[05:01:09] (PS1) Ejegg: Fix html_type on year rollup wmf_donor fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/186328 (https://phabricator.wikimedia.org/T86596) [05:05:34] (PS1) Ejegg: Allow Alipay donations in HKD [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/186329 (https://phabricator.wikimedia.org/T87045) [17:29:10] (CR) Katie Horn: [V: 2] Allow Alipay donations in HKD [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/186329 (https://phabricator.wikimedia.org/T87045) (owner: Ejegg) [17:37:12] (CR) Katie Horn: [C: 2] Allow Alipay donations in HKD [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/186329 (https://phabricator.wikimedia.org/T87045) (owner: Ejegg) [18:20:23] Today's Cat of the Day: http://goo.gl/cAMu2h [18:42:51] (PS1) Ejegg: Kill PayflowPro, part 1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186360 (https://phabricator.wikimedia.org/T86262) [18:43:21] (CR) jenkins-bot: [V: -1] Kill PayflowPro, part 1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186360 (https://phabricator.wikimedia.org/T86262) (owner: Ejegg) [18:54:44] hey pizzzacat! pregunta: you're not on the WP israel form yet, right? [18:57:11] hey AndyRussG whatcha doooin? [19:00:30] * AndyRussG is now embarassed ;p [19:02:40] no but I should do that today. [19:02:43] (atgo) [19:02:53] cool, thank you :) [19:02:58] I'm about to come into the office. there is too much construction going on below me. [19:03:06] it never ends [19:07:44] Gah. I can't believe what a mess the wr1 nightly is at this point. [19:07:52] It's... [19:08:22] Have you seen the Blues Brothers? [19:08:40] You know when all the individual pieces of the car fall off of all the other individual pieces at the same time? [19:14:22] https://www.youtube.com/watch?v=L8hX2Ex58os [19:15:58] marktraceur: That's exactly what I'm experiencing, yes. [19:16:15] Thank you. :) [19:16:17] I feel like that video link should probably be close by most of us, most of the time [19:16:22] * marktraceur bookmarks [19:16:24] seriously. [19:17:02] ejegg: Can you add another currency exception for the wr1 thingy? [19:17:13] (PS2) Ejegg: Kill PayflowPro, part 1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186360 (https://phabricator.wikimedia.org/T86262) [19:17:15] (PS1) Ejegg: Kill PayflowPro, part 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186377 (https://phabricator.wikimedia.org/T86262) [19:17:22] I mean, since you were just in there. [19:17:37] K4-713: Sure thing, boss [19:17:47] Thanks. :) [19:17:49] You can see the situation at the end of last night's failed job. [19:17:56] k, looking [19:18:01] Odd looking payment product, though. [19:18:05] Also, I looked it up. [19:18:19] Apparently, in Globalcollect, "PP" stands for "ewallet". [19:18:27] Obvs. [19:18:28] totally generic code [19:18:41] I filed it under "F". [19:19:26] F for Fantastic. [19:22:57] Right, totally. That must be it. [19:44:50] !log updated payments from 46bd1611c56d6e31594d01aa345c35dd45dcf676 to 4743b32c9091d6f2169bea3173e75aa5d2f36eb7 [19:44:58] Logged the message, Master [19:49:14] (PS1) Ejegg: Add another freaky Alipay audit exception [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/186391 [20:48:49] (PS1) AndyRussG: Test fixtures: standardize props on underscores [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186407 [20:56:00] ejegg: are deploys allowed today? wanna help me deploy a mini CN patch later today? schedule's wide open, I think I could from anytime after 2:30 pm [20:56:20] ejegg: also there's a selenium workshop all afternoon, about cross-browser testing [20:57:07] pizzzacat1: ejegg: K4-not-on-IRC: anyone have a USB drive they'd like me to erase all the data on? [21:00:06] sorry AndyRussG I don't have a usb drive :( [21:00:30] pizzzacat: Ah OK thanks NEway! :) [21:12:57] ejegg: https://gerrit.wikimedia.org/r/#/c/182074/ [21:42:44] (PS1) Ejegg: Kill PayflowPro, part 3 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186498 (https://phabricator.wikimedia.org/T86262) [21:45:26] ejegg do you know anything about formchooser? [22:00:45] pizzzacat: sorry, had irc minimised. I can probably answer some formchooser questions [22:14:39] (PS2) Ejegg: Kill PayflowPro, part 3 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186498 (https://phabricator.wikimedia.org/T86262) [22:14:41] (PS1) Ejegg: Delete lightbox form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186507 [22:16:59] Jeff_Green: taking another look at our problem SQL query [22:20:38] We're using less than 1% of the rows in geonames.altnames - might help to make a geonames.postcodes table with just the altnames that have format='post' [22:57:29] ejegg: I'm looking at https://gerrit.wikimedia.org/r/#/c/186391/, and I have a question. [22:57:53] Mostly about how that new weird record will look in civi. [23:03:20] K4-713: yeah, that is a good question [23:03:33] I guess we should ask if they have a substantial preference. [23:03:37] it'll probably pretend to be a bank transfer [23:03:38] I mean, I don't really care. :) [23:03:57] But, if they want it to show up as something they can track differently, we should set that up. [23:04:10] Yeah, it would be nice to know what is actually Alipay [23:04:25] It's... sort of a thing that's made up of other things. [23:05:13] Let me see if I can actually answer the question. :) [23:05:30] I mean, it's mostly like any other ewallet. [23:05:58] You can add funds to your account via a lot of different payment methods. [23:06:12] But, this is the first I've heard of the thing coming out the other side being... variable. [23:07:02] Also, I'm trying very hard to crash my browser right now. Just clicked review all side by side, on one of your PFP-destroying commits. [23:07:58] hehe [23:08:12] Somehow, it's okay. [23:08:13] definitely some batch editing there [23:08:34] ejegg: Did you by any chance talk to the-wub_ about renaming those i18n strings? [23:08:45] There's... possible fallout on donate wiki. [23:08:59] ah, good call [23:09:34] sorry, my 'what is actually Alipay' comment meant this: [23:09:45] it would be nice to know which donations actually came through alipay [23:10:43] This is... sort of tied up in "what is anything at all, really". [23:10:58] See also awight's notes about "refactoring" how we classify donations. [23:11:00] ejegg: is there a patch you'd like me to look at? or just a list of strings? [23:11:25] Ideally, we'd be able to record the thing as both alipay *and* direct debit. [23:11:28] Or not. [23:11:33] just a few strings [23:11:58] donate_interface-donate-click and donate_interface-accessible [23:12:18] Didn't you rename a bunch of things with "payflowpro" in them? [23:12:31] Or... am I hallucinating? [23:12:49] K4-713: I think the renaming was all HTML ids and classes, plus the css references to same [23:13:15] i18n I just killed a couple things that were payflow-related and not used [23:13:16] huh [23:13:21] Cool. :) [23:13:43] and replaced payflow with adyen in an api help example [23:13:58] I saw you even nuked it out of a comment. [23:14:05] Yaaaay [23:14:13] hasta la vista, payflow [23:14:15] I've been waiting a long time for this exorcism. [23:15:00] ejegg: How much actual testing did you do locally after these? [23:15:14] some... [23:15:27] I was just looking for... something non-zero. [23:15:45] let me just re-click all the stuff on my link list [23:17:00] hey pizzzacat i'm here to look at that form if you want... where you at? [23:17:25] atgo_ I'm on the couch behind the paper thingie but all I need is the link [23:17:50] I only got a screen shot [23:18:46] ejegg: okay, donate_interface-donate-click appears once on donate wiki, but it's in a template that isn't used any more (and I can't see us using it again) [23:18:57] donate_interface-accessible isn't used [23:19:10] thanks, the-wub_ ! [23:21:44] ejegg: I'm ready to go to the browser testing workshop NEtime [23:21:58] Woooo. [23:22:11] K4-713: wanna go to a browser testing workshop? [23:22:16] anyone else too? [23:22:22] Ah... nah, not that. [23:22:31] Hummmm [23:22:36] OK [23:22:36] I'm more interested in burning old code to the ground. [23:23:03] Also now that you're back on IRC I can ask if you have a USB drive that I can erase all the data on :) [23:23:06] But I believe you guys should totally go. :p [23:23:16] AndyRussG: How big? [23:23:22] not big [23:23:35] 222 MB [23:23:36] where is this going on AndyRussG ? [23:23:56] is that a new conference room? [23:23:58] jk [23:24:07] pizzzacat: it's in... one sec... [23:24:37] K4-713 how was karaoke? [23:24:42] pizzzacat: it's in chambers [23:24:43] It was rad. [23:24:56] AndyRussG: is it at 3:30? [23:25:08] I must've missed the invite [23:25:13] pizzzacat: it's like all afternoon, from 12 pm to 6pm. I think it's more like a drop-in clinic [23:25:19] I just found out by chance in fact [23:25:21] ohh [23:25:24] I'll invite u [23:25:29] I thought you were talking like it was now [23:25:38] oh [23:25:55] I am bad at reading [23:26:01] pizzzacat: check ur inbox [23:26:07] the invite should be thre [23:26:42] K4-713: so you're very sure I can erase all the data on Darth Vader? [23:26:44] hrm [23:26:51] AndyRussG: Yep. [23:26:52] Totally. [23:27:04] Somebody should. :) [23:27:05] um [23:27:21] you guys sound super powerful [23:27:32] It's a small Darth Vader [23:27:41] Or maybe we're *huge*. [23:27:53] But he'll use the dark side of the force to erase an operating system [23:28:04] Also: Size matters not. [23:28:05] pizzzacat: ejegg just bailed on the browser testing workshop, but I'm ready to go anytime [23:28:06] Dur. [23:33:43] https://www.mediawiki.org/wiki/QA/Selenium_Workshop [23:37:56] hey ejegg|away i've got a quick question if you're around [23:49:53] What's your question, atgo? [23:50:32] did you see pats' question about asking the donor for name & email through alipay? is there a reason we need to do that or could we simplify the flow? [23:50:42] "- There was also a question about why asking for name/email on the first page, if we could possibly get it back from Alipay... Could we possibly get rid of that first payment page?" [23:51:02] it would be a nicer experience, but i'm assuming that we need to send that to GC anyway [23:51:02] yeah, I saw that, but I don't think we get it back from them [23:51:07] cool, that's what i figured [23:51:45] yeah, all we get in the audit file is our reference number [23:52:45] K4-713: ejegg would it be catastrophic to do a quick 5pm meeting about audit stuff? [23:53:04] i can do 5pm [23:53:23] cool, thanks :)