[00:01:35] (PS2) Awight: WIP move token logic into a new class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187252 [00:03:09] (CR) jenkins-bot: [V: -1] WIP move token logic into a new class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187252 (owner: Awight) [00:03:55] CaitVirtue: uh, oh :) [00:04:04] how's the certifying? [00:13:58] @awight jeff's on a place, so we'll fix it tomorrow [00:15:52] ok, sorry about that [00:17:19] no worries [00:18:22] CaitVirtue: I can pull stuff for you if that makes sense? [00:18:43] atgo_: K4-713: cute photo alert. [00:18:56] :) [00:18:58] Truth. [00:19:11] <_< [00:19:36] @awight rosie's on it. thank you for offering though! :-) [00:19:59] CaitVirtue: whew! [00:20:10] thought you might call my bluff for a minute :p [00:21:04] @awight I'm saving up goodwill for other requests [00:23:55] hehe don't worry, it's already earning compound interest [00:25:10] :-) [00:30:57] (PS1) Ssmith: Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187297 [00:34:11] (CR) jenkins-bot: [V: -1] Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187297 (owner: Ssmith) [00:39:56] hey ccogdill - when did you say you were going to send emails? [00:40:03] is it now going to be when you're back? [00:40:19] we should manually push silverpop list as close to that as possible, i'd think [00:40:32] (CR) Awight: "@Siebrand: Sorry to let this go unanswered. It looks like you already figured out that the master page for translation is:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/165179 (owner: Siebrand) [00:40:49] atgo I think we are aiming to send tomorrow or friday [00:41:03] awight: ^ thoughts? [00:41:41] we have the phab task https://phabricator.wikimedia.org/T86822 [00:41:43] atgo: we seem to be good at the moment [00:41:47] lemme double-check... [00:42:01] I think it might be okay if we’re working with a list that’s only 2 days old [00:42:14] because we’re not actively campaigning [00:42:18] yeah [00:42:19] oof, no it's 2 days old, as you said [00:42:31] that will be different come Israel/Hungary [00:42:33] so awight it's working sometimes? [00:42:37] lemme just run a job manually and see if it succeeds. Unfortunately, I won't have an answer for an hour. [00:42:58] atgo: yeah, it failed for a week, then succeeded for a week [00:43:03] then broke this morning :-/ [00:43:07] and now is sad again [00:43:09] grumble [00:43:17] is this up to date? https://phabricator.wikimedia.org/T86822 [00:43:18] building manually... [00:43:54] atgo: I donno. We'd have to ask Jeff_Green or ejegg|away [00:44:33] I believe ejegg|away's patch did fix the zombie db queries, but didn't solve the root cause. [00:44:50] hmmm ok [00:45:55] atgo: fr-tech will get an email in an hour letting us know if the job completed. [00:46:31] thanks [00:48:20] (PS2) Ssmith: Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187297 [00:51:46] PPena: can you give me the report criteria for the reconciliation you're trying to do? [00:51:55] date range, gateways, currencies... [00:52:17] I think I can create a new report instance that gets around whatever is broken. [00:54:21] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186552 (owner: Ssmith) [00:55:27] (CR) jenkins-bot: [V: -1] Fix form width for consistent cross-device display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186552 (owner: Ssmith) [00:59:38] PPena: u there? [01:25:45] (PS3) Awight: Remove defaults for setup in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/185542 (owner: AndyRussG) [01:25:51] (CR) Awight: Remove defaults for setup in test fixtures (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/185542 (owner: AndyRussG) [01:25:58] (CR) Awight: [C: 2] Remove defaults for setup in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/185542 (owner: AndyRussG) [01:26:15] (PS2) Awight: Test fixtures: standardize props on underscores [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186407 (owner: AndyRussG) [01:26:35] (CR) Awight: [C: 2] Test fixtures: standardize props on underscores [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186407 (owner: AndyRussG) [01:30:43] (Merged) jenkins-bot: Remove defaults for setup in test fixtures [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/185542 (owner: AndyRussG) [01:30:45] (Merged) jenkins-bot: Test fixtures: standardize props on underscores [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186407 (owner: AndyRussG) [01:57:25] (PS3) Awight: WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 [01:57:49] (CR) jenkins-bot: [V: -1] WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 (owner: Awight) [17:48:43] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186498 (https://phabricator.wikimedia.org/T86262) (owner: Ejegg) [17:55:37] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186498 (https://phabricator.wikimedia.org/T86262) (owner: Ejegg) [18:19:22] K4-713: still hacking? [18:19:51] atgo: it's nice how we are the same height <:o) [18:20:00] yes, yes it is [18:20:01] no seat adjustment necessary [18:20:03] :) [18:28:25] hey AndyRussG [18:28:27] ! [18:28:44] atgo: Hi! [18:28:51] how was the trip home? [18:29:02] * pizzzacat1 feeling schizo [18:29:14] atgo: Great! Long but it's nice to be back :) thanks [18:29:16] pizzzacat: how are you? [18:29:20] atgo: but... Sadness!!!! [18:29:23] back in all the winter :P [18:29:26] I am fine [18:29:28] Verrry winter [18:29:30] thanks for asking [18:29:33] yeah i'm sad i didn't get to see you at all really while you were here [18:29:34] Hi pizzzacat1!!!!! [18:29:46] haha hi AndyRussG! [18:29:50] How's it going? [18:29:53] I was just having a conversation with pizzzacat [18:30:07] sometimes I like to check in on myself [18:30:18] atgo: me too... pizzzacat1: it's fun if one of you's on mobile and the other is on desktop [18:30:19] going great! how is Canada [18:30:25] Nice...! [18:30:37] But... sadness!!!!!!! because.... I lost my mug!!!!!!!!! [18:30:41] NOOOO!!! [18:30:43] ok wtvr pizzzacat [18:30:46] that's the sadnesssss [18:30:51] atgo: rrrrrrrrrrrrggg yeah that's the sadness [18:30:54] wtvr pizzzacat1 [18:31:08] I think it happend at the end of karaoke Tuesday evening [18:31:08] :( [18:31:10] wait, which mug? [18:31:16] aww yeah... but it's probably in the office? [18:31:17] FR mug [18:31:20] because... it should turn up [18:31:22] if that's the case [18:31:24] I saw a mug on the free table [18:31:28] but it's not a FR mug [18:31:29] haha pizzzacat [18:31:43] I could write Fundraising Tech on it [18:31:46] I went down to the 3rd floor to pick up my stuff that I'd left at my desk since I wasn't coming back the next day [18:31:48] pizzzacat: hahaha [18:31:52] and draw a little Honey logo [18:32:00] awwwwwww [18:32:01] That'd be better 'n nothing, yeah [18:32:06] pizzzacat: thanks [18:32:10] so wait, it's probably somewhere here in the office [18:32:13] email wmfsf? [18:32:19] or i can make a lap and look for it at some point [18:32:20] srsly [18:32:43] Then there I went back to the 6th, then and forth to the 3rd and 6th a bit, and now it's not in my bags now that I unpacked [18:32:59] atgo: I'll e-mail the list, yea good idea! thanks :) [18:33:14] pizzzacat: you're right. it is more distracty over here [18:33:45] I feel badly because you guys did suuch a great job about keeping it for me and getting it to me and I go and lose it right away :( I'm really sorry [18:33:48] it's so nice to hear you say that and know that I'm not just a complainey hallucinator [18:34:02] but yeah :( [18:34:13] Hallucinator? Hmmm [18:34:32] atgo: now imagine someone typing really hard and doing yoga next to you [18:34:35] :) [18:34:37] ha it's ok AndyRussG [18:34:46] atgo: ah thanks :) [18:34:56] it was late and there was like confusion over alarms etc [18:34:59] seriously i can make a lap and look for it at some point [18:35:10] it's ok pizzzacat, i have this; http://www.pandora.com/station/play/2462705016424186817 [18:35:27] haha whoaa [18:35:39] it's the best pandora station in the world. [18:35:41] it started playing over this ambient music I'm playing [18:35:43] it's amazing [18:35:51] atgo: I'll ask around a bit and let you know? don't want to be a remote distractor [18:35:57] :) [18:36:02] i'm between floors all the time anyway [18:36:21] AndyRussG: did you chat with awight at all about language variants while you were here? https://phabricator.wikimedia.org/T55641 [18:36:25] Ah OK, yeah if you do go upstairs for whatever reason, please do, that'd be fantastic [18:36:27] thanks [18:36:50] atgo: not yet, but I did just see some chatter about languages... I'll have a look!! [18:37:16] sure.. no worries right now. just jessicarobell and the-wub want to have a meeting about it next week and i was wondering if this would be in your court or awight's or..? [18:37:22] figuring out who to add to the mtg [18:38:06] atgo: Blah, missed your ping. Yes. [18:38:26] and AndyRussG should we invite someone from lang eng? [18:38:52] If it's CentralNotice-y I should be there, it'd be great to have Adam too or anyone doing DonationInterface... Though I can also go and summarize for the rest, if that's appropriate [18:38:58] atgo: In both the "coughing a lot" and the "doing things in code" senses, actually. :/ [18:39:11] haha i thought of that after i sent that [18:39:37] K4-713: hi! Hope your cough subsides.... [18:40:25] Thanks. :) [18:40:42] atgo: Do we need to meet about priorities today? [18:40:48] pizzzacat: you know what else it is? looking out the window is easier from there, so that's where my distracty mind goes [18:40:50] I feel like we just did that three times. [18:41:13] i think we can probably cancel, let me dig through notes and if there's anything i need to touch base about i'll let you know [18:41:24] Sounds good. [18:44:52] atgo: re language, I could look at the phab page and tell you after standup some clearer ideas about meeting attendees (I have an education program meeting in just a few minutes so no promises about doing that sooner) or if you want to put a tentative time on the calendar right away, that's also great [18:45:02] sure, i'm sending now [18:45:05] feel free to add whoever :) [18:54:50] hey ejegg, did you see the email ISRAEL tester? there's a question out to you... [18:54:51] Our rep at Worldpay had a suggestion to help mitigate the issue that we won't be able to search by name in Worldpay's console: we can send the transaction reference number with the authorization so that it shows up on the donor's bank statement. That way we can ask the donor for that bit of information if necessary. Is that something we could look into? [18:57:33] atgo: yeah, I saw the email but I have to look through the code a bit to see where we would put that [18:58:00] oh ok cool [18:58:07] thanks :) [19:05:28] atgo: you're distracted more in my desk area, or yours? [19:05:42] not sure [19:05:56] i'm actually doing ok now that the conference room people aren't being so loud [19:09:22] I seriously would love a pod [19:09:37] or like, in school, those desks with walls [19:09:52] I could spend hours in the library in college because of those and how quiet it was [19:18:53] pizzzacat: https://s3.amazonaws.com/images1.vat19.com/ostrich-pillow/ostrich-pillow-relaxation.jpg [19:20:46] K4-713: looks like underwear on head [19:20:58] * atgo snorts [19:21:14] How it looks... is beside the point. [19:21:18] ... [19:21:22] ...kind of. [19:21:52] needs to be much more menacing [19:22:06] http://www.studiobananathings.com/product/ostrich-pillow/?lang=en [19:22:18] I think you could easily draw angry eyes on. [19:22:21] just add a knight helmet with blacked out visor over that, and you won't get rolled wearing it on the T [19:24:28] hey awight! [19:25:12] how's things looking on the nightly audit & recurring stuff for AP? [19:25:42] K4-713: omg yes! [19:25:51] I have seen that before! [19:25:56] I need that, just, like, daily [19:26:01] all the time [19:26:02] (CR) Ejegg: "Looks good! Want to apply same fix to lines 506 & 646 too?" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/185206 (https://phabricator.wikimedia.org/T86686) (owner: Awight) [19:26:09] pizzzacat: If only there were a screen in there. [19:26:17] let's start a startup [19:26:22] ostrich screen [19:26:26] pillow [19:26:26] I was just thinking the same thing. [19:26:27] dot [19:26:29] io [19:26:32] :D [19:26:54] (CR) Ejegg: "oops, meant 546, not 646" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/185206 (https://phabricator.wikimedia.org/T86686) (owner: Awight) [19:27:00] Everybody will *need* one. [19:28:26] This could be a turning point in our whole society, actually. :p [19:29:16] but what about how it will mess up our hair? :-/ [19:29:31] It's okay. Inside the pillow, my virtual hair is amazing. [19:29:45] Constantly. [19:29:52] Unless somebody hacks it. [19:29:54] GOOD POINT [19:35:42] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186552 (owner: Ssmith) [19:36:58] criminy. Is that still going on? [19:37:28] Ah! Guess not. [19:37:32] And even after it passes, it's not submitting (e.g. https://gerrit.wikimedia.org/r/186498) [19:37:47] uff [19:38:40] Zuul says: "Jobs totals: 2 running, 1 completed, 0 queued" [19:38:42] uhm. [19:38:57] grr [19:40:26] Well, I think I'm going to eat something, and I may not come back immediately. [19:40:42] enjoy yr lunch! [19:40:48] I shall try. [19:41:13] Mostly, I'm going to eat as much ghost pepper as I can stand. Disguised as soup, or course. [19:41:35] This cold must be crushed. [19:45:11] (PS5) Ejegg: Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 (https://phabricator.wikimedia.org/T86945) (owner: Awight) [19:56:44] (PS4) Ejegg: Cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184844 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [19:59:11] (CR) Ejegg: [C: 2] Cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184844 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [20:02:54] (Merged) jenkins-bot: Cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184844 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [20:03:25] whew! what did I miss... [20:03:59] hi awight! [20:04:01] atgo-lunch: sure, I'll take a look at that [20:06:19] atgo-lunch: on second thought, I'm just gonna look at recurring. The audit thing is at an impasse. [20:06:50] rrr... I'll make a list of what I see as the viable alternatives. [20:30:14] awight: sounds good... whenever you get back to things :) [20:32:39] WTF--I cannot create a Phabricator project? [20:32:49] hi :) [20:33:06] no... it's a limited group [20:36:50] * awight continues shoveling :p [20:36:56] there's some lovely filth down 'ere! [20:37:15] atgo: we need a project for "fr tech testing", eh? [20:37:27] testing? [20:38:11] atgo: writing and integrating tests [20:38:29] "fundraising tech tests" would be better :) [20:40:25] wouldn't it make sense to have this live in the fr-tech backlog? [20:43:13] ok I'm going to go get a drink, I mean lunch, now [20:44:30] atgo: yes, and a specialized project as well [20:44:38] good luck pizzzacat [20:44:39] cos we can use them like tags... [20:45:21] i think we should talk about this with the whole team, maybe after stand up [20:47:46] atgo: did you see https://phabricator.wikimedia.org/T88012 [20:47:58] yeah [20:59:35] pizzzacat: i'm over by standup tv fyi [21:00:04] ok, coming shortly [21:01:08] atgo: I'm going to forego standup today, because talking. [21:01:36] Also, there's a bit of a situation going on. [21:02:50] yeah that's what i hear [21:04:29] (CR) Ejegg: [C: 2] "Redoing awight's +2 to kick gerrit" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186498 (https://phabricator.wikimedia.org/T86262) (owner: Ejegg) [21:05:32] I'd like to grab one bite to eat :) My standup is: planning to do AstroPay review wrap-up, listing what our alternatives are for audit file delivery, and writing them about a workaround for their recurring API. If I have time left in tha day, I'll nurse my poor DI refactor patches. [21:05:34] (Merged) jenkins-bot: Kill PayflowPro, part 3 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186498 (https://phabricator.wikimedia.org/T86262) (owner: Ejegg) [21:08:27] (Merged) jenkins-bot: Delete lightbox form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186507 (owner: Ejegg) [21:20:08] (CR) Ejegg: [C: 2] Fix form width for consistent cross-device display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186552 (owner: Ssmith) [21:20:33] (Merged) jenkins-bot: Fix form width for consistent cross-device display [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/186552 (owner: Ssmith) [21:32:54] atgo: Uh, momentary check in. [21:32:56] ? [21:32:57] How are we doing? [21:33:04] in.. what sense? [21:33:11] I dunno. Whatever. [21:33:37] As far as I can tell, all the exciting things that started happening as soon as I had warm soup, have stopped happening. [21:33:53] I wanted to make sure this was the case before I went to reheat my cold soup. [21:34:58] i have only heard of the things [21:35:02] they are not happening in any channels i am in [21:35:09] Okay then. [21:35:57] In that case, I'm going to actually eat now. :) [21:38:26] Was there a standup? I'm interested in what my dear comrades are up to [21:38:34] there was [21:38:40] blargh. k [21:39:02] awight ejegg K4|food any chance someone could kick the israel form out? [21:39:15] sure, I can [21:39:30] thank you! [21:39:45] awight: are we also in good shape to deploy the cleanup so far? [21:40:00] there aren't any cards in PD from cleanup [21:40:04] should there be? :) [21:41:26] just moved the payflow one there [21:42:09] but there are a ton of little cleanup patches that don't add up to complete cards [21:44:15] cool beans [21:49:23] atgo: just looked at the Phabricator page about the language variant issuze, I'll start looking into it. Hopefully it'll be straightforward [21:49:36] yeah AndyRussG there's no reason to jump on it right now [21:49:48] i bring it up because jessicarobell wants to talk about it next week, and kick off what needs doing [21:49:52] we should still finish what is in the sprint first [21:50:54] atgo: OK sounds good ;) [21:51:09] Should I assign it to myself in any case? (I don't see where to do that in Phab...) [21:53:50] sure! there are 2 ways [21:54:00] 1 - add yourself to the "assigned to" field when editing the task [21:54:37] 2 - go into the task and where you would write a comment, there's a dropdown that says "Reassign / Claim", and you can do it there [21:55:39] Gotcha! Nice, thanks [21:55:41] I can at least check it out a bit ahead of the meeting [21:55:53] ejegg: lemme look... [21:55:57] good question! [21:56:43] hmm, it looks a little bit exciting. [21:56:55] I'll be sure to grab my bucket of log popcorn [21:57:36] i've got to run to an appt... be back online around 4 for a bit [21:58:30] awight: last I tried to merge was just after 1dd7150 Don't feed the instructions results [21:58:39] and that was a bad place to deploy [21:59:49] but I think one of your subsequent patches gets it back to not exception-ing on invalid currency [22:15:42] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/187590 [22:16:18] This is an all-day deployment, I fear... ejegg: If you're curious, ^^ [22:16:28] yep, taking a look now [22:19:04] ejegg: confirmed that my deploy access is good! This is the way to do it, right? https://wikitech.wikimedia.org/wiki/Tin [22:19:38] yep, should be all set [22:38:47] awight: merge looks good [22:39:25] Oh good. I started testing it locally then got pulled in 4 directions [22:41:25] ejegg: awight: I'm looking at what patches to include to deploy for CN tomorrow. I see in Master we have changes to alterImpressions that I'd want to check are totally compatible with in-banner scripts, so I may just cherry-pick instead of merging all of master, depending... if that makes sense... So I'm leaving the "what" field on the wikitech deploy page unspecific for now [22:42:30] sounds good [22:42:37] :) [22:43:01] I always like leaving a little mystery :p [22:43:36] hehehe [22:44:58] awight: ejegg innocently agreed to help me with my first deploy tomorrow! do you want to also be included in the fun? It'd be a bit early PST, don't want to bother you with more distractions... [22:45:33] I'm trying to be on boppa duty tomorrow... have fun :) [22:47:07] Heh will do, enjoy!! [22:49:20] ejegg: all set: https://wikitech.wikimedia.org/wiki/Deployments#Week_of_27th [22:49:40] cool [22:51:25] Yeah... thanks! [22:51:37] * AndyRussG trembles in fear [23:08:34] PPena: where were you think we would use AstroPay, just in Brazil, or in all the countries they support? [23:13:47] I'm assuming mbeattie is the point person while ccogdill's away? [23:14:03] For spotting fires in Zendesk... [23:20:50] K4-713: ^^ waiting to deploy until I know someone is sitting by the donor red phone... [23:21:14] Er, you want to deploy something today? [23:21:18] right? [23:21:25] no i don't. but I agreed to :D [23:21:32] Hah. [23:21:54] and I bullied him into including everything [23:21:59] this is the Israel forms stuff. I had rolled a mergeball of everything, but w/o donor support, I think I'll just cherry-pick ;) [23:22:10] Yeah, that might be a good idea. [23:22:12] rats, i'll have to work on my bullying [23:22:16] lol [23:22:22] it's plenty threatening [23:22:28] you might want a little more tooth-baring [23:22:40] grr! [23:22:44] ooo [23:22:47] more gnashing [23:22:48] I mean, in theory, it's supposed to be Michael, but if he's not around I don't know how that would work. [23:22:56] * ejegg raises hands in a menacing dracula gesture [23:23:08] bahaha [23:23:09] yep, I emailed him but will now retreat to my sanctuary and deploy small thing. [23:24:04] Seems like a solid plan. [23:26:25] awight all LATAM countries [23:26:44] PPena: ok, thanks [23:45:49] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/187590 (owner: Awight) [23:46:07] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/187590 (owner: Awight) [23:50:28] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/187619 [23:50:49] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/187619 (owner: Awight) [23:59:24] !log updated payments from 4743b32c9091d6f2169bea3173e75aa5d2f36eb7 to ce73ed11de9775a596c51acdc036503751961bc8 [23:59:34] Logged the message, Master