[00:34:10] (PS1) Ssmith: Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 [00:35:20] hey awight! [00:35:24] and everyone else :P [00:37:10] hallooo [00:39:46] you assigned a task to me... do you need me to do something there? [00:39:54] it looks like we're waiting on AP response in both cases? [00:40:31] the audit thing is more up to us, but we need the response from them in order to have the full picture [00:40:40] ok [00:40:51] at which point i assume we'll need to connect with pats [00:41:10] thanks [00:41:16] I wasn't sure if I was accomplishing anything by assigning to you, I just wanted to emphasize that I'm done with my part there, and now it's a group discussion. [00:41:24] cool, thanks! [00:41:27] yep! [00:48:00] hrm, that's annoying--if tasks on a sprint board are past the fold, you have to move them up in order to promote to the next column. [01:30:25] dang, Chris Hedges is tearing it up on KPFA [01:53:40] (PS19) Awight: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) [02:16:33] (PS1) Awight: update civicrm submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/187639 [02:16:57] (Abandoned) Awight: update civicrm submodule [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/187639 (owner: Awight) [02:17:16] (PS1) Awight: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187640 [02:17:30] (CR) Awight: [C: 2 V: 2] update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187640 (owner: Awight) [02:17:32] (Merged) jenkins-bot: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187640 (owner: Awight) [02:18:59] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/187641 [02:19:21] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/187641 (owner: Awight) [02:19:23] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/187641 (owner: Awight) [02:20:10] !log updated crm from a6b28d0a5e90f7ca68988a15f311465bbb5ae5e6 to ff28f69392fdab74520bf94e4a46586637914480 [02:20:26] Logged the message, Master [02:22:43] (PS1) Ejegg: Add contribution tracking to Worldpay CC statement [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187642 (https://phabricator.wikimedia.org/T88060) [02:32:08] (CR) Ejegg: [C: 2] "Nice!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) (owner: Awight) [02:32:23] (Merged) jenkins-bot: Move more validation out of GatewayPage and into the adapter. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) (owner: Awight) [02:38:19] (CR) Awight: Move more validation out of GatewayPage and into the adapter. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/63823 (https://phabricator.wikimedia.org/T86249) (owner: Awight) [02:54:37] (PS1) Ejegg: Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 [02:54:57] bye! [14:08:14] Wikimedia-Fundraising: https://payments.wikimedia.org is not up to date with the TLS settings used - https://phabricator.wikimedia.org/T78160#1004238 (Jgreen) a:Jgreen [14:09:52] Wikimedia-Fundraising: https://payments.wikimedia.org is not up to date with the TLS settings used - https://phabricator.wikimedia.org/T78160#837194 (Jgreen) [15:30:03] morning ejegg|away! [15:30:29] Mmm I was wondering if we could maybe start a little later than planned... got some issues here [15:31:06] Specifically, wife and older daughter are both sick, and my cat did her business under my desk and I stepped in it and spread it all over the hallway :( [15:31:51] hi AndyRussG [15:31:59] later start is fine with me [15:32:03] Ehm hey [15:32:05] Thanks!!! [15:32:24] sorry to hear about all the sickness & mess [15:32:25] * AndyRussG types while standing sideways to avoid standing in the wrong spots.. [15:32:35] Heh it happens 8p thanks [15:49:15] Heh, now that's all fixed :) [15:49:25] * AndyRussG checks between toes [15:49:26] jk [15:49:48] all set to go? [15:49:54] ejegg: I was thinking we might even push it back a full hour, 'till 11:30, actually [15:49:58] Might that be OK? [15:50:06] yep, definitely [15:50:09] Thanks [15:50:30] (I still have to call the pharmacy, the school, etc etc) [16:34:04] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/187692 [16:34:29] ejegg: ^ here's the merge to the deploy branch... [16:34:32] * AndyRussG is a disaster... [16:36:58] ejegg: ready for a video call? [16:37:21] hi [16:37:24] one sec [16:38:59] ok, ready [16:39:24] cool thx! [16:41:36] K I'm in the call, I think my sound is working, not sure... [16:41:42] Yes it is [16:46:44] (CR) AndyRussG: [C: 2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/187692 (owner: AndyRussG) [16:47:22] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/187692 (owner: AndyRussG) [16:51:52] https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Updating_the_submodule [16:54:11] https://gerrit.wikimedia.org/r/#/c/187693/ [17:06:25] https://wikitech.wikimedia.org/wiki/Help:SSH_Fingerprints/gerrit.wikimedia.org:29418 [17:15:57] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1004381 (ellery) Here is a slight design constraint for sampling impression data: to do valid hypothesis testing , we need to know how many of the impressions we... [17:21:46] http://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap [17:34:31] Take ur time! :) [17:59:25] (PS1) Ejegg: Revert "Merge branch 'master' into wmf_deploy" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/187705 [18:00:59] atgo: just rolling back the CN deploy [18:01:04] aww [18:01:08] que paso? [18:01:09] (CR) AndyRussG: [C: 2] Revert "Merge branch 'master' into wmf_deploy" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/187705 (owner: Ejegg) [18:01:27] not sure, but we couldn't see any banners on mediawiki.org [18:01:53] (Merged) jenkins-bot: Revert "Merge branch 'master' into wmf_deploy" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/187705 (owner: Ejegg) [18:01:58] oh yeah, that does seem like a problem [18:02:01] :P [18:06:27] ejegg: are you going to be able to join the meeting? [18:07:36] just one more minute, atgo [18:07:38] AndyRussG: found your mug :) [18:19:02] atgo: fantastic, thanks so much!!!!! apologies again for the absent-mindedness [18:19:29] no worries :) [18:19:34] i can have it shipped to you? [18:40:07] atgo: Heh sure that'd be really fantastic! :) [18:40:47] Sorry for the delay, I was just reverting our CN update that didn't work (fortunately we only sent it out to mediawiki.org and a some test wikis) [18:40:56] no worries, sorry it didn't work out there [18:41:02] was that just the round trip thing? [18:41:14] atgo: mainly, though there were other changes rolled in there too [18:41:34] not sure which was the culprit, glad for ejegg testing-minded prudence [18:41:54] ejegg: all reverted, POTY banner is showing on mediawiki.org again! [18:42:04] OK, cool [18:42:09] I wonder what it was... [18:42:34] ejegg: it was something that was merged from master, yea not sure... [18:42:36] maybe more local testing of the merged branch next time [18:42:48] it's working on the beta cluster [18:42:56] which is up to date with master [18:43:15] hmmm [18:43:30] diffing what we deployed with master... [18:46:24] weird - there seem to be a lot of differences [18:46:28] oh wait [18:47:34] ok, so the only difference is a newline at the end of a file [18:47:39] dang [18:47:57] ejegg: here on wmflabs you can see the banner at the top of the page ("one", "two" or "three") [18:48:19] and I just verified it's on the new code, can see it in the debug on the browser [18:48:23] yep, there it is [18:48:26] http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?debug=true [18:48:47] Maybe something specific about the banner run by POTY? [18:49:41] Oh, do the changes in the displaying wiki depend on changes in the controlling wiki? [18:51:18] ejegg: nope [18:52:08] ejegg: I gotta do domestic take-care-of-sick-family stuff for a bit! Thanks again for ur help!!! back soooonish... [18:52:24] ok, best of luck with all that stuff [18:56:07] ejegg: thanks! I think since we're reverted and were ever only on mediawiki.org and test wikis, it's OK if I leave the computer for a little while, right? does that make sense? [19:01:33] for sure [19:08:26] guys! this looks slightly better! https://phabricator.wikimedia.org/sprint/view/1004/ [19:08:51] still have work to do, but yay [19:14:36] hey ejegg - just saw your email and patch to get the contribution tracking ID into the WP field [19:14:50] wondering, since it seems that awight is out and k4 definitely is, there's no way this is going to go out today, right? [19:18:25] probably not [19:21:07] cool. thank you [21:08:05] ejegg: standup time? :) [21:15:23] oops, sorry! [21:46:10] (CR) Ejegg: "Some comments and questions inline. I'll put up a board retrieval patch that might make it easier to get all the widget info you need." (7 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 (owner: Ssmith) [21:54:54] thanks ejegg! [21:56:21] yw! [21:58:10] (PS1) Ejegg: Don't die when log message is missing user [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187817 [22:10:37] (PS1) Ejegg: Retrieve widget code with instance data [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187819 [22:11:23] pizzzacat: there's the patch to make board-building a bit easier ^^ [22:16:30] hey guys - i'm heading home to finish from there. see you in a bit or maybe monday if i lose you :) [22:16:34] if so, have a lovely weekend! [22:16:52] thanks, you too! [22:20:46] oh, ok thanks ejegg