[14:38:58] Wikimedia-Fundraising: Enable HSTS on https://payments.wikimedia.org - https://phabricator.wikimedia.org/T88199#1008244 (Jgreen) p:Triage>Normal [18:42:22] Wikimedia-Fundraising-CiviCRM, Wikimedia-Fundraising: Improve documentation and new file format workflow for offline imports - https://phabricator.wikimedia.org/T88307#1008796 (awight) NEW [18:53:09] ejegg: hey... are you planning a DI deploy today? I just saw https://gerrit.wikimedia.org/r/#/c/187642/ [18:54:05] Oh yeah, guess I should! [18:54:32] checking deploy list [18:54:37] wait no [18:54:46] right... no need :) [18:54:50] to post there [18:55:15] sorry, must have been that bump on the head while sledding! [18:56:02] haha sounds fun [18:56:10] are you still under a blizzard? [18:56:28] yeppers, another foot or two falling today [18:56:42] I'm shedding layers here... a T-shirt is almost too much if it were not for modesty [18:56:45] hehe. [18:56:58] well, lmk when you're ready to relocate :p [18:57:18] I decided certain occupations such as sitting still all day are not best done in the cold [18:57:20] tempting [18:57:37] there's lots of unpaid side work available here ;) [18:57:58] heh. Did you finish that gate system? [18:58:17] Yep, finally finished installing the dog labyrinth on Saturday... I'm really relieved to be giving away the welder, etc. [18:58:31] I started thinking of it as some sort of contrapositive dowry... [18:58:38] what? Who's getting it? [18:59:01] oh right, m's dad [18:59:05] I gave it to father-in-law years ago, yep [19:00:56] I'll have to pester someone who does online banking to test that NarrativeStatment1 field [19:02:41] My rationalization of this being a dowry is that I give him a gift which disabled me from doing this work which doesn't pay--hence enabling myself to support his daughter. [19:03:05] heh, sounds logical [19:03:44] playing with lightning is so much fun [19:05:43] (PS2) Awight: Add contribution tracking to Worldpay CC statement [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187642 (https://phabricator.wikimedia.org/T88060) (owner: Ejegg) [19:05:52] (CR) Awight: Add contribution tracking to Worldpay CC statement (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187642 (https://phabricator.wikimedia.org/T88060) (owner: Ejegg) [19:06:03] (CR) Awight: [C: 2] Add contribution tracking to Worldpay CC statement [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187642 (https://phabricator.wikimedia.org/T88060) (owner: Ejegg) [19:06:10] enjoy :) [19:06:25] (Merged) jenkins-bot: Add contribution tracking to Worldpay CC statement [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187642 (https://phabricator.wikimedia.org/T88060) (owner: Ejegg) [19:07:13] Ahh, yeah, might be too long. [19:08:19] I thought that statement might appear instead of the vendor name [19:08:40] but docs suggest it's supplemental [19:09:40] hrmph [19:09:59] Unfortunately, it's the least-significant digits that matter [19:10:19] but we could report "123456-WMFCT" or something to really be sure the number gets in there [19:10:19] we could reverse it :) [19:10:25] hehe you would [19:10:35] I think we're fine just trying this, though? [19:10:50] gotta start someplace. [19:11:18] I wonder if there are rules about how many characters are supposed to be reported on yr statement... [19:11:30] WP docs say it varies by bank [19:12:04] I believe it [19:12:10] like 0-1,000 [19:16:22] (PS1) Awight: Minutely improve multiselect load issue [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188098 (https://phabricator.wikimedia.org/T74421) [19:16:27] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/188099 [19:17:49] MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising: Multiselects in Special:CentralNotice sometimes load incorrectly - https://phabricator.wikimedia.org/T74421#1008975 (awight) [19:18:12] wikibugs: help [19:18:38] awight: I see you have a 'fix and continuation' of https://gerrit.wikimedia.org/r/63823/ . Serious enough to avoid deploying the first one right now? [19:19:17] uh, oh [19:20:34] oh, fix was maybe just deleting the @param matching the argument you removed [19:21:09] ejegg: yeah, sadly I don't see any actual fixing... [19:21:28] cool, out the door it goes! [19:21:59] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/188099 (owner: Ejegg) [19:25:37] hehe, sorry you just tricked yourself into deploying the patchball... [19:25:56] pretty small patchball [19:26:13] oh? hrm I thought I cherry-picked on Thurs [19:26:14] since you shoved the massive one out last week [19:26:17] ok whew! [19:26:29] I erased all of last week over the weekend :) [19:26:57] superbowl party, right? [19:27:01] j/k [19:27:03] nah, the install [19:27:25] plus visiting a commune... many gear shifts [19:27:42] ooh, cool. How'd it look? [19:27:52] tricky situation. [19:28:03] dang [19:28:06] 2 years out at the least [19:37:29] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/188104 [19:38:24] (CR) Ejegg: [C: 2] Update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/188104 (owner: Ejegg) [19:39:36] * AndyRussG waves [19:40:09] ejegg: did you find any clues as to our deployfail last week? I still haven't found the cause [19:40:32] no, not at all [19:40:50] Hummmm OK thanks :) [19:48:50] (CR) Ssmith: "comments inline." (5 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 (owner: Ssmith) [19:59:30] !log updated payments from ce73ed11de9775a596c51acdc036503751961bc8 to 1e9b78e9a8bf557a710988620bd6f1a335787173 [19:59:37] Logged the message, Master [20:05:04] atgo: https://civicrm.org/make-it-happen [20:31:59] ejegg: found it! you were totally right, it was an ishyew with the subscribing and the infrastructure wiki being on different versions! [20:40:12] ejegg: awight: for deploys, we're able to push things out separately to group 0, 1 or 2, correct? http://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap [20:45:02] AndyRussG: it must be possible, but I haven't done it yet [20:45:14] ejegg: Hmm OK thx [20:45:26] AndyRussG: yes, you can [20:45:37] awight: ah cool thx! [20:45:45] AndyRussG: just watch out for the automatic promotion [20:45:55] Yeah exactly I wuz thinking [20:46:21] I'll cherry-pick just the change we need to have on meta in order to roll out everything else on some test wikis [20:46:37] u got it, then. Yeah e.g. if you merge to wmf15, it will be a manual deployment today, but the other groups will be deployed with the train on Tues and Wed [20:46:50] And so the cherry pick we can send to group 1 [20:46:55] meta is in group 1, right [20:46:56] ok [20:47:29] AndyRussG: I see what you're saying. It might not work, actually [20:47:35] ? [20:47:41] we can't push to groups independently, we can only manage the branches [20:48:03] so you can deploy to wmf14 and wmf15, which will impact wiki groups according to that roadmap [20:48:12] you can't go onto tin and say, update only group 1? How does the train run? [20:48:16] right [20:48:17] Some seekret sauce? [20:48:20] coal [20:48:35] cos we aren't in charge of associating each wiki group with a release branch [20:48:35] No wonder we're outdated and smelly [20:48:38] hehe [20:49:06] Ah OK I see, right I think ejegg had already explained this, sorry [20:49:22] Yeah each server in the cluster knows which version its wikiz are on [20:49:41] Well, if we commit into wmf15 today, we should get the same result then [20:49:55] is deploying to betameta good enough? [20:50:18] We have a change in the pipeline that has to be coordinated on infrastructure and subscribing wikis [20:50:31] oooh [20:50:34] It has to be on meta before we roll anything out elsewhere [20:50:45] that sounds like you might need to fix the code [20:50:53] control its expression via configuration [20:51:05] awight: naw it's not that grave [20:51:15] Wikimedia-Fundraising: Enable HSTS on https://payments.wikimedia.org - https://phabricator.wikimedia.org/T88199#1009389 (Dzahn) what you need for this: - ensure mod_headers is loaded in Apache - a config line like: Header set Strict-Transport-Security "max-age=31536000" before we did this on other service... [20:51:16] The code isn't broken, it's just confused [20:51:46] well, you probably want to put this behind a config variable anyway, cos--imagine rolling back the change! [20:52:59] (PS1) AndyRussG: Remove unused banner variance parameters [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/188121 [20:54:48] (CR) AndyRussG: "Cherry-picked from master because we need this on Meta in order to roll out a more general update anywhere else on production." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/188121 (owner: AndyRussG) [20:55:04] ejegg: awight: ^ [20:55:12] now I'm snooping around your change :) crap, it's my change. [20:55:19] awight: what do you mean about rolling back? [20:55:24] awight: it was and is a fine change [20:56:08] AndyRussG: that if you have a dependency like meta needs to be rolled out first, what's your contingency plan for reverting the change if it doesn't work? The subscribing wikis will have to be reverted first? [20:56:09] I should have thought about the coordination issues. Before this change, the server requires all the old params on Special:BannerLoader [20:56:31] Sounds like we should split the commit into two pieces [20:57:31] awight: wouldn't it be just the normal revert procedure? revert on wmf_deploy, then update the submodule in the core wmf15 branch and push that out everywhere it goes? [20:57:53] It's OK if the subscribing wikis are on the old code and meta is on the new code [20:58:03] but, then we have the server still requiring the extra params, and cached clients have the stripped down js [20:58:16] The problem is when the subscribing wikis are on the new code and the server is on the old [20:58:26] I think we should deploy the server side patch, then wait an hour before rolling out client side? [20:58:51] Only meta is requiring the old params, Special:BannerLoader is only ever called on meta, no? [20:58:53] also, that will make it simple to revert the client side code independently [20:59:01] yep [20:59:16] I see what you mean about caching tho [20:59:41] I'm happy to do that, especially since I made the mess :) [21:02:24] Mmm OK yeah sorry I didn't get the issue about cached clients you mentioned above ^ so sure, let's split it in two bits then... I guess we can gerrit them directly on the wmf_deploy branch [21:02:36] ok standing... [21:02:53] it's better to revert and put split patches on master... [21:03:07] Ah OK I see [21:03:25] Right, revert the whole patch on master, then add them again as two separate patches [21:03:28] Sounds cool! [21:03:32] If you feel like doing it, that's also cool, if you've nothing more urgent... Though I'm sure you have :D [21:17:33] AndyRussG: if you haven't started, yes I can do ^^ [21:21:29] (PS1) Awight: Revert "Remove unused banner variance parameters" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188131 [21:24:41] awight: ah OK thanks, I was gonna say it does sound like you have a lot of stuff on your plate right now :D feel free to leave it halfwaydone [21:24:48] gotta run to skool [21:25:00] (PS1) Awight: Server side: don't require unused banner variance params [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188144 [21:25:02] (PS1) Awight: Client side: don't send unused banner variance params [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188145 [21:25:09] AndyRussG: see ya! above patches should do the job. [21:25:33] awight: thanks! [21:25:43] least I could do! [21:31:32] (CR) Awight: [C: -1] "Looks like we're not conforming to the established typos :)" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187817 (owner: Ejegg) [21:35:39] I haven't been able to close the tab with this in it, all morning. [21:35:40] http://i.imgur.com/bBdo8Hm.gif [21:36:05] oh no, it's stuck on my phone now! [21:36:12] You're welcome. [21:36:23] anything that ends in .gif is OK in my book [21:36:39] I can think of a couple key exceptions, but... mostly. [21:38:45] Jeff_Green: You're not still stuck here, are you? [21:38:54] ha no [21:38:58] getting snowed in again [21:38:58] Whew. [21:39:05] That sounds nice. [21:39:12] Well... if you have enough cocoa. [21:39:28] my original flight made it out on time, and the storm we're having now has already dumped twice what the last one did [21:41:11] sharks! [21:48:43] (PS2) Awight: Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg) [21:48:49] (CR) Awight: [C: 2] Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg) [21:58:06] (PS11) Awight: WIP Adapter is not always initialized with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64345 [21:58:10] (CR) jenkins-bot: [V: -1] WIP Adapter is not always initialized with data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64345 (owner: Awight) [21:58:27] (PS2) Awight: protect findAccount in case there is no -AccountInfo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/95873 [21:59:16] (Abandoned) Awight: PayPal does not use a resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/105731 (owner: Awight) [21:59:18] (CR) jenkins-bot: [V: -1] Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg) [22:00:11] (Abandoned) Awight: move getGatewayClass into GatewayAdapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64873 (owner: Awight) [22:01:59] (Abandoned) Awight: getGlobal can be called for multiple adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/64874 (owner: Awight) [22:06:55] (PS6) Awight: Wipe out credit card validations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184847 (https://phabricator.wikimedia.org/T86945) [22:08:54] (PS3) Awight: Killall original_ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164393 [22:15:07] (CR) Awight: "TODO: precede with a patch to test success and error workflow for each adapter." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 (owner: Awight) [22:17:09] (PS4) Awight: WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 [22:17:24] (CR) jenkins-bot: [V: -1] WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 (owner: Awight) [22:20:38] (PS5) Awight: WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 [22:20:40] (PS2) Awight: New PaymentResult class for passing user interaction hints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 [22:20:42] (CR) jenkins-bot: [V: -1] WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 (owner: Awight) [22:20:58] (PS3) Awight: New PaymentResult class for passing user interaction hints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 [22:22:09] (PS6) Awight: WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 [22:24:43] (CR) jenkins-bot: [V: -1] WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 (owner: Awight) [22:26:59] (PS7) Awight: WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 [22:27:15] awight: pp and i are upstairs :) [22:27:17] (CR) jenkins-bot: [V: -1] WIP factor controllers, take 2 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185599 (owner: Awight) [22:27:21] atgo: headed! [22:33:59] awight: Did we ever decide why all the crm tests were failing on my local? [22:34:17] You... burned yours to the ground and started over, didn't you? [22:34:33] The amnesia is lifting. [23:56:04] (PS3) Katie Horn: Delete bad references [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/185206 (https://phabricator.wikimedia.org/T86686) (owner: Awight)