[00:40:47] (PS3) Ssmith: Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 [00:42:20] (CR) jenkins-bot: [V: -1] Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 (owner: Ssmith) [17:32:48] (CR) Ejegg: "Looking pretty good! Just a couple little things" (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 (owner: Ssmith) [17:42:13] (PS2) Ejegg: Don't die when log message is missing user [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187817 [17:42:36] (CR) Ejegg: "thanks for catching that. gotta love PHP!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187817 (owner: Ejegg) [17:43:03] (CR) Awight: [C: 2] Don't die when log message is missing user [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187817 (owner: Ejegg) [17:43:06] (Merged) jenkins-bot: Don't die when log message is missing user [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/187817 (owner: Ejegg) [17:44:09] (CR) Ejegg: [C: 2] Killall original_ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164393 (owner: Awight) [17:44:33] (Merged) jenkins-bot: Killall original_ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/164393 (owner: Awight) [17:53:28] awight: Hey, we should probably go now for checking in. [17:53:45] We seem to be always going way over, and there's a thing at 10:30 I shouldn't miss completely. :) [17:53:47] got anything I should bring before the scrum of scrums? [17:54:28] ejegg: Seems like our PCI stuff is moving well. Let's see... [17:54:55] awight: are you getting what you need on the CRM CI ? [17:54:56] I can't think of anything else that would impact other people, other than our ongoing assessment of the RecordImpression situation. [17:55:23] right, I'll at least mention we're looking at that [17:55:28] Cool. [17:55:30] kbye. [18:33:05] ejegg: sorry for the late. no, hashar said something like he might be able to get to this in a few months. [18:34:30] ah, cool [18:34:49] i mean, not cool, but I guess it won't help to complain in SoS [18:35:05] prolly not [18:42:57] YOU GUYS I GOT MY STASH BACK!! [18:43:07] 'stache? [18:43:09] holy cow, what was the trick? [18:43:12] haha [18:43:21] yeah you might want to trim it now that it's been under the furniture [18:43:24] so luckily I had my terminal still open [18:43:34] omg you copy n pasted the diff? [18:43:38] and there is a pop ID associated with your stash when you do a stash pop.... [18:43:45] so I created a new branch with that [18:43:49] and voila! [18:43:51] badass. [18:43:59] so easy. [18:44:02] yaay [18:44:44] yay pizzzacat!! [18:57:18] awesome! [19:03:13] K4|wandering: hehe btw all the stuff in the sprint I vaguely remembered having my name on it are actually DI refactor tasks I added. [19:21:38] (PS1) Ssmith: WIP stash recovery omg do not review [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188608 [19:21:55] (CR) jenkins-bot: [V: -1] WIP stash recovery omg do not review [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188608 (owner: Ssmith) [19:26:13] awight isn't there a way to run jslint locally? [19:26:32] (I should probably be doing that already but I haven't been) [19:27:23] pizzzacat: yeah... [19:27:34] um in dash, grunt should do the trick [19:27:50] i think you can globally install jshint via npm too [19:28:05] i just typed jshint and it didn't say it wasn't a command [19:28:10] but it didn't say anything else. [19:28:23] I get confused when there's no feedback #ux101 [19:28:49] yeah the jslint tools are a pita to run directly [19:29:23] womp womp [19:30:40] pizzzacat: this work? ./node_modules/gulp/bin/gulp.js lint [19:31:38] it does, if the object is to receive garbage errors that don't help anything [19:32:13] pizzzacat: that's odd, it returns clean for me [19:32:15] (PS4) Ssmith: Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 [19:32:19] (CR) jenkins-bot: [V: -1] Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 (owner: Ssmith) [19:32:26] hehe lemme try that patch, then [19:32:27] let's see [19:32:57] hah no complaints on that one either [19:33:13] one moment please, I did this homework a few months ago... [19:33:48] let's see if that worked [19:33:50] (PS5) Ssmith: Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 [19:34:00] yeah. [19:34:03] *shrug* [19:34:29] that patch is probably ready for merge [19:34:40] you know since it's on patch set 4,899 [19:37:30] I donno, this should do the job but just hangs, ./node_modules/gulp-jshint/node_modules/jshint/bin/jshint . [19:45:22] anyone have time for https://gerrit.wikimedia.org/r/#/c/187628/ ? [19:45:50] (PS1) Awight: ignore more stuff so jshint can be run from a dev instance [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188615 [19:46:07] looking [19:46:12] pizzzacat: now you can just type "jshint ." ^^ [19:46:22] ooh thank you! [19:46:28] looking at your patch awight [19:46:32] thanks ejegg :) [19:46:40] * awight sprays down console with coolant [19:46:54] (CR) Ejegg: [C: 2] "helpful!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188615 (owner: Awight) [19:46:58] I got an error for everything wrong with node and bower modules :) [19:48:01] (CR) Ejegg: [C: 2] Add generic board functionality & update sql [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/187628 (owner: Ssmith) [19:48:53] yaay [21:04:21] pizzzacat: hey... split this cakeito with me [21:04:28] doo it [21:04:32] fudpcure? [21:04:42] procurement of food is not a crime [21:04:47] i see [21:04:57] <_< [21:04:58] >_> [21:06:52] oh man [21:06:59] oh, i thought it was like an epicure, but not so picky [21:07:13] maybe in a bit…I was already not hungry when I ate that lunch just now :-| [21:11:16] not the first time I've pasted my password into Google x-x-x [21:21:56] hey ccogdill have you seen any WP transactions come through with the CID in the bank statement? [21:22:14] we haven’t gotten any confirmation from donors about that yet, no [21:22:48] because we haven’t run into any successful donations we couldn’t find through using the email address as the search parameter [21:22:59] so there hasn’t been a chance to ask yet :) [21:23:00] Wikimedia-Fundraising-CiviCRM, Wikimedia-Fundraising, Labs: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1015947 (awight) NEW [21:23:35] ccogdill: if there is an opportunity to ask, I'm very curious whether our text fits on a statement or needs abbreviating [21:24:14] okay. it’s just not something that really comes up, ejegg :/ maybe we should ask if one of our Israeli colleagues are willing to help again? [21:24:38] ccogdill: if it's not too much trouble, that would be great [21:24:47] okay, I’ll ask around [21:25:01] Wikimedia-Fundraising-CiviCRM, Wikimedia-Fundraising, Labs: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1015967 (awight) [21:25:09] better to learn that way than finding our we've been truncated on something we couldn't find otherwise [21:25:28] definitely [21:25:29] ejegg: what was the approx deployment date? [21:25:29] i mean, couldn't one of us make a donation? [21:25:50] i tried but minfraud bounced me. i'm following up with them to see why [21:25:50] (to help narrow list of victims) [21:25:53] atgo: yeah, I just don't have online statements, and yours didn't go through [21:26:02] ah. grumble. [21:26:09] my card w/ online statements was cancelled last week :) [21:26:10] awight: Monday [21:26:15] ok cool [21:26:21] hey awight could you put estimates on the 2 tasks here: https://phabricator.wikimedia.org/sprint/board/1036/ [21:26:25] ccogdill: ^^ [21:26:36] awight: nice ha [21:26:41] can I make one? I figured there would be IP issues but I have online statements if that’s the only thing getting in the way [21:26:52] yeah ccogdill it should work [21:27:20] okay let me give it a try [21:27:59] well the donation worked! [21:28:10] nice! [21:28:42] thanks awight [21:28:58] Wikimedia-Fundraising-CiviCRM, Wikimedia-Fundraising, Labs: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1015973 (awight) [21:31:04] (Abandoned) Ssmith: WIP stash recovery omg do not review [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188608 (owner: Ssmith) [21:31:07] ejegg I don’t think it worked... [21:31:27] this is all I see: PURCHASE DONATE@WIKIM NON PROFIT US CA [21:31:36] and then the last 4 digits of my card number [21:31:38] you donated via worldpay,right? [21:31:41] yeah [21:31:48] I see it in the worldpay console [21:32:18] do you know where the field is supposed to be on Worldpay’s side? is it a customer or card id? [21:32:52] They've got a field called NarrativeStatement1, which is just supposed to help explain the charge on the donor's CC statement [21:33:06] I don't know if they hang on to it in their own system [21:33:36] hmm. we need it to be in worldpay somehow [21:33:40] otherwise it doesn’t do us any good [21:33:59] but it doesn’t seem like it’s showing on my statement anyway [21:34:14] I was just using "Wikimedia Foundation donation # XXXXX" [21:34:21] where XXXX was the ctid [21:34:27] ohh [21:34:41] okay I guess that is helpful :) maybe it’s just too long [21:34:54] I'd have expected at least a few characters of it though [21:34:58] could we reduce it to just the number? or like Wikimedia XXXX [21:35:26] yep, most definitely. [21:35:42] yeah I guess it actually seems like it’s not getting pushed through on the statements correctly, though. do you think this is something we should ask WP for help with? [21:36:04] yeah, I'll email them [21:36:08] those docs are pretty old [21:36:20] okay. they weren’t very perscriptive in their suggestion to me, either [21:39:38] ccogdill: do you have the original email where they suggested putting the ref # on the donor's CC statement? [21:42:59] (CR) Ejegg: [C: 2] Kill "original_" [wikimedia/fundraising/PaymentsListeners] - https://gerrit.wikimedia.org/r/164390 (owner: Awight) [21:43:30] (CR) Ejegg: [C: 2] kill original_ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/164394 (owner: Awight) [21:43:35] (Merged) jenkins-bot: kill original_ [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/164394 (owner: Awight) [21:43:37] (Merged) jenkins-bot: sort fields [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/164395 (owner: Awight) [21:44:09] (PS3) Awight: Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg) [21:47:08] ejegg sorry about that - had an OIT thing for a minute. I just forwared you an email from Kevin at wp@ [21:47:08] (CR) Awight: [C: -1] "Looks like this one should be abandoned, now." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/188121 (owner: AndyRussG) [21:48:38] ejegg: you want the sampling patch https://gerrit.wikimedia.org/r/#/c/188394 merged, or do you have a more subtle deployment plan? [21:48:50] (Abandoned) AndyRussG: Remove unused banner variance parameters [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/188121 (owner: AndyRussG) [21:48:58] Hmm, maybe I should -1 that for now [21:49:00] * awight waves at AndyRussG [21:49:10] ejegg: or -2 if you really want to throw a stick in the spokes [21:49:38] * AndyRussG friendly-throws a snowball at awight [21:49:51] I think analytics is about totally ditch udplog for pulling stuff from hive [21:49:53] (CR) Awight: [C: 1] "Waiting to merge until the BANG!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188394 (https://phabricator.wikimedia.org/T45250) (owner: Ejegg) [21:50:02] ejegg: haha [21:50:06] well that sounds slow [21:50:15] what's their suggestion for working around the 6-hour lag? [21:50:26] awight: ejegg: that'd be good... would that put the nail in the coffin for recordImpression? [21:50:34] * awight flies into temper tantrum about snow down my neck [21:50:43] aww sorry [21:50:46] hehe [21:51:16] AndyRussG: well, I know ewulczyn has been pushing for real-timeness, maybe he can weigh in on the hive lag? [21:51:29] right... [21:51:49] trying to recall exactly what was said in SoS... hang on, checking etherpad archive [21:52:32] "officially no longer using udp2log" and "Faster hive table" https://www.mediawiki.org/wiki/Scrum_of_scrums/2015-02-04#Analytics [21:52:32] BTW I was thinking about S:RI, maybe we can just turn it off for most users that are on untargetted projects and languages, no? With maybe a config option to turn it back on if something's really weird that we need to check [21:52:42] weeeee! [21:53:08] err, maybe he just meant for their own purposes [21:53:14] ejegg: I think there was a thing != udp2log, it was called udppipe maybe? [21:53:15] should have asked a followup [21:53:47] ccogdill: you're going to laugh at me. i'm trying to find my transaction that failed [21:53:53] but.. i couldn't [21:53:59] then i realized i was in the GC console [21:54:01] haha [21:54:03] that would do it [21:54:06] yeah [21:54:11] AndyRussG: that's interesting. It's been so helpful for debugging, though... even to get the feedback that CN delivered an empty list of banners to render. [21:54:12] I can look for it in wp for you [21:54:16] thank you :) [21:54:27] did you use your wmf email atgo? [21:54:35] i'm not entirely sure.. that's part of the issue ha [21:54:37] atgo: do you have the CT id yet? I can look in the fraud tables [21:54:38] :) [21:54:38] probably [21:54:39] (PS1) Ssmith: Fixed WIP madness [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 [21:54:48] (CR) jenkins-bot: [V: -1] Fixed WIP madness [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 (owner: Ssmith) [21:55:01] yep found it atgo [21:55:06] awight: can you show me how in the future? [21:55:15] Hmmm... or maybe a much, much lower sample rate for the non-targetted? [21:55:15] it was caught in our fraud filters as you guessed [21:55:23] are you looking for a transaction id? [21:55:23] yeah i know.. we figured it out yesterday [21:55:25] yeah [21:55:35] i want to know my fraud score so i can hassle maxmind about it [21:55:39] 23997688.0 [21:55:40] ccogdill: are you pulling fraud details? [21:55:43] oh good, thx [21:56:01] awight: i got it thanks :) [21:56:12] ah cool, thanks! we’re all so sql handy now! [21:57:15] MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1016039 (AndyRussG) Hi... Any comments on how the retirement of udp2log might impact on this? Thx! https://www.mediawiki.org/wiki/Scrum_of_scrums/2015-02-04#Anal... [21:57:37] wait ccogdill that's from december [21:57:44] this would've been yesterday or the day before.. and that one passed our fraud [21:58:56] eh [21:59:03] you’re right [21:59:14] jetlag is officially getting to me, if I can use that excuse.... [21:59:34] was this on 1/13? [21:59:44] that’s the most recent attempt I get from your name, atgo [21:59:47] 25488456.0 [21:59:51] atgo: honestly, I doubt my method is very good. I go through processor communication logs, searching for the email address. A more reliable method would be to go to a unique WP page and search for that referrer in the db. [22:00:14] hmm [22:00:44] when did you make the attempt? [22:01:08] yesterday i think? maybe the day before [22:01:39] how did you find out it was a fraud failure? [22:02:09] K4-713 ? [22:02:16] huh? [22:02:16] atgo: sorry--GC or WP? [22:02:20] Wp [22:02:22] ok [22:02:32] K4-713: yesterday we looked up my failed transaction and you were able to find it [22:02:52] atgo: 25547139.0 [22:02:58] yes. [22:02:59] this is becoming a huge thing, but i was going to toss the vendor some info to try to figure it out [22:03:13] thank you [22:03:16] how did you get that? [22:03:23] that’s the order number? i don’t have that in WP anywhere, fwiw [22:03:29] grepped payments logs for your email address. [22:03:32] ahh [22:03:37] i assume my @wikimedia email? [22:03:43] nope, it was the other one. [22:03:44] yep ok, looking for details now: Feb 3 00:06:05 payments1003 worldpay_gateway: 25547139:25547139.0 Failed transaction because AuthorizePaymentForFraud failed [22:04:03] We're not doing much these days, so "gomez@" was enough. [22:04:37] is there a reason the worldpay portal doesn’t return results for that order number? [22:04:47] oh [22:05:02] I’m wondering because Michael is looking into a batch of 7 or so failed donation attempts we can’t find anywhere in WP’s potal [22:05:04] ccogdill: cos we never made a charge [22:05:07] thank you [22:05:14] we should be able to see failures [22:05:28] I saw Anne’s failed attempt from 1/13, for example [22:06:17] https://www.mediawiki.org/wiki/Extension_health [22:06:21] don't even look for our stuff [22:08:15] atgo: Do you want me to look something up? [22:08:23] no, thanks K4-713 [22:08:26] okay [22:08:37] Not even... our maxmind login? [22:14:01] oh yeah K4-713 that would be super [22:14:09] i'm in touch with them, too [22:15:19] support@ [22:15:21] ? [22:15:37] I have located the evidence that we used that before. [22:22:07] pp sent me some contact there [22:25:20] (PS1) Ejegg: Really send NarrativeStatement1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/188679 (https://phabricator.wikimedia.org/T88060) [22:25:47] awight, K4-713 ^^^ [22:25:48] oops [22:27:12] Figured out why ccogdill didn't see anything extra on her statement. Now fixed + tested [22:27:25] cool, thanks, ejegg! [22:27:34] not yet deployed, though! [22:27:52] just an automated test [22:27:55] ah I was going to look up your test donation on the WP side [22:27:59] but I should wait? [22:28:07] (CR) Awight: [C: 2] "Aargh :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/188679 (https://phabricator.wikimedia.org/T88060) (owner: Ejegg) [22:28:22] (Merged) jenkins-bot: Really send NarrativeStatement1 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/188679 (https://phabricator.wikimedia.org/T88060) (owner: Ejegg) [22:28:23] ccogdill: yeah, please hold for deployment [22:28:32] got it, thanks [22:33:50] awight: think I can get away with a DI deploy of that + killall original_ right quick? [22:34:14] yep! [22:34:19] rockin [22:34:25] lmk if I can help [22:34:59] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/188683 [22:35:19] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/188683 (owner: Ejegg) [22:35:33] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/188683 (owner: Ejegg) [22:37:21] (PS1) Ejegg: Update DonationInterface submodule for deployment [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/188685 [22:37:42] (CR) Ejegg: [C: 2] Update DonationInterface submodule for deployment [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/188685 (owner: Ejegg) [22:38:26] MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1016172 (AndyRussG) @ellery, maybe you could give us some more details about the scope and nature of the data you need? For example, do you use information about... [22:40:32] atgo: you have any interest in open window? [22:40:41] what? [22:50:26] !log updated payments from 1e9b78e9a8bf557a710988620bd6f1a335787173 to cbaf66e7705789f37117ec6edc4d936c6174d511 [22:50:29] Logged the message, Master [23:05:06] ccogdill: OK, deployed fix and we're definitely sending that field to WP now [23:05:43] okay cool! let me make another test donation and see what I can find on the WP side [23:08:27] hey ejegg - nothing on my bank statement changed from the last test donation [23:08:27] PURCHASE DONATE@WIKIM NON PROFIT US CA [23:08:30] is what I see [23:08:34] dang! [23:08:54] OK, I'll send an email to worldpay [23:09:50] okay! [23:10:15] so ejegg the other thing is I can’t find the attempt on WP’s portal at all [23:10:21] it’s in Civi - order ID 25578687.0 [23:10:29] ejegg, AndyRussG: We are having problems. [23:10:31] Wait 1 plese [23:10:36] ccogdill: whoa, that's VERY strange [23:11:15] np :) [23:11:36] I know! maybe has to do with these problems? keep me posted [23:11:54] I was worried when I couldn’t find Anne’s failed attempt from earlier this week either [23:12:37] (PS1) AndyRussG: WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [23:12:40] (CR) jenkins-bot: [V: -1] WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [23:53:35] (CR) Ejegg: [C: -2] "Don't merge this, still discussing what to do" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188394 (https://phabricator.wikimedia.org/T45250) (owner: Ejegg)