[00:02:12] Wikibugs, Wikimedia-Fundraising: Wikibugs bot is skipping many notifications - https://phabricator.wikimedia.org/T88747#1019780 (awight) Awesome work, thank you! [00:05:44] ...omg [00:06:19] what 'appen? [00:06:33] I... [00:06:37] noooo! [00:06:44] You'll see in a second. [00:06:48] It's. [00:06:50] Just. [00:06:52] Terrible. [00:10:41] (PS1) Katie Horn: Fix typo in nightly audit code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/188946 [00:11:00] awight: ^ [00:11:01] ... [00:11:13] I die. [00:11:21] ooh [00:11:25] (CR) Awight: [C: 2] Fix typo in nightly audit code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/188946 (owner: Katie Horn) [00:11:27] (Merged) jenkins-bot: Fix typo in nightly audit code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/188946 (owner: Katie Horn) [00:11:31] make it go away! [00:11:43] Bring me the Stone of Shame. [00:11:51] I will help carry it [00:11:57] I've earned at least that. [00:12:12] so the stupid thing was case-insensitive after all?? [00:12:13] I... can we try this? [00:12:17] Yes. [00:12:22] But, not where I thought. [00:12:25] I s'pose it's just a mysql "=" thing. [00:12:33] it's not "!"-insensitive. [00:12:42] Not really. It's an "everything is actually going through the refund queue" thing. [00:16:05] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/188948 [00:16:53] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/188948 (owner: Awight) [00:16:56] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/188948 (owner: Awight) [00:20:26] § Fundraising Tech Backlog, § Fundraising Sprint the Cure: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1019819 (atgo) [00:33:55] ccogdill: Good news. [00:34:07] I love good news! [00:34:11] I'm filling in the GC refunds and chargebacks from forever. [00:34:21] And from now on, they *will* come in automatically. [00:34:22] wohooo! you decided to just do everything? [00:34:25] With the nightly. [00:34:27] awesome [00:34:50] I'm re-running all the audit files I have hanging around. [00:35:01] Already got a lot of this month, I think. [00:35:23] PPena: You probably want to know this too. [00:35:30] I'm filling in the refund/chargeback hole now. [00:35:40] Finally found the terrible little problem breaking all of it. [00:36:40] K4-713 cool [00:36:54] K4-713 and yeah.. good luck! [00:37:03] I'll let you both know when I think it's mostly there. [00:37:06] Probably tomorrow. [00:37:11] There are a couple files I can't move. [00:43:42] Wikimedia-Fundraising-CiviCRM, Labs, Wikimedia-Fundraising: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1019884 (hashar) Or you can get the instance created in your labs project :-]  Might just need to add a security rule to your project to allow ssh from the J... [00:45:48] * awight taps K4-713 [00:45:58] yeeeeees? [00:46:14] <_< [00:46:25] sorry, ya missed it :p [00:49:16] awight: quick CN qunit test question: what did you mean by the comment "BOOM on priority case" ? [00:49:26] AndyRussG: I was wondering myself :( [00:49:29] looking... [00:50:06] bannerController.lib.tests.js [00:50:26] Line 26 (in my working version thereof...) [00:50:26] yes, 2757f4c7e22347a3f292e783f5b3340009278a54 ... [00:51:22] Maybe it was just to say that more testing of priority interactions was needed? [00:51:29] sorry, I really don't know [00:52:11] My only guess is that I was imagining somehow the default values would break a test case [00:52:20] u should probably ignore and delete, at this point... [00:53:30] gotta run, see you tomorrow! [00:54:17] hey K4-713, what's up with all the failmails? should we give ccogdill a heads up? [00:54:24] Er, huh? [00:54:37] Oh, that's me. [00:54:38] uhh... [00:54:41] Low priority. [00:54:45] chargebacks? [00:54:49] exchange rate fluctuations? [00:55:11] It's not 100% clear why that happens sometimes. [00:55:21] Occasionally, it's a totally different currency. [00:55:28] huh [00:55:48] I really like the ones that are off by 10x. [00:56:00] yikes [00:56:15] that’s a scary fluctuation [00:56:19] yep [00:56:36] It's probably not real, though. [00:56:45] yeah, fortunately (?) the donation is the higher number there [00:56:49] ohh well. that’s probably a good thing for those donors [00:57:06] Particularly when it's all the same currency, and it's a currency that they seemed to misreport on their end for some reason. [00:57:39] USually, we wouldn't get these all at once, either. [00:57:44] Some value in the... flood. [01:54:43] ccogdill: Hey, question. [01:54:50] When you refund a contribution... [01:55:12] ...do you do anything differently to indicate that it was donor-requested, vs. proactive snuffing of fraudulence? [01:55:28] we don’t [01:55:33] Aw. [01:55:35] ...could you? [01:55:35] we just click refund :/ [01:55:37] :) [01:55:41] ummm [01:55:50] I mean, we should talk about this. [01:55:50] let me look at it in civi for a second [01:56:05] But, it looks like you guys get a ton of what we miss. [01:56:24] And, that separation would be really useful to me, to ensure that we can miss fewer things. [01:56:39] Hopefully less clicking overall, then. [01:56:40] you mean chargebacks we missed? [01:56:56] No, things that the payments cluster didn't id as fraud. [01:56:58] And you do. [01:57:07] Things *we* miss, that *you* catch. [01:57:18] ohhh [01:57:21] I want the payments cluster to miss fewer things. [01:57:24] yes Michael especially is a whiz at that [01:57:29] he enjoys doing it, fwiw [01:57:34] he tells me it’s like a video game for him [01:57:38] oho [01:57:59] Then, maybe he would be interested in tweaking some dials a bit upstream. [01:58:00] :) [01:58:21] Or, telling us which dials we need and don't have yet. [01:58:21] yes definitely, he wants to be involved in the fraud parameter talks [01:58:26] Rad. [01:58:36] he got excited hearing about that on team day [01:58:39] so back to your question [01:58:42] I will keep that very much in mind. [01:59:05] when we preemptively refund fraudy-looking donations, we don’t do anything in civi at all [01:59:12] okay [01:59:19] because we only do this at GC for the time being, and GC tells civi to refund it [01:59:52] so do you want us to change the contribution type in civi for each one of these, and then let the GC refund come through? [01:59:57] I'll think about how we can... start making the distinction, without it being a bad new click. [02:00:04] it’s definitely a lot more touches [02:00:06] It might be easier to mark them the other way. [02:00:16] When somebody requests a refund. [02:00:29] Do you mark that in civi manually at the time? [02:00:30] well we don’t do anything to those in civi either [02:00:36] orly [02:00:36] no we only do in edge cases [02:00:44] like worldpay in france [02:00:51] ah, okay [02:01:00] Hummmm. [02:01:06] which is great! [02:01:12] yeah, totally. [02:01:25] I thought you were marking something in civi to indicate that it had been dealt with or something. [02:01:44] nope [02:01:45] If you're not marking anything in civi at all, then this is... probably not as easy as I thought it might be. [02:01:49] just the psp and our refunds doc [02:01:51] d'oh. [02:02:04] we do record this on a document though! [02:02:07] Back to the braining board. [02:02:07] the reasons and all that [02:02:44] What I want to get to, is a state in which we can just run a query for chargebacks + refunds that were preemptive chargebacks. [02:02:57] Leaving out the donors that changed their minds. [02:03:19] Anyway, none of this is urgent. [02:03:51] I do want to spend some time on it, though. [02:03:56] You know: personally. :) [02:12:16] well we could definitely get some of this from DS’s own internal reporting [02:12:22] it just wouldn’t be in civi [02:12:39] D...S? [02:13:00] Oh. Donor Services. [02:13:02] Dur. [02:19:33] :) [02:20:02] ccogdill: Ideally, we'd just need the one system in the first place. [02:20:09] yeah sure [02:20:20] I'm... guessing it's just too slow? [02:20:21] we like to record it somewhere else partly in case it doesn’t work in civi somehow [02:20:32] it being civi? [02:20:36] yeah [02:23:20] well there’s just no reason to do it there… since the psp will already do that for us [02:53:09] (CR) AndyRussG: [C: 2 V: 2] "Woohoo!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 (owner: Awight) [02:53:11] (CR) jenkins-bot: [V: -1] One QUnit test per allocation fixture [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 (owner: Awight) [03:07:27] (PS2) AndyRussG: One QUnit test per allocation fixture [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 (owner: Awight) [03:08:34] (CR) AndyRussG: "Rebased, resolving minor conflict" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 (owner: Awight) [10:22:37] § Fundraising Tech Backlog: Create Alipay-specific TY page - https://phabricator.wikimedia.org/T88700#1020414 (Pcoombe) If it's possible to hit the normal Thank You page with a URL parameter "payment_method=alipay" (or something similar) then I can handle it from there. [13:56:19] I'm going to be upgrading boron to trusty in a few minutes. [14:53:12] cmjohnson1: hi... is that relevant for FR? Looks like the people who know about the payments workflow are not here yet, but an e-mail to fr-tech might well get them... [14:54:14] Thx AndyRussG, Katie told me that nobody would be around at this hour doing deployments [14:56:23] K sounds good! [14:59:48] brb [16:34:32] § Fundraising Tech Backlog, § Fundraising Sprint Devo: Set CiviCRM timeout to 30 min - https://phabricator.wikimedia.org/T88759#1020708 (Jgreen) Are you seeing an nginx error page, or does it just never return? [17:05:22] § Fundraising Tech Backlog, § Fundraising Sprint Devo: Set CiviCRM timeout to 30 min - https://phabricator.wikimedia.org/T88759#1020776 (Jgreen) I bumped the timeout from 300s to 600s. Much beyond that and I suspect the limiter will be browser and firewall timeouts . . . [17:37:29] Jeff_Green: Are you going to be around in an hour or something? [17:37:40] i should, yeah [17:37:44] I need some help liberating some files I don't have permissions to see. [17:37:48] k [17:38:10] I'm in a meeting now, but I just wanted to make sure you would be floating around when I get out. [17:38:42] yup [17:38:54] Groovy. Thanks. :) [17:39:12] ejegg: hey um have you written PayPal about the nonsense audit lines? If not, I can do that now [17:39:15] np! [17:39:44] awight: nope, I think K4 said she might though [17:39:55] (PS1) AndyRussG: QUnit: Remove groovy try-catch block [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/189035 [17:40:09] Ha. Not it. [17:40:12] ok, I'll leave that for K4-713 [17:40:13] awight: Please go for it. [17:40:15] aaugh [17:40:16] :) [17:40:22] I was too slow [17:40:24] I'll do it [17:40:26] I deserve this :p [17:40:27] I have 1,000 manager things to do. [17:40:30] haha [17:40:31] support@ ? [17:40:44] Also, it looked like you had a ticket still out for something totally similar. [17:40:50] So, I didn't want to... you know, confuse them. [17:40:52] ejegg: PM'd [17:40:53] Seems really easy. [17:41:02] Kevin has been great... [17:41:08] thanks awight [17:41:09] Good to know. [17:41:25] Isn't that a song? "1000 manger-things-to-do on the wall, 1000 manager-things-to-do on the wall..." [17:41:30] Totally forward about what's going on, and what's being done to fix [17:41:43] Take one down, hoard it... 1500 manager things to do on the wall. [17:43:26] Heheh [17:43:41] Man the pump! [17:43:55] ? [17:44:30] Bilge, I was thinking. [17:46:29] * AndyRussG is glad enwiki is back: http://en.wikipedia.org/wiki/Bilge#Bilge_maintenance [17:46:55] Land guy, eh? [17:48:07] baahaha [17:48:15] I'll be in the head [17:48:19] the loo [17:48:20] wth [17:51:14] snow 'n' cement [17:51:39] what?! [17:51:55] ah landlocked [17:52:00] mmm [18:26:18] atgo: "Listmaster G" is your new rapper name. [18:26:23] Just saying. [18:28:19] * awight turns it up [18:32:28] untz untz [18:43:42] § Fundraising Tech Backlog, § Fundraising Sprint Devo: Set CiviCRM timeout to 30 min - https://phabricator.wikimedia.org/T88759#1020952 (Jgreen) p:Unbreak!>Normal [19:06:38] § Fundraising Sprint E: [BUG] Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1021012 (atgo) [19:07:31] § Fundraising Sprint E: [BUG] Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1021017 (atgo) p:Normal>High Major Gifts wants to use Civi Grants, and reminders are a key part of this. [19:16:37] § Fundraising Tech Backlog, § Fundraising Sprint Devo: Gateway Reconciliation report times out - https://phabricator.wikimedia.org/T87834#1021082 (awight) @PPena, can you try again? Jeff doubled the timeout, and I can successfully pull https://civicrm.wikimedia.org/civicrm/report/instance/53?reset=1 You pro... [19:31:10] PPena: just waving my hands to let u know the reconciliation report is ready for your next shot [19:35:01] atgo: Am i... a meeting... ayiieee [19:35:57] § Fundraising Tech Backlog, § Fundraising Sprint Devo: Set Civi Nginx timeout to something higher - https://phabricator.wikimedia.org/T88759#1021178 (awight) [19:36:22] § Fundraising Tech Backlog, § Fundraising Sprint Devo: Set Civi Nginx timeout to something higher - https://phabricator.wikimedia.org/T88759#1019749 (awight) @Jgreen -- thanks, that was enough for this year's workaround!! [19:46:18] Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, § Fundraising Sprint Devo: Gateway Reconciliation report times out - https://phabricator.wikimedia.org/T87834#1021228 (valhallasw) Sorry, another test to make sure the underlying issue also has been fixed. [19:46:46] woot [19:47:11] oh, yeah, the fact that the projects are reported here shows it works :D [19:48:02] awight sorry was on a call. Awesome! Will try it right now :) [19:49:50] Wikibugs, Wikimedia-Fundraising: Wikibugs bot is skipping many notifications - https://phabricator.wikimedia.org/T88747#1021253 (Legoktm) a:valhallasw [19:49:57] Wikibugs, Wikimedia-Fundraising: Wikibugs bot is skipping many notifications - https://phabricator.wikimedia.org/T88747#1021255 (Legoktm) Open>Resolved [19:50:04] <3 [19:54:49] awight your link is not even opening. Should I just try the old report on CIVI again? [19:55:20] awight's in the mg meeting just now [20:02:40] PPena: All the GC refunds/chargebacks are in there now. [20:02:45] ccogdill: ^^ [20:03:10] PPena: when u say "link is not opening", what does that mean? [20:03:11] I am not planning on trying to re-run anything else unless somebody finds a problem in the reconciliation process. [20:03:12] K4-713 wooooow [20:03:18] :) [20:03:25] awight it just keep loading in a white page [20:03:48] awight doesnt even load the form to try and get the report [20:04:01] im trying via the old report in CIVI now... its running. lets see if it times out... [20:04:03] PPena: is it spinning? [20:04:22] awight yeah looks like its trying to find the page, but doesnt [20:04:28] cos what I get with the "/53" report that u created yesterday is like a 10-minute wait, then it loads the results. [20:05:25] cool k4-713, thanks again for doing that! [20:05:30] Totally. [20:07:04] awight ok if this doenst work I will try your new link again [20:08:02] awight: food? [20:53:06] awight OMG... i think it worked [20:53:10] just took... 30 mins! [20:54:04] awight thank you so much! servers the purpose :) [20:54:23] awight let me know what to do moving foward (should I use this same link and just change the dates for the next months?) [21:13:00] Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, § Fundraising Sprint Devo: Set Civi Nginx timeout to something higher - https://phabricator.wikimedia.org/T88759#1021448 (Jgreen) Open>Resolved [21:13:01] Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, § Fundraising Sprint Devo: Gateway Reconciliation report times out - https://phabricator.wikimedia.org/T87834#1021449 (Jgreen) [21:22:38] atgo: my mug arrived! [21:23:20] atgo: also, out of curiosity, is there an easy way to find the previous sprint on Phabricator [21:23:21] ? [21:31:19] § Fundraising Sprint Devo, MediaWiki-extensions-CentralNotice: CentralNotice bucket improvements, step 3 bis part 1: remaining test details - https://phabricator.wikimedia.org/T86091#1021518 (AndyRussG) [21:31:50] AndyRussG: I don't think there's any link between the sprints, so u have to type "the Cure" into the search bar [21:32:04] Hmmm [21:33:02] Maybe there could be like a more "sprint" tag or something, so you can get to all the sprints...? [21:33:06] PPena: ok awesome, yes just create new report instances for each thing you do, and IMO try to restrict to one gateway at a time unless you actually want all th edata [21:33:22] awight THANK SO MUCH :D [21:33:33] Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, § Fundraising Sprint Devo: Gateway Reconciliation report times out - https://phabricator.wikimedia.org/T87834#1021537 (awight) Open>Resolved [21:33:45] PPena: it only took us 2 months :) [21:34:10] lol [21:34:37] § Fundraising Sprint Devo, MediaWiki-extensions-CentralNotice: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1021539 (AndyRussG) [21:59:57] (PS3) AndyRussG: WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [22:00:35] Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising: Create a general Civi import function to reduce time for hand keying donations in Civi - https://phabricator.wikimedia.org/T88836#1021661 (awight) [22:00:41] (CR) jenkins-bot: [V: -1] WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [22:06:42] (CR) AndyRussG: "This PS: actually some changes rolled in with a rebase. Apologies for the confusingness..." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [22:08:43] AndyRussG: on that note, where's that patch you wanted me to double-check? [22:08:57] awight: one sec :) [22:09:23] ah, https://gerrit.wikimedia.org/r/#/c/183164/ ? [22:09:30] (PS3) Awight: One QUnit test per allocation fixture [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 [22:09:37] awight: ep! [22:09:56] thanks! [22:09:56] (CR) Awight: [C: 1] "rebase looks fine" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 (owner: Awight) [22:10:17] awight: cool! [22:12:30] AndyRussG: the best way i've found is to just search them [22:12:31] (PS2) Awight: QUnit: Remove groovy try-catch block [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/189035 (owner: AndyRussG) [22:12:37] you could make a custom query [22:12:43] (CR) Awight: [C: 2] "I can dig it!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/189035 (owner: AndyRussG) [22:13:03] atgo: Ah hmmm OK interesting :) [22:14:27] BTW apologies again for snarkiness about art collectives, I feel like I offended like half the team this afternoon, very sorry about that [22:14:44] I had to re-google to find the page and remind myself how cool it is [22:15:41] AndyRussG: these people spend years doing interviews with people in the communities they're making art about-- http://beehivecollective.org/en/ [22:15:46] atgo: ^ [22:16:02] haha not offended at all :) [22:17:30] atgo: ah cool thanks :) [22:23:13] awight: wow that is also neat! Also no offense meant about the haircut, it does look fine... It was just that image in the first video call was very pixelated, hence the exclamation in standup [22:23:50] lol I'm not sad about my hair butchery, only that I have to talk about my self-image in public :p [22:24:02] * awight scurries back under a rock [22:25:28] I had this great barber in Mexico City, maybe I should hair-wait until Wikimania... [22:26:07] I should have asked Steven Walling for his barber suggestions while I had the chance [22:36:34] * atgo waves at pizzzacat [22:36:59] * pizzzacat waves at atgo [22:47:52] here is your cat of the day, everyone: https://33.media.tumblr.com/f786910d501ea89b618a3140702e0b6c/tumblr_nj4ppqjtSF1sgy4peo1_250.gif [22:50:47] needs midi [22:51:55] if it needed anything, that would be it [22:54:21] does anyone know if fr-online includes fr-tech? [22:54:50] (CR) AndyRussG: [C: 2] "\o/" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 (owner: Awight) [22:55:15] * AndyRussG saves the cat URL [22:55:33] (Merged) jenkins-bot: One QUnit test per allocation fixture [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/183164 (owner: Awight) [22:55:37] (Merged) jenkins-bot: QUnit: Remove groovy try-catch block [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/189035 (owner: AndyRussG) [22:59:39] (PS4) AndyRussG: WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [23:00:17] (CR) jenkins-bot: [V: -1] WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [23:01:52] pizzzacat: fr-online does indeed include tech. [23:01:57] Thanks for the cat. [23:02:09] I'm sad I didn't get you anything. [23:04:31] thanks K4-713 - I ended up sending to fr-all anyway! [23:04:36] haha [23:04:44] there are infinite cats on the internet [23:05:11] http://www.infinitecat.com/infinite/smallpics/smallpics-1-100/50s-pearl.jpg [23:05:44] ...yep. [23:06:33] Oh Dude, I just remembered the thing I was going to share with you guys after the prawning. [23:06:36] deuuude [23:07:34] wat. that's the entire site [23:08:07] The Infinite Cat Project is about one cat watching another. A long line of 1798 cats so far. The very first Infinaut is Frankie, seen at left admiring a flower. He is the owner of Paul Hamilton. [23:08:47] ! [23:09:35] oh it's really cool if you keep clicking the arrows [23:09:44] I Just... got to that. [23:09:50] wtf did I just do. [23:09:59] well that's it for work today [23:10:04] maybe for the rest of the month. [23:10:27] which do you prefer, going from 1 and zooming out, or going from 1798 and zooming in? [23:10:36] eeeee [23:10:49] oh god…..dare I [23:10:49] I'm trying it both ways. I feel funny. [23:10:57] I don't know if I'll ever come back if I do.... [23:11:25] (note for away teammates: all you can hear here is soft, regular clicking) [23:11:44] I think I prefer "next cat". [23:12:05] Okay, but this is the thing I was going to... [23:12:05] https://www.youtube.com/watch?v=dYBjVTMUQY0 [23:12:46] this is a plot to take over the... oh that next cat's quite nice [23:12:58] Initially I thought they were watching each other in real time [23:13:07] K4-713: what is this, the antidote? [23:13:20] I die every time I watch that. [23:13:25] baaa thx [23:14:32] We talked about pair programming for two seconds at the prawning, you see, and... haha, I can't. [23:14:51] oh my god that was amazing [23:14:57] haha [23:15:12] as pioneered on NCIS [23:15:19] The best thing is that they did a forking video that was, like, real. To prime for that. Which came out on April 1. [23:15:39] https://www.youtube.com/watch?v=u8qgehH3kEQ [23:17:56] the comments are good [23:19:04] haha how is the typing even being helped [23:19:33] haha oh yeahhh that one [23:20:07] "I've never seen code like this..." [23:20:36] i wonder if i could type faster with foot pedals for modifier keys [23:21:26] heh, they totally sell those. to emacs users. [23:21:42] remap yr damn ctrl key, people!! [23:22:11] I've seen at least one emacsen now with permanent left pinky damage. [23:24:56] yeah vim users would never want those [23:33:37] (PS5) AndyRussG: WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [23:38:53] (CR) AndyRussG: "This PS: just jlint and whitespace fixez" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [23:41:35] awight: quick ?: what does the "// TODO: chooser tests" at the end of bannerController.lib.tests.js refer 2? [23:42:08] looking... [23:42:52] AndyRussG: just that we should explicitly test chooseBanner and the other functions [23:43:41] I wrote the original tests at a strange granularity, just rushing to cover what I considered the subtle parts [23:44:53] awight: Ah OK, yeah makes total sense... I should have understood that comment, also, thanks [23:50:53] (PS1) Awight: Consolidate GatewayPage logic in the base class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 [23:52:08] (PS2) Awight: Consolidate GatewayPage logic in the base class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 (https://phabricator.wikimedia.org/T86251) [23:54:13] (PS1) Awight: Don't senselessly repeat base class code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189134 (https://phabricator.wikimedia.org/T87043) [23:55:04] AndyRussG: please do kick me when I leave behind a crypto-turd like that! It's a really bad habit...