[05:06:01] (CR) Legoktm: [C: 2] Replace anonymous hook implementation with named function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186898 (owner: Awight) [05:06:51] (Merged) jenkins-bot: Replace anonymous hook implementation with named function [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/186898 (owner: Awight) [17:16:44] (PS2) Awight: WIP doPayment() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 [17:17:08] (CR) jenkins-bot: [V: -1] WIP doPayment() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (owner: Awight) [17:17:39] (CR) Awight: "@K4-713: This isn't ready for full review yet, but I wanted you to have a chance to stop me before I go all the way down this alley." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (owner: Awight) [17:40:23] (PS5) Awight: Make paymentmethod non-static [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183630 (https://phabricator.wikimedia.org/T86256) [17:40:53] (CR) jenkins-bot: [V: -1] Make paymentmethod non-static [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183630 (https://phabricator.wikimedia.org/T86256) (owner: Awight) [18:10:09] (PS2) Ssmith: Library and Profile styles and flow [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 [18:10:55] (CR) jenkins-bot: [V: -1] Library and Profile styles and flow [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 (owner: Ssmith) [18:27:31] (PS3) Ssmith: Library and Profile styles and flow [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 [18:28:02] (CR) jenkins-bot: [V: -1] Library and Profile styles and flow [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 (owner: Ssmith) [18:39:22] § Fundraising Tech Backlog: GC CC donations inconsistent in when they reach Civi - https://phabricator.wikimedia.org/T89016#1025484 (CCogdill_WMF) a:atgo [18:45:45] (PS4) Ssmith: Library and Profile styles and flow [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 [18:46:22] (CR) jenkins-bot: [V: -1] Library and Profile styles and flow [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 (owner: Ssmith) [18:47:34] § Fundraising Dash, Fundraising-Backlog: A/B Testing header - https://phabricator.wikimedia.org/T88751#1025508 (atgo) [18:49:55] hey ccogdill [18:50:07] hey atgo [18:50:16] this is is the ticket that came through from phab about paypal: https://phabricator.wikimedia.org/T88895 [18:50:29] should we have him/her send more info to problemsdonating2? [18:50:36] problemsdonating@, rather [18:51:11] how about this, we can ask for email associated there or they can send it to problemsdonating [18:51:12] ? [18:51:33] i just don't want to make them put their email in phab [18:55:18] ccogdill: ^ [18:56:00] sorry atgo [18:56:08] no worries :) [18:56:08] yes, they should email problemsdonating@ [18:56:11] cool [18:56:18] I have a strong sense this is donor error in some way [18:56:27] because we haven’t seen this issue in Zendesk anywhere [18:56:33] so would be great to have the donor’s info :) [18:56:42] MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising: False positive payment prompt - https://phabricator.wikimedia.org/T88895#1025553 (atgo) Thanks for the report @idkn. Could you let us know the email associated with the (non)-payment at problemsdonating@wikimedia.org? [18:57:22] perfect, thanks! [19:12:59] K4-713: https://www.youtube.com/watch?v=dw_mRaIHb-M [19:25:17] § Fundraising Dash, Fundraising-Backlog: Main A/B data table - https://phabricator.wikimedia.org/T88752#1025663 (atgo) @meganhernandez_wmf could you please put a screenshot of the main data table in here? [19:31:31] § Fundraising Tech Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Create a general Civi import function to reduce time for hand keying donations in Civi - https://phabricator.wikimedia.org/T88836#1025670 (CaitVirtue) Another note: As we continue to innovate payment processing methods, we seem... [19:31:49] § Fundraising Tech Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Create a general Civi import function to reduce time for hand keying donations in Civi - https://phabricator.wikimedia.org/T88836#1025671 (CaitVirtue) [19:41:04] K4-713: youch, I found the issue. gateway::addData calls DonationData::addData to add the staged response data, then DonationData normalizes internally! [19:41:21] That's totally intended. [19:41:24] ... [19:41:30] but... you can't normalize staged data [19:41:40] it should add the data, unstage it, then normalize [19:41:42] No, you can't. [19:42:00] I should really diagram this. [19:42:10] That would be great [19:42:15] but I'm sticking to my story [19:42:40] So, changing this would be... Bad. [19:42:57] The reason we have to re-normalize, are things like... utm_source. [19:43:07] I think it's probably always wrong to normalize when the data hasn't been unstaged [19:43:12] You change something that's a component, that value has to be recalculated. [19:43:40] And there are other values that are sort of... compound values. [19:43:53] compound values ++. [19:44:07] I agree with the normalization, but it should happen after the unstaging [19:44:28] * K4-713 blinks [19:44:28] * awight looks to see if unstage functions rely on other pieces of unstaged data! [19:44:40] unstage shouldn't. [19:44:43] I mean, yet. [19:45:01] I guess there's no reason they shouldn't be able to in the future. [19:45:08] But, really: This needs a diagram. [19:45:43] If I had a sandwich for every time I got in to it with mwalker about staging vs normalization... [19:45:56] ...I'd be... Jabba the Hutt. [19:46:20] I know... we need a diagram, and IMO need to make the internal functions less crazy, e.g. getData_Unstaged_Escaped [19:46:25] Yes. [19:46:33] In fact, I don't want any of that mess. [19:46:34] that should just be "getVal" where that means, get me the normalized valud. [19:46:38] e [19:46:40] DonationData should handle it all. [19:46:48] Ah, but... you don't always want normalized. [19:46:55] that's true. [19:47:03] Can haz IRL for one more minute? [19:47:07] optional param. [19:47:10] yep [20:03:23] pizzzacat: Are you fooding today? [20:04:25] I am, but not at the moment… [20:04:28] kk [20:04:30] not feeling so hot [20:04:32] or appetizey [20:04:35] :( [20:04:39] Good luck with that. [20:04:46] heh yeah maybe soup later [20:58:57] (PS1) Ejegg: WIP: move some logging functions into GatewayLogger [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189584 [20:59:19] (CR) jenkins-bot: [V: -1] WIP: move some logging functions into GatewayLogger [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189584 (owner: Ejegg) [21:02:00] ejegg: see any empty deploy slots tomorrow that you'd like to babysit? https://wikitech.wikimedia.org/wiki/Deployments Thanks in advance! [21:02:56] stand up? [21:03:10] (CR) Awight: WIP: move some logging functions into GatewayLogger (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189584 (owner: Ejegg) [21:03:17] atgo: k! [21:04:12] (PS2) Ejegg: WIP: move some logging functions into GatewayLogger [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189584 [21:15:46] MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising: Tech Review of LATAM processor - https://phabricator.wikimedia.org/T87046#1026012 (awight) [21:16:11] § Fundraising Sprint Devo, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Tech Review of LATAM processor - https://phabricator.wikimedia.org/T87046#982398 (awight) [21:19:20] § Fundraising Sprint Devo, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Tech Review of LATAM processor - https://phabricator.wikimedia.org/T87046#982398 (atgo) [21:22:30] AndyRussG: want to go early tomorrow? like 9:30 eastern? [21:22:30] § Fundraising Sprint Devo, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Tech Review of LATAM processor - https://phabricator.wikimedia.org/T87046#1026044 (awight) [21:23:33] MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising: False positive payment prompt - https://phabricator.wikimedia.org/T88895#1026049 (atgo) a:CCogdill_WMF [21:23:48] ejegg: u bet! thanks :) [21:29:15] K4-713: There were definitely some disagreements about staged data, that I can see in the code... May I RL for another minute? I don't quite see the path forward... [21:29:28] Oh, sure. :p [21:42:29] ejegg: all set! https://wikitech.wikimedia.org/wiki/Deployments#Week_of_February_9th [21:44:22] ROCKIN [21:44:30] *rockin [21:44:45] sorry, had my headphones up too loud [21:49:03] ejegg: hey ummm--where did that patch go which incremented OrderId decimally for each WorldPay API call? [21:49:27] still hanging out with a -1, I think [21:49:40] https://gerrit.wikimedia.org/r/#/c/171561/ [21:50:09] which is silly, cause all it needs is a regex fix in the audit script [21:50:51] K4-713 is interested :) [21:51:12] We were having a serious finger puppet session re: OrderId ! [21:51:18] one sec, let me do that audit tweak [21:51:28] I think, interested in the other way :) [21:51:29] I just thought of something I should bring in to the office. [21:51:39] like when an X-ray is interesting [21:51:43] * K4-713 shakes self [21:51:50] >_> [21:52:00] ah, you mean it should just be abandoned? [21:52:15] ejegg: Not necessarily. I just can't figure out where this came from. [21:52:26] WP wanted us to use a different order ID for each api call [21:52:27] So... what is this solving for? [21:52:37] so that we could do automatic refunds [21:52:40] They do know what an "order" is, right? [21:52:47] :( [21:52:56] yeah, I was confused at that too [21:53:13] It would be even funnier if they called it a Cart ID. [21:53:21] I guess once they generate a token, that's all the continuity they want [21:53:30] Hmm. [21:53:36] ooo Store-Merchant Store ID [21:53:39] So, why ask for order id at all? [21:53:43] Is that a required field? [21:53:53] Really should be called transaction ID [21:54:26] So, wait. [21:54:35] I think there's some info on a mingle card [21:54:42] Which one ends up in their console? [21:54:48] And, which one ends up in civi? [21:54:53] ...they should be the same one. [21:55:09] You know, just in case we do things like add refund buttons in civi someday. [21:55:14] Or, recurring starts to exist. [21:55:33] I was assuming it was the ID associated with the sale [21:55:49] which I think gets the un-postfixed ID in that patch [21:55:49] I'm not at all sure if that's the last transaction or the first one. [21:55:56] Or, one in the middle. [21:56:06] https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/2144 [21:56:35] oh, I see [21:56:51] Looks like the last one. [21:57:00] Well, according to the card, anyway. [21:57:01] it's an issue with the way worldpay was passing things along to the financial institution [21:57:53] Okay. This makes sense now. [21:58:10] Well, if you push all the things that make no sense to an area we can't do anything about, anyway. :p [21:58:17] hehe [21:58:32] Damn, that should be a bona fide job skill. [21:59:16] so, i'll make a quick patch for that audit regex in case anyone ever wants to try this change [21:59:39] atgo: What's your policy on doing work off mingle cards at this point? [21:59:41] It looked good to me! [21:59:43] Should those get ported? [21:59:46] +1 [21:59:54] should, yeah [21:59:56] I'll copy-paste it into phab [22:00:00] Thanks. :) [22:00:07] i've just been copy-pasting as neede [22:00:19] K4-713: ejegg need me to read backscroll? [22:00:26] atgo: Nope! [22:00:31] ok :) [22:01:13] ooh this should totally be a subtask [22:01:34] of this one https://phabricator.wikimedia.org/T77909 [22:01:38] ejegg: K4-713^ [22:01:47] Okay, maybe you should read backscroll. [22:01:49] :D [22:02:19] atgo: when you say "subtask"... I found it's way easier to just set "blocked by" associationg [22:02:22] s [22:02:36] yeah.. either way. since search doesn't work literally at all, i find it easier to "create subtask" [22:02:38] for example, there's no way of making a subtask relationship after two tasks are already created [22:02:42] hrm [22:02:54] subtask and blocking tasks end up the same in phab as far as i can tell [22:02:55] oh, is there a phab thing for Worldpay refunds already? [22:03:03] no.. for worldpay in general [22:03:06] no, it's "make WP less suck" [22:03:11] heh [22:03:11] yep [22:04:46] hey pizzzacat1 - when you get the notebook set up for yourself, would you mind running me through it? [22:06:02] § Fundraising Sprint Devo: Make automated refunds possible in Worldpay - https://phabricator.wikimedia.org/T89046#1026176 (Ejegg) NEW [22:08:20] ejegg: are we working on worldpay in this sprint...? [22:08:32] atgo: nah, I was digging up old bones [22:09:06] Is it just me, or is it approaching "hot enough to melt my concentration" in the office right now? [22:09:12] § Fundraising Sprint Devo, Fundraising-Backlog: Make automated refunds possible in Worldpay - https://phabricator.wikimedia.org/T89046#1026192 (atgo) [22:09:16] it's toasty for sure [22:09:20] K4-713: minipause? [22:09:28] If only. [22:09:46] * awight slaps own glasses off [22:09:48] Josh and I used to get hot flashes all the time. [22:09:57] ...truth. [22:10:07] I had that too, on the 6th floor [22:10:17] now the cycles are slowing down [22:10:25] It's freaking February. [22:10:29] I should have a scarf on. [22:11:37] atgo: ok, to the backlog with it [22:15:24] atgo sorry I missed your message earlier [22:15:53] I will indeed, may be in a bit :) [22:29:54] (CR) Ejegg: [C: -1] "Looking pretty good! A few questions and comments inline, and jslint needs to be appeased." (7 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/188674 (owner: Ssmith) [22:34:33] (CR) Ejegg: [C: 2] Delete bad references [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/185206 (https://phabricator.wikimedia.org/T86686) (owner: Awight) [22:34:46] (PS1) Ejegg: Delete more bad refs. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/189601 [23:08:42] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/189601 (owner: Ejegg) [23:08:44] (Merged) jenkins-bot: Delete more bad refs. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/189601 (owner: Ejegg) [23:26:19] (PS1) Awight: WIP split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 [23:26:41] (CR) jenkins-bot: [V: -1] WIP split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [23:28:01] omg ejegg [23:28:07] pizzzacat and i have been working at this for like an hour [23:28:35] yeah, I just saw the 'anaconda' instructions [23:29:07] I was trying to get all the stuff installed against my system's python environment [23:31:24] think I mostly got it working, but I had to tweak the include paths at the start of the notebook [23:31:36] so all the import statements would work [23:31:46] hm [23:31:58] did you get to the point of running ipython [23:32:19] to give you a local notebook server ? [23:34:36] yeah [23:35:34] also, you need to clone ewulczyn's whole wmf git repo, not just the dashboard dir [23:40:51] (PS3) Ejegg: WIP: move some logging functions into GatewayLogger [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189584 [23:41:04] (CR) jenkins-bot: [V: -1] WIP: move some logging functions into GatewayLogger [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189584 (owner: Ejegg) [23:41:48] (PS2) Awight: Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 [23:45:11] (PS4) Ejegg: WIP: move some logging functions into GatewayLogger [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189584 [23:45:22] (PS3) Awight: Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 [23:46:32] (PS6) Awight: Make paymentmethod non-static [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183630 (https://phabricator.wikimedia.org/T86256) [23:47:53] MediaWiki-extensions-DonationInterface, Wikimedia-Fundraising, § Fundraising Tech Backlog: Tracking: General DonationInterface code cleanup - https://phabricator.wikimedia.org/T87043#1026642 (awight) [23:59:25] heading out for a couple hours, back later tonight