[00:05:06] AndyRussG: it's proving difficult to get to that code even from an interactive shell, actually [00:05:12] protected function... [00:05:20] lots of conditionals to avoid choose [00:05:21] Banner [00:08:12] lol, class BRP extends SpecialBannerRandom { function c() { $this->chooseBanner(); } } [00:08:27] stupid fauxrequest still required, though :$ [00:09:57] awight: wut? what extends that? [00:10:34] AndyRussG: bingo, check it out: [00:10:39] mwscript eval.php metawiki [00:10:54] where? [00:10:55] global $wgRequest; [00:10:55] $wgRequest->setRequestURL('theURL'); [00:10:55] class BRP extends SpecialBannerRandom { function c() { $this->chooseBanner(); } } [00:10:58] $bl = new BRP(); [00:11:00] $bl->c(); [00:11:11] ... See fluorine:/a/mw-log/T89258.log [00:12:18] wut is that? [00:12:28] BRP? [00:12:43] AndyRussG: also, $wgRequest->setHeader('X-Cache', 'from uh cache'); [00:12:57] This is livehacking an interactive session with metawiki [00:13:05] mwscript eval.php metawiki [00:13:08] on tin [00:13:24] http://www.mediawiki.org/wiki/Manual:Eval.php [00:13:41] BRP is just a wrapper to hack the access control [00:14:57] awight: that's just a bit nuts... [00:15:10] awight: so you're the one triggering those logs, right [00:16:23] yep [00:16:28] just those two [00:16:50] feel free to make another logging patch, or we can wait until next week... [00:17:54] awight: one sec [00:18:29] * awight eyes the sunshine just... out of reach :p [00:19:57] awight: yeah if you have time still tonight, we could add that to the entry point, as you'd suggested [00:20:49] We can just add the same log call just before sending the 410 [00:23:52] that works! [00:27:10] (PS1) AndyRussG: Add special debug log for SpecialBannerRandom::execute() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190609 [00:27:20] awight: ^ [00:28:33] AndyRussG: how'd it gooooo? [00:28:56] atgo: all good, especial thanks to awight's brilliant debugging ideas and deploy-fu :) [00:29:09] wooooooo!! [00:29:30] and nooooooooooobody mistook a "+" symbol for a "." nooooooobody at all [00:29:34] <_< [00:29:35] >_> [00:29:44] ahem, okey I'm ready for the next patch! [00:29:49] just getting warmed up :p [00:29:55] atgo: yeah so impressions should be down except on actual campaigns [00:30:05] awight: ^ you and that patch were like trains passing in the night [00:30:22] awight: do we have to block off more deploy time? [00:30:33] § Fundraising Sprint E, Fundraising-Backlog, § Fundraising Tech Backlog: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1038222 (atgo) Open>declined I'm actually going to close this unless we get more reports. Thanks! [00:30:39] (CR) Awight: [C: 2] Add special debug log for SpecialBannerRandom::execute() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190609 (owner: AndyRussG) [00:31:00] hehe, this is the one that might cause another 30k fatal errors :) [00:31:12] I'll plan to leave the house immediately after emitting [00:31:16] (Merged) jenkins-bot: Add special debug log for SpecialBannerRandom::execute() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190609 (owner: AndyRussG) [00:31:29] awight: well there's nothing more than just debug log which you've duly tested [00:31:42] hehehe [00:32:45] (PS1) Awight: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/190611 [00:32:58] (CR) Awight: [C: 2] Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/190611 (owner: Awight) [00:33:28] (Merged) jenkins-bot: Merge master into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/190611 (owner: Awight) [00:35:28] awight: I'm extending the deploy slot 'till 5 pm PST [00:35:48] k. I just pinged GG [00:36:20] * awight feels his useless fu rising [00:37:00] what is this fu? [00:37:49] err, I'm getting my pilot's license in deployment [00:38:13] it only takes 10,000 hours of mistakes [00:40:16] awight: I'll get a revert patch ready, too [00:40:32] meh it's probably fine [00:42:22] I mean, eventually we want it out of master neway [00:48:38] AndyRussG: we caught ghosts! [00:48:52] RATS, no cache header [00:49:14] at least we can match up to web requests however [00:49:27] awight: yes, that's about it [00:49:34] nice, though! [00:50:04] high five! [00:50:33] (PS1) AndyRussG: Revert special logging in SpecialBannerRandom [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190616 [00:50:44] yeah congrats, way to go! [00:52:44] AndyRussG: this one might be bursty, 2015-02-14 00:50:49 [00:54:04] It's as if each request caused a flurry of errors in the hhvm.log [00:54:17] what a carnival [00:54:21] Hmmm now I'm seeing more come in [00:54:29] oyo - i'm heading into headache land [00:54:36] that did look bursty [00:54:38] atgo: oh no! [00:54:42] awight: true [00:54:47] i'm going to go home... but i'll get back on IRC there [00:54:48] atgo: sorry! [00:54:49] :) [00:54:53] don't do it! [00:55:04] we'll see ;) [00:55:12] atgo: hope you feel better, have a great weekend [00:55:22] thanks! you too [00:55:23] atgo: don't worry it's all taken care of, and I can send an update to fr-all [00:55:28] see you tuesday [00:55:30] thanks AndyRussG [00:55:30] thanks! :) [00:55:49] atgo: np, likewise, feel better sooooon... [00:55:57] thanks :) [00:56:41] awight: this all seems so fine, I guess I don't see any reason to undeploy over the weekend [00:57:29] AndyRussG: looking forward to finding some compressed ectoplasm on Tuesday! [00:57:40] awight: should I send the updates to the Phab bugs? if you feel like chiming in also please feel free [00:57:46] awight: yurp!! [00:59:19] Pls mention the X-Cache mystery, maybe an op-san can hint at the internal header key [00:59:53] awight: I can also try analyzing that file to check frequencies [01:00:25] cool [01:00:34] Maybe the large volume of errors is a PHP thing. I recall now in debugging I've seen PHP call the same code several times for no apparent reason other than because PHP :) [01:00:51] Or also because Mediawiki 8p [01:03:07] awight: I'll also continue to keep an eye on banners 'n' site uptime.... [01:04:22] I have not seen such a thing [01:04:49] I mean, "because PHP" explains a lot of bad things in this world, but I haven't seen it hang up the phone repeatedly like this, before now. [01:05:34] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Thank you letters for our donors who donate via UKFC - https://phabricator.wikimedia.org/T89512#1038332 (awight) [01:06:23] AndyRussG: oh, wait a minute. the URLs are totally unique enough for us to see multiplication if it happens [01:06:28] this is great. [01:06:36] Ghostbusters! [01:07:14] awight: right, very true! [01:08:13] I haven't seen any repititions yet, though lots of android [01:08:21] Yeah we can also analyze all that [01:08:56] K4-713: success also in debugging, wooooo! [01:09:10] AndyRussG: it must have been related to the 503??! [01:09:21] awight: thaaat's a good point! [01:09:25] I'm really tempted to livehack that right now. [01:09:36] bwahahaha I dunno [01:09:37] awight: Resist. [01:09:40] Yeah [01:09:45] nah it's so harmless guys [01:09:57] look at how cute this little ghost is... [01:10:01] * K4-713 squints like eastwood [01:10:08] awight: we're ahead of the game still, let's keep it that wya [01:10:09] way [01:10:24] hehe I like our team teeter-totter style [01:10:31] we're such a gang :) [01:10:38] indeed! [01:10:44] hold me back! He can't handle the tooth! [01:10:49] haha [01:10:52] I'll analyze these on Monday, it's still a lot of info about devices that never purge their JS [01:11:01] awight: how is Mari holding up? [01:11:31] AndyRussG: she's asleep at the moment (hence productivity :p) [01:11:42] tylenol is masking the fever nicely [01:12:15] * awight feints at livehack [01:12:41] Noooo [01:13:03] I WANT TO LIVE. [01:13:32] awight: yeah let's be sure to keep the happy ending [01:13:43] The ghosts will still be there on Tuesday [01:13:44] :) [01:14:31] don't cross the proton beams! [01:14:39] It would be Bad. [01:15:20] :) Try to imagine all life as you know it stopping instantaneously and every molecule in your body exploding at the speed of light. [01:15:33] Okay. That's "Bad". [01:15:43] Wikipedia is really good for things you might need in a pinch like this. [01:15:46] Well, I know what I'm doing tonight. [01:16:05] I have been thinking about Ghostbusters at least once a day for the last... month? [01:16:11] This tears it. [01:16:34] interesting subtext, they cross the streams after noticing that Gozer's temple doors "swing both ways" [01:17:18] hey guys, did you notice that deploying is really freaking annoying? showed me this... https://www.mediawiki.org/wiki/User:Legoktm/deploy [01:17:34] I'm going to spend days trying to understand what is actually going on here... but I like it. [01:18:17] uhh [01:18:29] Now I just need one of those to build the submodule bumps... [01:19:01] huh [01:19:38] ;) yeah on that note, I'm an hour over my maximum millirems already [01:19:52] Time to get a new badge. [01:19:55] have a good weekend, my droogs! [01:19:56] lol [01:20:02] leave the badge at home [01:20:12] Or trade with a slacker [01:20:25] the sippy-bird [01:20:41] :D [01:22:55] Where is that stinking card? [01:23:40] MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising, § Fundraising Sprint Devo: Special:BannerRandom causing lots of fatal error messages - https://phabricator.wikimedia.org/T89258#1038430 (awight) [01:24:23] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, § Fundraising Sprint Devo: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1038431 (awight) [01:24:52] awight: submodule? [01:24:59] ah for wmf_deploy [01:25:06] sorry I had a brief family interruption [01:25:13] yeah, mediawiki-core submodule pointers [01:25:37] it's so mechanical, perfect candidate for ~legoktm/ori/.bashprofile [01:26:01] huh? [01:26:18] (oh yeah, it's Fridaaaaaaaaaaaaaaaaay!) [01:26:40] seriously. This stuff should be a brief interruption in your family time! [01:26:48] See you soon :) [01:27:03] I'm not moving until I have completed this thing I'm working on. [01:27:22] I think I live at my desk now. [01:27:27] * K4-713 sells house [01:29:07] § Fundraising Dash, § Fundraising Sprint Devo: BUG: Fraud widget numbers don't seem right - https://phabricator.wikimedia.org/T87810#1038456 (CCogdill_WMF) @atgo done! [01:29:28] K4-713: no don't sell! Proton beams! Ghosts! Rising interest rates! [01:29:40] Dogs and cats, living together! [01:29:50] Mass hysteria! [01:29:53] oooooooooh that's the worst [01:32:56] But seriously, didn't you do your time today already, AndyRussG? [01:35:20] K4-713: heh, almost... I'd like to write up a message to fr-all and the phab cards, at least for closure's sake tho [01:35:27] Good call. [01:36:44] Could also add a card to the "deployed" column in the sprint board ;p [01:37:43] Wat. [01:37:51] When did we start deploying things? :p [01:38:30] which things? today's stuff? [01:38:41] Anything. [01:39:00] at the dawn of the deploy command line [01:39:13] whut you mean there's no Phab deployed column? [01:39:16] Don't mind me: I'm just being terrible. [01:39:24] np! not terrible :) [01:39:32] bahaha, that would explain our recent burndown charts. [01:47:44] AndyRussG: I was going to ask you at some point: When would be a good time to schedule a weekly checkin? [01:47:56] Are any days usually better or worse than others? [01:48:04] K4-713: ah yes [01:48:23] days are usually better or worse than others [01:48:32] That's... fair. [01:48:53] In general before our daily standup time is better [01:49:08] hehe, okay [01:49:29] I'll work it in there sometime there's a room I can steal. [01:49:38] As it stands kids get home from school at 12:30 your time, except on Mondays and Wednesdays they arrive at 1:30 your time [01:49:55] So if it suits you, earlyish is good, but really I can work it in any time :) [01:50:41] Sounds good. [01:50:44] I'll find something. [01:51:22] K4-713: cool, thanks! :) [01:51:59] I figure you should get on the board before all my time leaks out. [01:52:20] Ah hmmm [01:52:50] time is always so... lacking... [01:53:14] Truth. [01:53:35] I wish I could stockpile it when things are boring and useless. [01:55:53] Hmmm [01:56:23] I think once on a bus I unwillingly watched a movie about a guy who had a remote control and so he could fastforward the boring parts of his life [01:56:26] It didn't end well [01:57:09] That seems like the opposite of a "remote" control. [01:57:36] Proximate control. [01:57:39] :/ [01:57:49] This is why nobody is paying me to make movies. [01:58:20] Actually fast forwarding wouldn't be the same as stockpiling, either [01:58:37] Yeah. I'm not even sure what that would look like. [01:58:46] time hoarders! [01:59:03] I can stop any time I want to. :p [01:59:50] Rooms and rooms stuffed to the ceiling with old, musty hoarded time [02:00:01] Ew. [02:00:17] I feel like I've been in that house. [02:01:54] Hoarded time that never gets used [02:02:35] * K4-713 looks sad [02:02:49] It got deep in here all of a sudden. [02:03:04] Quick! Say something stupid. [02:04:38] blrrgggrr [02:04:44] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Thank you letters for our donors who donate via UKFC - https://phabricator.wikimedia.org/T89512#1038536 (RLewis) @awight in response to your questions: 1. They have been imported, hand keyed. Check out contact id - 7932376 the 11/15/2014 donation or conta... [02:04:47] * K4-713 feels better [02:05:18] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Thank you letters for our donors who donate via UKFC - https://phabricator.wikimedia.org/T89512#1038546 (RLewis) @awight haven't been imported that was meant to be. [02:05:19] My brain is a wee bit fried so actually don't expect anything intelligent! ;) [02:05:46] Me too, and I'm not actually sure why. [02:06:37] Mmm I'm sure that managerial stuff is pretty exhausting! [02:06:53] OH. Right, that stuff. [02:07:03] I did do a lot of that. [02:07:48] I ordered cupcakes [02:07:54] wh... [02:08:02] for my daughter's birthday party tomorrow [02:08:12] Ah, nice [02:08:22] yeah! She's really excited [02:08:38] How old is she? [02:08:48] She actually turned 7 at the end of December, but we weren't here, and she didn't have the chance to celebrate with her friends here in Montreal [02:08:57] Aaah, cool. :) [02:09:13] Yeah! It's an indication that she's integrating prety well [02:09:38] her sister, who is 9, has had more trouble, but is also doing better than before... [02:10:30] At least now she wears a hat when she goes outside in the cold" [02:10:31] ! [02:10:56] § Fundraising Tech Backlog: Hackathon idea: Make DI Friendly - https://phabricator.wikimedia.org/T89188#1038558 (K4-713) [02:11:08] http://www.theweathernetwork.com/weather/canada/quebec/montreal [02:11:42] Weee! -7 degrees F [02:11:47] § Fundraising Tech Backlog: Hackathon idea: Make DI Friendly - https://phabricator.wikimedia.org/T89188#1029500 (K4-713) [02:13:08] * AndyRussG 's brain sloshes about aimlessly [02:15:16] § Fundraising Tech Backlog: Hackathon idea: Make DI Friendly - https://phabricator.wikimedia.org/T89188#1038563 (K4-713) [02:15:33] AndyRussG: If you're still sloshing around here for some reason (?), check out that card. [02:15:41] ah also gotta groom the backlog for quotables! [02:16:26] K4-713: the DI one just there ^T89188? [02:16:31] Yeah. [02:16:35] K [02:16:55] See, it's supposed to make our weirdness more accessible. [02:18:35] mmm yeah I'm getting that! [02:18:43] AndyRussG: Also, the thought occurs that if you wanted to work on DI, this might be a fun way to start. [02:18:55] How do you feel about hackathons? [02:19:57] K4-713: hmmm... I'm happy to work on DI and also help make it friendlier in the process [02:20:32] Groovy. [02:20:33] WRT the upcoming France hackathon, I was kinda hoping to uh... skip it and do Wikimania instead, for entirely non-work reasons... ;) [02:20:43] Yeah, no worries there. [02:20:55] Ah! OK, that's cool, thanks :) [02:21:04] I'm not even sure if anybody is going to go for this, really. [02:21:11] * K4-713 shrugs [02:21:11] I'll have fun showing folks around Mexico City tho! [02:21:37] * AndyRussG finishes reading... [02:21:41] I'd always rather do Wikimania, I think. Though, I've never tried to bring a project to a hackathon. [02:21:57] Maybe that's what's going to flip the switch. [02:22:22] I always want to go find something good to do, and hit walls until I give up and do strange things to DI. [02:24:00] hmmm [02:24:18] It looks interesting! I don't know enough about the details of DI to understand some bits of it [02:24:40] I'm going to make subtasks that anybody could decipher with a checkout in front of them. [02:24:46] I've also never been to one of our hackathons so I don't know much about what they're like [02:24:57] cool! [02:25:51] You should go to one. [02:26:01] And if you get to go to Wikimania, there's one in front of that, too. [02:26:48] Ah OK! Right didn't know about that, that makes sense [02:29:20] Yeah in fact I think we're going to try to bring the whole family to Mexico City during Wikimania and stay on some time before and/or after [02:29:30] § Fundraising Tech Backlog: Hackathon idea: Make DI Friendly - https://phabricator.wikimedia.org/T89188#1038588 (K4-713) [02:29:39] So if there's a pre or post mania hackathon, that'll work nicely :) [02:32:53] Man, that venue! It's way in the north of the city (or of the city proper) totally not the neck of the woods I lived in [02:33:13] § Fundraising Tech Backlog: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1038610 (K4-713) [02:35:17] Okay, I'm super out of here. [02:35:47] * K4-713 waves [02:50:20] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, § Fundraising Sprint Devo: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1038646 (AndyRussG) Hi all! A temporary fix with the amendment mentioned above (turning on sampling of Special:RecordImpression for an... [03:00:05] MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising, § Fundraising Sprint Devo: Special:BannerRandom causing lots of fatal error messages - https://phabricator.wikimedia.org/T89258#1038665 (AndyRussG) BTW, we're capturing some extra info about the phantom code execution in fluorine:/a/mw-log/T89258.log...