[00:04:58] ejegg: K4|missing: awight: wohooo! No more extra round-trips on mobile on the beta cluster! :) [00:05:07] Now we just gotta deploy the same config to prod [00:05:13] \o/ [00:05:28] * AndyRussG dances a performance-improvement jig [00:05:41] nice! [00:05:41] (that's allowed over IRC, not recommended for hangouts, tho) [00:05:46] :) [00:35:54] § Fundraising Sprint Devo, Fundraising-Backlog: BUG: Internal fraud "reject" data does not match GC's numbers; seems too high - https://phabricator.wikimedia.org/T89190#1045319 (Ejegg) This was my fault. On 2/5, I deployed a change to the payments cluster but not to the machine that runs our orphan script to... [00:37:07] AndyRussG|bassoo: I want to see that jig later. :p [00:55:06] K4-713: which jig? [00:55:28] The bassoo? [00:55:35] The jig you danced for removing one round trip from mobile. [00:56:05] Seems like a good one. :) [00:56:33] K4-713: aaaaah maybe at the next karaoke? [00:56:50] Definitely. [00:57:54] § Fundraising Tech Backlog: payments_initial and payments_fraud should each have a single entry for each order_id. - https://phabricator.wikimedia.org/T89782#1045366 (Ejegg) NEW [01:01:49] § Fundraising Sprint Devo, Fundraising-Backlog: BUG: Internal fraud "reject" data does not match GC's numbers; seems too high - https://phabricator.wikimedia.org/T89190#1045373 (Ejegg) Update: Katie points out that many of the spurious 'reject' lines are actually abandoned transactions. Between the updated o... [01:02:13] :) [02:14:41] MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1045534 (AndyRussG) I'm pretty sure the more permanent solution should involve: - A logging mechanism that has to be explicitly turned on for a given CentralNotic... [02:58:22] MediaWiki-extensions-CentralNotice, § Fundraising Sprint Devo, Wikimedia-Fundraising: Special:BannerRandom causing lots of fatal error messages - https://phabricator.wikimedia.org/T89258#1045548 (AndyRussG) [11:18:25] § Fundraising Sprint Devo, Wikimedia-Fundraising, Fundraising-Backlog: Deploy Swedish thank you letter - https://phabricator.wikimedia.org/T89611#1046126 (jrobell) thank you @atgo. [15:26:53] §Collaboration-Team, § Fundraising Sprint E, §Collaboration-Team-Sprint-Q-2015-02-25, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, § Fundraising Dash, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1046377 [15:31:29] §Collaboration-Team, § Fundraising Sprint E, §Collaboration-Team-Sprint-Q-2015-02-25, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, § Fundraising Dash, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1046406 [15:33:50] §Collaboration-Team, § Fundraising Sprint E, §Collaboration-Team-Sprint-Q-2015-02-25, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, § Fundraising Dash, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1041302 [16:23:13] §Collaboration-Team, § Fundraising Sprint E, §Collaboration-Team-Sprint-Q-2015-02-25, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, § Fundraising Dash, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1046682 [16:44:01] §Collaboration-Team, § Fundraising Sprint E, §Collaboration-Team-Sprint-Q-2015-02-25, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, § Fundraising Dash, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1046835 [17:02:36] §Collaboration-Team, § Fundraising Sprint E, §Collaboration-Team-Sprint-Q-2015-02-25, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, § Fundraising Dash, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1046905 [17:02:54] §Collaboration-Team, § Fundraising Sprint E, §Collaboration-Team-Sprint-Q-2015-02-25, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, § Fundraising Dash, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1046906 [17:05:29] AndyRussG: I wanted to mention yesterday, the standard around here seems to be that we self-merge configuration changes... [17:05:47] awight: ahhh OK, I think u might have mentioned that before, sorry if I forgot... [17:06:10] IMO that's a strange decision, seems a bit rough-n-tumble [17:06:47] Heh, it's to remind us about the unpredictability of the universe, maybe [17:07:06] :) [17:07:07] awight: BTW I was just about to ask, what about deploy to prod? I _think_ that's not automagic? Apologies if I've also been told of this before and forgotten... [17:07:17] ! log: increasing entropy [17:07:54] AndyRussG: actually that's the creepiest part. There's no deployment branch. You merge to master, then you're bound to keep deployment in sync [17:08:21] Deployment is done by "git rebase" in tin:/srv/mediawiki-staging, then a scap-dir on wmf-config, usually. [17:08:27] sorry, "sync-dir" [17:10:23] awight: riiiight, I was reading that... (but then thought the doc might be out of date) https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment#Change_wiki_configuration (pointed out by K4 yesterday) [17:11:12] looks up-to-date [17:11:19] Ahh cool [17:11:42] But so then it gets merged, and someone still has to push it to prod manually, no? I'd just want to be sure I know when that's going to happen, or maaaaaybe I can do it myself? Do I have to check out a slot? [17:11:53] Also, just remembered, I don't have +2 for mediawiki-conf [17:12:08] The sync-dir or sync-file is what pushes it to production. [17:12:25] AndyRussG: ah. you should rattle a saber! [17:13:22] https://gerrit.wikimedia.org/r/#/admin/projects/operations/mediawiki-config,access [17:13:25] awight: hhmmmm.... [17:13:31] You still don't have +2? [17:14:19] grr. Yeah you aren't in wmf-deployment for some reason. How... are you deploying? [17:15:59] awight: yeah, strange... [17:20:32] Hmmm [17:27:09] Yeah I'm not in that group... uuuuh if I wanted to deploy the config change today, for a superficial reason (like closing the card before prawning) mmm what would you suggest...? [17:31:32] awight: ^ ;p [17:32:24] awight: I'm happy to pull the trigger! [17:33:08] AndyRussG: but I think, if you've already been approved for deployment, you can get someone to flip that switch in a matter of minutes. [17:33:50] awight: K.... I'll try and I'll let u know if I get stuck then? thanks!!! [17:36:25] AndyRussG: totally. I'm available all day, either way. [17:36:54] awight: thanks [17:36:55] :) [17:36:57] awight: Sorry to hear about the plague. [17:38:20] K4-713: the pneumonia complication is the only real issue... [17:38:30] That's kind of a big deal. [17:38:46] The wikipedia article calls it "the captain of the men of death" :) [17:38:54] Mom always said not to F around with pneumonia. [17:38:58] nope. [17:39:02] ...but she was more polite than that. [17:39:07] no effing. no around. [17:39:29] Indeed. [17:40:19] * awight imagines Mrs. Horn up in everyone's business :) [17:40:46] That's pretty much what she does, so... accurate. [17:41:14] I've usually got a mundane imagination. [17:41:20] Usually she's just trying to help. [17:41:22] Usually. [17:42:20] Except for last night, the dreams were a total freak show. Rich kids keeping meat in cellars; a psychopath I knew, triggered by character in book with same name... [17:42:29] Yikes. [17:43:06] At one point I battled him, I was holding the business ends of two razor saws and he was idly pushing them at my head [17:43:09] charming [17:43:20] My dreams last night started with me experimenting with heating up pasta sauce in jars with laser beams. It was working out pretty well. [17:43:22] So where's the meat frum? [17:43:29] oh. That works? [17:43:34] No? [17:43:35] haha [17:43:37] You need a stupid maser [17:44:16] I made a label with a particular kind of spot painted on, that would absorb the IR better or something. [17:44:20] Oh, I just read the twilight zone collection, that was fun. [17:44:33] nice. Only the chunks heated up [17:45:36] The funny thing was, in my dream I wasn't trying to make money off it or anything, so much as I was trying to impress somebody. [17:45:47] I think it worked? [17:45:53] Alarm went off. Guess I'll never know. [17:47:14] That's perfect, so then you remembered into the real world and could still use the story to impress :p [17:47:52] Hum. [17:47:56] Interesting. [17:48:36] "In my dreams, I cooked for you with laser beams" = Hook for an amazing new punk song I'm going to write. [17:48:57] ...brb, relocating [17:49:10] * AndyRussG munches popcorn [17:50:52] * awight rubs hands at thought of explaining to imaginary new hires where fearless leader has run off to. [17:51:10] The laser kitchen. Obviously. [17:51:12] bahaha [17:51:59] brb, we're feeding crickets to the baby chickens. U(K)FC! [17:52:11] ooo [17:52:38] If I could borrow your chickens, what... would that even look like? [17:53:01] Apparently they like to eat this stuff that is constantly taking over my yard. [17:53:05] Anyway: video? [17:56:17] K4-713: sure, I guess the internet is used for all kinds of other terrible things, this won't be adding much to the heap :p [17:56:34] ha [17:56:42] I added a thing to the thing. [17:56:48] And by that I mean, a chat to the meeting. [17:57:24] oh. I tried and failed [17:57:42] Woah. What just happened to qc? [18:00:15] db error: unknown error? [18:02:28] trying to delete from the group contact cache, it looks like [18:03:40] oh, Lock wait timeout exceeded; try [18:03:42] restarting transaction [18:13:59] § Fundraising Sprint E, Fundraising-Backlog: Plan development for LATAM - https://phabricator.wikimedia.org/T86107#1047193 (atgo) [18:16:56] anybody have anything to raise at scrum of scrums? [18:18:22] ejegg: Mention the PCI thing next week? [18:18:33] k, will do [18:19:52] ejegg: There's just one guy, and he's here from the 24th through the 26th. :) [18:19:59] cool [18:22:00] argh, most useless stack trace of all time: DB Error: unknown error in CRM_Core_Error::exceptionHandler() [18:22:03] that's a lie. [18:22:37] the queue consumer fail? [18:24:25] yah [18:24:43] I do see what happened, I'm just smarting a bit at the exception message [18:25:15] i like the full dump of all arguments to all frames that precedes it though [18:25:28] also, I patched Civi a long time ago to emit the mysql error code rather than "unknown error", maybe I need to repatch. [18:25:48] does the dump still include the db password? :p [18:25:56] oof, and all kinds of PII [18:26:00] Jeff_Green: Good aftermath. :) Did you get that stuff I sent you? [18:26:10] Because I have more now. [18:26:15] the PCI stuff? [18:26:18] yep [18:26:25] i did get it but I haven't had a chance to read yet [18:26:43] I think it's largely going to be you for the first day or something. [18:26:58] ...the spreadsheet/checklist is really precise about what they need to verify. [18:27:04] mobilizing... [18:27:09] o_O [18:27:14] ok. quick reminder, which day are we talking about? [18:27:22] He gets here on the 24th. [18:27:25] ok [18:27:37] Probably staying until the 26th, unless it's all easier than he thinks. [18:27:45] alright [18:27:49] I should say "through the 26th". [18:35:46] § Fundraising Sprint Devo, Fundraising-Backlog: BUG: Internal fraud "reject" data does not match GC's numbers; seems too high - https://phabricator.wikimedia.org/T89190#1047255 (CCogdill_WMF) Thanks, @ejegg! I got the server info and will work on getting the data for Pats. I think this is solved now... [18:35:52] § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Collaboration-Team, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1047256 [18:42:00] § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, § Fundraising Sprint Devo, § Fundraising Tech Backlog, §Collaboration-Team, §Analytics-sprint-2015-01-08, § ... - https://phabricator.wikimedia.org/T89646#1047275 [18:43:07] hey ccogdill i feel like i'm going crazy... we had a bug for country=xx, right? [18:43:17] * K4-713 frowns [18:43:28] Can you say more about that? [18:43:41] the geolocation one? [18:43:49] yeah but I think you closed it last week atgo [18:43:56] we weren’t seeing new reports of it [18:44:03] yeah i thought so... [18:44:07] or at least took it out of sprint [18:44:08] … except that I might have seen on yesterday [18:44:08] now can't find [18:44:15] How was this manifesting in your world, ccogdill? [18:44:33] donors emailing saying they were getting sent to pages for countries/languages that didn’t make sense [18:44:56] That makes partial sense to me, yeah. [18:44:57] this was a thing a few months ago, remember K4-713? [18:44:58] we had someone yesterday who said they were browsing wikipedia in English and got sent to a Spanish form. that’s uselang and not country but seemed possibly related [18:45:06] XX has always been a thing for us. [18:45:18] yeah well AndyRussG found a "high number" of XX in a debugging thing the other day [18:45:26] so i'm trying to connect them in phab and i can't for the life of me find th ebug [18:45:28] atgo is this the task you were looking for? T87677 [18:45:31] It's just that people who can't be geolocated properly, shouldn't be getting fundraising banners. [18:45:44] aaaah yes [18:45:47] So, I'm wondering how they got in the pipe to begin with. [18:45:47] thank you ccogdill [18:45:51] well… we can’t say for sure they didn’t click the sidebar [18:45:55] no problem atgo! [18:46:05] Yeah: Sidebar or email, I think. [18:46:11] mhmm [18:46:18] Do the email links force a country? [18:46:23] no [18:46:47] § Fundraising Sprint Devo, MediaWiki-extensions-CentralNotice, Wikimedia-Fundraising: Special:BannerRandom causing lots of fatal error messages - https://phabricator.wikimedia.org/T89258#1047287 (atgo) @andyrussg interesting that you're seeing a high prevalence of country=XX. We've gotten a smattering of repo... [18:46:54] oh my god i hate wikibugs [18:47:08] Maybe it's ipv6 taking over and still not being fully-baked in the geolocation db. [18:47:14] hargh. [18:47:24] § Fundraising Sprint Devo, § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, §Analytics-sprint-2015-01-08, § Fundraising Tech Backlog, §Collaboration-Team, § ... - https://phabricator.wikimedia.org/T89646#1047291 [18:48:06] atgo: K4-713 yeah could be... I guess I'm not sure what the real XX numbers are, just that that seemed very high... [18:48:15] mhm [18:48:22] ...hmmm. [18:48:27] How far were they getting? [18:48:35] weird... i'm going to reopen the bug in case we have more reports [18:48:40] If some of them got to payments, there might be more informative logs there. [18:49:11] k4-713 - the person who reported the uselang issue got to payments. is that helpful or unrelated? [18:49:15] * K4-713 grumbles about contribution tracking not working on donate wiki anymore [18:49:25] ccogdill: That would be totally helpful. [18:49:30] k let me see [18:49:32] § Fundraising Sprint E, § Fundraising Tech Backlog, Fundraising-Backlog: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1047308 (atgo) declined>Open And more reports happened from T89258, so reopening for posterity. [18:49:34] If they got in far enough to get a contribution tracking ID... [18:49:42] ...we can run some fun queries. [18:49:45] ccogdill: could you add this to the phab task? ^ [18:50:10] sure! [18:50:13] k4-713 cid=10678379 [18:50:20] groovy. [18:50:24] wait 1. :) [18:50:37] AndyRussG: if you think T88614 is done, move it to deployed? [18:50:45] k! for info - he’s Swedish, browsing in English, got a Spanish form and TY letter [18:50:54] § Fundraising Sprint E, Wikimedia-Fundraising, Fundraising-Backlog: Deploy Swedish thank you letter - https://phabricator.wikimedia.org/T89611#1047314 (atgo) [18:51:14] did he manage to donate in spanish...? [18:51:32] That's... odd. [18:52:17] yeah he did [18:52:17] I'm seeing en_US, and a a campaign and banner and everything. [18:52:30] I saw the TY email, definitely Spanish [18:52:42] utm_source = B12_5C_112721_Sandwich_Sandwich.no-LP.cc. [18:52:49] ...wth? [18:53:26] Sandwich banner. [18:53:44] I... have no idea what they're doing anymore. [18:53:47] hah whatever that means... [18:54:01] Also, it's some kind of double sandwich. [18:55:08] Ah, I can look at this more closely in a few minutes, but there should definitely be enough clues to pin this one down. [18:55:24] This guy is from everywhere. [18:55:34] atgo: thanks! It's done in my view. I didn't hear opinions on the very last details in collab, but I know everyone's busy... quien calla otorga [18:56:06] ccogdill: Just one more question, though: What makes you think this is a country=XX thing? [18:56:13] I'm not seeing that anywhere. [18:56:15] cool, AndyRussG, i'm working on a response to you remail :) [18:56:27] Lots of actual countries. [18:56:48] k4-713 - I don’t know that it is. I just figured if the language was off, country could have played a part in that [18:56:57] also weird that you’re seeing US for him [18:57:00] when he’s in Sweden [18:57:22] There may have been some inane default somewhere for XX, I suppose. [18:57:27] K4-713: "XX" lives in bannerController as fallback country when none could be determined (I guess you knew that) (and maybe it's elsewhere too? dunno) [18:57:37] AndyRussG: Yep, I know. [18:57:51] But, those people should not get banners that are specifically geolocated, right? [18:58:07] K4-713: correct [18:58:33] hmmm [18:58:40] That's why I'm headscratching. I mean, it might be happening anyway, but that would be problem #1. [18:58:50] okay, gotta go. Meeting. [18:58:56] have fun! [19:01:52] § Fundraising Sprint Devo, § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, §Analytics-sprint-2015-01-08, § Fundraising Tech Backlog, §Collaboration-Team, § ... - https://phabricator.wikimedia.org/T89646#1047341 [19:02:38] § Fundraising Sprint E, § Fundraising Tech Backlog, Fundraising-Backlog: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1047348 (CCogdill_WMF) We got a new report of this on 2/17, which was a uselang issue (not sure if the country was correct or not). A Swed... [19:06:21] § Fundraising Sprint Devo, § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, §Analytics-sprint-2015-01-08, § Fundraising Tech Backlog, §Collaboration-Team, § ... - https://phabricator.wikimedia.org/T89646#1047357 [19:11:10] Continuous-Integration, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, § Fundraising Sprint E, Release-Engineering: Deploy CiviCRM integration job to WMF integration server - https://phabricator.wikimedia.org/T86374#1047381 (atgo) Cool. Sounds good. I was going to say we should get all the blockin... [19:14:41] § Fundraising Sprint E, § Fundraising Tech Backlog, Fundraising-Backlog: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1047408 (atgo) p:High>Normal [19:16:39] (PS1) Ejegg: Fix joins between payments_fraud and _initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/191382 (https://phabricator.wikimedia.org/T87810) [19:28:16] (CR) AndyRussG: "Thanks!" (7 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [19:38:51] § Fundraising Sprint Devo, § Fundraising Dash: BUG: Fraud widget numbers don't seem right - https://phabricator.wikimedia.org/T87810#1047498 (Ejegg) Oops, looks like the widget was wrong after all. I was joining the payments_fraud table to the payments_initial table using contribution tracking ID, when I sho... [19:45:21] § Fundraising Sprint Devo, § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, §Analytics-sprint-2015-01-08, § Fundraising Tech Backlog, §Collaboration-Team, § ... - https://phabricator.wikimedia.org/T89646#1047507 [19:46:57] § Fundraising Sprint Devo, Wikimedia-Fundraising-CiviCRM: BUG: Gateway Reconciliation Report not pulling all donations - https://phabricator.wikimedia.org/T89288#1047510 (awight) @Ppena: Thanks for letting us slide by with this bug, for now! Yes, we can certainly find a long-term solution. I think @RLewis h... [19:49:10] atgo: Ouch! Good luck with the phab sprint "upgrade" [19:50:08] § Fundraising Sprint Devo, § Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Prevent extra round trips due to mobile redirect - https://phabricator.wikimedia.org/T86101#1047528 (awight) [19:50:37] § Fundraising Sprint Devo, Wikimedia-Fundraising-CiviCRM: BUG: Gateway Reconciliation Report not pulling all donations - https://phabricator.wikimedia.org/T89288#1047529 (atgo) p:Unbreak!>Normal Downgrading priority since we have a workaround. @awight I'm assuming some of this will become better when w... [19:50:43] * atgo sighs [19:51:02] when is the offsite today? [19:51:03] ;) [19:51:26] awight: Like, now? :) [19:51:47] * awight sets an alarm to repeat daily [19:52:01] One week of offsites. [19:52:15] I... guess I'm always off of *some* site. [19:54:14] When we all get burned out by relaxing, we can upgrade to having offshores. [19:54:22] oooooooooh. [19:54:48] Now I'm thinking about Snow Crash. [19:54:55] Kind of like that. [19:55:21] too bad, I've lost all the detail from that book [19:55:30] Low impulse control? [19:55:35] offshores... yessss [19:55:36] it's funny reading things at too young, then re-reading [19:55:40] You should at least remember that bit. [19:55:44] nope. [19:55:44] you guys know me. i'm always down. [19:56:00] atgo: You want to Serious Lunch? [19:56:05] O_o [19:56:15] i'm at the research and data thing [19:56:17] Sirius lunch [19:56:19] what is a Serious Lunch? [19:56:28] I think we should go places and eat things, right, in the *same place we order them*. [19:56:34] Restaurants, you see, have tables. [19:56:41] It's crazy. [19:57:40] * awight tinges green [19:58:08] I mean, as much as I enjoy spending the majority of all my awake time in the same 30-foot radius... [19:58:09] Don't worry guys, I have a jar of broccoli soup in my backpack... I'll just be right here :p [19:58:25] aww. [19:58:34] pizzzacat: What's your food situation today? [19:58:47] aww well that sounds fun [19:59:03] but... i have a fuzzball with me who isn't allowed. and i'm in a thing [19:59:04] enjoy :) [20:00:56] § Fundraising Sprint Devo, § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, §Analytics-sprint-2015-01-08, § Fundraising Tech Backlog, §Collaboration-Team, § ... - https://phabricator.wikimedia.org/T89646#1047627 [20:02:04] Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising: Improve Civi error reporting - https://phabricator.wikimedia.org/T89868#1047647 (awight) NEW [20:04:04] Sigh, I can't find a task for fixing the rejected chargeback messages, but still can't tell whether the Phabricator search is at all reliable. [20:04:37] Are you subscribed to... emails for the backlog? [20:05:01] * K4-713 looks mildly sad [20:05:38] § Fundraising Sprint Devo, § Fundraising Tech Backlog, Wikimedia-Fundraising: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1047704 (awight) NEW [20:06:09] * awight slams locker [20:06:09] Oops. I have a meeting in an hour. [20:06:17] No serious lunch for me. [20:06:22] O_O [20:07:07] Okay, I have a big announcement to make, everyone, I hope this isn't too inconvenient. I'm adding a 1-point task to the next five hours of this sprint. [20:07:24] Five hours? [20:07:29] § Fundraising Sprint Devo, § Fundraising Tech Backlog, Wikimedia-Fundraising: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1047704 (awight) [20:07:57] I donno, I take the mental short-cut of ending each sprint at the end of Wed... [20:08:19] heh [20:08:35] Okay, I'm fooding. Forget you guys. :p [20:08:40] +1! [20:08:52] (which ==1) [20:09:05] (and 0!) [20:10:22] Γ("Surprise"). I guess that's why we stick with integer exclamations "!" [20:15:26] hey awight... this is your scrum master speaking [20:15:48] what's up with this? https://phabricator.wikimedia.org/T89871 [20:15:53] Whoa [20:16:09] It's data loss [20:16:26] I talked to K4|food about this last week, I think neither of us realized until today that there was no task yet. [20:16:43] ah cool [20:17:16] The issue is, once K4 fixed the GlobalCollect audit import to pull in chargebacks, we started seeing that there's always (?) an amount discrepancy between the original contribution and what was chargeback-refunded. [20:17:24] maybe we should add it to the next sprint (starting, you know, tomorrow) instead? [20:17:46] That is causing us to reject the messages, when instead we should accept fate. [20:17:49] um... [20:17:51] * awight double-checks the sprint [20:18:22] yeah, I jumped on this cos I don't have anything else in the sprint, afaict [20:18:22] what do you think? [20:18:43] wat? [20:19:10] sorry, what do I think about what? [20:19:10] got it [20:19:26] nvm [20:20:24] ejegg: hey... are you back to life? Just under an igloo? [20:20:50] yeah, hunkering down here [20:21:02] If you have the chance, please link patchsets to https://phabricator.wikimedia.org/T86266 (notification bot on vacation?) [20:21:09] and uh lemme know if it's PCR [20:21:18] oh, for sure [20:21:57] Glad to hear you're weathering it well. We had a crummy weekend of sick. [20:22:12] i can't believe you're not hibernating, ejegg [20:22:35] Wait, I though he was? [20:22:46] seriously tempted [20:22:48] Just with quick bursts of metabolic activity during the work day :p [20:23:51] atgo: Hey, can I use you as a proxy for PPena? Does it make sense to you if we record the difference in chargeback amount as a fee?? [20:23:51] (PS3) Ejegg: Add push and pop fns to DonationLoggerContext [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190134 (https://phabricator.wikimedia.org/T86266) [20:23:53] (PS3) Ejegg: Use DonationLogger in GatewayPage subclasses [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190135 (https://phabricator.wikimedia.org/T86266) [20:23:55] (PS1) Ejegg: WIP: get rid of shortcut log calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191392 [20:24:04] you know.. i'm not totally sure [20:24:13] but i'm talking to her in 30 minutes [20:24:13] Seems really weird to me, cos it's actually the customer paying the fee?? [20:24:15] i can ask her then [20:24:28] atgo: cool. You clear enough on the question? [20:24:57] the customer doesn’t pay the CB fee - just weighing in here [20:24:57] so the refunded amount is always lower than what was charged, right? [20:25:05] (CR) jenkins-bot: [V: -1] WIP: get rid of shortcut log calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191392 (owner: Ejegg) [20:25:14] ccogdill: ah. Lemme pull up an example, then, maybe there's a bug here. [20:25:26] k [20:25:29] happy to take a look [20:25:51] ccogdill: https://civicrm.wikimedia.org/queue/refund-notifications-damaged/ID:silicon-33582-1422383779863-2:1142473:-1:1:1 [20:26:47] It's GC ID 6691226358 [20:28:30] that’s really weird, awight. it’s possible the donor only submitted a CB for 4.68? I will look at another couple of CBs to check if this seems right [20:28:34] and can look at it with Pats too [20:29:07] ccogdill: ah. Yeah this is happening a few times a day, I believe. Unless the records are repeating... [20:29:19] I have other examples where th CB amount is the same as the order amount [20:29:26] 838754655 [20:29:45] 2021750627 [20:29:56] so I think that’s a weird thing with the user, but will ask Pats [20:30:00] Okay, I'll leave this case open until you learn more. Thanks for taking a look! [20:30:05] mhmm [20:30:17] Should I provide some more examples of differences, or do you have them in email already? [20:30:29] The emails contain the text "Payment amount specified did not match original" [20:31:11] This is good news, at least: these are not happening every day, they're repeated messages. [20:31:30] I think that's happening cos they are never entering our CRM successfully, so the audit job keeps trying to feed them back in. [20:31:56] yeah I have the failmails [20:31:59] (PS1) Awight: Don't reject mismatching refund amounts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 [20:33:00] § Fundraising Sprint Devo, § Fundraising Tech Backlog, Wikimedia-Fundraising: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1047907 (awight) There are a small number of these which are being retried every day. Examples: Error: INVALID_MESSAGE Payment amou... [20:36:00] (PS2) Awight: Don't reject mismatching refund amounts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) [20:38:05] (CR) Awight: [C: 2] Use DonationLogger in GatewayPage subclasses [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190135 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:40:24] (CR) Awight: Add push and pop fns to DonationLoggerContext (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190134 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:40:56] ejegg: Sorry to be thick about this, but I still don't get why the pointer math is necessary? [20:43:14] You think I should just rely on strict nesting of scopes? [20:43:28] § Fundraising Sprint E, § Fundraising Sprint Devo, § Fundraising Tech Backlog, Wikimedia-Fundraising: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1047704 (awight) [20:43:54] ejegg: You could make that an invariant... [20:43:58] (Merged) jenkins-bot: Use DonationLogger in GatewayPage subclasses [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190135 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:44:35] awight: just wanted to make sure each instance is only acting on the stuff it added, even if another instance is doing something else [20:44:36] awight: K4|food: know offhand who I need to ping in ops to get into the Gerrit wmf-deploy group? [20:44:52] ejegg: what do you mean by instance? [20:44:58] there's no threading... [20:45:02] PHP-- :( [20:45:29] I was walking in the countryside when I came upon a cow [20:45:32] yeah, maybe overkill [20:45:48] Caminando por el bosque una vaca me encontré [20:45:50] COW is great :p [20:46:04] (to the tune of "Oh Susanna" [20:46:05] ) [20:46:25] AndyRussG: I don't know this aphorism yet :D [20:46:42] oh wait, it's only Wednesday [20:46:43] But you're reminding me of a pretty darn funny multithreading joke... [20:46:57] * AndyRussG saves his offtopicsillies for Friday [20:47:08] awight: what's that? [20:47:39] Trying to search for original so I don't completely butcher... [20:48:22] but anyway, it's along the lines of, I wrote this really great program with prints out "Hello, world", then wrote a multithreaded version: [20:48:41] It prints ", worlddddddddddd..." [20:49:46] Sigh, looks like I was told an original joke a couple years ago and now it's gone forever. [20:51:04] oh dear. Library neighbor seems to be a freelance CPA or something, and he's having a quietly muttered stressful day. Relocating :) [20:52:51] haha re: joke [20:57:33] awight: Adding the push function gives me a good reason to keep track of local settings. Take the GC orphan adapter's constructor [20:57:48] 1 -> parent constructor creates log context [20:58:11] 2 -> parent constructor creates DonationData object, adding new prefix to context [20:58:37] 3 -> orphan constructor modifies identifier [20:59:18] if the DonationData object is destroyed, we want to preserve the modified identifier [21:00:14] § Fundraising Sprint Devo, § Fundraising Dash: BUG: Fraud widget numbers don't seem right - https://phabricator.wikimedia.org/T87810#1048002 (atgo) @ejegg - is this done? I wonder if we should make a "release" column in #fr-dash to store the next set of changes to go out in a deploy? [21:00:42] § Fundraising Sprint E, § Fundraising Sprint Devo, § Fundraising Tech Backlog, Wikimedia-Fundraising: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1048007 (awight) Followon task: Looks like the discrepancy is not expected. Find out what's going on, and dep... [21:01:56] ejegg: maybe RAII is not right for this... [21:02:29] I'm fine with merging the code as it is, it just strikes me as much more complex than what we're trying to accomplish. [21:02:35] AndyRussG: To answer your question from a while ago: Try ^d. [21:03:10] K4-713: cool thanks! :) [21:03:45] awight: yeah, singleton gateway_extras classes are also making me question RAII [21:03:56] awight: Did you talk to ccogdill about the chargeback mismatch amount stuff? [21:04:10] yep! in a meeting with Anne and Pats now [21:04:14] Neat. [21:04:15] we will review and let you know [21:04:17] :) [21:04:17] Just making sure. :) [21:04:51] K4-713: fyi, I decided to push the simple part through as its own task: stop rejecting msgs [21:05:10] Then, we can chase down the discrepancy more thoroughly. [21:05:31] awight: I think maybe we still want to reject and YELL LOUDLY if the refund or chargeback is greater than the original amount. [21:05:45] Or, maybe we just stick to the yelling? [21:05:46] that is so smart. [21:05:47] fixing. [21:09:24] Oh wow, I just noticed I'm rounding a currency code. [21:09:32] uhh [21:09:36] How? [21:09:59] I think that == ''. [21:12:24] (PS12) AndyRussG: WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [21:14:48] (PS13) AndyRussG: WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [21:19:54] § Fundraising Sprint E, § Fundraising Sprint Devo, § Fundraising Tech Backlog, Wikimedia-Fundraising: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1048081 (CCogdill_WMF) @awight we're pretty sure we know why this happened. Both of the transactions we were l... [21:20:28] Cool. [21:20:32] (PS3) Awight: WIP Don't reject mismatching refund amounts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) [21:25:11] (PS4) Awight: WIP Don't reject mismatching refund amounts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) [21:29:09] § Fundraising Sprint Devo, § Fundraising Sprint E, § Fundraising Dash, §Collaboration-Team-Sprint-P-2015-02-11, § Wikidata-Sprint-2015-01-21, §Collaboration-Team-Sprint-Q-2015-02-25, §Analytics-sprint-2015-01-08, § Fundraising Tech Backlog, §Collaboration-Team, § ... - https://phabricator.wikimedia.org/T89646#1048098 [21:35:52] Continuous-Integration, Release-Engineering, § Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, § Fundraising Sprint E: Configure Jenkins to run CiviCRM builds only on Fundraising CI slaves - https://phabricator.wikimedia.org/T89895#1048130 (awight) NEW a:awight [21:43:29] Continuous-Integration, Release-Engineering, § Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, § Fundraising Sprint E: Run CiviCRM testing scripts during CI - https://phabricator.wikimedia.org/T89896#1048160 (awight) NEW a:awight [21:52:09] Continuous-Integration, § Fundraising Sprint E, § Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Release-Engineering: Create CI slave instance for CiviCRM testing - https://phabricator.wikimedia.org/T89894#1048189 (atgo) Hey @awight why is this in all of the past sprints? [21:52:41] atgo: ugh, Phabricator is trying to be helpful, by copying all of the parent attributes. [21:52:49] hahahah i see [21:52:50] fixing... [21:52:53] sill phabricator [21:53:01] it's like... so close to knowing things :P [21:53:26] Oh, you didn't hear? They replaced the back-end with Mingle. [21:53:42] Continuous-Integration, § Fundraising Sprint E, § Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Release-Engineering: Create CI slave instance for CiviCRM testing - https://phabricator.wikimedia.org/T89894#1048191 (awight) [21:53:55] * K4-713 cries [21:54:08] We call it "Mangle". [21:55:03] 8D [21:56:25] Continuous-Integration, § Fundraising Sprint E, § Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Release-Engineering: Configure Jenkins to run CiviCRM builds only on Fundraising CI slaves - https://phabricator.wikimedia.org/T89895#1048206 (awight) [21:57:26] (CR) Ejegg: "How do you wrap a failure with this? Should it be possible to indicate the errors on unrecoverable failure?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 (owner: Awight) [21:57:59] phangle? [21:58:03] phabringle [21:58:05] pringles? [21:58:08] i'm hungy. [21:58:11] hungry. [22:00:18] hey pizzzacat ejegg - what are you guys thinking for pushing Dash stuff to prod? Just sort of as it comes or would you prefer to work on releases or...? [22:01:18] (CR) Awight: "Agreed, I need to backport that from here, https://gerrit.wikimedia.org/r/#/c/189153/8/gateway_common/PaymentResult.php,unified" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 (owner: Awight) [22:01:21] frequently would be good [22:01:58] repositioning butt... [22:02:18] not that we've got some visible evidence of the new boards [22:02:22] *now that [22:03:17] oh, I guess we maybe should wait till you can save new boards, or put in a nice default [22:04:14] (CR) Ejegg: [C: 2] Don't senselessly repeat base class code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189134 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [22:04:48] § Fundraising Sprint Devo, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Spike: what to do about Special:RecordImpression and Banner History - https://phabricator.wikimedia.org/T88614#1048224 (atgo) @andyrussg I'm going to move this to PCR until we get confirmation from @ellery @meganhernandez_WM... [22:05:24] * atgo has no idea what you're talking about [22:05:27] haha [22:05:29] sorry [22:05:32] it would be so helpful to me to have a staging site [22:05:33] I agree with ejegg [22:05:41] yes I agree with that also [22:05:43] hard to product manage things without being able to see them [22:05:49] it would be useful for me too [22:05:52] is that really an ops thing to have staging? [22:05:53] to test the viz rendering [22:06:01] to set up? [22:06:11] I think so… K4-713 any ideas? [22:06:18] ? [22:06:25] on how to get a Dash staging site? [22:06:29] is that Jeff? [22:06:35] I was about to say "Yes! What are we talking about? " [22:06:36] or some other maze of stuff [22:06:37] i can make a ticket [22:06:39] haa [22:06:42] atgo: we've got the feature done which shows users custom boards based on what's in the database, but not the features that let you save new configs into the db [22:06:49] ah [22:06:51] cool :) [22:06:57] I am finishing that patch right now [22:07:04] or I should say working on one aspect of that patch [22:07:07] This sounds like a Jeff_Green thing, yes. [22:07:09] so if we deployed now, we'd have to also add some db rows to tide users over [22:07:11] coool [22:07:43] Jeff_Green: do you know what it would take to get us a shiny new staging site for Dash? [22:08:07] i guess we'd just run another copy on a different port on lutetium [22:08:17] nice [22:08:31] although...something is rattling around in the back of my brain about complications of running more than one node process on the same machine [22:08:33] so we could have a staging branch point to another port? [22:08:41] one would hope, yeah [22:08:49] Jeff_Green: should i make a task for it in phab? [22:08:54] yespls [22:08:59] pizzzacat: What are you going to use this for, exactly? [22:09:18] will do :) [22:09:21] K4-713: to test visualizations and allow others to see progress, ie Anne [22:09:30] Before they've been merged? [22:09:33] and not get into cividump trouble lands [22:09:37] yes [22:09:40] get some feedback and a sound test environment before we give it to people to play with [22:09:41] Aha. [22:09:46] atgo: That should go in the card. [22:10:01] + add another oauth context in civi, + new tables someplace for staging to store user settings [22:10:35] atgo: Need to be able to put code on this instance that isn't merged in to master. [22:10:42] cool [22:10:48] So, it's not so much "staging" as a controlled sandbox, yeah? [22:10:50] yeah we will set up a staging branch [22:11:08] umm depends how you define staging? [22:11:11] how do you? [22:11:22] I think of it as "testing" [22:11:33] Hah. [22:11:42] The word "test" no longer means anything to me. :) [22:12:00] yeah I was just gonna say.. testing concepts rather than/in addition to functionality [22:12:01] So, usually, "staging" implies that you're testing the deploy branch, before you actually put the exact same thing on prod. [22:12:20] ah ok [22:12:27] well maybe yeah, we can call it a sandbox? [22:12:39] Yeah, that makes it more clear that it's meant to be more... loose. [22:12:50] I'm down with that [22:13:05] But that's also possibly more work for Jeff_Green, because he can't just clone the exact same thing for the deploy process. But you get more flexibility. [22:13:21] I think that's what you're... after? [22:13:22] oh I guess I was thinking they would be from separate branches [22:13:33] honestly until I look into it I'm not sure we can even run two instances [22:13:39] heh [22:13:40] yeah…there is that [22:13:42] § Fundraising Dash, operations: Create staging site for Dash - https://phabricator.wikimedia.org/T87809#1048240 (atgo) p:Normal>Triage [22:13:48] Different problem. :) [22:13:50] * pizzzacat weeps softly [22:13:57] I *think* the issue was the init scripting [22:14:09] pizzzacat ejegg K4-713 could you add context here? https://phabricator.wikimedia.org/T87809 [22:14:38] i.e. I didn't see a sane way for upstart to deal with more than one process named "nodejs" [22:14:43] or something like that [22:15:01] anyway, if you poke in a ticket for the vague wish we can look into it [22:15:18] § Fundraising Dash, operations: Create sandbox site for Dash - https://phabricator.wikimedia.org/T87809#1048263 (K4-713) [22:18:02] § Fundraising Dash, operations: Create sandbox site for Dash - https://phabricator.wikimedia.org/T87809#1048274 (atgo) p:Triage>Normal [22:18:07] thanks, Jeff_Green - I understand [22:18:24] ejegg: hey, have you seen this, while composer updating crm/? [22:18:24] Failed to execute git remote set-url composer 'https://gerrit.wikimedia.org/r/p/wikimedia/fundraising/SmashPig [22:18:28] .git' && git fetch composer && git fetch --tags composer [22:18:29] we can brainstorm about other options after we look into it I suppose. [22:18:31] fatal: No such remote 'composer' [22:18:46] awight: nope, never seen that one yet [22:19:00] Jeff_Green: regarding priorities for that, I marked it as "normal" because it's not on fire [22:19:15] atgo: ok thanks! [22:19:23] It's really too bad that my honeymoon with any PHP tool always begins and ends like this... [22:19:37] * K4-713 takes a second to reflect that things aren't normally on fire anymore [22:19:41] "omfg, I can't believe how bad the status quo is, maybe there's a new standard tool..." [22:19:52] * Jeff_Green wishes one of the priorities was "on fire" with a little animated gif of flames [22:20:01] all I can see online about checking in your vendor/ directory is 1) don't do it [22:20:03] I keep asking for flaming barrels. [22:20:17] ejegg: hehehe [22:20:19] 2) if you do it, .gitignore vendor/.git to allow dev repos [22:20:26] but 2) doesn't work [22:20:27] I know they exist. I have, like, five variations on a floppy at home. [22:20:51] ejegg: yeah, the composer.lock is supposed to take care of tracking issues [22:21:13] assuming you can run composer as part of deployment [22:21:25] right. I think that's where the bad started entering the system [22:22:16] we could and should have a compile step during deployment, but that requires local WMF mirrors of whatever crap we're depending on [22:22:46] the CPAN plague... [22:24:04] so for now just keep nuking/moving vendor/wikimedia before each composer update? [22:24:31] * awight feels creaky in the joints [22:24:38] it's such a terrible situation [22:24:55] § Fundraising Dash, operations: Create sandbox site for Dash - https://phabricator.wikimedia.org/T87809#1048291 (Ejegg) Need to create another OAuth context in Civi Need a db to add the new user preference tables Guessing we want to be able to manage this by pulling arbitrary git commits, not the usual deplo... [22:25:03] ejegg: I liked where you were going last week, want to continue with that? [22:25:21] awight: it didn't actually work, unfortunately [22:25:25] And feel free to kill vendor/ entirely [22:25:27] that might work :) [22:26:21] Even starting fresh with no top-level submodule, whatever I put in .gitignore, I can't convince git to check in a folder with its own .git and treat it normally [22:27:06] I meant, just remove the vendor submodule entirely [22:27:28] And not re-add [22:28:02] except on the deploy branch? [22:28:04] We'll figure something out for CI, maybe keep the crm/vendor repo around and clone explicitly [22:28:11] oh. deployment. siiigh [22:28:24] Still just a rat in a cage [22:28:36] ugh [22:29:02] It's nice having a formal link between the code and vendor/ version [22:29:31] between this and dead-end log ideas, i'm feeling really dumb [22:29:45] What about :( creating actual packagist releases for the goddam wikimedia submodules [22:29:53] whoa [22:30:02] * awight vomits into a bush [22:30:18] crazy, but it should work [22:30:22] baahaha [22:30:32] We should keep polishing this routine [22:31:49] I'd like to know how close WMF is to mirroring packagist or something... maybe this idea has been floated already [22:31:51] hmm, seems pretty low maintenance [22:32:05] oh yeah? u haz link? Is it just creating a git tag? [22:32:33] Luckily, our upgrade cycle on the submodules is very slow. [22:32:47] right on packagist.org: just submit your repo address [22:32:54] oh. [22:32:57] That works [22:33:05] they crawl your package.json 'periodically' [22:33:10] hehe. [22:33:19] I think we just need to fix the CamlCase nonsense [22:33:30] ah, yeah [22:33:38] if we haven't already... [22:34:24] nah, still needs fixin [22:35:22] My kid *loves* to fix stuff. I'm convincing her that she should be able to distinguish a 4-mm allen driver from a 5-mm. She currently simplifies it to "That one is boppa's." [22:49:51] (PS1) Awight: Require phpunit as a development dependency [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191487 [22:50:28] awight: I think I still like the complicated logging context better than passing around logger instances or simple static calls to update shared settings [22:51:16] That's fine with me. We can always come back to this, the usage is plenty clean, which is all I really care about! [22:51:42] cool, maybe a beautiful fourth way will occur to me later [22:52:13] hehe sorry to bust yr pair [22:52:41] hey, it's instructive [22:52:42] * awight shocks self at crude remark [22:52:47] :p [22:53:13] conclusion: "do not trust that bad haircut guy" [22:53:23] hehe [22:53:25] still waiting for my self-administered hack job to grow in :( [22:53:47] Gotta use a Flobee next time [22:54:18] (PS1) Awight: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191488 [22:54:28] (CR) Awight: [C: 2] update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191488 (owner: Awight) [22:54:32] (Merged) jenkins-bot: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191488 (owner: Awight) [23:02:36] (PS14) AndyRussG: WIP: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [23:03:14] one sec... [23:12:39] § Fundraising Sprint Devo, MediaWiki-extensions-CentralNotice: CentralNotice bucket improvements, step 3 bis part 1: remaining test details - https://phabricator.wikimedia.org/T86091#1048408 (AndyRussG) Closing sooooooooooooon! [23:13:01] § Fundraising Sprint Devo, § Fundraising Tech Backlog, § Fundraising Sprint E, MediaWiki-extensions-DonationInterface: Move any remaining controller logic out of the form classes - https://phabricator.wikimedia.org/T86251#1048409 (awight) [23:22:57] Continuous-Integration, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Release-Engineering: Deploy CiviCRM integration job to WMF integration server - https://phabricator.wikimedia.org/T86374#1048438 (atgo) [23:23:42] § Fundraising Sprint E, § Fundraising Tech Backlog, Fundraising-Backlog: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1048446 (atgo) [23:25:54] § Fundraising Sprint E, § Fundraising Tech Backlog, Fundraising-Backlog: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1048464 (awight) [23:26:17] Continuous-Integration, § Fundraising Sprint E, § Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Release-Engineering: Run CiviCRM testing scripts during CI - https://phabricator.wikimedia.org/T89896#1048160 (awight) [23:26:32] Continuous-Integration, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, § Fundraising Sprint E, Release-Engineering: Configure Jenkins to run CiviCRM builds only on Fundraising CI slaves - https://phabricator.wikimedia.org/T89895#1048130 (awight) [23:26:41] Continuous-Integration, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, § Fundraising Sprint E, Release-Engineering: Create CI slave instance for CiviCRM testing - https://phabricator.wikimedia.org/T89894#1048122 (awight) [23:26:54] § Fundraising Sprint E, § Fundraising Tech Backlog: [3 hours] BUG: GC CC donations inconsistent in when they reach Civi - https://phabricator.wikimedia.org/T89016#1048471 (atgo) [23:27:21] § Fundraising Sprint E, Fundraising-Backlog: Plan development for LATAM - https://phabricator.wikimedia.org/T86107#1048472 (awight) [23:27:52] § Fundraising Sprint E, § Fundraising Tech Backlog: [3 hours] BUG: GC CC donations inconsistent in when they reach Civi - https://phabricator.wikimedia.org/T89016#1025478 (atgo) @ccogdill_wmf is this a carryover from Mingle or something new? If so, could you add a link back? [23:29:13] § Fundraising Sprint E, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Civi feature: bulk send TY letters to donors who don't receive them when they donate - https://phabricator.wikimedia.org/T89516#1048482 (awight) [23:29:50] § Fundraising Sprint E, § Fundraising Sprint Devo, § Fundraising Tech Backlog, Wikimedia-Fundraising: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1048486 (atgo) a:awight [23:30:28] § Fundraising Sprint E, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1048488 (awight) [23:33:58] § Fundraising Tech Backlog, Wikimedia-Fundraising: Set up out-of-sync alerts so that the tech team immediately discovers translations ready for publishing - https://phabricator.wikimedia.org/T89910#1048498 (awight) NEW [23:35:34] § Fundraising Sprint E, § Fundraising Tech Backlog: [3 hours] BUG: GC CC donations inconsistent in when they reach Civi - https://phabricator.wikimedia.org/T89016#1048512 (CCogdill_WMF) @atgo it's a carryover from Mingle, but I included an update on 2/9 which was post-Mingle. https://wikimedia.mingle.thought... [23:40:16] § Fundraising Sprint E, Wikimedia-Fundraising, Fundraising-Backlog: Deploy Swedish thank you letter - https://phabricator.wikimedia.org/T89611#1048516 (atgo) a:atgo>None [23:40:24] § Fundraising Sprint E, § Fundraising Tech Backlog: [3 hours] BUG: GC CC donations inconsistent in when they reach Civi - https://phabricator.wikimedia.org/T89016#1048517 (atgo) a:atgo>None [23:40:31] § Fundraising Sprint E, § Fundraising Tech Backlog, Fundraising-Backlog: BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1048518 (atgo) a:atgo>None [23:41:22] § Fundraising Sprint E, § Fundraising Sprint Devo, § Fundraising Dash: BUG: Fraud widget numbers don't seem right - https://phabricator.wikimedia.org/T87810#1048520 (Ejegg) [23:42:04] § Fundraising Sprint E, § Fundraising Sprint Devo, § Fundraising Tech Backlog: Logging should be handled outside of core gateway class - https://phabricator.wikimedia.org/T86266#1048523 (Ejegg) [23:43:26] K4-713: that seems like a huge conversion loss to have the job posting under "Fundraising" rather than "Engineering" [23:43:55] pizzzacat1: K4-713 http://etherpad.wikimedia.org/p/fundraising_shrimp [23:54:57] § Fundraising Tech Backlog, Fundraising-Backlog, Fundraising Sprint Enya: [2 hours] BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1048555 (atgo)