[00:00:36] awight: thanks much in advance 4 the deploy help, apologies for my uselessness at getting it done myself... Here's the patch... https://gerrit.wikimedia.org/r/#/c/182078/ I guess one takes out a deploy slot for such stuff just like anything else? [00:02:50] AndyRussG: yeah, reserving a window is good [00:03:47] AndyRussG, awight: I'll snag this one just to keep the right process fresh in my mind [00:04:09] AndyRussG: I need to move butt again, 1700 PST is good for me, if not too late for you? [00:04:20] ejegg: oh--you want to do the deploy as well? [00:04:47] I'm more than happy to forget the correct process a little bit :) [00:04:49] yeah, I'll do the deploy [00:05:05] k, thanks! [00:05:10] ejegg: awight: thanks a ton! [00:05:15] ahem [00:06:10] AndyRussG: looks like the next slot is still 1700 PST. Works for me. You? [00:06:29] ejegg: sounds excellenty! [00:11:22] ejegg: I'm taking out the slot... 1 hr for the off chance something goes funny? [00:11:38] cool, don't think anyone will fight us for it [00:17:46] ejegg: done! [00:34:33] hey AndyRussG! do you want to talk about CN stuff? [00:36:37] atgo: mm how is in about 1 hr? Is that too late? I'm just a homework-helpong Dad for about 20 more minutes then ejegg is helping me with the deploy... [00:36:46] helping [00:36:58] i could do in 1 hour or tomorrow might be better? [00:37:21] atgo: sorry about! Yeah 1 hour or tomorrow are both fine for me :) thanks 4 understanding! [00:37:31] no worries :) [00:37:34] :) [00:37:50] i'll make a meeting for tomorrow - if i wait until after we talk in an hour i'll be in terrible rush hour :P [01:03:22] atgo: sounds good, thanks! [01:03:28] ejegg: all set anytime :) [01:03:42] I think in fact the only power I lack is the +2'ing of the actual patch [01:03:43] cool, me too! [01:04:17] going to rebase it first as per https://wikitech.wikimedia.org/wiki/Heterogeneous_deployment#In_your_own_repo_via_gerrit [01:05:01] OK, merged [01:05:13] Did you want to do the pull on tin and sync-file? [01:06:42] AndyRussG: ^^ or should I [01:06:44] ejegg: hmmm I've never done it... it's up to you :) I'm sure it'll take you longer to babysit me doing it than doing it yourself [01:06:50] So whatever you're up to [01:06:54] up for [01:07:18] I'm just following the instructions on that page [01:07:26] but I'll do it [01:07:35] ejegg: ok thanks much! :) [01:08:11] I don't get why it's so different if you're doing it yourself or if you're helping someone else do it [01:08:35] I think that's misleading [01:08:52] ah hmm [01:09:42] one sec... [01:09:59] as in I should stop? [01:10:16] ah no [01:10:29] no all good [01:11:06] good luck! i'm going to go beat rush hour [01:11:11] eep [01:11:17] into submission [01:11:25] ...you first. :) [01:11:32] I'll stay here and, ah... [01:11:38] ...make sure it's safe. Here. [01:14:09] :D [01:17:58] ejegg: https://en.m.wikipedia.org/wiki/Main_Page?country=IL [01:21:53] K4-713: extra round trips on mobile now officially done away with! :) [01:22:00] Woooooo! [01:22:08] Great news. [01:25:06] K4-713: Yea! finally :) [01:25:23] Everything seems to be in order... [01:26:32] Great! [01:26:49] I feel like this is getting easier. [01:27:23] I may be delirious for largely unrelated reasons. [01:28:27] Maybe the "just because you're paranoid it doesn't mean they're not after you" principle applies here ("just because you're delirious it doesn't mean it isn't getting easier..."?) [01:28:35] Ooo. [01:28:37] I like that. [01:38:29] awight: Oh yeah, you're totally right about the JD being in slightly the wrong place. [01:38:33] They're going to fix it. [01:40:21] K4-713: awesome. [01:41:48] When I was a young lad gazing up longingly at the WMF job postings, I don't think I looked for dev work under that department :p [01:43:04] § Fundraising Tech Backlog: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1048795 (awight) Awesome!! [01:44:49] Yeah, it shouldn't be there anyway. [01:44:55] But mostly that. [01:44:59] K4-713: hey, what is the precise window next Wed in which I should help with consultant-sitting? [01:45:12] I'll send you an invite. :p [01:45:49] K4-713: looks like they have you locked away 9-12 AM [01:45:57] That's the one. [01:46:59] awight: invite sent. [01:47:24] very nice [01:55:18] MediaWiki-extensions-CentralNotice, § Fundraising Sprint Devo, § Fundraising Tech Backlog: CentralNotice: Prevent extra round trips due to mobile redirect - https://phabricator.wikimedia.org/T86101#1048826 (AndyRussG) Open>Resolved [01:59:20] MediaWiki-extensions-CentralNotice, § Fundraising Sprint Devo, Wikimedia-Fundraising, Fundraising Sprint Enya: Spike: what to do about Special:RecordImpression and Banner History - https://phabricator.wikimedia.org/T88614#1048831 (AndyRussG) [02:00:46] MediaWiki-extensions-CentralNotice, § Fundraising Sprint Devo, Fundraising Sprint Enya: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1048833 (AndyRussG) [02:27:28] MediaWiki-extensions-CentralNotice, § Fundraising Sprint Devo, § Fundraising Tech Backlog: CentralNotice: Prevent extra round trips due to mobile redirect - https://phabricator.wikimedia.org/T86101#1048902 (atgo) Woot! [02:47:16] (PS5) Awight: Don't reject mismatching refund amounts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) [04:56:40] (PS15) AndyRussG: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [04:57:16] (CR) jenkins-bot: [V: -1] Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [05:05:05] § Fundraising Sprint Devo, MediaWiki-extensions-CentralNotice: CentralNotice bucket improvements, step 3 bis part 1: remaining test details - https://phabricator.wikimedia.org/T86091#1049000 (AndyRussG) Done--except for one silly bug! Grrrrr. Here's the head of the chain of patches: https://gerrit.wikimedia.... [16:57:56] (CR) Ejegg: [C: 2] "eh, no need to reshuffle patches, this is a great start" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 (owner: Awight) [16:59:42] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [17:10:54] (PS6) Awight: Don't reject mismatching refund amounts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) [17:26:09] (CR) Awight: [C: 2] "Makes sense!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/191382 (https://phabricator.wikimedia.org/T87810) (owner: Ejegg) [17:28:10] (PS5) Awight: New PaymentResult class for passing user interaction hints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 [17:36:28] Jenkins is dead. Long live Jenkins! [17:37:51] * ejegg sheds a single tear [17:38:02] ejegg: I'm ready to merge https://gerrit.wikimedia.org/r/#/c/190134/3, just remind me whether you wanted to rewrite or if we're going with the current iteration? [17:38:14] ejegg: hehehe. don't hold back [17:39:14] think I'm sticking with this approach for now [17:39:55] just to get away from everything passing through the adapter [17:46:55] I was hoping u would say that :) [17:47:39] (PS4) Awight: Add push and pop fns to DonationLoggerContext [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190134 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [17:47:46] (CR) Awight: [C: 2] Add push and pop fns to DonationLoggerContext [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190134 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [17:48:07] (PS2) Awight: WIP: get rid of shortcut log calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191392 (owner: Ejegg) [17:49:13] thanks! [17:53:34] Fundraising-Backlog, § Fundraising Tech Backlog, Fundraising Sprint Enya: [2 hours] BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1050227 (awight) The uselang= thing is almost certainly a separate bug. FWIW, we were also seeing the geolocation problems fro... [17:55:13] hey AndyRussG in the collab page, is the first section ellery's writing or yours? [17:55:19] https://collab.wikimedia.org/wiki/Fundraising/banner_history_cookie [17:55:56] Wikimedia-Fundraising-CiviCRM, Wikimedia-Fundraising, Fundraising Sprint Enya: Ressurect phpunit tests for the CRM modules - https://phabricator.wikimedia.org/T86686#1050235 (awight) Open>Resolved [17:56:34] Hi atgo... The first section I think was Ellery, or at least mainly [17:56:41] ok [17:56:54] it would be great to simplify this down a bit if we could.. not sure what's relevant at this point :) [17:57:01] yeah agreed [17:57:29] I have been thinking about Ellery's e-mail, have some possible solutions in mind [17:58:50] atgo: also, just out of burndown-fetish-ish curiosity, do you know why last sprint's burndown doesn't show that I closed the mobile round-trip card? [17:59:01] (btw, successful deploy last night w/ that) [17:59:05] i saw! thanks :D [17:59:31] because it was past the end of t [17:59:35] he sprint.. let me fix [18:00:18] https://phabricator.wikimedia.org/project/sprint/burn/1036/ [18:00:19] :D [18:00:56] ah OK mmm thanks [18:04:01] Man that test one was sooooooooo close... It just died 'cause of a silly difference between how we run tests locally vs how they're run on Jenkins [18:04:20] (which shows up a real issue that should be fixed, but that I was putting off, but that I'll now fix 8p) [18:40:36] (Merged) jenkins-bot: Fix joins between payments_fraud and _initial [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/191382 (https://phabricator.wikimedia.org/T87810) (owner: Ejegg) [18:41:26] (CR) jenkins-bot: [V: -1] WIP: get rid of shortcut log calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191392 (owner: Ejegg) [18:50:11] PPena: quick question about the LATAM integration: Are we only shooting for credit card processing, or should we also tackle bank transfer, which uses the same API? [18:51:01] awight we are shooting for all the methods I've specified in the mock up. For Brazil, they are credit card, bank transfer and boletos. [18:51:17] awight for the otehr regions, mostly the same, but may add *cash* [18:52:18] PPena: awesome, thanks for the confirmation! [18:52:38] PPena: & you want to target all the regions they support with the API, right? [18:53:00] awight correct. For now they are 7 different countries in LATAM [18:53:07] great. [18:53:13] awight i still need to mock up the remainign of them, though [19:08:03] PPena: no worries, I think you can skip that step unless you think there are more details you want to clarify. [19:08:57] awight oh cool. OK, we will see, probably the position of the banks, etc... [19:11:28] (CR) Awight: "kicking" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190134 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [19:11:33] (CR) Awight: [C: 2] Add push and pop fns to DonationLoggerContext [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190134 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [19:13:43] (Merged) jenkins-bot: Add push and pop fns to DonationLoggerContext [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190134 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [19:25:39] ejegg: Eep. Time kept moving and I forgot to notice. I'm going to be, like... two minutes late. [19:34:01] § Fundraising Dash, Fundraising-Backlog: Search and return results for Campaign name - https://phabricator.wikimedia.org/T89980#1050780 (atgo) NEW [19:34:19] K4-713: Here's some fun CR, https://gerrit.wikimedia.org/r/191396 [19:34:30] That will let us kick those chargebacks through the gate... [19:34:53] heh, neat. [19:36:07] Tests! [19:39:23] § Fundraising Dash, Fundraising-Backlog: Search by Banner Name - https://phabricator.wikimedia.org/T89982#1050821 (atgo) NEW [19:39:44] § Fundraising Dash, Fundraising-Backlog: Search and return results by Banner Name - https://phabricator.wikimedia.org/T89982#1050821 (atgo) [19:43:40] § Fundraising Dash, Fundraising-Backlog: Define start and end time for an A/B test - https://phabricator.wikimedia.org/T89984#1050846 (atgo) NEW [19:47:56] § Fundraising Dash, Fundraising-Backlog: Define start and end time for an A/B test - https://phabricator.wikimedia.org/T89984#1050885 (atgo) [19:50:22] § Fundraising Dash, Fundraising-Backlog: "Get Test" in A/B testing header - https://phabricator.wikimedia.org/T89990#1050914 (atgo) NEW [19:50:46] § Fundraising Dash, Fundraising-Backlog: Search and return results for Campaign name - https://phabricator.wikimedia.org/T89980#1050920 (atgo) [19:50:58] § Fundraising Dash, Fundraising-Backlog: Search and return results by Banner Name - https://phabricator.wikimedia.org/T89982#1050922 (atgo) [19:51:57] Wikimedia-Fundraising: Need access to PHP error logs on lutetium - https://phabricator.wikimedia.org/T89992#1050935 (awight) NEW [19:52:36] Wikimedia-Fundraising: Need access to PHP error logs on lutetium - https://phabricator.wikimedia.org/T89992#1050950 (awight) [19:56:57] mmm wikibugsfest [20:13:28] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1050994 (awight) [20:15:54] Wikimedia-Fundraising: Need access to PHP error logs on lutetium - https://phabricator.wikimedia.org/T89992#1051012 (Jgreen) a:Jgreen [20:16:06] Wikimedia-Fundraising, operations: Need access to PHP error logs on lutetium - https://phabricator.wikimedia.org/T89992#1050935 (Jgreen) [20:25:57] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051038 (Ejegg) Yeah, choosing a group as a recipient is totally fubared (in 4.2, at least). For activity-based r... [20:38:20] (PS16) AndyRussG: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 [20:45:30] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051128 (RLewis) @ejegg, @awight and @caitvirtue we want reminders to be used under Activities. For example, we'd... [20:52:38] MediaWiki-extensions-CentralNotice: CentralNotice bucket improvements, step 3 bis part 1: remaining test details - https://phabricator.wikimedia.org/T86091#1051147 (AndyRussG) Here is what's coded (and for many points, also reviewed and merged) of the initial proposal in the task: - Shared test fixtures:... [20:53:31] MediaWiki-extensions-CentralNotice, Fundraising Sprint Enya: CentralNotice bucket improvements, step 3 bis part 1: remaining test details - https://phabricator.wikimedia.org/T86091#1051151 (AndyRussG) [20:55:09] hey pizzzacat AndyRussG awight|dogfud ejegg k4-713 please bring over your tasks into the new sprint: https://phabricator.wikimedia.org/tag/%C2%A7_fundraising_sprint_devo/ [20:56:29] atgo what does that mean? [20:56:38] from the last sprint [20:56:52] atgo: I think I have :) [20:56:55] just change the card to say Enya? [20:57:00] or is there some way? [20:57:07] Way [20:57:20] (usually it's automatic right?) [20:57:33] just add the project [20:57:41] and then move it into the appropriate column [20:57:47] it's a bit tedious [20:57:53] the project being the sprint? [20:59:09] ah yes it is [20:59:16] § Fundraising Dash, Fundraising Sprint Enya: Library link leads to Library page - https://phabricator.wikimedia.org/T86838#1051165 (pizzzacat) [20:59:40] § Fundraising Dash, Fundraising Sprint Enya: Finish refactoring of each already existing widget - https://phabricator.wikimedia.org/T89298#1051168 (pizzzacat) [21:00:02] § Fundraising Dash, Fundraising Sprint Enya: Parse filter data when response is returned - https://phabricator.wikimedia.org/T86842#1051180 (pizzzacat) [21:00:24] § Fundraising Dash, Fundraising Sprint Enya: Save/Store X-by-Y widget (Persistence) - https://phabricator.wikimedia.org/T86836#1051181 (pizzzacat) [21:00:39] § Fundraising Dash, Fundraising Sprint Enya: Show default board when user logs in (Persistence) - https://phabricator.wikimedia.org/T86837#1051183 (pizzzacat) [21:11:28] Fundraising-Backlog: BUG: Internal fraud "reject" data does not match GC's numbers; seems too high - https://phabricator.wikimedia.org/T89190#1051216 (Ejegg) Open>Resolved [21:20:20] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051252 (Ejegg) Thanks for the info! That might work, possibly with a new custom activity type like 'should email... [22:31:39] atgo: one sec... [22:44:46] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051611 (awight) a:awight>None @ejegg, thanks for the valuable though sad details! I'm playing with the "Re... [22:51:03] Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Fundraising Sprint Enya, Wikimedia-Fundraising, Fundraising-Backlog: New Activity contact autocomplete fields don't work - https://phabricator.wikimedia.org/T90020#1051633 (awight) NEW [23:10:17] (PS1) Ejegg: Fix some contact autocomplete boxes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/191807 (https://phabricator.wikimedia.org/T90020) [23:10:38] awight: sorry if I'm duplicating your work ^^^ [23:18:47] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051724 (atgo) @awight you put this up for grabs.... @ejegg are you owning it? [23:29:05] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051744 (awight) @atgo: I think @ejegg pretty much nailed the coffin shut. I'm ready to set this as blocked until... [23:47:32] (CR) Awight: [C: 2] Fix some contact autocomplete boxes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/191807 (https://phabricator.wikimedia.org/T90020) (owner: Ejegg) [23:47:34] (Merged) jenkins-bot: Fix some contact autocomplete boxes [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/191807 (https://phabricator.wikimedia.org/T90020) (owner: Ejegg)