[00:00:29] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051857 (awight) Brilliant work! I just received a reminder. There's more followup to do, tech and admins need t... [00:03:08] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051861 (RLewis) @awight wow, great stuff. Can we discuss this in our MGF meeting tomorrow? [00:09:21] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051863 (Ejegg) Maybe even re-use the 'Emailed' activity type - reminders get sent a day before for those in 'sche... [00:09:53] * awight sighs contently at reading the following in the civicrm-lts mailing list: "I can — will there be a pull-request? It’ll help to know if it passes the test suite." [00:10:41] manually-run automated testing? [00:19:27] AIUI, it's just a continuous integration job that triggers on each pull request, see https://github.com/civicrm/civicrm-core/pull/5199 -- it's the colored dot next to each commit [00:22:18] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051887 (awight) @RLewis, good idea! If KBrownell is still available, we should ask her to explain best practices... [00:42:31] @awight is civigrant gone off the staging server? [00:42:50] (CR) Awight: [C: 2] "Fantastic! My only small gripe is the intrusion of testing code into the BannerAllocationCalculator, but that can be cleaned up later." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [00:43:25] (Merged) jenkins-bot: Test fixtures: expand to cover more scenarios [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [00:44:50] CaitVirtue: argh, I think the database got overwritten in an emergency data-recovery thing last week. [00:45:16] CaitVirtue: you had started testing it, then? [00:45:21] oh dear. ok. there were literally only 4 things in there, i think, so it's not a huge loss [00:45:54] That's a pain, still. I'll think about how to coordinate better in the future... [00:46:00] lemme turn it back on. [00:46:01] @awight can you re-add it? [00:46:08] @awight haha, ok, thanks. [00:46:49] CaitVirtue: ok it's on again [00:47:01] @awight thanks! [00:47:05] * awight makes a lot of groaning sounds to make this look like difficult work :p [00:47:30] awight: thanks! [00:47:32] CaitVirtue: also: reminders are ready to play with on the staging site. [00:48:00] Fundraising Sprint Enya, Wikimedia-Fundraising-CiviCRM, § Fundraising Tech Backlog, Wikimedia-Fundraising, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1051920 (CaitVirtue) Sorry to be late to the party here... @ejegg @awight We also have wild hopes and dreams of h... [00:48:02] I'd recommend having KBrownell help us with best practices and stuff... [00:48:14] totally agree [00:49:19] Seems like it's going to be easy to enable on the production server, but the work is all in figuring out which activities should cause reminders, etc. [00:49:41] K4-713: You're right, I should have finished my afterthought-patchsets before CR... :) Actually it was taking more than 5 minutes because I ran into an issoo, so it's fine to make it a different change... [00:51:20] @awight yes, that makes sense. Once you all get it working, will Rosie and I be able to add reminder fields to civigrant without your intervention? [01:17:55] so.... the guitarist from Devo died the day before our sprint ended :o [01:17:55] http://www.rollingstone.com/music/news/devo-guitarist-bob-casale-dead-at-61-20140218 [01:18:26] oh noes!!! we should keep tabs on Enya.. [01:24:02] Maybe it suddenly became difficult to Google for himself [01:36:52] (PS1) Awight: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191826 [01:37:01] (CR) Awight: [C: 2] update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191826 (owner: Awight) [01:37:02] (Merged) jenkins-bot: update civicrm submodule [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191826 (owner: Awight) [01:40:19] (PS1) Awight: New thank you translation: sv [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191827 (https://phabricator.wikimedia.org/T89611) [01:40:21] (PS1) Awight: other new thank you translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191828 (https://phabricator.wikimedia.org/T89611) [04:51:58] (CR) AndyRussG: "Thanks!!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/188687 (owner: AndyRussG) [11:34:39] (CR) Pcoombe: [C: 2] New thank you translation: sv [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191827 (https://phabricator.wikimedia.org/T89611) (owner: Awight) [11:37:16] (CR) Pcoombe: [C: 2] "Looks good, thanks Adam!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191828 (https://phabricator.wikimedia.org/T89611) (owner: Awight) [11:37:18] (Merged) jenkins-bot: other new thank you translations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191828 (https://phabricator.wikimedia.org/T89611) (owner: Awight) [15:14:08] (CR) JanZerebecki: [C: -1] "Please never throw plain Exception. See my comment on https://gerrit.wikimedia.org/r/#/c/184062/ ." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (owner: Ori.livneh) [15:15:02] (CR) JanZerebecki: [C: -1] "Please never throw plain Exception. See my comment on https://gerrit.wikimedia.org/r/#/c/184062/ ." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/184047 (owner: Ori.livneh) [15:15:16] (CR) JanZerebecki: [C: -1] "Please never throw plain Exception. See my comment on https://gerrit.wikimedia.org/r/#/c/184062/ ." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/184021 (owner: Ori.livneh) [16:24:32] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/191896 [16:24:51] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/191896 (owner: Awight) [16:24:53] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/191896 (owner: Awight) [16:25:49] !log updated crm from a1e604b93342f5555427eaeb81092bfa431ff093 to f594a66694d52af1c604b1813ac94e9592b6c81e [16:25:54] Logged the message, Master [16:26:31] Fundraising Sprint Enya, Wikimedia-Fundraising, Fundraising-Backlog: Deploy Swedish thank you letter - https://phabricator.wikimedia.org/T89611#1053868 (awight) Open>Resolved a:awight Deployed! [16:30:20] Fundraising Sprint Enya, Wikimedia-Fundraising, Fundraising-Backlog: Deploy Swedish thank you letter - https://phabricator.wikimedia.org/T89611#1053915 (jrobell) @awight @aklapper. Thank you!! [17:19:13] Wikimedia-Fundraising: Verisign logo not loading on payments - https://phabricator.wikimedia.org/T90231#1054155 (Pcoombe) NEW [17:22:55] Ooo, what was that... [17:24:45] disabled. [17:27:05] Wikimedia-Fundraising: Fatal error while editing a contribution - https://phabricator.wikimedia.org/T90232#1054175 (awight) NEW [17:32:13] Wikimedia-Fundraising: Fatal error while editing a contribution - https://phabricator.wikimedia.org/T90232#1054216 (awight) So far, I think this might have been something related to a comma in the contribution_source field, which might be breaking hooks? [17:37:05] Wikimedia-Fundraising: Stray comma causes all kinds of failures - https://phabricator.wikimedia.org/T90232#1054232 (awight) [17:49:19] In case anyone was wondering, the comma bug above really was the cause of the failmails! [18:05:50] Wikimedia-Fundraising: Verisign logo not loading on payments - https://phabricator.wikimedia.org/T90231#1054307 (Ejegg) Maybe a transient error on the verisign side? I can currently load the logo (which now says Norton secured... powered by Symantec) in FF and Chrome, and the verification popup window works... [18:15:28] § Fundraising Dash, Fundraising-Backlog: Define start and end time for an A/B test - https://phabricator.wikimedia.org/T89984#1054360 (atgo) [18:15:34] § Fundraising Dash, Fundraising-Backlog: Search and return results by Banner Name - https://phabricator.wikimedia.org/T89982#1054361 (atgo) [18:15:37] § Fundraising Dash, Fundraising-Backlog: Search and return results for Campaign name - https://phabricator.wikimedia.org/T89980#1054362 (atgo) [18:35:14] oh yay awight|specter [18:55:50] pizzzacat1: we should make red shoes club a recurring thing [19:00:18] every Friday atgo ! [19:19:58] !log enabled scheduled reminders in production CiviCRM [19:20:05] Logged the message, Master [19:28:54] * AndyRussG has no red shoes [20:14:01] Wikimedia-Fundraising-CiviCRM: Currency conversion rate off for JP Morgan Bank Transfer - https://phabricator.wikimedia.org/T90266#1055133 (RLewis) [20:16:28] pizzzacat1: Are you here somewhere? [20:16:52] nvm [20:18:30] Wikimedia-Fundraising-CiviCRM: Currency conversion rate off for JP Morgan Bank Transfer - https://phabricator.wikimedia.org/T90266#1055160 (RLewis) Added @ejegg to this task. Attached is the screenshot of the error message I receive. The import works but every time I import I receive this message. {F44437}... [20:22:43] (PS1) Ejegg: Change name of composer package [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191942 [20:29:22] bread, hummus, pesto, beans, cream cheese, ham, cheese, lettuce, tomato [20:29:26] toaster oven [20:29:47] shopping list? [20:29:55] hehe no, what I just ate :) [20:30:06] how was the toaster oven? [20:30:57] welllll if you're gonna be all exact and precise about it... [20:31:12] Note however that toaster oven was on a separate line [20:31:27] That makes it a different course [20:31:32] hehe [20:32:02] the kitchen is just sooo close! [20:33:46] What does "XXX" mean as a comment in code? [20:33:58] Or I guess what is it supposed to mean? [20:34:32] huh, I'd have to see the context [20:34:47] NSFW code below? [20:35:03] Maybe even! [20:35:35] I mean, where I came across it I think it means "code smell, pls remove one day" [20:36:06] CN/includes/Banner.php line 377 [20:36:11] ah no [20:36:13] 1377 [21:16:34] (CR) Legoktm: [C: 1] "+1. If you're already changing the name, most extensions typically use "mediawiki/" as the vendor rather than "wikimedia", but I'm guessin" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191942 (owner: Ejegg) [21:19:58] hey ejegg - i was thinking it might be helpful to write up the process for reminders (as well as suggested dos/donts) somewhere for the MG team to use [21:27:15] sure! [21:28:32] Did we want to get some input from kbrownell first? [21:30:15] hmm... definitely around civigrants, but it sounds like MG is good to go with the regular reminders, right? [21:30:24] ok, cool [21:31:35] Wikimedia-Fundraising-CiviCRM: Currency conversion rate off for JP Morgan Bank Transfer - https://phabricator.wikimedia.org/T90266#1055356 (atgo) p:Triage>Low [21:32:36] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Thank you letters for our donors who donate via UKFC - https://phabricator.wikimedia.org/T89512#1055360 (atgo) p:Triage>Normal a:atgo>None [21:40:56] (PS1) AndyRussG: PHPUnit test fixtures: clean up device handling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/191999 [21:41:42] g'bye o gerbil hole [21:41:47] Also: cool change number! [21:41:57] Lemme dance [21:42:30] Like Ceci, my youngest daughter, who likes to dance when it's 11:11 or 12:21 or 4:04 and stuff [21:48:23] heee [21:48:40] I have to dance when I notice it's 11:38. Usually. [21:49:17] atgo: Why are we shrimp chicken now? [21:49:19] * ejegg smiles knowingly at THX reference [21:49:35] * K4-713 high-fives ejegg [21:49:46] shrimp chicken? sprint checking :) [21:50:04] Oooooh. [21:50:13] *Now* I get it. [21:50:52] duuuh * [21:59:53] Why 11:38? [22:24:14] AndyRussG: https://en.wikipedia.org/wiki/THX_1138 [22:24:16] TIL. [22:25:34] marktraceur: ah cool! thanks :) [22:26:12] * AndyRussG chalks up one more entry on the list of cool things he's totally ignorant of [23:05:20] (PS1) Chad: Use EDIT_TOKEN_SUFFIX constant instead of global define [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192015 [23:29:06] Urf. Okay guys. I'm abandoning ship. [23:29:36] I may re-occupy ship after an unscheduled nap, but I'm not doing anybody any good right now. [23:29:42] may you drift to a pleasant island [23:30:06] haha, thanks [23:30:20] * K4-713 floats out with the tide [23:30:34] * K4-713 suspiciously watches sky for flaming arrows