[00:02:16] <atgo>	 AndyRussG: i think i thought i had a better handle on the way banners are loaded than i actually do
[00:03:14] <atgo>	 also my diagram sucks
[00:03:33] <AndyRussG>	 atgo: I'm sure it's fine! One sec, taking a look
[00:03:47] <atgo>	 haha no way
[00:03:48] <atgo>	 i'm lost
[00:04:00] <AndyRussG>	 it's hard to think about this stuff abstractly without working with the details..
[00:04:12] <atgo>	 my chicken scratch from yesterday was insufficient :P
[00:05:35] <AndyRussG>	 I think it's great that you're looking at the details of this! It's fun and totally useful for understanding how the tech can fit in with what people actually do with it
[00:06:19] <AndyRussG>	 So the main issue in the top diagram is that S:RI comes after S:BL in the current state
[00:06:40] <atgo>	 ooooh really?
[00:06:46] <AndyRussG>	 yeah!
[00:06:47] <atgo>	 that makes more sense actually
[00:06:58] <AndyRussG>	 S:BL is what brings in javascript that makes the final descision about whether to really show or hide the banner
[00:07:21] <atgo>	 man S:RI does seem to be inefficient then
[00:07:24] <atgo>	 want to update the thing?
[00:07:32] <AndyRussG>	 Sure!
[04:26:07] <grrrit-wm>	 (PS1) AndyRussG: Tests: one bugfix and minor improvements 'n' cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/192057
[04:28:57] <grrrit-wm>	 (PS1) AndyRussG: Test fixtures data: add partially overlapping heterogeneous case [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/192058
[04:32:50] <wikibugs>	 § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure: CentralNotice bucket improvements, step 3 bis part 1: remaining test details - https://phabricator.wikimedia.org/T86091#1056180 (AndyRussG) Here are the "afterthought" patch...
[16:42:03] <grrrit-wm>	 (CR) Awight: "Cool! I've confirmed that this constant exists on the fundraising/REL1_23 branch." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192015 (owner: Chad)
[16:42:08] <grrrit-wm>	 (CR) Awight: [C: 2] Use EDIT_TOKEN_SUFFIX constant instead of global define [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192015 (owner: Chad)
[16:42:31] <grrrit-wm>	 (Merged) jenkins-bot: Use EDIT_TOKEN_SUFFIX constant instead of global define [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192015 (owner: Chad)
[16:43:02] <grrrit-wm>	 (PS2) Awight: Change name of composer package [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191942 (owner: Ejegg)
[16:43:20] <grrrit-wm>	 (CR) Awight: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191942 (owner: Ejegg)
[16:43:39] <grrrit-wm>	 (Merged) jenkins-bot: Change name of composer package [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191942 (owner: Ejegg)
[16:44:10] <grrrit-wm>	 (PS4) Awight: Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg)
[16:44:40] <grrrit-wm>	 (CR) Awight: Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg)
[16:44:46] <grrrit-wm>	 (CR) Awight: [C: 2] Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg)
[16:46:33] <grrrit-wm>	 (Merged) jenkins-bot: Kill a couple obsolete @param tags [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/187644 (owner: Ejegg)
[16:51:41] <grrrit-wm>	 (CR) Awight: [C: 2] PHPUnit test fixtures: clean up device handling (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/191999 (owner: AndyRussG)
[16:52:52] <grrrit-wm>	 (Merged) jenkins-bot: PHPUnit test fixtures: clean up device handling [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/191999 (owner: AndyRussG)
[16:53:57] <AndyRussG>	 awight: woohoo! thanks :)
[17:45:26] <grrrit-wm>	 (CR) Awight: [C: 2] Tests: one bugfix and minor improvements 'n' cleanup (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/192057 (owner: AndyRussG)
[17:45:59] <grrrit-wm>	 (Merged) jenkins-bot: Tests: one bugfix and minor improvements 'n' cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/192057 (owner: AndyRussG)
[17:46:24] <grrrit-wm>	 (CR) Awight: [C: 2] "Great!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/192058 (owner: AndyRussG)
[17:47:34] <grrrit-wm>	 (Merged) jenkins-bot: Test fixtures data: add partially overlapping heterogeneous case [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/192058 (owner: AndyRussG)