[18:10:09] (PS11) Awight: Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 [18:10:47] (CR) jenkins-bot: [V: -1] Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (owner: Awight) [18:12:07] (CR) Awight: "We could use fixture data here, and I think @AndyRussG had a better and more unity plan to test the override param, rather than rely on a " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (owner: Awight) [18:12:39] (PS12) Awight: Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) [18:12:56] Good morning, friends, here is your cat of the day! https://41.media.tumblr.com/04b1abc6bba584f51fef8b44e1c3bafe/tumblr_nk26fp64s21tjdvfuo1_1280.jpg [18:13:11] (CR) jenkins-bot: [V: -1] Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) (owner: Awight) [18:13:21] pizzzacat: thanks! I've loved Russian blues ever since Master and Margarita [18:14:03] pizzzacat: wut? I didn't order a such a toothy cat... Thanks anyway, though, I could use him to defend my home [18:14:15] he's smiling you guys. [18:14:29] going against his nature [18:14:55] I'm proud of him. [18:15:23] pizzzacat: Aaaaah OK gotcha [18:15:36] http://the-affair.com/wp-content/uploads/2012/08/behemoth.zoom_.detail.g.1.jpg [18:16:04] http://www.readliterature.com/masterandmargarita4.jpg [18:16:40] https://s-media-cache-ak0.pinimg.com/236x/02/5a/82/025a82380656a80f548fcea60bafd023.jpg [18:17:31] ooh I love that second one awight [18:17:48] AndyRussG: just a heads-up, there's some interesting talk on the Analytics list, such as recommending that we tag any tasks with A--- when it might affect pageviews [18:17:58] pizzzacat: yah there's a color image, too--apparently it's a T-shirt!! [18:18:45] now I really need to read that book. [18:19:15] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog: New Activity contact autocomplete fields don't work - https://phabricator.wikimedia.org/T90020#1059638 (awight) Open>Resolved a:awight [18:19:16] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Enya, Fundraising Tech Backlog, Fundraising-Backlog: Make Civi Reminders work - https://phabricator.wikimedia.org/T86345#1059640 (awight) [18:22:04] awight: hmmm! [18:22:41] pizzzacat: imagine, Dickens meets magical realism [18:23:44] that sounds really cool. and a cat with a revolver. what more could I want? [18:24:01] I don't think he *needs* the revolver, most of the time [18:26:16] I think we should start a cat-related book club [18:27:03] too cool for school! [18:27:49] I guess I'm really into starting clubs lately [18:27:58] stupid ones though [18:28:06] did you hear about the Red Shoe Club? [18:28:15] I think so! You're on a roll... [18:28:28] if you would like do join (or anyone reading this), just wear red shoes on Fridays [18:28:37] But now you need to step it up and organize intermural get-togethers of clubs [18:28:47] ooh very good idea. [18:29:06] how are you feeling awight? has the flu flew? [18:29:06] wow... your last sentence sort of reads like a broadcast to extraterrestrials [18:29:16] ha yes. [18:29:17] I'm fine, kid is better, wife down. [18:29:18] it was. [18:29:23] damn [18:29:27] it's hard, man. [18:29:32] sorry to hear :( [18:29:50] I feel differently about eating skittles off of the Bart floor, now that I get three people sick, for weeks. [18:30:15] ... now I dip them in my pocket whiskey before eating. [18:31:01] awight: re: skittles, lol [18:31:18] awight: sorry to hear about the ongoing illnesses, glad Mari's better [18:31:50] thx! it was actually scary. [18:32:03] I imagine! :( [18:32:24] were the skittles even good? [18:32:25] she stopped eating for a week, and towards the end just sort of whithered into a ball like a spider. [18:32:35] oh my :( [18:32:38] Oh noes! [18:32:56] friends, I'm now off to combat some apparent bacteria that have taken to my daughter's ear. Fear not, the bacteria are weak and the doctor's medicine will be strong! [18:33:08] AndyRussG: argh! [18:33:17] I tell ya ... 8p [18:33:19] back later :) [18:34:13] awww man, best wishes [18:39:48] take care! [18:46:32] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Labs, Tracking: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1059761 (awight) @Andrew, I think that sounds right, but the Fundraising tech team should have permissions to administer this instance.... [18:57:47] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Labs, Tracking: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1059818 (Andrew) Antoine, can you add Adam as a project admin, or otherwise follow up on this? [19:04:14] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Blocked-on-Continuous-Integration: Add Fundraising Tech team to the labs Integration project - https://phabricator.wikimedia.org/T90472#1059835 (awight) NEW [19:04:21] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Labs, Tracking: Create new labs project: fundraising-integration - https://phabricator.wikimedia.org/T88599#1059842 (awight) Open>declined a:awight Okay, we're trying the approach @hashar suggests, see T90472 [19:04:23] Wikimedia-Fundraising-CiviCRM, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, and 5 others: Deploy CiviCRM integration job to WMF integration server - https://phabricator.wikimedia.org/T86374#1059847 (awight) [19:04:43] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Sprint Enya, Fundraising Tech Backlog, and 2 others: Create CI slave instance for CiviCRM testing - https://phabricator.wikimedia.org/T89894#1059849 (awight) [19:04:44] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Blocked-on-Continuous-Integration: Add Fundraising Tech team to the labs Integration project - https://phabricator.wikimedia.org/T90472#1059835 (awight) [19:05:09] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Continuous-Integration: Add Fundraising Tech team to the labs Integration project - https://phabricator.wikimedia.org/T90472#1059835 (awight) [19:39:30] (PS1) Aaron Schulz: Use the modern DB construction method [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/192377 [19:39:41] (CR) Aaron Schulz: "See https://gerrit.wikimedia.org/r/#/c/192006/" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/192377 (owner: Aaron Schulz) [19:57:52] (PS1) Ejegg: Add Monolog and PSR\Logger [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) [19:59:41] (PS1) Ejegg: Revert "Add push and pop fns to DonationLoggerContext" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192382 (https://phabricator.wikimedia.org/T86266) [19:59:43] (PS1) Ejegg: Revert "Use DonationLogger in GatewayPage subclasses" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192383 (https://phabricator.wikimedia.org/T86266) [19:59:45] (PS1) Ejegg: Revert "Move some logging functions into DonationLogger" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192384 (https://phabricator.wikimedia.org/T86266) [19:59:47] (PS1) Ejegg: WIP: add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 [20:00:25] (CR) jenkins-bot: [V: -1] WIP: add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (owner: Ejegg) [20:04:32] ejegg: hmm... what's up? [20:04:39] "Static logging calls = not awesome" ? [20:05:22] I was writing stuff to make the tests work after getting rid of the shortcut logging calls, and kept getting more and more disgusted whith what I was creating [20:05:25] Is it necessary to back out yr work, or can we refactor it? [20:05:26] hehehe [20:05:29] fair enuf [20:05:48] Fortunately, my stuff is still near the top of the stack [20:06:02] easy revert for now [20:06:16] also, we /can/ use monolog + psr via composer [20:06:31] if vendor/ exists, we autoload from there [20:07:02] Isn't mw-core integrated with monolog now? [20:07:04] if not (ie gerrit checks us out non-recursively into trunk ) we still have them autoloaded from top-level vendor/ [20:07:10] yep [20:07:22] I guess it doesn't matter if we reuse their integration [20:07:23] so we can use theirs in CI, and ours in oldversion [20:07:35] what is "oldversion"? [20:07:41] i mean payments [20:07:51] ok [20:07:56] cool, I'll take a look [20:08:09] (PS2) Awight: Revert "Add push and pop fns to DonationLoggerContext" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192382 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:08:14] yeah, we can't depend on their wrappers on payments, and we don't want those particular processors anyway [20:08:14] (note rebase!) [20:08:24] ah, thanks [20:08:48] (CR) Awight: [C: 2] Revert "Add push and pop fns to DonationLoggerContext" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192382 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:08:52] (PS2) Awight: Revert "Use DonationLogger in GatewayPage subclasses" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192383 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:08:56] (CR) Awight: [C: 2] Revert "Use DonationLogger in GatewayPage subclasses" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192383 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:09:06] (PS2) Awight: Revert "Move some logging functions into DonationLogger" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192384 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:09:12] (CR) Awight: [C: 2] Revert "Move some logging functions into DonationLogger" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192384 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:09:20] (Merged) jenkins-bot: Revert "Add push and pop fns to DonationLoggerContext" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192382 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:09:35] (Merged) jenkins-bot: Revert "Use DonationLogger in GatewayPage subclasses" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192383 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:09:38] (PS7) Awight: Don't reject mismatching refund amounts [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) [20:09:52] ejegg: hey, can you knock that one through the wicket at some point? ^^ [20:10:00] sure thing [20:10:06] (Merged) jenkins-bot: Revert "Move some logging functions into DonationLogger" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192384 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:10:42] (Abandoned) Ejegg: WIP: get rid of shortcut log calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/191392 (owner: Ejegg) [20:12:52] (PS2) Ssmith: WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 [20:12:57] (CR) jenkins-bot: [V: -1] WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [20:17:00] (CR) Awight: [C: 2] "Oooh, thanks for noticing!" [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/192377 (owner: Aaron Schulz) [20:17:09] (Merged) jenkins-bot: Use the modern DB construction method [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/192377 (owner: Aaron Schulz) [20:21:54] awight: Hey... https://meta.wikimedia.org/wiki/Special:GlobalAllocation [20:22:11] I'd ping Andy, but he's dealing with things. [20:22:29] K4-713: that thing has been broken for over a year :( [20:22:37] ...orly [20:22:48] The priority of fixing keeps sliding, sadly [20:23:10] So, there's no replacement? [20:23:21] Well, there's the original allocations page [20:23:29] (url'ing...) [20:23:32] http://meta.wikimedia.org/wiki/Special:BannerAllocation [20:23:53] The quick hack to "fix" globalallocation would be to not run the query until you've entered search criteria. [20:24:29] But it would still fail for "everything", cos I based it on a... O(N!) algo [20:24:43] You're probably going to have to say all that again in a minute. [20:24:58] The junta is coming? [20:25:17] awight: jamesofur was asking. [20:25:25] :) [20:25:27] I was indeed [20:25:30] ah. jamesofur: sorry, man [20:25:33] I'd like to fix it. [20:25:38] jamesofur: what is your query? [20:25:40] we just put up a banner so was tryign to see how it was up [20:25:46] (and our banner is everywhere) [20:25:54] so right now I'm just doing individual look ups [20:26:04] jamesofur: yeah, fyi http://meta.wikimedia.org/wiki/Special:GlobalAllocation?project=wikipedia&language=en&country=US [20:26:09] you can eff with the GET params :( [20:27:25] jamesofur: it's in every language? [20:27:29] * jamesofur nods [20:27:43] jamesofur: well sheeit. This might be a tiny improvement on individual lookups, http://meta.wikimedia.org/wiki/Special:GlobalAllocation?language=en [20:28:40] jamesofur: Here's some really bad news: fundraising started running our campaigns at "emergency" priority again. [20:28:47] * jamesofur nods [20:28:54] I know, I was talking with Megan [20:29:02] I think that's just out of inertia, you might want to ask around about fixing that. [20:30:17] jamesofur: one more thing totally broken about GlobalAllocation--it doesn't know about devices yet. So it's actually giving incorrect allocations when mobile and desktop campaigns overlap in their other criteria. [20:30:41] (CR) Ejegg: "Change looks solid, plus nice tests!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) (owner: Awight) [20:30:52] (CR) Ejegg: [C: 2] "Change looks solid, plus nice tests!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/191396 (https://phabricator.wikimedia.org/T89871) (owner: Awight) [20:31:00] ejegg: thanks! [20:31:24] ejegg: tests do a lot to dress up my piglets, eh [20:31:33] thanks awight [20:31:41] jamesofur: sorry I couldn't help more. [20:32:46] that sow's ear is looking more like a silk purse every day [20:41:17] ... [20:41:26] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/192392 [20:41:39] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/192392 (owner: Awight) [20:41:42] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/192392 (owner: Awight) [20:43:26] !log update crm from f594a66694d52af1c604b1813ac94e9592b6c81e to 3c002f32e04652ae56a4fe791bc6158ab981ed8d [20:43:33] Logged the message, Master [20:46:16] Wikimedia-Fundraising, § Fundraising Sprint Devo, Fundraising Sprint Enya, Fundraising Tech Backlog: Do not reject chargebacks because of mismatched amount - https://phabricator.wikimedia.org/T89871#1060275 (awight) Open>Resolved [20:48:46] (PS2) Ejegg: WIP: add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 [20:48:48] (PS1) Ejegg: Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) [20:49:08] (CR) jenkins-bot: [V: -1] Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:49:32] (CR) jenkins-bot: [V: -1] WIP: add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (owner: Ejegg) [21:26:11] Wikimedia-Fundraising: Verisign logo not loading on payments - https://phabricator.wikimedia.org/T90231#1060436 (atgo) Is this the same as the "Norton Secured" image? If it's not, then it's missing for me, too. [21:29:09] K4-713: is there still a use case for setting ExtrasLog to anything but syslog? Cause it looks like we don't do that anywhere in production. [21:30:41] Well... not really. [21:30:55] At this point, I'm thinking if somebody wants it back, they can make it work all over again. [21:31:04] yay, burn the complexity! [21:31:05] ooooooooooooold code. [21:31:06] thanks! [21:31:17] Probably doesn't even. [21:38:14] Wikimedia-Fundraising: Stray comma causes all kinds of failures - https://phabricator.wikimedia.org/T90232#1060504 (atgo) p:Triage>Low @rlewis @caitvirtue have you ever run into this? Marking as low priority unless our users are running into the problem. [21:38:49] atgo: jfyi, this bug comes from something that happened to rlewis. [21:38:58] ok [21:39:13] It produced a record so broken that the queue consumer was completely jammed, and the record could not be edited from the GUI. [21:39:32] that said--it's incredibly rare, and rlewis knows how to avoid creating one again :) [21:51:43] javascript callback hell [21:55:48] that is where pizzzacat is [22:03:23] pizzzacat: That stuff is horrific. It's especially silly when all this async code is executed in a single-threaded process :) [22:03:52] :( [22:10:11] I blame the nefarious axis of Lisp in CS programs. [22:12:03] (CR) Awight: Use PSR logging in DonationData (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:17:41] (PS6) Awight: New PaymentResult class for passing user interaction hints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 [22:17:47] (PS2) Awight: Use common code for Adyen form handling [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189136 (https://phabricator.wikimedia.org/T86251) [22:18:26] (PS4) Awight: Consolidate GatewayPage logic in the base class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 (https://phabricator.wikimedia.org/T86251) [22:18:43] Hi K4-713... quick question when you have a second, maybe before you move to PCI-unreachable :) For Wikimania I have this silly idea about doing a non-tech-related submission, but rather about the Wiki movement and a social science theory that I wrote about some not toooo long ago. But.... then I was thinking, maybe that won't merit support for travel? Any thoughts? [22:19:02] I could totally do a tech-related submission, also, BTW [22:19:09] or instead [22:19:16] AndyRussG: hell yeah the soc sci talk will be more of a hit [22:19:31] I don't know who to ask to confirm that, though. [22:19:37] hmmmmmm [22:20:31] no idea either, since I've never been to one of these events... [22:20:39] And fwiw, I think the travel thing is simply, we're encouraged to go to at least one of {wikimania, hackathon}, but it's only if you try to go to both that you might have to justify the need. [22:20:44] just a budget thing. [22:20:54] hmmmm [22:21:15] I think someone (maybe K4-713?) mentioned also hackathons surronding (before or after) wikimania... [22:21:31] My suggestion would be to propose a talk (w/o writing talk!) and see if there's interest? [22:22:08] Hmmm could be a plan... I guess I could also propose both the soc sci one and the tech one... [22:22:28] (CR) Ejegg: Use PSR logging in DonationData (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:22:39] AndyRussG: Yeah, what awight said. [22:22:51] K4-713: cool! thanks much :) [22:23:12] I think that's usually what happens, actually: Propose a talk, and see if it gets in. [22:23:18] Then write the thing. [22:23:59] unless that's fun :) [22:24:02] AndyRussG: Have you ever been to a wikimania? [22:24:12] (CR) Awight: Use PSR logging in DonationData (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:24:35] No never been, just seen a few videos of talks from them though [22:24:47] K4-713: mmmm :) yeah I wasn't planning on writing until getting approved... just have a few vague ideas at this point [22:24:57] Hm. I always wondered why "-mania" seems fun, and "insanity" seems... sketchy. [22:24:58] * AndyRussG drops some axel grease on rusty non-tech brain sections [22:25:03] Wikinsanity. [22:25:25] aaaaaaaaaaaah OK that'll fit with my plans :) [22:25:34] (PS4) Awight: Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 [22:26:03] § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, Fundraising Sprint Enya, and 3 others: Move any remaining controller logic out of the form classes - https://phabricator.wikimedia.org/T86251#1060681 (awight) [22:27:04] Wikimedia-Fundraising, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 4 others: Move any remaining controller logic out of the form classes - https://phabricator.wikimedia.org/T86251#964487 (awight) [22:27:43] AndyRussG: :) I'll take a room where he's staying. [22:28:39] :) [22:29:29] K4-713: Just in case you aren't entertained enuf. https://gerrit.wikimedia.org/r/#/c/189615/ [22:30:19] not sure where we'll stay this time, but totally the more the merrier :) (that's what u meant?) [22:31:14] BTW awight ejegg K4-713 pizzzacat I was meaning to bug you for any tech feedback on the interaction diagram (see link in atgo's e-mail) ... I know there are still some unknowns on the way to a real implementation, but I think that's the route to try [22:31:36] will have a look AndyRussG :) [22:31:45] pizzzacat: fantatic! thanks! :) [22:32:06] wait, which email AndyRussG? [22:32:06] hmm, lemme have a looksee [22:32:29] AndyRussG: Mostly I meant, "wikinsanity" sounds more fun. But also, I will take any suggestions as to the craziest lecture halls to visit in D.F. :p [22:32:30] pizzzacat: to fr-tech, about banner history.. lemme get the link [22:32:57] AndyRussG: the-wub did have some good points about reporting [22:33:15] AndyRussG: but otherwise, I love the idea of generalizing mixins :) [22:33:22] the Wikimania venu is way far from my parents-in-laws' place, actually this time we're trying to find like a timeshare or someone who wants to dwelling swap a couple weeks [22:33:32] smart [22:34:14] Heh we'll see how it goes... :) [22:34:27] * AndyRussG witholds verdict until he sees the bill [22:35:13] But it might be great and there might be space to house more! [22:35:46] awight: cool! thanks, yeah I think it's the way to go for per-campaign code... The only thing that I don't feel totally confident about is the amount of code that may have to be sent in with choices. But if the per-campaign mixins can be locally cached and/or smartly handled like RL modules, I think it can work [22:35:53] Well, keep me on that list, but I'm pressed to justify going to all the stuff this year :-/ [22:36:21] AndyRussG: yeah agreed about overhead. Hopefully we can keep the campaign logic simple. [22:36:23] awight: you bet! :D yeah and I sure understand [22:37:03] AndyRussG: I'm currently trying to figure out why I am desperately needed at the hackathon, plus maybe two weeks of wandering around and smelling cheese. [22:37:47] awight: exactly. I mean, it's not a huge amount of JS when minfied, though I don't think we want to be sending it constantly on too many requests... [22:38:34] * pizzzacat needs to relocate [22:38:41] awight: yeah, if cheese were the only factor, I'd definitely be frommagieux [22:44:03] yeah if we do find a place with extra space during Wmania, others are also welcome to hang out, co-locate if feasible :) [22:45:13] our kids can sing the internacional :D [22:46:34] but not in the cantina (that's in 20 years) [22:47:12] pizzzacat: here's the link: (sorry for the delay) https://docs.google.com/a/wikimedia.org/drawings/d/1fVRy6Qu9lejEQd75ww7n6piTRDQx0d_lzg82J_v-_Jc/edit [22:47:35] no worries. thanks! [22:47:44] pizzzacat: likewise [22:47:45] mm yeah I should reply to the-wub [22:52:41] AndyRussG: let me also just explicitly rejoice that you've killed stupid banner hiding! [22:52:55] The only issue there is that you'll have to port the entire world. [22:52:59] Which we do not rule... [22:53:36] awight: ah you mean, the entire on-wiki JS snippet world? [22:54:51] yep [22:57:04] Banner hide-'n'-seek--peek-a-boo! [22:57:21] awight: is it such a big world? [22:57:37] Nah, but they are cats and goats. [22:57:54] * AndyRussG never underestimates task hairines [22:57:59] Ah hmmm [22:58:01] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Integrate processing in LATAM - https://phabricator.wikimedia.org/T77907#1060785 (awight) [22:58:03] Wikimedia-Fundraising: Stray comma causes all kinds of failures - https://phabricator.wikimedia.org/T90232#1060786 (RLewis) @atgo yes this is something I have run into when I hand enter donations in Civi, it isn't a huge issue now I know why this happens. [22:58:42] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Create new HTML forms - https://phabricator.wikimedia.org/T90502#1060787 (awight) NEW [22:58:53] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1060793 (awight) NEW [22:59:00] awight: in theory we could still allow banners to have some of their own JS cargo, and even force a S:RI-ish logging call if necessary [22:59:09] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1060799 (awight) NEW [22:59:14] at least as a transitionary measure [22:59:20] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Add forms (perhaps in disabled state) to DonationInterfaceFormSettings.php - https://phabricator.wikimedia.org/T90505#1060805 (awight) NEW [22:59:30] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Write confirmation message listener, which rescues donations from the limbo queue - https://phabricator.wikimedia.org/T90506#1060811 (awight) NEW [22:59:51] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Write audit file processor - https://phabricator.wikimedia.org/T90507#1060817 (awight) NEW [23:00:07] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1060823 (awight) NEW [23:01:29] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1060823 (awight) [23:02:53] Wikimedia-Fundraising, Fundraising-Backlog: Write LATAM audit file processor - https://phabricator.wikimedia.org/T90507#1060840 (awight) [23:04:08] Wikimedia-Fundraising, Fundraising-Backlog: Write confirmation message listener for LATAM, which rescues donations from the limbo queue - https://phabricator.wikimedia.org/T90506#1060851 (awight) [23:05:01] Wikimedia-Fundraising, Fundraising-Backlog: Add LATAM forms to DonationInterfaceFormSettings.php - https://phabricator.wikimedia.org/T90505#1060857 (awight) [23:05:49] Wikimedia-Fundraising, Fundraising-Backlog: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1060861 (awight) [23:06:01] Wikimedia-Fundraising, Fundraising-Backlog: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1060864 (awight) [23:07:14] AndyRussG: yeah, that's a good idea. I'm not sure we can enforce that people call a hideBanner function however, instead we probably have to detect that insertBanner was never called! [23:07:51] Wikimedia-Fundraising, Fundraising-Backlog: Create new HTML forms for LATAM processing - https://phabricator.wikimedia.org/T90502#1060867 (awight) [23:08:01] Wikimedia-Fundraising, Fundraising-Backlog: Create new HTML forms for LATAM processing - https://phabricator.wikimedia.org/T90502#1060787 (awight) [23:09:01] awight: hmmm interesting point! [23:09:15] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Integrate processing in LATAM - https://phabricator.wikimedia.org/T77907#1060881 (awight) [23:09:28] (bits of code are sometimes so untrusting of each other... reasonably so, tho) [23:09:43] atgo: I'm wondering about milestones... lmk when you can chat [23:09:59] ok.. just a few min [23:10:02] atgo: hehe be liberal with inputs and strict with outputs [23:11:09] AndyRussG: looks great and makes sense, though I don't really know much about the mixins! [23:13:50] pizzzacat: cool, thanks! basically they're a replacement for on-wiki JS that is included in banners, providing parametrized bits of JS that can be selected per banner instead of the currently used JS-on-wiki-pages scheme. Mixins per banner already implemented by awight, so this is basically expanding them to be per-campaign, too, and sending possibly applicable ones to the client early on [23:14:30] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Integrate processing in LATAM - https://phabricator.wikimedia.org/T77907#1060897 (awight) [23:14:55] My main worry ^ at this point is the performance hit from that--sending in bits of JS to too many places too often, especially places they don't get used in [23:15:10] atgo: see the end of the description... https://phabricator.wikimedia.org/T77907 [23:15:45] since the server is not able to really decide who a campaign can apply to, it can only just eliminate a certain number of users, normally quite a lot, but the final selection has to be on the client [23:20:40] pizzzacat: CentralNotice can get pretty crazy at times... If the above is not intellegible please feel free to poke me for more details 'n' explanations :) [23:21:14] * AndyRussG 's favorite word this week is " 'n' ". [23:22:53] ha, thank you. [23:25:22] (CR) Awight: [C: 2] Merge contrib into contrib-v4.4 [wikimedia/fundraising/crm/civicrm] (contrib-v4.4) - https://gerrit.wikimedia.org/r/184787 (owner: Awight) [23:25:31] pizzzacat: np, likewise :) [23:25:35] (Merged) jenkins-bot: Merge contrib into contrib-v4.4 [wikimedia/fundraising/crm/civicrm] (contrib-v4.4) - https://gerrit.wikimedia.org/r/184787 (owner: Awight) [23:25:39] (CR) Awight: [C: 2] Update to CiviCRM upstream 4.4.11 [wikimedia/fundraising/crm/civicrm] (contrib-v4.4) - https://gerrit.wikimedia.org/r/184789 (owner: Awight) [23:27:01] (Merged) jenkins-bot: Update to CiviCRM upstream 4.4.11 [wikimedia/fundraising/crm/civicrm] (contrib-v4.4) - https://gerrit.wikimedia.org/r/184789 (owner: Awight) [23:31:10] (PS1) Awight: check in .gitreview to make the branch sticky [wikimedia/fundraising/crm/civicrm] (giantrabbit-v4.4) - https://gerrit.wikimedia.org/r/192471 [23:31:11] ok awight [23:31:18] (CR) Awight: [C: 2] check in .gitreview to make the branch sticky [wikimedia/fundraising/crm/civicrm] (giantrabbit-v4.4) - https://gerrit.wikimedia.org/r/192471 (owner: Awight) [23:31:22] (Merged) jenkins-bot: check in .gitreview to make the branch sticky [wikimedia/fundraising/crm/civicrm] (giantrabbit-v4.4) - https://gerrit.wikimedia.org/r/192471 (owner: Awight) [23:32:13] also awight we're going to be able to say the vendor out loud any minute now :P [23:39:02] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Sprint Enya, Fundraising Tech Backlog, and 2 others: Configure Jenkins to run CiviCRM builds only on Fundraising CI slaves - https://phabricator.wikimedia.org/T89895#1060942 (awight) a:awight>None [23:55:00] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Dedupe Civi - https://phabricator.wikimedia.org/T77938#1060963 (awight)