[00:10:57] (PS2) Ejegg: Add Monolog and PSR\Logger [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) [00:11:51] (PS2) Ejegg: Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) [00:11:53] (PS3) Ejegg: Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) [00:12:26] (CR) jenkins-bot: [V: -1] Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [00:12:42] (CR) jenkins-bot: [V: -1] Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [00:17:50] (CR) Ejegg: New PaymentResult class for passing user interaction hints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 (owner: Awight) [00:18:05] (CR) Ejegg: [C: 2] "Kicking CI" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 (owner: Awight) [00:18:15] Thanks for flushing :) [00:18:38] heh [00:20:40] i've been starting the logging changes around the edges this time so we can merge some of your stuff before I make the messy changes to the adapters + pages [00:20:52] No worries! [00:21:02] Rebasing won't be too hard, I'm sure. [00:21:19] Alternatively, you can do your work on my dev head [00:21:34] (sounds like I'm asking for a shave) [00:22:34] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Dedupe Civi - https://phabricator.wikimedia.org/T77938#1061028 (awight) [00:22:35] the most annoying part of Psr\Log\LoggerInterface is that LogLevel is selected from a new set of constants rather than the PHP builtins [00:22:45] blaargh [00:22:51] nice standard [00:22:52] so there will be a lot more changes than we'd need otherwise [00:24:39] I would recommend vim's "q" macros :) [00:25:17] oh, you mean the mode I always end up in by mistake? :P [00:25:18] atgo: fwiw, I've updated the dedupe project phases [00:25:25] hehe [00:25:30] ! [00:31:08] awesome! [00:39:46] (CR) Ejegg: [C: -1] "Let's make processPayment abstract or add stubs of the two fns you've got it calling." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [00:53:32] (Merged) jenkins-bot: New PaymentResult class for passing user interaction hints [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/185598 (owner: Awight) [00:58:44] (CR) Awight: "Yeah sorry about the patch spaghetti, this has been an interesting experiment in learning why small patches can be a bad thing!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [00:59:42] awight: Aw, crammit. I just realized I'm probably going to have to have a lunch plan for the next three days, too. [00:59:58] PCI? [01:00:01] yep [01:00:11] we should make it a family thing :) [01:00:32] Makes sense to me. [01:00:37] At least the first day. [01:00:51] Otherwise, it's hot pockets. [01:00:53] lemme edit my calendar... Thurs is my day off this week. [01:01:00] do people say that? [01:01:12] Do people say... what? [01:01:19] hot potato pockets? [01:01:35] No, I meant the nasty microwave things. [01:01:50] They're like fat pop tarts without the frosting. [01:02:09] aaah. I thought you meant something about petty cash... trading off lunch duty... it was interesting [01:03:19] I think I like your interpretation better. [01:03:32] Is there an easy way to copy an event to the FR calendar? [01:03:38] Yes. [01:03:43] O_O [01:04:00] It's in the "More Actions" dropdown inside the event... [01:04:31] Thanks! That's surprisingly well hidden in plain sight. [01:04:36] Right? [01:04:52] Took me forever to find that doofy thing the first time. [01:04:59] It's so easy now... [01:05:17] And then it's like: "Of course! What the hell was _I_ looking at?" [01:05:38] I feel the same way about "Forward All" in gmail. [01:05:42] Same reason. [01:05:44] whoa [01:05:47] Like... exactly the same thing. [01:06:04] (CR) Ejegg: [C: 2] "Ah, from the top of the tree it all makes sense!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [01:06:08] No c'mon, you're making that up. [01:06:11] That doesn't exist. [01:06:16] ...go look. [01:06:19] (Merged) jenkins-bot: Consolidate GatewayPage logic in the base class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189133 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [01:06:28] I did finally set my gmail to default to "reply all". [01:06:33] (PS3) Ejegg: Don't senselessly repeat base class code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189134 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [01:07:03] It's on the top... by the navigation buttons. The "More" dropdown. [01:07:27] Inside a thread. [01:07:27] ejegg: next time I go off on a quest like that, I think I'll make it a branch. Then, we can review individual patches with "is sane" heuristics, then apply full hermeneutics to the final merge? [01:07:40] K4-713: WAT [01:07:44] that *does* exist [01:08:03] I wouldn't lie about something like that. [01:08:08] Sounds like a good strategy [01:08:12] the "create event" thing is really strange [01:08:18] ejegg: sorry it's too late this time :) [01:08:43] ejegg: I almost don't want to get good at the Gerrit workflow. [01:09:02] It's like honing the skill of taking multiple-choice tests [01:09:18] Paranoia? [01:09:18] "what totally wrong thing will satisfy the evil gods?" [01:09:20] hehe [01:09:24] yes. [01:09:36] incredibly useful in artificially contrived situations [01:09:53] wow, I'm suddenly filled with sadness thinking about workplaces where "create event from thread" is the default response [01:10:20] Hey guys, I have a really smart idea rather than thinking about and responding to your comments. Let's have a meeting! [01:10:32] (CR) Ejegg: Don't senselessly repeat base class code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189134 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [01:10:45] (CR) Ejegg: [C: 2] Don't senselessly repeat base class code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189134 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [01:11:01] (Merged) jenkins-bot: Don't senselessly repeat base class code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189134 (https://phabricator.wikimedia.org/T87043) (owner: Awight) [01:11:13] ejegg: if it helps, I tried to list the actual dependencies in https://phabricator.wikimedia.org/T86251 [01:11:20] in the task description. [01:11:24] Thanks! [01:12:14] Hm, i really don't want to merge the adyen patch at its current tree position, with a WIP in between it and those functions existing [01:12:24] yeah, wait [01:12:35] which patch? [01:13:05] https://gerrit.wikimedia.org/r/#/c/189136/ [01:13:33] ejegg: I think that WIP will be abandoned. [01:13:44] yeah, that was a dead-end [01:14:05] The Adyen thing is legit, IMO, but can be dealt with independently of the rest of the stuff. [01:14:16] (PS3) Awight: Use common code for Adyen form handling [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189136 (https://phabricator.wikimedia.org/T86251) [01:14:37] In other words, yeah it can be cherry-picked after the other patches go in. [01:15:02] (Abandoned) Awight: WIP more controller logic consolidation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189139 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [01:15:14] ah, cool. i see now it's not part of 153's dependencies [01:16:38] that stuff was really a mess to maintain, thanks for CR! [01:16:42] beware the octopus :p [01:17:04] * ejegg tiptoes across the seabed [01:17:27] just... try to not look like a mollusk [01:17:53] * ejegg discards shell [01:18:15] have you seen "defensive tool use by cephalopod"? [01:18:23] * ejegg googles [01:18:26] https://www.youtube.com/watch?v=1DoWdHOtlrk [01:19:41] that might not be the clip where it closes itself in both halves [01:20:04] OH YEAH that's the one [01:20:07] oh, there it it is [01:20:22] * ejegg looks to octopus for interior decorating tips [01:20:35] that thing is so pissed about the doctorazzi [01:21:03] wow, i wonder if they lost many cameras! [01:21:36] um, here's another good one http://rsbl.royalsocietypublishing.org/content/early/2012/06/26/rsbl.2012.0435 [01:22:52] kinky cuttlefish... [01:25:44] that would be an amazing human trick [02:08:45] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 11 others: Notify existing Sprint Projects about new Sprint extension upgrade changes - https://phabricator.wikimedia.org/T89646#1061174 (Mattflaschen) >>! In T89646#1047507... [02:11:52] (CR) Ejegg: "Great leap forward for clarity! Couple trivial things with GC. Also, should querystring vars from return URLs be considered request or r" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [07:57:03] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 11 others: Notify existing Sprint Projects about new Sprint extension upgrade changes - https://phabricator.wikimedia.org/T89646#1061583 (Christopher) The meaning of "Done"... [08:30:50] (PS3) Ssmith: WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 [08:30:52] (CR) jenkins-bot: [V: -1] WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [17:56:20] Is Special:BannerLoader supposed to be served still? I read something recently that it was in use but unsure how. I noticed a request to it just now when using mrj.wikipedia.org [17:56:30] If that's unexpected, let me know and I can provide details [18:10:09] Krinkle: yep, we're still using it. The request means that according to the first pass of the banner targeting rules, you're eligible to see a banner. [18:10:35] ejegg: Ah, okay. [18:10:37] Some banners have js that runs after the BL request and determines that you shouldn't be pestered [18:11:03] ejegg: No rush or anything. I just thought I heard a while back that it was replaced. [18:11:21] I sort of lost track and havent look at it latelt, so don't mind me :) [18:11:25] We're gonna fix it so that js is in some RL modules that run before the BL request and can cancel it [18:11:50] then we'll know that each BL request means an actual banner view, and we can get rid of RecordImpression [18:12:07] Plans have been fluid for a while! [18:12:32] We did get rid of the old BannerRandom last fall, and BannerLoader replaced it [18:13:03] Right. Because Special:BannerLoader replacement should be doable (and I hear also desireable for other reasons so that we can do more complex targetting). BUt I guess then you no longer know which were seen if it's determined clinet-side [18:14:41] yeah, that's one reason to move the client-side banner hide scripts to RL. The other is just to get rid of more wiki-editable javascript [18:31:25] Hi. I'm WFH by mistake... [18:32:52] 10:29 <+marktraceur> My favourite continues to be 402 Payment Required [18:32:57] :D [18:33:47] !leaks [18:34:30] hehehe [18:34:38] that *should* be a bot [18:47:11] arg! infinite eat-drinkcoffee-eat-drinkcoffee cycles 8p [18:48:24] (PS1) Ejegg: Work around another odata-parser deficiency [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/192588 [18:52:16] (CR) jenkins-bot: [V: -1] Work around another odata-parser deficiency [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/192588 (owner: Ejegg) [18:53:28] (PS2) Ejegg: Work around another odata-parser deficiency [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/192588 [19:00:38] K4-713: some light reading for your down time, https://civicrm.org/blogs/sarahgladstone/rethinking-automated-recurring-contributions-code-attached [19:08:22] awight: Yer killin' me, here. [19:08:23] haha [19:08:37] Maybe next month. [19:08:44] But I'm going to need more bubble bath. [19:16:12] K4-713: having fun yet? [19:16:18] wheeeeeeeeeeeeee [19:16:25] :) [19:16:47] You ever have a 3-day oral exam that was worth half of your grade? [19:16:50] :p [19:17:05] Darn! No I never have... [19:18:11] The closest I might have gotten was a 1-day full battery of interviews for a job (at the WMF) [19:19:41] K4-713: BTW I did read the "Please Read" e-mail to fr-all, really sorry I missed it at first 8p... silly brain-based e-mail filter... [19:19:50] Pls let me know if you need anything! [19:19:59] Totally. [19:20:00] Thanks! [19:20:04] Likewise! [19:27:08] (CR) AndyRussG: "Woo! Fun! Just found out that the inconsistent failures here actually due to contamination between tests, the order of which can vary. Pat" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) (owner: Awight) [19:31:37] awight: hey, quick question... Do you know what u meant by "so nothing "? https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/6634134e897f8b77c12926c1b813ce7bd4d82d70/tests%2Fqunit%2Fext.centralNotice.bannerController%2FbannerController.tests.js#L70 [19:32:41] "because void "? [19:33:03] AndyRussG: oh there are words missing :( [19:33:20] AndyRussG: Saw your note about the cross-test contamination btw, I think that's been there all along. [19:33:35] awight: ahhh the nothingness got 'em I guess :) [19:34:19] AndyRussG: the "so nothing" was supposed to continue with an explanation of why we need to delete any built-in sitenotice and start fresh [19:34:19] awight: could be! I guess I didn't notice it, but that's what's causing the failures on my local setup, anyway. [19:34:54] AndyRussG: I should have mentioned, it was precisely these two tests that gave me a problem, the banner= then random= tests. [19:35:32] awight: yeah the latter is what's contaminating the former, making it go to load testing banner instead of loadRandomBanner() (in JS) [19:35:37] ah vice versa [19:35:54] latter, former, ladder, foamer, roamer... [19:36:17] oh no, he's gone off the both ends! [19:37:14] gone off the shallow end while up to his knees in deep end [19:38:00] * AndyRussG tries to jiggle brain parts back into place [19:38:12] rrgg mmrrfg blrg [19:39:01] Fabulosos Cadilacs! [19:40:02] :P [19:40:58] AndyRussG: You probably noticed this already, but mw.centralNotice.data is not reset from initialize(), and should be. [19:41:04] (PS4) Ssmith: WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 [19:41:07] (CR) jenkins-bot: [V: -1] WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [19:42:28] atgo: It's my submission for the next sprint name [19:42:35] awight: I think it's gonna be beforeEach and afterEach, something like that? Could be wrong... http://api.qunitjs.com/QUnit.module/ [19:42:38] haha is that a band? [19:43:02] atgo: http://en.wikipedia.org/wiki/Los_Fabulosos_Cadillacs [19:43:13] haha nice [19:43:42] Finally we came to a letter where I'm not completely off-key... so to speak... [19:44:00] AndyRussG: Sorry, I don't follow. I think setup() is already called? [19:44:23] awight: Hmm one sec lemme check again [19:44:49] I'm thinking the issue is just that mw.cn.initialize() doesn't reset mw.cn.data [19:45:07] Don't know why I missed that the first time through... ah, hindsight. [19:45:34] awight: should it? I think it rightly doesn't expect anything else there, unless someone's messing with its mind [19:45:43] I think it's a testing issue [19:45:52] tests need isolating from each other [19:45:54] hmm, that's a better way to look at it [19:46:00] I wonder if we can destroy mw.cn? [19:46:30] hmmm indeed that would be more thorough than what I was thinking... [19:46:47] oh nasty. We could many a copy of mw.cn and restore that after each test [19:46:56] err, or before. [19:47:21] fatter latter warmer former [19:47:33] here's a dirty trick, http://stackoverflow.com/questions/122102/what-is-the-most-efficient-way-to-clone-an-object [19:47:44] var newObject = jQuery.extend(true, {}, oldObject); [19:47:45] (PS5) Ejegg: WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [19:47:51] hmmmm [19:48:07] one moment, kid attack! [19:48:26] (CR) jenkins-bot: [V: -1] WIP x-by-y data retrieval/parsing [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [19:58:56] awight: K now I see how to do it, sorry for my silliness [20:07:27] looking forward to it! [20:09:23] awight: splitting staging/unstaging looks like a really good idea - i put a couple minor comments on it last night [20:09:40] hrm looks like I was mistaken about the desktop issue on that test! [20:10:51] how so? [20:10:57] ejegg: cool, looking now [20:14:17] awight: now that I fixed the contamination issue it's working with any ua [20:14:35] trying to figuer out why [20:15:18] great! [20:21:37] awight: yurp, it's just that device is only even detected when we load the mobile module [20:23:03] (PS13) AndyRussG: Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) (owner: Awight) [20:32:01] awight: so, PaymentMethod is only used for that one call to get the UtmSourceName? [20:34:15] (CR) Awight: "Query strings can be both, if they're coming from the user, they're request params, if from a processor, then they're response params. Th" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [20:34:27] (PS5) Awight: Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 [20:35:10] ejegg: my plan is to eventually replace all ($payment_method, $payment_submethod) handling with PaymentMethod objects. [20:35:17] but yeah for now, I think that's the only usage. [20:35:22] ah, I see [20:36:16] (CR) AndyRussG: [C: 1] "Yrhmm... I take back my unintentional lie about it being dependent on a desktop ua. That's not even being detected, since we don't load th" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) (owner: Awight) [20:36:56] ejegg: I do need some sanity checking on that, actually. [20:37:18] My thought was that we should refer to payment sub/method everywhere using a single, unique string [20:37:18] The planned usage of PaymentMethod? [20:37:21] rather than a pair [20:37:21] yes [20:37:36] and PaymentMethod would be an opaque type that handles all that [20:38:00] OK, i'll ponder that while I look around [20:38:20] There was another sketchy aspect which I should probably just abandon, that we have basically an "is instance" method that can answer questions like "is this a credit card payment?" "is it a paypal method?" [20:38:52] seems like the getFamily method tells you that [20:38:54] that catalyzed some interesting conversations about globalcollect paypal, etc. [20:38:56] sort of. [20:38:59] awight: Anytime you'd like to give your vo.bo.[1] to my minichange on that patch, then I'll +2, sound good? [1] http://www.proz.com/kudoz/spanish_to_english/business_commerce_general/1111436-vo_bo.html [20:39:27] ejegg: the big question is whether there is a valid use case for having multiple top-level things that a method implements. [20:39:35] AndyRussG: sure! [20:39:42] awight: thanks! :) [20:40:30] multiple top-level things? [20:41:21] ejegg: like, if we run alipay through globalcollect. That's "a globalcollect method", also "is alipay" and "is an ewallet" [20:41:31] I just don't know if there's a real use case [20:41:37] oh, i get it [20:43:15] AndyRussG: what did you fix? I don't see how mw.cn.data.testing gets reset... [20:43:34] I see getVars, but... how is that enough... [20:44:33] ok I see. It's fine that testing is still == true [20:44:40] awight: ah the test for going to loadTestingBanner vs. loadRandomBanner is just whether there is mw.centralNotice.data.getVars.banner exists [20:44:42] cos the conditional was on getVars.banner [20:44:59] (PS14) Awight: Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) [20:45:12] (CR) Awight: [C: 1] "Thanks for fixing this!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) (owner: Awight) [20:47:09] awight: ah! I see what you mean. Yeah it could definitely be cleaner :) Let's leave that for later too? what do you think? [20:52:35] For sure! [21:00:37] (CR) Ejegg: "Noticed one more opportunity to clarify things" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [21:05:27] hrm technical difficulties for hangout one sec [21:05:34] (PS6) Awight: Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 [21:06:08] K4-713 awight pizzzacat eh? [21:06:27] hum? [21:06:28] oh didn't see you in the other room [21:06:34] Er, yeah, I'm out. [21:06:36] K4 is with consultant I am the only one here [21:06:38] Which it should say in the event. [21:06:43] proposed IRC standup [21:06:47] Here's my update: AAARGH. [21:06:49] everyone else is in the hangout [21:06:49] haha [21:06:51] k [21:06:52] Tomorrow: AAARGH. [21:06:53] one sec [21:06:58] :p [21:07:03] oops, sorry [21:07:21] I did want to touch base [21:07:23] plz reenact for the group. [21:08:03] awight: standoop? [21:14:42] awight can we get james a query of some kind so we don't have to pull this daily? how does non-FR get impressions normally (if at all)? https://phabricator.wikimedia.org/T90635 [21:15:10] atgo: that's the reason I wanted him to make a task! cos normally what happens is someone taps Matt Walker on the shoulder... [21:15:20] nobody else has access to this db [21:15:45] what we need to do (long-term) is to extract the data somewhere public, and make all that stuff visible from within CentralNotice. [21:16:03] atgo: for the short-term though, we need to pull the data for him daily. [21:16:05] I think [21:17:27] (CR) Ejegg: "Thanks! Mind changing the other two calls in transactionConfirm_CreditCard to match?" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [21:17:50] oof that is a bummer [21:17:54] but ok [21:18:02] (PS7) Awight: Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 [21:18:21] i or caitlin could do that daily, too, once the query/ies are in hand [21:18:43] Yeah, I don't know at this point if our db is correct, or if we already need the Ellery dbs. <-- AndyRussG do you know? [21:18:48] sorry, context: [21:19:03] we're trying to get banner show and hide stats for James Alexander, https://phabricator.wikimedia.org/T90635 [21:19:12] (CR) Ejegg: [C: 2] Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [21:19:29] (Merged) jenkins-bot: Split staging from unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [21:20:44] awight: atgo: right thx... hmmm... I don't know what I have access to at this point... But it's Ellery's home town [21:20:56] awight: which is our db? [21:21:23] (CR) Awight: Split staging from unstaging (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189615 (owner: Awight) [21:21:25] I would have him ask Ellery because he'll have all the answers on hand [21:21:30] AndyRussG: the ... pgehres thing [21:21:33] ok sure [21:22:00] awight: the udp2log? Ah OK... And "Ellery dbs" is Hive? [21:22:41] FWIW, I may now have access that I did not yet have back in the day... and my laptop is all full-encryption etc etc now [21:23:40] hmm. Well, I'll start with pgehres queries, then Ellery can let us know if that's already been deprecated by hive. [21:24:02] weird, wikibugs is dead? [21:24:29] hallelujah [21:24:39] ya jerk :p [21:24:43] long live wikibugs! [21:25:18] Ah: labs is down [21:31:18] AndyRussG: do hide numbers go into the pgehres db? [21:32:40] awight: yes they do... [21:33:00] awight: also pgehres is not yet dead, apparently analytics wants to kill it but Ellery and FR won't let them [21:33:16] or at least analytics wants to kill udp2log [21:35:19] AndyRussG: where? bannerimpression_raw?? [21:35:26] no... [21:35:48] there's no 'reason' column in pgehres.bannerimpressions... [21:36:48] awight: aaah right yeah they do get processed, but don't go in to the db proper, heh [21:36:55] Thye go into some log that I've never seen [21:37:35] Is it correct form to send Ellery a message on GChat? Since he's not on IRC, I guess that's the ping route... [21:37:42] I think we need hive. I don't think my access request ever went through [21:37:53] * awight turns orange [21:38:13] which access request? [21:38:18] ah for hive [21:38:39] Yeah sounds like accuracy would be more useful than speed in this case [21:38:51] well, they want hide #s [21:39:00] I think the only way to get that is hive [21:41:10] Even if there may be a way to tease some kind of summary out of the pgehres log, hive is probably better [21:41:16] I just pinged Ellery on Gchat [21:41:23] He's "away" tho [21:42:29] atgo: BTW do you agree we should close the S:RI spike task now? I think we have a pretty clear idea about the path to take, or at least try to take :) [21:43:10] yes! [21:43:41] atgo: fantastic! [21:44:40] (CR) AndyRussG: [C: 2] "Wootlicious! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) (owner: Awight) [21:45:18] (Merged) jenkins-bot: Implement random= override test [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/173663 (https://phabricator.wikimedia.org/T86091) (owner: Awight) [21:45:24] atgo: let's export the google doc drawing and put it on the collab page, eh? [21:45:34] yeah sounds good [22:29:31] (PS7) Awight: Make paymentmethod non-static [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/183630 (https://phabricator.wikimedia.org/T86256) [22:36:53] (PS9) Awight: Move remaining controller logic into GatewayAdapter::doPayment() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) [22:45:48] here is your cat of the day: https://40.media.tumblr.com/21282e1adb0060f5d0710282d63083f2/tumblr_neqrgvVBG81tzim7wo1_500.jpg [23:52:21] hey AndyRussG - did you see megan's few questions on that drawing?