[00:19:31] (CR) Ejegg: "Found one more thing, in the worldpay success path" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [00:23:44] pizzzacat: https://www.youtube.com/watch?v=varlFj0W6UA [00:24:34] pizzzacat: where AR u [00:24:47] pizzzacat1: halloo [00:24:52] https://www.youtube.com/watch?v=varlFj0W6UA [00:25:04] if you like that, you might also like... [00:25:21] my internet crapped out and I don't have backscrolling [00:25:32] so I missed the url [00:25:57] pizzzacat: ok. you should start here, https://www.youtube.com/watch?v=varlFj0W6UA [00:26:10] Then you can move on to... https://www.youtube.com/watch?v=wfpL6_0OBuA [00:26:47] oh nvm about that last one [00:28:37] pizzzacat: here's some source material if u need to mix your own: https://www.youtube.com/watch?v=PpccpglnNf0 [00:28:49] haha [00:29:04] oh man that is so good, I love the goat with the slobber [00:34:48] https://wikimania2015.wikimedia.org/wiki/Submissions/Shared_cognition,_knowledge_and_content_production:_the_embodied_noosphere_logs_in [00:35:23] b almost r b :) [00:37:37] whoa :) [00:48:43] (PS1) Ejegg: Fix locale fallback calculation in paypal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193532 [00:50:11] (PS1) Ejegg: Remove/fix/comment unused local variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193533 [00:51:43] (PS1) Ejegg: Remove unused methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193534 [00:52:14] (PS2) Awight: Fix locale fallback calculation in paypal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193532 (owner: Ejegg) [00:52:21] (PS1) Ssmith: Chart now renders [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/193535 [00:53:01] (CR) jenkins-bot: [V: -1] Chart now renders [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/193535 (owner: Ssmith) [00:53:24] (CR) Awight: [C: 2] "Oh wow. Thanks, this bug was not causing a broken machine to work any better." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193532 (owner: Ejegg) [00:53:41] (Merged) jenkins-bot: Fix locale fallback calculation in paypal adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193532 (owner: Ejegg) [00:55:31] thanks awight! [00:58:00] how did you find that... [00:58:10] phpmd unusedcode [00:58:15] whaat [00:58:19] that should be used [00:58:21] mess detection! [00:58:45] oh, I see. $lang is unsed [00:58:48] that's also how i found those: https://gerrit.wikimedia.org/r/193533 [00:59:25] hehe those are entertaining [00:59:27] but the unused methods were via a bunch of grepping [01:00:27] //preserved for historical interest [01:01:04] Historians will mostly spend their time being amused that humans were doing the work of Skynet, back when :p [01:02:57] hmm, is that unused $add_antimessage in globalcollect.adapter.php making the orphan checker do more work? [01:03:33] eep. [01:04:42] ejegg: how is it causing more work, if it's unused? [01:04:57] nah, looks like we add it inside transaction_confirm_CreditCard [01:05:21] I meant should we be checking that var and adding an antimessage someplace? [01:05:56] but it looks like we take care of it, so we can remove that var [01:06:18] i mean at the top [01:07:29] err... i seem to remember futzing with that logic a few months ago. probably my fault that's stranded [01:09:38] ejegg: I'm not seeing the original message that needs to be negated... [01:10:10] I think it's the initial payment started message [01:10:32] Since we're confirming here, we can close out most of them [01:11:30] man, that limbo stomp hook is well hidden... [01:12:15] heh, at least someone left a //Stomp is in here comment [01:15:18] ejegg: I see there's a finalizeInternalStatus 'complete' a few lines above the bogus add_antimessage, but where is it sent as pending? [01:16:11] hmm, actually I'm not sure [01:16:12] odd, maybe it's sent twice, actually? cos of runPostProcessHooks right before the anti line [01:19:29] well, the stranding was my fault in 5c9f995 [01:19:36] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Patch-For-Review, Varnish: Special:RecordImpression should die in a fire - https://phabricator.wikimedia.org/T45250#1075179 (GOIII) With the so-called workaround in place, my //F-12 Developer tool's// console (Win 8.1/IE 11) still reports s... [01:19:44] trying to figure out if I'm adding an extra antimessage [01:20:05] It's possible there are two completed messages. But I don't think any antimessage? [01:20:55] I moved the antimessage up to the block with the CVV check [01:21:18] in a commit about not retrying some bad codes [01:21:32] can't reconstruct my reasoning [01:23:59] perhaps it'll all become clear over the weekend [01:24:15] gonna sign off for the night. Have a good one, all! [01:24:21] yes, you should get a fresh start on Monday :D [04:08:51] (PS1) AndyRussG: Browser tests: add mobile tags [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/193552 [04:14:17] (CR) AndyRussG: "Coming soon to a Jenkins Job near u!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/193552 (owner: AndyRussG)