[00:30:32] beep beep! [00:32:55] how's the new car? [00:34:30] AndyRussG: it's as close as you can get to the corolla station wagons these days, right? [00:34:37] ejegg: not bad! it drives :) [00:34:51] yeah actually Matrices were just discontinued [00:34:56] oh noes! [00:34:59] yeah [00:35:08] 2014 was the last year I think [00:35:16] station wagons are my favorite car form factor by a mile [00:35:27] But there's tons of them here, so I think repairs won't be too expensive [00:35:49] Yeah drives quite well, the inspection (at the CAA, like the AAA) checked out [00:35:58] It's a 2009 but has high mileage [00:36:08] And they're based on the corolla, so they must share some parts [00:36:16] yeah exactly [00:36:21] in km, it's about 190,000 [00:36:35] so in miles... I dunno, 130,000 ? [00:36:47] But it's been kept up, it was probably highway driving [00:36:56] my father and I hardly drive, but we share a '91 corolla wagon with almost 200k miles on it [00:36:57] No evidence of sever collisions ever or anything [00:37:16] right on [00:37:32] cool! yeah I'm not a driving afficionado either [00:38:10] my kids are like, you can give us a lift to school when it's -20 outside! and I'm like, nope, it's 2 blocks [00:38:13] i imagine with kids and montreal climate, there's a lot more impetus! [00:38:18] heh [00:38:36] yeah, it opens up a whole lot of possibilities [00:39:04] outings of almost any sort will get a lot easier [00:39:24] I mean, you can do the bus and metro, they run pretty often and reliably... [00:39:44] but it's still a lot longer than by car a lot of the time [00:39:50] bet it'll be a lot easier to convince them of montreal's merits [00:39:58] heheh also true [00:40:17] do you have a car? [00:41:15] (PS1) Ssmith: final x by y chart commit [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/194243 [00:41:17] that '91 wagon was mine for a while, then my dad's similarly-specced car got totalled (while parked) [00:41:50] (CR) jenkins-bot: [V: -1] final x by y chart commit [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/194243 (owner: Ssmith) [00:41:52] aww [00:41:58] so the wagon lives at my dad's now, but I use it when I need to drive [00:42:10] right [00:42:28] which in metro boston (and without kids) is pretty rare [00:43:43] hmm! [00:43:43] yeah I never owned a car before I was a Dad, even after it took a bit of convincing for me to agree 8p [00:43:43] in Mex we had a thing called a "Chevy Pop". Ironically, almost the same color as the Matrix we just got [00:43:43] Well not ironically [00:43:43] funnily? coincidentally [00:44:03] '91! That's _is_ pretty old. Still runs good? [00:44:30] I think the car we had in Mexico was '97 [00:44:53] But there they don't rust nearly as fast as here [00:46:27] ejegg: looks like no bad fallout from yesterday's CN deploy? :) [00:46:36] so far, so quiet! [00:46:42] excellent! [00:46:53] great to hear [00:47:22] Ohhh! bassooning time again! [01:04:57] (CR) Ssmith: [C: 2] Work around another odata-parser deficiency [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/192588 (owner: Ejegg) [01:05:30] (Merged) jenkins-bot: Work around another odata-parser deficiency [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/192588 (owner: Ejegg) [01:49:34] atgo: hey [01:49:55] I cross-referenced the heck out of my notes on the collab page. [01:50:04] ...for the policy doc section. [01:50:26] I can't tell if I'm happier, or more likely to set the couch on fire and run out of the place. [02:43:52] Wikimedia-Fundraising, MediaWiki-Vagrant: Vagrant Fundraising role needs to be able to run a specific MediaWiki branch - https://phabricator.wikimedia.org/T78739#1085346 (bd808) [02:49:37] (PS2) AndyRussG: WIP Special:RecordImpression: sample by default, custom rates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/193779 (https://phabricator.wikimedia.org/T45250) [02:50:45] (CR) jenkins-bot: [V: -1] WIP Special:RecordImpression: sample by default, custom rates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/193779 (https://phabricator.wikimedia.org/T45250) (owner: AndyRussG) [02:55:09] (PS3) AndyRussG: WIP Special:RecordImpression: sample by default, custom rates [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/193779 (https://phabricator.wikimedia.org/T45250) [17:25:20] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Document CiviCRM custom fields - https://phabricator.wikimedia.org/T91519#1089114 (awight) NEW [17:33:48] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Document CiviCRM custom fields - https://phabricator.wikimedia.org/T91519#1089196 (Ejegg) It seems like almost all of this can be generated from the Civi db automatically. The only thing missing is a 'description' box for custom fields. [17:34:39] ejegg: yes! that would be a great start. [17:38:44] lemme see if trunk has such a thing [17:59:09] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Document CiviCRM custom fields - https://phabricator.wikimedia.org/T91519#1089374 (Ejegg) Trunk Civi still doesn't have a description field, so I created an improvement suggestion in their Jira: https://issues.civicrm.org/jira/browse/CRM-16054. Doesn't... [18:27:57] hey ejegg - https://phabricator.wikimedia.org/T77912 [18:28:42] 91447-49 are relevant to Security [18:29:33] and 51 [18:53:32] Wikimedia-Fundraising, Analytics: Provide performant query access to banner show/hide numbers - https://phabricator.wikimedia.org/T90649#1089515 (awight) @kevinator, I hear you might be interested in this problem. We need to do something like, digest web requests into a database that can be queried effi... [19:09:28] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Document CiviCRM custom fields - https://phabricator.wikimedia.org/T91519#1089550 (awight) That's a great idea! I would still want us to have a single document for conciseness, but as you said, it would be a great start to be able to dump the current f... [19:36:29] (PS2) Ssmith: final x by y chart commit [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/194243 [19:37:11] (CR) jenkins-bot: [V: -1] final x by y chart commit [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/194243 (owner: Ssmith) [19:39:02] pizzzacat: maybe you want to start the jslint fixes with https://gerrit.wikimedia.org/r/190343/ [19:39:29] (PS3) Ssmith: final x by y chart commit [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/194243 [19:39:32] Since we gotta make that one mergeable before the others can go [19:39:56] ah, ok, ejegg [19:40:03] (CR) jenkins-bot: [V: -1] final x by y chart commit [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/194243 (owner: Ssmith) [19:40:04] well I already did that one but ok [19:40:10] blah [19:41:08] so, I seem to remember some issues with running jslint locally [19:41:20] awight did we ever figure that out? I keep pushing dumb patch sets [19:42:38] ejegg are you saying to start at the bottom and bubble up? to rebase upward? [19:42:43] somehow [19:42:46] yeah [19:42:50] ok gotcha [19:42:52] thanks [19:44:26] if you make all the fixes for the first patch and commit them at the end of the line, you can do one of those interactive rebases and move your fixes to just after the first, changing the 'pick' to 'fixup' [19:44:48] and git will combine your fixes with the first patch, then rebase the next two on top of the fixed version [19:45:34] sounds like something I will definitely mess up. [19:45:43] but I am willing to try it! [19:46:31] also awight atgo K4-713 I know this will come as a shock to you all, but I am seriously wanting pizza for lunch [19:46:44] I have a mysterious thing to go do. [19:46:54] i brought lunch today... we have the FR lunch too. maybe in ze park? [19:47:02] oh man [19:47:02] ccogdill: do you know anything about if FR lunch is happening? [19:47:23] atgo I don’t know… I don’t think I have time today [19:47:33] what do you think? [19:47:44] I don't think I have time eitehr [19:47:47] *either [19:48:15] I guess I will just have to find pizza another day. *sniff* [19:49:10] pizzzacat: I'm pretty sure you can run jslint locally, now [19:49:23] awight howww [19:52:07] pizzzacat: ./node_modules/gulp/bin/gulp.js lint [19:55:12] I was going to come down to 3 [19:55:19] (to eat lunch) [19:58:33] ejegg: hey, weren't you saying that dash development requires node 0.10 ? [19:59:03] ahh, right, gulp doesn't work on 0.8.2 [19:59:04] pizzzacat and I are baffled, cos "gulp lint" fails on node 0.8, but... isn't that the version running the Jenkins jobs? [19:59:23] huh, good question! [19:59:36] I think Jenkins may not be using gulp [19:59:52] whoa [20:00:09] it totally works now using v 10 of node [20:01:33] yeah, jenkins is running jshint directly [20:20:42] (PS2) AndyRussG: Browser tests: add mobile tags [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/193552 (https://phabricator.wikimedia.org/T86092) [20:32:58] Wikimedia-Fundraising, Analytics: Provide performant query access to banner show/hide numbers - https://phabricator.wikimedia.org/T90649#1089982 (AndyRussG) I know nothing about whether it's easy or feasible... but I'm imagining something like a cluster-side script that logs certain requests directly in... [20:45:29] ejegg: awight: pizzzacat: hi... to continue... er... seeking CR without reciprocating at all ;p I humbly bring to ur attention this sleek and biootiful one-liner :) https://gerrit.wikimedia.org/r/#/c/193552/ [20:46:21] (PS8) Ssmith: Data retrieval/superclassing. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 [20:46:43] sure AndyRussG - looking now! [20:46:52] pizzzacat: woo, thanks :) [20:47:08] (CR) jenkins-bot: [V: -1] Data retrieval/superclassing. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [20:47:11] (CR) Ssmith: [C: 2] Browser tests: add mobile tags [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/193552 (https://phabricator.wikimedia.org/T86092) (owner: AndyRussG) [20:47:20] whew that was rough [20:47:23] pizzzacat: woohoo! [20:47:38] trust me, I was sweating it ;p [20:48:05] interesting how linting on my local says everything's cool, but Jenkins linting is all "NOPE" [20:49:14] pizzzacat: where do you see the Jenkins "nope"? [20:49:28] https://integration.wikimedia.org/ci/job/wikimedia-fundraising-dash-jslint/432/console [20:49:34] 6 errors [20:49:41] AndyRussG: not your commit, don't worry! [20:49:50] but locally the output is clean :-/ [20:49:52] ohh sorry [20:49:56] thanks ejegg [20:49:57] ahhh that's OK [20:50:05] yes AndyRussG my own patch [20:50:18] Ah hmm [20:50:39] Could be different versions of jslint? [20:50:48] Or different config? [20:51:03] Or just bees in the optical disk readers [20:51:11] must be a different config [20:51:13] I hear the cluster's been getting that a lot [20:51:26] Eh bees can do a lot of damage, you never know [20:51:29] heh [20:52:36] oh, jsfilesToLint needs to include a bunch more stuff! [20:54:12] (PS9) Ssmith: Data retrieval/superclassing. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 [20:55:35] ejegg is that on Jenkins' end or my end? [20:55:38] probably mine huh [20:56:33] I'll check in a patch for gulpfile.js in a sec [20:56:53] ok! [20:58:06] (PS1) Ejegg: Lint all js except node_modules and bower_modules [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/194389 [20:58:42] thanks! [20:59:09] ejegg also, I guess I am ready to pull those linting fixes up the chain... [20:59:15] interactive rebase, you say? [21:00:17] that was a way to pull them up the chain at the same time as you applied them to the bottom patch set [21:00:41] doh [21:00:51] no big deal though [21:00:55] :'( [21:01:10] you can just cherry-pick the next two on top of the mergeable version of the first one. [21:01:11] is there a cool n fun way to do it after the fact, right now? [21:01:28] <:o) [21:02:12] like if I go in and click "rebase change" in gerrit, what does that actually do? [21:03:08] ah, that timeFormat still needs a 'var' before it, or a comma connecting it to the other declarations [21:03:19] (CR) jenkins-bot: [V: -1] Data retrieval/superclassing. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [21:03:32] blahhh I fixed that so many times [21:04:16] pizzzacat: yeah, rebase change in gerrit might work too, depends on how much the next two patches touch the stuff you're fixing in the first one. [21:05:12] (PS10) Ssmith: Data retrieval/superclassing. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 [21:05:50] ejegg what would you recommend? trying the gerrit way up the chain? [21:06:07] (or does gerrit automatically go up the chain? or just to the next up patch?) [21:06:16] doesn't hurt to try that first [21:06:32] ok waiting for that linting to fail [21:06:45] I think it only rebases the patch you press the button on [21:07:11] maybe I don't understand the wording of that? [21:07:17] So, do I get any of my wishes from PS7 ? :) [21:07:28] of this same patch? [21:07:46] I'm so sorry. I have been getting really mixed up with everything [21:07:54] let me look [21:08:17] oh jeeze [21:08:34] I hadn't even gotten to this stuff yet, was just fixing linting [21:08:58] sigh [21:10:55] *waves wand* your wishes are granted [21:11:22] does it all evaporate at midnight? [21:12:23] I think I might [21:12:39] anyway, will fix these today between meetings! [21:12:52] not looking forward to the linting rebase [21:13:02] I somehow still do not ever get rebasing right. [21:13:27] like there must be some just fundamental conceptual problem I have with it [21:22:06] Wikimedia-Fundraising, Analytics, Fundraising Tech Backlog, Fundraising Sprint Enya: Strategy banner impressions - https://phabricator.wikimedia.org/T90635#1090203 (Jalexander) Bump on this to see if any news :) [21:36:36] (CR) Ssmith: Data retrieval/superclassing. (12 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/190343 (owner: Ssmith) [21:37:20] ejegg what is the preferred indent? [21:37:43] pizzzacat: same as we're using elsewhere [21:37:53] let me see.. [21:37:59] the issue there was just a lot of extra tabs that make all the lines wrap in gerrit [21:38:16] weeeird [21:38:20] so changes are a lot harder to read [21:38:28] I can see, ok [21:38:34] I wonder what I did for that file. [21:38:51] looks like I'm using tabs that are equal to four spaces, everywhere else [21:41:28] thanks for all the feedback ejegg! [21:41:43] my pleasure! [21:43:04] Wikimedia-Fundraising, Analytics, Fundraising Tech Backlog, Fundraising Sprint Enya: Strategy banner impressions - https://phabricator.wikimedia.org/T90635#1090262 (awight) @Jalexander: February numbers should be ready in about half an hour, Can you access this URL? https://hue.wikimedia.org/bee... [21:47:35] Hey atgo, does it make sense to add a card for the further improved workaround for S:RI? [21:47:50] what's that? [21:48:49] Ah it's what we deployed on Monday to further cut down S:RI, as per comments on "S:RI must die in a fire" [21:49:10] atgo: https://phabricator.wikimedia.org/T45250 [21:49:17] It's deployed [21:49:30] oh i think it's ok to stay nested in there [21:49:49] OK cool :) [21:50:25] There's also a further improvement that we could roll out while we're waiting for the real fix... I guess another card would be good for that one? [21:50:34] Or also just roll with the same card? [21:52:16] atgo: ^ ? [21:52:46] what's the further improvement? [21:57:29] ejegg I am a little worried about making all these changes in this patch set and then, knowing what's coming next, having lots of merge issues. [21:58:03] hmm [21:58:03] atgo: the idea is to make S:RI always sample by default, and make any campaigns that indent to use impresions have to explicitly data turn it on, and set it to whatevers sample rate they need [21:58:29] pizzzacat: would it make sense to smoosh all 3 patches together? [21:58:38] that could work... [21:58:41] I think? [21:58:51] AndyRussG: this seems a bit unnecessary since we're already heading towards sundowning S:RI [21:59:10] oops meeting [21:59:13] pizzzacat: that's really easy to do with the interactive rebase [21:59:24] ah ok, will check it out.. [21:59:29] might ping you [22:00:02] atgo: well true, but... still it's a little ways off and without that there'll still be some unneeded calls to S:RI. but yeah you're right it does still need discussing [22:00:16] yeah i'm not sure we need to go there and delay the actual solution [22:12:42] atgo: OK! [22:12:48] hey pizzzacat be right there... i've got to do 2 quick things [22:13:35] no worries atgo [22:27:10] (PS11) Awight: Move remaining controller logic into GatewayAdapter::doPayment() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) [22:27:21] (CR) Awight: Move remaining controller logic into GatewayAdapter::doPayment() (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [22:27:28] (CR) Awight: Move remaining controller logic into GatewayAdapter::doPayment() (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [22:44:58] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 3 others: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1090476 (AndyRussG) Current status... [22:45:08] Wikimedia-Fundraising, Analytics, Fundraising Tech Backlog, Fundraising Sprint Enya: Strategy banner impressions - https://phabricator.wikimedia.org/T90635#1090478 (awight) a:awight [22:46:32] Wikimedia-Fundraising, Analytics, Fundraising Tech Backlog, Fundraising Sprint Enya: Strategy banner impressions - https://phabricator.wikimedia.org/T90635#1090479 (Jalexander) >>! In T90635#1090262, @awight wrote: > @Jalexander: February numbers should be ready in about half an hour, > > Can you... [22:51:08] (CR) Ejegg: Move remaining controller logic into GatewayAdapter::doPayment() (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [22:55:03] (CR) Ejegg: [C: -1] "BT/OBT looks good! Found one last thing in PaymentResult::fromResults while verifying that Worldpay success also works correctly." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [23:00:18] § Fundraising Sprint the Cure, Fundraising Tech Backlog, Fundraising-Backlog, Fundraising Sprint Enya: [2 hours] BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1090560 (Ejegg) This gives no insight into our 'XX' problems, but it explains the 'EU'... [23:45:49] § Fundraising Sprint the Cure, Fundraising Tech Backlog, Fundraising-Backlog, Fundraising Sprint Enya, Fundraising Sprint F: [2 hours] BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1090681 (atgo) [23:46:00] Wikimedia-Fundraising, Analytics, Fundraising Tech Backlog, Fundraising Sprint Enya: Strategy banner impressions - https://phabricator.wikimedia.org/T90635#1090682 (awight)