[00:02:06] Wikimedia-Fundraising-CiviCRM: Add "mobile" to list of phone type options on a contact record - https://phabricator.wikimedia.org/T89017#1090768 (atgo) [00:02:23] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Have Civi export name data in UTF-8 format - https://phabricator.wikimedia.org/T90834#1090769 (atgo) [00:35:03] Here is your cat of the day! http://40.media.tumblr.com/a3ef0c863aa066d3cf6e61f502e17bfc/tumblr_ndhk9hRahT1rkallao1_500.jpg [00:40:16] pizzzacat: whoa those shoes are waaaay too big [00:40:28] can you imagine how uncomfortable that must be? [00:40:41] very original tho [00:40:51] thanks 4 sharing :) [00:55:00] AndyRussG awight ejegg please copy your tasks from enya to FL [00:55:11] atgo: okidoki [01:15:30] okay, will do [15:19:15] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 4 others: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1092182 (AndyRussG) [16:09:15] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Tech Backlog, Release-Engineering, and 3 others: Create CI slave instance for CiviCRM testing - https://phabricator.wikimedia.org/T89894#1092315 (awight) [16:09:33] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Tech Backlog, Release-Engineering, and 3 others: Configure Jenkins to run CiviCRM builds only on Fundraising CI slaves - https://phabricator.wikimedia.org/T89895#1092316 (awight) [16:09:44] Wikimedia-Fundraising-CiviCRM, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, and 6 others: Run CiviCRM testing scripts during CI - https://phabricator.wikimedia.org/T89896#1092317 (awight) [16:10:31] Wikimedia-Fundraising, Analytics, Fundraising Tech Backlog, Fundraising Sprint Enya: Strategy banner impressions - https://phabricator.wikimedia.org/T90635#1092319 (awight) Open>Resolved [16:13:28] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1092320 (awight) We should weigh this work against a campaign-level mixin to do the same thi... [16:14:20] Wikimedia-Fundraising, Analytics, Fundraising Tech Backlog, Fundraising Sprint Enya: Strategy banner impressions - https://phabricator.wikimedia.org/T90635#1092328 (awight) Results have been delivered. I balked at making them public, because some auth tokens are slipping through the url parsing a... [16:14:36] Wikimedia-Fundraising, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 5 others: Move any remaining controller logic out of the form classes - https://phabricator.wikimedia.org/T86251#1092329 (awight) [16:14:52] § Fundraising Sprint Devo, Fundraising Tech Backlog, Fundraising Sprint Enya, Fundraising Sprint Flaming Lips, Patch-For-Review: Logging should be handled outside of core gateway class - https://phabricator.wikimedia.org/T86266#1092332 (awight) [16:15:58] (CR) Awight: "n.b., depends on vendor/ change abd7dd6c9ac13a780945884e2bd1028ef54b7956" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193280 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:22:33] (CR) Awight: [C: 2] "This makes me wonder... Are we sure that the DonationInterface vendor/autoload.php will be included after the mediawiki-core autoload? We" (1 comment) [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:24:51] (CR) Awight: [V: 2] Add Monolog and PSR\Logger [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:25:03] (PS6) Awight: Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:54:56] (CR) Awight: "Just a few questions. Looks like it will run!" (14 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [17:23:42] (CR) Ejegg: "Thanks for the CR! Will have another patch shortly with your suggestions" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [17:24:06] So, I don't have FB. But this finally percolated down to me: savethebros.com [17:24:26] * K4-713 raises eyebrow [17:25:19] Please watch the video. If you don't buy this product, we could face complete bro colony collapse. [17:25:49] oh noes. [17:25:54] Whatever would we... wait. [17:27:27] "they don't even have to know it's organic" [17:32:34] ejegg: hi! [17:32:38] About this, require_once( 'gateway_common/WmfFramework.php' ); [17:33:00] does the class_alias fool $wgAutoloadClasses or something [17:33:01] ? [17:34:22] K4-713: hey um, what's "lunch at the archive" about? [17:34:56] Are you snooping on my calendar? :p [17:35:11] My totally public calendar that I encourage people to... [17:35:21] ...ha, it's lunch, right... at the Internet Archive. [17:35:31] Hence the name... [17:35:33] * Nemo_bis approves [17:35:45] I have never been there. [17:36:08] K4-713: hehe. atgo added me to the invite, hence snoopy [17:36:18] Also, I guess they have a lot of questions for fundraising tech type people. [17:36:45] cool. I have friends there, I'll heads-up [17:37:14] Nemo_bis: :p [17:37:16] Cool. Just let me double-check the dates: I heard it was getting moved around. [17:37:21] yah, thx [17:40:54] Sometimes I think we should go have lunches with a ton of non-profits that are hitting that... transaction volume ceiling. You know what I'm talking about? [17:41:06] And not just because I like meeting people and eating things. [17:41:21] hi awight, sorry, had IRC under other windows [17:41:25] (though I do like those things) [17:42:23] +1 lunches +1 sharing tech +1 non-profits [17:43:43] I don't think the class alias is fooling anything per se. PHP should try to load whichever class is the target of the alias and autoload it normally if it's not there yet. [17:43:57] awight: Okay. So, how do we... tell people. That we will tell stories for sandwiches. [17:44:16] Or burritos. [17:47:30] ejegg: then, can we autoload ifdef MEDIAWIKI, and only require_once under Drupal? [17:48:15] K4-713: that should be a footnote in the donation banner. * Our tech team is ready and willing to meet you for coffee and especially spicy food, please insert credit card here. [17:49:09] Oh, and please consider editing the wiki rather than donating money or burritos. [17:49:20] serious. [17:50:11] Will Pontificate for Curry [17:50:59] I think we should hire someone to make these important phone calls. [17:52:06] Wikimedia-Fundraising-CiviCRM: New Civi Users for Engage have restricted access in Civi - https://phabricator.wikimedia.org/T91667#1092752 (RLewis) NEW [17:52:58] awight: okay, I'll see how that works [17:53:45] (CR) Awight: [C: 2] "Woo tests!" (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [17:59:30] awight ejegg i like the tag teaming you're doing on moving things into the sprint :P [18:02:26] The eye of Sauron speaks! [18:04:36] (CR) Awight: [C: 2] "I agree with your decision to keep behavior unchanged in this patch, but I'm fighting the itch to add FIXMEs all over the place." (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192977 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [18:13:56] (CR) Awight: [C: 2] "Unflagging!" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193272 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [18:14:46] whew, made it through the big one! [18:14:55] ha [18:15:32] U might want to check my fixes to doPayment(), too, since the logging patches are based on that... [18:16:14] OBT/BT fixup looked good [18:16:33] I just noticed one last thing in the PaymentResult creation fn [18:16:35] Thanks for catching that, it would have been a sad winter in Australia :D [18:16:38] ok [18:16:49] there's a comment on PS11 [18:17:17] I may have snuck that in right before sprint planning [18:18:18] a time-tested strategy :p [18:20:44] (CR) Awight: [C: 2] Use PSR logging in GatewayPage classes (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193280 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [18:25:12] (PS12) Awight: Move remaining controller logic into GatewayAdapter::doPayment() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) [18:25:44] (CR) Awight: Move remaining controller logic into GatewayAdapter::doPayment() (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [18:30:24] (PS2) Awight: WIP move param harvesting to the form layer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190359 (https://phabricator.wikimedia.org/T91670) [18:30:27] (CR) jenkins-bot: [V: -1] WIP move param harvesting to the form layer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/190359 (https://phabricator.wikimedia.org/T91670) (owner: Awight) [18:31:04] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Move GET/POST/COOKIE/SESSION assumptions into the UI controller - https://phabricator.wikimedia.org/T91670#1092937 (awight) [18:38:19] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Spike: Choose new template engine for DonationInterface and plan integration - https://phabricator.wikimedia.org/T91673#1092981 (awight) NEW [18:38:55] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Spike: Choose new template engine for DonationInterface and plan integration - https://phabricator.wikimedia.org/T91673#1092989 (awight) [18:39:39] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#964453 (awight) [18:43:39] (PS7) Ejegg: Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) [18:43:57] (CR) jenkins-bot: [V: -1] Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [18:44:05] (CR) Ejegg: Add Monolog handlers and processors (7 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [18:44:45] oh right, that dang testAutoLoadConfig [18:47:53] (CR) Awight: Add Monolog handlers and processors (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [18:48:40] ejegg: it's kinda useful. Isn't that the one that forces u to register your test classes under the UnitTestsList handler? [18:49:10] oh, is that what it's meant to do? [18:49:15] * awight|distractd bristles at "auto" things that still require manual class registration [18:49:42] Right now it's just complaining when we use autoload for something that's really just an alias [18:54:19] huh, "Only accept aliases for classes in the same file, because for correct behavior, all aliases for a class must be set up when the class is loaded" [18:54:38] atgo: cool, thx for the clarification! [18:54:58] ejegg: wat. That's an error message? [18:55:08] no, a comment in the test [18:55:26] with a link to https://bugs.php.net/bug.php?id=61422 [18:55:39] dear god [18:56:30] oh good, a 2012 bug that we can't assume is fixed for another 3 years [18:59:58] I'd rather go back to require_once than mash all those classes into the same file [19:01:39] (PS8) Ejegg: Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) [19:01:59] (CR) jenkins-bot: [V: -1] Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [19:05:18] (PS9) Ejegg: Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) [19:16:49] (PS5) Ejegg: Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) [19:17:31] (CR) Ejegg: Use PSR logging in DonationData (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [19:39:06] ejegg: totally. so the autoload don't work? [19:40:12] Just because of that test. I'm still not sure when that PHP bug would bite us [19:59:19] (PS4) Ejegg: Use PSR logging for gateway extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192977 (https://phabricator.wikimedia.org/T86266) [19:59:21] (PS6) Ejegg: Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) [20:01:40] (CR) Ejegg: Use PSR logging for gateway extras (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192977 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:19:51] (PS5) Ejegg: Use PSR logging for gateway extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192977 (https://phabricator.wikimedia.org/T86266) [20:19:53] (PS3) Ejegg: Use PSR logging in GatewayPage classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193280 (https://phabricator.wikimedia.org/T86266) [20:19:55] (PS4) Ejegg: Use PSR logging in gateway adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193272 (https://phabricator.wikimedia.org/T86266) [20:20:14] (CR) Ejegg: Use PSR logging in GatewayPage classes (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193280 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [20:28:57] (CR) Ejegg: "Yep, mw-core's vendor/autoload is definitely first. It happens in WebStart.php even before pulling in LocalSettings." [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [21:00:06] Wikimedia-Fundraising-CiviCRM: Batch refund recurring donations in Civi - https://phabricator.wikimedia.org/T91695#1093499 (CCogdill_WMF) NEW a:atgo [21:05:39] ejegg: boo! [21:24:20] § Fundraising Sprint Devo, Fundraising Dash, Fundraising Sprint Enya, Fundraising Sprint Flaming Lips: Finish refactoring of each already existing widget - https://phabricator.wikimedia.org/T89298#1093592 (pizzzacat) [21:24:40] § Fundraising Sprint Devo, § Fundraising Sprint the Cure, Fundraising Dash, Fundraising Sprint Enya, Fundraising Sprint Flaming Lips: Library link leads to Library page - https://phabricator.wikimedia.org/T86838#1093593 (pizzzacat) [21:24:56] § Fundraising Sprint Devo, § Fundraising Sprint the Cure, Fundraising Dash, Fundraising Sprint Enya, Fundraising Sprint Flaming Lips: Show default board when user logs in (Persistence) - https://phabricator.wikimedia.org/T86837#1093594 (pizzzacat) [21:25:17] § Fundraising Sprint Devo, § Fundraising Sprint the Cure, Fundraising Dash, Fundraising Sprint Enya, Fundraising Sprint Flaming Lips: Parse filter data when response is returned - https://phabricator.wikimedia.org/T86842#1093595 (pizzzacat) [21:25:34] § Fundraising Sprint Devo, § Fundraising Sprint the Cure, Fundraising Dash, Fundraising Sprint Enya, Fundraising Sprint Flaming Lips: Save/Store X-by-Y widget (Persistence) - https://phabricator.wikimedia.org/T86836#1093596 (pizzzacat) [21:34:29] Here is your Cat of the Day everyone: http://i.imgur.com/sLsAD.jpg [21:59:36] pizzzacat: oh noes! that cat could get hurt! [22:01:34] AndyRussG: I think she's just a little too punk rock to care [22:01:48] pizzzacat: oh [22:01:49] Hmm [22:01:59] Is it just a phase? [22:02:28] I guess that depends on whether she lived to see another day [22:06:55] Heheh [22:16:14] (CR) Awight: [C: 2] Add Monolog handlers and processors (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:20:17] (CR) Awight: [C: 2] Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:24:51] (CR) Awight: [C: 2] Use PSR logging for gateway extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192977 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:32:51] um K4-713 did you hear about this? http://blog.sfgate.com/stew/2015/02/25/pack-of-guinea-pigs-abandoned-at-dolores-park/#photo-599681 [22:33:01] I did. [22:33:06] :'( [22:33:09] ...they're not mine. [22:33:10] haha [22:33:13] haha [22:33:19] I never would have thought that. [22:33:21] I guess tons of people wanted to adopt them. [22:33:33] ohh that's good. I hadn't heard a follow up. [22:33:38] Hopefully they got referred to other rescues in the area... there are a ton of abandoned piggles. [22:33:39] :') [22:33:47] oh is that how you found yours? [22:34:03] I guess a lot of people go "Oh hey, you know what would be fun? Breeding guinea pigs!" [22:34:17] [five minutes later] [22:34:26] "OMG WHAT DO I DO WITH ALL THESE GUINEA PIGS" [22:34:42] And, yeah: Mine were rescues. [22:36:39] aww [22:41:35] I think I'm trying to do something that's actually impossible. [22:41:56] Every time I deal with an email, by the time I get back to my inbox there are like three more. [22:43:36] This must be how salmon feel. [22:44:37] salmon write e-mail? [22:44:51] Only when they really, really want to. [22:45:11] Hmmm [22:45:28] I guess they're lucky like that [22:45:46] Determination is worth a lot. [22:46:05] they're... determined then? [22:46:21] I mean, they'd have to be. No fingers. [22:46:27] Also no underwater keyboards. [22:46:38] Heheheh just waterproof cellphones [22:47:08] Do you think I could get startup money to waterproof tablets so salmon could write emails? [22:47:17] Definitely [22:47:22] But not from the fisheries industry [22:47:39] In that case, you guys are on your own from now on. [22:47:43] GOOD LUCK [22:47:50] :D [22:47:51] oh noes, I take it back [22:48:22] Eh, I figured it was too good to be true. [22:48:35] phew! [22:48:38] BTW K4-713 yesterday I realized that an old friend of mine, who I've known for more decades than I know what to do with, is very familiar with the PCI standard [22:48:44] orly [22:49:30] How familiar, and are they still in it? [22:50:20] Yeah... He's a lawyer, specializes in payments and stuff... I know WMF legal is excellent etc. etc. but if you were to need a reference for legal PCI specialties... [22:50:27] Thought I'd mention it just in case [22:50:40] Always nice to know people to call. [22:50:46] Yurp! [22:52:14] http://www.adamatlas.com/ [22:52:20] Went to high school with the guy [22:52:34] Just ignore the fact that he looks like David Letterman [22:53:31] That is also... quite a name 8D [22:53:48] Heheh your namesake on the first half [22:55:12] It is his real name, though I'm sure it has marketing value... [22:55:44] (CR) Awight: [C: 2] Use PSR logging in gateway adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193272 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:56:41] Wow. [22:56:41] (CR) Awight: [C: 2] Use PSR logging in GatewayPage classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193280 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [22:56:55] This does sound like an inexplicably unpopular comic book from the 60s. [22:57:08] awight: thanks! [23:00:00] (PS2) Awight: Cache some mailing details [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/194165 (https://phabricator.wikimedia.org/T86863) (owner: Ejegg) [23:00:23] (CR) Awight: [C: 2] "Good idea! In the long term, this caching should be built into the CRM_Mailing BAO classes..." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/194165 (https://phabricator.wikimedia.org/T86863) (owner: Ejegg) [23:00:28] (Merged) jenkins-bot: Cache some mailing details [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/194165 (https://phabricator.wikimedia.org/T86863) (owner: Ejegg) [23:01:12] (PS2) Awight: Remove unused methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193534 (owner: Ejegg) [23:02:05] K4-713: haha [23:03:03] hey ejegg! i see that this one isn't in any sprint... https://phabricator.wikimedia.org/T86863 [23:03:40] Oh yeah, I just had that little patch hanging around half finished for a while [23:03:47] K4-713: have u seen John Oliver's INFRASTRUCTURE trailer? [23:03:58] awight: ...no. [23:04:20] I have not even heard of this. [23:04:28] Which makes me think I've been stuck in a cave for a while. [23:04:29] I found myself glued to a few of his segments, surprisingly not wasted time! [23:04:32] atgo: I'm not sure that patch will do enough to close that ticket though. There are a ton of other db calls that may mean it's still too slow to use [23:04:36] awight: He's great. [23:04:43] ahhh got it. is this part of some larger thing? [23:04:47] getting civimail to work? [23:04:56] yeah [23:04:56] K4-713: you would appreciate this one, though long at 30 min. "If we do our job right... Nothing exciting happens." [23:04:57] so that MG can do.. something? [23:05:09] heh, and we can track bounces better and stuff [23:05:35] oh cool. [23:05:38] awight: In the event that something untoward happens to me at some point, please make sure they carve that on my grave. [23:05:40] do we have an epic for it somewhere? [23:06:06] There was a mingle card once, but I haven't made anything in phab [23:06:17] i can, though! [23:06:24] (CR) Awight: [C: 2] Remove unused methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193534 (owner: Ejegg) [23:06:26] yeah it would be cool to bring that over to track what else we might want to do here [23:06:32] (PS2) Awight: Remove/fix/comment unused local variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193533 (owner: Ejegg) [23:06:36] ok, will do [23:06:41] thank you :) [23:07:07] K4-713: you got it. Not quite as agro as I was hoping, though... [23:08:57] You can immediately cover the thing with moss if that makes you feel better. [23:09:02] :D [23:09:24] ejegg: the CiviMail job is run from the UI? I thought that was queued and run by a bg job? [23:09:39] Moss + buttermilk + tears of mourners -> blender... then go nuts. [23:09:50] (Merged) jenkins-bot: Remove unused methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193534 (owner: Ejegg) [23:10:03] huh? I was pretty sure it was a bg job too [23:10:04] How did you know... That really is on my short list of todos. [23:10:23] ejegg: ah ok. Wondering why it needs to be performant then. Just to not break everything else? [23:10:27] "just" :) [23:10:44] So as not to slow down the thank you send [23:11:28] (PS3) Awight: Remove/fix/comment unused local variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193533 (owner: Ejegg) [23:11:34] (CR) Awight: Remove/fix/comment unused local variables (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193533 (owner: Ejegg) [23:11:44] (CR) Awight: [C: 2] Remove/fix/comment unused local variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193533 (owner: Ejegg) [23:12:05] (Merged) jenkins-bot: Remove/fix/comment unused local variables [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193533 (owner: Ejegg) [23:12:07] I think the ty mailer was falling behind incoming donations when we had CiviMail inserts enabled at some point late last year [23:12:58] aah, thanks for the context, now I remember. [23:16:54] AndyRussG: u want my help putting on a finger puppet show to triage https://phabricator.wikimedia.org/T86100 ? [23:17:07] Wikimedia-Fundraising-CiviCRM, Fundraising Tech Backlog, Patch-For-Review: Fix performance problems recording thank you emails to CiviMail records - https://phabricator.wikimedia.org/T86863#1094156 (Ejegg) [23:17:09] Wikimedia-Fundraising-CiviCRM, Fundraising Tech Backlog, Fundraising-Backlog, Epic: Make CiviMail useful - https://phabricator.wikimedia.org/T91710#1094157 (atgo) p:Triage>Normal [23:17:22] thanks ejegg :) [23:17:31] yw! [23:17:32] awight: hmmm? [23:17:51] * AndyRussG doesn't recognize the name of that band, either [23:17:54] AndyRussG: do you have time to chat about the plan for migrating banner diet snippets? [23:18:17] awight: sure, but I really don't have anything intelligent to say about it, I think [23:18:33] hehe, it's a euphemism I was introduced to recently. "finger puppet" would be my role, and you would talk out whatever you're thinking :) [23:18:54] Aaah got it :) [23:18:57] also: Rubber duck. [23:19:07] ah right [23:19:27] AndyRussG: no problem, we could also chat after/during https://phabricator.wikimedia.org/T90913 [23:20:01] awight: that sounds like a good idea but let me get a bit further into it first, so yea at least once I've made a bit of headway on that task [23:20:23] makes sense! [23:20:32] I'll link as blocked... [23:20:35] awight: if you are interested and have absence of fun tasks you're very welcome to start digging into that card, BTW [23:20:40] ah yeah that makes sense [23:20:53] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 4 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1094160 (awight) [23:21:36] awight: For the performant campaign-associated mixins, my main worry is not sending puppetloads of unused JS for pre-campaign mixins with the choices data [23:21:48] AndyRussG: I wouldn't want to mess with your larger ouvre ;) happy to provide feedback any time, though! [23:22:25] I'm not sure if we shoud have some caching mechanism like is used for RL modules on local storage [23:23:20] I guess... I'm imagining that campaign mixins are written as a ResourceLoader js module that defines the logic, then we call into that with a one-liner if the campaign's banner comes up for display. That way we can reuse across campaigns and banners. [23:23:23] Another option is to try to put most of the actual per-campaign mixin code in a RL module that everyone gets (and thus often caches) [23:23:47] exactly what I was about to say! yay 'n' woot! [23:23:56] Probably makes a lot of sense to do a failover thing, too. If we decide to hide one campaign's banners, then the second choice is eligible, during that same impression cycle. [23:24:13] whoa. yeah jinx [23:24:24] me debes un chocolate [23:24:29] rats [23:25:16] K cool that we're on the same candied wavelength actually [23:26:14] WRT opening allocation space if a banner is hidden.... Hmm that sounds reasonable though it'll definietly be a change in allocation logic and maybe nix some of the allocative predicatability currently inbuilt in the system [23:26:30] riiight [23:27:00] that can definitely come in a later phase [23:30:34] awight: for example, right now there are two competing campaigns throttled at 20% [23:31:51] As it stands, each campaign owner is guaranteed that 20% of all targetees will be assigned their campaign and will have their campaign's show/hide logic run [23:32:17] If we set it up as you say, then the actual allocation chunk of each depends on how much the other is hiding [23:32:40] (CR) Ejegg: [C: 2] "Very nice! Looks ready for deployment and trial by fire." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [23:33:00] (Merged) jenkins-bot: Move remaining controller logic into GatewayAdapter::doPayment() [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/189153 (https://phabricator.wikimedia.org/T86251) (owner: Awight) [23:33:03] (Merged) jenkins-bot: Add Monolog handlers and processors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192385 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [23:33:07] I see the problem... the one sort of big mitigating factor however, is that we would only be increasing allocation for campaigns which are currently hidden behind others. [23:33:15] (Merged) jenkins-bot: Use PSR logging in DonationData [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192393 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [23:33:20] Yea true [23:33:22] (Merged) jenkins-bot: Use PSR logging for gateway extras [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/192977 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [23:33:24] (CR) jenkins-bot: [V: -1] Use PSR logging in gateway adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193272 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [23:33:26] (CR) jenkins-bot: [V: -1] Use PSR logging in GatewayPage classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193280 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [23:33:33] Probably wouldn't lead to a JS allocation war ;) [23:33:38] The issue might be, double jepoardy for the reader. [23:33:52] it might become very likely to see a banner... [23:34:06] But yeah, we can cross that bridge later, I think! [23:34:31] Yeah it's like, hey reader who clicked on the close button, you aren't getting out of it so quick [23:34:51] We have to build in a bit more mercy, eh? [23:35:20] if there are 100 different campaigns, the poor reader shouldn't have to click all 100 close boxes, then *surprise*, have them all reappear in a week. [23:35:56] Yeah worst case scenario [23:36:13] I guess it also would depend on the reason for the hiding, which can vary [23:36:32] MMmm BTW another thing that I'm derping on because of not knowing anything about it is grunt karma qunit interaction [23:37:17] oh dear [23:37:20] karma? [23:38:10] is karma a qunit dependency? [23:38:32] I know I was able to run qunit from the CLI and stuff... Are you hitting a problem? [23:38:41] no idea, it's a test runner I think [23:38:42] http://karma-runner.github.io/0.12/index.html [23:38:54] awight: ah yea that's what we want to do... Yeah how is that done? [23:39:10] https://integration.wikimedia.org/ci/job/oojs-core-npm/434/console [23:39:31] https://github.com/wikimedia/integration-config/blob/effb34e5ce56a7ce24ff33a92252b388f30883a4/jjb/mediawiki-extensions.yaml#L150 [23:40:03] (PS4) Ejegg: Use PSR logging in GatewayPage classes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193280 (https://phabricator.wikimedia.org/T86266) [23:40:05] (PS5) Ejegg: Use PSR logging in gateway adapters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/193272 (https://phabricator.wikimedia.org/T86266) [23:40:40] lessee... https://integration.wikimedia.org/ci/job/mwext-CentralNotice-qunit/560/consoleFull ... [23:41:07] oh nvm [23:41:35] AndyRussG: actually, take a look in there, I'm seeing failure but it returns success. [23:42:17] "Warning: No route to fetch banner choice data configured. [Called from CNBannerChoiceDataResourceLoaderModule::getChoices in /mnt/jenkins-workspace/workspace/mwext-CentralNotice-qunit/src/extensions/CentralNotice/includes/CNBannerChoiceDataResourceLoaderModule.php at line 57] in /mnt/jenkins-workspace/workspace/mwext-CentralNotice-qunit/src/includes/debug/MWDebug.php on line 300" [23:42:21] oof. it's been that way for a while. [23:42:27] I know this used to work... [23:42:28] awight: mind taking another whack at those two? Had to manually rebase around some of those unused code deletions [23:43:54] ejegg: oh, sure! [23:44:00] thanks! [23:44:14] AndyRussG: argh, older qunit console output has been purged. [23:45:12] awight: looks like it's just the choices data dependency of the module being tested, no? though not needed for the tests themselves [23:46:24] AndyRussG: well, it used to run all the tests, so something's broken... [23:46:43] AH sorry [23:46:47] 18:15:42 >> 1532 assertions passed (19628ms) [23:46:53] they are running. [23:47:17] Hmm, the formatting has changed, I think it used to dump a full list of the tests? [23:47:27] awight: well now I'm not sure... There are tests running, to be sure, but I are the CN tests? Could be other MW tests? [23:47:36] Maybe it dies on our tests? [23:47:51] Yeah that's unfortunate that we can't confirm. [23:48:06] I guess you could push a test patch that throws an assertion. [23:48:29] Hmmm [23:48:30] So, these used to run via some grunt CLI helper, AFAIR, and now it's a curl call. [23:48:59] I seem to recall having been here before re: funky qunit Jenkins [23:49:26] re: grunt, my understanding is that's what we're now supposed to do, grunt npm karma or something, like oojs does [23:49:30] It's actually really annoying, cos it's a series of curl's [23:49:32] and that'll get us on the train [23:49:37] mmm ok [23:49:50] I mean, the train to running qunit on real browsers [23:49:53] via SauceLabs [23:51:00] fwiw, https://github.com/wikimedia/integration-config/blob/master/jjb/macro.yaml [23:51:17] line 285 and... [23:51:39] and the next few definitions. [23:51:56] looks like qunit is executed by "grunt karma:main" [23:52:16] K4-713: ^ the death of language [23:52:31] #langdeth [23:52:47] lol [23:52:49] *those were words*... you maniacs, you blew it up... [23:57:27] awight: interesting [23:57:32] they're still words! [23:57:46] it makes programming much more fun [23:57:55] better than saying a b:c [23:58:34] or sprg nrmw:pllbbb [23:59:12] blargh, I got this far: npm install grunt karma grunt-karma ; node node_modules/grunt/lib/grunt.js karma:main [23:59:16] though indeed it's sad that the karma of the world must now be computerly grunted at every time we commit [23:59:18] nothing happens. [23:59:19] code