[00:00:22] AndyRussG: I think https://gerrit.wikimedia.org/r/#/c/181244 stands on its own merits [00:00:39] awight: yes! [00:00:42] The banner diet mixin however, I was expecting us to abandon, once we had a plan [00:02:24] AndyRussG: I wholeheartedly second your judgement wrt not migrating twice [00:02:44] I think we need a migration plan for the current thing [00:03:22] I definitely don't think the BannerDiet mixin as I wrote it has any business being deployed, cos we'll have to debug functionality and parameters... [00:04:53] The migration to campaign mixin diet (<_< >_> sounds like slimfast marketing) might be both simple and complicated. [00:05:18] I'm pretty sure there are gonna be complications [00:05:28] But that we'll come out much cleaner in the wash in the end [00:06:02] (Abandoned) Awight: Provide BannerShowHideCountDate as a mixin [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181239 (owner: Awight) [00:06:20] One complication, for example, will choosing a campaign rather than a banner! [00:06:26] AndyRussG: btw :) if it makes you feel any less guilty, https://gerrit.wikimedia.org/r/#/q/owner:self+status:abandoned,n,z [00:06:43] yes! and where the parameters go. [00:07:27] That actually is an interesting issue. We might end being able to make some progress on generalizing A/B testing if parameters are cascaded down from campaign to banner [00:08:32] awight: oooh! that'd also be a fun change to move on one day :) [00:08:51] (PS3) Ssmith: Fix time display, remove refresh and profile btns [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195996 [00:08:56] well... how were you planning to set the campaign-level diet variables? [00:09:17] uh... a web interface? [00:09:32] (CR) jenkins-bot: [V: -1] Fix time display, remove refresh and profile btns [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195996 (owner: Ssmith) [00:09:56] awight: oh you mean where to store 'em, I guess? [00:10:35] hmmm yeah another complication! [00:11:48] set and store, yeah [00:12:22] It could be part of the mixin UI (another complication!) [00:12:29] but probably better if it's more general [00:12:42] Hmmmm [00:13:26] could the current banner-mixin-UI be transported to campaign pages? [00:14:15] sure, but that doesn't have a param thing [00:15:24] hmmm [00:15:52] yeah... if we're gonna have both campaign and banner mixins, it'd be nice if they share UI qualities [00:16:08] Oooh! bassoons are chiming in the south wind! gotta run for a bit :) [00:19:05] O_O [00:19:23] ? [00:25:25] (CR) Ejegg: "'Year' labels still don't match the data we're getting for year. We get data for all time, grouped by year." (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195996 (owner: Ssmith) [00:37:02] (PS4) Ssmith: Fix time display, remove refresh and profile btns [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195996 [00:37:35] (CR) jenkins-bot: [V: -1] Fix time display, remove refresh and profile btns [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195996 (owner: Ssmith) [00:42:49] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Spike: do cancelled paypal subscriptions appear in civi? - https://phabricator.wikimedia.org/T92326#1111753 (awight) Fwiw: select * from civicrm_contribution_recur where contribution_status_id=3 and trxn_id like 'S-%' order by cancel_date desc; [00:45:06] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: See if we can log acquirer authorization information - https://phabricator.wikimedia.org/T92467#1111754 (awight) NEW [00:45:17] (PS5) Ssmith: Fix time display, remove refresh and profile btns [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195996 [00:56:11] (PS2) Ejegg: Fix x axis labels [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/196010 [00:58:52] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Spike: do cancelled paypal subscriptions appear in civi? - https://phabricator.wikimedia.org/T92326#1111811 (CCogdill_WMF) Adam and I talked and apparently only in edge-cases do PP cancelations not get to Civi. Donor Services did not know this! DS is g... [00:59:16] (CR) Ejegg: [C: 2] "Looks good!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195996 (owner: Ssmith) [01:13:58] hasta luego [01:29:59] (PS3) Ejegg: Fix board nav links [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195979 [01:30:01] (PS3) Ejegg: Fix x axis labels [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/196010 [02:53:25] (CR) AndyRussG: [C: 2] "Woohoo! \o/" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 (https://phabricator.wikimedia.org/T86100) (owner: Awight) [02:55:42] (Merged) jenkins-bot: Preload JS comes with no baggage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181244 (https://phabricator.wikimedia.org/T86100) (owner: Awight) [03:02:41] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 3 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1111963 (AndyRussG) Update: - All but one of the patches mentioned in this task have merged.... [17:02:13] (PS1) Awight: Merge commit '45232cf12fb6644750407925127c724572e3391a' (master) into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196259 [17:02:16] (PS1) Awight: Skip merging commit 'e2ee297dbcf3b399e2f2a3a92dbfcd938fc09b73' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196260 [17:02:17] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196261 [17:02:35] (CR) Awight: [C: 2] Merge commit '45232cf12fb6644750407925127c724572e3391a' (master) into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196259 (owner: Awight) [17:02:42] (CR) Awight: [C: 2] Skip merging commit 'e2ee297dbcf3b399e2f2a3a92dbfcd938fc09b73' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196260 (owner: Awight) [17:02:48] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196261 (owner: Awight) [17:03:03] (Merged) jenkins-bot: Merge commit '45232cf12fb6644750407925127c724572e3391a' (master) into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196259 (owner: Awight) [17:03:05] (Merged) jenkins-bot: Skip merging commit 'e2ee297dbcf3b399e2f2a3a92dbfcd938fc09b73' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196260 (owner: Awight) [17:03:24] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196261 (owner: Awight) [17:04:46] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196263 [17:05:10] (Abandoned) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196263 (owner: Awight) [17:05:41] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196264 [17:05:51] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196264 (owner: Awight) [17:05:57] (CR) Awight: [V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196264 (owner: Awight) [17:07:59] Jeff_Green: just checking whether you're around... I'm about to do a deployment, and I might run into git submodule glitches in payments.wmo [17:11:58] Jeff_Green: yep, I have issues. [17:12:11] ok [17:12:14] hi! [17:12:18] hey [17:12:34] Wikimedia-Fundraising, Fundraising-Backlog: Add LATAM forms to DonationInterfaceFormSettings.php - https://phabricator.wikimedia.org/T90505#1113607 (atgo) do we need help with design at all on this? We could get Trilogy to mock up some forms if helpful. [17:12:44] (CR) Krinkle: QUnit: avoid PHP error by using fallback API URL for banner choices (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/195200 (https://phabricator.wikimedia.org/T91763) (owner: AndyRussG) [17:30:37] ccogdill: the-wub: K4-713: atgo: here goes nothing! [17:31:00] * ccogdill buckles up [17:31:01] We already had that. [17:31:05] :D [17:31:06] !log update payments from cbaf66e7705789f37117ec6edc4d936c6174d511 to bfa2d27cd9715f7d151c9e1600987fab0d5165e3 [17:31:09] done. [17:31:11] Logged the message, Master [17:31:32] Oh dear. [17:31:40] wat [17:31:47] look at payments-initial [17:31:48] That I wasn't logged in [17:31:54] what [17:32:02] I think those are "NO" kronor [17:32:10] oh dear [17:32:46] K4-713: I think it's just paypal [17:32:56] and surprisingly, just a logging thing. Survivable until fixed? [17:33:01] There's a GC there, too. [17:33:04] what's the concern? [17:33:17] okay that's not healthy, either. [17:33:35] The logs are... different. [17:33:50] In a way that will definitely blow up the nightly audit script. [17:34:01] ok, rolling back then... [17:34:10] the IOWP looks... similar :) [17:34:18] :p [17:34:36] So, the log prefix really, really changed. [17:35:26] !log payments rolled back from bfa2d27cd9715f7d151c9e1600987fab0d5165e3 to cbaf66e7705789f37117ec6edc4d936c6174d511 [17:35:29] And now it's back. [17:35:34] Logged the message, Master [17:35:43] ccogdill: It's worth still watching for glitches, but we switched back to the old version of the code. [17:35:59] the-wub: ^ [17:36:09] That was not what I expected to blow up... [17:36:15] I guess it never it [17:36:16] is [17:36:21] Nope! [17:36:33] But, hey: Only one error message. [17:36:48] That error message does look pretty special, though. [17:37:01] Hum. [17:37:11] hehe [17:37:24] that might have actually happened... [17:37:31] Well, yes. [17:37:34] I mean, probably. [17:37:35] creepy actually, that's the referrer [17:37:53] Even Cyrillic doesn't look as mangled as that [17:38:17] Any chance we did something partially insane with escaping in the deploy? [17:38:41] Checking contribution tracking [17:39:52] It's... in there the same way. [17:40:19] thanks for the heads up! let me know if we retry at some point [17:40:23] It's possible. ejegg|away was very careful to not fix any of the crazy log messages or print_r statements though :) [17:40:29] ccogdill: will do [17:41:18] K4-713: but yeah, I can imagine the new logging library did something fun. Also, my MVC muck could be mangling a redirect. [17:41:23] It was just that one, though... [17:41:57] I'm checking for more in the contribution_tracking table. [17:42:02] thx [17:42:14] Got ten. [17:42:18] OH [17:42:20] . [17:42:37] Two today. [17:42:43] <_< [17:42:50] What a roller coaster [17:42:51] ? [17:42:58] ejegg: Hey! [17:43:02] back in my apartment! [17:43:07] Nice. :) [17:43:15] so, looks like I missed some fun [17:43:20] * ejegg reads backscroll [17:43:23] awight: Actually, I should say ten this calendar year. [17:43:31] ejegg: check /var/log/remote... [17:43:43] K4-713: ok yes that makes me feel well grounded [17:43:49] It does? [17:44:02] well. More so than, ten in the last 60 seconds. [17:44:02] ...oh. Weird. [17:44:11] They were all from either nowhere, or Ways to Give. [17:44:22] .js we can hope [17:45:16] Well, fredge didn't blow up. [17:45:18] That's good. [17:46:11] K4-713: think I should go relax the WR1 regexes? [17:46:18] ugh [17:46:27] In wr1, I'm not sure they're regexes. [17:46:38] And: No. [17:46:43] I'd just... leave it there. [17:47:00] ok, I'm not doing too much tomorrow morning :p [17:47:31] I'll eyeball the thing and see if it will just cruise over the lines, or if it will actually embarrass itself. [17:56:24] go ejegg! [17:56:41] thanks atgo! [17:58:01] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 2 others: Update GC audit to read WX file - https://phabricator.wikimedia.org/T86090#1113834 (atgo) [18:18:08] hi awight! [18:18:15] per https://phabricator.wikimedia.org/T92526, do you have time to teach me this today? :) [18:18:23] ccogdill: sure! [18:18:39] Let me see if I can add you to Jenkins. <-- K4-713 that's fine, eh? [18:18:57] hum. [18:19:03] Thinking... [18:19:30] Grumblegrumble. [18:19:33] So, here's the thing. [18:19:43] ccogdill: Be really, really careful in there. [18:19:49] :) [18:19:52] … okay :D [18:20:08] I’ll only ever do this one thing, I promise! [18:20:16] K4-713: btw, there's this thing they use for CI. It's horrible, but better than what we have. "jenkins job builder" [18:20:18] (PS1) Ejegg: Fix syslog formatting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196287 [18:20:19] ccogdill: Also, if you're going to start doing weird things with jobs, please be on IRC. [18:20:26] That would let us put the jobs into source control. [18:20:35] I’m always on at work! [18:20:40] awight, K4-713 ^^ that oughtta fix the log format [18:20:47] ejegg: Neat! [18:20:59] ejegg: ok, testing locally... [18:21:12] oh, not sure about the escaping though [18:21:21] ejegg: I think that was something else [18:21:29] it's been around... [18:21:42] just referrers, not all unicode? [18:22:02] ejegg: do you see something? [18:22:34] no, just looking around trying to find some good unicode [18:22:40] hehe [18:23:09] oughtta be some umlauts around with that scandinavian testing [18:25:59] ok, found a good-looking angstrom in the logs from the recent deploy. So it is just the same old referrer escaping issues [18:28:41] ejegg: Keeping the checkin now, or are you in the middle of everything? [18:29:07] sure, checkin now is good! [18:29:16] okay. I'll head that way. [18:34:12] (CR) Ssmith: [C: 2] Fix board nav links [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/195979 (owner: Ejegg) [18:41:26] Wikimedia-Fundraising, Fundraising Tech Backlog: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1114046 (awight) NEW [18:41:34] Jeff_Green: fyi ^ [18:43:09] (CR) Awight: [C: 2] "You did it!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196287 (owner: Ejegg) [18:43:35] (Merged) jenkins-bot: Fix syslog formatting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196287 (owner: Ejegg) [18:45:04] ccogdill: the-wub: K4-713: atgo: you up for a second shot? [18:45:19] sure! [18:45:23] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196293 [18:45:33] sure awight, I'm ready when you are [18:45:53] awesome, thx [18:45:59] < 5 min [18:46:13] (CR) Awight: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196293 (owner: Awight) [18:46:36] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196294 [18:46:44] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196294 (owner: Awight) [18:47:08] ejegg: heads-up, I'm deploying the patchballs again [18:49:02] !log updating payments from cbaf66e7705789f37117ec6edc4d936c6174d511 to a6c451c89620f531c590ddc6d954ac2b808da3df [18:49:09] Logged the message, Master [18:49:13] ccogdill: the-wub K4-713 ejegg: deployed! [18:49:27] ejegg: logs look perfect [18:49:37] Woooo! [18:49:40] oh, awesome! [18:49:42] cool [18:50:13] coming back to tail some logs. [18:53:21] I'm seeing a few cc and paypal donations in ecom since the deployment, so that's good :) [18:54:09] woooooooo [18:54:13] Wikimedia-Fundraising, Fundraising Tech Backlog, Fundraising-Backlog: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1114120 (atgo) [18:55:18] ^^^silverpop export still broken? aargh! [18:56:43] I just saw a line go by without the prefix in the gc log. [18:56:48] ...not a blocker for anything. [18:56:51] Just sort of odd. [18:56:52] I think. [18:57:01] no prefix at all? [18:57:04] lemme see [18:57:14] Makes sense, though: It's telling me it's constructing the object. [18:57:22] ....nothing to use in the prefix yet. [18:57:31] oh yeah [18:57:41] It's not going to choke anything, so that's okay. [18:57:54] I think that was the same before.. checking [18:58:06] We might want to take that one out eventually, though, because it's not really telling us anything useful. [18:58:15] Log bloat. [18:58:28] (CR) Ssmith: [C: 2] Fix x axis labels [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/196010 (owner: Ejegg) [18:58:47] Oh, actually? It's stuttering. [18:58:58] (Merged) jenkins-bot: Fix x axis labels [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/196010 (owner: Ejegg) [18:58:59] The very next line is the same message after it gets the prefix all sorted out. [18:59:00] hmm, maybe it wasn't that way. [18:59:38] ejegg: If this is the only thing I'm finding to pick on, you won already. [18:59:49] yay! [18:59:56] K4-713: hey, what line are u looking at? [19:00:09] awight: grep Constructing! [19:00:16] lol [19:00:24] which file? [19:00:33] awight: They all look like "Constructing!Getting metadata for payment submethod: visa" [19:00:37] payments-globalcollect [19:01:07] paypal's got some too [19:01:07] hah k thx [19:01:10] And, yeah: The very next line is the same with the fully-formed prefix. [19:01:18] Every one I'm seeing, anyway. [19:01:28] ooh, paypal had them pre-deploy [19:01:34] hmm, there are a lot of duplicated lines [19:01:39] yep [19:01:51] could actually be happening, though [19:01:59] Oh, I'm sure it is. [19:02:07] that "Getting metadata for payment method" happens every time we normalize :-/ [19:02:23] yeah, I think that's real. [19:03:19] I know "redo all normalize everything" is somewhere in our refactor wishlist. This isn't really news, I think... [19:03:28] ...but the weird thing is that... [19:03:29] Well. [19:03:38] tail -f payments-globalcollect | grep metadata [19:03:46] It's probably easier if you just look. [19:04:06] Not every group starts with Constructing!. [19:05:16] Somebody should squint at this for a while. [19:05:18] I think that's still a real thing [19:05:33] the rtbt involves extra calls, and there are... 3 normalization calls per API call [19:05:46] This is all cc. [19:06:21] And, ah... not in groups of multiples of three, either. [19:06:33] This predates the deployment, though [19:06:36] yep [19:06:51] what exactly looks bad? [19:07:34] I was being picky about the whole line if it never came in with a prefix. [19:07:40] Clearly it does. [19:07:46] Then we all started frowning at it. [19:08:17] Did atgo bail on us? [19:08:33] :) yeah that's creepy that it only sometimes skips the "Constructing!" prefix [19:08:38] K4-713: yeah atgo went to the farmer's market [19:08:46] I was going to go to that. [19:08:48] Oh well. [19:09:11] Ah, I suspect it's session stuff / returning from iframeland. [19:09:14] For some of this. [19:09:58] Or reloading. [19:10:24] Should I make up some more stuff? [19:10:44] I can do this all day. [19:11:05] probably happening from DonationData->setUtmSource [19:11:28] That's definitely a contender. [19:11:32] It's just so irregular. [19:11:44] K4-713: she just left 10 min ago! U can leave me with my mess [19:12:01] There will be plenty left when you get back [19:12:20] awight: Can I grab you a Food? [19:12:36] K4-713: I'm meeting an old friend. Actually, that might take a bit longer than usual... :) [19:12:48] When are you leaving? [19:12:51] 12:30 [19:12:55] eep. [19:12:56] -:45 [19:13:05] okay [19:13:10] I'll... [19:13:12] monitoring gap :) [19:14:47] so, setUtmSource doesn't call the thing that gets submethod meta unless DonationData already has a payment_method. Which might indeed be the return from iframeland? [19:16:36] Glad to know people still return from there :) [19:16:45] yep! [19:16:56] * awight puts a dollar in the jukebox to play [19:17:16] * ejegg wishes he had a bpay account [19:18:14] lastlog pizzza [19:18:22] bah [19:18:30] lol that almost sounded tasty [19:18:52] the log lady's fave [19:19:24] oh wow, that looked bad [19:19:35] wait, what? [19:20:00] PHP Fatal error: Call to undefined method MWException::isCommandLine() [19:20:06] oh crap [19:20:17] oh noes, undefined method call! [19:20:53] ah dang, amazon's still got it too [19:21:46] i thought sure we scoured for all of those when we went to add(Request|Response)Data [19:22:18] I don't even remember this issue [19:22:40] aargh, merge order fail [19:23:06] i think you fixed stuff up to use addRequestData / addResponseData on one line [19:23:38] and made some *gateway.body.php fixes on another that involved addData calls [19:24:13] hrm. [19:24:26] ahh thx, this is a second thing. Yep [19:24:51] (PS1) Ejegg: Fix addData calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196307 [19:25:25] (CR) Awight: [C: 2] Fix addData calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196307 (owner: Ejegg) [19:25:46] ejegg: are you free to deploy that? I have a friend trying to lunchjack me any minute now [19:25:50] (Merged) jenkins-bot: Fix addData calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196307 (owner: Ejegg) [19:25:54] yep, can do [19:26:40] * ejegg clones a shiny new copy of DI for deployment [19:27:01] :p [19:27:23] don't tell anyone, but I've actually been going back n forth locally and it's fine [19:29:40] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196309 [19:30:12] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196309 (owner: Ejegg) [19:31:45] (PS1) Awight: Merge REL1_23 into fundraising/REL1_23 [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196311 [19:31:59] ejegg: thanks! [19:40:45] (PS1) Ejegg: Submodule bump for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196319 [19:41:13] (CR) Ejegg: [C: 2] Submodule bump for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196319 (owner: Ejegg) [19:49:19] !log updated payments from a6c451c89620f531c590ddc6d954ac2b808da3df to 673e11f54c613163e7fcf1259935ebb8f9343a73 [19:49:25] Logged the message, Master [20:05:25] ejegg: hey :) [20:14:12] hi AndyRussG [20:14:26] Hey :) I was bothering you about standup [20:14:49] Sorry to hear about your lockout! I've done that... more than once... [20:16:09] atgo: I found Ellery's e-mail... gee, I really have to clean up my mailing list spamalot situation 8p [20:23:23] K4-713: seeing potentially more Error 400120 s than usual [20:23:31] not sure if it's a rollback situation yet [20:23:49] and there's an odd thing with MWException::isCommandLine not existing [20:25:09] er... weird. [20:25:21] ejegg: I'll look at it. [20:26:27] oh crap, it's gotta be using the drupal fakey version of the class. fixing... [20:27:02] I'm not sure the 400120s are a problem. [20:27:10] Over half of them are the same person. [20:28:05] ejegg: Also... how is drupal getting anywhere near DI? [20:28:33] Or, was that somewhere else? [20:29:08] it's to support using it in crm [20:29:22] * K4-713 squints [20:29:26] I think that makes sense. [20:29:55] anything mw-specific on the recurring gc codepath has a drupal doppelganger [20:30:17] hum [20:30:29] and we're including the composer autoload for the first time here [20:30:34] ooo. [20:30:52] which says MWException is defined in MWException.drupal.php [20:31:39] Yeah... I thought we were going to eventually do that with thin shims that only existed as a drupal module / mw extension / whatever it actually is. [20:31:54] And have DI libs that everything included from there. [20:32:01] Eh. Someday. [20:32:03] that would be awesome! [20:32:36] (PS1) Ssmith: Add widget instances to user default board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/196403 [20:32:37] Yeah, I always liked that option better than the other ones. [20:32:53] But we have to rethink the whole way translation works at that point, I think. [20:37:25] AndyRussG: mailing list goign to another inbox is lepful :) [20:37:34] AndyRussG: let me know if you need anything else that i can help with [20:37:46] atgo: OK thanks! likewise :) [20:39:10] atgo: yeah I have filters that send all my fr-tech e-mails to one box, but it gets all spammed out by the cluster alerts, and for some reason my additional fitlers aren't working as I want... Planning to fix it... soooooon :) [20:39:18] ooh yeah [20:39:35] there was a lot of that lately [20:39:42] yeah [20:39:49] anyway, it's fun living on the edge 8p [20:40:29] ejegg: Yeah, 400120 isn't anything that happened today. [20:40:37] There were 39 yesterday, and 30 the day before. [20:41:59] ok, cool [20:42:36] I mean, there should still be a card... but there may already be one. [20:44:45] (PS1) Ejegg: Only override MWException if not in mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196413 [20:45:07] ejegg: You need CR there? [20:45:15] K4-713: yes please! [20:45:43] rar [20:46:12] (CR) Katie Horn: [C: 2] Only override MWException if not in mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196413 (owner: Ejegg) [20:46:20] yah, autoloader fallback totally works here [20:46:20] That was easy. [20:46:46] (Merged) jenkins-bot: Only override MWException if not in mediawiki [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/196413 (owner: Ejegg) [20:49:33] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196416 [20:50:07] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/196416 (owner: Ejegg) [20:50:21] ejegg: So... why aren't we getting that error more frequently? [20:50:44] the MWException one? [20:50:50] yeah [20:51:02] It only happens in MWExceptionHandler::report [20:51:11] so when we don't catch it [20:51:42] guess we're catching most of 'em, and not asking them anything mwexception-specific [20:52:57] ejegg: This patch should be enlightening, then. [20:53:04] yep :P [20:53:44] (PS1) Ejegg: Submodule bump for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196419 [20:54:09] (CR) Ejegg: [C: 2 V: 2] Submodule bump for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/196419 (owner: Ejegg) [20:55:27] (PS5) AndyRussG: QUnit: avoid PHP error by using fallback API URL for banner choices [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/195200 (https://phabricator.wikimedia.org/T91763) [20:56:00] !log updated payments from 673e11f54c613163e7fcf1259935ebb8f9343a73 to 2c5e99cb6de54a6a4e6e2334d533e8ef36c2090c [20:56:07] Logged the message, Master [20:57:20] * K4-713 waits patiently for error [20:58:45] ...blarg? [20:58:54] that was me [20:58:58] I guessed. [20:59:02] :D [21:00:59] aww, the friendlier message for zero amounts regressed at some point [21:01:19] We were friendly? [21:01:29] Oh wait. FriendliER. [21:01:31] and now we're accusing people of making errors when they follow the paypal donation links [21:01:48] from ways to give [21:01:56] uff [21:02:26] I never did like how that... didn't ever really work. [21:02:33] i think we changed it from 'please correct the errors in your donation amount' to 'please enter a donation amount' [21:02:42] Did we [21:02:42] (PS6) AndyRussG: QUnit: avoid PHP error by using fallback API URL for banner choices [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/195200 (https://phabricator.wikimedia.org/T91763) [21:03:27] K4-713: yeah, it was e07ce53892066aa70e53d286ff25ebc1feaf3207 [21:04:37] one of my first DI commits! [21:04:38] The thing is... I don't know if most payments forms have an amount field. [21:04:53] So, that may be friendlier, but... possibly impossible. [21:05:05] sadness [21:05:19] Amount is one of those fields that's supposed to be filled in before you get to payments. [21:05:31] Like... payment method and currency code. [21:07:44] ejegg: Although, I think paypal and amazon might be exceptions. [21:08:13] They *only* show a form if there's something up with the amount/currency fields. [21:08:29] yeah [21:08:34] Like, if we are about to rail you to USD because Reasons. [21:09:33] Well, this is silly. [21:09:46] Everything got totally quiet there. [21:10:42] guess it is kinda late in the countries with campaigns [21:11:08] The only thing that's hit the error log since your deploy, was the fakey form request you did. [21:11:10] ejegg: why is the MWException.drupal.php file getting loaded at all? Is that the composer classmap autoload? I worry a bit about your fix, cos "composer dumpautoload" won't define MEDIAWIKI... [21:11:48] awight: yep, totally the composer classmap [21:12:00] K4-713: I'm not sure this is what you were imagining, but is it close? http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDonationInterface.git/ff4816a0cb78fdd002d47e02f1105b8fa3ce7e16/gateway_common%2FWmfFramework.drupal.php http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDonationInterface.git/ff4816a0cb78fdd002d47e02f1105b8fa3ce7e16/gateway_common%2FWmfFramework.mediawiki.php [21:12:08] Like you said, yeah translation needs a better shim [21:12:18] ...what, right now? [21:12:21] Not even close. :p [21:12:26] Oh wait. Shim. [21:12:28] K4-713: um, in a year or two :) [21:12:34] why is it a bad thing that dumpautoload doesn't define MEDIAWIKI? [21:12:56] ejegg: cause then the MWException.drupal.php file won't appear the next time you regenerate autoload_classmap.php [21:13:09] ahh, dang [21:13:32] Maybe we do the class_alias hack again? [21:13:58] wait, it WILL appear, because the test is for !defined [21:14:10] oooh, thx :) [21:14:30] So, the Composer autoloader will try this file and fail, then hopefully that will failover to the next autoloader... [21:14:41] yep! [21:14:50] cool, thanks for talking me through it [21:14:51] leastwise it did on my machine [21:15:34] ccogdill: fyi, the Silverpop export completed successfully... [21:15:36] awight: To seriously answer your question: Yes, but bigger. And not in the same repo, but this is possibly far less aggravating. [21:16:02] cool, thanks awight. I will import it into Silverpop this afternoon [21:16:28] K4-713: okay, that makes sense. [21:16:36] Does it? Oh good. [21:16:53] * awight arbeits taste [21:19:36] oh poop, the continue button does nothing on the iDeal form [21:19:49] ouch. [21:20:15] ejegg we’ve seen that before… can you get it to work if you select a different bank? [21:20:21] sometimes it’s iDeal and not us [21:20:40] ccogdill: thanks, I'll try a couple! [21:20:54] mhmm! [21:22:21] ejegg: SNS bank did work [21:22:35] that's really broken though, we need to give some UI feedback [21:23:49] yeah, the rest are getting 430900 - no valid provider [21:23:53] in the backend [21:24:46] ejegg: I just confirmed that this interface problem existed in the previously deployed code... [21:24:58] I'll start a card [21:25:01] ok, whew! [21:27:49] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Give error feedback when iDeal cannot connect to bank - https://phabricator.wikimedia.org/T92567#1114921 (awight) NEW [21:31:50] § Fundraising Sprint Devo, Fundraising Tech Backlog, Fundraising Sprint Flaming Lips, Patch-For-Review: Logging should be handled outside of core gateway class - https://phabricator.wikimedia.org/T86266#1114931 (awight) Open>Resolved [21:31:57] Wikimedia-Fundraising, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 4 others: Move any remaining controller logic out of the form classes - https://phabricator.wikimedia.org/T86251#1114933 (awight) Open>Resolved [21:38:36] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Give error feedback when iDeal cannot connect to bank - https://phabricator.wikimedia.org/T92567#1114943 (atgo) @pcoombe you usually keep an eye on iDEAL maintenance, right? Any thoughts about this? [21:43:34] Wikimedia-Fundraising, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Give error feedback when iDeal cannot connect to bank - https://phabricator.wikimedia.org/T92567#1114953 (atgo) Also @ccogdill_WMF @juro2351 your thoughts? [21:46:34] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Fields that need amending on the International Check Importer - https://phabricator.wikimedia.org/T92325#1114968 (atgo) [21:49:16] (CR) AndyRussG: QUnit: avoid PHP error by using fallback API URL for banner choices (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/195200 (https://phabricator.wikimedia.org/T91763) (owner: AndyRussG) [21:52:54] (CR) AndyRussG: "Thanks! I've tweaked this some more but we're still getting a warning (though I don't get one locally, so I imagine it could be a Jenkins " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/195200 (https://phabricator.wikimedia.org/T91763) (owner: AndyRussG) [22:26:05] ccogdill: jfyi, I'm disabling WorldPay, per https://phabricator.wikimedia.org/T91445 [22:27:15] !log disabled WorldPay gateway [22:27:21] Logged the message, Master [22:27:25] k awight, thanks! was wondering when this was going to happen [22:27:30] K4-713: woot! [22:27:32] ccogdill: done [22:27:39] woohoo [22:28:23] Did we just get another point? [22:28:35] hey awight... why are we digging around in ideal? sleuthing after deploy [22:28:36] ? [22:28:45] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 3 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1115085 (awight) a:awight>None [22:30:14] atgo: yeah, I was just testing some of the exotic methods [22:30:22] cool [22:30:34] wasn't sure if we had some problems or something [22:30:53] nothing new anyway! [22:31:12] Heh. "No New Problems" would also be a great shirt. [22:31:29] (particularly if "problems" was misspelled) [22:31:44] hehe [22:32:05] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 3 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1115098 (atgo) I thought we were done/abandoning this one? [22:32:22] :P [22:34:47] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 3 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1115122 (awight) We're doing this a different way. It remains to be decided if we're creati... [22:41:49] (CR) Awight: "@AndyRussG: I think deprecating "server choice" mode will help simplify things here." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/195200 (https://phabricator.wikimedia.org/T91763) (owner: AndyRussG) [22:46:56] hey AndyRussG|bassoo [22:47:31] and awight [22:47:36] yessir [22:47:39] what is happening with the banne rmixinx? [22:47:41] wow. [22:47:44] lol [22:47:46] banner. mixins. [22:47:47] https://phabricator.wikimedia.org/T86100 [22:47:51] I thought we banished Bane [22:49:19] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 2 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1115183 (atgo) [22:49:52] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint the Cure, Fundraising Tech Backlog, and 2 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1115186 (awight) [22:50:48] K4-713: oh hey, we can fill in section 1b (Qualified Security Assessor Company) this year with our contractor's info, right? [22:51:15] Ah, maybe? [22:51:24] Probably. [22:51:30] I'll get confirmation. [22:51:34] thanks! [23:29:22] Wikimedia-Fundraising-CiviCRM, Fundraising Tech Backlog, Fundraising-Backlog: Create a general Civi import function to reduce time for hand keying donations in Civi - https://phabricator.wikimedia.org/T88836#1115279 (atgo) [23:30:32] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Automation of existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115300 (atgo) @caitvirtue what do you mean by "automate" here? I think we will always have some amount of manual work, though I'd obvious... [23:30:48] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Automation of existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115301 (atgo) I realize that I wrote this task, but I think at your behest :) [23:33:10] hey K4-713 praveena swung by looking for you [23:33:40] I'm in a meeting atm... [23:33:44] out at 5. [23:34:15] sure, she just asked that i let you know [23:38:58] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Automation of existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115323 (awight) @atgo I think the plan was that we need to have a bulk import (spreadsheet) method for as much as possible, cos that's so... [23:39:14] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Bulk import for existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115324 (awight) [23:40:06] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Bulk import for existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115327 (atgo) @awight think we can merge with T88836? [23:43:54] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Bulk import for existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115341 (awight) I'm not sure that's right. How about for now I link T88836 that as a blocking task? The other card is more about a sp... [23:44:08] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Bulk import for existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115342 (awight) [23:44:09] Wikimedia-Fundraising-CiviCRM, Fundraising Tech Backlog, Fundraising-Backlog: Create a general Civi import function to reduce time for hand keying donations in Civi - https://phabricator.wikimedia.org/T88836#1115343 (awight) [23:47:38] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Epic: Bulk import for existing and future payment methods into CiviCRM - https://phabricator.wikimedia.org/T90242#1115351 (CaitVirtue) Yes, that's it exactly. Thanks! Caitlin Virtue Development Director Wikimedia Foundation [23:53:24] ok. brain is melting [23:53:26] ciao [23:53:28] amigos