[16:59:11] AndyRussG: hey, can you point me to something that explains qunit-karma? I want to shout "woohoo" that your job is running, but I don't understand what it does. It will eventually qunit on a variety of platforms? [16:59:56] That's what I understood Krinkle is aiming for :) [17:00:51] sounds good :) Did you notice that qunit uses the fallback skin, btw? [17:01:51] I did see that happening in our test, yeah... Not sure if that's intended [17:02:10] I'm trying to remember if I saw any doc for that... There must have been some.. rrrgg [17:02:20] It's a little funky. We have to workaround by adding the sitenotice div. [17:02:44] Just thought I'd mention it, cos that makes the environment different than running locally from the browser. [17:03:17] Hum! yeah interesting [17:04:01] I think karma runs it on real browsers but not from normal special page [17:05:08] Pretty sure I got some install tips here: http://gruntjs.com/getting-started [17:05:40] I should go back thru IRC history and make some notes... bash history has a way of disappearing... [17:06:01] (CR) Ejegg: [C: 2] "Looks reasonable. Do these issues explain the weird import?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198085 (owner: Awight) [17:06:27] awight: sadly our sauce iphone borked, no idea why: https://integration.wikimedia.org/ci/view/BrowserTests/view/CentralNotice/job/browsertests-CentralNotice-en.m.wikipedia.beta.wmflabs.org-os_x_10.10-iphone-sauce/ [17:07:53] (CR) Ejegg: [C: 2] Test that we are skipping the PP interstitial [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/197973 (https://phabricator.wikimedia.org/T92705) (owner: Awight) [17:08:21] (Merged) jenkins-bot: Test that we are skipping the PP interstitial [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/197973 (https://phabricator.wikimedia.org/T92705) (owner: Awight) [17:08:26] (CR) Awight: "No, the explanation is much more amusing: T92463 There are two pairs of duplicated column headers, which totally brainmelt the PHP CSV li" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198085 (owner: Awight) [17:09:21] AndyRussG: I don't think that's us, unless maybe we're pointing at a bad URL... "Net::ReadTimeout" [17:09:45] Ah, could be... "404 Resource Not Found" [17:09:51] Well that's exciting [17:09:58] Well the URL should be fine [17:09:59] :) [17:11:10] zfilipin has finished his workday because spherical earth, so we'll have to wait 'till Monday I think [17:15:00] howdy pizzzacat [17:15:51] This one's fun: https://gerrit.wikimedia.org/r/198148 Should let us include multiple copies of the same widget on one board [17:16:48] oh ok I'll check it out.. let's see if we had the same idea [17:17:08] just sat down, can't wait to wrap this last bit up and deploy today! [17:18:05] WOOOO [17:18:13] * K4-713 coughs [17:20:17] (CR) Ejegg: [C: 2] "less unit-y, but I like it!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/197974 (owner: Awight) [17:20:49] (Merged) jenkins-bot: Zoom out PayPal integration tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/197974 (owner: Awight) [17:20:49] K4-713 is invisible today [17:21:27] I've been phased. [17:21:35] Need tachyons. [17:21:54] My Nerd, though, is fully visible. [17:22:05] half an inch off the plane in the 4th dimension [17:22:10] (PS1) Ssmith: Remove widgets from boards [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198255 [17:23:00] (CR) jenkins-bot: [V: -1] Remove widgets from boards [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198255 (owner: Ssmith) [17:23:40] (CR) Ejegg: "pls remove bower_modules rollback" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198255 (owner: Ssmith) [17:24:16] (PS2) Ssmith: Remove widgets from boards [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198255 [17:29:20] anyone know the easiest way to un-commit an accidentally committed file? [17:29:29] *directory [17:29:44] I can't remember the simple way [17:30:20] (CR) Ejegg: [C: -1] "placement and modal look good. please remove alert, console.log and bower_modules rollback. Would be nice to remove the component or rel" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198255 (owner: Ssmith) [17:31:04] pizzzacat: for that one, you can just add the right version of bower_modules and amend [17:31:05] nevermind, have to do other stuff anyway [17:31:09] yeah [17:31:18] I didn't know if I'd need to make other changes [17:31:25] so that makes it more obvious [17:31:35] so go into bower_modules, check out 132339455dc0bf26fe7599f2bb57c70800f92b9f, and git add it to amend [17:32:24] ejegg what was the alert you're referring to? [17:32:53] thanks, will do re:bower modules [17:32:58] the ajax success callback [17:35:36] ohh ejegg I can just remove the entire success property [17:35:55] yeah, or use it to reload the board [17:36:07] oh how are we doing that? [17:36:39] you could use the same code as when we load it the first time. Think i did that on add too [17:37:39] is it ok to just assume it's the default board? [17:37:55] umm, probably not [17:38:11] right now we're only doing this with default board [17:38:14] from the library [17:38:25] like, adding, I mean [17:38:26] we don't save the board id anyplace in app content, huh? [17:38:34] we do I believe [17:38:55] oh, should the X buttons not appear in the shared board? [17:39:11] oh maybe not, I think that was in a different thing I was working on but didn't submit [17:39:19] ok, can be another patch [17:39:39] x buttons not appear in shared board? [17:39:44] yeah [17:39:47] what do you mean? [17:39:57] oh [17:40:01] shared with others [17:40:07] yeah, we can take X buttons out of boards you can't edit in another patch [17:40:08] not shared context [17:40:27] ah ok [17:40:45] so but for the immediate patch, what should I do for reloading? [17:40:59] because the way we have it now is assuming the user's default board for adding [17:41:18] ooh, just noticed you're assuming the default board for deleting too [17:41:23] yes [17:41:29] let's make the delete use the current board id [17:41:31] since we did so for adding [17:41:41] ok [17:43:05] then redo the get board/id + set self.displayedBoard [17:46:23] hmm, would be nicest if the board's widgets were an observable array we could just push to and remove from. but again, we can fix that later [17:52:06] (PS2) Awight: Set up rules for hand-keyed contributions made by Engage staff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198157 (https://phabricator.wikimedia.org/T91667) [17:53:01] (PS3) Awight: Set up rules for hand-keyed contributions made by Engage staff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198157 (https://phabricator.wikimedia.org/T91667) [17:53:41] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Grandmaster Flash: Turn Reminders on in production - https://phabricator.wikimedia.org/T92012#1135941 (awight) a:awight [17:56:21] ejegg when I try to reload the board I get an error that debugger is shedding no light on for me [17:56:44] what's your code look like? [17:57:30] I tried chatting to you but it's saying you're not logged in...weird [17:57:51] weird, lemme reload my gmail tab [17:58:06] not in gmail [17:58:12] (PS1) Ejegg: Fix widget loader tracking on board switch [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198265 [17:58:12] in IRC, which is weirder [17:58:19] huh, ok [17:58:19] um sorry, I have a meeting now [17:58:23] ok [17:58:30] will push what I have so you can see.. [17:59:26] (PS3) Ssmith: Remove widgets from boards [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198255 [18:09:55] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Grandmaster Flash: Turn Reminders on in production - https://phabricator.wikimedia.org/T92012#1136024 (awight) So, reminders are turned on and ready to go, but now we have to decide which activities will cause a reminder to go out. @RLewis: Did you get re... [18:10:08] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Grandmaster Flash: Turn Reminders on in production - https://phabricator.wikimedia.org/T92012#1101502 (awight) [18:12:56] Wikimedia-Fundraising-CiviCRM: Create Civi reminders for specific activity types - https://phabricator.wikimedia.org/T93390#1136045 (awight) NEW [18:13:01] Wikimedia-Fundraising-CiviCRM: Create Civi reminders for specific activity types - https://phabricator.wikimedia.org/T93390#1136052 (awight) [18:13:02] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Grandmaster Flash: Turn Reminders on in production - https://phabricator.wikimedia.org/T92012#1136053 (awight) [18:13:15] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint Grandmaster Flash: Turn Reminders on in production - https://phabricator.wikimedia.org/T92012#1136055 (awight) Open>Resolved [18:13:16] Wikimedia-Fundraising-CiviCRM: Create Civi reminders for specific activity types - https://phabricator.wikimedia.org/T93390#1136045 (awight) [18:23:05] (PS1) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/198267 (https://phabricator.wikimedia.org/T90913) [18:30:46] lol, does this come up blank for any of you, too? https://www.fidelity.com/insights/investing-ideas/socially-responsible-funds-make-an-impact [18:31:55] hah [18:31:57] yep [18:32:22] I'm so depressed, trying to game this 401k thing. #firstworldproblems [18:32:58] dump all your money in solar stocks! roller coasters are fun... [18:33:04] aww man [18:33:27] I don't think I can pry "all" my money out of WMF's broker's cold, dead hands [18:34:10] hmm, lemme remind myself what they're doing with mine... [18:34:20] But definitely thinking about writing an inflammatory tirade about divestment. [18:34:37] ejegg: btw, max out the matching withholding... [18:34:48] yep, got that going on [18:35:19] I discovered that even the "calvert social fund" BS is really just a Visa/Coke/Ford front [18:35:59] https://workplaceservices300.fidelity.com/mybenefits/savings2/performance/fundDetails?plan=30166&fromPage=hp09&fundnbr=OSCO&page=summary&inChildWindow=Y hah, hortus conclusus [18:36:58] ejegg: Hey, on a more directly workly subject... Did you see anything like an unsubscribe email listener during your bounced email hackfest? [18:37:47] not that I recall [18:38:27] k, thanks... [18:39:56] aww man, 'socially responsible' means apple, visa, amex, starbucks, and coca-cola. thanks Calvert [18:40:08] guess they're not making nukes or cigarettes... [18:40:19] or planned parenthood! [18:40:23] mofos [18:46:41] ejegg: maybe we can use Silverpop to receive unsubs?? There's no reverse suppression list import yet, though, eh? [18:47:05] no, not yet [18:47:16] ok, good to know [18:47:16] i might have started coding that stuff [18:48:15] ehh, not seeing it. hope i didn't nuke a branch [18:48:26] Heh, both times I've gone back to Mexico I've tried unsuccessfully to withdraw cash from the state-sponsored pension I paid into for years... [18:48:31] grrrr [18:48:50] I accidentally worked for UC Berkeley for a bit, probably a similar experience. [18:48:58] Heh [18:49:04] You're "allowed" under certain circumstances, but they make it very hard! [18:49:12] There was the withdrawal penalty, then the Enron fees... [18:49:21] :P [18:49:45] AndyRussG: But probably there's a streamlined process if you want to reinvest in Telmex... [18:50:06] Heheh or maybe in the about-to-be privatized water works! [18:54:07] * awight howls in fury [18:55:06] PPena: how is the ahem LATAM contract progressing? Are we ready to set up development accounts? [18:56:32] awight: we had an email about accounts with them at one point... [18:56:37] was that not valid? [18:56:40] ooh? [18:57:27] i'm looking now... [18:57:30] atgo: I do remember there is something about generic testing accounts in the API docs, but I don't think that's enough. We want console, our own reporting & stuff. [18:57:43] hmm ok [18:57:53] ppena said she thought we had everything we needed [18:57:56] i'll dig around email [18:58:37] ejegg do you have the email? [18:59:04] just forwarded [18:59:10] for some reason pats only sent to me and adam [18:59:23] checking [19:00:44] got it! [19:01:50] let us know if that doesn't give you what you need [19:09:34] pizzzacat: so, that removal error you're getting is my fault [19:09:49] dataLoading is not defined... [19:10:09] this will help some: https://gerrit.wikimedia.org/r/198265 [19:10:17] I think [19:12:04] ejegg: cool, looking now [19:12:19] yeah, it fixes your error but the modal doesn't fully go away sometimes. I think i need to de-bootstrap that modal [19:13:37] oh? ok.. [19:13:45] kind of losing track of order here [19:14:00] should we merge my remove widget patch and then merge your fix? [19:14:19] sure. [19:14:42] cool [19:15:33] well [19:15:40] ahh, that confirm modal is bootstrap too. that's going to prevent us from adding it to other widgets [19:15:42] actually I don't know if that's the best [19:15:58] because I have to add removal to the other widgets [19:16:09] i think we need to use the boostrap ko bindings or make our own modals [19:16:14] oh yep.. so why do we not want to use modals? [19:16:31] we just can't use those hardcoded ids for things we need more than one of [19:16:39] oh that issue, yeah [19:16:58] I would prefer to keep bootstrap modals and use binding params to fix the id's [19:17:38] we could generate the id''s based on the widget instance and name or something [19:17:53] eww [19:18:05] why not just use the bootstrap knockout bindings? [19:18:19] I didn't know they had them.. [19:18:22] http://billpull.com/knockout-bootstrap/ [19:18:40] perfect [19:18:59] \o/ [19:19:46] please update your bower_modules to 132339455dc before you add that! [19:19:49] so where does that leave me with the patch [19:20:00] so, I totally updated it, is it not reflected for some reason? [19:20:35] you've got it changing to b57027165c9375498978d3f65b8324d95621351c in your latest PS [19:20:36] I'm not sure how to tell, other than I updated the repo [19:21:03] let me see [19:21:18] oh weird [19:21:33] that was a revision from back in october [19:21:41] which? [19:21:47] awight: Hey, so: Do you know what happened to my beer from last night? [19:21:59] the one your current patch set is changing it to [19:22:28] I'm pretty confused because in my local I'm pointing to what appears to be the latest patch [19:22:38] but let me go to gerrit to see what your numbers show [19:22:50] K4-713: eh? no I left before it got like that [19:22:51] oh, strange, all of our newer changes aren't being merged to master [19:23:00] let's fix that [19:23:02] Mine is in the 6th-floor fridge with no red dot #snacks [19:23:02] * K4-713 frowns [19:23:09] I am pointing to https://gerrit.wikimedia.org/r/#/c/197270/ [19:23:11] in my local [19:23:21] Hm. [19:23:37] I may need some of it tonight, see. [19:23:43] pizzzacat: your patch is doing this https://gerrit.wikimedia.org/r/#/c/198255/3/src/bower_modules,unified [19:23:45] I intend to start that puzzle after work is done. [19:24:20] K4-713: ah. yes that is logical [19:24:44] How much of it could possibly have gone in the last... 16 hours? [19:25:08] so I have [19:25:13] PPena: do you get fr-accounts@ email? [19:25:14] commit b57027165c9375498978d3f65b8324d95621351c [19:25:14] Merge: 8ff1cd8 1323394 [19:25:14] Author: Elliott Eggleston [19:25:14] Date: Wed Mar 18 18:05:41 2015 +0000 [19:25:14] Merge "Update c3 and d3" [19:25:43] oh, ok [19:25:46] ejegg and that is incorrect? [19:26:07] no, that's fine... [19:26:20] K4-713: I hate to say it, but after a few months of sneaking down the stairwell with a beer every night, someone decided to hide it all from me :) [19:26:22] so when I committed, that's what I committed [19:26:25] Much appreciated [19:26:46] wait, let me see if I can find that one [19:27:07] awight: Gah! I knew I should have coated them with fluorescent dye. [19:27:48] ok. I'm now unclear what to work on since we have to refactor modals and this patch depends on the old style modals….should I just refactor to use bootstrap knockout modals in this patch or ...? [19:27:52] ok, sorry, i was pointing to the pre-merged one I guess [19:28:21] is it correct ejegg? [19:28:29] I mean you already said it is [19:28:37] ok, let's merge it as-is, and i'll add the bootstrap bindings to my patch since it needs it too [19:28:37] but just want to make sure you have the right version at the top? [19:28:47] oh ok.. [19:29:25] I feel like maybe you should go for it since it keeps changing course :) [19:29:26] (CR) Ejegg: [C: 2] "TODO: bootstrap knockout bindings instead of hard coded ids" (1 comment) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198255 (owner: Ssmith) [19:29:48] and then let me know when you're done, just before deployment, so I can make the style changes [19:30:01] so I can be out of your way and just finish the docs work [19:30:10] feel like I'm just adding a mess [19:30:22] and you're on a streak/know what you want [19:32:12] dangit k4-713 [19:32:16] ooh, i need to update bootstrap to use the bindings. let's see if that makes a mess! [19:32:16] i want to puzzle [19:32:24] atgo: I hella warned you. :p [19:32:28] i know... [19:32:46] Puzzle times is serious times. [19:33:13] ejegg yeah just let me know when you're merged and done before deployment [19:33:59] (PS1) Ejegg: Add knockout-bootstrap and update dependencies [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/198291 [19:34:13] (CR) Ejegg: [C: 2 V: 2] Add knockout-bootstrap and update dependencies [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/198291 (owner: Ejegg) [19:42:47] (PS1) Ejegg: Add knockout-bootstrap and update dependencies [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198294 [19:50:09] (PS2) Ejegg: Add knockout-bootstrap and update dependencies [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198294 [19:53:11] aargh, docs are horrible on this lib [19:57:09] pizzzacat: aargh, this lib doesn't do a lot of good for making modals repeatable [19:57:59] guess i'll complain about it more after security training [20:02:57] awight|lunch yes i do [20:03:00] awight|lunch need anything? [20:42:25] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Document CiviCRM custom fields - https://phabricator.wikimedia.org/T91519#1136724 (atgo) p:Triage>Low [20:48:06] Wikimedia-Fundraising, Fundraising Tech Backlog, Fundraising-Backlog, Patch-For-Review: BUG: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1136753 (atgo) It's been a few days - could we confirm and close this? @ccogdill_wmf @ejegg [20:49:29] Wikimedia-Fundraising, Fundraising Tech Backlog, Fundraising-Backlog, Patch-For-Review: BUG: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1136755 (CCogdill_WMF) Yes, sorry for the delay @atgo. Everything looks good in Silverpop. Le vendredi 20 mars 2015, atgo Wikimedia-Fundraising, Fundraising Tech Backlog, Fundraising-Backlog, Patch-For-Review: BUG: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1136758 (atgo) Open>Resolved [20:51:28] AndyRussG, ejegg, pizzzacat: http://xkcd.com/327/ [20:51:42] Bwahahahah [20:59:17] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/198320 (owner: L10n-bot) [21:00:21] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/198311 (owner: L10n-bot) [21:02:42] (PS2) Ejegg: Fix widget loader tracking on board switch [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198265 [21:10:21] (PS1) Ejegg: Revert "Add knockout-bootstrap and update dependencies" [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/198391 [21:11:07] (Abandoned) Ejegg: Add knockout-bootstrap and update dependencies [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198294 (owner: Ejegg) [21:11:45] (CR) Ejegg: [C: 2 V: 2] "fuhgeddaboutit" [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/198391 (owner: Ejegg) [21:12:54] PPena: hey! Yeah, there should be a new account confirmation from AP in there. [21:13:02] (PS2) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/198267 (https://phabricator.wikimedia.org/T90915) [21:14:33] funny, phab gerrit bot will add a patch to review for a task, but if you errered on the bug number like I just did and then fix it, it won't take the patch away from the taks that didn't deserve it [21:14:35] AndyRussG: fyi, I introduced JKatz to Steven's grand scheme today... I think he'd be very interested in hearing your thoughts. [21:14:54] awight: jKatz... looking [21:16:08] Oh right, he's the one working on gather! [21:29:17] (CR) Ssmith: [C: 2] Fix widget loader tracking on board switch [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198265 (owner: Ejegg) [21:48:35] PPena: hi! [21:54:28] awight there isnt [21:54:37] awight any account email on fracc [21:55:27] (PS1) Ejegg: Don't try to bind to an undefined board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198399 [22:00:25] PPena: ono! ok thanks. [22:05:39] PPena: should be resending now... [22:06:50] (PS1) Ssmith: Remove buttons for all widgets [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198402 [22:07:11] K4-713: IRL mirth <_< [22:11:00] (CR) Ssmith: [C: 2] Format smaller amounts of needed money more nicely [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198147 (owner: Ejegg) [22:12:40] (CR) Ssmith: [C: 2] Don't try to bind to an undefined board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198399 (owner: Ejegg) [22:13:35] (Merged) jenkins-bot: Don't try to bind to an undefined board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198399 (owner: Ejegg) [22:17:31] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Integrate processing in LATAM - https://phabricator.wikimedia.org/T77907#1137126 (awight) [22:22:44] K4-713: was it funie? [22:34:16] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Integrate processing in LATAM - https://phabricator.wikimedia.org/T77907#1137174 (awight) [22:37:41] (PS2) Ssmith: Remove buttons for all widgets [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198402 [22:45:46] (CR) Ejegg: [C: 2] "Dr. Frankenstein, your monster lives!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198402 (owner: Ssmith) [22:46:17] hehe ^ [22:53:48] haha yay [23:13:49] (PS1) Ejegg: Fix default board id on first login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198422 [23:41:24] (PS1) Ssmith: Fix setConfig value in fraud widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198434 [23:52:39] (PS1) Awight: WIP php-queue library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/198438 (https://phabricator.wikimedia.org/T92916)