[00:48:21] (CR) Awight: [C: 2] "zuul-cloner failure is disturbing, but not caused by the patch." [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/199133 (owner: Ejegg) [00:50:13] (Merged) jenkins-bot: Upgrade to Drupal 7.35 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/199133 (owner: Ejegg) [01:42:35] (PS1) Ejegg: Merge branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/199181 [01:45:58] (PS2) Ejegg: Merge branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/199181 [01:47:47] (PS3) Ejegg: Merge branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/199181 [01:50:09] (CR) Ejegg: [C: 2 V: 2] Merge branch 'contrib' [wikimedia/fundraising/crm/drupal] - https://gerrit.wikimedia.org/r/199181 (owner: Ejegg) [01:54:01] (PS1) Ejegg: Update Drupal submodule to 7.35 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199184 [01:55:46] (CR) Ejegg: [C: 2 V: 2] Update Drupal submodule to 7.35 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199184 (owner: Ejegg) [02:01:48] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/199185 [02:01:50] (PS1) Ejegg: Revert "Remove vendor submodule from master branch" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/199186 [03:58:06] (CR) Legoktm: [C: 2] Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/198856 (owner: L10n-bot) [04:01:33] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/198856 (owner: L10n-bot) [04:20:03] (CR) Legoktm: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/198874 (owner: L10n-bot) [04:27:32] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/198874 (owner: L10n-bot) [05:10:51] (CR) Legoktm: [C: 2] Localisation updates from https://translatewiki.net. [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/198899 (owner: L10n-bot) [05:11:13] (CR) Legoktm: [C: 2] Localisation updates from https://translatewiki.net. [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/198945 (owner: L10n-bot) [05:16:46] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/198899 (owner: L10n-bot) [05:25:37] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Sprint Grandmaster Flash: Make Civi CI job run on civicrm, drupal, and vendor (DonationInterface and SmashPig) repos - https://phabricator.wikimedia.org/T91905#1144246 (Krinkle) [05:25:38] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Sprint Grandmaster Flash: Mysterious failure to zuul-clone drupal repo - https://phabricator.wikimedia.org/T93707#1144244 (Krinkle) Open>Resolved It seems the new commit (Drupal update and branch merge) fixed whatever was up. ht... [05:36:20] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/198945 (owner: L10n-bot) [15:07:23] (PS1) Ejegg: WIP: shared filter component [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [15:07:54] (CR) jenkins-bot: [V: -1] WIP: shared filter component [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 (owner: Ejegg) [15:15:15] (PS2) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [15:18:27] (PS3) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [15:19:41] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Tech Backlog, Fundraising Sprint Grandmaster Flash, Patch-For-Review: Write Jenkins job builder definition for CiviCRM CI job - https://phabricator.wikimedia.org/T91895#1145176 (hashar) a:hashar>awight Reassigning to @awig... [16:01:37] Wikimedia-Fundraising, Fundraising Tech Backlog, Fundraising-Backlog, Patch-For-Review: BUG: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1145291 (CCogdill_WMF) Resolved>Open Sorry, have to reopen this @atgo. The data is not importing correctly, we think becau... [16:05:27] ccogdill: the bug you just reopened - super urgent? [16:06:11] yes atgo-meeting [16:06:14] can’t send email without it [16:06:44] yep [16:07:00] hey ejegg - FYI - https://phabricator.wikimedia.org/T92537 :( [16:07:04] i'm adding to the sprint at "unbreak now!" [16:07:16] Wikimedia-Fundraising, Fundraising Tech Backlog, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash, Patch-For-Review: BUG: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1145325 (atgo) [16:13:14] atgo-meeting: taking a look [16:13:22] thanks [16:14:00] probably just need to change the import config on the silverpop side [16:28:26] oh great, that's awesome. [16:28:52] just emailed ccogdill asking to turn my sp account back on [16:45:44] (PS4) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [16:52:28] Jeff_Green: Hey! [16:54:14] (CR) Ejegg: "Should we log the error at a higher level than info?" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/94087 (owner: Awight) [17:24:09] hi pizzzacat! Got a few exciting patches up, but only these 2 little ones are needed for the deploy: https://gerrit.wikimedia.org/r/198422 https://gerrit.wikimedia.org/r/198800 [17:26:39] You think you guys will get to the deploy bit today? [17:26:51] * K4-713 grins maniacally [17:27:05] * K4-713 keeps grinning [17:27:19] K4-713: i /think/ so! [17:27:44] Yaaaay [17:27:59] Let me know if I can do anything other than get out of the way. [17:28:10] cheering helps [17:28:53] WOOOO [17:29:14] * ejegg types faster [17:29:23] * K4-713 looks around for people to help make a pyramid [17:33:09] ejegg getting to it now! thanks [17:33:37] I still have some stuff to add before deploy as well [17:38:03] (CR) Ssmith: [C: 2] Fix default board id on first login [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198422 (owner: Ejegg) [17:39:00] (CR) Ssmith: [C: 2] Add gulp task to copy images [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/198800 (owner: Ejegg) [17:39:08] thanks! [17:44:15] ejegg sorry I missed your ping earlier, was in a meeting [17:44:21] just sent you the silverpop info! [17:45:24] thanks! [17:52:44] (CR) AndyRussG: "@awight Good point! A rough mock-up is here:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/198267 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [18:00:21] Hm. That was easy. [18:09:44] "//TODO: Insert actual fun part hereish." [18:09:58] ...I've just trolled myself two months ago. [19:18:28] (CR) AndyRussG: "Nice! Yeah, this was pretty hairy... a few points:" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [19:40:20] K4-713: hey, just saw your hey much delayed [20:20:45] Jeff_Green: Now it's my turn to be all delayed. [20:20:52] ha [20:21:05] How's things? [20:21:20] pretty good, you? [20:21:29] Decent! [20:21:41] did i miss anything exciting? [20:21:46] Not a lot happened while you were gone, due to Tom getting pneumonia. [20:21:59] ya [20:22:09] And I had a bunch of meetings. [20:22:34] yeah it seems to be planning season around here [20:22:36] Trying to think if any of that would be news, and/or relevant to you. [20:44:57] hey AndyRussG|mob [20:45:04] lmk when you're back - i have a couple of questions for you [21:10:58] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/199185 (owner: Ejegg) [21:11:29] (CR) Ejegg: [C: 2 V: 2] Revert "Remove vendor submodule from master branch" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/199186 (owner: Ejegg) [21:18:33] (PS1) Ejegg: Update ctools to 7.x-1.7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199335 [21:35:27] (CR) Ejegg: [C: 2] Update ctools to 7.x-1.7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199335 (owner: Ejegg) [21:37:22] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/199504 [21:45:45] (PS1) Ssmith: Modify c3 style value to work with widgets [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/199507 [21:48:24] (PS2) Ejegg: Modify c3 style value to work with widgets [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/199507 (owner: Ssmith) [21:57:47] (CR) Ejegg: "Doesn't fix the fraud widget for me in FF or chromium :(" [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/199507 (owner: Ssmith) [22:01:23] !log disabled Jenkins civi jobs [22:01:30] Logged the message, Master [22:02:17] !log updated civicrm from f8fb0f61531431348f3a8a3ee107056a864d537b to 4c459f3dbf3c3466cdc26a351ba589f4f1aef587 [22:02:22] Logged the message, Master [22:07:03] !log Re-enabled Jenkins civi jobs [22:07:12] Logged the message, Master [22:07:23] Hey ejegg... :) How's it going? Do you have a sec sometime to explain to me a few bits of the FR infrastructure I'm not familiar with? [22:07:45] sure, what's your curiosity AndyRussG ? [22:08:48] ejegg: basically I need to understand how info is logged about user donations [22:09:24] In a nutshell, for banner history, it looks like we'll be sending back sample data on everyone's history [22:10:01] And then we'll need to be able to flag the histories of those who donated and those who didn't [22:10:14] DonationInterface drops details into an ActiveMQ queue including utm_source and utm_medium querystring vars that tell us which banner ppl clicked on [22:10:19] And link the more detailed info we have about donors to their histories [22:11:00] OK hmm I'm about 60% terminology-oblivious WRT what u just said ;p [22:11:30] K I know DonationInterface... [22:11:35] OK, so the mediawiki extension doesn't insert donations into the db in realtime [22:11:54] Ah OK interesting [22:12:00] it uses a queue to buffer the stuff so CiviCRM extensions can digest them at their own rate [22:12:37] DonationInterface gets all of its banner-related info on the querystring of the initial hit [22:13:20] Ah OK [22:13:34] there are a few utm_XXXX variables (some kind of ad industry standard apparently relating to a 'urchin tracking manager' program that got bought by google) [22:14:00] Wow, amazing [22:14:49] http://www.maketecheasier.com/what-is-utm-source/ [22:15:09] Hmm so as a first step, could u maybe point me to some code that'll tell me exactly what DI gets? [22:15:52] sure, lemme see... [22:15:59] I guess either the slurp or the outspit side, or maybe even both would be fun [22:18:58] I guess the call to DI gets made from the banners... [22:21:16] AndyRussG: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDonationInterface.git/600b5a74867cdab08ab6d8335dc096df1c24634b/gateway_common%2FDonationData.php [22:21:30] That class pulls stuff in off the querystring [22:21:35] (apologies for my gross "humour") [22:21:43] cool! [22:22:21] that list of var_names a little ways down includes anything we get, and some stuff we usually don't [22:22:54] right [22:23:07] like card_num I guess we actually don't [22:23:19] ooh, guess we could zap that! [22:24:32] so this comes in... thru links in the banner, right? [22:24:40] yep! [22:25:22] Since it's a different subdomain (payments.wikimedia.org), we can't share cookies or local storage [22:26:03] yeah that's gonna be interesting... [22:26:05] so correlation of banner histories with donations, without unique IDs, will be an interesting challenge [22:26:09] heh, exactly [22:26:15] jinx! [22:27:40] could add a hash of the history to the DI [22:28:25] but then you'd need to make sure CN sends exactly that version of the history to our recorder [22:28:43] which i guess you'd do on banner click [22:29:53] i mean add the hash value to the link querystring [22:30:23] That's an interesting approach! [22:30:50] Yeah I mean, there's unique IDs and then there's unique IDs [22:31:33] yeah, you could have 1000 ppl with the same banner history and know that 5 of them clicked through to donate [22:31:42] A unique ID (or a hash) being passed on a URL to DI when someone clicks on donate is not the same as unique IDs all thru all our pageview logs, thankfully [22:32:26] The banner history is gonna be basically a timeline of banner views (but not the names of pages they were on)... Also I think it'll be important to fuzz the timestamps so they can't be linked to full server logs [22:32:49] ohh, timestamps will uniquify that stuff [22:33:23] they only care about day-scale granularity? [22:34:15] Well, I think if we fuzz it + or - some number of seconds it'll be enuf, considering our request volume [22:34:27] ok [22:34:57] as in, some random offset [22:35:49] right. well, the less exact we need 'em, the less localStorage we have to use too [22:37:02] mm also true! [22:37:25] (BTW I have a plan for localstorage overflow that I could put past u in a sec too, if you have time) [22:37:41] ooh, i'd love to know [22:37:53] * AndyRussG plays suspensful music [22:38:22] It's pretty simple. I'm pretty sure that when you write to localstorage, there's a way to tell if the write was successful [22:39:00] try catch or just read it back and compare [22:39:46] Yeah that may be it... haven't checked that detail, but I did read about tests that did it... So in cases where it's not sucessful (for whatever reason, be it due to overflow or some other ishiew) set a cookie [22:40:23] And if that cookie is set, indicating some history recording bork, then send that back when a user is sampled for banner history [22:40:58] oh, the cookie just stores the 'borked' flag? [22:41:11] for statistical purposes [22:41:26] Maybe... of it could store more. Yeah! The stats will have the percentage of users whose history borked [22:41:40] cool, i like that [22:41:45] :) thanks! [22:42:23] Yeah I hope that'll be enough for our statisticians to know whether any relevant amount of history is missing, and from whom [22:42:25] pizzzacat: think we should add some of these graphs? http://thebulletin.org/doomsday-dashboard [22:43:06] haha aww :( [22:43:17] If we send a banner history hash to DI, the value of the localstoragebork bookie could also be included [22:44:09] ejegg: whoa! and nice, though terrifying [22:44:34] ejegg: would you mind +2ing https://gerrit.wikimedia.org/r/#/c/199507/ (bower modules)? [22:44:37] yah.. they've gotten a lot closer to midnight since they started considering global warming [22:44:55] ejegg: umm continuing w/ the CN-DI-donation logging info chain... so let's say hypothetically DI gets a unique hash of banner history when the user clicks on donate in a banner [22:44:56] pizzzacat: is that supposed to fix the fraud widget offset? [22:44:57] about to push the stuff I've been working on today [22:45:22] no, I took care of that in style.css but there was a new style rule they added that messed up a different chart [22:45:25] I'm assuming that hash can get back to our records of donors somehow [22:45:27] you can see in the patch [22:45:37] oh, ok! [22:45:53] basically it made the svg cut off for the totals earned chart [22:46:12] the bottom was cut off… so I made it a little bigger [22:46:12] AndyRussG: we might need to add another field to our contribution tracking db, but yeah, we can do that somehow [22:46:24] ejegg: cool! [22:47:03] (CR) Ejegg: [C: 2 V: 2] "Ahh, this fix is for another problem!" [wikimedia/fundraising/dash/src/bower_modules] - https://gerrit.wikimedia.org/r/199507 (owner: Ssmith) [22:47:07] I don't usually like modifying the libs directly but chances are I'll have to do fixes for the next upgrade anyway [22:47:25] ¯\_(ツ)_/¯ [22:47:32] thx [22:47:36] so just to get a full overview of the process, DI knows when someone really donates or not, I guess, because it receives some info from the embedded payment processor form of something like that? [22:47:45] word. yeah, it would be a huge pain to create our own version + bower repo for this one tiny change [22:47:49] pizzzacat: nice UTF art [22:48:17] thanks, I also have (╯°□°）╯︵ ┻━┻ [22:48:35] both aliased on my machine to 'shrug' and 'flip' respectively [22:48:39] AndyRussG: yeah, we create a record that they started contributing as soon as they hit DI, then we can tell which of those end up feeding our bank account [22:48:52] aliased... awesome! [22:49:18] I have a magnetic poetry kit that includes the 'flip' glyph [22:49:34] hehe nice [22:50:17] pizzzacat: I rebased the bower_modules patch, so you may want to update locally before adding the submodule to a dash commit [22:51:06] no real change, I just had merged then reverted that knockout-bootstrap library in the meantime [22:51:09] ejegg: fantastic... Mmm just to check, so then this info is pulled directly from our civi database by Ellery and analytics when they study banner effectiveness, yea? [22:51:40] (PS1) Ssmith: Pre-deploy interface fixes [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199518 [22:51:57] ejegg I just did it.. [22:52:02] I mean it may be the wrong one [22:52:06] And that's how they compare which banners get more dough-nations? Because the Civi db has confirmed donations and the banner name? [22:52:09] yeah, Ellery's stuff pulls together stuff from contribution tracking and banner access logs [22:52:21] yeah [22:52:25] I did update it with the remote before git submodule updating though [22:52:28] so it might be fine? [22:52:30] I mean, the banner access side I'm familiar with... [22:52:50] or more or less, at least I know the overview ;p [22:53:24] ejegg: ¡excelente! thanks so much :) [22:56:32] (PS1) Ejegg: Update bower_modules to include the c3 fix [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199520 [22:57:11] pizzzacat: looks like your commit didn't touch bower_modules, so no need to revisit that. Can just merge that one^^^ [22:59:32] ok [23:00:05] was I just on autopilot with that c3 fix then? [23:00:38] If you had it locally you were getting what you expected [23:01:15] you updated the actual code in the submodule just right [23:01:45] we just needed to tell the main repo to use your latest version of the submodule [23:07:37] (CR) Ejegg: [C: 2] "Looks great! Love the puzzle piece." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199518 (owner: Ssmith) [23:09:40] Wikimedia-Fundraising, Fundraising Tech Backlog, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash, Patch-For-Review: BUG: Silverpop export is still broken - https://phabricator.wikimedia.org/T92537#1147038 (Ejegg) Brian S. updated the import to match the files we're generating now. We... [23:16:06] hey andyrussg - do you have a minute to talk about the UI stuff you sent out? or would another time be better? [23:16:08] (PS1) Ssmith: Add a cat playing a trombone [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199530 [23:16:14] could connect in the morning if better [23:16:24] ^^ejegg very important pre-deploy patch [23:16:39] If that's not MVP, I don't know what is. [23:16:50] (CR) jenkins-bot: [V: -1] Add a cat playing a trombone [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199530 (owner: Ssmith) [23:17:09] (PS2) Ejegg: Update bower_modules to include the c3 fix [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199520 [23:17:11] (PS1) Ejegg: Fix 'Not set up' on new widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199531 [23:19:15] (PS2) Ssmith: Add a cat playing a trombone [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199530 [23:19:20] had to lint the cat [23:19:27] hah! [23:20:00] atgo: sure! [23:20:07] meow [23:20:16] AndyRussG: want to do a call or talk here? [23:20:40] atgo: either one is fine! [23:20:40] pizzzacat: we'll need those two I just submitted too [23:20:57] ok.. easier for me if we talk talk [23:21:39] K one sec :) [23:22:33] looking now ejegg [23:22:40] brb, too. [23:23:08] (CR) Ssmith: [C: 2] Update bower_modules to include the c3 fix [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199520 (owner: Ejegg) [23:25:10] atgo-brb: https://plus.google.com/hangouts/_/gyfbr3wyv3cwzktyb36sd4ztnea?hl=en [23:26:19] ejegg when I'm looking at the fraud widget patch, I'm seeing that the gauge range selector (in the modal) doesn't appear unless the widget has been saved, is that happening for you? [23:27:03] ooh, i didn't notice exactly when thet happens, but yep. Let me seeif I can add a fix for that [23:27:50] do you want to do it in a new patch or this same patch? [23:28:35] I'll put up another [23:29:22] ok [23:30:06] (CR) Ssmith: [C: 2] Fix 'Not set up' on new widget [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199531 (owner: Ejegg) [23:30:21] ooh, dang. we're not saving greenHighRange or redLowRange anywhere [23:31:10] whoops! should those go into config? [23:31:25] sure [23:31:37] or set a default [23:31:49] huh, you've got 'renderPercentRangeChart' wired up to the button that opens the modify modal [23:32:02] can't see why saved vs not saved should matter [23:32:12] ohhh, it's not wired to the big 'set it up' button [23:32:19] honestly I haven't looked at it in ages [23:34:22] (PS1) Ejegg: Render settings arc on either button [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199533 [23:34:58] (CR) Ejegg: [C: 2] "Genius!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199530 (owner: Ssmith) [23:40:38] (CR) Ssmith: [C: 2] "Works 4 me!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199533 (owner: Ejegg) [23:42:55] https://en.wikipedia.org/wiki/Domain-driven_design [23:43:18] https://books.google.ca/books?id=xColAAPGubgC&printsec=frontcover&dq=domain+driven+development&hl=en&sa=X&ei=h_YRVbCVOemPsQTSwoDwCQ&redir_esc=y#v=onepage&q=domain%20driven%20development&f=false [23:51:24] (Merged) jenkins-bot: Update bower_modules to include the c3 fix [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199520 (owner: Ejegg) [23:53:00] be back online in 20 min [23:53:03] .