[00:06:06] (PS2) Ssmith: Optimize padding for laptops, better nav style [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199782 [00:07:14] (CR) Ejegg: [C: 2] Optimize padding for laptops, better nav style [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199782 (owner: Ssmith) [00:21:11] (PS1) Ejegg: Delete some unused stuff [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199802 [00:27:07] (CR) Ejegg: "Did I just put the c3 binding on the wrong element? It looks like it might fix it to move the 'data-bind="c3: avgUSDperSecondChart"' to t" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199759 (owner: Ssmith) [00:49:19] (CR) Ssmith: [C: 2] "it's working with my data" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199752 (owner: Ejegg) [00:49:48] (Merged) jenkins-bot: Ignore bogus future donations. [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199752 (owner: Ejegg) [02:02:56] (PS1) Ssmith: Remove default wording and direct new user to lib [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199815 [02:03:27] (CR) jenkins-bot: [V: -1] Remove default wording and direct new user to lib [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199815 (owner: Ssmith) [16:35:43] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1153496 (RLewis) @atgo I reimported the JP Morgan file. There was an issue with line 2 in the file which was one of the... [16:53:52] (CR) Ejegg: "Looks good, just need to satisfy Douglas Crockford's vars-at-the-top convention." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199815 (owner: Ssmith) [16:56:27] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/199938 [16:57:26] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/199938 (owner: Ejegg) [16:59:21] !log updated dash from 6d9acd60bb833c6dd57ab8b424afc8077b0c9f03 to 038bdc4c60697ac738eaeae384d91579710ff85a [17:28:24] (PS3) Krinkle: ci-settings: Update environment variable test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/197832 [17:37:32] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1153731 (atgo) @rlewis is that an OK outcome for you or is this an issue? [17:41:29] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1153737 (awight) I checked with RLewis, and this is a reimport of the old file, with manual fixups. We're still waiting... [17:47:38] Hi awight! When u got a sec, do you think you could explain to me briefly the use cases for the php components of the current banner-based mixin implementation? thx in advance :) [17:50:42] Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1153771 (RLewis) @awight and @atgo its line 3 not 2. I've put the file on the server. Here's the filepath: smb://files... [17:53:51] AndyRussG: sure, an easy example would be a fundraising thermometer, e.g. http://www.school-fundraisers.com/fundraising-thermometer.php [17:54:24] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint H, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1153780 (atgo) Ok. Let's leave this open until then. I'm adding to the next sprint for accounti... [17:54:25] Another would be, a mixin that provides other magic words such as donation amounts. [17:55:21] awight: Ah OK! So basically, just a thing to pull in special data server-side and put it in the banner? [17:57:02] It sounds like it's not something we'll need for campaign-based mixins, since they're all RL-based, so if we needed that, we could do another PHP-based RL module to be pulled in as a dependency as needed, make sense? [17:59:07] AndyRussG: well, I think most mixins would always be needed for all banners in a campaign, but I see what you're saying. [17:59:27] It's fine to take this slowly, since we're starting at mixins=0 :) [18:00:20] awight: mmm right, I mean, we're keeping the banner-associated mixins as they are, recall the new thing is just adding campaign-associated ones that run before banners are loaded [18:00:29] or even chosen [18:00:35] AndyRussG: donno... we might as well get rid of banner mixins at this point? [18:00:44] before someone accidentally uses them ;) [18:01:05] So yeah a campaign-associated mixin will run for all banners in the campaign [18:01:16] awight: hmmm I think we still potentially have use cases! [18:01:40] There are things that we'll still want to stuff only in one banner or another [18:02:09] Or is there a motivation for killing 'em? [18:02:24] meh, just that it's unused complexity. [18:03:47] ejegg: Hey, can we maybe have our checking early? [18:03:51] Like... nowish? [18:04:18] ...check-in. [18:05:05] (CR) Awight: [C: 2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/197832 (owner: Krinkle) [18:06:59] Jeff_Green: Hey, you around? [18:07:13] K4-713: sure, let me just get out of the quiet room [18:07:17] one sec [18:07:18] awight: K yeah I see... Here's what I suggest: let's leave 'em in at least until we seriously get going converting the on-wiki banner scripts to campaign-associated mixins. Once that's going we'll have a _batter_ idea of what banner-associated _mix_-ins would make sense to have, if any? [18:07:27] ejegg: Yeah, me too. [18:07:45] AndyRussG: :p I see what you did [18:08:08] awight: Meanwhile I won't worry to much about meshing the new code with exisitng the mix-in implementation recipe? [18:08:19] AndyRussG: yes, let's wait to cook the goose until we go whole-hog with campaign mixins. [18:08:38] awight: K cool, it's a deal :) [18:08:38] AndyRussG: well, now you've got me worried again :p [18:08:42] huh? [18:08:58] When did I stop worrying you? [18:08:59] How about, modifying the existing mixin implementation to at least support your constrained k/v pairs. [18:09:25] the k/v pairs are client-side [18:09:36] wat. [18:09:38] they'll go in the bannercontrollerlib api [18:09:47] client-side in localstorage [18:10:01] replacement for storing all our batter BS in cookies [18:10:05] I'm talking about the params to the campaign mixins. [18:10:13] aaaah OK right those [18:10:35] hrm, yeah a general thing for storing client vars would be helpful too. [18:10:55] yeah that logic could go in the mixin controller [18:11:29] You want to prevent legacy banners from using the client-store api? [18:12:33] huh? [18:12:51] no? or should I? [18:13:00] If the client var support is in the mixin controller, I assume it won't be accessible from campaign banners without mixins enabled? [18:13:35] And if it is accessible still, then it seems like responsibility for this feature should be outside of the mixin controller. [18:13:55] * AndyRussG tries to shake out confusion [18:14:22] I think it's me :) [18:14:23] Silly IRC async message exchange [18:14:28] want to "RL" chat? [18:14:31] I see what IRC did! [18:15:08] (PS2) Ssmith: Remove default wording and direct new user to lib [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199815 [18:15:19] awight: sure! anytime is good :) [18:15:21] hey ejegg, fixed the linting issue ^ [18:15:53] I am looking into the fraud gauge issues you emailed about; those should probably be fixed asap [18:17:35] AndyRussG: not sure that invite went through? [18:21:38] ~. [18:22:12] (Merged) jenkins-bot: ci-settings: Update environment variable test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/197832 (owner: Krinkle) [18:24:38] pizzzacat: awesome! [18:25:16] (CR) Ejegg: [C: 2 V: 2] Remove default wording and direct new user to lib [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199815 (owner: Ssmith) [18:32:17] ejegg do you have scripts for me to generate data, eg, for the fraud gauge, so I can test the color issue? [18:33:14] if you have data from lst year, you can move it around in time [18:33:19] lemme see [18:34:22] hmm, dates won't match across tables, but it should give you something to work with [18:34:58] somthing like this: [18:37:00] update payments_fraud set date = date + INTERVAL (contribution_tracking_id % 80) DAY WHERE date < date() - INTERVAL 80 DAY [18:37:12] pizzzacat: ^^ [18:37:50] should add a semi-random number of days between 0 and 80 to the dates in that table [18:38:35] not sure hold old your newest data is, but you can just run the same again if you still have nothing recent [18:38:59] thanks ejegg, trying it out [18:42:12] am I supposed to plug in dates or date functions? [18:42:17] ejegg^ [18:42:29] or strings [18:42:53] pizzzacat: I think you can just run it as typed [18:43:00] the column is called date [18:43:17] oh, that isn't working for me [18:43:28] what does it say? [18:43:35] syntax error :-/ [18:43:41] hmm, lemme try [18:46:02] ok, change the where bit to ( now() - interval 80 day ) [18:46:06] with the parens [18:46:52] ooh, rather utc_timestamp() [18:49:24] hmm it worked ejegg! but I'm not getting data in the fraud gauge, so I wonder what was actually set [18:50:03] look at the most recent dates in that table - 80 days may not have been enough, so you can just run that again [18:50:54] word [18:51:25] thank you, I'll play with it and get it to bend to my will! [18:52:42] ah yep, working now. cool! [19:04:05] (PS6) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [19:04:07] (PS1) Ejegg: Add a binding for select2 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199968 [19:04:42] (CR) jenkins-bot: [V: -1] Add a binding for select2 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199968 (owner: Ejegg) [19:04:44] (CR) jenkins-bot: [V: -1] Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 (owner: Ejegg) [19:04:51] K4-713: hey. here now [19:07:03] (PS7) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [19:07:05] (PS2) Ejegg: Add a binding for select2 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199968 [19:37:40] (PS8) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [19:37:42] (PS3) Ejegg: Add a binding for select2 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199968 [19:37:44] (PS1) Ejegg: Fix Contribution Status filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199980 [19:38:28] pizzzacat: I fixed the ugly on the shared filter component ^^ [19:45:10] (PS2) Ejegg: Delete some unused stuff [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199802 [20:14:54] hey ejegg we found awight [20:15:11] we're in the astropay estimation meeting [20:15:14] hangout [20:15:51] ok, be there in one sec [20:20:08] awight: sorry to interrupt, I know you're busy--just wondering if there's any rhyme or reason behind calling the SpecialCentralNotice method that handles viewing/editing an individual campaign listNoticeDetail? As in, what's the "list" part about? [20:20:15] Maybe because it has a list of banners? [20:20:31] I'm thinking about a flash refactor there before pooking stuff [20:23:16] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Integrate processing in LATAM - https://phabricator.wikimedia.org/T77907#1154386 (atgo) [20:24:52] (PS1) Ssmith: Fix fraud gauge color display [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199994 [20:25:37] ejegg I am not able to repro the issue you mentioned with fraud gauge not loading the configuration chosen timeframe on first load [20:26:46] Wikimedia-Fundraising-CiviCRM: Disable Arizona Lockbox users from Civi. - https://phabricator.wikimedia.org/T94081#1154412 (RLewis) NEW a:atgo [20:34:29] Wikimedia-Fundraising, Fundraising-Backlog: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1154493 (atgo) [20:39:24] Wikimedia-Fundraising, Fundraising-Backlog: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1154550 (atgo) [20:41:35] Wikimedia-Fundraising, Fundraising-Backlog: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1154674 (atgo) [20:43:08] Wikimedia-Fundraising, Fundraising-Backlog: Create new HTML forms for LATAM processing - https://phabricator.wikimedia.org/T90502#1154688 (atgo) [20:43:20] Wikimedia-Fundraising, Fundraising-Backlog: Add LATAM forms to DonationInterfaceFormSettings.php - https://phabricator.wikimedia.org/T90505#1154690 (atgo) [20:44:06] Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1154698 (atgo) [20:44:51] Wikimedia-Fundraising, Fundraising-Backlog: Write confirmation message listener for LATAM, which rescues donations from the limbo queue - https://phabricator.wikimedia.org/T90506#1154711 (atgo) [20:45:37] Wikimedia-Fundraising, Fundraising-Backlog: Write LATAM audit file processor - https://phabricator.wikimedia.org/T90507#1154716 (atgo) [20:49:48] pizzzacat: save a gauge with 24 hrs, then reload page with firebug or dev tools up and look at the filter sent on the query string [20:50:06] the DT param will still be 15 minutes ago [21:05:36] ejegg: "The Grand Design" [21:05:40] Jeff_Green: Still there? [21:05:48] yeah [21:05:48] awight: thanks! [21:05:52] Yay! [21:05:58] IRC tag is fun. [21:06:02] Anyway. [21:06:24] ejegg: yep, totally happens. huh! [21:06:27] woot [21:06:39] Jeff_Green: We should probably touch base about what's going on with the PCI stuff. [21:06:39] pizzzacat: I think the datepickers component is resetting it [21:06:59] K4-713: ok [21:07:22] ejegg: ok, lookin [21:09:26] atgo: so we're cool to check in filenames with the LatAm processor name now? [21:09:41] PPena_: do we have the contract yet? [21:11:49] ejegg but isn't the datepicker using the selectedTimePeriod param to set things? [21:13:44] pizzzacat: lemme look again [21:14:50] the date picker binds its selected options to chosenTimePeriodPresetDate [21:15:15] (for a single select you could use the value binding and not have to worry about an array) [21:15:53] ejegg: linked from the FTL wikipedia article... Looks like they say, it doesn't work yet but is promising :p http://arxiv.org/pdf/quant-ph/0512207.pdf http://arxiv.org/abs/1205.4926 [21:16:09] but there's nothing in date-picker.js to initialize chosenTimePeriodPresetDate to the original value of selectedTimePeriod [21:16:23] awight: wow! [21:17:23] ejegg I see what you mean…conceptually [21:17:53] …need to get the value from the current widget set to chosenTimePeriod [21:19:34] pizzzacat: the way we're using it now, you could just pass the one parent observable (fraud gauge's self.selectedTimePeriod) directly to the select's value binding [21:21:00] the select ? [21:21:12] which select? [21:21:15] the select in date-picker.html [21:21:40] could just data-bind: { value: params.selectedTimePeriod } [21:21:44] ohh [21:22:01] i know you've got a bunch of logic to allow other time selections [21:22:11] yeah that thing is a mess [21:22:16] but that would be a quick fix for the one case we're using now [21:22:20] totally [21:36:34] (PS1) Awight: Fix regression with zero-amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200031 (https://phabricator.wikimedia.org/T58657) [21:49:24] atgo: do we want to be on this? https://phabricator.wikimedia.org/tag/roadmap/ [21:49:31] nay [21:49:42] right, k [21:49:49] haha want more discussion or...? [21:50:07] No, I asked you before looking... at all. [21:50:15] It's not appropriate 4 us [21:57:51] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint H, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1155310 (awight) Today's failure looks like it was caused by a comma in the "Credits" field, bu... [21:59:53] Wikimedia-Fundraising, Fundraising-Backlog: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1155328 (atgo) [22:03:06] atgo: why removed story points? ^ [22:03:15] ahh shit [22:03:18] :p [22:03:24] i had it open and saved it by accident instead of closing [22:03:26] could you re-add? [22:03:51] thank you for the catch there! [22:03:52] Wikimedia-Fundraising, Fundraising-Backlog: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1155341 (awight) [22:03:58] hooray for IRC spam :) [22:04:01] hahah [22:04:02] DING [22:04:03] DING [22:04:11] atgo [22:04:15] take it easy, buddy [22:04:17] aww it doesn't ding on self mentions [22:04:22] HA [22:04:32] maybe you should use the visual bell? [22:04:47] Nobody actually cares if it takes u 5 minutes to respond, fyi [22:05:01] (PS2) Ssmith: Fix fraud gauge color display [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199994 [22:08:29] haha [22:08:34] yeah maybe i will turn off the noises. [22:08:50] (CR) Ejegg: [C: -1] "Looks good, just needs a lil fixup" (2 comments) [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199994 (owner: Ssmith) [22:08:51] OMG I thought you were dead! Where were you?????? [22:19:46] (PS1) Ejegg: Bind amount-per-second-chart to the right div [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200048 [22:21:25] atgo: air? [22:21:28] (CR) Ejegg: [C: -1] "Yep, this was me putting the c3 binding on the wrong div. I think Iae96ac8448eb546 is the fix we need here." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199759 (owner: Ssmith) [22:22:36] hey ejegg - the totals earned seems a bit off to me [22:22:59] like you can only define the goal, but it's always for December? [22:26:42] atgo yep, not as useful as id like [22:26:49] hmm [22:26:49] ok [22:27:16] i can fix that though :) [22:28:32] hehe is there a card for it? [22:29:30] not yet... [22:29:57] making one! [22:34:50] (CR) Ssmith: "Ok, are you wanting me to abandon this patch, then?" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199759 (owner: Ssmith) [22:53:10] (PS1) Ssmith: Add an add-widgets button to boards [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200061 [22:58:10] ejegg pizzzacat - i sent you guys some initial release notes [23:02:34] thanks atgo [23:06:42] (PS3) Ssmith: Fix fraud gauge color display [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199994 [23:07:22] (PS2) Ssmith: Add an add-widgets button to boards [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200061 [23:13:40] (CR) Ssmith: [C: 2] "That was it!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200048 (owner: Ejegg) [23:15:25] (CR) Ejegg: [C: 2] "Good stuff!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199994 (owner: Ssmith) [23:16:22] i'm going to head upstairs to say goodbyes [23:17:54] (CR) Ejegg: "Yes plz! The others were fine 'cause I put the c3 binding on the same element you were binding the chart to. This one I screwed up and put" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199759 (owner: Ssmith) [23:26:19] (Merged) jenkins-bot: Bind amount-per-second-chart to the right div [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200048 (owner: Ejegg) [23:35:18] (CR) Ejegg: [C: 2] "mmm, devious id reuse" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200061 (owner: Ssmith) [23:38:15] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/200074 [23:38:44] (CR) Ejegg: [C: 2 V: 2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/200074 (owner: Ejegg) [23:40:17] !log updated dash from 038bdc4c60697ac738eaeae384d91579710ff85a to 5a6b2dda71e6ce76d7bbba853acae8dc9416052c [23:40:26] Logged the message, Master [23:45:30] (CR) Ejegg: [C: 2] "Wunderschön!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200031 (https://phabricator.wikimedia.org/T58657) (owner: Awight) [23:49:41] (Merged) jenkins-bot: Fix regression with zero-amount error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200031 (https://phabricator.wikimedia.org/T58657) (owner: Awight)