[00:09:35] (PS1) Ejegg: Don't lint dist/ if it exists [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200079 [00:36:47] I'm gonna do a payments deployment, for https://phabricator.wikimedia.org/T58657 and cos it's Thursday. [00:39:57] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/200082 [00:57:56] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/200082 (owner: Awight) [00:58:18] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200084 [00:58:21] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/200082 (owner: Awight) [00:58:33] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200084 (owner: Awight) [00:59:03] (CR) jenkins-bot: [V: -1] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200084 (owner: Awight) [00:59:44] (CR) Awight: "recheck" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200084 (owner: Awight) [00:59:57] (CR) Awight: [V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200084 (owner: Awight) [01:01:49] !log updated payments from 32e860bd304763ccedc7110dee828249daa2b154 to f617326761887ed9a9100b472ea3b5736e2c10e6 [01:01:55] Logged the message, Master [01:04:35] Wikimedia-Fundraising: Put payments-initial feed on wikikiosk - https://phabricator.wikimedia.org/T94127#1155791 (awight) NEW [01:24:43] (PS1) Awight: Remove some donation premium language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 [01:27:17] (PS1) Ejegg: Add node.extend [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/200090 [01:28:42] (PS1) Ejegg: Add node.extend [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200091 [01:28:44] (PS1) Ejegg: Define common filters in one file [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200092 [01:55:44] (PS1) Awight: WIP Kill pre-PCI credit card cruft? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200094 [01:56:28] (CR) jenkins-bot: [V: -1] WIP Kill pre-PCI credit card cruft? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200094 (owner: Awight) [01:57:03] (PS2) Awight: WIP Kill pre-PCI credit card cruft? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200094 [01:57:38] (CR) jenkins-bot: [V: -1] WIP Kill pre-PCI credit card cruft? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200094 (owner: Awight) [02:12:59] (PS2) Ejegg: Define common filters in one file [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200092 [02:26:32] (PS3) Awight: WIP Kill pre-PCI credit card cruft? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200094 [02:27:04] (PS1) Awight: TODO Less special-casing in DataValidator [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200096 [02:32:25] (PS9) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [02:32:27] (PS4) Ejegg: Add a binding for select2 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199968 [02:32:29] (PS1) Ejegg: Add text filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200097 [02:33:23] (Abandoned) Ejegg: Fix Contribution Status filter [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199980 (owner: Ejegg) [04:55:11] (CR) Ejegg: "TODO: find a good way to write to each filter's userChoices after initial binding (for example, if you want to click to drill down from ye" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 (owner: Ejegg) [15:52:53] (CR) Ejegg: [C: 2] Remove some donation premium language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [15:54:40] (CR) jenkins-bot: [V: -1] Remove some donation premium language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [16:01:31] (CR) Ejegg: Remove some donation premium language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [16:05:52] (CR) Ejegg: [C: 2] Remove some donation premium language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [16:06:07] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [16:13:27] (CR) jenkins-bot: [V: -1] Remove some donation premium language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [16:26:23] Wikimedia-Fundraising: Put payments-initial feed on wikikiosk - https://phabricator.wikimedia.org/T94127#1157170 (atgo) I don't think we'll be able to get the Dash there because of the certificate issue. Even during December we had problems keeping it up in R37 with @jgreen there. What's the payments-initial... [16:53:55] Wikimedia-Fundraising-CiviCRM, Continuous-Integration, Fundraising Tech Backlog, Scrum-of-Scrums, and 2 others: Continuous integration - CiviCRM - https://phabricator.wikimedia.org/T78100#1157260 (greg) [17:30:53] (PS4) Awight: shutdown handler to capture fatal error info [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/94087 [17:31:01] (PS5) Awight: shutdown handler to capture fatal error info [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/94087 [17:31:09] (CR) Awight: "Good call!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/94087 (owner: Awight) [17:32:50] (CR) Awight: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [17:35:56] xxxxxxcdgu [17:36:13] b -Mari [17:36:45] hgh hzz94087 [17:38:47] heheh [17:39:42] bhgbgezx [17:39:45] EOT [17:41:17] EOF? [17:42:42] (PS3) Ssmith: Delete some unused stuff [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199802 (owner: Ejegg) [17:42:49] (CR) Ssmith: [C: 2] Delete some unused stuff [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199802 (owner: Ejegg) [17:44:50] (Abandoned) Ssmith: Fix positioning of amt per second chart [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199759 (owner: Ssmith) [17:46:15] (CR) Ssmith: [C: 2] Don't lint dist/ if it exists [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200079 (owner: Ejegg) [17:46:34] (Merged) jenkins-bot: Delete some unused stuff [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199802 (owner: Ejegg) [17:48:55] (PS2) Ssmith: Add node.extend [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200091 (owner: Ejegg) [17:49:01] (CR) Ssmith: [C: 2] Add node.extend [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200091 (owner: Ejegg) [17:49:29] (PS3) Ssmith: Define common filters in one file [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200092 (owner: Ejegg) [17:58:12] (Merged) jenkins-bot: Add node.extend [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200091 (owner: Ejegg) [17:59:51] ejegg|bike: are you still on your bike? [18:00:05] that is a long bike ride [18:00:14] you must be so tired [18:00:31] and maybe in another state by now [18:01:06] heh. stopping at a couple stores too [18:01:30] I saw you were on your bike yesterday [18:01:41] so this may be a separate bike ride [18:01:44] :p [18:02:05] anyway, a couple questions about shared filtering whenever you have a chance, no rush or anything [18:02:44] sure! 10 min and i'll be on a real kbd [18:04:32] (CR) Ssmith: [C: 2] "This is awesome!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200092 (owner: Ejegg) [18:09:49] hey pizzzacat do you know if we have lunch during our lunch meeting? [18:10:12] atgo: I have not heard of such things [18:10:24] I was thinking to go grab a pastry beforehand [18:10:30] because I didn't have breakfast [18:10:34] and I don't wanna get hangry [18:13:21] * awight thumbs-up neologism [18:13:42] atgo wanna go with? [18:34:10] AndyRussG|mob: Hum. You going to make the meeting today? [18:34:52] Coming [18:48:51] awight you are frozen [18:49:01] So sad. You were just getting going, too. [18:50:17] awight: I think you're alive again. [20:05:12] Is it standup? [20:14:23] ejegg: fwiw, I used jquery.ui.datepicker in CentralNotice and was happy with the result. [20:18:17] awight: cool. I think there's a bootstrap one too if we want to use more of that lib [20:20:21] I think the caveat was, if you want a time picker you're SOL. [20:20:36] Tangent... does Dash support i18n? [20:20:45] not so much yet [20:20:57] k. Yeah we'd need to have a use case first, eh? [20:21:02] yep [20:48:21] awight would you be willing to sit down with me next wednesday to go through the forms stuff for donation interface? [20:50:16] pizzzacat: sure! [20:50:54] Did u see that I pinpointed "lightncandy" as the Handlebars implementation used in mw-core? [20:51:35] (CR) Ejegg: "doing the gerrit hokey pokey" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [20:52:04] I did not! [20:52:08] Oh actually, it's mustache and handlebars. /me reads about what that means [20:52:14] yes :) [20:52:16] handlebars > mustache? [20:52:27] handlebars is built over mustache [20:52:33] I see... [20:53:07] One thing I ran into with this templating language IIR, is that expressions within a loop can't address variables in the enclosing scope. [20:53:25] Hopefully that's no longer a thing. [20:54:11] This sounds related, "Handlebars deviates from Mustache slightly in that it does not perform recursive lookup by default. The compile time compat flag must be set to enable this functionality. Users should note that there is a performance cost for enabling this flag. The exact cost varies by template, but it's recommended that performance sensitive operations should avoid this mode and instead opt for explicit path references." [20:54:17] meh. [20:54:51] (CR) Ejegg: [C: 2] "Aargh, submit button is still missing!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [20:54:57] lol [20:55:38] o right, automatic submit there [20:56:09] surprise! [20:56:38] Yeah I want to copy those Gerrit permissions from the DonationInterface repo to elsewhere, but the lack of a safety disconnect gives me pause. [20:57:13] jenkins-bot SPOF [20:57:21] * awight shudders at the thought of fighting Gerrit on a dank December night [21:00:28] (CR) Ejegg: [C: 2] "Sufficiently alarmist!" [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/94087 (owner: Awight) [21:05:33] (Merged) jenkins-bot: Remove some donation premium language [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200089 (owner: Awight) [21:07:57] hey can someone "mention" me? testing out notification settings [21:07:57] * awight burns a pile of T-shirts [21:08:08] atgo: atgo [21:08:12] YAY! [21:08:15] :p [21:08:21] what did u change? [21:08:23] no more dings, yes to notifications [21:08:30] growl? [21:08:36] yes? [21:08:40] pick your poison :p [21:08:43] i think that's how they go [21:08:50] congrats! [21:10:12] (CR) Ejegg: "Looks good! Might have the wrong batch number error message" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198157 (https://phabricator.wikimedia.org/T91667) (owner: Awight) [21:10:44] thank you [21:10:47] it's a proud day, here in the office [21:11:18] quiet though [21:11:26] Friday usually are [21:11:42] ^s [21:11:47] back in a bit [21:11:51] Did Wikibugs die? [21:12:06] AndyRussG: it no longer matches our sprint names... [21:12:28] Ah hmmm [21:12:32] Plays music? [21:12:32] AndyRussG: u can +/- 1 to raise eyebrows if you want? https://gerrit.wikimedia.org/r/#/c/199665/ [21:12:50] "give us all the ding" [21:14:26] Hmm lemme try [21:14:28] ding dong [21:14:38] (PS1) AndyRussG: Special:CentralNotice: code cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) [21:15:13] OOh, exciting! [21:19:47] Well, it's not really much yet [21:21:02] (CR) Awight: "Looks great at a glance! I'll dig further..." (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:23:19] (PS4) Awight: Set up rules for hand-keyed contributions made by Engage staff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198157 (https://phabricator.wikimedia.org/T91667) [21:23:49] (CR) Awight: "Danger danger, Will Robinson!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198157 (https://phabricator.wikimedia.org/T91667) (owner: Awight) [21:25:53] (PS2) AndyRussG: Special:CentralNotice: code cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) [21:26:23] awight: didja see the CR of ur poof Special:BannerRandom patch? [21:26:51] (apologies for bugging) [21:27:11] No, thanks for the nudge! [21:27:39] hey AndyRussG! did you see this come in? https://phabricator.wikimedia.org/T94151 [21:28:04] is this related to some patches in review? https://phabricator.wikimedia.org/T86092 [21:29:33] atgo: yes and yes :) [21:30:03] cool, thanks! do you want to reply/close/collapse them or should I deal with it? [21:30:29] § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, § Fundraising Sprint Devo, § Fundraising Sprint the Cure, and 3 others: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1158340 (AndyRussG) [21:31:19] atgo: it's OK. The new Phab task was added by zeljkofilipin following our call this morning [21:31:26] Just added it as a blocking task for the other one [21:31:39] We just have to make iphone browser tests run via Jenkins [21:32:50] folks, I'm off early this evening (EST time evening) and back later (more or less PST evening), hope that's OK :) [21:33:41] (CR) AndyRussG: Special:CentralNotice: code cleanup (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:34:00] (PS6) Awight: Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 [21:35:42] (CR) Awight: "Thanks for catching these! I agree that we should leave Special:BannerRandom replying with a status 410." (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [21:40:28] cool :) [21:42:23] cya later, all :) [21:43:09] Bye! [21:45:51] (PS7) Awight: Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 [22:07:41] (CR) Ejegg: [C: 2] Set up rules for hand-keyed contributions made by Engage staff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198157 (https://phabricator.wikimedia.org/T91667) (owner: Awight) [22:08:51] (Merged) jenkins-bot: Set up rules for hand-keyed contributions made by Engage staff [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/198157 (https://phabricator.wikimedia.org/T91667) (owner: Awight) [22:20:16] (CR) Ejegg: [C: 2] "Good to have! Plenty of rejected chunks trying to apply this to 4.4, though. Is the next step to try to resolve those, or something more" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/196021 (https://phabricator.wikimedia.org/T77910) (owner: Awight) [22:21:27] Wikimedia-Fundraising-CiviCRM, Fundraising Sprint H, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: Upgrade Civi to 4.4 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1158551 (atgo) [22:22:00] hey ejegg pizzzacat i sent out another version of notes [22:22:15] thanks atgo! Taking a look [22:24:27] notes look good to me, atgo [22:24:34] thanks! [22:24:43] once pizzza is back online and confirms i'll send :) [22:30:27] (CR) Awight: "I wish I had anything clever up my sleeve, but I think it's a manual merge as usual. The idea of having our changes as a patch was to hel" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/196021 (https://phabricator.wikimedia.org/T77910) (owner: Awight) [22:48:41] i got a shell on boron, but i would like root for debugging monitoring. i keep forgetting how to because i just need it every couple months [22:52:35] mutante: prolly holler at Jeff_Green, and he can splash the holy water around. [22:53:06] awight: alright, will do [22:53:47] mutante: and thanks for the attention to our cluster! [22:54:17] awight: yw, i'm trying to fix https://phabricator.wikimedia.org/T89983 [22:55:26] Ooh, looks useful. [22:56:00] https://icinga.wikimedia.org/cgi-bin/icinga/status.cgi?host=boron&nostatusheader [23:19:21] i found the password and got access now [23:21:37] * awight waits for the fire alarm to go off [23:21:52] Wikimedia-Fundraising, Fundraising-Backlog, Epic: Integrate processing in LATAM - https://phabricator.wikimedia.org/T77907#1158868 (atgo) [23:32:24] hey awight did you ever get your phabricator thing worked out re: https://phabricator.wikimedia.org/T93671 [23:32:51] No :( [23:33:48] It's... good to know that my accounts are not in order, I'll loop around to deal with this. [23:50:21] ok ladies and gents, i'm headed out for the evening / weekend. [23:50:27] Have a good one, all!