[16:58:26] !log updated crm from 4c459f3dbf3c3466cdc26a351ba589f4f1aef587 to 0e4a6ed961ca5a5882d42949c12f74c1d246b55e [16:58:31] Logged the message, Master [17:03:29] Wikimedia-Fundraising-CiviCRM, Continuous-Integration: Disable job on CRM deployment branch - https://phabricator.wikimedia.org/T94586#1167487 (awight) NEW a:awight [17:10:09] (PS1) Awight: Correct role name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/200887 [17:10:54] ejegg: have a second? ^^ [17:10:59] sure! [17:11:56] (CR) Ejegg: [C: 2] "Not that other Engage" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/200887 (owner: Awight) [17:16:10] (CR) Awight: [V: 2] Correct role name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/200887 (owner: Awight) [17:19:26] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/200890 [17:19:42] (CR) Awight: [C: 2 V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/200890 (owner: Awight) [17:20:11] !log update crm from 0e4a6ed961ca5a5882d42949c12f74c1d246b55e to b4268a60225ae11f2c2b58d3b1f1c44e282f9ec6 [17:20:17] Logged the message, Master [17:32:04] (CR) Awight: "Are u going to mention that this patch closes like 4 bugs?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200766 (https://phabricator.wikimedia.org/T90501) (owner: Ejegg) [17:32:26] :p [17:36:32] (CR) Ejegg: "Well, gets started on a few of em anyway! I wouldn't consider the forms or the transactions anywhere near done." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200766 (https://phabricator.wikimedia.org/T90501) (owner: Ejegg) [17:36:46] thanks! [18:31:12] hi pizzzacat! [18:34:47] oh hi! [18:36:47] (PS1) Awight: Revert "Correct role name" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/200911 [18:36:49] (PS1) Awight: Revert "Set up rules for hand-keyed contributions made by Engage staff" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/200912 [18:37:01] (CR) Awight: [V: 2] Revert "Set up rules for hand-keyed contributions made by Engage staff" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/200912 (owner: Awight) [18:37:10] (CR) Awight: [C: 2 V: 2] Revert "Correct role name" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/200911 (owner: Awight) [18:37:22] (CR) Awight: [C: 2] Revert "Set up rules for hand-keyed contributions made by Engage staff" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/200912 (owner: Awight) [18:39:03] !log rollback crm from b4268a60225ae11f2c2b58d3b1f1c44e282f9ec6 to 59f03df6b689ef443cc7b7e31e6f5b2986bc8bc9 [18:39:11] Logged the message, Master [19:49:43] (PS1) Ejegg: WIP add Astropay to DonationInterfaceFormSettings [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200988 (https://phabricator.wikimedia.org/T90505) [19:50:32] (CR) jenkins-bot: [V: -1] WIP add Astropay to DonationInterfaceFormSettings [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200988 (https://phabricator.wikimedia.org/T90505) (owner: Ejegg) [20:16:13] (PS1) Legoktm: jenkins job validation, do not submit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/201002 [20:17:34] hey K4|lunchly https://phabricator.wikimedia.org/T94506 [20:17:36] and ejegg [20:19:51] (CR) jenkins-bot: [V: -1] jenkins job validation, do not submit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/201002 (owner: Legoktm) [20:22:17] (Abandoned) Legoktm: jenkins job validation, do not submit [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/201002 (owner: Legoktm) [20:23:10] atgo: grabbing that bug. Also checking whether the campaign is disabled for Catalan speakers. [20:23:28] they didn't turn it off as a result of this [20:24:09] Okay, at least it's not emailing in Castillian. [20:24:19] That would chafe... [20:24:25] :P [20:27:38] derp. spent half an hour last night figuring out needed to set $wgDonationInterfaceEnableAstropay = true; to get the form to appear. Switched to other compy today and spent another half hour realizing the same thing [20:27:48] aww haha [20:31:29] ejegg: that magic is so musty. [20:32:01] Also: you have to assign some of the globals *before* requiring DI.php, no? [20:32:21] yup. [20:33:21] T94477: DonationInterface config should be less of a snowflake. [20:39:40] yah, and i should sync My [20:40:18] dev environment [20:49:53] atgo: hey, LMK anytime u'd like to talk about evil UI plans for CN [20:50:00] mua ha haaaa [20:50:03] ok.. give me a few minutes :) [20:50:13] want to say 230 or is that too late for you? [20:51:09] AndyRussG: ^ [20:51:48] atgo: sure, np! later is also fine, BTW, whatever's good :) [20:52:13] ok. i'd like to gather ze thoughts a bit for a sec [20:55:21] K [21:48:59] Oh man. A code task got me giggling *with* the author. [21:49:09] Usually I just go "lol no". [21:49:28] * awight subscribes [21:49:44] Yeah man... hang on, you'll like this one. [21:50:04] I'll sneak you their github link if I can find the thing again. [21:50:42] K4-713: btw. Do you remember when pizzzacat defeated the code task? That was magnificent. [21:50:57] I still have that. [21:50:58] Yes. [21:51:08] 100% Agree. :) [21:51:40] gave that thing a cold-ass Vulcan death grip... [21:53:47] That is what I look for in colleagues. [22:07:40] (PS1) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) [22:08:52] Wikimedia-Fundraising, Astropay Integration, Fundraising-Backlog, Fundraising Sprint Grandmaster Flash, Patch-For-Review: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1168536 (Ejegg) a:Ejegg [23:03:04] here is a song that I think you all will enjoy. paste into your cmdline: [23:03:11] say -v Cellos "mom do you have any cash I need to go to the store and buy some hot pockets it's an emergency mom" [23:03:31] (bolded from me searching it in my twitter oops) [23:04:50] say: command not found :( [23:05:06] * ejegg tries apt-get [23:05:38] dang really? [23:05:47] :'( [23:06:30] i can cowsay it [23:06:42] but that just makes ascii art [23:10:13] how do you cowsay? [23:11:43] you have to install cowsay first [23:11:46] btw everyone, some more important news: Anne showed me this cool site that is our cat of the day: http://catcordion.sergethew.com/ [23:14:08] ohh ejegg I feel like I need to [23:14:33] Thank you [23:14:35] ohh we have a cowsay on our fundraising data page! [23:14:44] didn't realize that was a thing [23:16:56] Wikimedia-Fundraising, MediaWiki-Vagrant, Fundraising Sprint Grandmaster Flash, Patch-For-Review: Vagrant Fundraising role needs to be able to run a specific MediaWiki branch - https://phabricator.wikimedia.org/T78739#1168771 (mmodell) awight: additional port forwarding isn't needed - you simply m... [23:18:39] hey awight [23:18:54] are we stripping language for allll catalan donors on GC? [23:19:45] atgo: yep. I saw one or two exceptions, probably caused by breaking the workflow [23:19:49] hm [23:19:55] so we need to contact GC about this? [23:19:59] in order to fix it? [23:20:00] I'm working on a fix, as soon as I can reproduce locally. [23:20:01] No [23:20:02] oh ok [23:20:04] cool [23:20:06] it's all on our side :( [23:20:13] awwwww [23:20:23] well that's a bummer, but it also means it's actually probably fixable! [23:20:24] This has been happening for any language not on the list I linked to... [23:20:38] oh no [23:20:39] :( [23:21:17] can we not.. add to that list? [23:21:42] no, these are the languages that GC translates for [23:22:29] It's fine that we figure out that GC doesn't speak the donor's language, the problem is that we're saving this fallback language into the contribution_tracking table. [23:23:51] awight are we still on branch REL1_23 for DI? [23:24:11] pizzzacat: Yeah, but we're upgrading soon. [23:24:20] ooh how soon? [23:24:33] Lmk if that becomes problem? [23:24:54] Is this about the lightncandy library being available? [23:25:07] awight are you talking to me? [23:25:20] pizzzacat: yes :p [23:25:35] Just wondering what an upgrade will help with. [23:25:35] ha ok. um I just wanted to be able to start from whatever is our freshest branch [23:25:49] I don't need to use the templating just yet [23:26:07] oh, I see. DonationInterface is on master, and the payments wiki code is at fundraising-REL1_23 [23:26:09] but if things will significantly change I'd love to know when [23:26:47] oh I see I asked the wrong question. DI is not a part of that derp [23:27:11] but good point on the discussion earlier about being able to use handlebars/mustache [23:29:06] pizzzacat: I did look into that, and fyi the templating engine used in MediaWiki core is this one specifically: https://github.com/zordius/lightncandy [23:29:49] ah cool, thanks awight, looking at it now [23:30:17] I can put the rendering thing together sooner rather than later, if it helps you prototype forms. [23:31:23] awight if that sounds fun for you, that would be awesome! or we could wait until prawning to see what would be best? [23:31:51] (PS1) Ejegg: Merge remote-tracking branch 'origin/REL1_23' into fundraising/REL1_23 [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/201067 [23:31:54] Yeah I'd love to get some momentum on this, then suddenly take a vacation :) [23:32:46] yeehaw [23:33:05] speaking of starting things and disappearing, i'mma just leave that patch merge in review and sign off for an hr or two [23:33:12] :P [23:33:32] aggressive :)