[00:00:13] AndyRussG: I've never noticed that before. It looks horrific. [00:00:33] I think it was another unfulfilled intention [00:01:34] It seems to do things... But in a bad way. [00:05:55] (PS4) Awight: Fix unstaging issue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201382 (https://phabricator.wikimedia.org/T94506) [00:11:35] (CR) Awight: Special:CentralNotice: code cleanup (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:11:57] (PS5) Awight: Special:CentralNotice: code cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:12:02] (CR) Awight: [C: 2] Special:CentralNotice: code cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:12:44] (PS5) Ejegg: Simplify communication_type nonsense [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201635 [00:13:10] (CR) Awight: Special:CentralNotice: code cleanup (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:13:24] awight: my "CN code cleanup wishlist" grows... [00:13:47] AndyRussG: Careful of leverage on that thing... It could become too heavy for a laptop. [00:14:17] (Merged) jenkins-bot: Special:CentralNotice: code cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/200236 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [00:14:58] Oooh! C'est l'heure de souperrrrrrrrr [00:15:05] enjoy! [00:15:11] Thx! :) [00:16:28] (CR) Ejegg: "Flexibility restored" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201635 (owner: Ejegg) [00:16:42] (CR) Awight: [C: 2] "Awesome." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/197205 (owner: Ejegg) [00:16:45] (Merged) jenkins-bot: Add timeout param to limit query lifespan [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/197205 (owner: Ejegg) [00:16:50] (CR) Ejegg: Simplify communication_type nonsense (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201635 (owner: Ejegg) [00:17:36] Wikimedia-Fundraising, Fundraising Sprint House of Pain, MediaWiki-Vagrant, Fundraising Sprint Grandmaster Flash, Patch-For-Review: Vagrant Fundraising role needs to be able to run a specific MediaWiki branch - https://phabricator.wikimedia.org/T78739#1184424 (awight) [00:34:02] (CR) Awight: [C: 2] Simplify communication_type nonsense (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201635 (owner: Ejegg) [00:35:48] (PS11) Awight: Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 [00:36:44] (CR) jenkins-bot: [V: -1] Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [00:40:02] (PS12) Awight: Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 [00:41:02] (Abandoned) Awight: WIP Don't overwrite normalized data with unstaged [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201318 (owner: Awight) [00:41:04] (CR) jenkins-bot: [V: -1] Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [00:41:41] (PS13) Awight: Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 [00:48:00] awight: off the top of your head, can you think what setting makes a lot of tests might fail with bogus 'untranslated messages present' due to escaped angle brackets? [00:48:30] in DonationInterface, that is [00:49:21] s/might// [00:49:31] (Merged) jenkins-bot: Simplify communication_type nonsense [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201635 (owner: Ejegg) [00:50:28] (PS9) Ejegg: Add skeleton of Astropay gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200766 (https://phabricator.wikimedia.org/T90501) [00:51:04] (CR) Ejegg: Add skeleton of Astropay gateway (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200766 (https://phabricator.wikimedia.org/T90501) (owner: Ejegg) [00:51:12] ejegg: no... [00:51:19] maybe $wgContLang is screwy? [00:51:28] thanks, I'll check it out [00:51:34] Maybe an i18n.php shim is damaged? [00:51:49] don't think so - that'd show in git status [00:52:11] it's escaping angle brackets on legit html tags for some reason [00:52:22] guessing it's a safety feature run amok [00:52:38] i'll compare settings with my other machine when i get home [00:53:59] $wgRawHtml ? Now I'm really throwing out wild guesses. [00:54:45] ejegg: When you find the screwy config, let's setMwGlobals in DonationInterfaceTestCase setUp, to make tests insensitive to local config. [00:54:53] good one! But plz don't distract yrself about it. sure I'll find it in comparing localsettings or php.ini [00:55:05] ooh, also a good call [00:55:22] Certainly sounds fun. I've seen that error for sure, but I think it was caused by actual untranslated messages :) [00:55:26] What patch is this? [00:55:35] I can run locally to confirm that it's your config. [00:56:01] it's happening in all branches for me (incl master), so I know it's local [00:56:18] ah [00:57:33] $wgLanguageCode = 'aa' didn't cause any failures for me. [00:57:40] awight: ever played with 'mosh' ? [00:58:04] noo... [00:58:20] mobile shell, persists across changing connections and predicts what keystrokes will do when there's high latency [00:58:56] Weird! I'm very happy using byobu, but I like getting occasional bleeding-edgecuts [00:58:59] pretty nifty stuff, and supported by my new favorite android ssh client [00:59:16] You... should not be doing that :p [00:59:16] juicessh [00:59:25] just enjoy the snow [01:00:18] heh, it's nice to use a dumb old tablet as an irc screen when out in the world [01:01:22] ejegg: I get 7 failures related to translation stuff when I comment out $wgDefaultSkin = "vector";, but not the exact error you reported. [01:01:42] weird [01:02:36] Maybe your mw-core version is screwy? [01:03:00] nah, just updated [01:03:25] maybe that's it :p [01:03:34] you should be on origin/fundraising/REL1_23 ... [01:03:48] i'm not gonna waste any more time poking at it without my working instance to compare. [01:03:50] k [01:04:04] heh, too bad they don't run our CI under that branch [01:04:07] ejegg: what's your favorite Android ssh client? [01:04:19] AndyRussG: JuiceSSH [01:04:34] ejegg: mmm K cool! noted :) [01:04:52] fav terminal? Not stock android, I assume...? [01:05:31] it has a good set of shortcuts for all the keys you don't get, and lets you use your predictive keyboard (tho that feature's kinda hidden) by swiping the shortcut bar to the side [01:06:26] AndyRussG: I don't find much need for a local terminal [01:06:34] Ah hmm! [01:06:37] what do you end up using it for? [01:06:43] (CR) Awight: Add skeleton of Astropay gateway (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200766 (https://phabricator.wikimedia.org/T90501) (owner: Ejegg) [01:07:14] I installed Debian (Lil' Debian) alongside Android on the phone [01:07:26] From there I could apt-get install git review [01:07:26] ejegg: Erp. PS9 is a rebase + new work... [01:07:39] Wat. [01:07:43] awight: sorry to combine! [01:07:45] I'm a bit wary of putting a wikitech key on the phone tho [01:08:04] (CR) Awight: [C: 2] Add skeleton of Astropay gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200766 (https://phabricator.wikimedia.org/T90501) (owner: Ejegg) [01:08:08] yeah, I just use mine to connect to a non-priv account on my vps for irc so far [01:08:26] Hmmm that makes sense [01:08:34] As long as bluetooth discovery is turned off :-x [01:08:40] Life pro tip: don't drive and code review [01:09:10] I guess "cruise control" isn't a gerrit thing [01:09:27] (Merged) jenkins-bot: Add skeleton of Astropay gateway [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200766 (https://phabricator.wikimedia.org/T90501) (owner: Ejegg) [01:10:03] Thanks for all the feedback awight! [01:10:29] I'mma sign off for now. Have a wonderful evening all. [01:10:33] See ya! [01:11:51] ejegg|away: bye! [01:12:41] awight: I think it's an undocumented command-line option [01:13:08] https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Miscelaneous_doc_bits [01:14:23] hehe [01:15:21] git review -R --cruiseControl [01:15:45] ------------ bla bla no hooks.msg found, please add Change-Id manually ---- crash! [01:15:59] ow, the coffee burns! [01:16:28] coffee filter turned airbag [01:21:08] awight: coool thanks! https://phabricator.wikimedia.org/T95254 [01:21:35] Thanks for doing that! I also made a note about the cache TTLs on the Notes subpage... [01:25:13] awight: yeah I just saw, thanks much :) [01:25:48] Now I'm listening to "TTL" https://www.youtube.com/watch?v=NFFgRRLInD4 [01:31:21] man that Special:BannerRandom ended up being way complicated [01:38:21] awight: I just want to fix one comment in the bannerRandom patch... I know it's late there, if you still have a sec to write an "I approve" comment WRT my change (coming in a sec) I'll +2 the whole thing, does that make sense? [01:40:41] AndyRussG: ues [;ease! [01:40:44] whoa [01:40:48] : yes please! [01:40:54] off-by-one digit issue [01:41:26] thx! yeah wrist placement rebellion [01:41:30] it happens [01:43:51] (PS14) AndyRussG: Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [01:45:02] (CR) Awight: [C: 1] "@AndyRussG: good catch! I approve :)" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [01:48:04] (CR) AndyRussG: [C: 2] "\o/ w00t!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [01:48:32] weee fireworks [01:49:14] I feel like I should deploy this stuff, so we can see how it works on prod, before adding the new [01:51:22] (Merged) jenkins-bot: Remove server-side banner random [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/190239 (owner: Awight) [01:54:46] (PS1) Awight: Fix stupid casting mistake [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/202306 (https://phabricator.wikimedia.org/T91667) [02:03:40] (Abandoned) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/198267 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [02:06:10] (PS1) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [02:10:08] (PS1) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 [02:11:04] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (owner: AndyRussG) [02:13:29] (PS2) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 [09:01:57] Wikimedia-Fundraising, Fundraising Sprint House of Pain, MediaWiki-Vagrant, Fundraising Sprint Grandmaster Flash, Patch-For-Review: Vagrant Fundraising role needs to be able to run a specific MediaWiki branch - https://phabricator.wikimedia.org/T78739#1184984 (awight) A small correction to the l... [11:56:11] Wikimedia-Fundraising-CiviCRM: several fundraising user client SSL certificates expiring 2015-04-15 - https://phabricator.wikimedia.org/T95200#1185258 (Aklapper) [13:24:24] In 5 minutes barium is going down for disk swap [13:32:12] barium is going down for a few minutes [15:24:56] (CR) Mattflaschen: "This caused lint failure in production. This repository should lint PHP files. We don't yet use 5.4:" (1 comment) [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [15:38:11] (CR) Ejegg: "Dang, core/vendor requires the same version of psr/log as we do, but it looks like they delete LoggerTrait.php before they check it in for" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:17:34] (CR) Mattflaschen: "> Dang, core/vendor requires the same version of psr/log as we do, but it looks like they delete LoggerTrait.php before they check it in f" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:23:52] (CR) BryanDavis: Add Monolog and PSR\Logger (2 comments) [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:26:47] (CR) BryanDavis: Add Monolog and PSR\Logger (1 comment) [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:47:01] (PS1) Ejegg: Update Monolog to 1.12.0 [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/202432 [16:48:25] (PS1) Ejegg: Remove trait files that break linting [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/202433 [16:53:24] (PS1) Ejegg: Update required version of Monolog to 1.12.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202436 [16:57:12] (CR) Ejegg: Add Monolog and PSR\Logger (2 comments) [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/192380 (https://phabricator.wikimedia.org/T86266) (owner: Ejegg) [16:57:17] (CR) Legoktm: "Maybe I'm missing something, but why does DonationInterface need its own vendor repository that just duplicates mediawiki/vendor?" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/202432 (owner: Ejegg) [16:59:17] ops-fundraising, operations, ops-eqiad: barium has a failed HDD - https://phabricator.wikimedia.org/T93899#1186561 (Cmjohnson) The disk that failed was an add-on of a 3TB disk and not covered under warranty. We do not have any 3TB disks on-site to swap out and will need to order more. [17:01:05] (CR) Ejegg: "Two reasons: We use some of DonationInterface under Drupal to process recurring donations (see WmfFramework wrappers for mediawiki functio" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/202432 (owner: Ejegg) [17:01:27] ops-fundraising, operations, ops-eqiad: barium has a failed HDD - https://phabricator.wikimedia.org/T93899#1186565 (Cmjohnson) The disk that failed was an add-on of a 3TB disk and not covered under warranty. We do not have any 3TB disks on-site to swap out and will need to order more. https://rt.wik... [17:35:50] hey ppena - i just got my first chip & pin card :P [17:36:47] atgo wow! you are in the future now! [17:39:16] it's a bright place, people [18:09:45] hey ejegg|biab when you're back - ping me? [18:12:37] ppena http://www.unixtimestamp.com/ [18:12:58] What's up atgo? [18:14:12] so i totally blanked - there is a call scheduled with Amazon to get a sense of the scope of work to upgrade to their new thing [18:14:19] would you be available at 5pm EST? [18:14:25] i think ijust accidentally sent you like 4 invites :P [18:14:34] When? [18:14:47] Oh, lemme check [18:15:41] sure,should be fine [18:16:53] also... ccogdill has a complicated sql question, will you have time tomorrow before you head out on vacation to maybe help her out? or are you swamped... [18:17:13] thanks!! [18:18:35] Definitely have time for sql [18:21:49] Wikimedia-Fundraising-CiviCRM: several fundraising user client SSL certificates expiring 2015-04-15 - https://phabricator.wikimedia.org/T95200#1186995 (atgo) also jvandavier is no longer working at WMF and won't need a cert. [18:22:01] thanks ejegg! ccogdill ^ [18:24:41] ejegg thank you! is now a good time? [18:26:27] Wikimedia-Fundraising-CiviCRM: several fundraising user client SSL certificates expiring 2015-04-15 - https://phabricator.wikimedia.org/T95200#1187011 (CCogdill_WMF) @Jgreen could we include my request from T95011 in this batch? Not sure if that helps expedite. [18:27:48] ccogdill: sure! [18:28:21] Fundraising-Backlog, ops-fundraising: Need Civi access for Donor Services agent - https://phabricator.wikimedia.org/T95011#1187013 (Jgreen) [18:28:53] Fundraising-Backlog, ops-fundraising: Need Civi access for Donor Services agent - https://phabricator.wikimedia.org/T95011#1187014 (Jgreen) a:atgo>Jgreen [18:50:25] Fundraising Sprint House of Pain, Fundraising-Backlog: Change legal text about recurring on all forms - https://phabricator.wikimedia.org/T94246#1187045 (atgo) a:Pcoombe @Pcoombe to let us know what the workflow is here [18:54:34] (CR) Ejegg: [C: 2] "Aw, man... Good thing (?) we're using strict comparison!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/202306 (https://phabricator.wikimedia.org/T91667) (owner: Awight) [19:02:40] (CR) Ejegg: [C: 2] "here's to more comment correctness" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197002 (owner: Awight) [19:19:39] (PS2) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [20:00:35] (PS3) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 [20:00:45] Fundraising Sprint Enya, Fundraising Sprint Flaming Lips, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, and 4 others: Configure Jenkins to run CiviCRM builds on Fundraising CI slave instance - https://phabricator.wikimedia.org/T89895#1187285 (greg) [20:00:48] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, and 7 others: Deploy CiviCRM integration job to WMF integration server - https://phabricator.wikimedia.org/T86374#1187282 (greg) [20:19:23] ejegg thanks for the tip with skyscanner! [20:24:52] yw atgo! you saw you can just put 'Everywhere' in the destination box? [20:25:55] Fundraising-Backlog, Epic: Amazon upgrade - https://phabricator.wikimedia.org/T87625#1187392 (atgo) [20:26:29] man. so cool [20:26:56] ejegg: also there ARE docs [20:27:07] but don't fret not being able to speedread them in the next 3 min [20:28:06] ah, phew! [20:30:53] :) [20:32:44] ejegg: did you get the dial in? [20:33:29] we are awaiting :) [20:52:18] Fundraising-Backlog, Epic: Amazon upgrade - https://phabricator.wikimedia.org/T87625#1187495 (atgo) [20:52:29] Fundraising-Backlog, Epic: Amazon upgrade - https://phabricator.wikimedia.org/T87625#995438 (atgo) [20:52:57] Fundraising-Backlog, Epic: Amazon upgrade - https://phabricator.wikimedia.org/T87625#995438 (atgo) [20:59:48] Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, I18n: zh-..., pt, and other language variants are not supported by CentralNotice - https://phabricator.wikimedia.org/T55641#1187536 (atgo) [20:59:52] Fundraising Tech Backlog, Fundraising-Backlog: Create Alipay-specific TY page - https://phabricator.wikimedia.org/T88700#1187537 (atgo)