[00:01:31] (PS2) Ejegg: WIP sign transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 [00:01:33] (PS7) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) [00:01:35] (PS1) Ejegg: Fix content-type for non-XML POSTs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202625 [00:03:10] (CR) jenkins-bot: [V: -1] WIP sign transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (owner: Ejegg) [01:30:32] (PS8) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) [01:32:19] (CR) Ejegg: "Thanks for the comments! TODO: fix the TestingAdapter stuff in all the other copies too." (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [01:34:29] (PS3) Ejegg: WIP sign transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 [01:35:05] (CR) jenkins-bot: [V: -1] WIP sign transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (owner: Ejegg) [02:14:37] (PS4) Ejegg: Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) [02:19:47] (CR) Ejegg: Sign Astropay transactions (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [02:42:37] (PS4) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 [05:41:30] (PS1) Ejegg: Use curl_setopt_array instead of a loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202675 [06:50:06] Fundraising Sprint Flaming Lips, Fundraising-Backlog: CCogdill should be able to kick the silverpop job - https://phabricator.wikimedia.org/T92526#1188568 (awight) [07:17:43] (CR) Awight: [C: 2] "Sure. But in the long run, let's tweak the lint rules. Or if that's not possible, fork the module and configure composer.json to pull fr" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/202433 (owner: Ejegg) [07:20:05] (CR) Awight: [C: 2] "@legoktm: and also, we include some extensions that are not included in the WMF production set. But yeah, this serves exactly the same pu" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/202432 (owner: Ejegg) [07:24:26] (CR) Awight: [C: 2] "Oh good!" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202675 (owner: Ejegg) [07:25:47] (Merged) jenkins-bot: Use curl_setopt_array instead of a loop [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202675 (owner: Ejegg) [07:34:54] (CR) Awight: "/me sets off the "WOOT" alarms..." (2 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (owner: AndyRussG) [07:48:22] (CR) Awight: WIP Campaign-associated mixins: schema update (2 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [07:50:03] (CR) Awight: WIP Campaign-associated mixins (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (owner: AndyRussG) [07:53:58] (CR) Awight: "Definitely an improvement, but I worry a bit about compatibility with all the gateways, since we're losing the text/plain default." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202625 (owner: Ejegg) [07:59:12] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Move DonationInterface test fixtures into pure data files. - https://phabricator.wikimedia.org/T95397#1188800 (awight) NEW [08:01:06] (CR) Awight: "(only skimmed)" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [08:02:55] (PS2) Awight: Update required version of Monolog to 1.12.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202436 (owner: Ejegg) [08:03:01] (CR) Awight: [C: 2] Update required version of Monolog to 1.12.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202436 (owner: Ejegg) [08:04:00] (Merged) jenkins-bot: Update required version of Monolog to 1.12.0 [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202436 (owner: Ejegg) [08:06:56] (CR) Awight: "I have a lot of respect for a language where (true == '2'). A similar sort of respect as I would have with a dull knife or a grease fire." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/202306 (https://phabricator.wikimedia.org/T91667) (owner: Awight) [08:26:33] (CR) Awight: "Backport of a mw-core 1.25 testing feature." [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/201133 (owner: Awight) [08:29:08] Fundraising Tech Backlog: Upgrade payments mw-core to something newer - https://phabricator.wikimedia.org/T94528#1188825 (awight) Woot! REL1_25 was just introduced. [08:30:03] Fundraising Tech Backlog, Technical-Debt: Upgrade payments mw-core to something newer - https://phabricator.wikimedia.org/T94528#1165770 (awight) [14:15:05] (CR) Ejegg: "That's a very young default. Prior to the communication_type patch we just merged, it was text/namevalue or text/xml." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202625 (owner: Ejegg) [16:42:41] (CR) BryanDavis: ""Soon" we will have PHP5.4+ on all the misc servers and can drop the PHP5.3+ restrictions that we have on Jenkins. See T87036" [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/202433 (owner: Ejegg) [16:58:12] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1190458 (RLewis) @atgo and @awight the import worked for March 2015. but I'm not e... [17:12:10] (PS2) Awight: Fix content-type for non-XML POSTs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202625 (owner: Ejegg) [17:12:19] (CR) Awight: [C: 2] "OK, thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202625 (owner: Ejegg) [17:17:54] (Merged) jenkins-bot: Fix content-type for non-XML POSTs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/202625 (owner: Ejegg) [17:25:08] awight: BTW thanks 4 the CR! [17:25:16] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Wikimedia-Fundraising, MediaWiki-Vagrant, Patch-For-Review: Vagrant Fundraising role needs to be able to run a specific MediaWiki branch - https://phabricator.wikimedia.org/T78739#1190568 (awight) [17:28:55] awight: ...also.. so you think we can forgo the norm of having code work with or without the schema change? That's all the schema check is about, as I think we've done for previous schema updates... [17:30:27] of course! [17:30:37] why forgo the norm though? [17:30:52] It goes so well with a deployment sandwich... [17:31:53] In case the tomato flies out on the first bite ;p [17:32:23] Since u commented that we can assume the schema is good... [17:33:03] What is the benefit in writing the code in this more dynamic way? [17:33:52] The rule I thought was to make the code so that it wouldn't break even if the schema update hasn't gone thru [17:33:54] Holy cow-- a surprise metrics meeting? [17:34:50] and it's about us! [17:35:33] awight: and it's exactly at the same time as the interview [17:35:50] (11 am your time) [17:37:21] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Wikimedia-Fundraising, MediaWiki-Vagrant, Patch-For-Review: Vagrant Fundraising role needs to be able to run a specific MediaWiki branch - https://phabricator.wikimedia.org/T78739#1190616 (awight) [17:39:16] awight: I guess you don't want us to move the interview with Casey so we can be on call during metrics? I don't really know what's being presented, just that it's FR-y [17:39:18] Almost. I think the rule is, write it so that there's no way to screw up the deployment. [17:39:40] AndyRussG: IMO it's way more important to respect C's time [17:39:55] awight: K sounds good [17:39:58] "Fundraising" doesn't mean fr-tech, apparently, or hopefully we'd know [17:40:06] yeah... [17:40:26] that will be an amusingly short meeting, otherwise :D [17:40:42] Mmmm... [17:41:21] hiii [17:41:28] atgo: hey :) [17:41:59] atgo: ejegg and I have an interview at the same time as metrics [17:42:31] oh nooooo!! that's awful. i'm sorry :( [17:42:38] probably too late to reschedule, huh? [17:42:49] np :) yeah it seems [17:43:08] metrics is FR-y but not -tech-y? [17:43:20] so... the theme is "data driven" and we are the primary/main team [17:43:33] so it's mostly going to be the slides from the report that went out a few weeks ago [17:43:36] consolidating all the research [17:43:39] Megan is presenting [17:44:07] Ah OK [17:44:19] and by we, yes mostly fundraising [17:44:39] "proper" [17:48:30] sorry got booted there for a sec [17:49:11] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1190679 (awight) @RLewis: yes! Thank you for the detailed report, I'll try to make... [17:54:24] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1190710 (atgo) @awight should we make a separate task for that and maybe try to get... [19:33:12] (PS3) Awight: Require the php-queue library [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/198438 (https://phabricator.wikimedia.org/T92916) [19:33:32] (PS3) Awight: WIP New DonationQueue shim around php-queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [19:38:45] (CR) jenkins-bot: [V: -1] WIP New DonationQueue shim around php-queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [19:39:22] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1191461 (awight) @atgo: agreed, I think we can lower to Normal priority. At least,... [19:41:04] Fundraising Tech Backlog: Upgrade payments mw-core to something newer - https://phabricator.wikimedia.org/T94528#1191462 (awight) [19:44:12] (Abandoned) Awight: Clean up database switching [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197745 (https://phabricator.wikimedia.org/T92000) (owner: Awight) [19:56:34] (PS4) Awight: New DonationQueue shim around php-queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [19:57:00] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Use the new queue wrapper for adding messages to the queues - https://phabricator.wikimedia.org/T92921#1191505 (awight) Unblocked. [20:12:56] AndyRussG|school: ejegg: pizzzacat: The FR presentation was really good, sorry you missed it! [20:14:03] Looks like the recording worked, https://www.youtube.com/watch?v=To4HLZSrp0Y -- also, the videography done in our new space was awesome. [20:15:27] AndyRussG|school: sorry to get distracted earlier. As I understand the guidelines, we want to make any single commit safe to deploy, so generally we avoid mixing things like schema migration and dependent code. [20:16:46] But as long as they're in separate commits, and it's safe to deploy in phases, we don't need to support patches being deployed in the wrong order. [20:17:12] I guess the interesting-getting comes in when we have to rollback in production. [20:18:34] In the WIP mixins case, even without the dynamic schema assertion, we can revert by undeploying using the same steps as deployment but backwards. This gets scary to think about :) [20:23:06] awight: thanks for the link! taking a look [20:26:12] awight: np! Yeah I'll watch metrics a bit later... WRT the schema change, I think you're right, I'm taking things too literally [20:26:45] Here is "by the book": https://wikitech.wikimedia.org/wiki/Schema_changes and https://www.mediawiki.org/wiki/Development_policy#Database_patches [20:27:23] Without the schema check, there should be no issues w/ rolebak [20:28:03] I'm thinking the JS might be more flexible, tho, due to the infinite caching issues we've seen [20:32:26] True, the same principle applies everywhere. JS rollback is a lot laggier though, so we'll encounter... either 3 or 4 of the 4 possible combinations of a client+server tope [20:33:13] *toe-pay [20:35:56] mmm} [20:36:08] a wig for your toe? [20:36:27] or the latest financial product from nike? [20:37:09] http://www.wordreference.com/es/en/translation.asp?spen=tope ? [20:37:23] heh [20:37:58] Like Apple pay for people who walk around on their hands all day [20:38:47] doorstop. client-server doorstop. [20:39:22] wow, the word it carries a lot more baggage than I thought. I meant, http://i136.photobucket.com/albums/q164/alexk32/Mexico2009010.jpg~original [20:39:55] A speedbump we're setting for ourselves, to make things more hilarious when we need to roll back [20:40:50] Ah great point, interesting! [20:41:23] Yeah I don't recall having backed up over those too often [20:41:30] They're bad for low-riding cars, tho [20:42:25] just don't use the spikes they have at rental car lots [20:46:34] Which spikes? [20:52:52] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Failed iframe liberation can make it impossible to retry a donation - https://phabricator.wikimedia.org/T95475#1191695 (awight) NEW [20:52:53] AndyRussG: usually at the entrance, things that you /can't/ roll back over without popping your tires. [20:53:29] Heh never seen those! Maybe I should look before backing up tho [20:53:39] Good habit to be in :p [20:54:11] or carry a sheet of plywood in the trunk if you do plan to roll back... [20:54:41] Hmmm we should add that to the doc somewhere... Don't forget your plywood in case of rollback :) [20:54:47] I thought at first you meant these: http://crosspalms.com/wp-content/uploads/2010/08/spikes.jpg [20:54:48] awight: I think we need a mockable curl wrapper to get rid of all that copy-paste in the testing adapters. There seem to be a few wrappers, including PECL's HttpRequest and a couple of smaller ones on github. Any experience with them / any preference? I didn't see anything in mw-core on a cursory scan. [20:58:33] ejegg: That sounds like an excellent plan, and probably the only sane way out. However, there might be some easier dirty dancing to do, like https://gerrit.wikimedia.org/r/#/c/133508/ or doing horrific things with TestingAccessWrapper... [20:59:19] yeah, traits would do the trick! And bd808 is making another push for 5.4 [21:00:14] I'm not too compelled to maintain support for 5.3, since this extension is so enterprisey in the first place... [21:00:59] In the end though, I think you're right that any steps towards looser coupling and dependency injection are always welcome improvements! [21:01:50] Would you be OK with keeping the status quo for Astropay and fixing 'em all when we get to use traits? [21:06:57] ejegg: of curse! Sorry I wasn't more clear about the TODO-ness [21:19:42] ejegg: How do you suggest I create a logger, from code with no access to the $adapter? I'd like to include the global prefix, still... [21:20:13] that's a good question. Where are you trying to do that? [21:21:12] (PS5) Awight: WIP Use DonationQueue shim for non-orphan queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [21:21:19] ejegg: ^^ there, [21:21:49] https://gerrit.wikimedia.org/r/#/c/200793/5/gateway_common/DonationQueue.php,unified around line 15 [21:24:24] dang, I don't have any great ideas off the top of my head [21:26:03] Well, I'll do it explicitly for now... [21:26:47] we could do something gnarly like have the adapter register itself in the constructor as the 'current adapter' in some static var somewhere, then let the factory check for that if it doesn't get an adapter argument [21:29:11] Most important IMO is to keep the sites of usage simple, so that would be fine. There are already lots of single-threading assumptions, like $adapter->getCurrentTransaction(), so it's fine to add another... [21:30:28] I forget why the RAII stack didn't work out in practice, no big deal tho [21:30:53] It's just incompatible with keeping loggers as member fields [21:31:47] Which makes me think... anything in GatewayAdapter that uses a special logger should probably be extracted into new classes... [21:33:08] sounds right [21:33:52] (PS9) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) [21:37:12] (PS5) Ejegg: Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) [21:37:14] (PS10) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) [21:38:58] (CR) jenkins-bot: [V: -1] Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [21:39:25] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1191933 (atgo) Open>Resolved [21:40:04] (CR) jenkins-bot: [V: -1] Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [21:41:32] Fundraising Sprint I, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1191953 (atgo) NEW [21:43:12] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Spike: What happened with this JP Morgan import? - https://phabricator.wikimedia.org/T92463#1191965 (atgo) See T95487 for the spinoff of the additional work. Thanks! [21:46:44] (PS6) Ejegg: Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) [21:46:46] (PS11) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) [21:46:47] atgo: Thank you! [21:47:29] (PS6) Awight: Use DonationQueue shim for non-orphan queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [21:49:05] no problem! [21:50:49] arg! updated my mw install and now all me JS are not working [21:54:00] Ah oops I see, tha wasn't it 8p [22:01:36] (PS5) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 [22:04:20] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (owner: AndyRussG) [22:05:13] aaagh hangouts [22:06:02] my computer is freaking out [22:21:10] Fundraising Sprint J, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1192204 (atgo) [22:22:47] Fundraising Sprint I, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Reorganize CiviCRM 4.4 upgrade tasks - https://phabricator.wikimedia.org/T95496#1192208 (awight) NEW [22:23:14] Fundraising Sprint J, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Upgrade Civi to 4.4 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1192215 (awight) [22:24:08] Fundraising-Backlog: Accept incoming unsubscribe emails - https://phabricator.wikimedia.org/T93427#1136877 (atgo) [22:24:22] Fundraising Tech Backlog, Fundraising-Backlog: Update unsubscribe link in TY email header - https://phabricator.wikimedia.org/T93946#1150732 (atgo) [22:28:42] atgo: would you prefer to chat now, or wait until 4? [22:30:01] either way... maybe in like 3 minutes? i just want to run to kitchen [22:30:07] ejegg: hope your vacation goes excellently :) [22:30:15] ok, ping any time [22:30:20] thanks AndyRussG ! [23:08:05] atgo: Oh, where are we at with "● A/B componentes for the internal dash [23:18:33] nowhere [23:18:41] i mean, we have ideas [23:18:58] k [23:18:59] but there isn't actual implementation that's been done besides framework, which is what took Q3 [23:19:14] i also think that goal is too broad :) [23:19:17] I've updated the doc per our conversation... [23:19:40] Just the Appendix is left. [23:19:54] cool! want me to take a peek? [23:20:36] Sure, no rush [23:35:04] awight: mind if i make some additions? [23:40:13] i did, in purple mostly [23:43:26] atgo: thanks! [23:46:59] no problem [23:47:06] i'm about tohead out... [23:47:13] ejegg: have a WONDERFUL vacation! [23:56:34] thanks atgo! [23:57:34] (CR) Ejegg: [C: 2] "Looks good. Doesn't seem like any of our unstaged things have side effects at this point." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201382 (https://phabricator.wikimedia.org/T94506) (owner: Awight) [23:58:22] (PS5) Awight: Fix unstaging issue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201382 (https://phabricator.wikimedia.org/T94506)