[02:26:32] (CR) AndyRussG: "Thanks so much for all this!! BTW, for any suggestions that I didn't specifically reply to, please consider the response to be, "Will do"." (14 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (owner: AndyRussG) [13:56:47] updating barium [14:01:44] ops-fundraising, operations, ops-eqiad: barium has a failed HDD - https://phabricator.wikimedia.org/T93899#1209209 (Cmjohnson) New disk is on-line nclosure Device ID: N/A Slot Number: 3 Drive's position: DiskGroup: 1, Span: 0, Arm: 0 Enclosure position: N/A Device Id: 3 WWN: 5000c500794334bb Sequence... [14:21:18] ops-fundraising, operations, ops-eqiad: barium has a failed HDD - https://phabricator.wikimedia.org/T93899#1209254 (Cmjohnson) Open>Resolved package updates were successful..resolving this ticket [17:21:32] pizzzacat, AndyRussG|mob_: anything you want me to bring up at the scrum of scrums? [17:22:07] Hi ejegg! How was your vacation? [17:22:34] lots of fun, just wish i could have stayed longer [17:22:51] Cool! Where'd'ja go again? [17:23:00] Costa Rica. saw a couple of sloths, which was my top priority. [17:23:06] Ah right! [17:23:30] and some beautiful beaches, which satisfied my gf. [17:24:01] ejegg I don't have anything today [17:24:07] Right :) [17:24:21] I wish I could see some sloths. [17:24:32] Sometimes my cat pretends to be one [17:24:42] sometimes *I* pretend to be one [17:24:56] let's be honest: most of the time [17:25:04] http://sadbastard.org/images/sloth.gif [17:25:34] ^ exactly [17:25:56] cwdent: pizzzacat: actually that sloth looks pretty perky [17:26:29] ejegg: Re: SoS: Hmmm... Not really, thanks! If you happen to chat with anyone from ops, I'm curious about the correct way to deploy this, once it gets approved (hopefully soon): https://gerrit.wikimedia.org/r/#/c/202925/ [17:26:43] I don't think it's something that's worth bothering everyone about, though [17:27:14] ejegg: Basically it's a very minor change to a method signature in core, but there are several extensions that override that very method [17:27:44] I assume what we have to do is patch the extensions, update the submodules, and make sure everything related goes out exactly at the same time [17:27:47] hmmm, let me take a look [17:28:39] Last comment mentions the extensions that I think need updating... Unless somehow we need to take into account more that don't have submodules in the core repo [17:28:45] Hmm I guess I didn't look at skins [17:28:52] Ah no not true, yes I did [17:29:52] pizzzacat: the real sloths were a lot harder to photograph than this guy: http://imgur.com/mLuvSfl [17:30:41] i was messing with some tests and had a submodule question: the fundraising mw branch has a commit checked out for DonationInterface on the deployment branch which doesn't have the tests dir. is there a dev process for that? [17:30:42] hahahaaaa [17:32:49] sorry that was a terrible sentence [17:44:34] hi cwdent! The team has been deleting tests for deployment since before I got here, I think to reduce potential attack surface. [17:45:36] We generally delete the tests and merge commits from master in the same commit [17:46:08] gotcha! so you check out master, do your development, delete the tests and commit, then pull into the deployment branch? [17:48:17] cwdent|afk: I check out master, make a local bugfix branch, commit stuff and git-review to send the stuff to gerrit. When it's +2ed in gerrit and passes tests, it gets merged to master. [17:49:19] and that last step is when the tests dir gets removed? [17:49:22] Once we're ready to deploy a bunch of changes, then we do a merge to deployment in DI and a submodule update in the fundraising mw bit [17:49:44] Nope, tests stick around in master [17:49:59] oh duh yeah that's where i found em [17:50:45] We try to only merge to deployment right before we actually push the code up onto the payments cluster [17:50:53] cwdent|afk: ejegg: pizzzacat: atgo: have you all been IRC-introduced to each other? cwdent|afk is Casey, job candidate who we interviewed last week and who's been hanging out, installing MW, and actively checking out our codebase and some bugs. ejegg is Elliot (maybe you went on vacation shortly after the interview?), pizzzacat is Sherah, who was on vacation during the interview and works especially on the FR [17:50:54] Dashboard, and atgo, who just joined the chat, is Anne, our fearless product manager :) [17:51:34] hi cwdent [17:51:37] so that branch should remain a good reflection of the code we're currently serving up to the world. [17:51:39] ah yes, i've been /whoising errybody [17:51:46] hi pizzzacat! [17:52:08] Ah cool :) [17:52:16] Nice to see you in #wikimedia-fundraising, cwdent! [17:52:48] pleasure to be here :] maybe some day in an official capacity [17:53:11] anyway thanks for the info, i have to actually afk now but i'll be back later with more newb questions [17:53:26] awesome, ask away anytime! [17:55:05] AndyRussG: I mentioned you wanted deploy tips and dropped a link into the notes, but didn't get a lot of reaction. Let me know if you get some feedback [17:55:23] ejegg: K fantastic, thanks mucho [17:55:25] pizzzacat: how was your vacation / film project? [17:58:06] ejegg I got very sick so my vacation did not go as planned or really feel like a vacation :( [17:58:14] I ended up not being able to go to Portland [17:59:12] aww, bummer [17:59:28] hope you're all better now at least [18:00:17] thanks, I'm way better now. :) [18:17:41] Fundraising Sprint Enya, Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, and 7 others: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1209974 (AndyRussG) Now c... [18:18:36] Fundraising Sprint Enya, Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, and 7 others: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1209975 (AndyRussG) Ope... [18:20:54] Fundraising Sprint Enya, Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, and 7 others: CentralNotice bucket improvements, step 3 bis part 2: moar better cross-browser tests - https://phabricator.wikimedia.org/T86092#1209977 (AndyRussG) (The... [18:47:16] Fundraising-Backlog: Update error messaging on donate form (pre-payment fields) - https://phabricator.wikimedia.org/T96066#1210085 (Pcoombe) I don't think it's possible to change the English text on translatewiki, we have to change the DonationInterface code. I can probably make a patch for this tomorrow if... [18:48:50] Fundraising-Backlog: Update error messaging on donate form (pre-payment fields) - https://phabricator.wikimedia.org/T96066#1210086 (CCogdill_WMF) Awesome, thanks @Pcoombe & @awight. This isn't urgent but nice to fix whenever we can. [20:02:58] ejegg: any idea if these lines in SpecialBannerLoader have any use? I can't find any... https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/special/SpecialBannerLoader.php#L117-123 [20:03:11] fyi all, I am in a meeting until 2 so I will be missing standup [20:06:36] pizzzacat: thx don't we not have standup in deference to shrimp? [20:06:49] oh right! nevermind then! [20:06:50] :) [20:07:12] Today the mighty shrimp roam the meetingspace! [20:09:26] AndyRussG: lemme take a look [20:09:32] ejegg: thanks! [20:10:36] AndyRussG: Is the 'priority' array member consulted to detemine which banner to show? [20:11:07] Not there. Nothing in the banner is consulted, it's consulted in choiceData [20:11:22] Unless there's some weird on-banner JS that does consult it [20:11:30] I checked on meta and came up empty-handed [20:12:28] huh, guess those lines are pointless then [20:13:03] Maybe ask the-wub if he ever wants that in his banner array? [20:13:46] Yeah I was think that [20:14:02] However, I think also we could just forget it, 'cause in fact if he wants it, he shouldn't [20:14:32] Any of that banner script that might want it will go the way of the campaign mixin soon enuf [20:14:50] And those won't be grabbing such data from the banner fer sher [20:14:52] yah, good point [20:15:36] thx... excellent, so I'm killing it ;) [20:29:07] Man there is so much dead code floating around! [20:31:16] ejegg: what about this third param on loadTestingBanner? https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/modules/ext.centralNotice.bannerController/bannerController.js#L132 [20:31:40] chopping block too, no? It looks simple enuf, maybe it's a mirage [20:34:27] AndyRussG: yeah, can't see how that does anything! [20:34:41] Maybe one day we'll come across an ocean vortex of dead code, like those artificial islands made of discarded plastic bags [20:34:52] ooh, toxic! [20:35:02] And we'll get draggged.... innnnn.......... [20:35:20] bet it's all up in Mare Imbrium [20:35:51] The moon is made of dead code? [20:36:11] or just polluted with it [20:36:40] lol no wonder no one's been back [20:39:31] Frankly I don't see the point of having the second param in there rather than coded directly in the loadTestingBanner function [20:41:58] AndyRussG: me neither, unless ppl like calling that fn from the console [20:44:01] Maybe once... I'm guessing once there was some badly designed code that actually used the priority param and other stuff from the campaign in the banner scripts [20:44:09] But that it's been since removed [20:44:15] Hopefully [20:52:22] Hmmm actually I'm thinking of some circumstances in which it the second param might still be used [20:52:30] K back to life for that one [21:33:27] (PS7) Ejegg: Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) [21:33:29] (PS12) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) [21:33:31] (PS1) Ejegg: Parse JSON responses, get Astropay status and errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204346 (https://phabricator.wikimedia.org/T90503) [21:48:54] Fundraising Sprint I, Fundraising-Backlog, Wikimedia-Fundraising, Astropay Integration: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1210604 (atgo) [21:50:22] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Use the new queue wrapper for adding messages to the queues - https://phabricator.wikimedia.org/T92921#1210612 (atgo) [21:50:40] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Use the new queue wrapper for adding messages to the queues - https://phabricator.wikimedia.org/T92921#1123885 (atgo) [21:51:09] Fundraising Sprint I, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1210617 (atgo) [21:57:22] (PS1) AndyRussG: Special:BannerLoader: test campaign staleness [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204390 (https://phabricator.wikimedia.org/T88276) [22:01:39] Fundraising Sprint House of Pain, MediaWiki-extensions-CentralNotice: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1210660 (AndyRussG) [22:01:55] Fundraising Sprint House of Pain, MediaWiki-extensions-CentralNotice: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1210652 (AndyRussG) [22:02:17] Fundraising Sprint House of Pain, MediaWiki-extensions-CentralNotice: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1210663 (AndyRussG) a:AndyRussG [22:02:42] Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, and 2 others: Implement campaign associated mixins per findings from T90913 - https://phabricator.wikimedia.org/T90915#1210671 (AndyRussG) [22:02:45] Fundraising Sprint House of Pain, MediaWiki-extensions-CentralNotice: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1210652 (AndyRussG) [22:04:09] one sec [22:05:03] pizzzacat: http://epicstream.com/features/Heres-A-Huge-Creepy-Realistic-Wool-Cat-Head-You-Can-Wear-As-A-Mask [22:06:06] booted from hangout, trying to get back in [22:06:44] k [22:08:04] ejegg: we can't hear u [22:13:03] ringing? [22:18:44] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising-Backlog, Astropay Integration, Patch-For-Review: Create a skeletal Astropay gateway in DonationInterface - https://phabricator.wikimedia.org/T90501#1210716 (atgo) Open>Resolved [22:18:46] Fundraising-Backlog, Wikimedia-Fundraising, Epic: Integrate processing in LATAM via Astropay - https://phabricator.wikimedia.org/T77907#1210717 (atgo) [22:20:21] Fundraising Sprint House of Pain, Fundraising Sprint I, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1210725 (pizzzacat) [22:20:27] Fundraising Sprint House of Pain, Fundraising Sprint I, Patch-For-Review: Add mustache templating engine gateway form renderer - https://phabricator.wikimedia.org/T95951#1210727 (Ejegg) [22:20:36] Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising-Backlog: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1210728 (pizzzacat) [22:20:47] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint I, MediaWiki-extensions-CentralNotice, Patch-For-Review: [1 day] BUG: CN banner being shown after campaign end - https://phabricator.wikimedia.org/T88276#1210729 (AndyRussG) [22:20:50] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Use the new queue wrapper for adding messages to the queues - https://phabricator.wikimedia.org/T92921#1210730 (Ejegg) [22:21:30] Fundraising Sprint House of Pain, Fundraising Sprint I, MediaWiki-extensions-CentralNotice: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1210733 (AndyRussG) [22:21:34] Fundraising Sprint I, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Reorganize CiviCRM 4.4 upgrade tasks - https://phabricator.wikimedia.org/T95496#1210734 (atgo) [22:22:07] Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint I, and 3 others: Implement campaign associated mixins per findings from T90913 - https://phabricator.wikimedia.org/T90915#1210736 (AndyRussG) [22:22:15] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising-Backlog, Patch-For-Review: BUG: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1210737 (Ejegg) [22:22:28] Fundraising Sprint I, Wikimedia-Fundraising-CiviCRM: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1210739 (atgo) [22:22:31] Fundraising Sprint House of Pain, Fundraising Sprint I, MediaWiki-extensions-CentralNotice: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1210738 (AndyRussG) [22:22:42] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising-Backlog, and 3 others: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1210740 (Ejegg) [22:23:14] Fundraising-Backlog: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#1210749 (atgo) [22:24:05] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising Tech Backlog, and 2 others: Write an abstracted interface for queue send and receive - https://phabricator.wikimedia.org/T92916#1210752 (Ejegg) [22:24:49] Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Use the new queue wrapper for orphan slaying queue stuff - https://phabricator.wikimedia.org/T92922#1210754 (Ejegg) [22:25:36] Fundraising Sprint House of Pain, Fundraising Sprint I, Fundraising-Backlog, Patch-For-Review: Change legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1210760 (Ejegg) [22:27:04] https://phabricator.wikimedia.org/T96084 [22:27:44] Fundraising Sprint I, Wikimedia-Fundraising-CiviCRM: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1210768 (atgo) a:atgo>None [22:28:00] Fundraising Sprint I, Wikimedia-Fundraising-CiviCRM: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1207963 (atgo) p:Triage>Normal [22:28:43] Fundraising Sprint I, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1210772 (atgo) [22:28:56] Fundraising Sprint I, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1210775 (atgo) p:Triage>Normal [22:30:13] Fundraising-Backlog: Require email on iDEAL form - https://phabricator.wikimedia.org/T96074#1210776 (atgo) a:atgo>None [22:31:39] http://etherpad.wikimedia.org/p/fundraising_shrimp [22:36:01] Wikimedia-Fundraising, Continuous-Integration: wikimedia/fundraising/dash.git should pass jshint - https://phabricator.wikimedia.org/T67053#1210789 (Krinkle) [22:54:11] atgo: pizzzacat: ejegg: thanks 4 being patient WRT my musical ignorance and sorry for taking so long [22:54:56] Thanks for being open to checking out new tunes! [22:55:23] ah my pleasure! I'll have to start listening to the runner up some now :) [23:01:57] AndyRussG: totally ok! [23:03:24] pizzzacat: :) thanks