[00:35:21] <AndyRussG>	 Hey ejegg... Feel like a quick no-brainer +2?
[00:35:41] <ejegg>	 I'll take a look!
[00:35:51] <AndyRussG>	 ejegg: thx! https://gerrit.wikimedia.org/r/#/c/203630/
[00:36:28] <AndyRussG>	 It's just 'cause following the removal of the old Special:BannerRandom method, the shim to compar allocations on the CN admin page was also removed
[00:36:52] <AndyRussG>	 But we forgot to take out the css rule hiding the results from the new method
[00:37:30] <AndyRussG>	 ...Just bugging u 'cause my next patch would work out better on top of this... :)
[00:37:31] <ejegg>	 oh yeah, that hokey switch
[00:37:45] <AndyRussG>	 the hokey pokey!
[00:38:04] <ejegg>	 happy to help zap it
[00:38:11] <AndyRussG>	 :) much apprciated
[00:38:34] <ejegg>	 but why is there still an element with that ID?
[00:39:53] <ejegg>	 oh, nvm
[00:42:36] <grrrit-wm1>	 (CR) Ejegg: [C: 2] "poof" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/203630 (owner: AndyRussG)
[00:56:19] <grrrit-wm1>	 (PS1) Ejegg: Tiny bit more post-BannerRandom cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204427
[00:59:19] <grrrit-wm1>	 (PS2) Ejegg: Tiny bit more post-BannerRandom cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204427
[00:59:47] <ejegg>	 AndyRussG: a tiny bit more cleanup in that vein: https://gerrit.wikimedia.org/r/204427
[01:30:40] <AndyRussG>	 ejegg: thanks!
[01:36:55] <grrrit-wm1>	 (CR) AndyRussG: [C: 2] "Nice!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204427 (owner: Ejegg)
[01:37:22] <ejegg>	 thanks!
[01:37:35] <AndyRussG>	 :)
[01:38:12] <AndyRussG>	 I'm trying to remember if there wasn't one other crumb of related cruft, come to think of it...
[01:39:21] <grrrit-wm1>	 (Merged) jenkins-bot: Tiny bit more post-BannerRandom cleanup [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204427 (owner: Ejegg)
[01:41:08] <AndyRussG>	 Ah no, I'm mistaken... It was BannerChooser, but that's still used in BannerAllocationCalculator
[05:37:38] <grrrit-wm>	 (PS1) Ejegg: Redirect to Astropay on successful NewInvoice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503)
[05:38:46] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] Redirect to Astropay on successful NewInvoice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg)
[05:40:54] <grrrit-wm>	 (PS2) Ejegg: Redirect to Astropay on successful NewInvoice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503)
[17:08:38] <wikibugs>	 Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, MediaWiki-extensions-CentralNotice, Patch-For-Review: [1 day] BUG: CN banner being shown after campaign end - https://phabricator.wikimedia.org/T88276#1212817 (AndyRussG) Again, since we can'...
[17:18:03] <K4-713>	 Hiiiiiii.
[17:27:09] <marktraceur>	 K4-713: You walked in and there weren't immediately twenty things wrong. Seems suspiciously normal. :P
[17:40:52] <ccogdill>	 hey Jeff_Green, I’m updating my cert and have a quick, silly question for you
[17:41:03] <Jeff_Green>	 ya?
[17:41:09] <ccogdill>	 I think I can do this all myself, I just don’t know the command to get into my home directory on lutetium
[17:41:14] <ccogdill>	 :D
[17:41:18] <K4-713>	 marktraceur: Yeah: Too quiet.
[17:41:23] <K4-713>	 marktraceur: Wait: I missed a line.
[17:41:25] <Jeff_Green>	 ccogdill: oh. one sec, doorbell
[17:41:30] <ccogdill>	 k thanks!
[17:42:02] <ccogdill>	 or, I guess what the location is called so I can scp
[17:42:22] <Jeff_Green>	 ok back
[17:43:04] <Jeff_Green>	 ccogdill: if you open a terminal on your Mac (you're a mac user right??) you can use scp to fetch the two files
[17:43:24] <Jeff_Green>	 scp lutetium:client_cert* ~/Desktop/
[17:43:30] <ccogdill>	 right, I just thought i’d have to specify the folder it was coming from
[17:43:43] <ccogdill>	 but nevermind! if that’ll work I know that command already :)
[17:43:44] <Jeff_Green>	 oh!
[17:43:55] <Jeff_Green>	 your homedir is implied
[17:43:59] <ccogdill>	 ahhh
[17:44:05] <Jeff_Green>	 [host]:[directory]
[17:44:10] <ccogdill>	 got it
[17:44:18] <ccogdill>	 okay thanks. told you it was a silly one!
[17:44:23] <Jeff_Green>	 not silly!
[17:44:42] <ccogdill>	 :)
[17:47:24] <K4-713>	 Jeff_Green: Hey, Good Aftermath!
[17:47:27] <K4-713>	 How are we doing?
[17:52:44] <AndyRussG>	 K4-713: Booo! Welcome back :)
[17:52:58] <K4-713>	 AndyRussG: Hello!
[17:53:06] <AndyRussG>	 How'd it go?
[17:54:17] <K4-713>	 Hm. How to say.
[17:54:35] <K4-713>	 It was extremely engaging.
[17:54:48] <K4-713>	 Ridiculously educational.
[17:55:30] <K4-713>	 Also exhausting.
[17:55:52] <K4-713>	 But probably the best thing I could have gotten up to in my free time.
[17:56:43] <K4-713>	 Also, I am jetlagged like Woah.
[17:58:37] <AndyRussG>	 K4-713: whoa indeed! wow, sounds fantastic
[17:59:29] <Jeff_Green>	 K4-713: hey, welcome back!
[17:59:48] <Jeff_Green>	 sorry, had to help a neighbor for a minute there
[18:00:05] <K4-713>	 Jeff_Green: No worries.
[18:00:19] <Jeff_Green>	 mostly I've been working on two factor auth
[18:00:26] <K4-713>	 Yeah, how's that going?
[18:00:46] <Jeff_Green>	 i've got kerberos and yubikeys working
[18:00:50] <K4-713>	 And by that I probably mean: How long until nobody can get in anymore? :p
[18:00:54] <Jeff_Green>	 hahahaha
[18:01:06] <Jeff_Green>	 so well this is where it gets interesting
[18:01:09] <Jeff_Green>	 INNNNTNTNTNTNNERESTING
[18:01:54] <Jeff_Green>	 my working plan, which seems to be passing basic peer insanity checks is to put two-factor auth right on the bastion's ssh
[18:02:27] <Jeff_Green>	 so when you connect it first checks ssh keys, then asks for a passphrase
[18:03:13] <Jeff_Green>	 that passphrase could be either a traditional stored-in-kerberos password, or a one time key provided by a yubikey dongle
[18:03:29] <Jeff_Green>	 with yubikey the dongle acts like a keyboard with 1 button
[18:03:45] <Jeff_Green>	 you press it and it spews a very long one-time text string and a linefeed
[18:03:53] <K4-713>	 Neat!
[18:04:35] <Jeff_Green>	 the thing that's been taking a long time is getting into the guts of PAM (pluggable auth modules) and puppetizing thinhgs
[18:04:57] <Jeff_Green>	 today I've been looking at extensions to deal with locking out brute force attempts
[18:04:58] <K4-713>	 huh
[18:05:36] <K4-713>	 Well, that sounds... kind of fun, actually.
[18:05:44] <Jeff_Green>	 it's not awful
[18:05:59] <Jeff_Green>	 and now I have a much better understanding of kerberos and radius ;-)
[18:07:19] <K4-713>	 Totally sounds like fun. Perhaps I have had too much sun lately.
[18:07:29] <Jeff_Green>	 ha
[18:07:58] <K4-713>	 Aaanyway, is there anything you know of that I should probably know about sooner than later?
[18:08:06] <Jeff_Green>	 hmm.
[18:08:08] <K4-713>	 I have this formidable pile of emails.
[18:08:16] <Jeff_Green>	 generally I'm the last to know things
[18:08:25] <Jeff_Green>	 nothing major I can think of
[18:12:34] <K4-713>	 That seems to be a very good sign.
[18:12:50] <K4-713>	 I had these visions of you being called at 3:30 in the morning to stop Jenkins from going mad.
[18:13:26] <Jeff_Green>	 yeah, unless we're mid big english fundraiser I'm probably an F- on middle of night response time
[18:17:28] <cwdent>	 hi K4-713! this is casey who you spoke with the other week. been idling in this channel and trying to get a lay of land, just in case things work out!
[18:21:19] <AndyRussG>	 K4-713: ^ cwdent has been hanging out here since early on this week... following up on our shameless suggestion that he take a look at some DI bugs
[18:21:56] * awight waves at cwdent 
[18:22:08] <awight>	 Haven't scared you away yet, eh?  That's good :)
[18:23:37] <cwdent>	 hehe, wish i could say i've submitted some patches but really just been getting a high level idea of how the pieces fit together
[18:25:09] <AndyRussG>	 Sounds like a completely reasonabl approach
[18:25:13] <cwdent>	 i was able to get basically all the tests passing but wondered, do they all pass normally? or are there a few known busted ones?
[18:25:46] <K4-713>	 cwdent: Oh hey!
[18:26:09] <K4-713>	 Sorry I'm not going to be terribly interactive for a while. Lots of... post-vacation meetings to attend today.
[18:26:30] <cwdent>	 i understand!
[18:26:33] <K4-713>	 ejegg|biab: Speaking of which...
[18:28:03] <AndyRussG>	 Hmmm on DI? dunno... Looks like they all pass on Jenkins when code is uploaded to Gerrit: https://integration.wikimedia.org/ci/job/mwext-DonationInterface-testextension-zend/751/consoleFull
[18:28:09] <AndyRussG>	 How are you running them?
[18:28:41] <ejegg|biab>	 K4: will be on in 3 min!
[18:29:18] <K4-713>	 ejegg|biab: Cool. See you then. :)
[18:29:27] <cwdent>	 i went into the submodule and checked out master to get the tests dir, and then ran php tests/phpunit/phpunit.php --group DonationInterface
[18:29:32] <K4-713>	 ejegg|biab: I should be in the meeting by then, too. Heh.
[18:29:33] <awight>	 cwdent: Please do pastebin us the failing tests!
[18:29:51] <awight>	 They pass normally, but I would believe that they're fragile.
[18:30:24] <AndyRussG>	 ...which in a certain sense is not a bad sign...
[18:30:42] <cwdent>	 awight: http://pastebin.com/cJQJx528
[18:30:53] <cwdent>	 may certainly be something about my config though because i set it up by hand
[18:31:00] <cwdent>	 so i'm sure i'm missing a million things puppet would do
[18:31:38] <awight>	 cwdent: Well, the tests are supposed to be completely insensitive to config.
[18:31:41] <awight>	 In theory.
[18:32:00] <cwdent>	 looks like i18n errors?
[18:32:01] <awight>	 Ah, that's a failure I recognize..
[18:32:09] <awight>	 Can't remember what causes it, though!
[18:32:24] <cwdent>	 i'll see if i can figure it out
[18:32:52] <awight>	 I think ejegg|biab just had this happen to him.
[18:33:49] <awight>	 cwdent: There's something funky we're doing wrt those country codes appended to the end...
[18:34:53] <awight>	 DataValidator::wfLangSpecificFallback ...
[18:36:50] <awight>	 cwdent: The file DonationInterface/vendor/autoload.php exists?
[18:37:35] <cwdent>	 yep that's there
[18:38:11] <awight>	 What is your commandline to run phpunit?
[18:38:53] <cwdent>	 php tests/phpunit/phpunit.php --group  DonationInterface
[18:38:55] <cwdent>	 from mw basedir
[18:39:08] <awight>	 okay...
[18:39:28] <cwdent>	 i can dig at this!  don't want to take up your time
[18:40:13] <awight>	 Well, there's a heinous thing we do to both translate and localize.  Postal code is called something different in each country, so we have this funky semiconvention of appending the country name to the i18n message key.
[18:40:40] <awight>	 The lookup is ultimately done in WmfFramework... but that class is bifurcated so we can run under both MediaWiki and Drupal.
[18:41:06] <awight>	 I think the error is happening just before that layer, in DataValidator::wfLangSpecificFallback
[18:41:09] <awight>	 but not certain
[18:41:47] <awight>	 ejegg|biab will definitely have some ideas when he's back, cos I think he just ran into this exact issue.
[18:41:47] <cwdent>	 groovy
[18:41:59] <awight>	 Meanwhile, I guess u could filter out those tests if you're looking at something specific.
[18:42:24] <awight>	 instead of --group, specify --filter DonationDataTest, for example.
[18:42:38] <cwdent>	 i'm definitely still a babe in the woods with this codebase
[18:43:22] <cwdent>	 but stack traces are a great way to learn!
[18:47:31] <awight>	 The wolf-shaped shadows...
[18:47:59] <awight>	 ejegg: I was banging on yr door...
[18:48:01] <ejegg>	 awight, cwdent: I never did resolve that, but I'm looking again now
[18:48:06] <awight>	 k, thanks!
[18:48:11] <cwdent>	 * TODO: Belongs somewhere very else.
[18:48:12] <cwdent>	 hehe
[18:48:30] <awight>	 cwdent: oh... If you like tounge-in-cheek commentary, this is the codebase for you!
[18:49:47] <cwdent>	 love it
[18:52:12] <cwdent>	 at my last job we had a bash script that heat mapped programmers to cursing in the code and commit log
[18:52:16] <cwdent>	 i wonder if i can find it
[18:53:38] <AndyRussG>	 What about one that maps intentionally incorrect grammar?
[18:53:43] <awight>	 excellent.  We could retool that...  Or we could use the ELIZA continuous integration plugin to respond in kind.
[18:54:17] <AndyRussG>	 Jenkins merge Siri
[18:54:58] <awight>	 Ouch: http://www.bbc.com/news/blogs-trending-32308428
[18:55:15] <awight>	 crowdfail or something
[18:56:46] <cwdent>	 perhaps my favorite twitter bot: https://twitter.com/stealthmountain
[18:57:52] <cwdent>	 this is good: https://github.com/xiongchiamiov/git-swear-stats
[19:03:36] <AndyRussG>	 awight: sad :(
[19:04:27] <AndyRussG>	 cwdent: heheheh (good antidote to sadness...)
[19:12:21] <ejegg>	 cwdent, awight: my working test setup is running PHP 5.5 and my breaking test setup is running PHP 5.6 - what are your versions?
[19:12:29] <awight>	 argh.
[19:12:46] <ejegg>	 just trying to narrow the possibilities
[19:12:49] <awight>	 zend 5.4.39, 5.5, and hhvm
[19:13:01] <awight>	 Can you run the working setup with your php5.6?
[19:13:16] <ejegg>	 will try that in a sec
[19:13:27] <ejegg>	 cwdent: you're not running 5.6, are you?
[19:13:28] <cwdent>	 i'm actually running hiphop
[19:13:30] <cwdent>	 forgot about that
[19:13:35] <cwdent>	 bet that's it
[19:13:48] <AndyRussG>	 "PHP 5.6, breaking tests... because"
[19:14:09] <awight>	 I haven't run the tests under hhvm cli, but that's what WMF CI uses, so probably not the issue.
[19:14:11] <ejegg>	 wait, awight just said he's running hhvm
[19:14:13] <ejegg>	 oh
[19:15:11] <cwdent>	 yeah, all the vanilla mw tests i've run have passed, so it could be DI specific?
[19:15:20] <cwdent>	 cause that doesn't get tested against hhvm does it?
[19:15:33] <awight>	 Good point, lemme see...
[19:15:59] <ejegg>	 Something in the RapidHTML?  It's only the form load verification tests failing with escaped HTML tags
[19:16:19] <awight>	 Yeah DI is actually run under zend
[19:17:41] <awight>	 https://integration.wikimedia.org/ci/job/mwext-DonationInterface-testextension-zend/750/console
[19:17:55] <ejegg>	 and my test are failing under zend, so that's not it
[19:18:07] <awight|soup>	 brb
[19:29:21] <wikibugs>	 Fundraising-Backlog: Improve error messaging for donors experiencing browser errors - https://phabricator.wikimedia.org/T96293#1213465 (CCogdill_WMF) NEW a:atgo
[19:31:14] <wikibugs>	 Fundraising-Backlog: Improve error messaging for donors experiencing browser errors - https://phabricator.wikimedia.org/T96293#1213473 (CCogdill_WMF)
[20:11:52] <AndyRussG>	 I'm gonna kill the BannerChooser class too. Just used for global allocations, but I think I can spin it into BannerAllocationCalculator
[20:12:39] <AndyRussG>	 atgo-lunch: is there anything I should be reading ahead of the meeting?
[20:12:49] <atgo-lunch>	 hey AndyRussG! nope, just bring your intentions
[20:13:08] <AndyRussG>	 atgo: fantastic, thanks!
[20:15:36] <AndyRussG>	 Hahahaha || vs. or
[20:15:56] <AndyRussG>	 That's soooo intuitive!
[20:35:59] <atgo_>	 http://etherpad.wikimedia.org/p/fr-tech-quarterlygoals
[20:37:51] <atgo>	 pizzzacat: http://etherpad.wikimedia.org/p/fr-tech-quarterlygoals
[21:49:49] <atgo>	 ejegg: calling you in
[21:50:55] <ejegg>	 thanks atgo! guess it kicked out phone-me when computer-me left
[21:51:02] <atgo>	 yeah it does that. it's annoying
[21:56:30] <cwdent>	 well i tried to track that error down, those encoded chars are showing up in an attribute value, but the only relevant thing i can find is %donate_interface-postal% in globalcollect_gateway/forms/*
[21:57:14] <cwdent>	 so that's getting swapped with <> somehow...i lost the trail there.  i am leaving town shortly so i best sign off, but have a great weekend everyone
[21:59:34] <AndyRussG>	 cwdent|out: thanks! (Everyone's in a meating now BTW)
[21:59:47] <AndyRussG>	 cwdent|out: have a great weekend too!
[23:03:57] <awight|soup>	 cwdent|out: Sorry, I did know about the &lt;.  The angle brackets are what a message looks like when MediaWiki cannot find a translation.  Rather than "Fromage", you get "<cheese-key>".  Have a nice trip!
[23:09:25] <grrrit-wm>	 (PS8) Ejegg: Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503)
[23:09:27] <grrrit-wm>	 (PS2) Ejegg: Parse JSON responses, get Astropay status and errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204346 (https://phabricator.wikimedia.org/T90503)
[23:09:29] <grrrit-wm>	 (PS3) Ejegg: Redirect to Astropay on successful NewInvoice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503)
[23:09:31] <grrrit-wm>	 (PS13) Ejegg: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503)
[23:09:45] <grrrit-wm>	 (CR) Ejegg: Redirect to Astropay on successful NewInvoice (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg)
[23:10:03] <grrrit-wm>	 (CR) Ejegg: Parse JSON responses, get Astropay status and errors (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204346 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg)
[23:10:24] <grrrit-wm>	 (CR) Ejegg: Sign Astropay transactions (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg)
[23:11:20] <grrrit-wm>	 (CR) Ejegg: Use transaction-specific URLs for Astropay (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg)
[23:13:59] <pizzzacat>	 y'all wanna do offsite meeting at 4:30? 5?
[23:14:08] <K4-713>	 4:30 is good.
[23:14:19] <pizzzacat>	 that's the spirit
[23:14:29] <pizzzacat>	 awight?
[23:14:55] <awight>	 yessir
[23:15:03] <awight>	 oh.  yes.
[23:15:13] <pizzzacat>	 that's the first time someone's called me sir since I lived in Mississippi
[23:15:42] * pizzzacat actually lived in Mississippi that wasn't a joke ok
[23:15:44] <awight>	 m i curvy letter curvy letter i...
[23:15:58] <pizzzacat>	 humpback humpback
[23:16:03] <pizzzacat>	 dotted letter
[23:16:10] <pizzzacat>	 crooked letter
[23:16:18] <pizzzacat>	 is how it goes
[23:16:19] <awight>	 no!  they say all that?
[23:16:20] <pizzzacat>	 so.
[23:16:21] <awight>	 cool
[23:16:22] <pizzzacat>	 yes
[23:16:24] <pizzzacat>	 haha
[23:16:33] <pizzzacat>	 m, dotted letter, crooked letter, crooked letter
[23:16:48] <pizzzacat>	 dotted letter, crooked letter, crooked letter
[23:17:03] <pizzzacat>	 dotted letter, humpback, humpback, dotted letter
[23:17:13] * pizzzacat is out of breath
[23:17:19] * pizzzacat needs some sweet tea
[23:18:17] * awight kicks back and watches everyone else sweat
[23:25:07] <wikibugs>	 Fundraising Sprint Indigo Girls: Write Dash Documentation - https://phabricator.wikimedia.org/T96318#1214231 (pizzzacat) NEW a:pizzzacat
[23:25:28] <wikibugs>	 Fundraising Sprint Indigo Girls: Write Dash Documentation - https://phabricator.wikimedia.org/T96318#1214240 (pizzzacat)
[23:25:50] <wikibugs>	 Fundraising Dash, Fundraising Sprint Indigo Girls: Write Dash Documentation - https://phabricator.wikimedia.org/T96318#1214231 (pizzzacat)
[23:34:04] <grrrit-wm>	 (CR) Awight: "Haven't finished reviewing." (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204390 (https://phabricator.wikimedia.org/T88276) (owner: AndyRussG)