[02:04:33] (CR) AndyRussG: "Thanks! :)" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204390 (https://phabricator.wikimedia.org/T88276) (owner: AndyRussG) [03:01:17] (CR) Awight: "Should this still be merged, in a disabled state, or is the paper mandate still a deal-breaker? There's a lot of work in here, it would b" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/145731 (owner: Katie Horn) [03:31:47] (PS7) Awight: WIP Use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203282 (https://phabricator.wikimedia.org/T92922) [03:31:49] (PS9) Awight: Write DonationQueue shim around PHPQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) [03:31:51] (PS15) Awight: Use DonationQueue for non-orphan queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [03:35:15] (PS10) Awight: Write DonationQueue shim around PHPQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) [04:34:34] (CR) Awight: [C: 2] "Looks great! Some cleanup stuff mentioned inline." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204346 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:36:34] (CR) Awight: [C: 2] Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:38:09] (PS14) Awight: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:38:16] (CR) Awight: Use transaction-specific URLs for Astropay (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:38:23] (CR) Awight: [C: 2] Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:38:31] (PS9) Awight: Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:38:40] (PS3) Awight: Parse JSON responses, get Astropay status and errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204346 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:38:45] (Merged) jenkins-bot: Use transaction-specific URLs for Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201048 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:38:48] (PS4) Awight: Redirect to Astropay on successful NewInvoice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:40:21] (CR) Awight: Redirect to Astropay on successful NewInvoice (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:41:21] (CR) Awight: [C: 2] Redirect to Astropay on successful NewInvoice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:42:14] (Merged) jenkins-bot: Sign Astropay transactions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/201642 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:42:25] (Merged) jenkins-bot: Parse JSON responses, get Astropay status and errors [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204346 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [04:43:21] (Merged) jenkins-bot: Redirect to Astropay on successful NewInvoice [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204456 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [05:09:14] (CR) Awight: Special:BannerLoader: test campaign staleness (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204390 (https://phabricator.wikimedia.org/T88276) (owner: AndyRussG) [13:46:28] ops-fundraising, operations: DNS for betelgeuse and beryllium - https://phabricator.wikimedia.org/T96365#1215305 (Jgreen) NEW a:Jgreen [15:22:59] ops-fundraising, operations: DNS for betelgeuse and beryllium - https://phabricator.wikimedia.org/T96365#1215538 (Jgreen) Open>Resolved corrected beryllium spelling, added DNS for primary IP for betelgeuse [15:23:56] ops-fundraising, operations: DNS for betelgeuse and beryllium - https://phabricator.wikimedia.org/T96365#1215549 (Jgreen) [15:28:43] ops-fundraising, operations: DNS for betelgeuse and beryllium - https://phabricator.wikimedia.org/T96365#1215565 (Jgreen) [16:23:27] Fundraising-Backlog: Update error messaging on donate form (pre-payment fields) - https://phabricator.wikimedia.org/T96066#1215779 (Pcoombe) a:atgo>Pcoombe [16:24:52] Fundraising-Backlog: Update error messaging on donate form (pre-payment fields) - https://phabricator.wikimedia.org/T96066#1215782 (atgo) @pcoombe - just to be clear, the changes to the formatting are happening with Sherah in T86214, right? @pizzzacat @awight will this conflict with the refactor work that's... [16:28:09] hey andyrussg - mind if we push the UI checkin til monday? [16:28:20] atgo: sure, no problem! [16:28:46] How's the sore throat? [16:29:53] ok. i'm suuuper stuffy [16:31:25] Ooof... Hope you feel better soon! [16:48:24] (PS1) Pcoombe: Change English error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204798 (https://phabricator.wikimedia.org/T96066) [16:50:25] Fundraising-Backlog, Patch-For-Review: Update error messaging on donate form (pre-payment fields) - https://phabricator.wikimedia.org/T96066#1215904 (Pcoombe) @atgo Yes, changing the formatting is T86214, which I'm not in a position to help with. My patch just changes the content of the messages. [17:25:58] atgo: Argh, check your email. [17:26:07] I found a problem. [17:26:19] I don't think I can deal with it right now myself, though. [17:26:21] Or I would. [17:27:00] ejegg: You too. :p [17:28:57] good catch, k4-713 [17:31:32] checking... [17:47:15] (PS1) Ejegg: Fail on any unrecognized CVV return codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204819 (https://phabricator.wikimedia.org/T96393) [17:51:10] (CR) Katie Horn: "Looks good, but: Could you log something at warn level when this happens?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204819 (https://phabricator.wikimedia.org/T96393) (owner: Ejegg) [17:51:26] good call [17:57:54] (CR) AndyRussG: Special:BannerLoader: test campaign staleness (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/204390 (https://phabricator.wikimedia.org/T88276) (owner: AndyRussG) [18:02:45] (PS2) Ejegg: Fail on any unrecognized CVV return codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204819 (https://phabricator.wikimedia.org/T96393) [18:05:21] (CR) Katie Horn: [C: 2] Fail on any unrecognized CVV return codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204819 (https://phabricator.wikimedia.org/T96393) (owner: Ejegg) [18:06:37] (Merged) jenkins-bot: Fail on any unrecognized CVV return codes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204819 (https://phabricator.wikimedia.org/T96393) (owner: Ejegg) [18:11:33] ejegg: Thanks for that. [18:11:37] hmm, there's a bit of a backlog to be deployed. Might do this as a cherry-pick [18:11:48] Well, it *is* friday. [18:11:51] So that makes sense. [18:11:55] k [18:11:59] Good call. [18:15:55] (PS1) Ejegg: Fail on any unrecognized CVV return codes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204836 (https://phabricator.wikimedia.org/T96393) [18:17:11] awight: about to merge a cherry-pick to deployment. Speak now or forever hold your peace! [18:17:26] https://gerrit.wikimedia.org/r/204836 [18:17:36] gogogo. :) [18:17:58] ejegg: thanks! [18:18:09] (CR) Ejegg: [C: 2] Fail on any unrecognized CVV return codes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204836 (https://phabricator.wikimedia.org/T96393) (owner: Ejegg) [18:25:49] (Merged) jenkins-bot: Fail on any unrecognized CVV return codes [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204836 (https://phabricator.wikimedia.org/T96393) (owner: Ejegg) [18:27:45] hey ejegg or awight, I have a hopefully quick sillverpop import question :D [18:28:02] ccogdill: shoot! [18:28:03] I’m trying to qa a specific record on the file but not sure what db to query… [18:28:13] or I may not have access to it, but hoping i just don’t know the name [18:28:46] do you know if that’s something I can look at? [18:29:33] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/204839 [18:29:58] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/204839 (owner: Ejegg) [18:31:18] (CR) Awight: Fail on any unrecognized CVV return codes (2 comments) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204836 (https://phabricator.wikimedia.org/T96393) (owner: Ejegg) [18:32:15] ccogdill: switching to the private channel... [18:32:29] k! [18:34:16] (CR) Katie Horn: Fail on any unrecognized CVV return codes (1 comment) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204836 (https://phabricator.wikimedia.org/T96393) (owner: Ejegg) [18:34:58] Hmm. [18:35:07] I think maybe somebody killed off a trim at some point. [18:35:28] ooh, so the ' ' isn't totally new? [18:35:39] The single space has been with us all along. [18:35:43] K4-713: oh wow, that customfilters thing is magical. [18:35:44] eek [18:35:45] There is a code for a blank. [18:36:18] And by "blank" I mean empty string. [18:36:23] Words. [18:37:02] Seriously, this jetlag is worse than... [18:37:02] Probably related to my trampling of unstaging. [18:37:05] !log update payments from d37687239fa79842c0d6ea65e9230a3f14cda867 to f4ba034a8d55810276bbb7d4f861ceba7dfeaf2b [18:37:12] Logged the message, Master [18:37:15] awight: Ah, I don't know about that. [18:37:19] But maybe. [18:37:21] Who knows. [18:37:28] Anyway, now we have tests and things. [18:37:48] Also, I'd really like to know why they ever send a damn space, because it's not in their docs as a possibility. [18:39:09] There's even a code for "something went wrong with this test". [18:39:35] * K4-713 checks to see if anything ever goes wrong enough to get that code, but not too wrong that they just send a stupid space [18:43:24] Yes. Yes it does. [18:44:35] anyone got a good trick for getting certain terms hilighted in tail -f (as with grep) but still showing all the other lines [18:44:41] ? [18:45:43] ejegg: use less [18:45:47] oh hey, this works! tail -f file | egrep 'term|' [18:45:47] less +F [18:45:51] oh cool! [18:46:00] ooh, less has a follow mode? [18:46:03] yep [18:46:05] "F" [18:46:05] thank you! [18:46:17] and if you do a search ahead of time, it will stay highlighted [18:46:21] nice [18:46:23] huh [18:46:25] another cool feature is "&" [18:46:30] temporary grepping [18:46:31] wozzat? [18:46:32] Usually I just open like 20 windows. [18:46:48] You look much more busy when you do that. [18:46:57] :p [18:47:18] needs matrix font [18:47:37] And a browser window with a stack trace in it. [18:47:44] Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1216446 (CCogdill_WMF) NEW a:atgo [18:47:45] ejegg: I don't understand yr egrep pipe... that highlights for you? [18:47:46] Nobody will bother you. [18:48:12] awight: it matches the term or nothing, so it outputs all, but highlights the matched term [18:48:12] cool, yes it does! [18:59:08] Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1216520 (CCogdill_WMF) p:Triage>Normal [19:27:48] Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1216614 (atgo) @ccogdill_wmf - keep us posted about the test you run tonight. We may want to escalate priority if it's a bigger issue. [19:28:15] Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1216615 (CCogdill_WMF) @atgo will do! [19:55:23] Hmm grrrit-wm? [20:36:37] hey K4-713 - do you htink you'll be able to review those PCI docs soon? would be great to keep that ball a-rollin' [20:37:49] ... [20:37:58] Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1216925 (awight) I see a contact_id of both 614261 and 2416323 for that email address, but they both have preferred_language set to ca_ES as... [20:38:10] * K4-713 hums quietly to self, looks vacantly happy [20:38:32] I knew there was something. [20:38:47] atgo: You are talking about the... policy docs? [20:38:51] yes sorry [20:39:15] Ah. [20:39:19] Fundraising Sprint House of Pain, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adapt the Memcache queue subclass - https://phabricator.wikimedia.org/T92918#1216930 (atgo) @awight it looks like this one didn't make it to #sprinti... should it be over there? [20:39:36] atgo: I think you missed the part where I explained I am having a profound case of the Stupid today. [20:39:43] ha yeah i was a little late to standup [20:39:44] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adapt the Memcache queue subclass - https://phabricator.wikimedia.org/T92918#1216932 (awight) [20:39:44] https://phabricator.wikimedia.org/T91452 [20:39:55] K4-713: there's the task [20:40:22] atgo: I don't know if I'll be able to get to that today, but I'll try to remember it and not just throw it down a hole again. [20:40:33] sure! i figured today was a long shot, i just don't want it to fall off [20:40:41] it would be great to get it done in this sprint (which started yesterday) [20:41:04] aye. [20:41:18] also K4-713 ejegg|bike awight i know it's not ideal... but this guy is due tomorrow; https://phabricator.wikimedia.org/T94246 [20:41:27] [it'll be ok if we miss it until monday if it's high risk] [20:41:33] * K4-713 wanders off to have some whiteboard time [20:41:35] we don't have the translations yet either :) [20:41:46] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Monitor payments cluster memcache - https://phabricator.wikimedia.org/T96433#1216946 (awight) NEW a:awight [20:45:48] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Document how the new queuing stuff will work - https://phabricator.wikimedia.org/T96434#1216962 (awight) NEW a:awight [20:45:55] Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Document how the new queuing stuff will work - https://phabricator.wikimedia.org/T96434#1216970 (awight) [20:51:15] pizzzacat: Pinging to let you know there are a few more reviews for https://phabricator.wikimedia.org/T95951 if you have a chance. [20:51:50] thanks awight. I wasn't clear on how to run the tests so ejegg said he was doing that one. let me see... [20:51:56] ok, sure! [20:52:07] oy where are the patches [20:52:12] but u should probably get the tests running, anyway... [20:52:49] is there a wiki or something I can read to set it up? [20:53:25] yeah looks like the tests one is the only one needing review [20:53:36] https://gerrit.wikimedia.org/r/204011 https://gerrit.wikimedia.org/r/#/c/204020/ [20:53:45] unless I am missing something which is entirely possible [20:54:35] ok that second one [20:56:06] awight any tips on setting up tests to run? not sure where to start on that [20:56:23] Running the tests is bizarre. "php tests/phpunit/phpunit.php --filter FormTest" [20:57:51] oh that's it? [20:57:56] Hopefully... [20:58:14] ok. let me try it. [20:59:18] pizzzacat: also: You run that from the mediawiki-core directory. [20:59:31] ah was just gonna ask haha [21:00:27] do I have to install phpunit or is that already there? [21:01:04] Run "composer update" in the mw-core directory [21:01:54] so, everything looks like it's there, but it's saying it can't open phpunit.php [21:02:12] Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Document how the new queuing stuff will work - https://phabricator.wikimedia.org/T96434#1216962 (awight) [21:02:18] wait I think I was in the wrong place [21:02:19] what's the error? [21:02:21] ah [21:02:24] but still from core is problemming [21:02:32] Warning: require_once(PHPUnit/Runner/Version.php): failed to open stream: No such file or directory in /Users/sherahsmith/workspace/FundraisingInstance/core/tests/phpunit/phpunit.php on line 105 [21:02:43] lemme see [21:02:49] oh. you're using the fundraising branch :( [21:03:02] Getting phpunit working with our deployment branch is... way more difficult. [21:03:16] oh. [21:03:19] Oh god [21:03:24] ? [21:04:00] well, the thing to do is clone another mediawiki-core, and checkout master. [21:04:08] yeah… [21:04:09] if that sounds fun :x [21:04:23] I can do it [21:05:11] No rush for this project, but you should probably get the tests running as a background thing. [21:08:31] I will so the repo can get up to date [21:10:00] oh the joy of finding repos in gerrit [21:10:37] awight: so from this task https://phabricator.wikimedia.org/T92915 I should be looking at the blocking tasks for more? [21:10:57] Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1217052 (awight) NEW a:pizzzacat [21:11:18] AndyRussG: yes, here are the exciting ones: https://phabricator.wikimedia.org/T92916 and https://phabricator.wikimedia.org/T92921 [21:11:30] pizzzacat: LPT: type "filter" into your browser search bar to bring up the url for the gerrit search page, then change the value of the "filter" URL param to something you want to look for [21:11:43] such a good hack [21:11:58] * AndyRussG hugs modern browser location bars [21:12:07] I ended up just clicking "Project" [21:12:08] pizzzacat: I meant the location bar, sorrry [21:12:11] and doing a search there [21:12:27] Yeah but it takes 4evar, no? [21:12:33] I mean, just to bring up the list initially [21:12:36] just feels like when you type project in the search bar, the results should be the same [21:12:41] yeah totally [21:12:49] Yeah the UI sucks canal water [21:12:53] haha [21:13:00] yeah.. confusing as hell [21:13:11] Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1217063 (CCogdill_WMF) @awight that's interesting. When I queried the silverpop_export table, I used email = in the WHERE clause instead of... [21:13:31] fwiw, I noticed that gerrit works nicely on chrome-family browsers. The js assumes that your js engine is multithreaded. Stealth way to sell their browser... [21:13:35] awight: thanks! looking... [21:26:13] awight: whoa that's quite crazy to hear about chrome 'n' GWT, didn't know that [21:26:48] Oh, that's the issue? I didn't realize gerrit was built on GWT [21:26:52] what a dog [21:27:31] didn't you once hack on it? [21:27:43] maybe I'm imagining [21:28:25] I messed with Guice dependency injection, they're probably kissing cousins of some sort [21:29:25] ah yes right there's a GWT version of Guice called GIN [21:29:29] awight: did you see this from earlier? I pinged a bit back... https://phabricator.wikimedia.org/T94246 [21:29:38] expires tomorrow in theory, but if we miss it it's not the end of the world [21:30:57] atgo: urgh, I was trying to do that but missed the deployment window [21:31:05] mm ok [21:31:10] I think it's safe enough for a Fri deploy, though [21:31:12] Shall we? [21:31:15] if you want [21:31:19] k [21:31:22] it's also not the end of the world [21:31:23] if we miss. [21:31:28] i just would want to update the rest of the team [21:31:52] not the end from a legal perspective [21:34:01] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204936 [21:34:03] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204937 [21:34:05] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204938 [21:34:07] (PS1) Awight: Change recurring info text for new legal requirements [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204939 (https://phabricator.wikimedia.org/T94246) [21:34:25] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204936 (owner: Awight) [21:34:31] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204937 (owner: Awight) [21:34:40] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204938 (owner: Awight) [21:34:47] (CR) Awight: [C: 2] Change recurring info text for new legal requirements [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204939 (https://phabricator.wikimedia.org/T94246) (owner: Awight) [21:34:51] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204936 (owner: Awight) [21:35:09] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204937 (owner: Awight) [21:35:18] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204938 (owner: Awight) [21:35:56] (Merged) jenkins-bot: Change recurring info text for new legal requirements [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204939 (https://phabricator.wikimedia.org/T94246) (owner: Awight) [21:37:21] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/204940 [21:37:35] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/204940 (owner: Awight) [21:39:00] awight any idea about this error? Fatal error: Class 'UtfNormal\Constants' not found in /Users/sherahsmith/workspace/nonFundraisingCore/core/includes/title/MediaWikiTitleCodec.php on line 233 [21:39:17] this is when I run a core instance from master [21:39:58] pizzzacat: looks like u need "composer update" ? [21:40:06] I did that [21:40:33] !log update payments from f4ba034a8d55810276bbb7d4f861ceba7dfeaf2b to 46076dec9d82faa8660138f3b09342237891298b [21:40:38] Logged the message, Master [21:40:55] awight are you telling me to do something? [21:41:33] like, is that a command or…? [21:42:02] pizzzacat: yeah u should run that from the commandline, in mediawiki-core/, if you haven't already [21:42:25] ok cool [21:42:55] It's the new thing, probably will be the solution to any class not found errors going forward. [21:42:59] do you mean core/ ? [21:43:08] and it doesn't recognize !log ? [21:43:10] yeah [21:43:14] wait [21:43:34] sorry :) "!log" is just a deployment I was doing. That creates an entry in http://wikitech.wikimedia.org/view/Server_admin_log [21:43:51] ok so just get rid of the !log? [21:44:02] pizzzacat: dont' run that [21:44:13] ok I am confused now. [21:44:13] I was suggesting "composer update" [21:44:20] oh [21:44:24] that should install a bunch of files under core/vendor/ [21:44:25] I had already run that.. [21:44:27] k [21:44:36] oh maybe it was in the wrong directory. [21:44:37] Well, the file that's missing is "vendor/wikimedia/utfnormal/src/Constants.php" [21:44:39] lemme see [21:44:57] it also matters that you run the composer command after the git checkout [21:45:14] yeah I did, but I did it in the wrong directory (extensions) [21:45:18] k :) [21:45:21] it's running now from the top :) [21:45:27] jeeze [21:45:30] I was like hmm [21:45:52] It's a pretty janky package management system, but a lot better than the Nothing we had in the beginning! [21:46:23] awight: aht's a stomp frame and a stomp transaction? [21:46:34] hahah something from nothing [21:46:51] AndyRussG: I don't think this helps much, but https://wikitech.wikimedia.org/wiki/Fundraising#Message_Queue [21:47:04] lmk if there are topics I should cover in more detail! [21:47:04] big bang, then infinitely expanding galaxies of package management systems [21:47:16] What if the universe were just a big software repository? [21:47:21] luckily, it's very unlikely that they collide [21:47:29] Mmmm dependency error [21:47:34] I suppose it is, in the sense of Borges's library of babel [21:47:54] Ah hmmm [21:47:55] at least--it's isomorphic to a software repository [21:48:45] awight: thanks! [21:49:40] AndyRussG: a "frame" is just the STOMP term for a message. It includes the headers, which can be used in selector queries, and the message body. [21:49:54] what's stomp? [21:50:11] transactions are the usual--at least in theory you can wrap queue operations in a transaction, and commit or roll back as a group. [21:50:14] Maybe u mentioned it earlier? [21:50:26] STOMP is an ancient communication protocol for queueing [21:50:35] http://activemq.apache.org/stomp.html [21:50:41] Ah K I that's the ancient thing u mentioned, then... [21:51:25] Hopefully, we'll be killing stomp as the next phase in overhauling the queueing... [21:51:27] DI would rollback transactions as a group? [21:51:32] It's unsafe at any speed [21:51:40] Nah, we aren't using transactions afaik [21:54:10] So why's there a method doStompTransaction? [21:54:30] Or are we with 2 meanings of "transaction"? [21:55:01] AndyRussG: ah, sorry. That "transaction" just means, "a financial thing that happened" [21:55:20] We use that synonymously with, "donation" [21:56:36] awight do I run the phpunit FormTest command thingie inside DI extension? [21:56:51] what is the expected output? [21:56:59] like "passing" or something on the commandline? [21:57:48] pizzzacat: run the phpunit commandline from cor/ [21:57:49] core [21:58:07] success looks like, "...." "4 tests passed" [21:58:17] (CR) Ejegg: "Dang. It looked like the dynamic partials compile option lightncandy provides could give us a little modularization for e.g. personal inf" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204020 (https://phabricator.wikimedia.org/T95951) (owner: Awight) [21:58:20] failure will display a bunch of red F's [21:59:18] (CR) Awight: "I think this is a good time to push back on TemplateParser to make sure it will work for our needs..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204020 (https://phabricator.wikimedia.org/T95951) (owner: Awight) [21:59:24] it says "couldn't find a usable PHPUnit" [21:59:37] can I see? [21:59:46] see…? [21:59:52] pastie? [22:00:09] ~/workspace/nonFundraisingCore/core [master|…1] [22:00:09] ≫≫≫≫≫≫≫≫≫≫≫≫ php tests/phpunit/phpunit.php --filter FormTest [22:00:09] Couldn't find a usable PHPUnit. [22:01:01] pizzzacat: do you have vendor/phpunit/phpunit/phpunit ? [22:01:25] Also, did you install the wiki database yet? [22:01:42] oh wow lots of other steps. sorry! [22:01:51] umm is vendor supposed to be under core? because nope [22:02:33] awight, I can't just use the same db as I'm using with fundraising instance? [22:02:50] pizzzacat: that's what gets created by "composer update" [22:02:58] no, the db is not compatible [22:03:04] oy [22:03:07] hehe [22:03:13] Now that I've ruined your day... [22:03:17] ok, how do I set it up? [22:03:42] is there a wiki with the remaining steps I need to complete before I can run tests? [22:03:43] The best way is probably to add another apache site for the mediawiki-core directory [22:04:16] http://www.mediawiki.org/wiki/Manual:Installation_guide [22:04:57] err... actually, that doesn't cover installing from code [22:04:59] gah [22:05:47] i've been running the tests with 'make phpunit' this whole time. is that outdated? [22:05:59] hmm [22:06:00] omg. That sounds nice [22:06:12] ejegg on core? [22:06:17] ejegg: where is that? [22:06:20] master I mean? [22:06:29] yeah, i have a separate checkout for unit tests [22:06:31] I don't see a makefile [22:06:52] it's in tests/phpunit [22:07:22] though it's a little funky to pass options [22:07:42] e.g. make phpunit FLAGS="--group CvvResult --log-json=log.json" [22:07:50] awight are you going to be in on Monday? [22:08:06] this is way easier in person [22:08:13] pizzzacat: yep, sure! [22:08:19] and not critical to the stuff I'm supposed to be doing right now [22:08:24] yah [22:08:25] ah ok great! [22:08:28] nice to have [22:08:33] prob less annoying for all! [22:08:50] Not annoying for me, other than feeling like a jerk :) [22:08:55] haha nah [22:09:04] :) [22:09:22] There's a script that lets you install everything from the commandline. And here's its documentation: http://www.mediawiki.org/wiki/Manual:Install.php [22:09:25] HAHA [22:09:26] hey awight - saw you moved that recurring card to "done" but... it's not updated [22:09:35] oh [22:10:17] atgo: https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=cc-vmad&recurring=true&uselang=en&language=en¤cy=EUR&country=US&amount=2 [22:10:26] maybe you're cached? [22:10:37] quite a linky mouthful [22:10:38] would it not update on donate as well? [22:10:44] that's separate, huh. [22:10:52] yep [22:10:54] hmm [22:10:54] ok [22:11:04] Oops. Lemme deploy there as well [22:11:11] Thank you for checking! [22:11:11] thanks! [22:20:44] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1217327 (awight) [22:20:49] awight: k... so what did u mean "at least in theory you can wrap queue operations in a transaction, and commit or roll back as a group"... PS if ur deploying pls go ahead and ignore... [22:21:48] AndyRussG: "stomp transaction" sounded like this thing that we don't use, which sort of gives ACID properties [22:26:06] Ah K got it [22:27:15] So just to recap (sorry for the uselessy questions) there is a thing in "stomp" called a transaction that we don't use, but in DI a donation can also be called a transaciton, so "doStompTransaction" means do a (WM-fundraising) transaction using STOMP, yea? [22:28:22] lol [22:28:29] yep [22:28:47] sorry u caught me off-guard with "stomp transaction" [22:29:02] hopefully you have a tin foil helmet for this expedition [22:31:17] No only a fanatical devotion to the pope [22:31:47] Those are the two things you'll need. [22:32:20] The tin foil helmet, and a fanatical devotion to the pope. And nice red uniforms. THREE. [22:32:29] awight: l10n using just TemplateParser seems like it'll be a pain too. Flow's using ligtncandy w/o wrapper to go full-handlebars and register helper functions for translating messages and a bunch of other things. [22:33:37] marktraceur: mmm my red guantlet is a tad soiled [22:33:46] ejegg: side thing--what did you do about the trait file when deploying? [22:33:55] I'm getting killed by a php -l on tin... [22:34:13] AndyRussG: Gotta throw down the gauntlet. Into the hamper. [22:34:24] heheheh [22:34:33] oh, never actually deployed onto donatewiki [22:34:40] nobody expects the Spanish Inquisition... [22:34:41] but i did make a patch to delete that file [22:34:47] rats, k [22:35:21] hmm, looks like it got merged into vendor [22:35:29] awight: I should set that as my default kick message. [22:35:58] an african or a european swallow? [22:36:10] but I never updated the submodule pointer in the deployment branch [22:36:12] hehe, you get kicked often? [22:36:39] ejegg: no worries, these are excellent breadcrumbs [22:36:43] awight: No, but I kick people sometimes. [22:37:01] awight: ecae7c1b55eb0317c798877170208f6274606771 [22:39:18] (PS1) Awight: Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204958 [22:39:28] (CR) Awight: [C: 2] Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204958 (owner: Awight) [22:39:57] (Merged) jenkins-bot: Update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/204958 (owner: Awight) [22:43:12] why does transactionDirect_Debig no longer call doLimboStompTransaction( true ); but instead calls $this->deleteLimboMessage( 'limbo' );? [22:44:50] AndyRussG: that's where it gets freeky. This is after the WIP orphan patch, right? [22:45:09] the "true" argument meant, send an antimessage [22:45:29] so instead, we delete the message directly. (and that's weird that I left a queue name in there) [22:45:50] oh right, the queue name was to support the glocalcollect-cc-limbo special case [22:46:52] Hmm [22:46:57] awight: ejegg: without understanding much of how this code works, my overall impression so far is that there are so many interacting parts here that I would definitely want to draw up some "before" and "after" diagrams and have written notes [22:47:33] yeah, there are a lot of moving pieces to track [22:47:40] Do you have api, object or interaction diagrams? [22:47:54] we have the sweatshirt :) [22:48:03] for sweating in? :) [22:48:46] *this* is the sweatshirt :D https://wikitech.wikimedia.org/wiki/Fundraising#/media/File:DonationPipeline_201302.png [22:49:54] The patch I'm looking at is Use DonationQueue for non-orphan queuing, which follows Write DonationQueue shim around PHPQueue [22:50:32] link sez ^"Sorry, the file cannot be displayed" [22:51:16] Yea when atgo-away suggested a diagram for the new banner history stuff, and it ended up being an interaction diagram, I found that really useful [22:52:28] Sounds like this change is even more complicated, and there could be unexpected edge cases that might be teased out by looking at a visual representation [22:52:29] https://wikitech.wikimedia.org/wiki/File:DonationPipeline_201302.png [22:53:16] Totally. It's also been helpful to have K4|whiteboard explain the orphan stuff I hadn't bothered to fully understand :( [22:54:05] It's okay. It's all weird in there. [22:54:11] heheh [22:54:18] Let me attempt to take a picture of this mess I just made. :) [22:54:19] It's okay, it's like that everywhere [22:54:28] K4|whiteboard: ah fantastic! thx [22:54:42] Or rather, a picture of the neat diagram of the mess I made three years ago. :D [22:55:04] three years is nothing [22:55:07] ejegg: Thanks for doing tha tpatch! I'm able to deploy now [22:55:14] hooray! [22:55:27] I wish I had time to do this every week. [22:58:32] K4|whiteboard: ejegg: awight: I'm about to take off to contribute to Diseny's family mind control... ir... I mean, entertainment contribution... (taking our older daughter to see a movie, since the younger one got to go to the sleepover party...) I should get backscroll but it'd be great if you'd like to send stuff by e-mail, also... thanks and apologies! [22:59:01] enjoy the show! [23:01:16] ejegg: thanks! [23:01:33] AndyRussG: okay, don't take the tin foil off! [23:01:51] K maybe I could put a wig over it! [23:02:41] awight: Mmm last comment, dunno if it's easy but yea those boolean params would be fun to make more self-explanatory somehow, I guess? [23:03:03] No idea if that's in-scope or way outside [23:04:26] AndyRussG: I think I killed that one boolean param, to doStompTransaction [23:04:34] In general, hell yeah that's a great way to go [23:05:11] Ah right, doLimboStompTransaction( true ); is in the old version, not the new! cool, sorry about that [23:05:23] Have a great weekend all! "C" ya in the digital air ducts! :D [23:06:25] -pia [23:06:37] Disinfony? [23:08:00] or disnssonance [23:08:15] cya :) [23:23:21] Fundraising-Backlog, Patch-For-Review: Update error messaging on donate form (pre-payment fields) - https://phabricator.wikimedia.org/T96066#1217416 (awight) @atgo @pizzzacat: The refactor will use the existing error strings, so there's no conflict. Thanks for checking! [23:47:18] Fundraising-Backlog, ops-fundraising: Need Civi access for Donor Services agent - https://phabricator.wikimedia.org/T95011#1217495 (CCogdill_WMF) Hey @Jgreen, was Kristie included in the list of people who you send the cert update to earlier this week? If you could give us an ETA on when she can get set... [23:53:30] awight or K4-713 where does Dash documentation go? did we agree mediawiki? (weird)? [23:53:45] bahaha [23:53:49] Flip a coin. [23:53:57] I'm... I might be kidding. [23:54:19] haa [23:54:26] Right now, the overall consensus seems to be that everything goes on mediawiki.org, whether or not it has anything to do with mediawiki. [23:54:29] * K4-713 shrugs [23:54:39] ok, that's what I thought I heard you say yesterday [23:54:49] Sounds like me, yeah. [23:54:58] checks out. [23:55:53] I mean, unless you're planning on using a bunch of wacky templates, it shouldn't be difficult to move if the tides turn. Again. [23:56:13] Better to have it in the wrong place, than nowhere.