[00:29:26] (PS1) AndyRussG: Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [00:30:20] (CR) jenkins-bot: [V: -1] Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [00:32:14] (CR) AndyRussG: "This patch set is just code rolled out from I9f80edcbcacca26e9f8dea041b1da027d2ed9ec9 (without changes from CR or other fixes yet)." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [03:39:34] (CR) AndyRussG: "(Note: the exception to the above is that in I9f80edcbcacca26e9f8dea041b1da027d2ed9ec9, the method filterAndTransformBanners() was comment" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [07:30:33] (PS2) AndyRussG: WIP Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [07:32:01] (CR) AndyRussG: "...removed BannerChooser and AllocationContext, since they're not used, though I felt a bit sad about the latter." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [07:32:05] (CR) jenkins-bot: [V: -1] WIP Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [10:45:05] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1220354 (Pcoombe) Thanks all! @awight : that was just a local donate wiki snafu. We h... [15:50:09] Wikimedia-Fundraising-CiviCRM: several fundraising user client SSL certificates expiring 2015-04-15 - https://phabricator.wikimedia.org/T95200#1220803 (Jgreen) Open>Resolved CRL published revoking the old certs for the abovementioned users [16:12:45] ops-fundraising, operations, network: pfw-eqiad JunOS upgrade - https://phabricator.wikimedia.org/T96569#1220888 (faidon) NEW [16:15:03] ops-fundraising, operations, network: pfw-eqiad JunOS upgrade - https://phabricator.wikimedia.org/T96569#1220906 (Jgreen) [17:06:59] pizzzacat: globalcollect_gateway/forms/css/gc.css [17:22:16] Fundraising-Backlog: Enabling Paypal in local currency (RMB) for China - https://phabricator.wikimedia.org/T96062#1221169 (atgo) p:Triage>Normal [17:24:39] Fundraising-Backlog: Enabling Paypal in local currency (RMB) for China - https://phabricator.wikimedia.org/T96062#1221174 (atgo) [17:24:59] Fundraising Sprint J, Fundraising-Backlog: Enabling Paypal in local currency (RMB) for China - https://phabricator.wikimedia.org/T96062#1207432 (atgo) [17:25:18] hey awight ejegg K4-713 - what's an estimate look like for that one? ^ [17:25:28] * K4-713 blinks [17:25:46] atgo: looks easy, a few hours... [17:25:54] maybe 2 pts? [17:25:57] Just in time for PAyPal to change their mind :) [17:25:59] sure [17:26:02] If it really is as easy as adding a currency code to a list? 1. [17:26:09] mmk [17:26:54] * currency code added to list * locale list verified * form settings updated * deployment [17:26:59] atgo: I will have to make a small change in the banners and donate too, once the tech side is done [17:27:05] plus that :) [17:27:15] thanks awight and the-wub! [17:34:34] Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1221189 (atgo) p:Normal>High Changing to high priority because we have some concerns about unsubscribes. [17:34:46] Fundraising Sprint J, Fundraising-Backlog: BUG: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1221191 (atgo) [17:45:37] pizzzacat: https://github.com/wikimedia/integration-jenkins/blob/master/bin/mw-install-sqlite.sh [17:51:09] hey awight the-wub - one more question about the pp/rmb thing. could we a/b test those if we set up for rmb? [17:51:17] i'm assuming we could keep 2 forms pretty easily [17:51:51] atgo: it should be fairly easy from the banner side [17:51:57] you can pass in a form name from the banner, so yeah, we should be able to do that test [17:52:05] cool [17:52:07] sounds gouda [17:56:51] hey AndyRussG - regarding lang variants, we don't have that work tracked totally in phab, right? [17:57:05] we currently just have https://phabricator.wikimedia.org/T55641 which is only the CN part [17:58:02] Hey atgo, how go the stuffies? ;) [17:58:09] hey! you know, the stuffiest. [17:58:14] awww [17:58:28] but i finally bucked up and made an appt to see a doctor so hopefully we can figure out why i'm ALWAYS getting sick [17:59:33] ah! sounds like a plan... Like 15 years ago I was going through a bout of always getting sick, always sore throats [18:00:07] and how did you stop doing that? [18:00:12] Turned out it was the pollution in Mexico City, or some kind of airborne allergen, or both... Got better with a combination of antihistamine and exercise [18:00:34] Basically the allergies would give me a runny nose and the dripping mucus was iritating my throat [18:01:03] And I guess that would make me suseptible to actual colds 'n' stuff [18:01:06] and then moving to canada :) [18:01:18] yeah that makes sense... i wonder often if it's somewhat environmental [18:01:24] my house is old and has carpet [18:01:36] heh that was a lot more recent... but yeah I've had less allergies.. [18:01:50] Ah carpet! that can hold so much dust [18:01:55] Do you have a Roomba? [18:01:59] i have a vacuum [18:02:03] it's like a roomba [18:02:06] but you have to drive it [18:02:19] :) [18:02:25] we have a lot of stairs, so roomba would probably die. also honey would be a jerk about it FOR SURE [18:02:44] We got a Roomba like a month ago and you wouldn't believe the amount of dust it sucks up! [18:02:59] It totally avoids the stairs by itself, no issues there [18:03:30] We've been running it every other day or so and it's _always_ picking up tons of dust [18:04:04] It may be less powerful then the vaccum but if you can run it a lot more.. [18:04:45] hmm i'll look into it [18:04:50] thanks AndyRussG! [18:05:30] My kids also got sick a lot when they were small, probably also due to allergens/pollution, and what helped them was getting their tonsils and adenoids out (which they also needed due to sleep issues) [18:05:36] atgo: np! :) [18:05:47] hm [18:06:00] WRT language variant stuff... [18:06:24] yeus [18:06:27] yeah I'm pretty sure we don't have anything in Phab besides that card [18:07:22] ok [18:07:26] is there other work though? [18:07:36] i'm looking at this: https://www.mediawiki.org/w/index.php?title=Fundraising_tech/Language_variants [18:07:49] and it sort of seems like everything would consume the ISO code from the banner? [18:10:53] atgo: I guess that sounds right, I'll have to re-download that stuff into my brain to be able to semi-know what I'm talking about again... [18:11:01] hm ok [18:11:05] sorry for putting you on the spot :) [18:11:12] Ah no problem :) [18:12:13] I mean, yes everything further along in the donation pipeline will get info sent when the user clicks on something in the banner, so in principle, yes [18:12:37] At this point I'm not totally sure it's an ISO code exactly, but something like that [18:13:01] pizzzacat: https://gerrit.wikimedia.org/r/p/mediawiki/extensions/ContributionTracking.git [18:13:29] awight: could you perchance weigh in on this lang variants thing? [18:14:34] awight: https://www.mediawiki.org/w/index.php?title=Fundraising_tech/Language_variants [18:14:40] also, boo! [18:15:09] Hmm since I've changed my default desktop font you all look so very different [18:15:22] But so do I [18:17:02] atgo: should I be getting back into gear on the language variants issue? I guess you want some more specific cards? [18:17:42] we've got to figure out if we want to tackle this for the potential China campaign (which may actually be yet a ways off) [18:17:59] so if you've got a minute, it would be great to detail a bit more (perhaps under an Epic about lang variants) [18:18:06] but really just a rough estimate would be great [18:19:53] (CR) Ejegg: "Ahh, the old queue-wrapper-wrapper! Code + tests look good. Got 2 questions about newBackend calls, and some WS to normalize in TestingQue" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) (owner: Awight) [18:23:32] (CR) Ssmith: [C: 2] Tests for the Handlebars form renderer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204011 (https://phabricator.wikimedia.org/T95951) (owner: Awight) [18:24:13] (Merged) jenkins-bot: Tests for the Handlebars form renderer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204011 (https://phabricator.wikimedia.org/T95951) (owner: Awight) [18:25:11] atgo: AndyRussG: I'm too slender to weigh in for much, but let's try to standardize on BCP-47 language tags, and avoid any MediaWiki mutant codes or ISO stuff. [18:25:36] :P [18:25:54] (CR) Ssmith: [C: 2] Change English error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204798 (https://phabricator.wikimedia.org/T96066) (owner: Pcoombe) [18:26:08] awight: in general, at a very broad pass, would we call this whole effort 8 pts? 16? [18:26:10] AndyRussG: ^ [18:26:19] (CR) Ssmith: [C: 2] Correcting s/handlebars/mustache/ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204020 (https://phabricator.wikimedia.org/T95951) (owner: Awight) [18:26:19] sorry for bombaring you guys with this [18:26:44] (Merged) jenkins-bot: Change English error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204798 (https://phabricator.wikimedia.org/T96066) (owner: Pcoombe) [18:26:47] atgo: What's our milestone? Just getting pt-BR and zh-classical working? [18:26:57] (Merged) jenkins-bot: Correcting s/handlebars/mustache/ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/204020 (https://phabricator.wikimedia.org/T95951) (owner: Awight) [18:27:02] yeah [18:27:22] if we can do something more robust, great, but those are the 2 we're coming up on soon [18:27:28] oops! zh-Hant vs zh-Hans [18:27:35] not "zh-classical" [18:28:28] i got what you were going for :) [18:28:58] atgo: I think the whole thing is < 8 points, it's just a matter of being more careful about how we pull in the preferred language, normalizing it according to some rules that I've already written in https://github.com/adamwight/LanguageTag (and might be present in MW-core these days), then not damaging that data as it's passed down the pipeline. [18:29:33] cool, thank you [18:31:14] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1221537 (awight) [18:31:18] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Patch-For-Review: Add mustache templating engine gateway form renderer - https://phabricator.wikimedia.org/T95951#1221536 (awight) Open>Resolved [18:31:21] AndyRussG: Check-in? [18:31:34] ccogdill: MBeat: Is today a good day for sketchy DonationInterface deployment? [18:31:49] haha sketchy? is this the one from last week? [18:31:53] I don't see why not [18:31:54] today is fine for me [18:32:07] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1221542 (awight) @pcoombe: Thanks for finding that! [18:32:11] guys. sudafed is magic. [18:32:14] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1221543 (awight) Open>Resolved a:awight [18:32:33] ccogdill: yep, it's the one from last week [18:32:36] Ok thanks! [18:32:41] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1221546 (atgo) [18:32:54] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1158117 (atgo) Updated title because there will be follow-on deploym... [18:33:00] just let us know when awgith [18:33:03] *awight [18:33:15] and yay sudafed! I hope you’re good to scuba atgo [18:33:16] Fundraising-Backlog, Epic: Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#1221549 (atgo) NEW [18:33:22] ccogdill: MBeat: fwiw, This is meant to fix the Catalan language corruption, but it might have unintended side-effects and could cause other data corruption :( [18:33:39] anything specific we should watch out for? [18:33:41] me too ccogdill... made an appt with a doctor :) [18:33:46] good idea :) [18:33:55] ok, we will watch Zendesk for anything unusual [18:34:07] Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, I18n: zh-..., pt, and other language variants are not supported by CentralNotice - https://phabricator.wikimedia.org/T55641#1221559 (atgo) [18:34:09] Fundraising-Backlog, Epic: Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#1221558 (atgo) [18:34:31] Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, I18n: zh-..., pt, and other language variants are not supported by CentralNotice - https://phabricator.wikimedia.org/T55641#588090 (atgo) [18:34:33] Fundraising-Backlog, Epic: Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#1221549 (atgo) [18:34:46] Fundraising-Backlog, Epic: Support language variants throughout donation pipeline - https://phabricator.wikimedia.org/T96594#1221549 (atgo) [18:35:41] ccogdill: I think a good weathervane would be that donor's language is correct in CiviCRM. I'll be spot-checking a few. [18:37:59] Fundraising Sprint J, Fundraising-Backlog: Enabling Paypal in local currency (RMB) for China - https://phabricator.wikimedia.org/T96062#1221603 (atgo) [18:38:26] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/205304 [18:38:43] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/205304 (owner: Awight) [18:39:08] (Merged) jenkins-bot: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/205304 (owner: Awight) [18:46:33] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/205335 [18:46:44] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/205335 (owner: Awight) [18:47:15] ccogdill: MBeat: I'm ready to deploy, please let me know if I should hold off for any reason. [18:47:30] deploy away, awight! [18:47:32] all systems go, from here [18:47:37] thx! [18:49:49] !log update payments from 46076dec9d82faa8660138f3b09342237891298b to 88b9f621bfee1de14a8cdef556a90e5567721754 [18:49:55] ccogdill: MBeat: ^^ deployed! [18:49:57] Logged the message, Master [18:50:24] thanks for the headsup, awight [18:50:27] :D [18:50:42] mbeat, I’ll leave it up to you to decide if you want to test donate the catalan form [18:50:47] see if your language sticks with you [18:50:56] or just wait to hear from donors about it [18:51:29] i've got a spare $, will give it a go [18:51:36] :) [18:51:48] grr, Catalan did not work for me [18:52:01] hmm, maybe hold off on it, MBeat [18:52:48] awight are you rolling it back? would it help for us to test a few other languages/ [18:53:11] ccogdill: I won't roll it back unless it's breaking anything... [18:53:18] fair enough [18:53:29] ccogdill: please do test one or two other langs though, just to confirm it's working at all :( [18:53:40] okay, will try uk [18:54:39] I hit a velocity filter... [18:55:37] awight I did a uk test donation [18:55:42] and got a combo ru/en TY page [18:55:44] whatever that means [18:55:52] yikes [18:55:59] uk meaning ukraine, not united kingdom [18:56:09] I just got an English error page for a Spanish donation--is that a known bug? [18:56:14] https://payments.wikimedia.org/index.php?title=Special:GlobalCollectGateway&appeal=JimmyQuote&ffname=error-cc&gateway=globalcollect&country=US¤cy_code=USD&amount=1.04&language=es&utm_source=fr-redir.default~default~default~default~control.cc&utm_medium=spontaneous&utm_campaign=spontaneous&payment_method=cc [18:56:28] awight: can i be testing something? [18:56:29] this problem keeps coming back [18:56:37] feels like we fixed it a few times... [18:56:45] yeah the no translation for error thing has been persistent [18:57:01] atgo: thanks [18:57:07] yeah what should i test? [18:57:36] ccogdill: fyi, I correctly received a Spanish thankyou page, so I think basic stuff is working. [18:57:55] atgo: It looks healthy... [18:57:57] okay, so just the small variants that aren’t working [18:58:08] oh ok [18:58:09] fwiw my civi record for the uk donation shows no preferred language [18:58:12] ccogdill: yeah, which is what I thought I had fixed. [18:58:23] ccogdill: that's bad. [18:58:32] well… at least nothing’s changed [18:58:34] Can you compare to behavior before this deployment? [18:58:36] oh, ok :) [18:58:41] nope I think it’s the same [18:59:02] atgo - do you know if there’s a current phab task for that error translation issue? [18:59:06] simply unsettling [18:59:12] yeah [18:59:12] let me look... i know we had one [18:59:19] yeah I just thought it was solved... [18:59:26] I want to fix that... right now. That's the worst. [18:59:32] https://phabricator.wikimedia.org/T94604 [18:59:39] ccogdill: ^ [18:59:53] Fundraising-Backlog: Language error in "Transaction could not be accepted" page - https://phabricator.wikimedia.org/T94604#1221782 (atgo) p:Triage>Normal [19:00:10] oop, I guess I wrote that… thanks, atgo! [19:00:35] :) [19:03:49] catalan-language form donation reached GC w/English as preferred language [19:04:35] & Civi in EN as well [19:04:48] yep, it’s looking like the change didn’t stick :( [19:10:42] atgo: awight: yeah agreed with awight's points on language variants above ^ [19:10:57] thanks :) [19:13:02] np! [19:19:29] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: BUG: Catalan donate flow is not retaining language data - https://phabricator.wikimedia.org/T94506#1165355 (awight) Deployed patches made no difference! [19:29:51] (PS1) Awight: Fix totally wrong language things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205348 (https://phabricator.wikimedia.org/T94604) [19:30:26] Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Language error in "Transaction could not be accepted" page - https://phabricator.wikimedia.org/T94604#1222014 (awight) [19:32:59] Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Language error in "Transaction could not be accepted" page - https://phabricator.wikimedia.org/T94604#1222024 (awight) The issue is that we're not including the "uselang" parameter in the error page, and the "language" param is not... [19:38:11] (PS2) Awight: Fix totally wrong language things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205348 (https://phabricator.wikimedia.org/T94604) [19:46:39] (PS1) Awight: "language" parameter will work without "uselang" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205354 (https://phabricator.wikimedia.org/T94604) [19:47:10] Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: BUG: Language error in "Transaction could not be accepted" page - https://phabricator.wikimedia.org/T94604#1222107 (awight) [19:50:29] awight: I have a question about the language things patch... [19:50:34] Wait. It's lunch time. [19:50:37] Bah. [19:50:54] K4-713: hehe [19:51:03] What was going wrong with that? [19:51:10] There are a few things wrong [19:51:12] I can tell you exactly why all that was in there. [19:51:18] Maybe it's not relevant anymore... [19:51:33] The bigger patch is just cleaning up a bunch of garbage that was supposed to be doing language fallbacks but was not. [19:51:46] No, it was supposed to be... not doing fallbacks. [19:51:48] Kind of. [19:51:56] The second one is more exciting. It causes the "language" parameter to always override "uselang" and default settings. [19:52:06] ok, perfect then :) I removed the fake code [19:52:13] * K4-713 frowns [19:52:38] We... should talk. [19:52:40] I think it all blames to me... it's better this way [19:52:43] When I'm not between meetings. [19:52:45] k [19:52:52] I don't know about that. I remember having to do a lot of this. [19:53:02] Maybe you cleaned up my whitespace or something. :p [19:53:03] Feel free to -1 that stuff or tell me to, if you think it's sketchy [19:54:12] ha, no, I remember that mwalker was doing a fancy language fallback patch in mw-core, and I probably got inspired to do the same thing in ... DataValidator. But without actually implementing anything useful. [19:54:48] The problem is (or rather was... not sure if it's still this way) was that we were trying to determine that a message existed in a specific language. But the core stuff would, for instance, tell you the message existed even if it had already fallen back to something. [19:54:57] So... that might have improved in core. [19:55:19] Which wold be great. [19:55:35] Right. OK i can buy that. The === english thing was not really ok, so I'll block that patch and look in more detail. [19:56:37] (CR) Awight: [C: -1] "Need to confirm that we're doing "messageExists" correctly, the old workaround was because mw-core would say a message existed even if it " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205348 (https://phabricator.wikimedia.org/T94604) (owner: Awight) [19:56:45] At any rate: TESTS. :D [19:56:52] Seriously. [19:56:56] They make me believe you more. [19:57:52] (PS3) Awight: Fix totally wrong language things [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205348 [20:00:11] awight: not really important I guess, but your commit message sounds like your patch is fixing the wrong things... ;) [20:00:25] :) [20:00:59] Wrongly fixing unjust status quo [20:01:40] Two wrongs walked into a bar one day [20:01:59] ... [20:03:43] AndyRussG: virtual meet? [20:04:27] yurp [20:13:03] atgo: pizzzacat: is there anything you want me to look at/read over before we mete? [20:14:09] not off hand, no [20:14:19] hey ejegg - could we check in on astropay at some point? [20:14:35] because.. it looks like we're not going to make our target: https://phabricator.wikimedia.org/project/sprint/burn/1134/ [20:14:42] I don't have anything either AndyRussG [20:15:04] atgo: sure, any time works for me [20:15:14] k. i'll ping you this afternoon [20:15:17] ok [20:17:26] atgo: pizzzacat: k thanks :) [20:17:31] We had a page somewhere with notes, no? [20:17:52] AndyRussG: https://etherpad.wikimedia.org/p/centralnotice [20:19:28] pizzzacat: thanks! Yeah bookmarking that one... [20:33:34] * pizzzacat pizzzaMeeting [20:33:40] um [20:33:57] * pizzzaMeeting knows how to IRC [20:36:48] https://gerrit.wikimedia.org/r/#/c/202310 [20:36:55] haha pizzzaMeeting [20:38:08] https://phabricator.wikimedia.org/T90915 [20:38:48] https://gerrit.wikimedia.org/r/#/c/202310/10/modules/ext.centralNotice.adminUi.campaignManager/campaignMixinParamControls.mustache [20:40:05] https://gerrit.wikimedia.org/r/#/c/202310/10/CentralNotice.php [20:49:26] atgo-call: re: astropay burndown, I've reviewed and merged a lot of work that isn't reflected on that board, cos it's 90% done... [20:50:42] https://www.mediawiki.org/wiki/Extension:CentralNotice/Notes/Campaign-associated_mixins_and_banner_history [20:50:54] ejegg: if you get bored, https://gerrit.wikimedia.org/r/205354 [20:51:14] taking a look [20:51:29] O_O that was fast [20:52:09] It should fix an extremely embarrassing bug. I hear 5-20% or more of non-English donors get an English error page. [20:52:46] ooh, i see... [20:54:46] Fundraising-Backlog, ops-fundraising: Need Civi access for Donor Services agent - https://phabricator.wikimedia.org/T95011#1222349 (Jgreen) >>! In T95011#1217495, @CCogdill_WMF wrote: > Hey @Jgreen, was Kristie included in the list of people who you send the cert update to earlier this week? If you could... [20:54:52] atgo-call: minor thing--I think language variants block HK but not CN, or am I misunderstanding? [20:54:59] that's right [20:57:25] (CR) Ejegg: [C: 2] "Seems like the simplest solution at this point." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205354 (https://phabricator.wikimedia.org/T94604) (owner: Awight) [20:57:59] (Merged) jenkins-bot: "language" parameter will work without "uselang" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205354 (https://phabricator.wikimedia.org/T94604) (owner: Awight) [20:58:04] Fundraising Sprint J, Fundraising-Backlog: Enabling Paypal in local currency (CNY) for China - https://phabricator.wikimedia.org/T96062#1222354 (awight) [20:58:30] Fundraising Sprint J, Fundraising-Backlog: Enabling Paypal in local currency (CNY) for China - https://phabricator.wikimedia.org/T96062#1207432 (awight) Just to avoid confusion, I've corrected the currency code to "CNY". [21:00:36] atgo-call: OK thanks, I see now. We might consider splitting that campaign, since CN and HK are blocked on totally different issues. [21:04:06] well they want to run the campaigns together, so it's really one thing [21:04:10] for us [21:04:13] oook, no prob [21:04:24] awight re: astropay, that's exactly the kind of info i'm looking for [21:04:33] ejegg awight quick IRC checkin about astropay? [21:04:59] or hangout if you want, i'm easy :) [21:05:34] either way works [21:05:57] ejegg has been cautiously kicking down all the doors. [21:07:04] The frontend is probably over halfway done [21:07:53] either way works for me too [21:08:02] The work remaining includes pizzzacat's form refactor, which is over the first speedbump, now that I've implemented a simple Mustache template engine. [21:08:28] pizzzacat and I have unilaterally decided that we're trying to support just Brazil CC in this first iteration. [21:08:33] Which is a pretty big caveat. [21:08:59] There's a WIP for 90505 (add forms to settings), but that'll probably change with pizzzacat's work [21:09:16] and I guess I have been working on 90504 in parallel with 90503 [21:09:33] AFAIK, none of the backend stuff has been started yet... [21:09:39] but I haven't done anything with queue messages yet, and probably shouldn't till we merge awight's other stuff [21:09:52] ejegg: nah, go ahead! [21:09:58] right, I've done nothing for the backend [21:10:00] u mean, like listeners? [21:10:11] or do you mean a limbo queue? [21:10:37] yeah, i just haven't got it dropping messages in limbo [21:11:21] and the resultswitcher stuff I've got locally would need limbo deletion added later [21:11:29] ahh. Ok, for limbo, I agree that waiting for the dust to settle makes the most sense [21:12:08] cool [21:12:21] yeah... queue stuff is in the 2nd bit according to how we broke this out before [21:12:25] https://phabricator.wikimedia.org/project/sprint/board/1134/ [21:12:42] good point [21:13:02] i think we need to confirm with pp and the rest about focusing on brazilian credit cards only for the first pass [21:13:03] atgo ah, that makes sense. we did have something about queues in 90504, but we could break that out [21:13:22] whatever you want to do is fine by me, i just want to make sure we're on track :) [21:13:25] atgo: I started that conversation, but haven't communicated a schedule yet [21:13:35] yeah, well there's a requirements checkin on thursday [21:13:40] that's the right time to ahve the talk about this [21:13:43] got it [21:14:09] ejegg: looks like PPena forgot to include you on that one... but i just added you [21:14:15] thanks! [21:14:53] i'll review that doc + comments again, add any questions [21:15:08] It got... 50 pages longer :D [21:15:19] detail! [21:17:35] ejegg sorry! :) [21:17:46] atgo pls add anyone else that I may have missed [21:17:58] done :) [21:19:57] PPena: no worries [21:32:19] awight ejegg - so do things seem on track to you? [21:32:47] atgo: yes, I think so! [21:33:08] there are 4 points about to tip, and another 4 with pretty good progress [21:33:35] cool.. so that'll still leave 15 [21:33:42] and < 1 month [21:35:23] that green line has clever plateaux for weekends, but it didn't reflect the vacation. So I think that's still OK. [21:35:43] atgo: IMO expanding from BR-CC to all countries and methods is a really big effort. What are we estimating here? [21:36:02] haha fair enough ejegg - i don't think we can override that :) [21:36:08] err, I mean what is that milestone at the end of the burndown? [21:36:18] awight: that's a good question... and something we should elaborate on thursday morning. [21:36:21] k [22:04:25] (PS11) Awight: Write DonationQueue shim around PHPQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) [22:04:34] (CR) Awight: Write DonationQueue shim around PHPQueue (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) (owner: Awight) [22:08:49] (CR) Ejegg: "Sorry to leave such murky comments - I meant the PHPdoc var name should be 'options' not 'overrides', and that you never call this protect" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) (owner: Awight) [22:09:44] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Deprecate "language" parameter - https://phabricator.wikimedia.org/T96621#1222672 (awight) [22:11:09] Fundraising-Backlog, ops-fundraising: Need Civi access for Donor Services agent - https://phabricator.wikimedia.org/T95011#1222674 (CCogdill_WMF) Done! I need to confirm the number is her cell, as I'm not sure. https://office.wikimedia.org/w/index.php?title=Contact_list [22:11:49] (CR) Awight: "Oh! Good point, I hadn't thought about the protectedness. I think you're right, cos options really are specific to the backend, which Do" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) (owner: Awight) [22:20:23] awight: ejegg: pls LMK if u can think of any reason not to kill this method: https://github.com/wikimedia/mediawiki-extensions-CentralNotice/blob/master/tests/ComparisonUtil.php#L4-22 ? [22:20:34] It's unused currently [22:22:43] Got nothing of the top of my head [22:23:08] AndyRussG: Oops. I wrote that to allow for an additional type of assertion, which would only test the array properties that were provided. That let me ignore stuff which would change between tests. [22:24:21] awight: hmm! [22:24:52] * AndyRussG gazes out the window now finally understanding... [22:27:55] awight|brb: do you think it'll be useful in the future in CN? Now that I get it it sounds interesting, maybe a mini Github repo would be a place to keep it for now? [22:28:05] awight|brb: ejegg: thanks both, BTW :) [22:30:19] AndyRussG: let's kill it! We can always dig through history or rewrite if it's needed again. [22:30:31] You did a lot of work to kill defaults, which I think deprecated this [22:33:47] which defauls? [22:34:01] ah right default values in tests [22:34:07] K will dooooooooooo [22:35:44] Fundraising-Backlog, ops-fundraising: Need Civi access for Donor Services agent - https://phabricator.wikimedia.org/T95011#1222730 (CCogdill_WMF) I can confirm her cell number is up there and Kristie is ready! [22:38:46] bassoon! [22:47:29] (PS1) Awight: Hack more language globals [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205456 (https://phabricator.wikimedia.org/T94604) [22:51:59] (CR) Katie Horn: "I thought we were trying to contain mediawiki globals..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205456 (https://phabricator.wikimedia.org/T94604) (owner: Awight) [22:54:58] (CR) Awight: "Well... the UI is hopelessly coupled to MediaWiki, so I'm okay with doing this as a workaround." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205456 (https://phabricator.wikimedia.org/T94604) (owner: Awight) [22:55:55] hey team! stepping out for a few min to buy nyquil... ping me on gchat/email if you need anything [23:16:06] (PS1) Ejegg: Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) [23:16:33] (CR) jenkins-bot: [V: -1] Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [23:16:49] (PS2) Ejegg: Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) [23:40:05] (PS1) Ejegg: Don't crash on missing fname or lname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205468 [23:40:39] pizzzacat: ^^^ should fix your fname / lname crash [23:45:42] thanks ejegg!