[00:16:01] have a good evening all! [03:19:12] (PS3) AndyRussG: WIP Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [03:20:54] (CR) jenkins-bot: [V: -1] WIP Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [13:36:17] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1227430 (Pcoombe) Resolved>Open Re-opening because I missed th... [13:42:10] (PS1) Pcoombe: Correct recurring info text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205849 (https://phabricator.wikimedia.org/T94246) [14:38:15] fundraising-tech-ops: fundraising system kernel updates - https://phabricator.wikimedia.org/T95887#1227693 (Jgreen) [14:39:19] Wikimedia-Fundraising, fundraising-tech-ops: Need access to PHP error logs on lutetium - https://phabricator.wikimedia.org/T89992#1227695 (Jgreen) [14:40:32] fundraising-tech-ops: Write alerts for missing or empty logfiles - https://phabricator.wikimedia.org/T87683#1227715 (Jgreen) [15:00:05] fundraising-tech-ops, Wikimania-Hackathon-2015, Wikimedia-Hackathon-2015: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#1227813 (Jgreen) [16:48:47] (CR) Awight: [C: 2] Correct recurring info text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205849 (https://phabricator.wikimedia.org/T94246) (owner: Pcoombe) [16:49:30] (Merged) jenkins-bot: Correct recurring info text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205849 (https://phabricator.wikimedia.org/T94246) (owner: Pcoombe) [17:01:13] pizzzacat: http://www.sftu.org/repairs.html [17:28:32] Heading to scrum of scrums - anyone got anything I should bring up? [18:16:03] (PS4) AndyRussG: WIP Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [18:28:12] (PS1) Awight: Be much more conservative about unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205898 (https://phabricator.wikimedia.org/T94506) [18:48:25] (PS12) Awight: Write DonationQueue shim around PHPQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) [18:48:31] (PS16) Awight: Use DonationQueue for non-orphan queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [18:48:36] (PS8) Awight: WIP Use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203282 (https://phabricator.wikimedia.org/T92922) [18:50:30] (CR) Ejegg: [C: 2] Write DonationQueue shim around PHPQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) (owner: Awight) [18:52:58] O_o [19:00:49] (CR) Awight: Define PaymentStatus, deal with delimited response (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [19:01:43] (CR) Awight: [C: 2] Remove optional fields from NewInvoice txn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205776 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [19:05:14] (CR) Awight: [C: 2] Deal with duplicate order id in Astropay (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205784 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:11:08] (PS5) AndyRussG: Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [19:11:23] Finally out of WIP! [19:11:36] * AndyRussG doesn't wait 4 Jenkins.... [19:11:39] .... [19:11:41] ... [19:13:48] (PS4) Ejegg: Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) [19:15:05] (CR) Awight: [C: -1] "Typo in comment :)" (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:17:36] (PS1) Ssmith: WIP forms refactor styles [extensions/DonationInterface] (formsRefactor) - https://gerrit.wikimedia.org/r/205912 [19:18:10] (CR) Ejegg: Define PaymentStatus, deal with delimited response (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [19:19:52] (CR) Awight: Define PaymentStatus, deal with delimited response (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [19:19:57] (PS5) Awight: Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [19:20:04] (CR) Awight: [C: 2] Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [19:20:11] (PS2) Awight: Remove optional fields from NewInvoice txn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205776 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [19:20:21] (PS2) Awight: Deal with duplicate order id in Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205784 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:20:25] (PS2) Awight: Determine per adapter whether we need to pop out of iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:21:20] AndyRussG: Any interest in dividing up this small patch? [19:21:52] awight: hmmm... well it's all really interconnected [19:22:07] The client code and the server code and the tests and the test fixtures all have to coordinate [19:22:22] as does the special page code [19:22:51] I suppose a few bits and pieces of refactorings could be broken out but it'd be very minimal and I think not worth it [19:23:28] I don't see any big pieces that could be separated, maybe I'm missing something [19:24:53] Oooh gotta run to pick up the kids (Mariana just had a root canal...) [19:25:02] youch, sorry to hear it! [19:25:33] thx! yeah just this morning... unavoidable tho, better sooner than later.. [19:27:12] (PS3) Ejegg: Determine per adapter whether we need to pop out of iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) [19:29:02] (CR) Ejegg: "clarified comment - isResponseFramed doesn't get called for GC's resultswitcher since that page doesn't use the base class's handleResultR" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:32:39] (CR) Awight: [C: 2] Determine per adapter whether we need to pop out of iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:41:34] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1228883 (atgo) Just a reminder - we need this to be on Donate and Pa... [19:42:42] Fundraising Tech Backlog: Donatewiki is not doing contribution_tracking - https://phabricator.wikimedia.org/T96902#1228884 (awight) NEW [19:47:06] hey awight k4-713 ejegg - do we use the EMIS files from paypal? [19:47:27] worldpay, sorry [19:48:17] hmm, EMIS doesn't ring a bell for me [19:49:25] apparently there was an issue with the files from mach 3-18 [19:49:30] i think we would've noticed by now... [19:49:42] but they're proactively offering to recreate them if we need them [19:57:07] atgo: I think we do, actually, but there wouldn't be anything in there. [19:57:33] I was saying, on principle we would like all audit files to be correct if there's any data. [19:57:46] Wasn't it off by then? [19:58:01] (CR) jenkins-bot: [V: -1] WIP forms refactor styles [extensions/DonationInterface] (formsRefactor) - https://gerrit.wikimedia.org/r/205912 (owner: Ssmith) [19:59:20] K4-713: It was turned off 3/12 [20:00:12] Ah, okay. So we'd still need them from the 3rd to the... 13th, to be safe. [20:00:19] Wait. Was the 13th on a weekend? [20:00:25] The next weekday. [20:00:40] K4-713: I'd ask for the whole range, cos of processing delays. [20:00:53] Man Jenkins is like no way, I'm not touching that! [20:00:57] awight: Okay: Sold. [20:01:07] * K4-713 blinks very slowly [20:01:19] (Merged) jenkins-bot: Write DonationQueue shim around PHPQueue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203280 (https://phabricator.wikimedia.org/T92916) (owner: Awight) [20:02:28] 50 minute Jenkins backlog? [20:02:48] Now it ran the tests, but that's more like discontinuous integration [20:07:11] (PS6) Awight: Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [20:07:19] (PS3) Awight: Remove optional fields from NewInvoice txn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205776 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [20:07:22] (PS3) Awight: Deal with duplicate order id in Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205784 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [20:07:27] (PS4) Awight: Determine per adapter whether we need to pop out of iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [20:20:44] (PS6) Ejegg: WIP Astropay resultswitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) [20:22:08] (PS2) Awight: Don't crash on missing fname or lname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205468 (owner: Ejegg) [20:22:14] (CR) Awight: [C: 2] Don't crash on missing fname or lname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205468 (owner: Ejegg) [20:22:38] (Merged) jenkins-bot: Don't crash on missing fname or lname [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205468 (owner: Ejegg) [20:26:26] (PS4) Ejegg: comments and fixup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203281 (owner: Awight) [20:26:51] (CR) Ejegg: [C: 2] comments and fixup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203281 (owner: Awight) [20:27:12] (Merged) jenkins-bot: comments and fixup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/203281 (owner: Awight) [20:27:17] Should I recycle the contents of the baggies of crasins that I sent with my kids' lunches and that my kids didn't eat? [20:27:58] (earlier that day: "Look, you can mix dirt and glue in with the crasins and you can't tell the difference!) [20:28:08] (Later: Dad: munch munch munch) [20:28:39] I have been processing a huge amount of leftover mush, too... [20:29:38] What will we all do when those kids grow up? [20:29:59] (years later: knock knock: What is it, Dad? Ahh hi, got any leftovers?) [20:31:16] (CR) Ejegg: "Looks very useful! Needs to be updated since the phpqueue patch merged first." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/195375 (owner: Awight) [20:32:26] (PS7) Ejegg: Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) [20:33:37] (CR) Ejegg: [C: 2] "Already +2ed by awight, just trying to convince CI to merge" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [20:33:44] AndyRussG: Shouldn't that kind of talk go in the snacks channel? :p [20:35:06] K4-713: ooh! so right! [20:38:30] (Merged) jenkins-bot: Define PaymentStatus, deal with delimited response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205461 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [20:38:57] I mean, far be it from me to discourage snacky talk in any venue... [20:39:01] Craisins are good. [20:39:07] Maybe not with dirt in them. [20:39:30] (PS4) Ejegg: Remove optional fields from NewInvoice txn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205776 (https://phabricator.wikimedia.org/T90503) [20:39:47] (PS4) Ejegg: Deal with duplicate order id in Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205784 (https://phabricator.wikimedia.org/T90504) [20:40:04] (PS5) Ejegg: Determine per adapter whether we need to pop out of iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) [20:40:28] Variety is the spice of crasins [20:41:38] (CR) Ejegg: [C: 2] "Echoing awight's +2 to spur Jenkins to merge" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205776 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [20:42:11] Today dirt, tomorrow clumps of massaged marshmallow pudding [20:42:27] (Merged) jenkins-bot: Remove optional fields from NewInvoice txn [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205776 (https://phabricator.wikimedia.org/T90503) (owner: Ejegg) [20:42:30] (Merged) jenkins-bot: Deal with duplicate order id in Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205784 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [20:42:32] (Merged) jenkins-bot: Determine per adapter whether we need to pop out of iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205785 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [21:00:09] Go, Jenkins! It's your birthday! [21:06:19] * atgo laughs at "discontinuous integration" [21:07:16] No wonder Jenkis is tipsy [21:07:54] Mmm now I'm cyber-slurring my words, too [21:18:38] (CR) Awight: Allocation: choose campaign first, fix throttling bug (13 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [21:18:56] awight: woohoo! that was fast :) [21:19:12] (PS7) Ejegg: Astropay result switcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) [21:20:13] AndyRussG: I haven't tried to smoke test yet! [21:20:29] Bring on the matches! [21:25:16] (CR) Awight: "Awesome! I noted some things." (4 comments) [extensions/DonationInterface] (formsRefactor) - https://gerrit.wikimedia.org/r/205912 (owner: Ssmith) [21:34:34] Fundraising Sprint J, Fundraising-Backlog: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1229407 (atgo) a:atgo>None [21:48:10] Fundraising Sprint J, Fundraising-Backlog: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1229478 (CCogdill_WMF) p:High>Normal Confirming this does not seem to be impacting unsubscribes, so we can change b... [22:08:40] Fundraising Dash, Fundraising Sprint Grandmaster Flash, Fundraising Sprint J: Make additional filters for X-by-Y chart - https://phabricator.wikimedia.org/T86840#1229537 (atgo) [22:09:06] Fundraising Sprint J, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1229540 (atgo) [22:13:03] Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1229560 (atgo) [22:13:57] Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1217052 (atgo) [22:14:25] Fundraising Sprint J, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1217052 (atgo) [22:31:36] Fundraising Sprint J, Fundraising-Backlog: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1229617 (atgo) [22:31:50] Fundraising Sprint J, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1229619 (atgo) [22:32:03] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: Upgrade Civi to 4.4 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1229621 (atgo) [23:06:04] What should I call cAndO? [23:06:19] donno! [23:07:22] contexts_and_outputs [23:07:33] then there's context and output name [23:07:49] We could call it George! [23:08:56] I'm a bit reactionary about battling single-letter abbreviations (a's), so feel free to ignore me! [23:11:34] it's a bit of a strange data structure... [23:12:34] It might be better to have a list of banner+campaign configurations, a separate list of testing contexts, then a test case would be (configName, contextName) -> (outputs) [23:14:02] I was only offended by "cAndO" cos my font doesn't distinguish between O and 0 very well! [23:14:12] Ah hmmm [23:14:37] It is a strange stucture, true... But I think from the testing perspective it makes sense... Basically each test case is a scenario (server-side), for each such scenario there are many possible contexts (client scenarios) and possible results for those contexts [23:16:46] I'll just expand to contextAndOutput [23:17:25] U could immediately assign to $context and $outputs local variables... [23:17:35] I do! [23:18:01] ....uh mostly [23:18:04] Could do so more, yeah [23:53:20] (CR) Awight: "This one freaks me out. I'm not being fair, I'll take another look tomorrow..." (8 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [23:59:31] (PS2) Awight: Be much more conservative about unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205898 (https://phabricator.wikimedia.org/T94506) [23:59:47] ejegg: K4-713: fyi, here's a sketchy change ^^