[00:00:31] actually, that makes a lot of sense [00:01:24] aargh, base class unstage dividing by 100? I think I need to override that for astropay too [00:09:16] ejegg: yeah... that might be something to revisit [00:09:30] ok friends, see you soon! [01:06:30] (PS6) AndyRussG: Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [01:08:59] (CR) AndyRussG: Allocation: choose campaign first, fix throttling bug (13 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [02:49:36] (PS11) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [02:49:38] (PS3) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [02:50:41] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [02:53:43] (CR) AndyRussG: "This PS: rebased on new allocation method (I42985cf4de2dfeba9244b8d82f63b3d9d8319c81)." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [02:59:12] (CR) AndyRussG: "This PS: just rebased on new version of schema change (which follows new allocation mehtod, I42985cf4de2dfeba9244b8d82f63b3d9d8319c81)." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [03:03:28] (CR) AndyRussG: "Test failures are because we need to adapt some tests for mixins, and because this needs Iee61e5b527321d01287baa03ad9b4d4f526ff3ef from co" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [13:39:55] (PS7) AndyRussG: Allocation: choose campaign first, fix throttling bug [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) [15:46:14] (PS4) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [15:53:49] (PS12) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [15:54:28] (CR) AndyRussG: "This PS: rebased once more..." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [15:54:40] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [15:57:21] (CR) Ejegg: [C: 2] Be much more conservative about unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205898 (https://phabricator.wikimedia.org/T94506) (owner: Awight) [15:58:13] (Merged) jenkins-bot: Be much more conservative about unstaging [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205898 (https://phabricator.wikimedia.org/T94506) (owner: Awight) [16:09:10] (CR) AndyRussG: WIP Campaign-associated mixins: schema update (2 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [16:31:30] (CR) AndyRussG: Allocation: choose campaign first, fix throttling bug (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [16:38:58] (PS1) AndyRussG: bannerController call to BannerLoader: Remove unused params [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206142 [16:42:59] (CR) AndyRussG: "P.S. An thoughts on pruning this method?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206142 (owner: AndyRussG) [17:35:31] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1231753 (awight) @pizzzacat: I noticed yesterday that this task is not quite the right one to describe this first... [17:40:14] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1231785 (pizzzacat) @awight : Totally agree. I can make a separate card for the first Astropay proof of concept. [17:41:58] Fundraising Sprint Indigo Girls, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1231787 (pizzzacat) NEW a:pizzzacat [17:42:08] Fundraising Sprint Indigo Girls, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1231802 (pizzzacat) [17:44:03] (CR) Ejegg: "I followed style of Adyen to try to re-use the GatewayPage handleResultRequest code. It is kind of funky that it calls processResponse ou" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [17:46:50] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1231814 (atgo) Yay! Concrete, bite sized tasks! :) [17:48:26] ejegg: Just to be clear, a lot of my comments are about future refactoring things, no obligation to do them or even plan them now... [17:48:44] Lmk if that's ever murky [17:49:35] awight: I'm going to see where an 'incoming' transaction type gets me in the next couple hrs [17:50:13] just pondering the best way to feed the data into the adapter from the GatewayPage [17:50:23] interesting [17:51:34] Adyen is definitely hacky, overriding and calling processResponse with incompatible method signatures. [17:51:38] I wonder if it makes any sense to consider the returned stuff to be a response to a redirect-style api call :-/ nah [17:51:53] They're... all hacky [17:51:56] heh [17:55:18] hey AndyRussG - i notice that thus task for banner history doesn't have any blocking/blocked tasks - shouldn't it be related to the others? https://phabricator.wikimedia.org/T94763 [17:58:54] Fundraising Sprint Indigo Girls, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1231787 (atgo) @pizzzacat does this replace T90502? or are they sort of interdependent? [18:04:34] Fundraising Sprint Indigo Girls, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1231880 (pizzzacat) @atgo I'd say they're the same thing. Sorry, I didn't know the other one existed. [18:05:30] ejegg: Are you thinking an "incoming" transaction would be specified using the communication_type field? [18:05:39] yeah [18:05:43] awesome. [18:06:03] There's some asymmetry between staging and unstaging, I'm sure you'll have fun :p [18:06:27] err, right... [18:06:30] Fundraising Sprint Indigo Girls, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1231881 (atgo) No worries! Merging. [18:06:43] Fundraising-Backlog, Wikimedia-Fundraising, Astropay Integration: Create new HTML forms for Astropay processing - https://phabricator.wikimedia.org/T90502#1231882 (atgo) [18:06:44] Fundraising Sprint Indigo Girls, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1231883 (atgo) [18:06:53] i was thinking of setting the raw response from the GatewayPage before calling doTransaction [18:07:02] Fundraising-Backlog, Wikimedia-Fundraising, Astropay Integration: Create new HTML forms for Astropay processing - https://phabricator.wikimedia.org/T90502#1060787 (atgo) [18:07:19] ejegg: I think that sounds good [18:07:37] cool. either that or giving do_transaction another parameter [18:08:28] I'd like to simplify that interface, which is sort of the opposite direction. [18:08:41] c.f. doPayment() [18:08:41] sounds good [18:09:42] My thinking is that we should keep controller logic within the adapter classes for now, and isolated from the forms classes [18:10:29] So, the adapter class contains all the knowledge about how to interpret API responses [18:10:34] right, but there should be an all-purpose way for the forms classes to provide input harvested from the request [18:10:44] Yes! [18:10:57] pretty much addResponseData [18:11:44] The form can be responsible for combining GET and POST, and I donno how to fit SESSION into that [18:12:56] hmm, i'd be fine having the form send the session stuff in too. [18:13:37] just marking it all with the source (us/processor) and medium - GET/POST/SESSION [18:16:37] awight: any appetite for a merge + deploy to clear out the backlog before merging the meat of the queue reform? [18:20:17] oh, never mind, looks like you did that just a little while ago! [18:26:25] yep! [18:26:49] I'd like to get that Catalan unstaging thing pushed out, though [18:30:40] Hi atgo! Yeah that task should block the global task... I'll add it [18:32:03] thanks! [18:37:36] ccogdill: U know if MBeat is working today? [18:37:54] I'm considering another exciting shot at paymentswiki deployment. [18:37:59] awight yes he is, but he’s off every Thursday from about 9am-12pm pst [18:38:07] so maybe after that? [18:38:15] yeah, that's perfect for my schedule. [18:38:20] cool! [18:38:28] Maybe 1:30, then. I'll email [18:38:40] sounds good [18:39:22] (PS2) Awight: Hack more language globals [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205456 (https://phabricator.wikimedia.org/T94604) [18:39:31] (PS3) Awight: Hack more language globals [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205456 (https://phabricator.wikimedia.org/T94604) [18:41:26] Fundraising-Backlog: Can CC have a scratch database to create temporary tables in civicrm? - https://phabricator.wikimedia.org/T97065#1232012 (CCogdill_WMF) NEW [18:43:53] Jeff_Green: ping :) ^^ [18:44:36] pong! [18:45:23] hmm, she might already have one. checking [18:47:39] Fundraising-Backlog: Can CC have a scratch database to create temporary tables in civicrm? - https://phabricator.wikimedia.org/T97065#1232060 (Jgreen) a:Jgreen [18:55:26] (CR) Awight: Allocation: choose campaign first, fix throttling bug (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [18:55:50] (CR) Awight: Allocation: choose campaign first, fix throttling bug (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [18:55:50] Jeff_Green: I just lobbed another one your way - https://phabricator.wikimedia.org/T97071 [18:56:01] yup, saw it! [18:56:47] awight: thanks! [18:58:24] (CR) Awight: "Looks ready to go, but I should smoke test a bit." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/205193 (https://phabricator.wikimedia.org/T96194) (owner: AndyRussG) [18:59:25] awight: yeah lemme fix thos var names and whitespace before the 'old +2 :) thx! [18:59:50] of curse [19:02:05] fyi awight ejegg we’re waiting for our room to open up [19:02:10] WRT your comment on where to shortcircuit banner allocation if there's just one banner... I did in fact ponder it a bit because it seemed that bannerController was mucking about in the details of bannerController.lib's buisness [19:02:20] Is that what's irking you? [19:02:43] ccogdill: ok, i'll be on in 1 min too [19:02:44] hey awight ejegg - running a bit late [19:02:48] sounds good [19:02:50] ccogdill: we are in the room with another mtg [19:03:19] MBeat FYI for you too — waiting for our room [19:03:30] thx, was gonna pipe up! [19:03:40] :) [19:03:44] I eventually concluded that it was OK on the grounds that if we can check for the length of those variables on .lib then also grabbing just element 0 was fair game [19:04:46] Could hide some of those checks behind methods w/ fiendly names in the .lib tho [19:04:54] awight: ^ (when you get a chance) [19:07:30] awight|mtg: ejegg we have no batteries in trackpad and are muted [19:09:44] Fundraising-Backlog: Can CC have a scratch database to create temporary tables in civicrm? - https://phabricator.wikimedia.org/T97065#1232140 (Jgreen) I created the database 'ccogdill' on which you have full privileges. You should be able to create tables in that db and query across databases, which I think... [19:09:52] ejegg: just intros so far [19:18:58] Fundraising-Backlog: Can CC have a scratch database to create temporary tables in civicrm? - https://phabricator.wikimedia.org/T97065#1232177 (Jgreen) [19:18:59] Fundraising-Backlog: Can CC have a scratch database to create temporary tables in civicrm? - https://phabricator.wikimedia.org/T97065#1232012 (Jgreen) test...does this comment go out via irc bot? [19:19:01] Fundraising-Backlog: Can CC have a scratch database to create temporary tables in civicrm? - https://phabricator.wikimedia.org/T97065#1232180 (Jgreen) [19:20:09] Fundraising Sprint J, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create a Civi import function for hand keyed donations in Civi - https://phabricator.wikimedia.org/T88836#1232185 (atgo) [19:30:07] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Edits to LYBUNT report - https://phabricator.wikimedia.org/T88819#1232219 (atgo) [19:31:43] Fundraising-Backlog: Account Updater via WorldPay - https://phabricator.wikimedia.org/T91860#1232230 (atgo) [19:37:15] atgo: Question for you in the hangout chat [19:42:54] MBeat: Is 1:30 today a good time to stomp out potential DS fires? [19:43:18] in terms of low Zendesk traffic? sure [19:43:37] (CR) Awight: Astropay result switcher (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:43:41] (PS8) Awight: Astropay result switcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:43:46] (CR) Awight: [C: 2] Astropay result switcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:44:15] (Merged) jenkins-bot: Astropay result switcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/205646 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [19:47:23] (PS17) Awight: Use DonationQueue for non-orphan queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [19:50:13] MBeat: thanks. Yeah, There might be some donor data corruption after the deployment, in which case I'd want to revert as quickly as possible! [19:50:56] would this be in Civi, awight, or something the donors would see on their end? [19:52:03] MBeat: In the worst case, everyone would start seeing English thank-you letters. [19:52:33] ah, ok. we can triage if need be. I say go for it [19:54:12] thx, I'll send another heads-up when I'm getting ready. [20:04:52] AndyRussG: ejegg: ping [20:17:46] (CR) Ejegg: "Looks pretty solid. A few trivial comments. If we're replacing antimessages with deletes, do we wait to deploy this until we have a new " (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [20:24:54] (CR) Ejegg: "TODO: sometime between this and Id40e497b35f5, use DonationQueue for payments-init message in GatewayAdapter::sendFinalStatusMessage and a" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [20:26:36] (PS1) Awight: update packages [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/206177 [20:26:38] (PS1) Awight: .gitignore for unused files we've removed, which depend on traits [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/206178 [20:26:48] (PS2) Awight: gitignore unused files we've removed, which depend on traits [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/206178 [20:26:53] ejegg: U wanna bless that one? ^^ [20:27:15] * ejegg dons priestly vestaments [20:27:34] The goth ones... [20:28:07] (CR) Ejegg: [C: 2 V: 2] update packages [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/206177 (owner: Awight) [20:28:13] ohwow, http://c8.alamy.com/comp/DE11F0/england-east-sussex-brighton-brighton-pride-parade-parade-participant-DE11F0.jpg [20:28:42] (CR) Ejegg: [C: 2 V: 2] gitignore unused files we've removed, which depend on traits [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/206178 (owner: Awight) [20:28:54] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/206179 [20:28:56] (PS1) Awight: update vendor submodule (deployment) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/206180 [20:29:18] (CR) Awight: [C: 2 V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/206179 (owner: Awight) [20:29:30] (CR) Awight: [C: 2 V: 2] update vendor submodule (deployment) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/206180 (owner: Awight) [20:34:00] on the catwalk at a real clerical fashion show: http://i.guim.co.uk/static/w-620/h--/q-95/sys-images/Guardian/Pix/pictures/2012/10/8/1349697938224/clergy1.jpg [20:35:00] and what the heck kind of CMS is the Guardian using? [20:36:47] That's quite the URL [20:36:48] you look away from IRC for 10 minutes and things get weird... [20:37:06] schroedinger's catwalk [20:40:22] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/206184 [20:43:37] (CR) Ejegg: [C: 2] "Handy! Should let us zap a bunch of stuff in the gateways test classes." [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/201133 (owner: Awight) [20:44:38] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/206184 (owner: Awight) [20:45:14] (CR) Ejegg: [C: 2 V: 2] Fix TestingAccessWrapper::__call [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/201134 (owner: Awight) [20:46:42] MBeat: ccogdill: I'm ready to deploy in the next few minutes. [20:46:57] ready when you are [20:46:58] thanks 4 headsup [20:48:00] argh, I hit a snafu [20:48:48] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, and 2 others: Write an abstracted interface for queue send and receive - https://phabricator.wikimedia.org/T92916#1232420 (awight) Issue while deploying: ``` Submodul... [20:49:19] (CR) jenkins-bot: [V: -1] Fix TestingAccessWrapper::__call [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/201134 (owner: Awight) [20:51:48] ejegg: Can you remind me how to deal with the vendor/ "No submodule mapping found in .gitmodules for path 'coderkungfu/php-queue'" thing? [20:52:11] hrm, actually, I think I had cloned manually by mistake. [20:52:12] oh man [20:52:51] I think composer does that [20:53:00] rats. yeah it's not just me [20:53:01] then you have to delete the .git dir [20:53:20] k, awesome [20:54:20] didn't work :( I removed the coderkungfu/php-queue/.git directory [20:55:50] phooey, we have to undo the submodule addition, which is always fun [20:56:19] This sox [20:56:22] maybe the .git dir was there when you initially git add-ed then dir? [20:56:35] *the coderkungfu dir [20:57:22] yep! I think I'm close [20:57:31] if yr version of git doesn't do de-init, i can help [20:57:32] I'll definitely write this up, assuming I survive the experience [20:57:40] (PS1) Awight: Check in php-queue library as files rather than as a submodule [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/206190 [20:57:49] I think it was never a real submodule, so that helped a big [20:57:50] bit [20:58:11] (CR) Awight: [C: 2 V: 2] Check in php-queue library as files rather than as a submodule [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/206190 (owner: Awight) [20:58:37] (PS1) Awight: update vendor submodule (deployment) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/206192 [20:58:44] (CR) Awight: [C: 2 V: 2] update vendor submodule (deployment) [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/206192 (owner: Awight) [21:01:27] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/206195 [21:01:38] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/206195 (owner: Awight) [21:02:58] ejegg: That worked! Thanks again! [21:03:08] awesome [21:03:38] MBeat: ccogdill: ok NOW i'm going for it. [21:03:44] woo! [21:03:50] :) [21:04:23] !log update payments from 88b9f621bfee1de14a8cdef556a90e5567721754 to 83d09e09178c634ad35dbb684d1c3aebbb709969 [21:04:26] Logged the message, Master [21:04:42] Testing Catalan donation... [21:05:43] I don't see any activity... [21:05:56] It was low traffic though [21:07:08] Woohoo! Catalan TY page [21:07:32] Arf, my SSL cert [21:07:50] yay awight! [21:08:39] atgo: u wanna do a donation? Probably most helpful to make it in a language other than English [21:11:20] yes [21:11:24] i can do catalan? [21:11:47] Yep! [21:11:54] awight: does the country matter? [21:12:19] I did uk and got a uk page! [21:12:19] woo [21:13:12] atgo: It shouldn't. But it would be good to verify that country != US makes it to Civi. [21:13:33] success! catalan TY [21:13:44] nice [21:13:44] now i'm going to get some weird emails :P [21:13:58] awesome awight :) [21:14:14] Argh: where is the preferred language in the Civi console? [21:14:36] oops. but the subj line isn't translated [21:14:42] it’s under communication preferences awight [21:14:44] the rest of the TY is catalan [21:14:55] Hopefully that's because the subj line isn't translated yet? [21:15:13] i'll check with jessica [21:15:34] This wouldn't have come up before today :) [21:15:35] (CR) Ejegg: [C: -1] "Oops, one more thing. Adyen + Amazon have doLimboStompTransaction calls that need to be converted." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [21:16:22] ejegg: maybe I'll split limbostomp into a second patch... [21:16:44] sounds good [21:17:02] awight: you make a good point :P [21:18:18] atgo: confirmed, https://translatewiki.net/w/i.php?title=Special:Translations&message=MediaWiki%3ADonate+interface-email-subject%2Fen [21:18:48] ooh gotcha [21:18:51] ok. well thank you [21:20:17] atgo: Actually, it might be worth making a point of that ^^, the subject line and TY letter body are translated in different places... [21:21:55] hey AndyRussG - this one got dropped. what's up? https://phabricator.wikimedia.org/T87677 [21:22:06] awight: yeah that is weird for sure [21:25:31] Fundraising Sprint Enya, Fundraising Sprint Flaming Lips, Fundraising Tech Backlog, Fundraising-Backlog, and 2 others: [2 hours] BUG: Donation link geolocation not working consistently - https://phabricator.wikimedia.org/T87677#1232607 (atgo) [21:26:14] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, and 2 others: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1232609 (atgo) [21:26:29] Fundraising Tech Backlog, Astropay Integration: Write confirmation message listener for Astropay, which rescues donations from the limbo queue - https://phabricator.wikimedia.org/T90506#1232610 (atgo) [21:26:54] Fundraising Tech Backlog, Astropay Integration: Add Astropay forms to DonationInterfaceFormSettings.php - https://phabricator.wikimedia.org/T90505#1232619 (atgo) [21:27:12] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1232622 (atgo) [21:29:57] Fundraising-Backlog: Improve error messaging for donors experiencing browser errors - https://phabricator.wikimedia.org/T96293#1232636 (atgo) p:Triage>Normal [21:31:33] Fundraising-Backlog: Make worldpay forms for Japan - https://phabricator.wikimedia.org/T93019#1232643 (atgo) p:Normal>Low [21:32:47] Fundraising-Backlog: Help Ellery understand recurring - https://phabricator.wikimedia.org/T92461#1232655 (atgo) @ellery - do you have specific questions so that we can figure out how to bring you up to speed? I think you're already digging on this, and maybe we don't need to have a task for it in phab if you... [21:34:06] atgo: weird in the original sense of, the result of an evil spell... It's a known screwup, at least [21:34:37] Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, Astropay Integration, Patch-For-Review: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1232661 (atgo) [21:35:15] Fundraising Tech Backlog, Astropay Integration: Write Astropay audit file processor - https://phabricator.wikimedia.org/T90507#1232662 (atgo) [21:39:08] alright friends, i'm off for the weekend. see you tuesday! [21:40:05] wooho [21:40:08] have fun! [21:40:12] thanks!! [22:20:05] (PS18) Awight: WIP Use DonationQueue for non-orphan queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [22:25:28] (PS1) Ejegg: Make resultswitcher processing slightly less funky [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206307 (https://phabricator.wikimedia.org/T90504) [22:30:08] (PS19) Awight: WIP Use DonationQueue for non-orphan queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [22:49:22] awight: Hi! what was ur transition to and from? Also... have a sec for a CN mystery? [22:50:17] Just a molt [22:50:40] Yes, looking forward to the mystery! [22:51:12] fg [22:51:14] http://meta.wikimedia.beta.wmflabs.org/wiki/Special:CentralNoticeBanners/edit/browser_test_b1 [22:51:15] hehe [22:51:17] vs [22:51:24] Ono, that's a bad one [22:51:43] http://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Special:BannerLoader&banner=browser_test_b1&campaign=&uselang=en&db=metawiki&project=meta&country=CA&device=desktop [22:51:51] (check out the bannerHtml in the result) [22:52:17] Hrm, I'm timing out on that URL [22:52:56] Yeah labs has been teetering on the brink all day [22:53:09] or the beta cluster [22:53:22] Give it a reload, even so it's missTreous [22:54:20] Oh hmm I'm getting also unable to connects on all of 'em now [22:54:44] The third puzzling item is that if you go to the logs for banner content changes, it's empty! [22:55:28] I wouldn't expect it's the same problem as the overal labs outages we're getting, though I suppose it could be... [22:57:13] The crux of the difference between the first two links is that on the first, you see the banner content as expected, and on the second it sez "bannerHtml":"\u003CCentralnotice-template-browser_test_b1\u003E" [22:57:37] Hmmm I guess it could be some i18n scap issue [22:58:54] sorry, I had chicken drama [22:59:15] awww [22:59:22] 3c is "<"? [22:59:30] yeah [22:59:31] yah [22:59:40] yeah, that's definitely translation fail [22:59:54] K interesting [23:00:04] cwdent and ejegg had a case of that recently, must be catching... But in an entirely different project :( [23:00:18] Hum [23:00:28] oh no, are the missing messages spreading? [23:00:40] langoliers ate em [23:00:42] on the beta cluster, yea [23:00:50] Hard to imagine that the CN thing is actually an issue with the scap process, although there was a l10n cache hiccough for the last... few months. [23:01:33] I guess I wasn't expecting anything like that since there are no translatable messages in that banner... but I guess the whole banner content shown in the banner content edit textbox is also a translatable message [23:01:47] Speaking of chicken drama, I'm gonna have the product thereof [23:02:05] basssssssssssoon [23:02:24] AndyRussG: I still can't see that page, but I think I understand what's happening... [23:02:58] awight: cool! Mmm I'll see backscroll, back in 20-25 min [23:03:22] Maybe, the namespace with banner content was damaged, but the banner db tables are still pointing to the old page. [23:03:35] I think I can check for that, if ever the server comes back online [23:08:26] AndyRussG|dinner: http://meta.wikimedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Centralnotice-template-browser_test_b1 [23:11:59] AndyRussG|dinner: I wonder if this is wrong, https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings-labs.php#L129 [23:13:02] Maybe it's being aliased to meta-labs after all, see https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/CommonSettings-labs.php#L150 [23:21:16] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, and 2 others: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1232846 (Ejegg) Open>Resolved [23:21:16] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, and 2 others: Write adapter class API definitions for New Invoice and Payment Status - https://phabricator.wikimedia.org/T90503#1232846 (Ejegg) Open>Resolved [23:21:17] Fundraising-Backlog, Wikimedia-Fundraising, Epic: Integrate processing in LATAM via Astropay - https://phabricator.wikimedia.org/T77907#1232847 (Ejegg) [23:21:17] Fundraising-Backlog, Wikimedia-Fundraising, Epic: Integrate processing in LATAM via Astropay - https://phabricator.wikimedia.org/T77907#1232847 (Ejegg) [23:31:14] can somebody kick one of the wikibugs? [23:31:36] that sounds so mean [23:32:14] can't let the monstrous vermin multiply [23:47:24] Which do you want to keep? wikibugs_ or wikibugs?