[01:50:16] (CR) AndyRussG: WIP Campaign-associated mixins (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [15:03:58] (PS9) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [16:41:25] K4-713: no civic duty after all? [16:41:48] ejegg: Not necessarily. [16:42:06] So, they do this thing here, where you call in a few times to see if you have to report in two hours or not. [16:42:17] ah, cool [16:42:26] Until I call in and they say "Your group is needed!" I'm pretending it's not happening. :) [16:42:33] Next check is 11am. [16:42:42] nice to not be stuck waiting in the courthouse! [16:42:59] Yeah. It's almost like they came up with the system sometime in the last 20 years or something. [16:43:39] ...almost. :p [16:44:01] needs appz [16:44:34] Realtime Jury Duty App [16:44:45] ...no cellphones in the courthouse. (har) [16:45:28] So, the thing is, if I get called to go in, I'm batting 1000 for getting selected. [16:45:53] no, it's all on microsoft surface tablets. Like SHIELD and the NFL [16:46:07] I suspect I have some kind of pheromone that makes me seem pliant to lawyers. [16:46:12] :| [16:46:15] oh man, you must come off as very fair and balanced [16:47:49] Or, I look like I might be just sympathetic enough to criminals not to get ejected by the defense, and like enough of a square not to get booted by the prosecution? [16:48:05] need more opinionated tattoos [16:53:17] ejegg: ...on the forehead. :p [16:53:28] No, actually... I usually really like jury duty. [16:54:10] It's just that since I took this job, they have a serious inclination toward bringing me in during particularly bad times. [16:54:15] yeah, could definitely be interesting. Hey, people watch court tv [16:58:21] ejegg: Yeah, but court TV isn't as interesting as closed proceedings. Heh. [16:58:41] It's almost like some kind of smokescreen, actually... [17:00:00] i've only even gotten to the interview + diamissal once [17:29:10] K4|meeting, awight, AndyRussG: anything you want I should bug other teams about? [17:29:43] ejegg: hmmm I had thought of something but it's slipped my brain now [17:29:57] I'll ping u if I remember it? Thanks, BTW! :) [17:30:01] k. I'll keep an eye on IRC in case [17:30:23] cool! Don't worry much about it, it probably wasn't too important... [18:00:48] (PS1) AndyRussG: Fix fetching choice data via API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/207505 [18:01:40] ^ surprise! By default, MW api strips out false values!!! bwahahahahah [18:02:16] anti-Easter-egg party! [18:03:19] oh man, wonder if they're using empty() to see if things are set [18:03:49] ejegg: no, the best part is it's intentional :) [18:04:03] huh... ok [18:04:18] One sec I'll demonstrate ;p [18:08:21] ejegg: compare these two links [18:08:22] https://meta.wikimedia.org/w/api.php?action=centralnoticebannerchoicedata&project=wikipedia&language=en&format=jsonfm [18:08:33] https://meta.wikimedia.org/w/api.php?action=centralnoticebannerchoicedata&project=wikipedia&language=en&format=jsonfm&formatversion=2 [18:08:56] Scroll down to the Election2015_Submission campaign [18:09:13] ohhh, in the output! [18:09:34] In the first link, there is no geotargeted=false value. It's stripped out, because, well, because! Yeah! You have to add the "formatversion=2" param to prevent it [18:09:43] is 'geotarged' actually false in the original, or is it undefined? [18:09:55] It's so totally and completely defined and false it's not funny [18:10:17] wow, formatversion 1 seems dumb [18:10:58] guess it's more compact if you assume everything defaults to false? [18:11:15] * awight freaking dies [18:11:17] at leat the 0 values get included [18:11:58] Cos the HTML checkbox thing seemed like such a smashing success... [18:12:06] https://github.com/wikimedia/mediawiki/blob/master/includes/api/ApiFormatJson.php#L74-91 [18:12:28] * AndyRussG sends debugger for a pit stop [18:12:31] Fundraising Sprint Indigo Girls, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1246305 (atgo) NEW [18:13:35] To boot, I think it's not documented, or at least I didn't find it... [18:16:12] awight: yeah looks like it's checkbox in an api result [18:18:10] the *output*. Right. That's so evil [18:23:02] Crazy [18:24:05] awight: almost done following up on all your CR suggestios... BTW speaking of surprises, I'm looking at this comment on mixin change, "Type validation should be done on the client, it's disconcerting to have data silently truncated." I am adding validation, but where do you see specifically data trundaction? [18:24:38] Well, if I specify "abc" in an int field, it accept the form POST and sets the value to "0" [18:24:59] awight: ah OK got it :) [18:25:01] thx! [18:25:27] (I was wondering if something unseen was happening on the string param, hopefully that one's OK!) [18:38:06] * atgo always forgets to un-away :/ [18:46:34] ... so where are we keeping documentation? [18:48:15] We each get every 4th letter, so none of us can give it up if tortured [18:49:17] umm, was the answer mw.org for generic software stuff, and wikitech for our specific install? [18:50:12] hmm ok [18:50:24] i'm going to write up some centralized info about how translation deployment/processes work [18:51:05] sounds sorta specific to us [18:51:10] word [18:51:21] ok. i'll work on that this week [18:52:43] ejegg: hahahah [18:54:00] wait, but we need some redundancy in case of assassinations. let's go with RAID-5 [19:04:42] (PS1) Ejegg: WIP Astropay Listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/207526 (https://phabricator.wikimedia.org/T90506) [19:06:55] (PS1) Ejegg: Add Astropay to Gateway Reconciliation report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207528 (https://phabricator.wikimedia.org/T90508) [20:27:44] (PS24) Awight: WIP Use DonationQueue for "complete" and "pending" queues [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [21:20:54] Fundraising-Backlog, ยง Fundraising Sprint Abba: Make GC and WP visually match what's on donate wiki (and consequently eachother) - https://phabricator.wikimedia.org/T86086#1247122 (atgo) a:pizzzacat>None [21:27:26] Fundraising-Backlog: Make the Civi Change Log more useful - https://phabricator.wikimedia.org/T95939#1247133 (CaitVirtue) Yes please!! As more people use Civi, this feature becomes more and more value. [21:27:39] Fundraising-Backlog: Make the Civi Change Log more useful - https://phabricator.wikimedia.org/T95939#1247134 (CaitVirtue) [21:47:11] Fundraising-Backlog: Make the Civi Change Log more useful - https://phabricator.wikimedia.org/T95939#1247238 (awight) Eileen McNaughton tells us that there's a built-in CiviCRM feature that should do this for us, although it's never been tried on a database of our size. She's enabled the feature for all of... [21:56:33] (PS15) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [21:57:16] (CR) AndyRussG: "Another rebase" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:58:05] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:58:51] (PS16) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [21:59:36] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [22:45:02] Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create a Civi import function for hand keyed donations in Civi - https://phabricator.wikimedia.org/T88836#1247444 (atgo) [22:45:12] Fundraising Sprint K, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1247447 (atgo) [22:45:22] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1247448 (AndyRussG) [22:45:24] Fundraising Sprint Indigo Girls, Fundraising Sprint J, Fundraising Tech Backlog, Astropay Integration, Patch-For-Review: Write adapter controller logic to process front-end payments - https://phabricator.wikimedia.org/T90504#1247451 (Ejegg) [22:45:36] Fundraising Sprint K, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1247452 (atgo) [22:45:47] Fundraising Sprint Indigo Girls, Fundraising Sprint J, MediaWiki-Templates, MediaWiki-extensions-DonationInterface, I18n: Mustache renderer needs to support i18n - https://phabricator.wikimedia.org/T97149#1247454 (Ejegg) [22:45:52] Fundraising Sprint K, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1247460 (atgo) [22:45:59] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, and 2 others: [1 day] BUG: CN banner being shown after campaign end - https://phabricator.wikimedia.org/T88276#1247461 (AndyRussG) [22:46:01] Fundraising Sprint Indigo Girls, Fundraising Sprint J, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1247462 (Ejegg) [22:46:03] Fundraising Sprint K, Fundraising-Backlog: Silverpop export not capturing language changes in Civi (not sure if this is language-only or not) - https://phabricator.wikimedia.org/T96410#1247463 (atgo) [22:46:08] Fundraising Dash, Fundraising Sprint Grandmaster Flash: Make additional filters for X-by-Y chart - https://phabricator.wikimedia.org/T86840#1247464 (atgo) [22:46:16] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1247465 (Ejegg) [22:46:25] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1247469 (atgo) p:Triage>Normal [22:46:29] Fundraising Dash, Fundraising Sprint Indigo Girls, Fundraising Sprint J: Write Dash Documentation - https://phabricator.wikimedia.org/T96318#1247470 (Ejegg) [22:46:31] Fundraising Sprint Indigo Girls, Fundraising Sprint J, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1247478 (atgo) p:Triage>Normal [22:47:08] Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, and 4 others: Implement campaign associated mixins per findings from T90913 - https://phabricator.wikimedia.org/T90915#1247500 (AndyRussG) [22:47:18] Fundraising Sprint Indigo Girls, Fundraising Sprint J, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1247502 (atgo) [22:47:29] Fundraising Sprint Indigo Girls, Fundraising Sprint J, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1246305 (atgo) [22:47:49] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, Fundraising-Backlog: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1247512 (Ejegg) [22:47:51] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, MediaWiki-extensions-CentralNotice: CentralNotice: key-value storage for new campaign-associated mixins/banner history - https://phabricator.wikimedia.org/T94763#1247513 (AndyRussG) [22:47:54] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, and 3 others: Use the new queue wrapper for adding messages to the completed and pending queues - https://phabricator.wikimedia.org/T92921#1247514 (awight) [22:48:06] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint K, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Adapt the Memcache queue subclass - https://phabricator.wikimedia.org/T92918#1247515 (atgo) [22:48:12] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, Fundraising Tech Backlog, and 2 others: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T92922#1247517 (awight) [22:48:27] Fundraising Sprint Indigo Girls, Fundraising Sprint J, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Document how the new queuing stuff will work - https://phabricator.wikimedia.org/T96434#1247519 (awight) https://wikitech.wikimedia.org/wiki/Fundraising#Message_Queue [22:48:50] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1247524 (Ejegg) [22:49:03] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint J, and 3 others: Write an abstracted interface for queue send and receive - https://phabricator.wikimedia.org/T92916#1247529 (Ejegg) [22:53:05] Fundraising Sprint Indigo Girls, Fundraising Sprint J, Wikimedia-Fundraising-CiviCRM: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1247587 (atgo) [22:53:20] Fundraising Sprint Indigo Girls, Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Reorganize CiviCRM 4.4 upgrade tasks - https://phabricator.wikimedia.org/T95496#1247588 (atgo) [22:53:48] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Use the new queue wrapper for limbo, antimessage, and orphan slaying - https://phabricator.wikimedia.org/T97201#1247589 (awight) [22:55:08] http://etherpad.wikimedia.org/p/fundraising_shrimp [23:24:17] (PS25) Awight: Use DonationQueue for "complete" and "pending" queues [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) [23:24:19] (PS1) Awight: Catch errors and redirect to general failure page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207675 [23:24:21] (PS1) Awight: Comment about TODOs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207676 [23:36:26] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint K, and 2 others: Adapt the Memcache queue subclass - https://phabricator.wikimedia.org/T92918#1247745 (awight) [23:41:01] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint K, and 2 others: Adapt the Memcache queue subclass - https://phabricator.wikimedia.org/T92918#1247772 (awight) [23:41:08] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint K, and 2 others: Adapt the Memcache queue subclass - https://phabricator.wikimedia.org/T92918#1247773 (awight) a:awight [23:44:07] (CR) Ejegg: [C: 2] "Handling it at the top - nice" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207675 (owner: Awight) [23:45:26] (CR) Ejegg: [C: 2] "So granular!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207676 (owner: Awight) [23:45:32] (Merged) jenkins-bot: Catch errors and redirect to general failure page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207675 (owner: Awight) [23:45:56] (Merged) jenkins-bot: Comment about TODOs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207676 (owner: Awight) [23:48:47] :)