[00:00:04] K4-713: ejegg: For a good time, this is ready for review: https://gerrit.wikimedia.org/r/184022 [00:00:57] oho! Yeah, guess we're catching most all the bogons at the top now [00:01:10] MWException wasn't gaining us anything, it's true... [00:05:51] (CR) Awight: [C: 1] "Holding off on merge, I made a bunch of changes, so ejegg or khorn should take a look." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [00:13:58] Heading home, I'll be confounding domestic and work life in a few hours... [01:00:15] (CR) Ejegg: "I love the specificity! So much more opportunity for pedantic argument :P" (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [01:03:40] (CR) Ejegg: [C: 2] "Looks good to me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [01:06:18] (Merged) jenkins-bot: Use DonationQueue for "complete" and "pending" queues [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [07:43:30] (PS5) Awight: WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) [07:44:01] (CR) jenkins-bot: [V: -1] WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [07:47:24] (PS2) Awight: WIP Stop writing limbo messages to ActiveMQ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207017 (https://phabricator.wikimedia.org/T92922) [07:47:26] (CR) jenkins-bot: [V: -1] WIP Stop writing limbo messages to ActiveMQ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207017 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [07:49:57] (Abandoned) Awight: DO NOT MERGE and the orphan slayer, too [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207028 (owner: Awight) [07:53:59] (PS3) Awight: WIP Stop writing limbo messages to ActiveMQ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207017 (https://phabricator.wikimedia.org/T92922) [07:54:45] (CR) jenkins-bot: [V: -1] WIP Stop writing limbo messages to ActiveMQ [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207017 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [08:11:03] (CR) Awight: Use DonationQueue for "complete" and "pending" queues (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/200793 (https://phabricator.wikimedia.org/T92921) (owner: Awight) [08:13:32] (PS2) Awight: DO NOT MERGE Also use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207029 (https://phabricator.wikimedia.org/T92922) [08:13:55] (CR) jenkins-bot: [V: -1] DO NOT MERGE Also use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207029 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [08:45:00] (PS1) Awight: Minor cleanup in orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207738 [08:45:02] (PS1) Awight: Clean up an orphan config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207739 [08:45:04] (PS1) Awight: WIP Use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207740 [08:45:06] (PS1) Awight: WIP Stop using STOMP in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207741 [08:45:08] (PS1) Awight: WIP remove unused logfile parsing code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207742 [08:45:21] (Abandoned) Awight: DO NOT MERGE Also use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207029 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [08:45:27] (CR) jenkins-bot: [V: -1] Minor cleanup in orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207738 (owner: Awight) [08:45:30] (CR) jenkins-bot: [V: -1] WIP Use DonationQueue in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207740 (owner: Awight) [08:45:38] (CR) jenkins-bot: [V: -1] WIP Stop using STOMP in the orphan slayer [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207741 (owner: Awight) [08:45:41] (CR) jenkins-bot: [V: -1] WIP remove unused logfile parsing code [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207742 (owner: Awight) [08:45:47] (CR) jenkins-bot: [V: -1] Clean up an orphan config [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207739 (owner: Awight) [14:28:59] fundraising-tech-ops, operations, network: pfw-eqiad JunOS upgrade - https://phabricator.wikimedia.org/T96569#1249041 (faidon) Open>Resolved a:faidon This was done last Monday (Apr 27). pfw-codfw was also updated to match it. No complaints so far, so all went as planned! [16:41:18] awight: hi! If for the schema change for mixins I have to add fields to another table (the notice log table) do you prefer it to be in the same patch.sql file or separate? [16:43:45] AndyRussG: probably safer to put in a second file, so the migrations are independent... [16:44:25] awight: K thx! [17:16:17] (PS5) Ejegg: Make resultswitcher processing slightly less funky [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206307 (https://phabricator.wikimedia.org/T90504) [17:16:25] (PS4) Ejegg: Fix comm status and error checking for PaymentStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206327 (https://phabricator.wikimedia.org/T90504) [17:18:22] (PS1) Ejegg: Add limbo queue message before redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207843 (https://phabricator.wikimedia.org/T90504) [17:56:52] (CR) Awight: Add limbo queue message before redirect (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207843 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [18:06:58] (CR) Awight: Fix comm status and error checking for PaymentStatus (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206327 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [18:13:08] ...huh. [18:14:22] !log disabled Thank You mail send [18:14:32] Logged the message, Master [18:14:39] awight: ...yt? [18:17:05] ejegg: How about you? :p [18:18:09] K4-713: sorry, what's up? [18:18:14] * ejegg checks things [18:18:18] Thank You is choking. [18:18:28] ah, dang [18:18:39] INVALID_MESSAGE Empty gateway transaction id in WmfTransaction::from_unique_id() (line 94 of /srv/org.wikimedia.civicrm/sites/all/modules/wmf_civicrm/WmfTransaction.php) [18:19:00] odd! [18:19:02] I like how the error log doesn't tell you anything about the specific transaction. :p [18:19:18] Otherwise it would be too easy. [18:19:24] (CR) Awight: Make resultswitcher processing slightly less funky (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206307 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [18:19:28] ah, fun [18:19:38] Okay, so awight is totally alive somewhere. [18:19:47] (PS2) Awight: Correct recurring info text again [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207180 (https://phabricator.wikimedia.org/T94246) (owner: Pcoombe) [18:19:48] Or, wait. That was you. [18:19:50] gotta be something in the logs around it [18:20:01] nope, that was awight reviewing [18:20:09] (PS10) AndyRussG: WIP Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [18:20:24] (CR) Awight: [C: 2] ":) it kind of worked, anyway..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207180 (https://phabricator.wikimedia.org/T94246) (owner: Pcoombe) [18:20:45] (Merged) jenkins-bot: Correct recurring info text again [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207180 (https://phabricator.wikimedia.org/T94246) (owner: Pcoombe) [18:20:49] Jeff_Green: Heads up: We might start tripping alarms because I disabled the Thank You mail send job. [18:20:58] I think there's an alert if those pile up. [18:21:25] ok, jenkins log has a contribution id [18:21:37] * K4-713 squints [18:21:38] ok [18:21:43] Ah. It's just up the page a bit. [18:21:44] I see. [18:21:53] K4-713: ! yes, alive but did not see TY failmail, yet. [18:22:00] ...really? [18:22:02] Thanks for shutting off the gas so fast! [18:22:14] I'm so on it, I can't get down. [18:22:31] How did I get up here. [18:22:39] call the fire dept! [18:22:42] letting the days go by? [18:22:51] ...oops, wrong song [18:24:24] wth, this makes no sense. [18:25:36] the wmf_..._extra has a gateway txn id, right? [18:25:55] This is a really creepy error, so far [18:26:04] Uhm. For real. [18:27:03] it has a check number [18:27:39] awight: ...no it doesn't. At least, not the thing I'm looking at. [18:27:51] contribution id = 3726622 [18:29:34] Oh, I'm looking at 11872684 [18:29:41] /job/Thank you mail send/250661/console [18:29:45] one moment... [18:29:48] That's the contribution tracking id, right? [18:29:50] Or, is it? [18:29:57] no, it's a CiviCRM id [18:30:09] ARGH words. [18:30:41] Okay, that makes way more sense. [18:30:42] What's making me sad and afraid is that, why has this not happened before? [18:31:00] If trxn_id is empty, WmfTransaction::from_unique_id blows up :( [18:31:11] Yeah, that looked like what it was trying to tell us. [18:31:20] I'm adding a conditional for that, but also scratching my butt about the: why now? [18:31:29] Didn't we used to make a... fake one? [18:31:36] Argh, I'm late for checking in with ejegg. [18:31:41] kbye! [18:31:41] awight: You got this? [18:31:45] yep, thanks [18:31:52] groovy. [18:31:56] ejegg: See you in a second. [18:32:05] ok [18:35:14] (CR) Awight: [C: 2] "Thank you for fixing, what a ridiculous bug in MediaWiki. Don't you think we should deprecate the non-shared db case?" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/207505 (owner: AndyRussG) [18:37:09] (Merged) jenkins-bot: Fix fetching choice data via API [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/207505 (owner: AndyRussG) [18:38:21] (CR) AndyRussG: "Mmm good idea... Maybe just a quick message to wikitech-l first, to check that it's not important to anyone?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/207505 (owner: AndyRussG) [18:39:21] AndyRussG: hehe, that sounds interesting! bring the ol' albatross around for a good whif :p [18:39:39] awight: lol [18:39:42] "whiff", apparently [18:40:00] lest we get albotross-slapped [18:40:12] or albatross-wiffed [18:41:53] that's what a whiffle-albotross is for [18:41:58] it's like a whiffle ball [18:42:18] you throw it and makes a lonely whiffling sound as it goes [18:42:54] K4-713: To anwser your question, yes we used to make a fake trxn_id that included a hash. Not good if this can be evaded somehow, I'll make a card to investigate. [18:43:12] O_O [18:43:24] Aha, I thought maybe it was something like that. [18:45:07] (PS1) Awight: Protect thank-you job from nonfatal exception [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207878 [18:45:50] K4-713: ejegg: at your leisure ^^ [18:46:41] ccogdill: MBeat: heads-up, outgoing thank-you letters are paused at the moment, we're trying to fix a small clog. [18:51:36] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: All contributions should be assigned a trxn_id - https://phabricator.wikimedia.org/T97683#1250033 (awight) NEW [18:53:10] hey awight thanks - k4 sent an email to fronline :) [18:53:57] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Fix blank no_thank_you - https://phabricator.wikimedia.org/T97684#1250047 (awight) NEW [18:54:28] ccogdill: Thanks! [18:54:57] ccogdill: We have a fix, I can probably deploy it within half an hour. [18:55:09] awesome! [19:04:51] awight: so that contribution is okay, even though it seems to be missing a lot of info? [19:08:16] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Throw error on save if the "contribution source" is not formatted correctly - https://phabricator.wikimedia.org/T97685#1250084 (awight) NEW [19:08:33] ejegg: There were some other data entry mistakes, ^^ [19:09:00] I think the misformatted "50 EUR" melted down some of our hooks. [19:10:07] Ahh, word. [19:10:10] Here's the batch it was a part of: select * from civicrm_contribution c left join wmf_contribution_extra e on c.id=e.entity_id where c.trxn_id is null and c.id <= 11872705 order by c.id desc limit 50; [19:10:48] I guess we still have enough info to send the TY mail, so it's fine to catch and continue [19:11:02] (CR) Awight: [C: 2] Add Astropay to Gateway Reconciliation report (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207528 (https://phabricator.wikimedia.org/T90508) (owner: Ejegg) [19:11:09] That's what I'm thinking. [19:11:19] Actually... There's probably no email for this check. But if there were, ! [19:11:32] Check out this other bug: https://phabricator.wikimedia.org/T97684 [19:11:51] We're dancing on toothpicks. suspended over caviar. [19:11:56] oh yeah, that's been annoying forever [19:12:23] (Merged) jenkins-bot: Add Astropay to Gateway Reconciliation report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207528 (https://phabricator.wikimedia.org/T90508) (owner: Ejegg) [19:12:41] ejegg: well, CR that fix if you agree, and I can deploy it... [19:13:46] we could short-circuit earlier if no email, but ehh [19:13:58] yeeeah [19:14:17] (CR) Ejegg: [C: 2] "Cool. Looks like we still have enough info for the TY" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207878 (owner: Awight) [19:14:44] That could be optimized in another patch, which preens NTY after save [19:14:53] thanks! [19:17:56] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/207896 [19:18:07] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/207896 (owner: Awight) [19:18:36] (CR) jenkins-bot: [V: -1] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/207896 (owner: Awight) [19:19:38] * awight stares incredulously. [19:20:08] ejegg: fyi, that test is not supposed to run on deployment. So it's gonna be unpleasant deploying until it can be fixed. [19:20:09] civibuild? [19:20:21] We've removed the tests from deployment. [19:21:14] https://phabricator.wikimedia.org/T94586 [19:21:46] Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Infrastructure: Disable job on CRM deployment branch - https://phabricator.wikimedia.org/T94586#1250138 (awight) p:Normal>High Raising the priority, this is now an obstacle to deployment. [19:22:23] (CR) Awight: [V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/207896 (owner: Awight) [19:23:14] !log updated crm from 59f03df6b689ef443cc7b7e31e6f5b2986bc8bc9 to 514e7ea41acd14e1565b31b76621ea840d209e07 [19:23:22] Logged the message, Master [19:23:44] !log enabling Thank You job [19:23:49] Logged the message, Master [19:24:03] Ok, seems to have recovered. [19:24:27] ejegg: I'm running away to a house full of screaming kids. You okay watching for smoke? [19:26:01] awight: sure thing [19:26:20] thanks! [19:28:56] (PS1) Ejegg: Fix an undefined variable warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207904 [20:00:47] (PS11) AndyRussG: Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [20:01:49] (PS1) Ejegg: Update advanced_help and services [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207914 [20:05:25] rrg trying to connect [20:24:42] Fundraising Sprint James Brown, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Why did TY melt down? - https://phabricator.wikimedia.org/T97685#1250347 (atgo) [20:46:44] (CR) Awight: [V: 2] Update advanced_help and services [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207914 (owner: Ejegg) [20:49:28] (CR) Awight: [C: 2] Fix an undefined variable warning (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207904 (owner: Ejegg) [20:51:17] (Merged) jenkins-bot: Fix an undefined variable warning [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/207904 (owner: Ejegg) [20:55:40] Rrrrg more unexpected weirdness with the API, ignoring the rabbit this time... [20:57:13] (CR) Awight: "Also, I wanted to clarify our conversation in IRC earlier--the other table migration should be stored in a separate sql migration file, bu" (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:00:43] awight: when you say "in the same patchset", you mean...? They're both in the Gerrit change... [21:02:36] (CR) Awight: [C: 1] Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:02:41] AndyRussG: That is what I meant! [21:02:51] awight: cool! [21:03:12] AndyRussG: Can you remind me how the incompatibility works between mw-core and extensions, when RL getDependencies is not updated? [21:03:41] I'm a little disturbed that some extensions don't have version information, e.g. https://wikiapiary.com/wiki/Extension:Gadgets [21:04:04] Yeah... uhhh several extensions override getDependencies, using of course the existing method sig [21:04:17] I definitely recommend updating the minor version number for any extensions as you make this change. [21:04:46] So when the extension has the wrong function signature, it emits a PHP warning at non-strict level, once per request? [21:04:49] Ah hmmm... [21:04:49] If the sig of the overridden method is changed, something dies a small, sad death inside the web servers [21:04:54] oh! [21:05:07] That sounds more serious :) [21:05:15] Not sure if it gangreens all the way out and kills the whole pageload [21:05:44] I only got as far as becoming aware that it was bad and stopping it [21:05:51] (CR) Awight: [C: -1] "Please update extension minor version so we can track deployment in the wild. Same for the other extensions!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206985 (owner: AndyRussG) [21:06:04] (just recording this somewhere) [21:06:09] yurp! [21:06:46] If it kills any resourceloading at all, we probably need to make a more gentle migration. [21:10:36] Also, I have a confession to make: I hate inheritance :) [21:12:43] Oh interesting, ULS uses date tags for release versioning: https://wikiapiary.com/wiki/Extension:UniversalLanguageSelector [21:13:32] HMMM [21:13:41] woops capslock fail [21:15:33] hehe [21:19:19] K this baby is now moving into the "in review" column bwahahahahahah [21:20:00] Did I say the API is brokenish again but I'm leaving it 4 now? [21:33:20] oooh [21:33:55] I see no new review... [21:34:06] * awight thinks about other ways to procrastinate [21:37:23] (PS1) Awight: Merge some of master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207990 [21:37:25] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207991 [21:37:27] (PS1) Awight: Correct recurring info text again [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207992 (https://phabricator.wikimedia.org/T94246) [21:37:29] (PS1) Awight: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207993 [21:38:18] (CR) Awight: [C: 2] Merge some of master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207990 (owner: Awight) [21:38:27] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207991 (owner: Awight) [21:38:32] (CR) Awight: [C: 2] Correct recurring info text again [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207992 (https://phabricator.wikimedia.org/T94246) (owner: Awight) [21:38:38] (CR) Awight: [C: 2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207993 (owner: Awight) [21:38:40] (Merged) jenkins-bot: Merge some of master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207990 (owner: Awight) [21:38:54] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207991 (owner: Awight) [21:38:56] (Merged) jenkins-bot: Correct recurring info text again [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207992 (https://phabricator.wikimedia.org/T94246) (owner: Awight) [21:39:05] (Merged) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/207993 (owner: Awight) [21:40:57] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/207995 [21:41:08] (PS2) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/207995 [21:41:21] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/207995 (owner: Awight) [21:46:02] !log update payments from 83d09e09178c634ad35dbb684d1c3aebbb709969 to df8aeb5d1c5f595348f77cb56d3975eca19a65a2 [21:46:09] Logged the message, Master [21:49:15] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1250714 (awight) I've deployed t... [21:49:36] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1246305 (awight) I've deployed to payments, but I'm letting donatewiki changes go out with the train (Tuesday, May 5 I... [21:53:35] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1250721 (atgo) Thanks @awight. L... [21:59:22] ejegg: ccogdill: MBeat: I'd like to try an experimental payments deployment, worst case scenario is that we drop some donation messages before they are consumed by the CRM, and we have to get them through auditing... Sound good? :) [22:00:03] awight: sounds fun! [22:00:08] :) [22:00:23] eeek experimental [22:00:26] go for it! [22:00:28] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1250744 (atgo) Let's also leave this one open until @jrobell confirms next week. Thanks @awight! [22:00:36] ;) ok, cut me down a tree, I'll get a few gallons of gasoline. [22:00:43] atgo: sure thing! [22:00:50] oh hey :) [22:01:14] anything we can be on the lookout for, awight? [22:01:55] MBeat: There could also be complaints about payments crashing before the thank-you page... [22:02:03] Otherwise, the donors shouldn't see anything. [22:02:15] I'll be watching the queue consumer to make sure messages are still coming in. [22:02:22] I should know within about 5 minutes if there are issues. [22:03:02] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: Use the new queue wrapper for adding messages to the completed and pending queues - https://phabricator.wikimedia.org/T92921#1250760 (awight) Confi... [22:03:15] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: Use the new queue wrapper for adding messages to the completed and pending queues - https://phabricator.wikimedia.org/T92921#1250762 (awight) [22:03:27] thanks [22:04:08] (PS17) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [22:04:39] (CR) AndyRussG: "Rebased one more time" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [22:04:54] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [22:05:49] (PS1) Awight: Merge deployment into master [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/208007 [22:05:59] (CR) Awight: [C: 2] Merge deployment into master [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/208007 (owner: Awight) [22:06:11] (PS18) AndyRussG: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [22:06:52] pizzzacat: did you also watch this?! https://www.youtube.com/watch?v=bScOj4e0bOQ [22:06:55] because. woah. [22:07:06] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/208008 [22:07:17] (CR) jenkins-bot: [V: -1] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/208008 (owner: Awight) [22:07:32] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [22:09:24] (PS2) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/208008 [22:09:41] (CR) Awight: [C: 2 V: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/208008 (owner: Awight) [22:10:50] !log updating payments from df8aeb5d1c5f595348f77cb56d3975eca19a65a2 to 3ab89e2b14eb449f7ceddf2325493d6235395ecd [22:10:59] Logged the message, Master [22:11:03] MBeat: ccogdill: okay, deployment happening in a few seconds... [22:11:07] (PS19) AndyRussG: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [22:11:14] done [22:11:16] cool [22:11:32] sounds good [22:11:53] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [22:11:53] making my donation... [22:12:57] (CR) AndyRussG: "Tests pass locally; failures are because the core patch needed has not been approved yet." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [22:14:34] expected behavior? [22:14:49] ccogdill: MBeat: doesn't look good, I'm rolling back my changes. Only 3 donations fell through the net, at least. [22:15:09] ok, thanks for the update [22:16:59] !log payments rolled back from 3ab89e2b14eb449f7ceddf2325493d6235395ecd to df8aeb5d1c5f595348f77cb56d3975eca19a65a2 [22:17:07] Logged the message, Master [22:17:41] ah okay [22:17:48] too bad! [22:18:40] oops, the issue was just configuration. Trying one more time. [22:19:41] !log payments redeployed, revision for payments-wiki changed... from df8aeb5d1c5f595348f77cb56d3975eca19a65a2 to 3ab89e2b14eb449f7ceddf2325493d6235395ecd [22:19:47] Logged the message, Master [22:21:48] ccogdill: MBeat: fyi, I've redeployed with corrected configuration, I'll let you know how it goes this time. [22:27:42] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Queue consumer should provide the contribution ID after it's been inserted - https://phabricator.wikimedia.org/T97724#1250821 (awight) NEW [22:28:15] ccogdill: MBeat: woohoo, I think we can keep the change! In other words: nothing happened :) [22:28:31] cool! [22:28:55] nice! [22:29:26] * awight pats at drop of sweat [22:32:29] ohh very nice! [22:32:40] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Make the forms come from one template - https://phabricator.wikimedia.org/T86248#1250852 (atgo) [22:32:46] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: Write an abstracted interface for queue send and receive - https://phabricator.wikimedia.org/T92916#1123830 (awight) Leaving open in hope that @eje... [22:33:14] K4-713: hehe, your nick breaks Phabricator's ping parser [22:33:19] Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, Astropay Integration: Make mustache form for Astropay credit cards - https://phabricator.wikimedia.org/T97056#1250855 (atgo) [22:33:26] https://phabricator.wikimedia.org/T92916#1250839 [22:33:32] Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-Templates, MediaWiki-extensions-DonationInterface, I18n: Mustache renderer needs to support i18n - https://phabricator.wikimedia.org/T97149#1250856 (atgo) [22:33:47] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, Fundraising-Backlog: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1250859 (atgo) [22:35:12] * awight kicks a locker [22:35:19] awight: I'll look over the rest of it [22:36:00] Unrelated, don't worry :) Awesome, thanks! [22:36:06] awight: What did I do? [22:36:09] Break the world? [22:37:23] nah, I was looking for free CR [22:38:06] Am I impossible to ping in Phabricator? [22:38:09] yes [22:38:14] GWAHAHAHA [22:38:15] Well, I could CC you [22:38:17] * K4-713 coughs [22:42:25] K4-713: On the bright side, I just deployed phase 1 of the PCI queue work... All completed and pending donations are going through the new library. [23:00:05] (PS1) Ejegg: Validate source field on manual donation entry [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/208019 (https://phabricator.wikimedia.org/T97685) [23:01:28] Fundraising Sprint James Brown, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Why did TY melt down? - https://phabricator.wikimedia.org/T97685#1250961 (awight) @atgo: I don't agree that the new title is even related--Maybe a distant blocked task at best. Or I am missin... [23:07:48] Fundraising Sprint James Brown, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Why did TY melt down? - https://phabricator.wikimedia.org/T97685#1250974 (atgo) @awight we talked it through after standup and wanted to leave this as an investigation/spike since @ejegg and @... [23:13:35] Fundraising Sprint James Brown, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Why did TY melt down? - https://phabricator.wikimedia.org/T97685#1250995 (awight) I see, thanks for explaining--please make that a second card if you wish, but I did my own investigation and p... [23:14:38] awight: ready! [23:14:59] k [23:58:09] (CR) Awight: "Want to validate that it's a supported currency, while you're in there?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/208019 (https://phabricator.wikimedia.org/T97685) (owner: Ejegg) [23:58:55] (CR) Ejegg: "Sure, good call" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/208019 (https://phabricator.wikimedia.org/T97685) (owner: Ejegg)