[14:38:22] (PS1) Awight: WIP Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [14:38:47] (CR) jenkins-bot: [V: -1] WIP Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [16:09:48] (PS3) Ejegg: Push gateway_params down into data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208275 [16:41:33] http://3v4l.org/tT4l8 [16:50:13] (PS2) Awight: WIP Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [16:50:35] (CR) jenkins-bot: [V: -1] WIP Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [17:02:50] (PS3) Awight: Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [17:04:10] (CR) jenkins-bot: [V: -1] Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [17:06:45] (PS4) Awight: Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [17:07:22] Fundraising Sprint James Brown, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Technical-Debt: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1257599 (awight) [17:18:31] (CR) Awight: "Thanks for the review!" (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [17:18:46] (PS6) Awight: MWException -> Exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [17:18:54] (PS7) Awight: MWException -> Exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [17:21:51] (PS2) Awight: MWException -> Exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/184021 (owner: Ori.livneh) [17:22:06] (CR) Awight: "PS 2: Manual rebase" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/184021 (owner: Ori.livneh) [17:28:58] (PS3) Awight: MWException -> Exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/184021 (owner: Ori.livneh) [17:29:19] (PS4) Awight: MWException -> Exception [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/184021 (https://phabricator.wikimedia.org/T97855) (owner: Ori.livneh) [17:29:35] K4-713: hey. https://gerrit.wikimedia.org/r/208643 [17:29:41] Eep. [17:29:46] HI [17:29:51] HI ADAM. [17:30:21] ...oooh. I actually want to read this, though. [17:30:24] OH OHAI [17:32:32] * awight gulps watery coffee and chokes a bit [17:32:50] awight: Hum. I wonder about some of the changes there, actually. [17:34:07] I think some things go nuts when you auto-include classes you don't actually have enabled. [17:34:27] And then you end up whitelisting stuff you have disabled. [17:34:42] That seems unlikely--we would have to "class_exists" to cause that sort of situation [17:35:04] Well, when I say "stuff goes nuts" I might mean deliberately. [17:35:34] ok, I'll look around for stuff gone nuts [17:35:44] I'll check for any funky tests of globals or class_exists... [17:36:01] I think a lot of mess comes out of forms being enabled. [17:36:15] what's the technical definition of snowflake? [17:36:35] Beautiful and unique codebase! [17:36:41] Or... okay, just unique. [17:36:46] aaaah gotcha :) [17:36:57] Also... so MWException is like, deprecated? [17:37:06] Apparently, there has been a finding of two "identical" snowflakes, in 1988: http://en.wikipedia.org/wiki/Snowflake#Uniqueness [17:37:07] Perhaps "maddening" and/or "incomprehensible" should get thrown in there too. [17:37:11] AndyRussG: yyyeah [17:37:20] I pushed people to document WTF, but that didn't happen. [17:37:20] melts in your hand? [17:37:26] awight: ah K, thx :) [17:37:46] Do we have Dylan yet? [17:37:50] https://phabricator.wikimedia.org/T86704 FYI [17:38:06] The only explanation I can offer is my straw-man argument in that bug [17:38:48] awight: thx [17:39:14] Oh, and I have spoken to Dylan this morning. HR has him. [17:39:30] * awight does the dance of the captive techsen [17:39:52] morning fr tech [17:40:15] http://www.people.vcu.edu/~djbromle/portrait04/paul/Image88.gif [17:41:24] cwdent: hi!! and welcome!! ;D (tho I think officially next week?) How's everything? [17:41:40] cwdent: Good morning! [17:41:58] K4-713: I'm not sure what you mean by "forms being enabled", are you talking about wgSpecialPages or DonationFormSettings.php ? [17:42:03] good! excited for next week [17:42:15] just been finishing up some projects i started while unemployed [17:42:16] cwdent: fantastic :) yeah us too :) [17:42:39] ahh right that sounds well-organized... [17:42:49] * AndyRussG nevvvver puts off stuff like that [17:42:53] awight: I'm just talking ffnames that are associated with disabled gateways. [17:43:15] pasted this earlier but not sure if anyone noticed http://3v4l.org/tT4l8 [17:43:30] There was an awful lot of logic in there to make sure that nothing that is disabled even gets defined, but I think it depends on... the globals not being there at all. [17:43:31] howdy cwdent! [17:43:37] figured out what is going on finally, == is just more hosed than i realized [17:43:56] K4-713: I see, yeah--wgDonationInterfaceEnable* globals still work in DonationInterfaceFormSettings, but only if you include that file after the settings :( [17:43:59] grr [17:44:07] interprets strings like #e# as exponents [17:44:19] * K4-713 shakes fist at php [17:44:23] and does some silent hex/dec juggling [17:44:35] (PS2) AndyRussG: Pls don't merge - WIP - CNBannerChoiceDataResourceLoaderModule::getDependencies() method signature [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206985 [17:44:41] cwdent: Yeah, I usually go 100% suspicious when I see a '==' anywhere. [17:45:21] php, it keeps you on your toes [17:45:38] yep, all false with === [17:45:47] Or, crawling across the landscape on your elbows. :) [17:46:44] interesting [17:46:54] also useful-looking site BTW [17:47:08] K4-713: What do you think about moving DonationInterfaceFormSettings into the extension? We can still override from LocalSettings... [17:47:41] * K4-713 goes dark for a second [17:47:51] * awight taps wiretap [17:48:10] I... think I need to have a massive argument with myself about that now. [17:48:32] The main argument in favor of my crazy suggestion is, we want this thing to work out of the box. [17:48:45] Riiiight... but here's the thing. [17:49:05] Right now, all the forms are intended to be unique to us. [17:49:25] We'd have to come up with some more rigid use of ffname for that to make sense. [17:49:28] Yes, but they're already defined in the extension... with WMF text and all... [17:49:29] Or... [17:49:42] Er, they shouldn't be. [17:49:55] Or, you mean, the form pieces? [17:49:58] And, the forms themselves should be equally applicable to other orgs. [17:50:01] yeah [17:50:18] This is one of those things that only exists the way it is now, because we got all idealistic at some point and then had to drop it midway to the goal. [17:50:26] k [17:50:59] So, either we admit that we're not doing what we intended and embrace it (i.e. - go ahead and bake it in as you suggest) or abstract the whole thing out to another thing. [17:51:09] And there's the argument. [17:51:15] I don't know what I like. [17:51:22] Ideally... there are two pieces: one is a definition of the gateway's capabilities, the second is the subset of the capabilities which we have enabled for WMF [17:51:30] aye [17:51:46] And, we don't have the insight beyond our own accounts to do the first one correctly at this point anyway, imo. [17:52:09] It's fine to have the capabilities defined as: what our code supports [17:52:20] Which is pretty much, what our accounts support [17:52:24] yep [17:52:40] * awight is still leaving heavily towards: put it all in the extension [17:53:00] Yeah... I am beginning to lean that direction. [17:53:06] I'm only worried about practical safety concerns, that it might be twitchy overriding these structures from LocalSettings [17:53:45] Well, the nice thing about just admitting it is what it is, is that we can clean up a lot of dumbass things I never liked. [17:53:59] :D [17:54:16] And then they're all in one place for when we decide it's worth doing more... hm. Thoroughly. [17:54:19] I'm also equipped to add dumbass things, if needed [17:54:45] I can also do that all day. [17:54:46] yeah that's sort of the approach I took with the gateway controller logic: put it all in the adapter so we know we need to clean up later. [17:54:49] hired [17:54:55] <_< [17:54:56] >_> [17:55:33] Well, I'll make a second patch to do this, and we can both argue with ourselves there, later [17:56:00] Rad. [17:59:17] (CR) Ejegg: [C: 2] "Awesome, thanks for putting up with the nitpicks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [18:01:22] (Merged) jenkins-bot: MWException -> Exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [18:04:49] awight: you finally convinced me to take the dictionary approachto the campaign mixin params, so I'm gonna add a new join table for campaign mixin params [18:05:12] * AndyRussG checks his skull thickness [18:06:07] AndyRussG: Not sure how I accomplished that :p [18:06:24] Uhh rational discourse [18:06:33] It was the analytics thing, huh? That case will probably never happen :) [18:07:01] brghghllk [18:07:03] lol ok lemme know if there's anything I should review [18:07:22] K will do, thx! [18:07:25] is the value a blob or an indexed string? :D [18:08:14] I feel... ah... a BLOB! [18:08:50] /o\ [18:08:58] Or maybe we could have both fields? [18:09:20] I don't get it [18:09:30] One for "fundamental" datatype params and one for fields that just wanna be BLOBs? [18:09:43] Well, I don't want to totally write off the use case of more complex parameter data structures [18:10:39] Your quesiton caught me off guard, I hadn't really thought about it yet [18:11:23] For the analytics use case, using the dictionary approach would make it easy enough to pull all the values used in campaigns for a given parm [18:11:59] I'm not sure you'll reap the benefits of the normalization, if any, if the value is a blob. You could start with strings and then migrate to blob if that becomes necessary... [18:12:24] In that case you wouldn't be using the MySQL index for analysis in any case. The dictionary approach just makes it simpler to see what the values of tha param are across several campaigns [18:12:29] But OK yes that also sounds fine [18:12:36] Indexed first and add BLOB as needed [18:12:48] btw, I don't think we're alone, I saw this same discussion fly by wrt. UserPreferences, on #wikimedia-dev [18:13:20] Yea hmm not surprising, well let's just kick out our RMDBs and use structured data [18:13:56] You hate BLOBs BTW? (<- not serious) [18:14:09] Scary movie, it must have damaged me [18:14:27] http://en.wikipedia.org/wiki/The_Blob#/media/File:The_Blob_poster.jpg [18:14:32] Beware of the Blob... [18:14:40] Such a good song. [18:16:10] ☊ [18:16:11] https://www.youtube.com/watch?v=OG2-ccAEcWs [18:16:51] ♮♫ agree [18:36:22] hey awight [18:36:35] just a heads up - rlewis can get someone from engage to test after the deploy [18:36:47] when should she aim for? [18:37:07] atgo: Probably 2pm, thanks! [18:38:13] (CR) JanZerebecki: [C: 1] "Looks good, though didn't verify the call sites." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/184021 (https://phabricator.wikimedia.org/T97855) (owner: Ori.livneh) [18:45:03] sure awight! i just replied on that thread with that info, so if you could confirm over there when it goes out that owuld be rad [18:48:36] (PS1) Awight: Move default DonationInterfaceFormSettings into the extension [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208704 (https://phabricator.wikimedia.org/T94477) [18:53:29] (PS1) Awight: Squirrely hand merge of Engage features [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/208708 [18:54:40] (CR) jenkins-bot: [V: -1] Squirrely hand merge of Engage features [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/208708 (owner: Awight) [18:55:33] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/208710 [18:55:51] ejegg: Can you peek at https://gerrit.wikimedia.org/r/208708 this afternoon? [18:55:56] sure! [18:56:23] Donno if that was the best move... Contrary to appearances, I try not to do any actual changes in the deployment branch... [18:56:26] (CR) jenkins-bot: [V: -1] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/208710 (owner: Awight) [18:56:44] (jenkins failures mean nothing--the tests are missing) [18:58:51] looks fine, as long as we can go back to normal merges for the next bunch! I see the source validation is wrapped up in there too [18:59:03] yep [18:59:13] Yeah, the next commit is a normal merge [18:59:56] ok, i'll just peep it for another min [19:00:01] Not sure how to do better next time, I would have had to revert the revert, and I think your validation patch was null-merged or something. [19:00:16] I guess, in the future we should do the revert on -master and move the feature into a branch. [19:02:33] Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog: Send announcement to CN-Admins about upcoming technical and UI changes - https://phabricator.wikimedia.org/T98053#1258242 (atgo) NEW [19:03:10] Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog: Send announcement to CN-Admins about upcoming technical and UI changes - https://phabricator.wikimedia.org/T98053#1258251 (atgo) [19:09:23] ejegg: The new deployment head passes my smoke testing, fwiw [19:09:48] (PS1) Awight: Correct new role name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/208712 [19:10:04] (CR) Ejegg: [C: 2] "LGTM" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/208708 (owner: Awight) [19:11:12] (CR) Awight: [V: 2] Squirrely hand merge of Engage features [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/208708 (owner: Awight) [19:11:35] (CR) Awight: [C: 2 V: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/208710 (owner: Awight) [19:12:41] !log update crm from 514e7ea41acd14e1565b31b76621ea840d209e07 to 2a2336655737a2cd1d3cc24624d1e8475e4cf039 [19:12:47] Logged the message, Master [19:13:33] so, processResponse refactor is getting tricky. dealing with code paths that want to both set transactionResult keys and return error codes / retry vars. [19:14:39] Oof, sorry to hear it. U wanna draw a line somewhere and stop, or are your changes already incompatible with some of the gateways? [19:15:22] I'll put up a WIP to sanity check soon [19:15:29] I'm happy to dive in there too, if I wouldn't be in your way. [19:15:43] I totally have a pitbull jawlock on DI... [19:16:30] Actually, the keys we're setting on those paths are mostly things we should move out of response! [19:16:37] Like final status [19:17:22] Yeah, that looked like a really productive thing to refactor. There are so many misunderstandings baked in... I can take credit for more than a few. [19:34:04] (PS7) Awight: WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) [19:34:38] (CR) jenkins-bot: [V: -1] WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [19:37:31] Fundraising-Backlog: Make automated refunds possible in Worldpay - https://phabricator.wikimedia.org/T89046#1258395 (atgo) [19:37:32] Fundraising-Backlog, Epic: Make WorldPay more robust - https://phabricator.wikimedia.org/T77909#1258394 (atgo) [19:49:01] Fundraising Sprint Enya, Fundraising Tech Backlog, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, and 3 others: Do banner hiding with mixins - https://phabricator.wikimedia.org/T86100#1258474 (atgo) Should we close this one as invalid/declined? [19:50:36] Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, Astropay Integration: Make mustache form for Astropay Brazilian credit cards - https://phabricator.wikimedia.org/T97056#1258487 (atgo) [19:52:02] (PS3) Awight: WIP forms refactor styles [extensions/DonationInterface] (formsRefactor) - https://gerrit.wikimedia.org/r/205912 (https://phabricator.wikimedia.org/T97056) (owner: Ssmith) [19:52:27] (CR) jenkins-bot: [V: -1] WIP forms refactor styles [extensions/DonationInterface] (formsRefactor) - https://gerrit.wikimedia.org/r/205912 (https://phabricator.wikimedia.org/T97056) (owner: Ssmith) [19:53:47] Fundraising Sprint James Brown, Fundraising Tech Backlog: Refactor DI's response processing - https://phabricator.wikimedia.org/T98063#1258500 (Ejegg) NEW a:Ejegg [19:53:49] Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1258508 (atgo) [19:56:02] Fundraising Tech Backlog, Fundraising-Backlog: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#1258524 (atgo) [19:58:02] Fundraising-Backlog, § Fundraising Sprint Abba: Make GC and WP visually match what's on donate wiki (and consequently eachother) - https://phabricator.wikimedia.org/T86086#1258536 (atgo) [19:58:08] Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba: Make GC and WP visually match what's on donate wiki (and consequently eachother) - https://phabricator.wikimedia.org/T86086#961283 (atgo) [20:01:34] (PS3) AndyRussG: Pls don't merge - WIP - CNBannerChoiceDataResourceLoaderModule::getDependencies() method signature [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/206985 [20:08:34] (PS4) Ejegg: Push gateway_params down into data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208275 [20:08:36] (PS2) Ejegg: getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 [20:08:38] (PS3) Ejegg: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 [20:08:40] (PS1) Ejegg: Start refactoring processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) [20:24:02] hey! does anyone know how far away someone should be for the "work with less frequently" review for the annual reviews? [20:24:13] uhhh... [20:24:22] * K4-713 reads email for once [20:24:29] https://office.wikimedia.org/wiki/WMF_2014_-_2015_Annual_Review_and_Retrospective [20:24:40] Aw man. email *and* a wiki page? [20:24:50] I'm not going for employee of the month, here. :p [20:25:23] atgo: Ah, that. [20:25:39] For you, this might be a little... odd. [20:25:42] word. [20:25:50] i've already discovered that :) [20:25:56] So, in the past, fundraising tech has just picked people in fundraising proper to fill that part. [20:26:09] i'm just wondering if the not-so-close people should be people within FR who i work with less or people outside of FR [20:26:12] But you're the keystone between the two, so... [20:26:17] like... the product team [20:26:25] Yeah, you might have to go outside the whole deal. [20:26:31] I mean, I think I would, if I were you. [20:26:34] oy. ok [20:26:49] yeah [22:29:32] * K4-713 waves at XenoRyet [22:32:25] Hi there [22:32:33] You made it! :) [22:32:41] Yea, guess I'm in the right spot [22:33:07] Yep. I have a ton of other channels to share at some point, but that can probably wait for a bit. [22:34:23] Probably so. I'll just lurk here for the time being. [22:34:41] Sounds like a plan. [22:54:41] (PS8) Awight: WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922)