[00:08:04] (PS6) Awight: Push gateway_params down into data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208275 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:09:44] (CR) Awight: [C: 2] Push gateway_params down into data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208275 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:09:45] (Merged) jenkins-bot: Push gateway_params down into data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208275 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:09:45] (PS3) Awight: Move Final Status out of transaction_results, use consts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208872 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:13:16] am i guessing right that XenoRyet1 is dylan?? [00:13:19] welcome :) [00:13:51] Usually without the 1, but yes. [00:27:55] (CR) Awight: [C: 2] Move Final Status out of transaction_results, use consts (7 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208872 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:28:05] (PS6) Awight: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:28:17] (Merged) jenkins-bot: Move Final Status out of transaction_results, use consts [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208872 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:28:55] XenoRyet1: punk as funk! [00:29:16] ohai awight. [00:29:34] K4-713: Still trying to set a record for last person at work? [00:29:45] Oh hell no. I'm waiting for the science to start. [00:29:50] ah! [00:29:52] oh sad [00:29:53] new host [00:29:57] Right? [00:29:58] you? [00:30:02] ...yes. [00:30:06] !!woot [00:30:12] I've been promoted to Chief Science Officer. [00:30:18] * awight splutters [00:30:33] they told you that was a promotion? [00:31:07] It's better than Executive Officer In Charge Of Radishes. [00:31:09] ejegg: I like that this processResponse stuff is not on a branch :p this is how we get ants [00:31:09] I think. [00:31:20] A feather in your cap :D [00:31:24] awight: ooh, risky, that [00:31:52] I got to the point of mushing all the parse* calls under processResponse today, and it is not really looking like a win. [00:32:00] uh no! [00:32:06] here, let me put the failing WIP up [00:32:08] too long a function? [00:32:35] I don't remember if I commented, btw... you might gain a year back from the middle of your life, if... [00:32:43] just a lot of repeating transaction_result->setXY( parseXY() ) [00:33:05] u did the harder patches here in smaller pieces, a non-destructive commit first, then the gateways can be migrated independently. [00:33:29] Usually, introduce a second function rather than overloading the old ones... [00:33:41] ejegg: aughh! [00:33:57] (PS1) Ejegg: WIP fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 [00:33:59] (CR) jenkins-bot: [V: -1] WIP fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (owner: Ejegg) [00:35:38] awight: ehh, maybe pushing those set calls to the front of processResponse is a valid way to start migrating to the new signature [00:37:03] Thanks for all the comments awight! [00:37:12] I'll mull 'em over some more tomorrow. [00:37:28] happy cinco de mayo, all [00:37:38] bye bye! [00:54:45] (CR) Awight: "incomplete review" (10 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [15:23:22] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice: Lock forbidden countries out of CentralNotice, for fundraising campaigns - https://phabricator.wikimedia.org/T98263#1265080 (Pcoombe) I wouldn't consider this a priority to be honest. We don't tend to do blanket campaigns in the same way as pr... [15:54:30] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1265175 (Pcoombe) Open>Resolved a:Pcoombe Just checked, this looks good now. Thanks! [15:58:29] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1265191 (Pcoombe) @jrobell is of... [16:57:59] * K4-713 yawns [16:59:57] * ejegg throws a water balloon *Wakey wakey!* [17:17:17] Fundraising Dash, Fundraising Sprint Enya, Fundraising Tech Backlog, § Fundraising Sprint Abba, and 4 others: Notify existing Sprint Projects about new Sprint extension upgrade changes - https://phabricator.wikimedia.org/T89646#1265678 (Christopher) A couple of notes about the latest Sprint chang... [17:22:51] (PS2) Ejegg: Fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) [17:22:53] (CR) jenkins-bot: [V: -1] Fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [17:28:17] K4-713, AndyRussG|a-whey: here is your weekly last-minute call for Scrum of Scrums input! [17:29:15] ejegg: I have nothing. [17:29:31] k [18:03:36] (PS7) Ejegg: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) [18:05:16] (CR) Ejegg: Prepare to prune $transaction_results (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [18:21:52] Fundraising Tech Backlog, MediaWiki-extensions-CentralNotice: Lock forbidden countries out of CentralNotice, for fundraising campaigns - https://phabricator.wikimedia.org/T98263#1266033 (awight) Open>Invalid a:awight Aha, okay thank you for the confirmation! Marking this as invalid. [19:18:44] (PS5) Awight: Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [19:34:35] (PS3) Ejegg: Fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) [19:34:37] (PS5) Ejegg: Fix comm status and error checking for PaymentStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206327 (https://phabricator.wikimedia.org/T90504) [19:34:39] (PS5) Ejegg: getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) [19:34:41] (PS5) Ejegg: Start refactoring processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) [19:34:43] (PS2) Ejegg: Add limbo queue message before redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207843 (https://phabricator.wikimedia.org/T90504) [20:02:25] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1266467 (Ejegg) Looks like these changes are in 1.26wmf5, not 1.26wmf4, so they'll go out to DonateWiki on Tuesday the... [20:10:44] (CR) Awight: "Deployment:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/184022 (https://phabricator.wikimedia.org/T86704) (owner: Ori.livneh) [20:15:29] awight: got the latest couple astropay patches stacked on top of the processResponse refactor, and it seems like the refactor did help there [20:20:29] ejegg|bike: Whew! I'm looking forward to reading the one where you consolidate all the processing and setting... I've been thinking that this stuff should be split into a separate class, so those are all internal assignments, but not sure what this stuff looks like yet, cos it's so finely dispersed. [20:31:21] (PS6) Awight: Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [20:31:23] (PS1) Awight: Add Special page aliases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209369 [20:31:38] (PS2) Awight: Add Special page aliases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209369 [20:31:54] (PS7) Awight: Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [20:32:35] (CR) Awight: "PS 6: rebase onto a patch for the missing special page aliases" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [20:43:33] (CR) Awight: Make DonationInterface config less of a snowflake (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [20:44:01] (PS8) Awight: Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) [21:03:31] (CR) Ejegg: [C: 2] "That's the voodoo we need!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209369 (owner: Awight) [21:03:55] (Merged) jenkins-bot: Add Special page aliases [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209369 (owner: Awight) [21:04:09] Oooh. You guys doing voodoo? [21:04:14] Before sunset? [21:04:18] ejegg: n.b. I donno if there is an i18n/*.json equivalent yet for special page aliases [21:04:27] but i don't practice Santeria... [21:04:40] ...don't got no crystal ball? [21:08:20] (CR) Ejegg: [C: 2] "Thanks, this will surely save a bunch of time and headaches!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [21:08:51] (Merged) jenkins-bot: Make DonationInterface config less of a snowflake [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208643 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [21:09:07] K4-713: btw, you might like where this is going: https://gerrit.wikimedia.org/r/#/c/209378/ [21:09:29] ejegg: thanks! What do you think about the formsettings? [21:09:44] (PS2) Awight: Move default DonationInterfaceFormSettings into the extension [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208704 (https://phabricator.wikimedia.org/T94477) [21:10:10] awight: also seems like the right thing to do [21:10:43] k. There's definitely work to do splitting WMF config out from the defaults, but I figure this is a reasonable first step. [21:10:47] will be great to not need much extra magic to be able to use DI [21:11:25] We should default to all-on for development, but I'm wondering how to still fail open. [22:11:49] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267170 (awight) NEW [22:12:06] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1267181 (atgo) Open>Resolved [22:12:44] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: Write an abstracted interface for queue send and receive - https://phabricator.wikimedia.org/T92916#1267186 (atgo) a:awight [22:12:47] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: Use the new queue wrapper for adding messages to the completed and pending queues - https://phabricator.wikimedia.org/T92921#1267184 (awight) Ope... [22:13:04] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: Write an abstracted interface for queue send and receive - https://phabricator.wikimedia.org/T92916#1267188 (awight) Open>Resolved [22:16:53] Fundraising Sprint James Brown, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Throw error on save if the "contribution source" is not formatted correctly - https://phabricator.wikimedia.org/T97685#1267201 (Ejegg) Open>Resolved [22:17:26] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267215 (atgo) a:awight [22:17:40] Fundraising Sprint James Brown, Fundraising Tech Backlog, Patch-For-Review: MWException -> Exception - https://phabricator.wikimedia.org/T97855#1267217 (atgo) a:awight [22:26:45] Fundraising Sprint Indigo Girls, Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1267256 (awight) [22:26:59] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint K, Fundraising Tech Backlog, and 4 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1192208 (awight) [22:27:52] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1267262 (atgo) [22:28:13] Fundraising Sprint K, Fundraising Tech Backlog, Astropay Integration, Patch-For-Review: Write confirmation message listener for Astropay, which rescues donations from the limbo queue - https://phabricator.wikimedia.org/T90506#1267265 (Ejegg) [22:29:49] Fundraising-Backlog: Enabling Paypal in local currency (CNY) for China - https://phabricator.wikimedia.org/T96062#1267272 (atgo) [22:31:00] Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog: Send announcement to CN-Admins about upcoming technical and UI changes - https://phabricator.wikimedia.org/T98053#1267274 (atgo) p:Triage>Normal [22:31:39] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: We need a way to debug which form partials are being loaded - https://phabricator.wikimedia.org/T96440#1267278 (atgo) [22:32:56] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Document CiviCRM custom imports - https://phabricator.wikimedia.org/T92025#1267280 (atgo) p:Triage>Normal [23:08:44] hey awight [23:09:03] I think I’ve dug myself into a mysql hole again… do you have a minute, by chance? [23:17:26] ccogdill: i might be able to help [23:17:38] ah thank you ejegg! I figured it was a bit late to ask you [23:18:06] heh, i keep nearly PST hours these days [23:18:11] or PDT rather [23:18:53] so I’m sending an email to a list of people whose gc recurrings failed this year (I have a couple lists separated by month). I want to make sure I’m not emailing people who have set up new recurring donations since then [23:19:20] so my plan was to check the order ids on my list and see if people with those email addresses had a recent recurring donation [23:19:29] ok, cool [23:19:55] I think I may be going about it in a more complicated way than necessary… so it would be best if I showed you :) [23:20:04] should I just paste it here or on phab? [23:20:12] phab's probably nicer [23:20:29] k [23:21:17] ejegg: https://phabricator.wikimedia.org/P615 [23:22:26] the reason I’m trying to pull a list with their email address is because I was planning on using this as a suppression list for the email — basically if you’re on the list resulting from this query, you won’t get my email. [23:22:48] ah, cool [23:23:02] taking a look [23:23:19] thanks! [23:24:44] is the query taking forever, or not giving the results you expect? [23:24:52] not giving the results I expect [23:24:56] I keep getting an empty set [23:25:00] hmm, ok [23:25:02] and I know it shouldn’t be empty [23:25:44] because at least one transaction on the list retried and succeeded on 3/17 ( order id 7289538975) [23:26:04] hmm, joins look ok at first glance [23:30:17] ccogdill: if I change the query to count(*) without joining to your import table, it says there are 2124 rows, so I'd suspect something's up with that first join [23:30:29] yeesh [23:30:58] it’s funny because I performed a similar query yesterday with that first join and it worked [23:31:48] can you try to grant me permissions to your table? [23:32:08] something like GRANT SELECT on ccogdill.GCID0315 to 'ejegg'@'localhost' [23:32:25] sure... [23:33:02] ah [23:33:07] I don’t have permission to grant access [23:33:15] d'oh! [23:33:32] I think there's a phab ticket asking to let us all see each others' stuff [23:33:55] yeah I’ve been running into permissions issues all over the place lately :p [23:34:10] if it helps I pasted a working example of joining my table to wmf_contribution_extra on phab [23:34:13] https://phabricator.wikimedia.org/P615 [23:34:48] that’s just a different table for a different month’s worth of data - but the same basic idea. the only real difference is the contribution_recur table [23:36:04] Huh, join sure looks the same [23:36:13] right?! I don’t understand what’s different [23:36:27] Ooo, looks fun [23:36:46] :D [23:38:36] if this is too crazy, ejegg, I can keep tinkering with it tonight… I may import a file with the email addresses I have to cut out the need for the contribution table and see if that makes it easier [23:39:39] sometimes an "explain" before your query will give an idea of where it's failing. [23:39:53] just explain SELECT … ? [23:39:56] yeah! [23:39:58] k [23:41:00] ahh, i have a theory [23:41:16] mmm? I’m trying to make sense of this explain thing… [23:41:24] so the ids in your table are the failed transactions, right? [23:41:41] yeah [23:42:11] We might need an extra join to the contributions table with a different alias [23:42:23] why? [23:42:48] So, your join right now will only look at the rows related to those specific failed transactions [23:43:32] hmm okay. so if a transaction with the same order id succeeds later, my join wouldn’t pick up on that second attempt? [23:44:20] oh hmm, let me remind myself what links recurring transactions together [23:46:06] could the problem be that the trxn_id in the contribution and contribution_recur tables is different from the one in wmf_contribution_extra and my GCID0315 table? [23:46:37] one being “RECURRING GLOBALCOLLECT 7289538975-6” and the other just “7289538975” [23:46:50] yeah, i think that's it! [23:46:55] bah [23:47:03] let me see if there's anything else we can join the recurring table on... [23:47:13] oh hey, how about just the contact id? [23:47:18] doh [23:47:26] haha sheesh [23:48:14] Yep, ejegg got it: "JOIN civicrm_contribution_recur ON civicrm_contribution.trxn_id = civicrm_contribution_recur.trxn_id [23:49:02] That join should be, "join civicrm_contribution_recur on civicrm_contribution.contribution_recur_id = civicrm_contribution_recur.id" [23:49:36] joining on contact.id will squash civicrm_contribution_recur.trxn_id, I think? [23:50:13] gah I’m still getting an empty set! [23:51:25] can you paste the explain results? [23:51:58] done [23:52:01] https://phabricator.wikimedia.org/P615 [23:56:31] awight: I think it's OK to join on contact_id, since she wants ppl who have re-established a new recurring donation that may not be connected to their old recurring donation that failed [23:56:46] d'oh, but then the contact ids might not even be related [23:56:53] :( [23:56:56] ccogdill: What is an example ccogdill.GCID0215.id ? [23:57:08] 7289538975 [23:57:16] ccogdill: I think you'll have the best results if you upload the email list and join from there [23:57:18] this is the magic one that should return if the query is right [23:57:21] okay [23:57:35] I was getting close to doing that, ejegg, so that won’t be too hard [23:57:49] cool. [23:58:08] well thank you for looking at it [23:58:12] we could do that kinda join with the data you've got in the table, but it would get pretty hairy [23:58:24] I’m starting to see that [23:59:03] man I really thought I had this one right, too! foiled again