[00:00:17] heh. It's a complex schema with some dirty data! [00:00:41] tell me about it! [00:01:38] ccogdill: Can you explain again how you used to build the GCID0215 table? [00:01:46] Maybe there really isn't anything in that date range? [00:02:23] oh no awight I’m sorry, I gave you an ID for 0315, not 0215… here’s one on that list: 25612498 [00:02:35] the GCID0215 table only has one column with the id in it [00:02:59] so just create table, and “LOAD DATA LOCAL INFILE '/tmp/GCID0215.csv' INTO TABLE GCID0215;" [00:03:18] sorry here’s the create: “CREATE TABLE GCID0315 ( ID varchar(255) COLLATE utf8_unicode_ci unique key );" [00:03:35] ccogdill: You're pretty sure that some of these people have: civicrm_contribution_recur.start_date < '2015-05-06' AND civicrm_contribution_recur.start_date > '2015-03-13' [00:03:39] ? [00:03:47] this one specifically 7289538975 [00:03:51] from the 0315 list [00:03:57] thx [00:04:11] awight: that contribution links to an email that's on 4 different contacts [00:04:28] nice [00:04:57] ccogdill: that one has a start_date of 2014-12-16 22:17:27 [00:05:02] eh [00:05:14] so I thought the start_date was meaningless in that data [00:05:26] and it would always be the actual contrib date [00:05:35] my bad... [00:06:01] I see, vs. receive_date then? [00:06:16] i guess [00:14:06] so awight there is no receive_date in civicrm_contribution_recur [00:14:22] would use just use the date in civicrm_contribution instead? is the recur table funkier than I want to deal with? [00:14:38] _recur is just the subscription, so yeah civicrm_contribution.receive_date is the date each payment is settled. [00:14:49] okay I’ll try that instead [00:14:49] thanks! [00:14:59] awesome, keep us posted [00:16:23] hmph no luck… still empty set [00:16:32] I’ll try importing my file with email addresses and see if that helps [00:18:36] can u post the current query? [00:18:46] btw, a new paste is better than as a comment [00:18:54] ohh okay [00:19:13] https://phabricator.wikimedia.org/P616 [00:19:20] hah “an untitled masterwork" [00:24:51] reading... [00:24:59] (btw, refresh for newlines :) [00:27:51] ooh! you made it prettier [00:31:55] awight|distract I think I got it when I used email address [00:32:02] returned a very sane number of results... [00:44:40] thanks again for your help ejegg and awight! have a good night :) [00:44:52] good night ccogdill ! [00:48:13] (CR) Ejegg: [C: 2] "Looks good! Scratch one more speed bump from the onramp..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208704 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [00:48:41] (Merged) jenkins-bot: Move default DonationInterfaceFormSettings into the extension [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208704 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [00:49:24] (PS1) Ejegg: Replace setTransactionResult calls in Adyen adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209408 (https://phabricator.wikimedia.org/T98063) [00:50:15] good evening all [01:04:59] Fundraising Sprint James Brown, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Technical-Debt: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1267688 (awight) a:awight [01:05:52] Fundraising Sprint James Brown, Fundraising Tech Backlog: MWException -> Exception (DonationInterface) - https://phabricator.wikimedia.org/T97855#1267689 (awight) [01:33:37] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267739 (awight) [01:35:04] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Enable CiviCRM's cache clear job - https://phabricator.wikimedia.org/T98428#1267741 (awight) NEW [01:36:01] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Enable CiviCRM's cache clear job - https://phabricator.wikimedia.org/T98428#1267752 (awight) [01:36:02] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1267753 (awight) [01:41:04] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267754 (awight) [01:41:32] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267170 (awight) [01:41:57] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267170 (awight) [02:07:37] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267779 (awight) [02:10:35] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267791 (awight) [02:13:38] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267793 (awight) [02:15:59] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267794 (awight) [02:21:08] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267800 (awight) [02:23:13] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Error while running make-thank-you - https://phabricator.wikimedia.org/T98431#1267801 (awight) NEW [02:26:26] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267810 (awight) [07:03:20] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1267994 (awight) [07:08:36] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1268000 (awight) [07:39:17] Fundraising Sprint James Brown, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review, Technical-Debt: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1268042 (awight) Deployment hint: Save the result of https://payme... [07:56:24] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#1268061 (awight) NEW [08:06:11] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1268072 (awight) [08:26:14] (CR) Raimond Spekking: "Are these special pages visible to the user? Does it make sense to translate them?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209369 (owner: Awight) [08:28:19] (PS1) Awight: Downgrade log message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209435 [08:28:22] (CR) jenkins-bot: [V: -1] Downgrade log message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209435 (owner: Awight) [08:28:37] (PS2) Awight: Downgrade log message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209435 [08:33:08] (PS1) Awight: List all special pages potentially needing alias names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209437 [08:33:30] (CR) jenkins-bot: [V: -1] List all special pages potentially needing alias names [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209437 (owner: Awight) [08:40:44] (CR) Awight: "Good question, please let us know what you think:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209369 (owner: Awight) [08:44:18] (PS9) Awight: WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) [08:44:30] (CR) Awight: "PS 9: manual rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [08:44:42] (CR) jenkins-bot: [V: -1] WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [08:46:13] (PS10) Awight: WIP Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) [09:20:57] (PS11) Awight: Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) [09:21:52] (CR) Awight: "Smoke tests cleanly." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [09:22:51] (PS12) Awight: Use DonationQueue for limbo queuing [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) [09:38:02] Fundraising Sprint James Brown, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Tweak mw-vagrant for payments, until it's usable - https://phabricator.wikimedia.org/T98410#1268235 (awight) [09:38:53] (CR) Awight: "Grumble. Unable to smoke test the orphan slayer yet, but the basic limbo add and delete functions work." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [12:11:12] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog: Translate wiki translations to be deployed -sk, lv, ro - https://phabricator.wikimedia.org/T97556#1268455 (atgo) Resolved>Open [13:51:15] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#1268777 (atgo) @meganhernandez_WMF thinks this may have been done intentionally. Do we have any notes about when this was changed? [13:53:27] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#1268788 (atgo) p:High>Normal [13:54:51] Fundraising-Backlog: Support the fundraising annual report - https://phabricator.wikimedia.org/T98472#1268793 (atgo) NEW [16:53:20] Fundraising Tech Backlog, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface: Overriding DonationInterface config in mw-vagrant is difficult - https://phabricator.wikimedia.org/T98103#1269500 (bd808) Discussed on (CR) Ejegg: "Looks good! Nice gradual, safe start - mirroring limbo queues for one gateway. Just one question about $this->handled_ids. Also, unrela" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [18:40:24] (CR) Ejegg: "Another unrelated comment: setting the default queue to memcached ends up throwing some "Call to undefined method PHPQueue\Backend\Memcach" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [19:14:49] (CR) Ejegg: [C: 2] Downgrade log message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209435 (owner: Awight) [19:15:23] (Merged) jenkins-bot: Downgrade log message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209435 (owner: Awight) [19:17:52] (CR) Ejegg: "Some of these exist in x_gateway/x_gateway.alias.php . Delete those files and consolidate here?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209437 (owner: Awight) [19:20:14] (CR) Ejegg: Use DonationQueue for limbo queuing (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206312 (https://phabricator.wikimedia.org/T92922) (owner: Awight) [19:38:50] Fundraising Tech Backlog, MediaWiki-Vagrant, MediaWiki-extensions-DonationInterface, Patch-For-Review: Overriding DonationInterface config in mw-vagrant is difficult - https://phabricator.wikimedia.org/T98103#1270044 (awight) Open>Resolved a:awight [19:52:55] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Assisted currency conversion for PayPal is broken again - https://phabricator.wikimedia.org/T98447#1270199 (awight) That's what I was thinking as well, but I've gone through the code version history, and the last change I found was Mar 201... [19:53:18] awight:: do you remember which channel it was we chatted on about kafaktee with ottomata a few days ago? I'm trying to find the backscroll so I can send a coherent message e-mail [19:54:52] AndyRussG: Sounds like a wikimedia-analytics issue? [19:55:15] Yeah... I think I looked there, lemme try again... [19:55:34] He might have strolled in here. I'll grep, too... [19:56:04] Mmm pretty sure it wasn't here... thx! [19:56:28] AndyRussG: wikimedia-operations, May 1 [19:57:09] awight: funtastic, thanks much! [19:57:21] http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-operations/?C=M;O=D in case you're missing the logs [19:57:31] ooh very convenient [19:59:08] (PS4) Ejegg: Fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) [19:59:10] (PS6) Ejegg: getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) [19:59:12] (PS8) Ejegg: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) [19:59:14] (PS6) Ejegg: Start refactoring processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) [19:59:16] (PS1) Ejegg: Remove validation action from transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209612 (https://phabricator.wikimedia.org/T98063) [19:59:42] (CR) jenkins-bot: [V: -1] getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [19:59:50] (CR) jenkins-bot: [V: -1] Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [20:00:07] (CR) Ejegg: "Rebased on top of removing validation_action from results" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [20:00:47] d'oh [20:29:30] (PS2) Ejegg: Remove validation action from transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209612 (https://phabricator.wikimedia.org/T98063) [20:29:32] (PS9) Ejegg: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) [20:34:39] MBeat: meganhernandez: Is there a good time this afternoon to attempt a very risky payments deployment? [20:35:01] volume is low now, so it's fine with me [20:35:15] (PS10) Ejegg: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) [20:35:17] Great, I'll give notice when I'm prepared to deploy. [20:35:48] (PS11) Ejegg: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) [20:37:19] hi awight, i’m not putting up anything big this afternoon, but there are some emails going out in the europe morning tomorrow [20:39:05] meganhernandez: ok, I think that will be safe. If I do the deployment soon, we'll have plenty of time to roll back in case of problems. [20:42:33] ok, thanks for the heads up awight [20:42:41] anything particularly exciting going out? [20:46:07] meganhernandez: Nothing with end-user effects, we hope. It includes major changes to configuration however, which are intended to reduce the hazing involved in getting new developers up to speed. [20:49:39] (PS7) Ejegg: getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) [20:49:41] (PS12) Ejegg: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) [20:50:21] (CR) jenkins-bot: [V: -1] getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [20:51:31] thanks awight & have fun [20:51:33] haaaze [20:52:03] :) Our capacity to haze is stretched to the max, so we decided to let people just do work [20:57:00] (PS8) Ejegg: getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) [20:57:02] (PS1) Awight: Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209627 [20:57:19] (CR) Awight: [C: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209627 (owner: Awight) [20:57:27] (CR) jenkins-bot: [V: -1] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209627 (owner: Awight) [20:57:29] (CR) Awight: [V: 2] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209627 (owner: Awight) [20:57:41] (CR) jenkins-bot: [V: -1] Merge master into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209627 (owner: Awight) [20:58:00] fight, fight! [21:06:34] (PS7) Ejegg: Start refactoring processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) [21:13:28] (PS1) Awight: Update DonationInterface, includes major config changes [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/209631 (https://phabricator.wikimedia.org/T94477) [21:13:36] ejegg: some pixie dust, if you would? ^^ [21:13:44] soitenly [21:14:27] ejegg: ah, one more fix [21:15:12] (PS1) Awight: update composer.lock [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209632 [21:15:14] (CR) Ejegg: [C: 2 V: 2] "Intrepid!" [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/209631 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [21:15:51] sorry, itchy trigger finger [21:16:05] hehe [21:17:09] (CR) Ejegg: [C: 2] "only the latest kung-fu stylez" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209632 (owner: Awight) [21:17:56] (PS1) Awight: Update php-queue [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/209633 [21:18:14] (PS1) Awight: update composer.lock [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209634 [21:18:16] (PS1) Awight: update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209635 [21:18:35] (CR) jenkins-bot: [V: -1] update composer.lock [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209634 (owner: Awight) [21:18:37] (CR) jenkins-bot: [V: -1] update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209635 (owner: Awight) [21:19:12] (PS1) Awight: update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/209636 [21:21:01] (CR) Ejegg: [C: 2 V: 2] Update php-queue [extensions/DonationInterface/vendor] - https://gerrit.wikimedia.org/r/209633 (owner: Awight) [21:21:08] (Merged) jenkins-bot: update composer.lock [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209632 (owner: Awight) [21:21:46] (CR) Awight: [C: 2] update DonationInterface submodule [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/209636 (owner: Awight) [21:21:47] Thanks! [21:22:13] thank you for juggling all the deploy stuff! [21:22:19] MBeat: meganhernandez: K4-713: ejegg: Okay, I'm deploying in a few minutes [21:22:29] Woot. [21:22:30] ejegg: That one did feel a bit silly. We need some serious docs for that. [21:22:41] thx for heads-up, awight [21:24:25] (CR) Awight: [C: 2 V: 2] update vendor submodule [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209635 (owner: Awight) [21:25:00] (CR) Awight: [C: 2 V: 2] update composer.lock [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/209634 (owner: Awight) [21:26:08] ejegg: No deployment gotchas for your stuff, right? [21:26:27] no, not those first ones [21:27:01] I'll just peek at the logs to make sure they don't look too different [21:29:01] !log updated payments from 3ab89e2b14eb449f7ceddf2325493d6235395ecd to f97f8f99268974cfdb0182f178955bd627137842 [21:29:05] MBeat: deployed! [21:29:07] Logged the message, Master [21:29:20] cool! [21:30:36] Looking healthy so far... [21:36:36] (PS5) Ejegg: Fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) [21:36:36] (PS8) Ejegg: Start refactoring processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) [21:38:51] (PS6) Ejegg: Fix comm status and error checking for PaymentStatus [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/206327 (https://phabricator.wikimedia.org/T90504) [21:38:53] (PS3) Ejegg: Add limbo queue message before redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/207843 (https://phabricator.wikimedia.org/T90504) [21:40:25] gee, maybe building this tower would go faster if I didn't insert all the new floors at the bottom... [21:41:17] that's what makes it fun! [21:41:39] It's pretty easy to rebase an entire chain, donno if you've been doing that or not. [21:42:08] yeah, but I've been doing silly things like renaming variables that are used in 95 different places [21:42:13] hah [21:42:19] oy vei [21:44:17] feet are getting antsy and battery's getting low. Think it's time for some more... [21:58:15] How did it go, guys? [21:58:23] Did I miss a show? [22:34:49] K4-713: seems to have been a non-event [22:35:16] Er. In that the deploy didn't happen, or did we mysteriously fail to cause any side effects again? [22:35:48] Deployed successfully, and no smoke yet [22:36:10] :( we'll all be out of work at this rate. [22:39:09] Well, gee. [22:39:14] Don't say that in front of the new guy... ;-) [22:40:13] "Out of work"? I think you mean "At an offsite for being cool". [22:42:01] XenoRyet: if you find any bugs, keep them for yourself :p [22:50:45] meganhernandez: fyi, the deployment happened an hour ago, and it seems to have been without incident! [22:51:06] great, thanks awight [22:59:44] (PS3) Awight: Remove validation action from transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209612 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [22:59:57] (CR) Awight: [C: 2] "Nicely pruned!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209612 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:01:16] (Merged) jenkins-bot: Remove validation action from transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209612 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:02:18] Thanks awight! [23:04:40] I think I already commented somewhere... but it's looking like base class response processing should be moved into a helper class, some day... [23:07:31] (PS13) Awight: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:07:39] (CR) Awight: Prepare to prune $transaction_results (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:07:45] (CR) Awight: [C: 2] Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:07:56] (PS9) Awight: getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:08:10] (Merged) jenkins-bot: Prepare to prune $transaction_results [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208276 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:10:46] (CR) Awight: [C: 2] "Great, and so much more sane!" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:10:58] (PS9) Awight: Start refactoring processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:11:25] (Merged) jenkins-bot: getResponseXX -> parseResponseXX [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208295 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:13:53] ejegg: What catches ResponseProcessingExceptions? [23:14:19] Oh hehe. The code I added to GatewayPage... [23:15:06] also in do_transaction_internal [23:15:16] in case we need to retry [23:15:18] yes, just got to there! [23:16:54] Since a ResponseProcessingException doesn't necessarily set getTransactionErrors, what happens for the errors where $retryVars is empty? [23:17:33] hmm,maybe i should add the caught error [23:17:59] Yeah, I don't see how that would signal failure to do_transaction_internal cos I don't see errCode get checked. [23:18:56] ooh, it doesn't,huh? [23:19:13] I have no idea how this ever worked. [23:19:34] vi'ing around now... [23:19:36] ok, i should add some more tests that go all the way to checking the PaymentResult [23:20:16] Are there any tests that retry the do_transaction_internal loop? [23:22:07] definitely some that make sure we /don't/ retry on force_cancel [23:22:38] not sure if I test the opposite case... [23:23:39] This would be an existing bug, AFAICT, so I'm ready to merge this commit... [23:23:56] Maybe just a TODO or a Phabricator spike to investigate... [23:24:43] ok, if it doesn't make you too queasy [23:25:00] nah [23:25:31] i have definitely been lazy with additional testing for this bunch of changes... [23:25:43] me too... I pretty much relied on just deploying [23:25:58] hehe... the ultimate test [23:35:50] (CR) Awight: [C: 2] Start refactoring processResponse (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:35:56] (PS6) Awight: Fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:40:11] (CR) Awight: [C: -1] "Very minor search and replace thing, there is an extra space after $response, everywhere." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:41:14] (Merged) jenkins-bot: Start refactoring processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/208739 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:44:00] whoops, let me get that space out of there [23:47:46] (CR) Awight: Fold parseResponseXX calls into processResponse (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:47:52] (PS7) Ejegg: Fold parseResponseXX calls into processResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) [23:59:10] (CR) Ejegg: Fold parseResponseXX calls into processResponse (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209154 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg)