[00:00:03] fraggle fragging [00:00:11] m.i.c... k.e.y... [00:00:12] (PS2) Ejegg: Validate contribution amount as decimal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210249 [00:01:04] Why? Because GIVE ME ALL YOUR DATAZ. [00:01:10] (CR) Awight: [C: 2] Validate contribution amount as decimal (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210249 (owner: Ejegg) [00:01:12] (Merged) jenkins-bot: Validate contribution amount as decimal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210249 (owner: Ejegg) [00:01:54] Aside from the medical data, that conference was pretty creepy. [00:02:08] ^^ even creepier than that statement. [00:02:47] Yep. I enjoyed seeing what "advancement" is really about, and there were some cool ideas. But yeah, it would have been a relief if the UN busted in and arrested half the attendees for data trafficking [00:02:54] Hmm, does the currency code case matter in source? [00:03:14] donno! [00:03:21] yikes [00:03:33] such... basic stuff. We could really use a QA guru [00:03:37] * K4-713 squints [00:03:46] Yeah, we should totally just autofill that field... [00:03:51] yyeah [00:03:53] Are we not ucase'ing everywhere? [00:03:57] :( [00:04:01] Hargh. [00:04:14] We're discovering there was like no normalization whatsoever on the contribution_source field. [00:04:25] Was it all in qc or something? [00:04:26] We were relying on upstairs being amazing at their jobs [00:04:31] I mean, we require them to enter both components one freaking line above [00:04:36] Damn. I didn't know Rosie was a robot. [00:04:41] yep [00:04:43] But, in retrospect: Should have seen that one coming. [00:04:49] somebody missed the jetsons [00:04:50] which does not explain her current condition [00:04:53] ejegg: Right? [00:04:55] ! [00:05:18] smh [00:06:02] * K4-713 cannot say any of the things [00:07:18] o wait, source is sometimes not USD. And that's the only currency in the total amount dropdown [00:07:47] So maybe just autogen if blank [00:08:03] erm, source is converted to USD to get total amount [00:08:16] Not sure I see what u mean [00:08:51] Wait, do we overwrite manually entered total amounts with stuff calculated from source? [00:09:04] Why would we do that [00:09:16] I mean... I wouldn't be surprised. [00:09:23] Not entirely. [00:09:28] I don't think we do any conversion for manually entered things [00:09:41] Yeah... I'd like to think we'd just take their word for it. [00:10:11] Source is just informational at that point--however, our hook parses the contribution_source into wmf_contribution_extra original_currency and original_amount [00:12:07] k [00:12:11] Makes sense. [00:14:07] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1278092 (RLewis) @awight Here's the filepath: smb://filesrv1/Fundraising/Tech/Major Gifts/Wiki Individua... [00:18:17] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Tech Backlog, Fundraising-Backlog, and 3 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1278115 (awight) [00:19:44] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1278127 (awight) a:awight [00:25:22] (PS2) Awight: Rename AZ Lockbox -> Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210247 (https://phabricator.wikimedia.org/T96084) [00:30:38] (PS3) Awight: Rename AZ Lockbox -> Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210247 (https://phabricator.wikimedia.org/T96084) [00:32:42] Will finish the day from home, in a few hours! Au revoir comrades [05:52:47] (PS1) Awight: Test message injection takes URL directly [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/210279 [09:47:10] Fundraising Sprint James Brown, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, Patch-For-Review: Disable CI job on CRM deployment branch - https://phabricator.wikimedia.org/T94586#1278840 (hashar) >>! In T94586#1278028, @awight wrote: > @hashar: Can you advise? https://gerrit.wikime... [09:51:50] (CR) Hashar: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210247 (https://phabricator.wikimedia.org/T96084) (owner: Awight) [09:53:03] Fundraising Sprint James Brown, Wikimedia-Fundraising-CiviCRM, Continuous-Integration-Config, Patch-For-Review: Disable CI job on CRM deployment branch - https://phabricator.wikimedia.org/T94586#1278852 (hashar) Should be good now :} [12:20:13] Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice: Untranslated CentralNotice banners should be flagged or forbidden - https://phabricator.wikimedia.org/T90634#1279132 (Nemo_bis) [17:39:22] (PS2) Ejegg: Create PaymentResult from PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210218 (https://phabricator.wikimedia.org/T98063) [17:39:24] (PS3) Ejegg: Get rid of more setTransactionResult calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209779 (https://phabricator.wikimedia.org/T98063) [17:39:26] (PS4) Ejegg: Replace setTransactionResult calls in Adyen adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209408 (https://phabricator.wikimedia.org/T98063) [17:39:28] (PS2) Ejegg: Finish eradicating setTransactionResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209785 (https://phabricator.wikimedia.org/T98063) [17:39:30] (PS2) Ejegg: Start chipping away at getTransactionAllResults [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209791 (https://phabricator.wikimedia.org/T98063) [18:11:33] ejegg: ...I've just been reading some of the commit messages and code going by... [18:11:58] what do you think of the direction? [18:12:03] Can you summarize for me, why we're getting rid of setTransactionResult? [18:12:48] * K4-713 looks all confused and lost [18:12:49] it was mashing up things relating just to the response with things relating to what we decide to do with the response [18:13:10] hmm. [18:13:12] and being a freeform array, was also accumulating random keys [18:13:18] ( like my force_cancel ) [18:13:48] Hmmmm. [18:14:02] So, you're replacing that mechanism with something more... rigid? [18:14:08] yeah [18:14:15] Perfect. Carry on. :) [18:14:21] thanks! [18:14:43] I do have one concern, but I think I might be making it up. [18:15:35] inspired by awight's comments on warts in the processResponse structure, but I've gone past the point I needed to get to in order to make that nicer. So I can go back to astropay any time and take this to its logical conclusion later [18:15:40] what's the concern? [18:15:47] Fundraising Tech Backlog, Astropay Integration: Write Astropay audit file processor - https://phabricator.wikimedia.org/T90507#1280422 (atgo) Will we have rejections and pending transactions in civi? @ppena thinks we should not. Let's clarify. [18:16:47] ejegg: I'm just going to grab your patch on my local and see if I'm making it up or not first. [18:17:04] But... are there tests that assert that the payments-initial lines are still being created at the end of our workflows? [18:17:11] Those are kind of important. [18:17:19] And, I guess, the fredge messages, too. [18:17:32] if not, I'll gladly add 'em! [18:17:38] That would be swell. :) [18:18:07] those are all inserted via queues, yes? [18:19:37] All this used to get handled by finalizeInternalStatus getting called at appropriate times. [18:19:49] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1280426 (atgo) @ppena is going to run reconciliation. @awight do we have an ETA on this for her to check... [18:19:49] If you didn't change any of that, it should all be fine. [18:20:15] That /should/ still be happening as normal [18:21:04] Cool. It used to be a lot more closely related to setting certain statuses and checking for certain keys in the transaction result, in various places. [18:21:19] Which of course varied by gateway and/or how much coffee I'd had that day. [18:21:39] Brighter lines should help with this, though, so... this is great. [18:24:00] ooh, I guess I'm doing the wrong thing in Astropay then. [18:24:43] orly [18:24:50] K4-713: so before redirecting to the processor, I should finalize the internal status to 'pending'? I'm only finalizing it at all in the result switcher now [18:25:02] Wait... [18:25:11] Does the user come back from that? [18:25:25] yeah, we give astropay a return url [18:25:28] Duh... you just said resultswitcher, so yes. [18:25:31] and they post back some signed params [18:25:51] You know, I don't think we do that with CG CC. [18:25:56] Maybe we do. [18:26:05] looking [18:26:29] I think what we expect there, is that we have poked that donation along as far as we're going to, when we set the final status. [18:26:53] But, I could be making that up, too. [18:26:56] :/ [18:27:12] i think that's still right [18:27:24] that's what the comment says, anyway! [18:27:27] You know what I should have written a couple years ago? [18:27:29] Documentatoin. [18:27:34] Also documentation. [18:28:01] The comments are still really informative (and amusing) - don't beat yrself up too much! [18:28:21] It would seem not insane to set things to "pending" but I think we only do that if we don't expect it to go any farther on the payments cluster. [18:28:42] Right, GC seems to finalize most things in transactionConfirm_CreditCard [18:29:15] or '//if we're of a type that sends donors off never to return, we should record that here.' [18:31:46] hey ejegg K4-713 - am i understanding correctly that those translations should go out today on the train (or have)? [18:32:14] "those" translations? [18:32:36] atgo: Yeah, they should! Let me check special:version [18:32:49] cool, thanks [18:32:59] K4-713: no context for you! [18:33:01] :P [18:33:19] K4-713: https://phabricator.wikimedia.org/T97556 [18:34:19] Oh. [18:34:28] So, the train only applies to things on the regular cluster. [18:34:35] DonationInterface is all us, all manual, all the time. [18:34:44] donatewiki seems to take the choo choo [18:34:52] Unless you're talking about the DI translactions on donate, yes. [18:35:03] Translactions. I'm full of weird today. [18:35:04] i think that was the last of the stragglers [18:35:15] sounds milky [18:35:32] awkward. [18:35:54] the process of turning recipes vegan by substituting soy milk? [18:35:55] * K4-713 drops the mic, goes to lunch [18:36:03] * atgo is ready [18:36:35] haha, neat. Anyway, yeah. Donate wiki is on the cluster and gets to ride the deploy train. :) [18:36:54] I'm... yep. kbye. [18:36:56] atgo: it has the version that the updates got merged to [18:37:03] ok rad [18:37:43] ejegg: FYI - https://wikitech.wikimedia.org/wiki/Fundraising/Translation [18:37:52] thanks! [18:45:59] ^ nice! [18:54:54] (PS1) AndyRussG: bannerController.lib: KV store with localStorage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/210404 (https://phabricator.wikimedia.org/T94763) [18:55:51] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/210404 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [18:59:08] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, Fundraising-Backlog: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1280509 (atgo) a:pizzzacat>None [18:59:33] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, Fundraising-Backlog: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#963771 (atgo) a:XenoRyet [19:04:28] (PS1) Ejegg: Test a GlobalCollect API response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210406 [19:04:55] (CR) jenkins-bot: [V: -1] Test a GlobalCollect API response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210406 (owner: Ejegg) [19:06:49] (Abandoned) AndyRussG: bannerController.lib: KV store with localStorage [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/210404 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [19:08:31] (PS2) Ejegg: Test a GlobalCollect API response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210406 [19:09:25] (PS1) AndyRussG: bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) [19:10:15] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [19:11:00] (CR) AndyRussG: "Test failures are due to ancestor commit dependency on unmerged core change." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [19:28:29] (PS4) Ejegg: Rename AZ Lockbox -> Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210247 (https://phabricator.wikimedia.org/T96084) (owner: Awight) [19:29:15] (CR) Ejegg: [C: 2] "Looks comprehensive" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210247 (https://phabricator.wikimedia.org/T96084) (owner: Awight) [19:30:35] (Merged) jenkins-bot: Rename AZ Lockbox -> Engage [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/210247 (https://phabricator.wikimedia.org/T96084) (owner: Awight) [19:48:00] Fundraising Tech Backlog: Bug: WorldPay audit processing needs more error checking - https://phabricator.wikimedia.org/T98802#1280653 (atgo) [19:59:03] (PS12) AndyRussG: Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [20:55:18] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint K, Fundraising Tech Backlog, Fundraising-Backlog: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1280894 (atgo) [20:56:58] heyo - are we planning any more deployments before end of sprint tomorrow? [20:57:17] ejegg: ..? [20:58:03] atgo: awight was hoping to deploy monday, but wanted to wait till some donor svcs folks were available [20:58:19] the queue stuff? [20:58:20] so if they're around tomorrow, we'll probably deploy [20:58:26] cool, yeah makes sense [20:58:27] yeah, the queue stuff [20:58:32] awesome [20:58:38] what about civi & CN? [20:59:04] Not sure what's outstanding there, but I could do a Civi deploy whenever [20:59:17] cool.. it's just this one: https://phabricator.wikimedia.org/T96084 [20:59:39] Ah right [20:59:52] there's no particular pressure, just wondering since i'vr been getting some questions [21:00:43] that one should be an easy deploy - just renaming some classes. Need to clear a server-side cache after, but that should be all [21:03:25] atgo: I guess it's not impossible we'll deploy CN stuff tomorrow, at least maybe the small patch for compatibility with the core change we need [21:03:38] AndyRussG: thanks! [21:03:43] atgo: yw! [21:04:01] AndyRussG: we have 2 other cards in Pending Deployment [21:04:08] would those not go out with it? [21:05:12] atgo: potentially they could, though I think it'd be a separate deploy [21:05:18] interesting [21:05:18] ok [21:05:28] wouldn't necessarily have to be, depends on what folks from ops tell me [21:09:11] k [21:33:59] hey XenoRyet - want to chat about a first Thing for doing? [21:34:20] Yea, now is a good time. [21:34:24] sweet [21:38:16] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint K, and 2 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1281025 (atgo) [21:40:29] Fundraising-Backlog, Patch-For-Review: Update error messaging on donate form (pre-payment fields) - https://phabricator.wikimedia.org/T96066#1281029 (atgo) @pcoombe should we get this into review/deployment in the next sprint? @xenoryet - FYI... this is the one for the error text changes :) [21:57:22] Fundraising Sprint James Brown, MediaWiki-extensions-CentralNotice: CentralNotice: deploy core change required for campaign mixins - https://phabricator.wikimedia.org/T98924#1281060 (AndyRussG) NEW [21:58:00] Fundraising Sprint James Brown, MediaWiki-extensions-CentralNotice: CentralNotice: deploy core change required for campaign mixins - https://phabricator.wikimedia.org/T98924#1281075 (AndyRussG) a:AndyRussG [22:24:58] Fundraising Dash, Fundraising Sprint K: Create "A/B testing" board in Dash - https://phabricator.wikimedia.org/T98927#1281118 (atgo) p:Triage>Normal