[00:00:10] I'm not convinced we need the multi-node thing for staging... [00:00:19] well [00:00:26] But the permissions and hyper-realism are important. [00:00:35] for what you guys do, probably, yeah [00:00:45] but what if what you're modeling is cross-network behavior [00:01:08] I think that would be more for firewall config and stuff [00:01:09] i.e. you want to test redis HA behavior in various failure modes [00:02:20] so when I first built frack I needed to test pxe/tftp/dhcp/dns etc from unimaged hardware up to running, puppetized systems [00:02:58] this allowed me to get everything built and tested while the datacenter folks were unboxing and assembling hardware [00:03:00] Sounds like, an ops playground has much more jagged metal than a dev playground [00:03:33] yeah, it's a different set of issues [00:03:39] Tetanus. [00:03:42] New release(s) available for Wikimedia Foundation <-- is this the civi upgrade i heard awight mention earlier? [00:03:44] Probably the lowest-level uses I was imagining would be, changing application config and making sure syslog has stuff [00:03:51] cwdent: eek. worse [00:03:58] That's Drupal telling us its pants are down. [00:04:02] awight yup, I do that kind of testing too [00:04:09] ohgod [00:04:18] 'sokay. That's why they're behind that firewall. [00:04:21] good thing it's behind that cert [00:04:21] And... it's coming from a staging box cos our prod box has too much duct tape over its mailhole. [00:04:28] also testing things like "does this puppet tweak actually result in the service over on *that* server getting the proper config, and restarting itself" [00:04:31] It's less breezy in there. [00:05:02] awight it could be useful for testing a db/queue backbone replacement for example [00:05:14] I wish I could make myself love Puppet. Sigh [00:05:17] like a multi-host pipeline situation [00:05:36] Jeff_Green: yes! [00:05:37] ha, yeah, I don't see that ever happening for me [00:05:40] let's do that [00:06:07] I still think every imagineable puppet workflow is universally slower than simply doing everything by hand everywhere over dialup [00:06:11] Jeff_Green: This ridiculous thing just happend: http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDonationInterface.git/d4e274060fd234ef2225207c17899d33a0d08575/gateway_common%2FDonationQueue.php [00:06:22] It means, we can run our queuing on anything. [00:06:30] nice [00:06:35] Totally opens the door to shooting ActiveMQ [00:06:38] when do we get uuids??? [00:06:38] huh [00:06:44] ...haaaargh. [00:06:48] The really big one, though, is to kill the contribution_tracking SPOF [00:06:58] UUIDs man [00:07:02] or pseudo uuids [00:07:06] sequences, whatev [00:07:15] <_< [00:07:16] serverID+timestamp+process_id [00:07:16] >_> [00:07:19] yep [00:07:24] Uhm. [00:07:26] OH HEY. [00:07:32] I think we all have a really important offisite. [00:07:34] Like, now. [00:07:35] So. [00:07:37] That's just a detail of how we get offa contribution_Tracking [00:07:41] ...let's not miss that. [00:07:43] I cannot wait [00:07:53] K4-713: whut? [00:08:15] Jeff_Green: :( [00:08:29] i have an important offsite soon which involves drums amps and earplugs [00:08:35] That works too. [00:08:43] IOU 1 offsite. [00:08:49] (at least) [00:09:29] * K4-713 runs flailing from the building [00:10:16] have fun people [00:10:37] OK sorry we always talk about puppet :p [00:11:51] (PS1) Awight: WIP tests for the orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211065 (https://phabricator.wikimedia.org/T99017) [00:12:13] (CR) jenkins-bot: [V: -1] WIP tests for the orphan rectifier [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211065 (https://phabricator.wikimedia.org/T99017) (owner: Awight) [16:50:50] Fundraising Tech Backlog, Fundraising-Backlog: Make a form without city/state for a test - https://phabricator.wikimedia.org/T86239#1288288 (atgo) p:Normal>Low [16:51:03] Fundraising-Backlog: Improve error messaging for donors experiencing browser errors - https://phabricator.wikimedia.org/T96293#1288289 (atgo) p:Normal>Low [16:51:03] Fundraising Tech Backlog, Fundraising-Backlog, § Fundraising Sprint Abba: Make GC and WP visually match what's on donate wiki (and consequently eachother) - https://phabricator.wikimedia.org/T86086#1288290 (atgo) p:Normal>Low [16:53:49] Fundraising Tech Backlog: Cron should not send email unless there is an error - https://phabricator.wikimedia.org/T99259#1288298 (awight) NEW [17:29:27] (PS4) Ejegg: Make do_transaction return a PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211046 (https://phabricator.wikimedia.org/T98063) [17:30:25] (Abandoned) Ejegg: Create PaymentResult from PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210218 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [17:52:18] Wikimedia-Fundraising-CiviCRM: Currency conversion rate off for JP Morgan Bank Transfer - https://phabricator.wikimedia.org/T90266#1288498 (atgo) [17:52:20] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1191953 (atgo) [17:52:57] Wikimedia-Fundraising, Patch-For-Review: JP Morgan import failing due to currency issues - https://phabricator.wikimedia.org/T86682#1288502 (atgo) [17:52:58] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Make JP Morgan Import a bit more robust - https://phabricator.wikimedia.org/T95487#1191953 (atgo) [17:56:53] Fundraising Sprint L, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create a Civi import function for hand keyed donations in Civi and DAF - https://phabricator.wikimedia.org/T88836#1288512 (awight) [17:57:47] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1288513 (awight) [18:07:03] (PS1) Ejegg: Throw exception on duplicate row headers in import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) [18:11:46] ejegg: regarding this ticket https://phabricator.wikimedia.org/T98927 [18:12:16] i found a *widget* called ABTesting i was able to add to my board by enabling it a few places [18:12:39] but this should be its own *board* a la big english? [18:12:43] cwdent: oh, I guess we took a baby step or two that direction! [18:13:00] Yeah, I think a separate board is the goal [18:13:15] We have a concept of dependent widgets, illustrated in big english [18:13:54] the main chart on big english is the only one that actually makes a data request, and it makes that data available to the board's shared context [18:14:18] gotcha, looks like it implements 3 widgets? [18:14:37] then there are a couple of other widgets ( needed countdown, amount per second ) that pull data from the shared context to build their charts [18:15:02] If they don't find any data in the shared context, they display an error message saying they need a parent widget [18:15:16] I think the a/b test board will be similar [18:15:20] cool [18:15:24] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: [1 day] BUG: CN banner being shown after campaign end - https://phabricator.wikimedia.org/T88276#1288549 (atgo) @andyrussg did this go out already? [18:15:37] with one widget that lets you define a test and makes a data call [18:15:45] i notice in the db there's a big english row for every user. isn't it the same board for everyone? [18:15:50] then a bunch of other widgets that just visualize that data [18:16:16] cwdent: we hadn't worked out all the nitty gritty of permissions for shared boards [18:16:33] so we decided to give each user a copy for starters to avoid confusion [18:16:53] makes sense [18:17:24] think i'm starting to get a general idea of how it fits together [18:17:51] so this a/b widget is probably not worth messing with right now? [18:18:18] let me see how far we got there... [18:18:41] thanks! don't mean to interrupt [18:19:00] no worries [18:20:06] hmm, seems to just be loading some dummy data into a table for now [18:20:43] I think that was the first of the sections of the ipython notebook that we were going to replace [18:21:02] let me forward you an email from ellery linking to his node port of some of that [18:22:05] sent! [18:22:12] great, thank you [18:25:05] atgo: woops, yeah! I forgot to mark that as closed! [18:25:19] doing so now [18:26:54] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: [1 day] BUG: CN banner being shown after campaign end - https://phabricator.wikimedia.org/T88276#1288602 (AndyRussG) Open>Resolved [18:27:18] Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, and 3 others: [1 day] BUG: CN banner being shown after campaign end - https://phabricator.wikimedia.org/T88276#1008052 (AndyRussG) @atgo yep! Sorry for the delay :) [18:27:34] thanks! [18:28:35] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 2 others: CentralNotice: allocate campaigns then banners and fix allocation bug - https://phabricator.wikimedia.org/T96194#1288610 (AndyRussG) Open>Resolved [18:28:38] Fundraising Sprint Flaming Lips, Fundraising Sprint Grandmaster Flash, Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, and 5 others: Implement campaign associated mixins per findings from T90913 - https://phabricator.wikimedia.org/T90915#1288611 (AndyRussG) [18:31:22] Fundraising Sprint Kraftwerk, Analytics-Cluster, operations: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1288620 (AndyRussG) [18:32:00] ccogdill: i announcned your macadamia's in the snacks channel :) [18:32:49] ohh thanks! [18:32:58] I’m not in that one… the temptation would be too great [18:38:21] Fundraising Sprint Kraftwerk, Analytics-Cluster, operations: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1288632 (AndyRussG) a:AndyRussG [18:38:47] cwdent: 'lectronics thing to show you at some point [18:39:02] awight: I made a patch for the dupe headers: https://gerrit.wikimedia.org/r/211144/ [18:39:10] but I'm having trouble running phpunit locally [18:39:25] eek [18:39:27] not autoloading base test classes, apparently [18:39:46] have you had to tweak things at all to make that work? [18:40:06] Did you get the *stupid* vendor/autoload thing? [18:40:47] hmm, I thought bootstrapping drupal would do that. [18:41:15] But I think our test base files aren't in the composer autoloader anyway [18:41:37] it's specifically complaining about CiviMailTestBase, which isn't in the classmap [18:41:46] lemme see... [18:42:17] ejegg: did you "drush cc" ? [18:42:42] You're on master and not deployment? [18:42:48] you have files[] = tests/phpunit/CiviMailTestBase.php [18:42:54] in modules/wmf_communication/wmf_communication.info ? [18:43:40] yes to .info, trying cc now [18:43:56] Are you sure you're "use"ing? wmf_communication\CiviMailTestBase.php [18:44:30] no, but CiviMailBulkTest is in the same namespace [18:44:53] ehh, I know I had this working on the other box. Sorry to pester you, I'll figure it out [18:45:08] drush cc didn't do it [18:46:41] Tests: 67, Assertions: 177, Skipped: 1. [18:54:35] ejegg: well, CI can run phpunit which is nice [18:56:05] There isn't even a reference to that class. Can you paste the error? [18:56:30] also, how are you invoking phpunit? [18:56:33] PHP Fatal error: Class 'wmf_communication\CiviMailTestBase' not found in crm/sites/all/modules/wmf_communication/tests/phpunit/CiviMailBulkTest.php on line 13 [18:56:35] it should be like: "phpunit" [18:56:42] just running phpunit in the base crm dir [18:56:43] aaah [18:56:44] k [18:58:10] This is interesting: sites/all/modules/wmf_communication/tests/phpunit/CiviMailTestBase.php [18:58:37] shouldn't that just exclude it from running as tests? [18:58:55] I think so... [18:59:49] still fails with that commented [19:01:01] but totally working on my other dev box. I'll figure it out! [19:01:14] Hmm, I guess phpunit is relying on the Drupal class registry to autoload that class... [19:01:32] yeah, we bootstrap drupal before running tests [19:02:07] fwiw, select * from registry where name='wmf_communication\\CiviMailTestBase'; [19:02:46] is the wmf_communication module enabled? [19:03:09] (awkward that we autoload the test class from the main module...) [19:03:13] meh [19:03:25] ok I'll get out yr kitchen [19:03:26] hmm, it's got 5 other wmf_communication classes loaded in the registry [19:03:35] but not that one, eh? [19:03:47] perhaps the module is disabled [19:04:06] There should be 32 classes [19:04:26] This is something I'd like to fix about the phpunit tests, they should only run for enabled modules. Or complain. [19:05:06] pm-list shows it enabled... I think it's only the 5 b/c I just cleared the caches [19:05:18] lemme hit a ty test page or two [19:05:28] no, clearing the cache is supposed to rebuild the registry [19:05:31] ejegg: hrm. since that block in persistence.js is only fired on first login, wouldn't we have to delete and recreate the users for everyone to get the AB board? [19:05:34] drush cc all? [19:05:47] cwdent: d'oh! yep [19:06:48] awight: oh, it doesn't add those on demand? [19:06:51] hmm [19:07:11] Wikimedia-Fundraising-CiviCRM: Unit tests are coupled to Drupal modules that might not be enabled - https://phabricator.wikimedia.org/T99269#1288718 (awight) NEW [19:07:12] or i suppose i could put it at the top of the block [19:07:28] but that seems like it will get brittle long term [19:08:07] cwdent: yeah, I think long term we want to delete these bulit in per-user boards and just leave the single personal default insert [19:08:54] We also need to decide how to version the schema. I'd been trying to write persistence.sql in an idempotent fashion, but we've really only had one deploy so far since adding the dash_ tables [19:10:18] mysql has that "on duplicate key" function that could be used [19:10:39] but would require a composite key [19:10:57] probably overengineering [19:13:24] or could do a convoluted thing like select into ... from user left join board on owner_id where board.id is null [19:14:08] yep that would work too. did you say there was a rest api for creating boards? [19:14:33] yep! The routes are all listed in server.js [19:14:54] you've got get/post to /board [19:15:03] and get/put to /board/:id [19:15:19] most of the logic for those is in routes/board.js [19:15:39] nice [19:16:29] This module looks nice, https://github.com/db-migrate/node-db-migrate [19:16:52] cwdent: If you know a better way to apply the loginCheck function as middleware to most (but not all) routes, I'd love to get that repeated 2nd argument out of there. [19:17:15] there being server.js lines 82-96 [19:19:19] awight: that looks pretty nice! I like the option to use SQL or their db-independent syntax [19:19:52] ejegg: this is pretty much what i've seen in the past wrt middleware [19:20:03] there's probably a way to attach it to an http ver [19:20:05] verb [19:20:11] ahh, cool [19:20:26] I guess POST/PUT/DELETE should pretty much always be authenticated [19:22:59] (PS1) Awight: Update list of gateways in the reconciliation report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211158 (https://phabricator.wikimedia.org/T96084) [19:23:03] ejegg: quick one? ^ [19:23:21] sure thing [19:28:30] (CR) Ejegg: [C: 2] Update list of gateways in the reconciliation report [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211158 (https://phabricator.wikimedia.org/T96084) (owner: Awight) [19:30:11] (PS1) Awight: update modules [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/211161 [19:30:56] (CR) jenkins-bot: [V: -1] update modules [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/211161 (owner: Awight) [19:31:11] (PS1) Awight: Update Composer modules [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/211163 [19:31:54] (PS2) Awight: update modules [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/211161 [19:32:35] (CR) jenkins-bot: [V: -1] update modules [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/211161 (owner: Awight) [19:33:14] (PS3) Awight: update modules [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/211161 [19:34:44] (PS2) Awight: Update Composer modules [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/211163 [19:35:57] (PS1) Awight: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/211179 [19:36:13] (CR) Awight: [C: 2] Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/211179 (owner: Awight) [19:36:16] (Merged) jenkins-bot: Merge master into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/211179 (owner: Awight) [19:37:30] !log update crm from 2a2336655737a2cd1d3cc24624d1e8475e4cf039 to 03eb4cff1b009e8abaceec250f9a1c5d1f3c6b18 [19:37:35] Logged the message, Master [19:55:18] (CR) Awight: [C: -1] "With tests! Awesome. Blocking on the case-sensitivity issue cos it's something we saw in the wild." (10 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) (owner: Ejegg) [20:04:04] (PS14) AndyRussG: Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) [21:14:30] (CR) AndyRussG: "Ooops, please ignore this PS (13), I forgot to send a clean rebase first..." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [21:23:34] arg! it's oops Friday [21:24:29] Fundraising Dash, Fundraising Sprint Kraftwerk: Create "A/B testing" board in Dash - https://phabricator.wikimedia.org/T98927#1289137 (cwdent) here is a patch for review https://gerrit.wikimedia.org/r/#/c/211292/ [21:27:26] Hmmm gerrit-wm is on the fritz [21:29:30] Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289146 (RLewis) NEW a:atgo [21:29:52] Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289154 (atgo) [21:30:39] Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289156 (atgo) p:Triage>Unbreak! @rlewis I'm setting this to highest priority and adding to the sprint right now as I think this is proba... [21:31:01] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289158 (atgo) [21:31:10] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289159 (atgo) a:atgo>None [21:31:18] awight: ejegg this seems super important ^ [21:31:40] ooh, that does seem bad! [21:31:43] Checking it out [21:32:49] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289160 (RLewis) @atgo thanks, that sounds like a good idea. It might be specific to this contact record but w... [21:35:02] thanks ejegg! [21:36:59] let's try to get a sense of the scale, too... like if it's really just this one, less scary than if it's doing that as a habit [21:43:51] ejegg: aah, the Source field validation is really annoying [21:44:15] oh dang, did that cause the duplicate? [21:44:19] nah [21:44:41] pretty sure the validation will do what we expect, and prevent form submit [21:45:10] * AndyRussG misses pings from grrrit-wm :( [21:49:16] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289220 (awight) I tried entering a contribution by hand and it created a single record. Looking at the activ... [21:52:04] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289239 (RLewis) @awight I added the mail appeal in after I'd saved the contribution, but it shouldn't have cr... [21:55:01] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289240 (Ejegg) The web server logs show two POSTs with action=add one second apart at the time of that record... [21:57:06] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289253 (awight) Confirmed that the delete doesn't work, though. Here are some notice-level loglines: https:... [22:00:24] awight: aah, validating on delete too? Let me fix that [22:13:06] awight: https://gerrit.wikimedia.org/r/211299 should make it possible to delete contributions again [22:22:30] http://i.imgur.com/B2aAk88.png [22:22:40] firefox complains about gmail now [22:22:47] ssl arms race escalates [22:23:21] lol, "Yes, 20,108 times" [22:23:52] ejegg: awight: cwdent: atgo: XenoRyet: K4-713: If it happened that I had to move Monday's CN intro to a different day, say maybe Tuesday, would that potentially be OK? It looks like I may have to take my oldest kid to a birthday party that afternoon (it's a holday here that day)... She's had a lot of trouble integrating at school here, so it'd be really good to be able to bring her... [22:23:59] hehe. new computer [22:24:09] don't worry about me! my scheudle is dumb. [22:24:12] AndyRussG: I'm okay with that, yes. :) [22:24:16] cwdent: strange, I have the same encryption spec, but w/o TLS1.2 [22:24:28] AndyRussG: sure thing! [22:24:37] AndyRussG: no problem at all [22:24:56] AndyRussG: yea, no problems here. [22:25:34] interesting awight, maybe they're in the middle of some cert changes [22:25:52] atgo: K4-713: ejegg: cwdent: XenoRyet: thanks so much, really appreciate it, sorry about the changes...! :) [22:26:19] cwdent: fwiw, 57:53:78:A6:01:EF:98:DF:6A:56:35:4F:94:9E:C9:77:FA:8D:E0:1B [22:26:21] I might as well move it right away, I guess, even tho the thing Monday isn't 100% confirmed [22:26:34] yeah "Begins On 5/6/2015" [22:27:03] cwdent: I think I read something about some cert authority in China being controversial but still used by Google? [22:27:16] huh same fingerprint [22:27:23] freakshow [22:27:35] the whole thing stinks [22:27:46] I'm using FF 34.0.5 [22:27:55] cwdent: if you're paranoid you can always jail your Gmail webmail/hangouts in a VM [22:28:00] :p [22:28:06] * AndyRussG shows off tin foil hat [22:28:21] subdermal foil... [22:28:23] hehe [22:28:36] awight: I'll just deploy that lil fix [22:28:45] i think the bitcoin block chain approach is how ssl certs should be handled [22:28:50] mine your cert [22:28:55] no central authority [22:28:55] heh it's not natural baldness, really!! nothing to do with the stress of parenting [22:29:33] i've probably gone on that rant here already [22:29:42] * cwdent gets back to work [22:30:02] * AndyRussG is happy to hear rants.. [22:30:10] :) [22:30:19] Things are looking up for IRC edutainment [22:30:20] also if anyone has any distributed social networks to suggest... [22:30:42] diaspora? (/me dodges suicide) [22:30:55] https://okturtles.com/ [22:32:23] iiintesresting [22:34:27] * AndyRussG watches video [22:35:00] this is beautiful too https://www.eff.org/files/colour_map_of_cas.pdf [22:35:06] !log updated crm from 03eb4cff1b009e8abaceec250f9a1c5d1f3c6b18 to 7ffe0cefb019828a09c9369187f14518847b5f41 [22:35:14] Logged the message, Master [22:37:06] ejegg: Thanks! [22:37:52] web of distrust... [22:38:01] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289485 (Ejegg) Rosie, want to try to delete the duplicate again? The new 'Source' field validation was break... [22:38:09] cwdent: what is it? [22:38:35] it's a map of all the trusted CAs [22:38:42] and who granted them trusted status [22:39:00] you want green lock?? 5 dollar!! [22:39:18] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289491 (RLewis) @ejegg awesome it worked, thank you. [22:41:34] annual review day is a terrible day to forget headphones. [22:42:06] Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM: Civi has created two contributions by accident and won't delete the additional contribution - https://phabricator.wikimedia.org/T99288#1289501 (atgo) Open>Resolved a:atgo Yay! Thanks guys for the quick fix [22:44:01] hmmm [22:46:17] Wikimedia-Fundraising-CiviCRM: Civi import whitescreens - https://phabricator.wikimedia.org/T99300#1289521 (awight) NEW [22:46:47] awight: so, drush cc all doesn't necessarily rebuild the whole registry table - only changed files. In case you're ever in that boat, I had to disable modules / cc all / enable / cc all to finally get all the classes loading again. [22:47:12] that's terrible news [22:47:17] thanks for the workaround, though! [22:47:40] ooh, no catcher at the plate, huh? [22:47:45] I donno [22:48:12] ejegg: meh, it catches real nice on my dev box [22:48:22] aargh [22:49:47] https://github.com/okTurtles/dnschain#other-resources [23:00:23] (PS16) Awight: Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [23:00:57] (CR) Awight: [C: 2] "Great! Just noting here that the schema change will need to be deployed before merging this branch..." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [23:01:58] (Merged) jenkins-bot: Campaign-associated mixins: schema update [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202309 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [23:02:03] awight: thanks! [23:03:54] awight: did u rebase using... gerrit rebase button? [23:04:06] AndyRussG: yep! [23:04:13] hope I didn't break things [23:04:14] hmmmmm [23:04:19] only the past [23:04:26] the future is still sunny tho :) [23:04:27] harr [23:04:52] really my fault, I think I needed to update the commit that the feature branch starts on [23:04:58] in the wordl according to Gerrit [23:05:36] Good point, the rebase button is both terrifying and convenient [23:07:23] might also have been because I just added the default branch of campaign_mixins there in .gitreview [23:08:17] I guess correct practice would be to re-merge master back into the feature branch, no? [23:08:33] awight: ^ ? [23:09:14] AndyRussG: what was the outcome you were hoping for? [23:09:16] pull --rebase is nice for clean looking history [23:09:20] what does the rebase button do? [23:09:49] cwdent: Gerrit's rebase button just does git rebase --onto origin/master REF^ REF [23:10:44] awight: hmm nice that u know those details...! I think in this case it was origin/campaign_mixins REF^ REF (cwdent: that's the feature branch) [23:11:05] hmm never tried pull --rebase [23:11:38] wat! [23:11:40] yeesh [23:11:55] i always found it worked well for longish term feature branches [23:12:24] cwdent: hmm! The fun thing is here we almost never use those [23:12:35] This is kinda the exception... [23:12:39] i get terrified of anything more than the most simple rebases [23:12:45] That's insane, what does this even mean... [23:12:48] i have blown my foot off more than once [23:12:59] * AndyRussG understands [23:13:02] which thing awight ? [23:13:17] Yeah I always use -i just in case... and even then sometimes it blows up [23:13:45] awight: cwdent: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/CentralNotice,branches [23:13:49] That patch I merged... Ended up back in May [23:13:55] March, I mean [23:14:09] eff. [23:14:13] Yeah see that's what I'm talking 'bout :) [23:14:16] ohgod [23:14:18] sounds familiar [23:14:33] (PS1) Awight: Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/211310 (https://phabricator.wikimedia.org/T90915) [23:14:45] AndyRussG: mind if I merge to master? ^^ [23:15:08] awight: why? [23:15:35] good point. You want a feature branch, but one based on today. I'm finally catching up. [23:15:35] It's my fault, I told Gerrit about the feature branch a long time ago, and you have to tell it about a branch's "initial commit" [23:15:50] Maybe I was sucked into the time warp along with that commit [23:16:04] awight: I also want to preserve all the talk history in that commit on Gerrit [23:16:34] awight: so, I'm like, let's instead add a patch to the feature branch that merges in the current state of master, no? [23:16:54] https://www.youtube.com/watch?v=YE8PTMSFMUg [23:17:54] cwdent: bwahahaha [23:19:14] awight: how the heck are any of the exception tests passing? Exception->code is an int, and we're feeding it strings in WMFException [23:20:18] they're failing for me [23:20:21] probably unrelated but iirc function sig type mismatch is a "catchable fatal error" in php [23:20:23] (Abandoned) Awight: Campaign-associated mixins: schema update [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/211310 (https://phabricator.wikimedia.org/T90915) (owner: Awight) [23:20:23] whatever that means [23:21:11] awkward town [23:21:34] (PS1) AndyRussG: Merge branch 'master' into campaign_mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/211314 [23:21:38] i'mma make 'em consts [23:22:00] str consts? sounds great! [23:22:54] Hmm, easier just to make a new field maybe [23:25:30] AndyRussG: looks like the right way forward! [23:25:59] awight: K sounds good :) yeah we may well have to do this again before merging the other way 'round [23:26:20] for example, to bring in compatibility with the change in the RL method sig [23:28:09] how did life even exist when all we had was svn... or... *gasp* cvs ? [23:29:02] patch -p0... [23:29:14] I honestly prefer patchfiles sometimes [23:29:28] our kids won't know if git was invented before or after computers had screens [23:30:03] luddite! [23:30:12] 36% done with reviews. huzzah. [23:30:25] atgo: :) [23:30:40] AndyRussG: your kids know computers once didn't have screens? [23:31:02] I think I might have told 'em, yeah 8p [23:32:02] for now that's all condensed into a time when everyone rode horses [23:32:35] actually no, Sofía these days has a much more detailed timeline knowledge [23:36:01] atgo: that's not a number [23:36:11] you're not a number. [23:36:17] BOOM [23:36:22] it hurts me to laugh. [23:36:41] I guess I'm getting .7 of a review from u now [23:37:08] * awight delayed-gets the Prisoner reference [23:38:12] \m/ [23:38:29] awight: the follow-on patch for mixins is still subject to the changes needed for the new schema, do you want me to re-add the "WIP" tag? [23:38:48] prisoner reference...? [23:39:39] i only know it from the iron maiden song [23:40:17] https://en.wikipedia.org/wiki/Number_Six_%28The_Prisoner%29 [23:40:28] atgo: https://www.youtube.com/watch?v=Xcaxlxgnvf0 [23:40:58] * atgo is totally hipper than she thought [23:41:17] i was definitely just being a smartass [23:44:52] see that's from before we had git but when computers already had screens... or that's when I first saw it, at least... [23:46:09] Wikimedia-Fundraising-CiviCRM: Drupal stuff can whitescreen - https://phabricator.wikimedia.org/T99300#1289704 (awight) [23:46:46] https://en.wikipedia.org/wiki/Source_Code_Control_System [23:46:55] retro source control [23:47:07] I used that at my first job... [23:47:15] on Solaris [23:47:40] dang [23:47:41] wow [23:47:42] cred [23:47:49] * awight looks around and suddenly doesn't feel cool [23:48:18] Don't worry, it was integrated with xemacs and stuff. [23:48:26] au contraire [23:48:28] RCS! [23:49:10] friends, I must depart! I'll be back at this some over the weekend, see you when I see you :) enjoy! [23:49:19] see ya! [23:49:24] have a good weekend AndyRussG [23:49:38] I'll try not to butcher the mixins feature branch while you're away [23:49:39] cwdent: likewise [23:49:57] ciao! happy weekend! [23:50:01] awight: I'm sure any cutting u do will be for the better [23:50:58] p.s. feel free to ping anytime for whatever reason, BTW :) [23:51:18] The union will be angry about this... [23:51:40] (PS5) Awight: Replace setTransactionResult calls in Adyen adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209408 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:51:47] (CR) Awight: [C: 2] Replace setTransactionResult calls in Adyen adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209408 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:51:52] (PS4) Awight: Get rid of more setTransactionResult calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209779 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:52:06] 45%. progress. [23:52:10] (Merged) jenkins-bot: Replace setTransactionResult calls in Adyen adapter [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209408 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:57:48] (CR) Awight: [C: 2] "To address the question in the commit log, nah that seems bad. I think we should be able to tighten scoping so there's a single entry poi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209779 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:57:59] (PS3) Awight: Finish eradicating setTransactionResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209785 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [23:58:07] (Merged) jenkins-bot: Get rid of more setTransactionResult calls [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209779 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg)