[00:01:14] (PS1) Ejegg: Use integers for WmfException codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211327 [00:01:30] aww, ints? [00:01:43] and this is how we get ints [00:01:49] hehe [00:02:12] We could introduce a new string field $type [00:02:44] but overriding $code with a string doesn't fly with the versions of PHP / PHPUnit I've got [00:03:08] you know there is an expectedExceptionMessage, and even a regex variant? [00:03:26] Didn't know about the regex version! [00:03:45] I mean... the enum is a great improvement, but it seems like a big patch to do it this way [00:04:14] This is the easy way - still passing in the string, and just setting the code with the constant value [00:04:45] OK, it's pretty dumb... [00:04:50] Very cool, but how do you convert back to string? [00:05:24] Minor thing, $message should start with the string and not the code [00:05:31] hey ejegg... given that there are currently 8 points on you in "doing" for astropay, should I take out the others from the sprint backlog and assume we'll get there next time? [00:05:33] Oh yeah, it should [00:06:01] ejegg: Did I point u to AndyRussG's typesafeenum class? It would be awesome for this... [00:06:33] Good call that we're not being typesafe about $code :) [00:07:10] atgo: Just moved the refactor one into review, and it looks like awight is tearing through that now! [00:07:14] woo!! [00:07:17] how exciting! [00:07:27] awight: Yeah, that typesafe thing is cool! [00:08:48] (CR) Awight: "A minor thing to fix wrt the error message string. I think this is a great direction to go in!" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211327 (owner: Ejegg) [00:09:20] ejegg: This refactor should probably have been on a feature branch, btw... [00:10:19] (CR) Awight: [C: 2] Finish eradicating setTransactionResult (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209785 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:10:27] (PS3) Awight: Start chipping away at getTransactionAllResults [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209791 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:10:46] (Merged) jenkins-bot: Finish eradicating setTransactionResult [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209785 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:10:47] awight: oh yeah, want to use the string in a bunch of places [00:12:09] (CR) Awight: [C: 2] "Really looking cleaner!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209791 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:12:14] (PS2) Ejegg: Use integers for WmfException codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211327 [00:12:30] (Merged) jenkins-bot: Start chipping away at getTransactionAllResults [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209791 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:12:51] (CR) Awight: "Nvm about the getter comment, that's a terrible idea." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/209779 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:13:01] aargh, whitespace [00:13:07] (PS5) Awight: Make do_transaction return a PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211046 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:13:53] (PS3) Ejegg: Use integers for WmfException codes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211327 [00:13:56] ejegg: What do you think about making transaction_response a local variable rather than a member? [00:21:25] (PS1) Ejegg: Get rid of getTransactionAllResults [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211330 [00:21:27] (PS1) Ejegg: Set detailed error arrays for Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211331 [00:22:01] awight: that could probably work! [00:22:45] On second thought... we would have to add the response object to a lot of function parameters, eh? [00:22:55] I was thinking about that when looking at the last few things that use the getTransactionXX things [00:23:03] awight: ehh, true [00:23:31] anyway, this is finally making it possible to see the code structure... [00:24:25] ahh, and there are those times when we want to set some stuff in transaction_response as well as throwing an exception [00:24:37] oof [00:25:05] err.. wait, maybe we always overwrite _response when we catch the exception [00:25:41] That would make sense [00:25:54] return $space_junk [00:26:02] hehe [00:26:38] also: Are you gonna make another sweater with all the yarn you're pulling out of this thing? [00:26:54] better - a thneed! [00:27:38] something everyone needs [00:28:15] A while ago, a friend wrote an intl economics class essay using thneeds as the codeword for commodity [00:28:20] ... so much respect [00:28:34] huge ovaries of brass [00:28:42] i love it [00:29:26] Hey y'all... I think I'm coming down with a... coma. [00:29:34] Probably going home now. [00:29:45] wait, I have budget issues [00:29:49] * awight ducks [00:30:03] * K4-713 read that as "inexpensive issues". [00:30:16] :) u know me [00:30:47] Srsly tho, I can't brain anymore today. [00:30:57] drain brain [00:31:04] enjoy yr weekend K4! [00:31:04] Going to go home and stop trying to brain. [00:31:13] Maybe brain later. [00:31:19] *burble* [00:31:34] * K4-713 salutes [00:33:00] (CR) Awight: [C: 2] "Some superficial things to clean up if you wish..." (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211046 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:33:16] (CR) Awight: [C: 2] Get rid of getTransactionAllResults [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211330 (owner: Ejegg) [00:33:22] (Merged) jenkins-bot: Make do_transaction return a PaymentTransactionResponse [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211046 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [00:33:34] awight: thank you for all the review! [00:33:38] (Merged) jenkins-bot: Get rid of getTransactionAllResults [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211330 (owner: Ejegg) [00:34:04] Of course! and thank you for trimming the freaking brambles into such nice topiary [00:34:21] (CR) Awight: [C: 2] Set detailed error arrays for Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211331 (owner: Ejegg) [00:34:33] Gonna smoke test this a bit, now... [00:34:42] (Merged) jenkins-bot: Set detailed error arrays for Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211331 (owner: Ejegg) [00:35:35] yeah, hopefully I can do a risky++ deploy monday [00:47:31] (PS1) Ejegg: Minor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211338 [00:47:43] (CR) Ejegg: Make do_transaction return a PaymentTransactionResponse (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211046 (https://phabricator.wikimedia.org/T98063) (owner: Ejegg) [01:08:47] (PS1) Ejegg: Fix a few values in Engage import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211344 [01:12:52] (PS3) Ejegg: Throw exception on duplicate row headers in import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) [01:14:24] (CR) Ejegg: "Oops, combined rebase + changes... lemme fix that" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) (owner: Ejegg) [01:15:06] (PS4) Ejegg: Throw exception on duplicate row headers in import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) [01:15:32] (CR) Ejegg: "Rebased on top of int exception codes" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) (owner: Ejegg) [01:17:12] (PS5) Ejegg: Throw exception on duplicate row headers in import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) [01:19:00] (PS6) Ejegg: Throw exception on duplicate row headers in import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211144 (https://phabricator.wikimedia.org/T95487) [01:21:48] see you later, all! [11:31:17] (PS1) Umherirrender: Replace deprecated $wgSpecialPageGroups [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/211387 [19:18:33] (CR) Legoktm: [C: 2] Replace deprecated $wgSpecialPageGroups [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/211387 (owner: Umherirrender) [19:19:23] (Merged) jenkins-bot: Replace deprecated $wgSpecialPageGroups [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/211387 (owner: Umherirrender)