[00:13:36] (PS21) AndyRussG: WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [00:13:38] (PS1) AndyRussG: Pls don't merge - WIP - CNBannerChoiceDataResourceLoaderModule::getDependencies() method signature [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/211657 [00:14:26] (CR) jenkins-bot: [V: -1] WIP Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [01:09:47] (CR) AndyRussG: "Just a rebase. Also re-added the WIP tag since actual changes are coming up in a bit, and since the dependency is a cherry-pick that will " [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [01:41:11] (CR) AndyRussG: [C: -2] "Temporary cherry-picked equivalent to I816bffa3815e2e to provide a dependency for I9f80edcbcacc while we wait for the former to merge into" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/211657 (owner: AndyRussG) [07:47:44] (CR) Siebrand: [C: -1] "i18n/L10n reviewed. 9 messages were added, not all were documented in qqq." [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [14:04:28] morning fr [14:10:31] cwdent: hi! [14:10:42] how was your flight? [14:11:29] easy. got home and slept for about 12 hours [14:12:40] so who all from this channel is in france? i know katie and anne... [14:13:53] i arrive on friday [14:14:18] that's when the hackathon actually starts right? [14:15:15] I'm not entirely sure [14:18:17] in theory, yes [14:34:46] cwdent: cool! Re: France, I'm not going, just here at home in Montreal. I'll be at Wikimania, though... When did you say Katie and Anne are going? [14:35:47] they both said they're going but i'm not sure which day...my friend tyler (works is releng) is already out there [14:47:41] ah cool! [14:48:52] hmm looking at google calendar they both have Lyon noted only as of Friday [14:50:21] nice, well that's good for me cause i know i'm gonna have a million questions this week [14:59:19] cwdent: excellent! :) [14:59:54] * AndyRussG sings: "If I had a million questions, if I had a million questions, if I had a million questions..." [15:00:37] Right now answering a million questions... on these annual review forms ;p [15:01:02] heh. due today? [15:08:07] yup! the form "turns off" at 5pm PDT [15:10:38] fundraising-tech-ops, operations, ops-eqiad: barium has a failed HDD - https://phabricator.wikimedia.org/T93899#1293710 (Cmjohnson) Open>Resolved Fixed...resolving [15:13:31] fundraising-tech-ops, operations: upgrade tellurium.frack.eqiad.wmnet to Trusty - https://phabricator.wikimedia.org/T95294#1293717 (Cmjohnson) Open>Resolved a:Cmjohnson This has been completed. [16:35:57] K4-713: i see you're in my review writing spot :P [16:36:09] I won't be for long! [16:36:19] Also, I'm having to miss the checkin today. [16:36:37] Maybe I should come say things irl. [16:38:18] oh nooooes [16:47:52] * AndyRussG waves at K4-713 and atgo [16:48:01] oh heyy [16:48:10] Happy Monday, y'all! [16:48:13] hi :) [16:48:14] woo [16:48:19] ahoy [16:48:23] happy review deadline Monday! [16:48:29] gah [16:51:28] I may have spent a huge chunk of Saturday doing that. [16:53:09] K4-713: more organized than me... [17:20:23] i'm working on mocking up test data for the dash, imported the civi schema (no data) locally. lots of tables! [17:20:54] Sounds like fun [17:21:15] * awight shudders [17:21:34] getting a full data set for the queries will be interesting, lots of foreign keys [17:21:58] My least favorite recent discovery is that, randomly deleting contact and contribution rows can leave Civi in a state where it won't run at all :) [17:22:26] yeah foreign keys are a mixed bag for sure. does mysql support drop/cascade? [17:22:33] Holler if I can help track down any referenced tables [17:22:52] Yeah it does, but it looks like Civi doesn't quite implement them correctly. [17:23:09] Luckily, I think you can ignore more of this for Dash work [17:23:24] i'm fixin to dump data from the non sensitive tables like donor roles and contribution types [17:23:33] and then mock up data for anything related to actual donations [17:23:33] sure [17:23:49] seem like a good plan? [17:24:42] oh, here's a possible shortcut. You could generate a CSV of random data, then import it into Civi using the offline2civicrm module... [17:25:02] That takes care of all the auxiliary tables and constraints... [17:27:36] good call. mediawiki-vagrant the best approach for local civi? [17:30:35] cwdent: For now, definitely. [17:31:52] so probably easiest to populate the vagrant civi db with the import util, then dump and import to my local mysql for node dev [17:32:46] I think that would be a win [17:41:43] Connect to Civi using an URL like, http://crm.local.wmftest.net:8080/ [17:42:48] cool yeah, i spent some time with the vagreant vhosts last week [17:42:53] finding them entry points [17:43:59] cause i enabled the fr role, and suddenly localhost was no wiki [17:48:53] aargh, I've documented that really badly [17:49:13] Just added the CRM entry point to https://www.mediawiki.org/w/index.php?title=Fundraising_tech#Installing_the_software_stack [17:49:56] oh perfect, thanks [17:50:09] :( too late, though [17:50:15] if i run across anything i think i can effectively document i'll hit you up about it [17:50:33] eh nah i learn best by breaking stuff [17:50:36] Feel free to TODO, also [17:50:49] ...in a controlled environment [17:50:53] :) [17:51:27] I think XenoRyet said the same thing on Friday. This should be an interesting few weeks ;) [17:52:48] indeed [17:54:22] this spells disaster for my former employer: https://blog.adafruit.com/2015/05/16/big-news-adafruit-is-manufacturing-arduinos-for-arduino-cc-in-new-york-new-york-usa-arduino-teamarduinocc/ [17:54:30] i sure am glad i got out when i did [17:54:44] Sad! [17:55:21] speaking of breaking stuff [17:55:50] awight, have you knocked the DonationInterface around much since reviewing all that stuff last week? [17:56:16] I should probably hammer on it a little more locally before releasing it into the wild [17:58:57] ejegg: Not yet--lemme do that now [17:59:08] thanks! [18:01:25] (Abandoned) Ejegg: WIP add Astropay to DonationInterfaceFormSettings [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/200988 (https://phabricator.wikimedia.org/T90505) (owner: Ejegg) [18:03:39] well if it's cool i'm going to grab a sandwich and head over to the shop (coworking space i'm renting with a couple friends) [18:03:46] it's about a 10 minute walk from home [18:05:08] back shortly! [18:21:47] cwdent|lunch: http://crm.local.wmftest.net:8080/node#overlay=admin/import_checks [18:41:04] thanks awight! [18:42:44] internet's pretty good at the shop [18:43:02] paying for 20/5 and getting about 10/2 -- par for the course [18:43:48] How many of you are usually working there? [18:43:54] I thought you already had the fibernet? [18:44:38] just 2 or 3 of us [18:44:52] no fiber yet, i'll have it probably next month at home but i'm not sure when it'll get here on main st [18:45:12] funny [18:48:57] awight: Oh hey: I need to arrange a pig drop. [18:49:06] !! [18:49:16] awesome, we were just talking about that [18:49:21] Yaaay. [18:49:31] I'm leaving for the hackathon on Thursday, so before that sometime. [18:49:31] You should come over here, so as to play with the baby ducks and my kid [18:49:36] oooo [18:49:59] You have the pick of evenings, nothing's planned for us, so far [18:50:57] ejegg: Nothing has emitted smoke so far... you considering a deployment today? [18:51:59] awight: Maybe wednesday? [18:52:07] There's a campaign running, C15_enlvroskLVROSK_*, getting some traffic now, but it's long-running so probably not a big deal to blip out during [18:52:07] For the pigs. Not the deploy. [18:52:08] :p [18:52:11] K4-713: you got it :) [18:52:14] thanks! [18:52:15] Heh [18:52:17] wooo! [18:52:29] * K4-713 makes funny guinea pig noises [18:52:29] awight: I was thinking tomorrow [18:52:33] for the deploy [18:52:42] * K4-713 giggles [18:52:45] ejegg: pig deployment, avast! [18:52:56] I'm helping! [18:53:01] Do pigs swim?? [18:53:14] Some of them apparently like it. [18:53:20] I have not water-tested mine. [18:53:27] * awight imagines interesting new lawn jockey potentials [18:53:42] "Today, we will test your buoyancy." [18:53:43] gotta run! Pls ping my mobile me or e-mail if there's anything urgent :) cya.... :) [18:53:43] Why have I never wondered this [18:54:23] isn't there a domesticated rodent that dies if it gets wet? [18:54:27] chinchillas? [18:54:39] what, from hypothermia? [18:54:46] Definitely not guinea pigs. I think chinchillas are Hard. [18:55:02] Cute and fluffy for sure. But fiddly and difficult. [18:55:25] i guess they get moldy [18:55:30] so they have to take dirt baths [18:55:32] Eep. [18:55:43] Oh yes. Chinchillas need their special dust. [18:55:51] but i do wonder how an animal that can't get wet gets naturally selected for survival [18:56:09] Maybe they live in a big fluffy desert? [18:56:30] they must [18:57:06] Or, like, the land of pillows. [18:57:19] It would explain a lot. [19:02:52] there is a cute doggy here [19:03:06] the space we're renting is in the back of an antique store [19:03:34] the owner is here sometimes packing stuff up he sold on ebay [19:17:50] Zendesk is reporting a delay in creating tickets (so far about 3 hours) - I'll update with an ETA for a fix when I know more [19:18:51] MBeat: no worries from our side, I don't think anyone's planning to rock the boat today [19:19:52] cool, thank you awight. ZD resolved a couple of other issues today, so hopefully they clear this last one soon [19:27:21] MBeat: I'd like to deploy some potentially risky code changes tomorrow if that's OK. Any preference on time? [19:27:46] not particularly! [19:28:01] just give me heads-up [19:28:18] k, thanks. I'll confirm again before I make a move [19:45:40] Zendesk ETA "a few hours" [20:04:54] Fundraising Dash, Fundraising Sprint Kraftwerk: "Get Test" in A/B testing header - https://phabricator.wikimedia.org/T89990#1294738 (atgo) a:cwdent [20:27:36] Fundraising Dash, Fundraising Sprint Kraftwerk: "Get Test" in A/B testing header - https://phabricator.wikimedia.org/T89990#1294816 (cwdent) this header will be applied to the ABTesting board, right? as opposed to the widget (which exists but is not currently implemented) regarding the quick/fuzzy searc... [20:28:08] * cwdent starting to learn which irc bot is which [20:36:03] Fundraising Dash, Fundraising Sprint Kraftwerk: "Get Test" in A/B testing header - https://phabricator.wikimedia.org/T89990#1294846 (atgo) Good questions. I'm not sure how it should work (as a widget or a part of the board or what), but the idea is that this header will dictate the data displayed across a... [20:36:54] chinchillas are the softest [20:38:39] rebooting in order to starve sysvinit demons... [20:41:53] atgo: the idea of this board is to be a predefined collection of widgets, like the big english board, yeah? [20:42:01] yea [20:42:02] h [20:42:09] i think that's the best first approach, cwdent [20:42:22] since megan's team has pretty well defined what they want to be at this point... we can make it more customizable later [20:42:33] cool. so maybe this header is just a particular widget? [21:02:00] mediawiki appears to be all tabs everywhere, this dash project has some mixed tabs and spaces... anyone have a strong opinion? [21:08:47] only that we don't mix [21:10:20] i'll probably change it all to tabs as i go then [21:10:29] i used to hate tabs, but golang showed me the light [21:10:48] * awight shouts something muffled [21:11:04] Zendesk ticket issue is resolved, btw [21:11:22] Glad to hear it! [21:13:35] on second thought...vast majority spaces in dash. spaces it is. [21:20:18] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Change the AZL Civi import to Engage - https://phabricator.wikimedia.org/T96084#1294928 (awight) Open>Resolved Confirmed that there are no compla... [21:21:42] Oh c'mon... the review forms turn off at 5PM? [21:21:47] That's just punitive... [21:22:53] I think I saw an email earlier saying they were going to leave the form on until tomorrow morning. [21:24:28] cwdent: you may notice a split between backend and frontend on the whitespace in dash. I prefer tabs too. Time for a big whitespace conversion commit? [21:27:23] hehe, that would get me some SLOC stats right quick [21:31:04] Nicer to get it over with in one big bang than to have ws changes interspersed amongst the diffs [21:32:11] yeah, i'm messing with a grep/sed thing now [21:37:37] XenoRyet: woot, thanks! That makes a *lot* more sense, I see the email: [wmfreqs] [DEADLINE] Annual Reviews due today 5:00pm PDT (& extra sprint) [21:38:07] grep --exclude-dir=node_modules --exclude-dir=bower_modules -r -m 1 '^\s' * | wc -l [21:38:09] 103 [21:38:11] not too bad [21:39:28] I think you're just listing every file [21:39:34] only 103 lines starting with a space in the whole project? [21:39:36] "\s" will match space or tab [21:39:37] ignoring binaries it's 67 [21:40:02] hrm... isn't \t tab? [21:40:06] -m 1 is sort of the same thing as -l [21:40:12] \s is any whitespace [21:40:24] oh, never used -m before [21:40:44] grep '^ ' | wc -l I think [21:40:46] eh, yeah you're right [21:41:08] 32 files [21:41:09] much better [21:41:17] whew! [21:41:35] the one that always burns me is egrep vs grep :( Why not the default... [21:41:42] same thing in vi... [21:42:05] but creepier [21:42:08] i was hooked on ack for a long time [21:42:26] you and ejegg should write a freaking time machine in awk, to send us into the post-PHP future [21:42:29] but every time i get hooked on a tool that isn't stock i find myself wasting a bunch of time when i get back on a normal system [21:42:55] Isn't gawk stock everywhere? [21:43:21] not on ubuntu :-\ [21:43:27] O_O [21:43:34] i've got awk [21:43:36] no ack [21:43:38] * awight punches an emoji [21:43:51] oh. I just parsed "ack" [21:43:54] what is this ack? [21:44:27] http://beyondgrep.com/ [21:44:47] * awight scowls at "portable Perl 5" [21:45:25] the other thing about ack though is it tries to be helpful and silently ignore several common filetypes [21:45:29] which can be super not helpful [21:45:53] ahh, i can see how that could bite you [21:46:27] wth, I wanna see some example output here [21:46:58] The sales literature says "exactly the same as grep" :p [21:48:17] it's tuned to be developer friendly or something, tries to ignore help files and other things that can be unreadably matchy [21:48:44] like it only wants to search source code [21:48:58] * awight cautiously wields new perl armor [21:49:58] man i saw larry wall per6ing all over the place at oscon a few years ago [21:50:05] it was hilarious and a little sad [21:50:49] "here we can replace these 10 lines of perl5 with the <-INF> identifier" [21:51:01] "and this whole algorithm with a unicode trombone" [22:21:44] ejegg: fyi i'm doing this space->tab stuff by hand. too much mixed 2/4/8 space tabs to really automate. but VG= takes care of most of it. [22:22:11] VG= ? [22:22:52] in vim...auto format [22:23:04] ahh, nice! [22:23:30] * ejegg needs to make another run at weaning himself off IDEs [22:31:31] tfw autoformat reveals that there's an unclosed div buried somewhere in there http://sadbastard.org/images/out5.gif [22:33:16] the horror! [22:36:36] boom. done reviewing (finally) [22:36:43] if anyone needs anything, i'm above ground again :) [22:37:06] atgo. hah, i'm just pressing submit on the final one now! [22:37:09] feels good [22:38:32] well i just put a closing tag at the end of the file. made no visible difference, though i guess modern browsers will take care of that sort of thing for you. [22:59:16] hey team - is there somewhere we're keeping track of worldpay store IDs? [22:59:35] we got some new ones... wondering where to stash them [22:59:38] atgo_: arrgh. [22:59:45] word, awight [23:00:00] are they confidential? [23:00:09] hey! yeah, sort of confidential enuf [23:00:24] (PS1) Cdentinger: spaces to tabs, fix a couple errant html tags [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/211914 [23:00:41] I suppose collab is appropriately private [23:00:50] ^ just whitespace [23:00:52] fyi, the master list is in a configuration file :( [23:01:46] such a hideous, uncontrolled growth... [23:02:13] That stuff should really be their responsibility to keep track of. [23:10:49] yeah [23:10:56] hm.. ok. i'll throw it on collab for now [23:14:35] Fundraising-Backlog, § Fundraising Sprint Abba: Fix WorldPay in GB - https://phabricator.wikimedia.org/T86098#1295129 (atgo) [23:14:41] Fundraising-Backlog: Make worldpay forms for Japan - https://phabricator.wikimedia.org/T93019#1295130 (atgo) [23:14:48] Fundraising-Backlog, § Fundraising Sprint Abba: Make WorldPay NZD work - https://phabricator.wikimedia.org/T86097#1295131 (atgo) [23:19:17] Wikimedia-Fundraising-CiviCRM: CiviCRM - how to format text in a text box in the prospect tab? - https://phabricator.wikimedia.org/T98262#1295132 (Ejegg) I think we just need to tweak the custom field definition. Civi shows a beta warning when you do it, but on my local install, I was able to change a field... [23:47:52] Wikimedia-Fundraising-CiviCRM: CiviCRM - how to format text in a text box in the prospect tab? - https://phabricator.wikimedia.org/T98262#1295228 (CaitVirtue) Do we need to do that for each field, or is this one overarching setting we're changing? Caitlin Virtue Director of Development Wikimedia Foundatio... [23:52:40] Wikimedia-Fundraising-CiviCRM: CiviCRM - how to format text in a text box in the prospect tab? - https://phabricator.wikimedia.org/T98262#1295430 (RLewis) I think its the setting for field. Is Elliot making the change or does he suggest we do it? Rosie Lewis Development Research Analyst +1 (415) 839-6885 rl... [23:55:06] Wikimedia-Fundraising-CiviCRM: CiviCRM - how to format text in a text box in the prospect tab? - https://phabricator.wikimedia.org/T98262#1295479 (RLewis) @ejegg do we need to make this change? [23:57:38] Wikimedia-Fundraising-CiviCRM: CiviCRM - how to format text in a text box in the prospect tab? - https://phabricator.wikimedia.org/T98262#1295480 (atgo) I've triaged this as "low" priority. If it's something you guys can handle to let fr-tech focus on the higher priority issues, that would be great. If not,... [23:59:01] Wikimedia-Fundraising-CiviCRM: CiviCRM - how to format text in a text box in the prospect tab? - https://phabricator.wikimedia.org/T98262#1295481 (RLewis) @atgo yep we can make the changes and see what happens. It's definitely not something we want fr-tech to spend time on over other stuff :-)