[14:48:25] * AndyRussG waves [14:49:17] mornin [14:50:09] cwdent: hi! :) [14:51:38] how's the weather in montreal? [14:57:53] it's still raining here, and not supposed to stop for another week :( [15:00:50] and the pledge drive is starting on CPR. grim times. [15:20:04] cwdent: it was roasting hot yesterday but today it's windy and chilly, probably gonna rain soon [15:28:40] cwdent: cpr = Colorado Public Radio? Do you listen while you work? [15:29:07] yeah when it's not too distracting [15:32:59] cwdent: interesting... mmm over here most of the time it's music without lyrics for me... Somehow anything with words that I can make out easily kills workflow for me [15:34:11] heh yeah i do a lot of instrumental post rock too, but i find once i get in the zone i pretty much tune everything out [15:36:54] heheh actually I'm mostly instrumental pre rock :) [15:37:08] but if you have suggestions I'd love to hear them! [15:37:27] hehe, like classical or jazz? [15:37:33] yes both of the above [15:37:40] and traditional folk from various parts [15:38:27] I think in our sprint-naming sessions only once or twice has anyone even voted for any groups (or composers) that I've nominated [15:38:53] hehe. i also love jazz and some classical but i'm much less familiar with the latter [15:38:58] which is fine! I'm learning about a lot of stuff [15:40:14] one of my favorite post rock "bands" of all time is from montreal, they are called Godspeed You! Black Emperor [15:40:26] they are more of a chamber orchestra with some electric guitars and drum kit [15:40:28] ah right... yeah I grew up surrounded by both those genres [15:40:30] Hmmm [15:40:33] * AndyRussG checks it out [15:41:24] There's actually a pretty cool music scene here [15:41:30] their record "F♯ A♯ ∞" is a masterpiece [15:41:39] oh yeah i've heard montreal has great music [15:41:41] and food [15:41:59] oh yeah food here is great, a huge amount of diversity [15:42:15] I'm only slightly bummed that we're going to miss the Montreal Jazz festival our first year back here... [15:43:13] (The day before it starts or so we're going to Mexico City to visit friends and family, and will stay there 'till Wikimania is over.) [15:44:37] you were living in mexico previously? [15:44:45] Yeah! for 18 years [15:45:16] wow! where abouts? i spent some time in oaxaca and really loved it [15:45:24] yeah if missing the Jazz Festival is the price I pay for the rest of my family letting me tear them from the land of their birth, even (possibly) quite temporarily, so be it [15:45:57] always lived in Mexico City, though I did get to see a lot of other places at different times [15:46:02] Ah cool! Where in Oaxaca? [15:47:23] My brother-in-law's wife lived in a town in Oaxaca as a kid, though lives in Mexico City now [15:48:40] Pretty amazing the cultural contrasts within Mexico itself! Mariana (my wife)'s family is originally from Guerrero, just the next state down, but there are totally Guerrero-Oaxaca cultural clashes they have to deal with... [15:49:34] we stayed in oaxaca city, where the big teacher strike was [15:49:47] old friend of mine from minneapolis spends every winter there [15:50:13] and yeah it's starkly different from northern mexico where i spent a lot of time as a kid (born in NM) [15:50:14] cwdent: right! yea I'm pretty sure I went through there once years ago. Yeah there have been a lot of really important movements in Oaxaca [15:50:20] even the people look totally different [15:50:29] indeed! [15:50:50] incredible place, saw a lot of ancient ruins [15:51:11] cool! yeah the country has a huge amount of history [15:51:21] and i could stuff myself with the best food and drink for like $10/day [15:52:56] heh yeah food is such a huge part of the culture too [15:53:16] my brother-in-law's wife's dad makes mole himself, from scratch [15:53:27] yum [15:53:32] It's like a one- or two-day operation, zillions of ingredients [15:54:24] * AndyRussG hopes on the next trip they'll give us some to take home :D [15:54:40] I guess you haven't thought about going to Wikimania? Or are you going? [15:55:57] eh i have to go to a wedding right then :-\ [15:56:07] i am best man so i can't skip this one [15:56:25] but i am so burned out on weddings right now [15:56:36] between myself and my girlfriend we must have gotten invited to 20 this year [15:56:56] and not a single one within a thousand miles of here [15:58:02] cwdent: hmmm wow, that is a lot 8p Well, at least you've gotten to travel qutie a bit! [15:59:16] yeah, that part is alright [15:59:48] her whole family is on the east coast so we get back there a lot, which i really enjoy [16:00:03] a couple days in the city is perfect, then i want to come home [16:00:51] ah right... hmm whereabouts in the East? [16:00:59] Yeah the U.S. is such an incredibly diverse place too [16:01:30] also these days, with such connectivity everywhere, the motivations for city dwelling are less [16:01:46] totally [16:02:05] they're all in the PA, NJ, NY area [16:02:23] we go to nyc and long island quite a bit [16:02:29] ah cool [16:02:52] Yeah NYC has quite a unique vibe, or at least it still did last time I passed through :) [16:04:15] yeah i find it so fascinating. dani's twin sister lives in astoria queens which is my favorite place i've been in nyc [16:04:51] right across the river from manhattan but feels comparatively like the country [16:06:18] ah hmm [16:06:24] not sure I've ever been to Queens [16:07:50] Mariana is a total city slicker! When we arrived to this residential-urban neighbourhood here in Montreal, she was shocked at how quiet it was compared to where we lived in Mexico City (and we definitely didn't live in the busiest part of the city, by any strech) [16:08:36] (she had actually visited many times before, but it's different actually living here) [16:08:45] i haven't been to mexico city since i was little, but from what i know it is mind blowingly huge [16:09:42] Its gi-normous. Actually like zillions of smaller cities and towns all squished together [16:10:34] Also kinda not very planned, compared to lots of places... though most parts do have basic services these days [16:10:53] I'm listening to Allelujah! Don't bend! right now, BTW [16:11:32] nice, i've got that one on LP, it's their newest [16:14:33] LP! wow [16:14:37] https://play.spotify.com/album/3ld6n4RnKT8mYYOhAOg2Kf [16:14:52] "Asunder, Sweet, and other Distress" [16:16:05] https://en.wikipedia.org/wiki/Asunder,_Sweet_and_Other_Distress [16:16:44] oh man! how did i miss that [16:16:52] * cwdent queues it up [16:30:33] (CR) Awight: [C: 2] Reset all singletons after each test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212224 (owner: Ejegg) [16:30:45] (PS2) Awight: Run antifraud filters before redirecting to Astropay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212228 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [16:31:00] (Merged) jenkins-bot: Reset all singletons after each test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212224 (owner: Ejegg) [16:38:04] ejegg: np! I just learned about the group from cwdent infact [16:38:29] awight: thanks for still merging it - I should do the same when i have tiny quibbles, and trust the comments won't sink beneath the waves [16:38:35] * AndyRussG likes the sound of "infact" without the space [16:39:24] speaking of which, there are two 'minor cleanup' patches in my list that are responses to your comments [16:39:25] (CR) Awight: "Have you seen @I16da0683c2c ? I'm concerned that the WorldPay layout will take too much work to have match the old forms..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (owner: Ejegg) [16:39:49] awight: ejegg: cwdent: I have now a plan for our change to core, following a bit more talk on #wikimedia-operations (quoting below...) [16:40:11] ejegg: Yeah, I donno how to keep TODOs visible... I guess I should bookmark a "starred" changesets view [16:40:17] 1) make sure enough core devs and implicated extension devs are reviewers/subscribed to the changes and the phabricator task. 2) Set a proposed date for merging everything, ask for any objections and final comments before that date. 3) Talk to release engineering to make sure it all gets on the same train [16:40:18] AndyRussG: oooh [16:40:33] https://phabricator.wikimedia.org/T98924 [16:40:39] AndyRussG: 3 sounds real tough [16:40:55] WMF is not the only deployment... [16:40:59] https://gerrit.wikimedia.org/r/#/c/202925/ [16:41:20] awight: ah hrmmm very good point [16:41:26] So, due to PHP being stupid, it's neither forwards- nor backwards- compatible? [16:41:35] I guess we could to it all in a specific window [16:42:00] awight: WRT extension-vs-core changes? not quite fortunately [16:42:16] Core can safely go first, then? [16:42:43] "For example, if the child class defines an optional argument, where the abstract method's signature does not, there is no conflict in the signature. This also applies to constructors as of PHP 5.4. Before 5.4 constructor signatures could differ." [16:42:43] https://php.net/manual/en/language.oop5.abstract.php [16:42:54] (^ provided by matt_flaschen) [16:43:12] I thought it was throwing warnings... [16:44:09] It's throwing warnings vice-versa on my box, for the signature change, anyway [16:44:39] Maybe I should break apart into different commits the signature change and the actual use of the new param in the call to getDependencies with the new param arrggg [16:44:39] warnings if you go extension-first? [16:44:51] It's a hard problem... [16:45:07] * awight reads the phab task [16:45:14] (not much there I think) [16:45:40] the commit message is more complete right now infact [16:45:45] ah, yeah the core patch [16:47:22] inheritance is eveil [16:47:58] I suppose we'd have the same problem using interfaces in PHP though [16:48:15] (CR) Ejegg: "Thanks for the pointer! The getResources() call definitely fits better in the form class than having to add that in the GatewayPage handl" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (owner: Ejegg) [16:50:51] awight: hmmm... without checking the doc, I would actually expect errors doing core first then extensions... Maybe I'm getting some silunt local errors somehow [16:51:44] awight: for transclusion, what do you think of an 'appeal' setting (overrideable on querystring) with the title as given in RapidHTML templates, then snagging the text in compile() and adding it to the context [16:51:48] ? [16:51:55] seems like the easiest way to start [16:52:37] and just have {{{ appeal-text }}} in the appropriate spot [16:54:29] ejegg: I was leaning towards the other direction, where we pull the appeal stuff out of rapidhtml forms [16:55:11] not sure what that translates to, other than injecting a page wrapper at the GatewayForm level. [16:55:30] Yeah, I was just lazily trying to avoid touching all those files [16:55:52] fine with me, but it increases the pain later I think [16:56:42] k, i'm on board with provisionally adding the appeal in MustacheRenderer [16:57:06] Lemme code something up and see if it gets ugly [17:10:41] ejegg: should a user's default_board always be their "'s board" or is the intent to make it configurable? [17:11:16] I think we should let 'em change it [17:11:34] sounds good! [17:11:36] Just had to give them something to see for starters [17:12:19] I assume at some point we'll have the sharing permissions worked out and they'll come up with a really good shared default dash [17:12:39] for sure [17:15:15] hello from france! [17:15:45] Hi [17:15:58] hi atgo! [17:16:01] hey atgo! how is it so far? [17:16:07] so pretty! [17:16:08] i'm so tired. [17:16:21] i believe it. 8hrs ahead? [17:16:34] are you right on the mediterranean? [17:16:57] atgo: bonsoir! [17:17:06] atgo: As-tu essayé Waze? [17:17:11] no mediterranean [17:17:14] there are rivres [17:17:39] 2 of them, in fact [17:17:52] haven't tried Waze... i'll check right now! [17:18:02] (Just saw your post to wmfall) [17:18:18] Glad to hear it's nice! [17:19:10] wait i think waze only does driing [17:19:12] driving* [17:19:32] awww too bad, oh well... I just remembered it was an alternate map app [17:19:38] good thinking :) [17:20:06] also... i realize that i won't be there for Shrimp Chicken later [17:20:12] because... it's tired o'clock over here. [17:20:15] Anybody got anything for me to bring to scrum of scrums? [17:20:21] and i would be destructive instead of useful :P [17:20:33] AndyRussG: should I poke somebody about your core change? [17:20:33] atgo: no problem at all [17:20:47] ejegg: I've just been doing so thanks! Yeah I think we have a plan [17:21:08] Just looking at whether it should go core first or extensions first [17:21:18] awight|mtg: ejegg: cwdent: WT@#&! You can't make PHP complain if a method gets too many arguments? http://stackoverflow.com/questions/7928707/why-does-php-not-throw-an-error-when-i-pass-too-many-parameters-to-a-function [17:21:22] Fundraising Sprint L, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1299419 (atgo) [17:21:30] ok, I'll just put it in the notes! [17:22:16] not without some manual checking AndyRussG [17:22:23] ejegg: the idea was "1) make sure enough core devs and implicated extension devs are reviewers/subscribed to the changes and the phabricator task. 2) Set a proposed date for merging everything, ask for any objections and final comments before that date. 3) Talk to release engineering to make sure it all gets on the same train" [17:22:41] sound like a good plan [17:23:13] but awight|mtg mentions that getting it all on the train may be hard since some of the extensions may do off-train deploys [17:23:23] so I think we may resort to a special deploy slot for it all [17:23:36] cwdent: ah! how does it work exactly? [17:23:48] ah, special deploy shouldn't be too bad [17:23:54] You mean, not without manual checks in the coe itself? [17:24:02] ejegg: yeah just a few extension + core updates... [17:24:36] yeah AndyRussG. supports variable length unnamed argument lists so you just have to check yourself [17:24:50] * AndyRussG thinks maybe a more experienced deployer is... volunteering ...? ;) [17:25:16] also don't put any faith in the function sig type hints because type mismatch throws a "catchable fatal error" ! [17:25:31] which is an infuriating phrase [17:26:05] cwdent: maybe intentionally so... ;P ? [17:26:40] Yeah I just would want some kinda strict feature where you tell PHP you're not using that and ask it to warn you when you send too many args [17:27:09] * AndyRussG 's Java days fade into ever more distant memory [17:27:20] you could roll your own "function" class :P [17:27:52] well, _that_ might be a breaking core change [17:28:30] i think the similarity between php and javascript is the vanilla language is useless [17:28:46] but js offers you prototypes to write a less useless language inside it [17:29:07] php gives you inheritance which...yeah [17:29:28] they're such different worlds, despite similaritie [17:29:30] s [17:30:00] JS, especially modern-style JS programming, can feel much cleaner [17:30:36] PHP, well yes fine code is possible, but it feels like there's always a bunch of messy corners, rough edges and dirty windows that you've just trained yourself not to see [17:31:25] * AndyRussG looks out dirty window [17:32:39] yeah, great javascript is elegant and beautiful [17:32:48] great php...doesn't break constantly [17:33:58] anyway i probably shouldn't rag on the tech that keeps the wiki up and pays everyone's salaries :P [17:36:20] cwdent: oh no it's quite all right :) you'll find no language zealots here... as far as I know! :) [17:36:36] * AndyRussG checks under desk [17:38:02] I've come across people with strong feelings about python (favorable and disliking) here and there, and one of our most brilliant engineers once suggested I learn functional programming, but I think that's it, as far as I recall [17:47:47] Fundraising Sprint L, Fundraising-Backlog, § Fundraising Sprint Abba, § Fundraising Sprint Beastie Boys, and 3 others: Update GC audit to read WX file - https://phabricator.wikimedia.org/T86090#1299490 (atgo) Wahoo! [17:49:12] Fundraising Sprint L, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, Patch-For-Review: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1299508 (atgo) [17:50:03] Fundraising Dash, Fundraising Sprint L, Fundraising-Backlog: Search and return results for Campaign name - https://phabricator.wikimedia.org/T89980#1299509 (atgo) [17:50:35] AndyRussG: oh sorry, I wasn't talking about off-train deploys--it's certainly possible to deploy all WMF-deploy-branch extensions and core simultaneously. [17:50:53] What I meant was, it's important that the migration plan takes into account 3rd party wikis [17:51:07] awight: ahhh hrm [17:51:13] They shouldn't be in danger of spewing random warning text for months [17:51:40] awight: I guess for that we should talk to release engineering? I have no idea what the right solution would be for that [17:51:45] ejegg: before i go too far down this path, planning to add an array to defaults.js that describes the default tables and associated widgets, and put a generalized function in persistence.js to do the checks and inserts. does that sound reasonable to you? [17:52:26] AndyRussG: I also think peering hard at wikiapiary would give some hints as to how people generally follow core vs extension updates. [17:52:37] My guess is, core updates are more common [17:53:21] awight: arg! sounds like fun but I may just put up a Someone Else's Problem field in front of that one... no? [17:53:29] cwdent: ejegg: Shall I add the dash to mw-vagrant when I get a chance, or does that sound fun to either of you to do yourself? [17:53:32] cwdent: I dunno if defaults.js is the place for it [17:54:14] cwdent: I think that should stay just operational configuration [17:54:19] AndyRussG: mmm, if it's gonna be a harmless warning, we should go out of our way to support not logspamming IMO. If it's a breaking change, we definitely need a solid back-compat plan [17:54:48] ejegg: just hard coded in persistence? [17:54:57] or a different config file? [17:55:04] awight: i wouldn't mind taking a crack at that [17:55:06] maybe a JSON file like we get back from /boards/:id? [17:55:10] cwdent: sold :) [17:55:15] awight: K so I just verified it's not breaking per se if there's a core update but not an extension update, since PHP will take extra args [17:55:22] It may only warn on e_strict too [17:55:39] we try to keep strictly clean [17:55:53] does it warn? I thought the swallowing was silent [17:56:12] awight: it only warns about the different method sig of the overriding method [17:56:36] aah. awkward [17:56:45] or.. it would be multiple boards, so like we return from /user/boards [17:57:09] hahah it's bass ackwards [17:57:10] where does that json live? [17:57:14] AndyRussG: and I assume it breaks if done extension-first? That could be okay, but we should add a version check in the extension entry point [17:58:10] awight: my understanding is it won't actually break extension-first either, because the argument is optional and PHP is good with that, too [17:58:22] cwdent: maybe we move persistence.* to a persistence folder (and later, maybe break 'em out by object type) [17:58:45] awight: "For example, if the child class defines an optional argument, where the abstract method's signature does not, there is no conflict in the signature. This also applies to constructors as of PHP 5.4. Before 5.4 constructor signatures could differ." [17:58:45] https://php.net/manual/en/language.oop5.abstract.php [17:58:45] (^ provided by matt_flaschen) [17:58:50] then the initial data can go in persistence/defaultBoards.json or something? [17:58:51] AndyRussG: ok :) I'll stop wearing you out about it, then [17:59:02] i like that idea. i could see logically dividing up some of what's already in there too [17:59:16] awight: it's OK! Thanks for thoroughness :D [17:59:19] rockin! [17:59:22] for now i'll just move them and add that file though [17:59:31] sounds good [17:59:57] alrighty, well imma head to the shop [18:01:42] awight: ejegg: cwdent|afk: yeah only warning with e_strict [18:03:49] AndyRussG: fwiw, https://phabricator.wikimedia.org/P662 [18:03:55] just like u said [18:04:11] no warnings for the other way around [18:04:41] So... that's the more difficult thing to prevent, I think. Cos we can't edit the old extension code to be forwards-compatible or test anything. [18:06:47] Too bad the pattern isn't that the RL member function calls $this->getContext()... [18:09:49] awight: nice test code! thanks for doing that :) [18:11:24] Too curious not to [18:13:24] :) [18:14:15] You're right about the pattern, too. It sure could do that, as far as I can see, if it context were passed in to the reasourceloadermodule as a constructor param [18:15:48] https://github.com/wikimedia/mediawiki/blob/master/includes/resourceloader/ResourceLoaderStartUpModule.php#L195 [18:16:28] Or maybe a separate call to setConfig, I don't think there's a base constructor. [18:16:34] sorry, "setContext" [18:16:47] Hmm also [18:17:12] $resourceLoader at that line already has $context [18:17:58] https://github.com/wikimedia/mediawiki/blob/master/includes/resourceloader/ResourceLoader.php#L497-524 [18:18:31] yes! [18:18:33] Maybe that's a better route [18:18:38] parallel to setConfig [18:18:42] It would save compatibility headaches [18:19:20] apologies that I'm the main source of those ;) [18:19:40] awight: heh messenger, not cause of the message [18:20:31] I do like that the contextualness is explicit when you pass as a param, but it sort of becomes distracting in the majority of subclasses which will never use the $context param to getDependencies [18:22:20] awight: check out the base class, tho: https://github.com/wikimedia/mediawiki/blob/master/includes/resourceloader/ResourceLoaderModule.php [18:22:32] It's all passing in context in a zillion methods [18:22:37] ino :( [18:23:09] I can't imagine that the devs didn't consider adding in context as a class member, there's probably a reason [18:23:54] Lemme add a comment about that to the Gerrit change and phab task, and maybe we can wait on a response there from Krinkle et al [18:24:40] The class is not stateless [18:37:14] awight: btw if ur bored here are some bits that... may or may not bore you more 8p https://gerrit.wikimedia.org/r/#/c/211314/ https://gerrit.wikimedia.org/r/#/c/210408/ [18:37:30] great! [18:38:01] (CR) Awight: [C: 2] "(self merge is ok)" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/211314 (owner: AndyRussG) [18:38:14] (PS2) Awight: bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [18:38:26] self-merge-a-merge [18:38:28] elf-merge [18:38:37] AndyRussG: aargh, sorry ^^ hopfully I didn't screw the history again [18:38:55] awight: ah no on the contraire, thanks! [18:38:58] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [18:39:20] (Merged) jenkins-bot: Merge branch 'master' into campaign_mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/211314 (owner: AndyRussG) [18:39:30] yeah the KV patch won't merge yet in any case due to deps [18:39:50] But it'd be great to get some initial feedbk [18:40:43] Where does mw.log go? Back to us? [18:40:51] awight: nope, just to the console [18:41:01] thx [18:41:13] it's the mw way of saying console.log [18:41:19] eew [18:41:55] I think it's got a shim for browsers that don't support that [18:43:30] atgo: Hey, only if you're working... You agree that I should write and update subtasks for https://phabricator.wikimedia.org/T95496 ? [18:43:45] yes :) [18:43:52] thanks! [18:44:12] maybe put them under here: https://phabricator.wikimedia.org/T77910 [18:44:27] good idea [18:51:46] (PS1) Cdentinger: moves persistence stuff to new dir, add defaultTables.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/212316 [18:55:11] i have a couple questions about process... [18:56:10] why use branches for stuff where you're going to rebase into a provisional commit against master and it won't get merged until approved in gerrit? [18:56:20] does it really matter if you have a local branch in that instance? [18:56:34] nah [18:56:37] 2nd question, anyone ever bother pushing their local branches to remote? [18:56:40] that's just for your own benefit [18:56:50] so you don't accidentally increment local/master [18:57:06] ok cool, that's what i figured [18:57:22] wanted to make sure i wasn't missing something [18:57:38] cwdent: yeah, I push local branches when it's a long-running project or I want to shere. There's a gimmicky feature in Gerrit, where push gerrit HEAD:sandbox/cwdent/Branchname gives you a place to do that [18:58:19] You can also create a branch from the web UI, if other people will be contributing stuff [18:58:52] http://www.mediawiki.org/wiki/Gerrit/personal_sandbox [18:59:35] ok cool, that's been my normal workflow with branches too [18:59:41] minus the gerrit thing [18:59:56] i'm not going to complain about gerrit [18:59:58] ...yet [19:00:18] I need to start having the discipline to create branches for everything... I have to reset the needle on my local master a few times a day [19:01:13] if there is one thing git demands it's disciplined users [19:01:33] I wouldn't be here right now, if not for reflog [19:01:35] I'm a mess. [19:01:46] it's like the sensei that severely beats its pupils for very minor infractions [19:01:54] oh, sandbox is nice! [19:02:01] DON'T YOU LIKE LEARNING? [19:03:03] D'oh - I thought we had given worldpay the fancy new styles when I chose that gateway to copy the form from [19:03:14] http://www.gifbin.com/bin/022012/1329933589_pai_mei_beard_flick.gif [19:07:37] ejegg: sorry! I'm not sure what we should do there... pizzzacat's redesign was functionally much better, but the styles are messed up. [19:07:48] U saw her WIP patch? [19:08:19] (CR) Awight: bannerController.lib: KV store with localStorage (7 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [19:16:33] (CR) Awight: WIP l10n for mustache (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (owner: Ejegg) [19:25:04] awight: yeah, just trying to get it looking like GlobalCollect now [19:25:22] pizzzacat's patch, that is [19:25:36] whew... that's the hard way, for sure. You think it will pay off? [19:25:45] I don't know that we even want the fluid thing [19:28:09] hmm [19:29:06] ok, for this round I'll just copy the GC tables and use her module loading functionality [19:29:46] if i try to get fancy with css this'll take a month [19:34:55] ejegg: How do you want to deploy https://gerrit.wikimedia.org/r/#/c/210764 ? [19:35:09] Astropay is currently enabled by default, so this change would be live [19:36:15] (CR) Awight: "Ready to merge, I just want to clarify how this will be deployed." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210764 (https://phabricator.wikimedia.org/T90505) (owner: Ejegg) [19:38:14] Yeah, I guess we want to hide it so it's not chosen for BR? [19:38:35] And rebase back under the RapidHTML revert [19:39:02] So, maybe not merge that till we actually have live credentials set up [19:39:43] Fundraising Sprint Indigo Girls, Fundraising Tech Backlog, MediaWiki-Templates, MediaWiki-extensions-DonationInterface, I18n: Mustache renderer needs to support i18n - https://phabricator.wikimedia.org/T97149#1299787 (awight) To throw an exciting wrench in, we have a special requirement for Fu... [19:40:25] brb, gonna food [19:40:31] ejegg: even for testing? ok sure [19:40:34] chow! [19:40:58] ejegg|food: Here's a good one for the next SoS: https://phabricator.wikimedia.org/T97149 [19:42:41] This could be cherry-picked to master and merged, if you want to close the card: https://gerrit.wikimedia.org/r/#/c/210769/ [19:43:02] BTW I've been having luck with Gerrit's cherry-pick button. [19:54:33] Fundraising-Backlog: Use WMF-hosted unsubscribe page for Fundraising emails, make conditional opt-out options - https://phabricator.wikimedia.org/T99821#1299809 (CCogdill_WMF) NEW a:atgo [19:58:41] arg that was a clumsy merge! [20:11:32] * awight looks guilty [20:18:18] ejegg: does this declaration syntax make you recoil? https://gist.github.com/caseydentinger/c27fea67da0070c3f027 [20:18:25] with the newline after var [20:18:43] one problem with tabs is you can't count on things lining up the other way [20:20:17] besides that first line, it's basically the existing style [20:20:51] works for me [20:22:44] cool, ty! [20:23:09] Please don't align! [20:23:31] So much waste of life when editing those... [20:23:33] non-aligned movement? [20:23:44] antidisestablishment... [20:25:08] (PS2) Ejegg: Do queue stuff in Astropay ResultSwitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210769 (https://phabricator.wikimedia.org/T90504) [20:25:53] (CR) Awight: [C: 2] Do queue stuff in Astropay ResultSwitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210769 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [20:25:58] thanks! [20:29:16] http://endless.horse/ [20:29:40] hah! [20:31:06] Doesn't work for me, I have tabs [20:31:07] ahh, scroll script. For a second I hoped they just kept the http connection open... [20:33:10] (PS1) Awight: DO NOT MERGE jenkins job validation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/212440 [20:34:10] i'm not going to fight anyone on syntax stuff but i would like to submit that i think in multi line declarations there is meaning encoded in the alignment [20:34:27] when you omit var [20:35:15] it's the aligned "=" that gives me an itchy trigger finger... but I won't stop you :p [20:35:39] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, and 4 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1299966 (awight) [20:36:15] yeah i don't bother aligning = ever [20:36:33] but the gist... [20:36:41] ok thanks for confirming :) [20:36:49] oh sorry [20:36:51] bad example [20:37:16] * awight peeks behind the curtain with increasing suspicious [20:37:19] i do however get a small joy when a bunch of variable names are the same length [20:37:19] suspicion [20:37:23] lol [20:38:41] the longer I look at "suspicion", the less I believe in spelling English [20:40:25] would you say you are...suspicious of it? [20:40:57] That would... make the situation worse [20:41:08] blue---no, yellow! [20:41:42] hehe [20:43:57] (Merged) jenkins-bot: Do queue stuff in Astropay ResultSwitcher [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210769 (https://phabricator.wikimedia.org/T90504) (owner: Ejegg) [21:05:49] (PS2) Ejegg: WIP l10n for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 [21:09:13] (PS3) Ejegg: WIP l10n for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 [21:11:16] i wish there was consistency with async js operations, i don't like it when sync things take a callback [21:12:29] (PS1) Awight: Split out our CiviCRM-core customizations [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/212447 [21:13:44] ejegg: ^^ O_o [21:15:23] awight: woohoo! Checking it out [21:15:47] awight: are these the things that would have to be patched if civi was upgraded? [21:15:55] (CR) Ejegg: WIP l10n for mustache (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (owner: Ejegg) [21:15:57] yyyeah [21:16:26] we sure got a passel of em [21:17:13] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, and 4 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1300087 (awight) [21:17:28] (Abandoned) Awight: DO NOT MERGE jenkins job validation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/212440 (owner: Awight) [21:22:05] hmm, gerrit's a bit of a confusing interface to examine patch files [21:22:20] you could merge :) [21:22:34] diving in! [21:23:16] * awight gently nudges https://phabricator.wikimedia.org/T99152 and https://phabricator.wikimedia.org/T99017 into harm's path... if you're in that kind of a mood [21:23:54] oh nice, you got memcache acting queue-y [21:24:16] grr. another one of those moments where I realize I'm not actually a programmer. well, not a good one at least. [21:24:29] I hadn't considered how that would work. [21:25:23] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Port civi-core patches to extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1300095 (awight) NEW [21:26:40] doesn't memcache do its own serialization? is the json_encode just to make it prettier? [21:26:58] I forget why I did that... [21:27:24] There was some issue with memcache vs memcached using different serializations, maybe I was just being conservative. [21:27:35] hmm, not that it would help in that case. [21:28:29] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare CiviCRM 4.4 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1300103 (awight) NEW [21:29:10] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1300109 (awight) [21:29:27] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1300095 (awight) [21:29:37] (PS2) Ejegg: WIP Copy GlobalCollect form and make it mustache-y [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 [21:29:39] (PS1) Ejegg: WIP add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 [21:29:41] (PS1) Ejegg: WIP forms refactor resources [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [21:30:05] (CR) jenkins-bot: [V: -1] WIP add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [21:30:07] (CR) jenkins-bot: [V: -1] WIP forms refactor resources [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [21:31:03] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Port our CiviCRM customizations to 4.4 upstream, and to extensions - https://phabricator.wikimedia.org/T99838#1300113 (awight) NEW [21:31:56] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1300128 (awight) [21:31:58] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Prepare CiviCRM 4.4 upstream and Giant Rabbit branches - https://phabricator.wikimedia.org/T99837#1300129 (awight) [21:33:08] (PS2) Ejegg: WIP add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 [21:33:40] (CR) jenkins-bot: [V: -1] WIP add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [21:38:26] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Triage what to do with civi-core patches: extensions, upstream, or abandon - https://phabricator.wikimedia.org/T99836#1300147 (awight) [21:40:38] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: Upgrade Civi to 4.4 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1300159 (awight) [21:43:39] Fundraising Tech Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas - https://phabricator.wikimedia.org/T99841#1300169 (awight) NEW [21:47:02] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Install 4.4 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1300182 (awight) NEW [21:47:39] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Install 4.4 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1300182 (awight) [21:48:09] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Install 4.4 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1300182 (awight) [21:48:47] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install Civi 4.4 to production - https://phabricator.wikimedia.org/T99844#1300198 (awight) NEW [21:49:08] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Install Civi 4.4 to production - https://phabricator.wikimedia.org/T99844#1300198 (awight) [21:49:09] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Install 4.4 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1300205 (awight) [21:49:44] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Port our CiviCRM customizations to 4.4 upstream, and to extensions - https://phabricator.wikimedia.org/T99838#1300207 (awight) [21:49:46] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic: Install 4.4 to staging and test like hell - https://phabricator.wikimedia.org/T99842#1300182 (awight) [21:50:16] Fundraising Tech Backlog, Wikimedia-Fundraising, Wikimedia-Fundraising-CiviCRM: Compile release notes and gotchas - https://phabricator.wikimedia.org/T99841#1300209 (awight) [21:50:18] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Port our CiviCRM customizations to 4.4 upstream, and to extensions - https://phabricator.wikimedia.org/T99838#1300113 (awight) [21:50:46] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, and 4 others: Reorganize CiviCRM 4.4 upgrade and GR reporting integration tasks - https://phabricator.wikimedia.org/T95496#1300221 (awight) Open>Resolved [21:50:47] Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Epic, Patch-For-Review: Upgrade Civi to 4.4 & integrate new reporting - https://phabricator.wikimedia.org/T77910#1300222 (awight) [21:50:49] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Enable CiviCRM's cache clear job - https://phabricator.wikimedia.org/T98428#1300223 (awight) [21:50:53] sorry... [22:04:44] ejegg: we're chickening if u interested [22:24:29] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, Patch-For-Review: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1300287 (awight) [22:25:08] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, Patch-For-Review: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1300289 (awight) a:awight [22:25:22] Fundraising Sprint L, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1300290 (awight) [22:25:24] Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, MediaWiki-extensions-CentralNotice, Patch-For-Review: CentralNotice: deploy core change required for campaign mixins - https://phabricator.wikimedia.org/T98924#1300291 (AndyRussG) [22:48:49] my parents are coming into town like now so i'm gonna run home, back on in a bit though [23:16:38] (CR) Ejegg: [C: 2] "Impressive wrangling! Much clearer to have 'em all split out and named. Bunch of triage-related comments." (10 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/212447 (owner: Awight) [23:21:02] hey sorry about all the racket on the call today, it's usually super quiet in there [23:21:25] cwdent: np! [23:22:56] (CR) Awight: Split out our CiviCRM-core customizations (4 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/212447 (owner: Awight) [23:23:00] (Merged) jenkins-bot: Split out our CiviCRM-core customizations [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/212447 (owner: Awight) [23:23:51] c'mon. We live for that stuff. [23:24:17] as far as the new sprint, i am wondering if tickets for tidying up the default tables and getting dash into vagrant/puppet would be warranted. i feel like both should be achievable before next weds [23:24:40] i say that without having dug into mw-vagrant but with plenty of config management experience [23:25:56] It's just Puppet [23:25:57] and yeah the shop is full of 19th century folk art that i bet you'd get a kick out of awight [23:26:09] Rococo... [23:26:12] that's all i know [23:26:49] yep. and lots of southwestern jewelry [23:27:05] turquoise for days [23:27:09] cwdent: on a whim, sounds great, and making cards will be better for everybody [23:27:51] cool, permissible to create myself or do we delegate to anne/katie? [23:31:47] oh totally on you :) [23:32:04] we're very self-managely [23:32:27] the sprints are just to make sure we're not in outer space (unless we're supposed to be), and for communication [23:32:33] * awight wonders if I'm lying [23:33:57] sounds great, parents are here so i'll take care of all that in the morning [23:34:02] g'night! [23:36:01] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Document how the new queuing stuff will work - https://phabricator.wikimedia.org/T96434#1300487 (awight) [23:51:49] (PS3) Ejegg: WIP add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457