[00:06:01] (PS3) Ejegg: WIP Copy GlobalCollect form and make it mustache-y [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 [00:06:03] (PS4) Ejegg: WIP add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 [00:08:33] (PS2) Ejegg: WIP forms refactor resources [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [03:27:25] Fundraising Dash: refactor default board inserts on dash - https://phabricator.wikimedia.org/T99867#1300668 (cwdent) NEW a:cwdent [03:30:04] Fundraising Dash, Fundraising Sprint L: refactor default board inserts on dash - https://phabricator.wikimedia.org/T99867#1300676 (cwdent) [03:44:03] Fundraising Dash, Fundraising Sprint L, MediaWiki-Vagrant: create vagrant role for fundraising dash - https://phabricator.wikimedia.org/T99869#1300685 (cwdent) NEW a:cwdent [08:05:09] Fundraising Sprint Indigo Girls, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Astropay Integration, Patch-For-Review: Make form for Astropay Brazilian credit cards - https://phabricator.wikimedia.org/T97056#1231787 (atgo) Moved to "doing" since there's a patch attached :) [15:33:13] (PS3) Ejegg: cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211039 (owner: Awight) [15:34:15] (CR) Ejegg: [C: 2] "Rebased around do_transaction refactor, awight's cleanup is still nice & clean!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211039 (owner: Awight) [15:34:46] (Merged) jenkins-bot: cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211039 (owner: Awight) [15:54:04] (CR) Ejegg: [C: 2] "Looks good! I see you've encountered some of the oddities we created as a result of mashing up bootstrap and knockout. Eventually I'd li" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/212201 (owner: Cdentinger) [15:57:42] ejegg|away: in the past i've had some success using this instead of bootstrap: http://getskeleton.com/ [15:57:50] it's a lot simpler [17:30:41] (PS22) AndyRussG: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [17:31:17] * AndyRussG waves at atgo ejegg cwdent :) [17:31:29] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [17:31:40] hello AndyRussG! [17:31:45] nice work on that bug :) [17:32:33] morning erryone [17:32:41] atgo: ah thanks, for a sec I was scared it might be real, but for now my theory is it's something else (random network issues, someone forgetting they were logged out, something like that) [17:32:48] morning cwdent :) [17:32:54] atgo: how's Lyon? [17:32:58] well phillipe commented that he messed up the bucketing? [17:33:03] Also: anyone know if K4 will be at all reachable today, by any chance? [17:33:36] i doubt it? [17:34:17] atgo: ah OK, yeah I hadn't seen that! [17:34:18] AndyRussG: didn't we have a task for CN that wouldn't allow an empty bucket to be set? [17:34:29] i can't seem to find it.. maybe it didn't move over from mingle? [17:34:36] atgo: it's done and deploy'd [17:34:41] hmm... [17:34:50] are we sure? because... doesn't that seem like what happened here [17:34:51] ? [17:34:56] atgo: but it just displays a warning, doesn't actually prevent it [17:36:02] lyon is lovely! [17:36:10] i went to 2 museums, walked like 11 or 12 miles [17:36:11] It shows a little red message at the top of the page, could be more visible... [17:36:13] ate gelato [17:36:20] cool! [17:36:34] oh yeah... like after the campaign is saved you mean? [17:38:06] AndyRussG: ^ [17:38:28] atgo: correct. We could make the notice more visible, but other than that, there's not much more to do with our clunky UI, short of redoing it properly [17:38:39] yeah [17:38:44] ok... something to think about [17:38:47] It's all the oposite of AJAX [17:38:55] it would be nice to throw a popup in that case [17:39:01] but we should also, you know, redo the bucketing UI anyway :) [17:39:09] exactly [17:41:12] Yeah also I think there may be a point in some peoples' workflows in which that is a valid state... as in, first increase the number of buckets, save, then add banners as needed to fill 'em up [17:41:53] oh yeah [17:42:01] so until we fix that workflow, this is probably the best solutio [17:42:14] because having to save twice like that is not the best either [17:42:53] Mmm probably it's the best way for now, or close to it... Conceivably we could make the warning bigger or put it somewhere else (like next to the "submit" button...) [17:43:21] Or it could sing a song [17:44:02] but what if they muted?! [17:44:07] clearly... animated gif overlay. [17:44:16] Flash animation! [17:44:26] Mmm so do you know, is K4 actually flying today? I guess the best way to reach her would be e-mail, then... [17:47:31] Definitely we should re-do all CentralNotice and banners using Flash [17:48:38] i think she is flying today [17:48:50] she declined all the meetings [17:51:26] (CR) AndyRussG: "Thanks @Siebrand! Sorry if I wasn't clear, those are temporary messages... They'll be removed before this feature branch is merged to mast" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [17:51:39] atgo: hmm K thx! [17:51:50] wait! there's a thing! [17:52:01] https://office.wikimedia.org/wiki/Lyon_Hackathon/Arrival_and_Departure_List [17:52:01] ? [17:52:27] her flight is at 345.. i know because i took the same flight 2 days ago [17:52:31] or yesterday. i can't tell. [17:53:26] anyway.. i need to run and get some dinner before calls later [17:53:39] and to, you know, attempt to get on some sort of normal schedule [17:54:14] atgo: cya! thx [17:57:39] (PS23) AndyRussG: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [17:58:47] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [18:05:25] AndyRussG: Holler if there's anything I should review today! I'm not sure which things are waiting for me, vs Krinkle and the core team... [18:06:25] awight: hi! I was just going over your last set of comments on the mixins patch to see if I got everything, just found one detail still... I'll give a shout about that in a sec I hope [18:06:26] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog: Upgrade payments MW Core - https://phabricator.wikimedia.org/T99020#1302139 (awight) a:awight [18:06:46] AndyRussG: awesome, just spoon-feed me the patches if you don't mind :) [18:06:58] awight: sure u bet, and thx! [18:07:13] I'm noticing it's not convenient to get the list of patches from a Phab task... [18:11:31] Hurm... which Phab task 4 u looking at? [18:16:05] It's just silly to read all the comments for patches, when we're already parsing the links [18:23:50] You mean, there should be a more efficient way to get straight to the comments= [18:23:51] ? [18:24:03] (PS24) AndyRussG: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [18:24:39] Fundraising Tech Backlog, Patch-For-Review: Upgrade payments mw-core to something newer - https://phabricator.wikimedia.org/T94528#1302164 (awight) [18:24:41] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog: Upgrade payments MW Core - https://phabricator.wikimedia.org/T99020#1302163 (awight) [18:25:01] (CR) AndyRussG: Campaign-associated mixins (7 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [18:25:10] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [18:27:36] awight: That one should be ^ ready to be looked at again. I think I've more or less dealt with all the comments :) [18:28:56] Jeff_Green: Don't worry if you're EU or flying or something... but I'm wondering, do we use upgrade.php on the payments cluster? [18:29:31] hmmm, i don't know [18:30:05] it does db updating? [18:30:39] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1302182 (awight) a:awight [18:31:57] Jeff_Green: yeah. I forget what we did last time we upgraded MW-core. [18:32:06] me too [18:32:27] On the real cluster, catrope has a standing troutslap on offer to anyone who runs that script. [18:32:42] heh [18:32:44] upgrades are done real slow and manually, by mwscripting each patch [18:32:57] But I think that has to do with their screwy schema tweaks? [18:33:15] We might be fine, cos our db is smallish and stock. [18:33:31] maybe we could make it run in a mode where the queries are displayed instead of done automatically, so we can sanity check them? [18:33:49] Sure, or we could run it on a backup? [18:33:49] otoh the payments db is tiny, it's pretty easy to back it up and restore in a pinch [18:33:54] yeah [18:33:58] let's just go for it, eh? [18:34:02] ha [18:34:05] I should document this somewhere... [18:34:21] well now is a bad time because I'm leaving soon for Lyon [18:34:42] :) No worries, I was thinking any time next week. [18:36:03] ok [18:48:18] awight: what do you think of changing the memcache backend to use memcached and cas tokens? [18:57:47] ejegg: I think it's great, but we should coordinate with CoderKungfu [18:57:59] what is cas, compare and swap? [18:58:07] cwdent: that skeleton css yep! [18:58:23] ah, check and set [18:58:27] bah, slow shell! [18:58:42] ejegg: yeah it's very lightweight but still "responsive" [18:58:54] and the default styles are fine for a simple guy like me [18:59:08] and it's slightly less chunky div soup than bootstrap [18:59:22] oh yeah, tons of containers there [19:00:06] We'd have to find another thing for modals [19:00:07] weird, cas seems to stand for both atomic things at once [19:00:25] not sure what else we rely on bootstrap for [19:00:27] Are we not atomic with the Memcache extension? [19:00:47] awight: just the bucket read / alter / store [19:03:19] oh wait, does regular php-memcache have cas now? I read that was missing, but there's some kinda fn with that name [19:03:55] I see what u mean, yeah I was setting us up for a race condition! [19:04:30] ... and this is why I was so mad at myself for not considering that memcache didn't support queuing natively... [19:05:02] and if we go over 1MB of unresolved limbo entries, we have to start sharding the index container and shit [19:05:07] gtrrrrr [19:05:27] I started reading up on Redis, and that seems pretty cool - we could just push or pop from an array without the round trip [19:05:34] I think Jeff_Green was saying, installing Redis on the payments cluster sounded like an awesome hackathon task :p [19:05:39] exactly [19:05:42] LPUSH [19:05:48] oh i forgot about that! [19:05:53] :) [19:06:03] let's test it on lutetium first [19:06:03] It's not a rush for that either, we haven't written the code yet [19:06:08] cool [19:06:20] We have months of playing around in Vagrant before we would even need lutetium... [19:06:21] maybe for the Mexico City hackathon [19:06:26] ha ok [19:06:37] I gotta run an errand, biab [19:07:55] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302292 (awight) [19:08:12] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1029500 (awight) [19:08:25] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1029500 (awight) [19:22:47] awight: yeah, looks like php-memcache has a 'cas' function from 3.0+, though it's not in the php.net docs yet [19:28:01] promises are an interesting interface for mysql [19:29:17] cwdent: I started out doing it with callbacks, and that got old fast [19:30:30] But I think mysql errors a ways along the promise chain may not be bubbling up to the top level error handler correctly [19:31:47] hrm, i'll see if i can fix that [19:32:48] or they weren't at one point - I forget if that's still an issue [19:37:48] awight:oh, to use cas with php-memcache 3+, we'd still have to switch to using \MemcachePool instead of \Memcache. So it might be worth switching to the lib whose CAS documentation is readily available [19:53:54] ejegg: feeling pretty bad right now about what an overengineered catastrophe i've turned a few simple queries into [19:54:12] hehe [19:54:42] getting pretty involved, huh? [19:54:56] i wanted to make it check against the list and back fill any missing boards or widgets that may have been added [19:55:14] and it mostly works but it's fugly and unreadable [19:58:46] hmm, yeah. Probably not worth spending too much time making it beautiful [19:59:17] since we shouldn't have to insert too many per-user boards after we sort out shared stuff [19:59:53] ugh yeah good point [19:59:59] a/b and big english should probably just be shared [20:00:29] time would probably be better spent sorting out sharing [20:00:53] hey, if it's coded and working, no need to throw it out either! [20:01:35] hehe, we'll see if you say that after you see it [20:02:07] i'll finish it up and make a patch but will be totally ready and willing to trash it [20:02:30] shared boards are a way simpler and better solution for this [20:03:27] 'simple' till people want fine-grained permissions or acls or the like [20:10:50] (PS2) Ejegg: Correct new role name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/208712 (owner: Awight) [20:14:36] (CR) Awight: [C: 2] "Thanks! Follows up on @If8d54feae5d" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/208712 (owner: Awight) [20:15:20] (Merged) jenkins-bot: Correct new role name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/208712 (owner: Awight) [20:22:24] Fundraising Tech Backlog: Upgrade payments MW Core - https://phabricator.wikimedia.org/T99020#1302474 (awight) [20:29:46] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1302478 (awight) [20:36:11] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1302484 (awight) [20:36:55] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1017275 (awight) [20:36:56] Fundraising Dash, Fundraising Sprint L, MediaWiki-Vagrant: create vagrant role for fundraising dash - https://phabricator.wikimedia.org/T99869#1302487 (awight) [20:39:04] Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Document how the new queuing stuff will work - https://phabricator.wikimedia.org/T96434#1302489 (awight) [20:44:17] Fundraising Tech Backlog, Wikimedia-Fundraising: Write puppet to provision DonationInterface - https://phabricator.wikimedia.org/T99951#1302501 (awight) NEW [20:44:28] AndyRussG: this bucketing thing from this morning sounds more severe than i thought [20:44:42] Fundraising Tech Backlog, Wikimedia-Fundraising: Write puppet to provision DonationInterface - https://phabricator.wikimedia.org/T99951#1302501 (awight) [20:44:44] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302507 (awight) [20:44:47] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1302509 (awight) [20:44:57] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1017275 (awight) [20:44:59] Fundraising Tech Backlog, Wikimedia-Fundraising: Write puppet to provision DonationInterface - https://phabricator.wikimedia.org/T99951#1302501 (awight) Open>Resolved a:awight [20:45:01] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1029500 (awight) [20:45:24] (PS4) Ejegg: l10n for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (https://phabricator.wikimedia.org/T97149) [20:45:36] atgo-dinner: in what sense? looking at Phillipe's last comment? [20:45:43] i'm editing the task.. hang on [20:46:10] I was gonna ask him what he meant by stuff "getting moved" to bucket C [20:46:34] Just thinking out loud, it might be a browser autofill issue, the admin interface has that problem [20:46:45] well.. i'm not so sure [20:46:48] https://phabricator.wikimedia.org/T99915 [20:47:27] (CR) Ejegg: l10n for mustache (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (https://phabricator.wikimedia.org/T97149) (owner: Ejegg) [20:48:49] atgo: feel like i have a much better idea of my goals for this, mind if i edit some phab tasks to reflect the current plan of making a global a/b board and getting the widget to return something useful? [20:48:56] totally! [20:49:05] groovy [20:50:43] gonna head to the shop, back in a few [20:52:22] atgo: what was Phillipe trying to do with buckets anyway? Was he running a test? Or did he want a specific sequence of banners? [20:52:32] just having 2 different banners [20:52:36] K... [20:52:44] So that's not what buckets are for at all [20:52:55] well, put some people into 1 bucket [20:52:58] put some people into the other [20:53:01] If you want 2 different banners to get chosen randomly, you just put them in the same bucket [20:53:06] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302529 (awight) [20:53:10] But why some in one and some in another? [20:53:30] same.. bucket? [20:53:36] they're A/B testing the 2 [20:53:41] i am learning [20:53:50] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1029500 (awight) [20:55:14] AndyRussG: ^ [20:55:16] huh... OK A/B testing is for buckets [20:55:26] or vice versa I mean [20:55:45] Out of curisoity what A/B testing are they doing with board voting banners? [20:57:34] i've asked... i'm assuming clicks? [20:58:43] yeah, clicks AndyRussG [20:59:07] Hmmm OK interesting [21:00:06] I'm a bit confused as to what exactly happened with the UI when Philippe was setting up the campaign... Maybe we schedule a video call and he can, uh, sort of re-enact? [21:00:26] The first step for the bug would be to be able to reproduce it [21:00:47] yeah he talked me through it [21:00:52] so... he set it up with 2 buckets [21:00:56] and put one in A and one in B [21:01:12] and then when he went back (because some people weren't getting any banners), saw that they were in A & C [21:01:17] but only 2 buckets were selected [21:01:21] so nobody was seeing the banner in C [21:02:14] philippe is joining :) [21:02:38] here [21:06:35] atgo: hmmm [21:06:41] he's having some trouble with IRC, says he [21:07:04] hello philippe! [21:07:07] bienvenue [21:07:10] K so it switching buckets via the administration ui [21:07:28] Heya :-) I broke the thing! [21:07:38] philippe: salut, comment ça va? [21:07:45] ca va bien, merci [21:07:59] * atgo already used all her french [21:08:09] That’s all I know too [21:08:15] I just sound all hoity-toity [21:08:26] philippe: I don't think you broke it, but it's got loads of UI issues and surely some bogs too [21:08:28] bugs [21:08:43] AndyRussG: I’ve been using that thing for 8 years. What you describe? That’s it’s resting state. [21:09:13] Back in my day…. we built banners and used magic words, not variables. $SITENAME. UPHILL. BOTH WAYS. [21:10:54] andyrussg - my concern with this is that it's going ot keep being a problem/cause more problems... so if we can figure out if it's an isolated thing, that's a great first step [21:11:17] philippe: ah OK neat [21:11:22] atgo: yeah [21:11:27] woohoo! [21:11:30] I think the first step would be to look at the logs? [21:11:42] philippe: which day did this happen on? [21:11:44] Today. [21:11:52] At least, that’s when we noticed it. [21:12:05] and when did you make the campaign? a while ago, yeah? [21:12:06] If we can tell if it ever served banners to it.wikipedia, we should be able to tell when it STOPPED serving them. [21:12:23] Yeah, a couple weeks ago [21:12:27] but we just enabled it three days ago [21:12:39] I’m not sure if it ever served them to it.wiki at all. [21:12:55] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302569 (awight) [21:13:05] (it turns out, one of the banners was also misconfigured and didn’t have “show to logged in” checked… so between that and the bad bucket, that wiki may have gotten NO banners.) [21:13:06] https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs [21:13:49] Fundraising Dash, Fundraising Sprint L: make the a/b test widget return data - https://phabricator.wikimedia.org/T99867#1302572 (cwdent) [21:14:03] philippe: hmm well if it's not geotargeted and targets all languages it shouldn't be different for different wikis, unless other campaigns are there at the same or higher priority [21:14:27] It should be possible to confirm using the banner impression logs, though [21:14:29] It was definitely blacked out only on some projects. [21:14:47] We were seeing the one functional banner on en.wiki, for isntance… and 2000 people followed it to vote. [21:15:48] Re: blacked out on some projects, that'd be the case for French, for users in France, since the hackathon banner is at a higher priority [21:15:57] WM_Hackathon2015 [21:16:37] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302574 (awight) [21:16:51] CN changelog here: https://meta.wikimedia.org/w/index.php?title=Special:CentralNoticeLogs&offset=&limit=100 [21:16:52] philippe: are you getting that from clicks? [21:17:07] Which bit? the 2000? [21:17:12] No, that’s from the vote logs on votewiki [21:17:50] and those have a referrer? or how do you know that it's just from 1 banner? [21:18:13] Because we only had one enabled, remember… one of them didn’t have the “show to logged in” option checked, accidentally [21:18:23] oh right [21:18:30] let's blame the jetlag :P [21:18:38] The other one was sitting there, in Bucket C, but showing to no one. [21:18:43] (Abandoned) Cdentinger: moves persistence stuff to new dir, add defaultTables.js [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/212316 (owner: Cdentinger) [21:20:33] philippe: atgo: on the logs UI I don't see any cases of banners in bucket C [21:20:50] James and I saw’d it. [21:20:57] With our own eyes. [21:21:14] The thing is haunted or something. :) [21:21:22] philippe: no doubt. AndyRussG - if the campaign was only set to display A & B, would we have C in the logs? [21:21:33] also philippe in the future, if you run into weird things, we'd love screenshots :) [21:21:44] D’oh. And I preach that to people all the time. [21:22:02] :P [21:22:03] Duly noted. [21:22:06] thanks! [21:22:21] i get it when the software is generally finicky, you tend to fiddle before screencapping [21:22:26] at least i do [21:22:31] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015: In the event that credentials for a gateway are not supplied, that gateway should go in to local development mode. - https://phabricator.wikimedia.org/T99954#1302591 (awight) NEW a:K4-713 [21:22:43] well, also, you should assume that I’m tech-incompetent. THink of me like Chaos Monkey. That’s why I keep James around. [21:23:13] Although, come to think of it, the time I disabled editing on enwiki? That was his code. [21:23:31] haha nice [21:27:41] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302599 (awight) [21:28:05] Ok, I’m gonna go find alcohol. It’s 5PM… somewhere. East coast. And it’s been one of those days. [21:28:07] philippe: atgo: I know the interface can be flaky and that it can appear to set a value when it isn't [21:28:10] Ping me if you need anything else. [21:28:18] philippe: OK thanks so much for your help with this [21:28:23] see you philippe [21:28:23] Sure, thank you guys :) [21:28:27] thanks for the help! [21:28:29] philippe: atgo: I was gonna say, I can dig more into the dB [21:28:34] Working on centralnotice? you’re doing the work of the angels. [21:28:45] either that, or your masochistic. [21:28:54] to-MAY-to, to-MAH-to [21:29:05] philippe: hrrggg thanks! it's got its fun bits [21:29:47] Yeah if the buckets were actually registered in the DB as A and C, I think that info might be in the CN log table even tho not visible in the logs in the UI [21:29:53] not quite sure... [21:30:32] hmm [21:30:36] It also could have been that UI issues made it look like it was buckets A and C, but it wasn't, and the issue with users not seeing banners was something else [21:30:39] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302616 (awight) [21:30:49] There are a host of possible reasons someone might not have seen a banner [21:30:55] yeah [21:31:10] i wonder if we can use the click logs to see if the "B" banner was clicked at all? [21:35:31] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1302626 (awight) [21:35:48] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1029500 (awight) [21:37:42] hey awight! [21:38:22] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015: In the event that credentials for a gateway are not supplied, that gateway should go in to local development mode. - https://phabricator.wikimedia.org/T99954#1302633 (awight) [21:39:32] atgo: Hi, how's the cheese? [21:39:39] so good [21:39:40] also, bread. [21:39:51] like how is our bread game SO FAR behind France's? [21:39:51] * awight swoons [21:40:04] i don't get it. [21:40:06] They have socialist laws about putting sugar in. [21:40:10] Only so much. [21:40:21] We're just slaves to whatever the industry decides we should eat. [21:40:37] ugh even tartine has nothing on this [21:40:41] it's so good. [21:40:46] :) [21:40:52] (grr) [21:41:10] i see you organizin' the hackathon tasks [21:41:12] There are chickens exploring my shed... [21:41:32] yep, I put a note out to K4-713 to take a look, hopefully she agrees with the direction I was headed in. [21:41:33] Fundraising Sprint Kraftwerk, MediaWiki-extensions-CentralNotice: [bug] Banners adding themselves to some - https://phabricator.wikimedia.org/T99915#1302641 (atgo) [21:41:57] Not changing anything really, just giving context and explaining what's ready to use and what's still TODO. [21:42:02] generally, i'm not sure that we should have hackathon stuff in the sprint? [21:42:07] WEll [21:42:10] since it's sort of "bonus" [21:42:11] it's what Katie's doing [21:42:18] How about zero points? [21:42:23] yeah i think that's fair [21:42:35] Oh good, it is already :p [21:42:53] poifect [21:43:21] The one thing I could use a second opinion about, is how I've turned T99954 into a list of requirements, rather than subtasks. [21:44:26] (btw, join in the competition to roll over to six digits!!) [21:46:45] shit let's go [21:47:03] http://i1.kym-cdn.com/photos/images/facebook/000/128/136/awwwwshit.jpg [21:47:29] hehe [21:47:34] awight: yeah i think that makes sense [21:47:46] they sound more requirments-y than task-y [21:48:09] Hey, thanks to whoever updated https://gerrit.wikimedia.org/r/#/admin/groups/784,members ! [21:48:32] cool, thank you for taking a look. [21:52:31] no problem [21:55:11] (CR) Awight: "Looking really good! Maybe one step further..." (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (https://phabricator.wikimedia.org/T97149) (owner: Ejegg) [21:59:21] atgo: Hey, can you nudge K4-713 when you see her, to find a slot in the https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2015/Program ? I would like to know ahead of time since I'll be up early or something. [22:03:28] Gotta pace myself for the big 9's [22:03:29] atgo: thanks for the clarifying e-mail... yeah I also wanted to just explain why I thought tasks could be there [22:03:41] atgo: also: you should try to sleep :) [22:03:45] awight: whicn 9's [22:03:57] awight: do you have WM Hackathon plans? [22:04:13] also ejegg|afk ^ [22:04:38] awight: I meant wikimania [22:04:53] AndyRussG: https://phabricator.wikimedia.org/feed/ c.f. the potential odometer tumble!!! [22:05:21] awight: wut? [22:05:30] My hackathon plan was sort of to help with the DonationInterface sprint over the weekend... [22:06:02] ah cool! mmm I initially thought you were talking about the Wikimania hackathon, and also did want to to ask u about that, BTW [22:06:16] AndyRussG: Win notoriety by snagging bug #99999! [22:06:57] Ah, the wikimania hackathon is really exciting, I'm hoping to do a workshop and engage with editors, suck their brains dry, yumm... [22:07:08] AndyRussG: nope, no specific plans besides wanting to attend [22:07:53] awight: ejegg: wanna try to organize something Education or collaboration-related? [22:08:01] yes! [22:08:05] :) [22:08:09] excelente [22:08:16] sure! [22:08:20] Do u have an official slot yet, or will this be an unconference? [22:08:29] \o/ [22:08:57] No official slots yet... [22:09:03] I think we may have to book [22:09:11] rats, ok [22:09:13] No idea really how the process works... [22:10:42] Ugh, /me looks at the cutoff. Doesn't look like the process works. [22:10:49] https://wikimania2015.wikimedia.org/wiki/Hackathon [22:11:07] Everything gets an 8.25, then someone flips a coin :( [22:11:08] (PS5) Ejegg: l10n for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (https://phabricator.wikimedia.org/T97149) [22:11:11] haha andyrussg i think i... may have overcaffeinated today to make up for the jetlag [22:11:18] WOhoooo [22:11:40] awight: AndyRussG ejegg there may be some hangover from the hackathon stuff from this weekend, too [22:11:48] ejegg: what do you think about making boards.owner_id nullable? not sure what to do about public boards vs. the foreign key [22:11:53] which k4 and i had talked about maybe trying to wrap up at wikimania [22:13:06] cwdent: yeah, that could work [22:13:27] guess it's that or designate a superuser [22:13:29] awight: which cutoff? Yeah my volunteer talk landed tails (not accepted) [22:13:38] but that was for Wikimania proper, not the hackathon [22:14:28] actually the super user might not be a bad idea, so that the board can get edited through the UI [22:14:34] I see. I'm just noticing that 8.222 got denied and 8.333 accepted. [22:16:10] cwdent: conveniently, I have uid 1 in deployed dash! [22:16:27] you're it! [22:16:31] heh [22:16:36] awight: but the Wmania hackathon is diff [22:17:09] (CR) Awight: [C: 2] l10n for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (https://phabricator.wikimedia.org/T97149) (owner: Ejegg) [22:17:36] awight: ejegg: https://phabricator.wikimedia.org/tag/hackathon-mexico-city-2015/ [22:17:52] (Merged) jenkins-bot: l10n for mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212243 (https://phabricator.wikimedia.org/T97149) (owner: Ejegg) [22:21:42] AndyRussG: yes, good point! We should still try to drag editors into our fold, I wonder how to do that. [22:22:18] editors and volunteer devs [22:22:33] I think Quim will be the one to ask for guidance on this... [22:24:19] alright friends [22:24:24] i'm actually going to try to sleep [22:24:27] talk to you tomorrow! [22:27:00] atgo: ok, pls poke K4 about getting on the program! [22:27:48] ejegg: Am I forgetting components? https://phabricator.wikimedia.org/T88658 [22:28:42] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1302799 (awight) [22:29:01] hmm, does smashpig include all the listeners we're actually using? [22:29:52] on the program? [22:29:57] WEllll, ok no. I left out legacy stuff. [22:30:06] ok [22:30:14] I figure, stop developing on that... [22:30:23] Good point though, I'll make a note [22:30:49] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1302800 (awight) [22:30:50] noted [22:31:50] awight: there's a bunch of weird stuff in tools that might be irrelevant, like silverpop export and central notice status processing [22:33:18] ys! I think I'll spell them out individually... [22:33:29] awight: what do you mean "on the program"? [22:33:51] oh sorry, https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2015/Program [22:33:58] See you tomorrow! [22:34:31] duly noted [22:34:32] ciao! [22:38:09] ejegg: civimail bounce processing... [22:38:40] er, if we actually had that... [22:39:05] That's all in our crm repo, though [22:39:17] just needs to be turned on [22:39:36] oh, i guess there's a bunch of mail server config too [22:47:48] Yeah, these puppet modules are almost all configuration... [22:48:42] I can take a stab at the mail server config then - you already configure it a bit for CRM, right? [22:51:41] totally! Thanks [22:52:04] I'm sure you know, most of Jeff_Green's production puppet is available on boron [22:52:32] Fundraising Tech Backlog, Wikimedia-Fundraising, Epic: Write puppet modules to provision all fundraising components - https://phabricator.wikimedia.org/T88658#1302820 (awight) [22:53:29] ejegg: That isn't blocking anything at this weekend's hackathon, btw [22:53:58] ah, good... [22:54:47] I think K4-713 wants to focus exclusively on DonationInterface, https://phabricator.wikimedia.org/T89188 [22:56:35] (PS1) Cdentinger: a/b testing board [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/212725 [22:57:18] ejegg: ^ super simple to get shared boards working, tomorrow i'll make them read only for non-owners [22:57:40] no hurry on merging that or anything, i have plenty to do [22:59:06] nice, i'll take a look! [22:59:41] ejegg: O_o did you deploy your DI work on Tuesday and I didn't notice? [22:59:48] yep! [22:59:52] wowza! [22:59:55] surprisingly uneventful [23:00:06] i was so sure _something_ would break [23:01:29] that's crazy. Hi-five! [23:01:41] * ejegg looks at the elbow... [23:01:48] bam [23:02:23] on the opposite extreme, the REL1_25 merge is about to be really silly, I think we're down to just .gitmodules and .gitreview [23:02:32] Otherwise we're running a stock core [23:02:43] freaking awesome [23:02:54] nonevents all around! [23:03:54] (PS1) Awight: Merge REL1_23 into fundraising/REL1_23 [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/212727 [23:03:56] (PS1) Ejegg: WIP More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 [23:04:08] (CR) jenkins-bot: [V: -1] WIP More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (owner: Ejegg) [23:10:12] (PS4) Ejegg: Copy GlobalCollect form and make it mustache-y [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (https://phabricator.wikimedia.org/T97056) [23:16:06] (CR) Ejegg: "I revised @I16da0683c2c and added it a couple of commits later to pull in the css. I definitely like the resource logic there. For now, " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [23:33:09] (PS1) Awight: Merge fundraising release branch into REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212731 [23:33:15] (PS1) Awight: No-op merge of fundraising/REL1_23 into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212732 [23:36:16] I'm having a bit of trouble getting the unit tests to run. It's giving me this error: PHP Fatal error:  Class 'PHPUnit_Runner_Version' not found in /home/dkozlowski/vagrant/mediawiki-fr/tests/phpunit/phpunit.php on line 108 [23:36:36] Is that something we've run across before? [23:36:53] hmm, I remember having a bunch of trouble with it early on [23:37:27] (CR) jenkins-bot: [V: -1] No-op merge of fundraising/REL1_23 into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212732 (owner: Awight) [23:37:35] (CR) jenkins-bot: [V: -1] Merge fundraising release branch into REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212731 (owner: Awight) [23:37:43] I've been running them via the makefile in mediawiki's tests/phpunit dir lately and they work OK [23:37:55] (Abandoned) Awight: No-op merge of fundraising/REL1_23 into fundraising/REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212732 (owner: Awight) [23:39:01] (PS2) Awight: Merge fundraising release branch into REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212731 (https://phabricator.wikimedia.org/T94528) [23:39:07] alright, let me try that [23:39:08] XenoRyet: try going into that dir and running em like this: make phpunit FLAGS="--group DonationInterface" [23:39:22] XenoRyet: try "composer update" in the top level of mediawiki/core... [23:39:28] ooh, that might be it! [23:39:39] Ah wait, sorry. You're using the fundraising/REL1_23 branch... [23:39:49] oh ya [23:39:56] I'm actually fixing that ^^ at the moment, just checkout fundraising/REL1_25 and work there [23:40:16] you should be able to run "composer update" to install phpunit [23:40:53] testing was very unhealthy previously, there was an unpleasant wrapper that expected to monkeypatch PHPUnit internals and stuff. [23:41:03] hi awight :) do you have a second for a quick sql thing? [23:41:11] I really do think it’s a quick one! [23:41:30] ccogdill: Sure, sql = fun! [23:41:35] you’re telling me! [23:41:58] do you know in what database/table the utm_source lives? [23:42:08] as it pertains to individual donations [23:42:11] That should be in drupal.contribution_tracking [23:42:25] It might be a heinous compound field, though... [23:42:48] (CR) jenkins-bot: [V: -1] Merge fundraising release branch into REL1_25 [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212731 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [23:42:55] like it’s not as simple as just saying where utm_source = x ? [23:43:02] yep [23:43:06] hrmph [23:43:08] For example, B15_0515_enlvroskLVROSK_dsk_lg_pos_cntrl.no-LP.cc [23:43:21] well I’m looking for emails. our source codes are nicer [23:43:30] just sp12345678 (replacing those 8 numbers) [23:43:34] We wrote a database trigger that parses this garbage into individual columns, but ewulczyn informed me recently that it's no longer reliable. [23:43:41] ah [23:44:03] umm, try "where utm_source like 'sp%'" for cheap thrills [23:44:25] okay one sec! thanks for getting me to the right db :p [23:44:27] otherwise, "where utm_source rlike 'sp[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9][.]'", sorry... [23:44:36] that’s not terrible [23:44:40] O_O [23:44:45] Want to work in tech? [23:44:56] I only want like 7 specific emails so doing it that way might be my best option anyway! [23:44:59] heh [23:45:37] I did a big query by myself today! I think the fact that that feels like a milestone means I’m not ready [23:46:05] No way. I never do more than one query a day, myself. There's so much more to live for ;) [23:47:19] It's really exciting that you're beating information out of SQL, I think Sherah's dashboard will be an amazing canvas for your upcoming works... [23:47:44] You should start pasting your queries at https://collab.wikimedia.org/wiki/Fundraising/Engineering/Fun_SQL_Queries [23:48:03] I’ve pasted a couple [23:48:09] but I think I’m going to start my own page for email stuff [23:48:21] my queries are pretty specific and I don’t want to muddy the waters [23:48:34] but yes I have big dreams from the dash! [23:48:57] oh, cool! [23:50:12] I think the utm_source works! the where utm_source like ‘%sp%’ returned about the number of contacts I was expecting [23:50:21] so maybe that’s only a headache for banner sourcing [23:50:34] oh, leave off that initial '%', it doesn't do anything but slow u down [23:50:57] ah yeah I guess that’s unnecessary [23:51:07] thanks again! you saved me a ton of describes [23:51:09] a "prefix search" is pretty fast, but when you search for "sp" in the middle, it has to actually process every string in the database. [23:51:13] k, good luck [23:51:23] makes sense. it’s better to know what I’m starting with [23:51:38] you got me at "a ton of describes", btw :) [23:51:48] haha [23:52:23] one day I’ll know where everything is just like you 8) [23:52:28] baahahaha [23:55:16] (PS5) Ejegg: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 [23:55:42] (CR) jenkins-bot: [V: -1] Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [23:56:51] dang, zuul's phpunit isn't new enough to support mocking method return values