[00:01:03] oh, glad to hear that will finally be a thing. [00:03:26] guess it's 4.0+ [00:04:50] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1303083 (awight) [00:05:27] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1165770 (awight) [00:06:57] (PS6) Ejegg: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 [00:06:57] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1303092 (awight) [00:08:47] (PS1) Awight: Add Vector skin [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212735 [00:09:31] ejegg: Are you talking about the thing where a mock function can expect calls, or is this actual dependency injection, provided by PHPUnit? [00:10:07] the mock can expect calls (with specified args), and you can tell it what to return [00:10:16] so, sorta-DI! [00:10:33] as long as it's a global you can override :P [00:10:48] 99978... [00:11:08] ejegg: aww. Yeah, that thing. But you have to build DI into your app, even if it's just for tests. [00:11:41] I'd really like the stuff that Python can do, where your unit test class can define a set of replacement classes that will be used any time the code references a real class. [00:13:32] (CR) jenkins-bot: [V: -1] Add Vector skin [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212735 (owner: Awight) [00:14:00] Mmm, that's not good, I'm getting errors from the "mediawiki 1.26alpha updater" on the new fundraising/REL1_25 branch [00:14:10] ruh-roh [00:15:48] ah nvm, it's mwscript stuff specific to mw-vagrant [00:16:02] serious gotcha: you can't run "php maintenance/*" [00:17:15] mwscript maintenance/update.php --wiki paymentswiki [00:17:49] huh... never needed to use mwscript [00:21:04] It's backported from production, and deals with multiwiki setups [00:21:21] ah, cool [00:21:25] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1303115 (awight) [00:26:05] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1165770 (awight) Some things are emitting smoke--the GlobalCollect credit card type buttons do nothing. [00:31:29] (PS2) Awight: Add Vector skin [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212735 (https://phabricator.wikimedia.org/T94528) [00:32:26] (PS1) Awight: Use $.on in place of deprecated $.live [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/212737 (https://phabricator.wikimedia.org/T94528) [00:34:26] (PS1) Awight: Add composer.lock to see if it cures Zuul [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212738 (https://phabricator.wikimedia.org/T94528) [00:34:48] (PS2) Awight: Add composer.lock to see if it cures Zuul [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212738 (https://phabricator.wikimedia.org/T94528) [00:36:00] (CR) jenkins-bot: [V: -1] Add Vector skin [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212735 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [00:38:30] (CR) jenkins-bot: [V: -1] Add composer.lock to see if it cures Zuul [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212738 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [00:54:19] (PS1) Awight: Use $.on in place of deprecated $.live [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212740 (https://phabricator.wikimedia.org/T94528) [00:54:43] (Abandoned) Awight: Use $.on in place of deprecated $.live [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/212737 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [03:12:56] (PS3) AndyRussG: bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) [03:13:48] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [12:50:46] (PS1) Purodha: Message nehacement. [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/212779 [15:14:16] (CR) Ejegg: [C: 2] "Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212740 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [15:14:53] (Merged) jenkins-bot: Use $.on in place of deprecated $.live [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212740 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [15:22:36] ejegg: i've got a schema file for adding the A/B stuff. since you are superuser how would you feel about me updating your default board to be the A/B board so that you can add/remove stuff with the current UI? [15:22:59] just as a stop gap solution [15:23:02] oh sure, that's fine [15:23:21] cool [15:24:17] Hi [15:24:35] We have received some feedback from our readers on OTRS regarding the foundraising [15:24:49] where should I post it/send it so it doesn't get lost? [15:28:26] strainu: if they tried to donate and something screwed up, please forward it to problemsdonating@wikimedia.org [15:28:50] if it's just general feedback, I think donate@wikimedia.org [15:29:12] no, basically they want to donate by phone because we're asking "too much data" [15:29:30] and 2 people want a way to donate specific to Romania [15:31:12] OK, i think donate@wikimedia.org is a good destination for those requests [15:31:50] thanks [16:16:58] (PS3) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [16:17:36] (PS2) Ejegg: WIP More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 [17:41:23] (CR) Ejegg: [C: 2] Merge REL1_23 into fundraising/REL1_23 [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/212727 (owner: Awight) [17:45:53] cwdent: that one: https://gerrit.wikimedia.org/r/#/c/212797/ [17:57:46] (PS4) AndyRussG: bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) [17:58:31] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [18:01:21] (CR) AndyRussG: bannerController.lib: KV store with localStorage (6 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [18:01:51] awight: boo! that one ^ is also ready for another peek NEtime, BTW :) [18:02:02] awesome, thanks! [18:02:15] likewaise! [18:02:22] likewise! [18:02:52] ejegg: I ran into a vendor/ thing when trying the REL1_25 upgrade... [18:03:35] ... you agree we should reuse the mediawiki/core/vendor repo, and name our deployment branch the same as on mw/core ? [18:04:33] Hmm, that might be an annoying solution however, cos we do development in the same mw/core branch as deployment. [18:05:34] oh huh, we can't just check out the same vendor repo in our branch? [18:05:51] oh, the same as core? [18:06:02] Good point! [18:06:22] but, we're still back to developing with a vendor/ submodule conflicting with composer... [18:07:01] hmm [18:08:19] so maybe we make a branch of core/vendor too? No real changes, just keep its revision in step with our 1_25 core branch's composer.lock [18:15:42] bassoon! [18:28:56] (PS4) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [18:39:42] (PS5) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [18:46:13] (CR) Awight: [C: 2] Refactor form resource loading (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [18:49:20] ejegg: What is triple-brace in Mustache? [18:49:53] just doesn't escape html [18:50:01] oh! thx [18:50:22] hehe, /me tries rtfm [18:56:55] (CR) Awight: Copy GlobalCollect form and make it mustache-y (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [18:57:00] (PS5) Awight: Copy GlobalCollect form and make it mustache-y [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [18:57:06] (CR) Awight: [C: 2] Copy GlobalCollect form and make it mustache-y [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [18:57:17] (PS7) Awight: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [18:57:32] (Merged) jenkins-bot: Copy GlobalCollect form and make it mustache-y [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212252 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [19:14:23] (CR) Awight: [C: -1] "Needs a predecessor patch which makes make_safe safe." (9 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [19:21:07] (CR) Awight: bannerController.lib: KV store with localStorage (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [19:31:52] (CR) Awight: "Seems like all the KV stuff with the exception of the storagecontext enum can be generalized, and should be moved into a new js module?" (6 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [19:37:28] AndyRussG: can you assign T98924 to the person you want to review the getContext idea? Krinkle, maybe? [19:39:07] awight: hmmm interesting [19:39:43] I guess we could, but I wouldn't expect him to babysit the whole deploy, just give his opinion on that point... [19:42:58] He seems pretty detached these days [19:50:47] From the spreadsheet it looks like he is in Lyon [19:51:19] Yup [19:51:22] Hmmm [19:52:22] (PS2) Awight: Fix a few values in Engage import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211344 (owner: Ejegg) [19:52:36] (CR) Awight: [C: 2] Fix a few values in Engage import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211344 (owner: Ejegg) [19:53:11] (PS2) Awight: Minor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211338 (owner: Ejegg) [19:54:20] (Merged) jenkins-bot: Fix a few values in Engage import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/211344 (owner: Ejegg) [19:55:03] (CR) Awight: [C: 2] Minor cleanup (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211338 (owner: Ejegg) [19:55:32] (Merged) jenkins-bot: Minor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211338 (owner: Ejegg) [19:55:35] (PS3) Awight: Test a GlobalCollect API response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210406 (owner: Ejegg) [19:57:21] (PS8) Ejegg: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 [19:58:10] (CR) Awight: [C: 2] Test a GlobalCollect API response (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210406 (owner: Ejegg) [19:58:33] (Merged) jenkins-bot: Test a GlobalCollect API response [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210406 (owner: Ejegg) [20:00:14] ejegg: All the patches are merged? https://phabricator.wikimedia.org/T90504 [20:00:36] Waiting for me to review anything? [20:00:44] oh hey, I guess so! [20:01:02] i mean, not waiting, unless there's some logic I forgot to include [20:01:13] I'm confused about all the stuff in CR... [20:01:19] T90505 is still in development? [20:01:44] awight: WRT "/me frowns a very short time, then assumes natural log expression" ... ?? :) [20:01:50] And it looks like AndyRussG's cards are blocked on Krinkle's reattachment [20:02:04] AndyRussG: hehe, I was taking a jab at the single-letter variable [20:02:09] "e" [20:02:12] Ah [20:02:13] Hmm [20:02:20] Well it's like _the_ variable for exceptions, no? [20:02:31] I'm fine, don't worry about me :) [20:02:36] oh, I just need to cherry-pick that settings change out from behind the RapidHtml revert [20:02:46] Hmmmm ;) [20:03:21] I'm just happy that the world moved beyond BASIC, I type egregiously long names whenever possible [20:03:56] I would possibly go with "ex" for that reason, but it's not a blocker, obviously! [20:04:08] Sorry to fling mud ;) [20:08:10] awight: do you want to join Standup? [20:17:58] Hackathon card: https://phabricator.wikimedia.org/T89188 [20:38:52] Ah cucumber [20:39:09] Yea sounds like fun [20:41:42] hehe, I had to look around for cucumbers for a minute [20:43:00] cwdent: fwiw, vagrant/puppet/modules/restbase is spinning up a nodejs app. [20:44:15] ah cool, good base for dash [20:46:52] https://i.imgur.com/gjwu5We.gifv [20:47:17] aww [20:51:38] Sometimes watching a silly animal gif is... priceless... [20:51:45] * AndyRussG turns off internetz [20:53:03] http://sadbastard.org/images/pug13.gif [20:57:05] Tha pathos! [20:57:43] mmm [21:02:45] ejegg: I've started thinking that indexed FIFO queues are not actually a thing... The orphan slayer, for example, should actually be making a query for "time < (now - 30 minutes), which we're simulating in code. [21:03:33] I'd rather spend the time making a Redis store work, cos then we can trivially use ZREVRANGEBYSCORE to get the oldest messages, older than half an hour. [21:03:39] right, but oldest first is still good [21:03:56] oh yeah, sounds good to me! [21:04:29] The only issue is that the redis backend already has the storage type hardcoded... [21:04:29] Forking that feels really silly... [21:04:48] Ahh, and the other thing that makes it not a real pop is that we don't actually want to delete all the ones we fetch [21:05:00] I think we do! [21:05:11] If they can't be rectified after half an hour, they're gonzo [21:05:40] oh, the only ones we leave in are the younglings? [21:05:44] yep [21:05:51] like fishing [21:05:56] well that's cool then [21:06:22] better to lure only the adults than traumatize the fry and throw em back [21:07:02] huh, well the Predis backend already has a switch to change the container type, I guess I can just build that pier out a few more miles... [21:15:19] Check out this scary feature, they say it was built for a car ferry. https://www.google.com/maps/@37.8541357,-122.3358034,2747m/data=!3m1!1e3!5m1!1e4 [21:20:49] bridge to nowhere! [21:22:50] no street view? [21:23:56] There's another good one down here, https://www.google.com/maps/@37.5180192,-122.0964651,3024m/data=!3m1!1e3 [21:24:33] Those are old salt-harvesting pools, and you can semi-illegally walk or bike on the remaining elevated stuff... [21:28:34] aww, Redis's sorted set is wasteful, cos we don't actually care that the values are unique [21:36:26] (PS3) Ejegg: WIP More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 [21:36:28] (CR) jenkins-bot: [V: -1] WIP More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (owner: Ejegg) [21:37:07] (PS4) Ejegg: WIP More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 [21:37:09] (CR) jenkins-bot: [V: -1] WIP More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (owner: Ejegg) [22:02:41] (PS5) AndyRussG: bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) [22:03:28] (CR) jenkins-bot: [V: -1] bannerController.lib: KV store with localStorage [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [22:04:28] (CR) AndyRussG: bannerController.lib: KV store with localStorage (1 comment) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [22:07:46] (CR) AndyRussG: bannerController.lib: KV store with localStorage (5 comments) [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [22:08:54] So, my vagrant issue. If I do vagrant destroy then vagrant up from my existing version, it times out on ==> default: Mounting NFS shared folders... [22:09:11] If I try starting completely from scratch, I'm getting [22:09:11] ==> default: Error: composer install --optimize-autoloader --prefer-dist returned 1 instead of one of [0] [22:09:11] ==> default: Error: /Stage[main]/Crm/Php::Composer::Install[crm-composer]/Exec[composer-install--vagrant-srv-org-wikimedia-civicrm]/returns: change from notrun to 0 failed: composer install --optimize-autoloader --prefer-dist returned 1 instead of one of [0] [22:09:41] Then a bunch of skipping because of failed dependencies warnings [22:10:17] Anyone know what's going on there? [22:12:40] XenoRyet: do you have nfs-kernel-server enabled on the host box? [22:12:55] (CR) AndyRussG: "> Seems like all the KV stuff with the exception of the" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/210408 (https://phabricator.wikimedia.org/T94763) (owner: AndyRussG) [22:12:59] yeah, you must... [22:13:44] Yea, do [22:14:14] XenoRyet: what's the tree-ish of your vagrant/srv/org.wikimedia.civicrm clone? [22:15:51] Tree-ish? [22:16:00] err, the commit ID [22:16:12] * awight dimly recalls English language [22:16:13] * AndyRussG loves that term [22:16:36] It did take me aback the first time I heard it, tho [22:16:55] XenoRyet: try vagrant provision [22:17:03] i had that error the other day and _think_ that's what i did [22:17:06] Tree-ish in that with the commit ID you know exactly which part of the history graph ("tree") you're on [22:17:19] cwdent: ooh, that sounds like I have a missing dependency [22:17:45] Ok, windows guy. What's the best way to find that out? [22:17:58] I did try vagrant provision, I think same thing happens [22:18:20] that wascold. [22:18:39] by the way I might draw baby aggro at any moment here [22:18:51] I meant I'm the windows guy, I don't know how to do it yet ;-) [22:18:57] :) go to vagrant/srv/org.wikimedia.civicrm and 'git log -1' [22:19:31] commit be08b16c5d0959b6484edfea2c9d38c4c84f84bc [22:19:31] Author: Adam Roses Wight [22:19:31] Date: Mon May 4 12:09:34 2015 -0700 [22:19:43] THAT fucking guy [22:19:52] lol [22:21:02] well it's not totally up to date, but that shouldn't make a difference. [22:21:27] Weird though, I just cloned the whole thing last night. [22:22:08] I guess the next commit was early this morning :) [22:22:19] It won't affect your composer issue, though [22:22:40] can you do turn on the puppet debugging and paste me the line right before the composer failure? [22:22:58] You can actually vagrant ssh into the VM and try running that line to get the output [22:23:07] * awight destroys box [22:24:52] Composer could not find a composer.json file in /home/vagrant [22:24:52] To initialize a project, please create a composer.json file as described in the https://getcomposer.org/ "Getting Started" section [22:25:30] (PS6) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [22:25:32] (CR) jenkins-bot: [V: -1] Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [22:25:34] That seems weird [22:25:47] yeah, cwd issue [22:26:03] try: cd /vagrant/srv/org.wikimedia.civicrm [22:26:33] from inside the vagrant box, or back on host machine? [22:26:50] in the VM [22:26:59] then run the composer commandline there [22:27:56] windows blind spot again, what's the command for that? [22:28:38] got to the directory, just don't know the command to run [22:28:52] XenoRyet: oh wow, I reproduced something really weird, [22:28:53] ==> default: Notice: /Stage[main]/Php::Composer/Exec[update_composer]/returns: [Fri May 22 22:28:23 2015] [hphp] [25905:7f228a154d00:0:000001] [9d6791:7ca880:7f2281ce9ec5:7c9c69] Uncaught exception: Could not open extension /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/fss.so: /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/fss.so: cannot open shared object file: No such file or directo [22:28:59] ry [22:29:17] (PS7) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [22:29:32] the command to run is whatever you found by running "PUPPET_DEBUG vagrant provision", probably something like "composer update", I'm hoping? [22:30:49] right, ok [22:31:15] XenoRyet: yeah looks like your command is "composer install --optimize-autoloader --prefer-dist" [22:31:21] looks like it ran. Got some warnings but no errors [22:31:36] ugh [22:31:43] My failure was slightly different [22:32:01] hmm [22:33:58] Sorry, dishes + kid attack [22:34:53] no worries, got a kid demanding attention here as well [22:37:43] (PS9) Ejegg: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 [22:38:34] XenoRyet: the fun's just beginning! [22:39:30] (PS8) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [22:40:18] Went to get some food but the internet is garbage here [22:42:25] cwdent|phone: I know the feeling... [22:45:20] (PS9) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [22:47:30] (CR) Ejegg: "Sorry, rebase mess. PS6 addressed the minor comments from PS5 - 7,8,9 just rebase it to the right place after a screwup." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [22:51:20] The fun thing about Eclipse is that now I can get a decent call stack, like I always could before in Java... [22:53:51] (PS5) Ejegg: More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 [22:54:16] netbeans does that OK too. [22:54:52] But there's an annoying bug with the UI when it's maximised in whatever gnome 3 is running on my deb box [22:56:24] ok folks, i'm heading to the show. Probably be on over the weekend some to check in on the hackathon. [22:56:28] Good evening, all! [23:16:13] phew my debug settings survived the Eclipse upgrade! [23:23:39] (CR) AndyRussG: CentralNotice uses content rather than interface language (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) (owner: Awight)