[00:03:16] <grrrit-wm>	 (PS1) AndyRussG: Clean cruft in CNBannerChoiceDataResourceLoaderModule::getChoices() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/212834
[01:51:46] <grrrit-wm>	 (CR) AndyRussG: "This is already done... Thanks and apologies for leaving this and not seeing it at a timely time!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/181237 (owner: Awight)
[05:44:12] <grrrit-wm>	 (CR) Awight: CentralNotice uses content rather than interface language (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/197741 (https://phabricator.wikimedia.org/T53475) (owner: Awight)
[09:49:28] <awight>	 K4-713: It's so wrong that I can say this.  but "hi"
[09:49:40] <awight>	 Can I help with brave new world?
[09:49:48] <K4-713>	 omg... your timing is amazing.
[09:49:58] <awight>	 <_<
[09:50:09] <K4-713>	 By that I mean I just spent an hour grumbling at comoser.
[09:50:10] <awight>	 Hopefully you're at the beginning of your rope and not the end
[09:50:11] <K4-713>	 er. Composer.
[09:50:18] <awight>	 oh
[09:50:23] <awight>	 confuser
[09:50:26] <awight>	 sorry
[09:50:31] <awight>	 yeah we need some serious release notes
[09:50:31] <K4-713>	 Ah... so, finally I got the thing to stop complaining about monolog, and... funny story.
[09:50:36] <K4-713>	 SRSLY.
[09:50:40] <K4-713>	 Funny other story.
[09:51:08] <K4-713>	 I just commented out all my localsettings about donationinterface aside from the include statement...
[09:51:13] <awight>	 yep
[09:51:15] <K4-713>	 ...and the GC form still loads.
[09:51:19] <awight>	 totally
[09:51:26] <K4-713>	 Is that not incredibly bad?
[09:51:32] <awight>	 nah it's fine?
[09:51:35] <K4-713>	 Default for everything in DI should be fail closed.
[09:51:51] <awight>	 It hasn't been that way.... as long as I know
[09:51:52] <K4-713>	 I can set it to being disabled, and that works...
[09:52:00] <K4-713>	 Ah, it should have been that way forever.
[09:52:03] <awight>	 yes--I did that two weeks ago!
[09:52:11] <K4-713>	 okay.
[09:52:12] <awight>	 it used to be impossible to disable...
[09:52:17] <K4-713>	 uh
[09:52:22] <K4-713>	 No, because pfp...
[09:52:34] <K4-713>	 Used to be a ghost with us for a long time.
[09:52:41] <awight>	 but lemme see, sorry if I'm repeating things you already figured out by brute force
[09:52:56] <K4-713>	 Hang on.
[09:52:58] <awight>	 * move all DI localsettings config to after the require statement
[09:53:00] <K4-713>	 Let me explain my reasoning.
[09:53:09] <awight>	 * run "composer update" from DI directory
[09:53:13] <awight>	 (i'm listening :)
[09:53:47] <K4-713>	 We want to make it necessary to enable things (instead of explicitly disable) because Other People.
[09:53:47] <awight>	 * get a new fundraising/REL1_23 core branch, to deal with formsettings thing.  no longer require that explicitly.
[09:54:26] <awight>	 that's fine, just tweak the defaults in DonationInterface.php and don't forget to add the config on the payments cluster
[09:54:40] <K4-713>	 If we genuinely want Other People to use this ever, we don't want to auto-enable all the gateways we support. Also, with any luck, we'd be Other People soon ourselves and not have accounts with things that Other Other People want.
[09:54:48] <awight>	  /names <-- um where is the crowd? :p
[09:54:58] <awight>	 yes!  I totally agree
[09:55:06] <K4-713>	 BUT!
[09:55:21] <K4-713>	 If we're running in dev mode, the fakeness that doesn't exist yet should come alive.
[09:56:02] <K4-713>	 Also: Composer question.
[09:56:11] <K4-713>	 Are you running composer stuff on boron?
[09:56:14] <K4-713>	 Or...
[09:56:18] <K4-713>	 .
[09:57:13] <awight>	 I think I agree with the dev mode thing, everything is off to start with.  when you enable a gateway with no creds, it works but in test mode.  adding the creds transparently makes things work for real.  Something about test vs prod accounts, here.
[09:57:32] <awight>	 no, ejegg|away and I decided to do the composer thing pretty much the same way as in WMF deployment
[09:57:55] <K4-713>	 I guess I don't know how that works either.
[09:58:01] <awight>	 the dev branch of DI has no vendor/ dir and you have to update manually.  But it has composer.json and composer.lock, so we all have the same versions.
[09:58:02] * K4-713 thumbs up
[09:58:11] <K4-713>	 ...
[09:58:16] * K4-713 frowns, drops thumbs
[09:58:22] <awight>	 however, the DI deployment branch includes a fully stocked vendor/ submodule
[09:58:40] <K4-713>	 OH.
[09:58:45] <K4-713>	 THAT MAKES MORE SENSE.
[09:58:55] <awight>	 I'm not thrilled, but we wanted to be consistent with other jankiness
[09:59:03] <K4-713>	 blurf.
[09:59:03] <K4-713>	 okay
[09:59:29] <K4-713>	 buh, plans.
[09:59:29] <awight>	 It's already come home to roost, today I realized that the 1.25 core upgrade is suddenly annoying, cos our fundraising branch is both dev and deployment.
[09:59:38] * K4-713 squints
[09:59:42] <K4-713>	 okay
[09:59:45] <awight>	 so the vendor/ strategy doesn't really work for us
[09:59:48] <K4-713>	 Ah, we're like one minute from lunch.
[10:00:11] <K4-713>	 And the wifi keeps freaking bouncing.
[10:00:23] <awight>	 on the flip side, we no longer require any core hacks, so fundraising/* is really just a deployment branch now
[10:00:31] <K4-713>	 guh
[10:00:42] <K4-713>	 Did you get my statement about the AWFUL WIFI, or did it get eated?
[10:00:53] <awight>	 I think I'm getting all yr statements
[10:00:59] <K4-713>	 okay
[10:01:03] <K4-713>	 well... eats time.
[10:01:05] <awight>	 just |fud or whatever and I'll get the hint
[10:01:06] <awight>	 ok!
[10:01:20] <K4-713>	 Are you going to be doing things?
[10:01:23] <awight>	 hell no.
[10:01:28] <K4-713>	 bahaha, okay.
[10:01:38] <K4-713>	 After lunch, I'm going to work on refactoring config settings.
[10:01:42] <awight>	 I'm embarrassed to explain why I'm up at this hour, but... learning how to publish a Debian package.
[10:01:48] <awight>	 awesome.
[10:02:01] <K4-713>	 And... coming up with some obnoxious indicator that you're running a gateway in local dev mode, that explains exactly how to change it to work for realz.
[10:02:06] <awight>	 all I can add there is, remember they all go after the require_once DI.php
[10:02:11] <K4-713>	 yep
[10:02:13] <awight>	 cool
[10:02:16] <awight>	 very cool
[10:02:19] <K4-713>	 I have nuked all DI localsettings locally.
[10:02:23] <K4-713>	 Well... commented.
[10:02:39] <K4-713>	 Functionally equivalent to nuke.
[10:02:44] <awight>	 good luck getting a veg sandwich
[10:02:50] <K4-713>	 Heh. Thanks.
[10:02:53] <awight>	 noon, I see
[10:03:03] <K4-713>	 aye
[10:03:03] <K4-713>	 ...kbye.
[11:12:15] <awight>	 Any other exciting discoveries in the fossil sediment?
[11:12:43] <awight>	 K4-713: ^
[11:21:21] <K4-713>	 huh
[11:21:27] <K4-713>	 I was going to say things.
[12:12:58] <grrrit-wm>	 (PS2) Siebrand: email -> email address [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/212779 (owner: Purodha)
[12:13:13] <grrrit-wm>	 (CR) Siebrand: [C: 2] "i18n/L10n reviewed." [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/212779 (owner: Purodha)
[12:13:24] <grrrit-wm>	 (Merged) jenkins-bot: email -> email address [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/212779 (owner: Purodha)
[13:31:33] <grrrit-wm>	 (PS1) Katie Horn: Odd untranslated label issue in zipcode title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212915
[13:35:34] <grrrit-wm>	 (CR) Katie Horn: "...argh. I believe I have just demonstrated how the changes managed to pass. It burns. Also there are more issues of this nature; I was ho" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212915 (owner: Katie Horn)
[15:28:00] <grrrit-wm>	 (CR) Ejegg: "PS8: updated make_safe, used $ for appeal placeholders, added tests for appeal override. PS9: rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg)
[16:40:05] <awight>	 That's weird indeed.
[16:40:11] <K4-713>	 ohai
[16:40:15] <K4-713>	 I have another problem.
[16:40:48] <K4-713>	 I got to a point where I started disabling things in DI by default, and predictably, all the tests broke.
[16:41:04] <K4-713>	 The thing I wasn't expecting (but maybe I should have been) is that I can only unbreak half of them.
[16:41:21] <K4-713>	 In other words, it looks like the disabling of pieces is not working the way we think it is.
[16:41:34] <K4-713>	 It certainly isn't in the tests.
[16:41:55] <grrrit-wm>	 (CR) Awight: [C: 2] Odd untranslated label issue in zipcode title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212915 (owner: Katie Horn)
[16:42:22] <grrrit-wm>	 (Merged) jenkins-bot: Odd untranslated label issue in zipcode title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212915 (owner: Katie Horn)
[16:42:37] <K4-713>	 awight: So, I'm trying to think of a good way to write a test in which we assert that nothing is there when we initialize mediawiki with nothing good enabled in DI.
[16:42:39] <awight>	 On the first thing ^, did you ever figure out why the tests pass?
[16:42:42] <K4-713>	 ...without breaking all the mess.
[16:42:43] <K4-713>	 And, no.
[16:43:00] <K4-713>	 Same state as when I sent the email.
[16:43:17] <awight>	 For the nothing test, in theory it's just $this->setMwGlobals and set everything to disabled...
[16:43:25] <awight>	 gack
[16:43:31] <K4-713>	 okay
[16:43:37] <K4-713>	 I'll... see what I can do with that.
[16:43:41] <K4-713>	 Thanks. :)
[16:43:45] <K4-713>	 Oh wait.
[16:43:56] <K4-713>	 The problem is, those globals control things being mapped to other things.
[16:44:01] <K4-713>	 So, if they've already been defined...
[16:44:06] <K4-713>	 ...how to undefine?
[16:44:09] <K4-713>	 Can't unload classes.
[16:44:22] <awight>	 You shouldn't have to go as low-level as the autoloader
[16:44:30] <K4-713>	 orly?
[16:44:43] <K4-713>	 How else to make sure it's not there, though?
[16:44:46] <awight>	 Nothing switches on class_exists
[16:44:58] <K4-713>	 hmmm
[16:45:05] <awight>	 I think it's just the form whitelists
[16:45:10] <K4-713>	 Urgh.
[16:45:19] <K4-713>	 But, not for things like minfraud.
[16:45:25] <K4-713>	 Things that are not gateways.
[16:45:26] <awight>	 and those happen in a hook now, in response to the globals.  That's how I undid the pre/post configuration mess
[16:45:37] <K4-713>	 hurm
[16:45:41] <awight>	 for minfraud, it's whether a wgHook is defined
[16:45:45] <awight>	 see...
[16:45:47] <K4-713>	 Defined.
[16:46:01] <awight>	 $wgExtensionFunctions[] = function() {
[16:46:03] <awight>	 etc
[16:46:05] <K4-713>	 So, if a test runs that uses it... and then the "nothing" test runs, wouldn't that always fail?
[16:46:29] <awight>	 btw, I have a kid and no parental backup for maybe 15 min
[16:46:42] <K4-713>	 That's okay. Supposedly there's dinner or something before we all die.
[16:47:05] <awight>	 I donno how that extensionfunctions thing interacts with tests
[16:47:11] <awight>	 sounds like a serious screwup, though
[16:47:16] <K4-713>	 I'm gonna find out.
[16:47:16] <awight>	 still a snowflake
[16:47:35] <K4-713>	 And then I'm probably going to run up a tree and throw rocks at people.
[16:48:43] <awight>	 That sounds like a good nitetime activity
[16:49:05] <K4-713>	 Totally.
[16:49:15] <awight>	 qrqbbbnbbbbnbnewqq42342q3434ee333344
[16:49:16] <awight>	 -mari
[16:49:42] <K4-713>	 :D
[16:50:17] <K4-713>	 Okay, I'm out for a while. Thanks for the merge.
[16:50:21] <K4-713>	 So... odd.
[16:50:22] <awight>	 k then
[16:50:35] <awight>	 I'll peek at the remaining snowflakiness if I can
[16:50:42] <K4-713>	 Rad, thanks.
[18:16:19] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, Wikimedia-Hackathon-2015, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188#1305575 (awight)
[18:16:20] <wikibugs>	 Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, and 2 others: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1305573 (awight) Resolved>Open
[18:17:27] <wikibugs>	 Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, and 2 others: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1164463 (awight) Solving a different way--@K4-713  points...
[20:58:34] <grrrit-wm>	 (PS1) Awight: WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477)
[20:58:58] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight)
[21:54:26] <grrrit-wm>	 (PS2) Awight: WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477)
[21:55:04] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight)
[22:03:31] <grrrit-wm>	 (PS3) Awight: WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477)
[22:03:57] <grrrit-wm>	 (CR) jenkins-bot: [V: -1] WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight)
[22:18:08] <grrrit-wm>	 (PS4) Awight: Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477)
[22:18:21] <grrrit-wm>	 (PS5) Awight: Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477)
[22:19:35] <wikibugs>	 Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, and 2 others: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1305816 (awight) a:awight>K4-713
[22:22:23] <wikibugs>	 Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface, and 3 others: DonationInterface config should be less of a snowflake - https://phabricator.wikimedia.org/T94477#1305818 (awight)
[22:35:20] <grrrit-wm>	 (PS2) Awight: WIP / DO NOT MERGE - GC WX audit module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/199653 (owner: Katie Horn)