[08:42:54] (CR) Katie Horn: "Dang, dude. This is great. Just a couple comments, which probably reflect me getting lost in the bigness." (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [09:10:21] (CR) Katie Horn: "Gah, one more thing." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [10:31:18] (PS6) Awight: Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) [10:34:32] fundraising-tech-ops, Hackathon-Mexico-City-2015, Wikimedia-Hackathon-2015: overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508#1306500 (Jgreen) [10:49:18] (CR) Awight: "I didn't see many opportunities for splitting this patch up, most of these changes have to be made together. I'll try to make the next pa" (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [10:55:37] (PS7) Awight: Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) [11:32:18] (PS8) Awight: Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) [11:32:20] (PS1) Awight: Be consistent about forms whitelisting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213239 [11:32:22] (PS1) Awight: Add some new (UNUSED) globals that will toggle gateway availability [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213240 [11:32:24] (PS1) Awight: WIP try to fix a weird testing thing that exposes bug [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213241 [11:32:26] (PS1) Awight: red pen stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213242 [11:32:28] (PS1) Awight: Validate gateway first [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213243 [11:32:51] (CR) jenkins-bot: [V: -1] Be consistent about forms whitelisting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213239 (owner: Awight) [11:32:57] (CR) jenkins-bot: [V: -1] Add some new (UNUSED) globals that will toggle gateway availability [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213240 (owner: Awight) [12:11:48] (PS1) Alex Monk: Add extension.json, empty old PHP entry point [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/213255 (https://phabricator.wikimedia.org/T88050) [12:13:37] Fundraising Tech Backlog, MediaWiki-extensions-General-or-Unknown, Patch-For-Review: Convert FundraisingTranslateWorkflow to use extension registration - https://phabricator.wikimedia.org/T88050#1306727 (Krenair) a:Krenair [12:52:44] (CR) Katie Horn: [C: 2] Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [12:52:52] K4-713: boo! How's hacking en France? [12:52:55] whoa [12:53:03] awight: boo also! [12:53:04] Aaa! [12:53:19] heh [12:53:20] hi! [12:53:34] It's pretty great. But I'm rusty as hell and it's kind of embarrassing. [12:53:42] Though, not really surprising. [12:53:51] I could talk a budget to death. [12:53:56] (PS2) Awight: Build special page with the correct case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213241 [12:53:57] (PS2) Awight: Add some new (UNUSED) globals that will toggle gateway availability [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213240 [12:53:59] (PS2) Awight: Be consistent about forms whitelisting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213239 [12:54:41] (PS9) Awight: WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) [12:55:04] (CR) jenkins-bot: [V: -1] WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [12:55:32] It is funny how different modes of thought get used to being used or not... glad you've got the opportunity get away from budgets for a while :) [12:55:43] Yeah don't ask me to write a new chapter of my thesis right now [12:55:56] Anything I can contribute to/help with, BTW? [12:56:40] Heh. Good question. [12:57:03] Ah, I feel like we need a ton of phpunit tests surrounding configuration options. [12:57:19] Hmm that sounds fun :) [12:58:39] ommfg I found the issue, I had put one of those setMwGlobals calls in a test constructor rather than setUp(). [13:01:53] d'oh! [13:02:00] AndyRussG: ...really? [13:02:18] No, that can't be right. "fun" is a different thing. :p [13:02:34] It's all relative. [13:03:23] awight: dood, how many patches do you have out right now, for the config stuff? [13:03:43] Or, I suppose, whatever https://gerrit.wikimedia.org/r/#/c/213003/ split in to. [13:05:33] agh, what just happened. [13:05:51] Did you upload a new patch set after I +2'd the other one, but before jenkins could... [13:05:53] Yes. [13:06:54] * awight sets to self-destruct in 10 [13:08:39] awight: Should I leave it alone, now that it's all... failing and stuff? :p [13:10:03] (PS3) Awight: Add some new (UNUSED) globals that will toggle gateway availability [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213240 [13:10:05] (PS10) Awight: WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) [13:10:07] K4-713: the predecessors are redy to go [13:10:15] * awight looks around for the "a" [13:10:30] (CR) jenkins-bot: [V: -1] WIP Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [13:10:57] oic. I was going backwards. [13:11:17] K4-713: heads-up, I'm not gonna add all the extra safety interlocks to"night" [13:11:30] no worries. [13:12:36] (CR) Katie Horn: [C: 2] Build special page with the correct case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213241 (owner: Awight) [13:13:00] (Merged) jenkins-bot: Build special page with the correct case [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213241 (owner: Awight) [13:13:35] K4-713: i put the formchooser getAll method back together the way it was... [13:13:36] (PS2) Katie Horn: red pen stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213242 (owner: Awight) [13:14:11] okay [13:15:01] omgoodness, I can make the formchooser testgetall only doable in local dev mode now. [13:15:09] And it makes freaking sense, because it's all in DI now. [13:15:21] :] [13:15:46] Oh, also: We should kill the formsettings file in core. :) [13:17:00] (CR) Katie Horn: [C: 2] red pen stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213242 (owner: Awight) [13:17:02] I did [13:17:21] (Merged) jenkins-bot: red pen stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213242 (owner: Awight) [13:17:25] (PS11) Awight: Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) [13:17:32] K4-713: ^^ that one [13:17:55] hr? [13:18:06] PS11 is the final answer? [13:20:50] (CR) Katie Horn: [C: 2] Be consistent about forms whitelisting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213239 (owner: Awight) [13:21:15] (Merged) jenkins-bot: Be consistent about forms whitelisting [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213239 (owner: Awight) [13:22:17] (PS1) Awight: Rebrand WorldPay -> Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213269 [13:22:41] (CR) jenkins-bot: [V: -1] Rebrand WorldPay -> Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213269 (owner: Awight) [13:22:42] K4-713: yep, I think it's good with the exception of extra safety checking [13:22:51] (PS2) Katie Horn: Validate gateway first [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213243 (owner: Awight) [13:23:03] (CR) Katie Horn: [C: 2] Validate gateway first [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213243 (owner: Awight) [13:23:33] (Merged) jenkins-bot: Validate gateway first [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213243 (owner: Awight) [13:24:10] This next deploy is going to be a bear. [13:25:04] (PS2) Awight: Rebrand WorldPay -> Worldpay [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213269 [13:25:18] cherry-picking days are gone [13:25:34] ejegg|away has some treats queued up, too :) [13:26:08] :) [13:26:15] you mean the mustache stuff? [13:26:16] hey waitaminute it's Sunday [13:26:31] what'r these ppl doing up? [13:26:32] (CR) Katie Horn: [C: 2] Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [13:26:57] ejegg: oh! right, you stealth deployed the bulk of the refactoring [13:27:19] yah, with unexpectedly zero consequence [13:27:36] WHY ARE WE ALL WORKING. [13:27:39] :p [13:27:48] ...but seriously. [13:27:52] whoa, worldpay no longer CamelCase? [13:27:53] you should do this next deployment, while your third eye is smiling :p [13:28:17] ejegg: apparently it wasn't, then was, then wasn't again, all before we considered signing a contract with them :) [13:28:21] ok friends [13:28:22] bye [13:28:24] just gotta placate the right loas [13:28:30] P_p [13:29:37] ejegg: What are you doing hanging around? [13:29:50] just taking a peep at the hackathon doings [13:30:08] Aha. Well, I think I finally get to do the hacking part. [13:30:21] I spent a lot of time yesterday looking at config problems and going "oh no". [13:30:32] Then awight fixed pretty much everything I didn't get to. [13:30:37] Is our phishing website^W^W mock processor ready yet? [13:30:43] haha, no. [13:30:44] But. [13:30:50] That's totally the fun part. [13:31:05] Also, I have already admitted several times that I am so rusty I'm squeaking. [13:31:10] And it's embarrassing. [13:31:21] But... only one way to unrust. [13:31:24] Bet it feels good to be back in the code! [13:31:30] It does, yes. [13:31:50] Even if the only thing I've actually git reviewed so far was a basic find and replace job. [13:32:02] ...it took a while to figure out what the heck was going on. [13:32:24] ehh, i'm just glad to have your eyes on all the wierdness we've been up to [13:32:34] Yeah, this is fun. [13:32:36] who knows what we've missed [13:32:40] :D [13:32:48] I think it's mostly what *I* missed. [13:32:49] But. [13:33:00] There's this totally mysterious thing that was going on that I'm still not sure about. [13:33:09] I caught a problem, running phpunit locally yesterday. [13:33:13] oh? [13:33:21] And it was something that production jenkins should have run and failed on. [13:33:23] with the forms and translation? [13:33:27] A problem that made it to the payments cluster. [13:33:36] I still don't know why those tests didn't fail. [13:33:38] ooh... dassa no good [13:33:42] Yeah, totally. [13:33:57] It was basically a typo in a whole bunch of templates. [13:34:10] ...a typo in a translation label. [13:34:17] Huh. I mean, I saw how the just-html-change didn't run phpunit. But the rest of the changes do... [13:34:19] It was causing a thing to be not translated. [13:34:38] Yeah, exactly. And all the ones in master lately were not html only. [13:34:52] That's totally mysterious and should have caused a small fire. [13:35:08] So, why did it take me running the thing at the command line, locally? [13:35:11] Odd. [13:35:22] Makes me wonder if prod jenkins is running all the tests we think it is. [13:35:43] I mean, it usually doesn't say much about exactly what it's up to unless an assert fails. [13:35:43] is zuul's i18n setup subtly different enough to swap out some messages or something? [13:35:58] hrm [13:36:10] I guess we could do a test commit asserting that true is false inside the test in question. [13:36:22] That would at least tell me that it's... you know: running. [13:37:37] okay, I'm going to rejoin the world. I've been doing CR in my hotel room to escape distraction while awight was still awake. [13:37:49] Now I can be as distracted as I want. [13:37:50] :D [14:02:44] baha, oops. [14:02:49] Something went nuts. [14:05:03] ? [15:03:18] (CR) Katie Horn: [C: 2] Add some new (UNUSED) globals that will toggle gateway availability [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213240 (owner: Awight) [15:08:25] (CR) Katie Horn: "I said +2." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [15:08:27] (Merged) jenkins-bot: Add some new (UNUSED) globals that will toggle gateway availability [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213240 (owner: Awight) [15:08:29] (Merged) jenkins-bot: Make configuration testable [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/213003 (https://phabricator.wikimedia.org/T94477) (owner: Awight) [15:52:14] (PS1) Parent5446: Updated extension registration to new system [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903) [15:52:24] (CR) jenkins-bot: [V: -1] Updated extension registration to new system [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903) (owner: Parent5446) [16:18:20] (CR) Parent5446: Updated extension registration to new system (1 comment) [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903) (owner: Parent5446) [16:28:43] (PS2) Parent5446: Updated extension registration to new system [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/213315 (https://phabricator.wikimedia.org/T87903)