[00:00:05] How much should we say? "This payment processor is kaput, please return to donate.wmo and try again? [00:02:38] Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Bad gateway error should be more helpful - https://phabricator.wikimedia.org/T100584#1316226 (awight) NEW [00:02:39] Ah... I don't think we should add a ton about how soon to try again. [00:02:48] Maybe something about contacting problemsdonating. [00:02:56] And trying again "later". [00:03:09] or heh let's just redirect to the payments error page. [00:03:09] What about the one that's already in there? [00:03:11] :) [00:03:11] ...yes. [00:03:12] That. [00:03:37] Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Bad gateway error should be more helpful - https://phabricator.wikimedia.org/T100584#1316233 (awight) [00:03:38] noted [00:04:05] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Bad gateway error should be more helpful - https://phabricator.wikimedia.org/T100584#1316226 (awight) [00:04:13] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface: Bad gateway error should be more helpful - https://phabricator.wikimedia.org/T100584#1316226 (awight) [00:07:13] Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: "Uncommitted DB writes" errors are getting creepy - https://phabricator.wikimedia.org/T100585#1316240 (awight) NEW [00:10:50] (PS1) Awight: Redirect to failure page when the gateway is disabled [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214272 (https://phabricator.wikimedia.org/T100584) [00:11:33] I don't know whether "invaluable gift" is an appropriate thing to say about my $1.02 donation... [00:13:35] huh [00:19:42] (CR) Awight: [C: 2] Quit wasting translators' time with test pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214263 (owner: Ejegg) [00:20:21] (Merged) jenkins-bot: Quit wasting translators' time with test pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214263 (owner: Ejegg) [00:21:44] (PS1) Katie Horn: WIP - Local Dev Mode. DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214273 [00:22:05] OH GOOD. My topic made it. [00:22:08] (CR) jenkins-bot: [V: -1] WIP - Local Dev Mode. DO NOT MERGE [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214273 (owner: Katie Horn) [00:22:23] ...I keep forgetting that branch names make it to Places. [00:22:52] awight: Bored? ^^ [00:23:03] I mean, obvs I don't want that to get merged. [00:23:04] But. [00:23:14] Eyeballs. [00:23:36] For a sort of general direction kind of thing. [00:24:54] woot! [00:25:21] I... don't know what kind of terrible monster I want to get written for constructing responses. [00:25:37] But, it's got to be at least basilisk level. [00:26:03] My instinct is, as static as possible [00:26:10] eeeeyes.... [00:26:15] with a tiny thing which does orderid munging. [00:26:27] I may steal some of the crap I wrote for constructing requests. [00:26:39] That was very cool [00:26:39] ...oh. [00:26:41] Oh no. [00:26:46] I just had the most terrible idea. [00:27:03] Just... a new gateway. [00:27:03] >.< [00:27:08] noo? [00:27:18] Only backwards. Same exact everything. [00:27:28] noo! [00:27:28] ...ow. [00:27:31] no no nononon [00:27:32] no [00:27:32] Ow ow ow [00:27:50] I'm wondering what would explode if I tried to do that. [00:27:50] how about the other thing u said... very much like the test fixtures [00:27:54] I would explode [00:28:12] That would be unfortunate. [00:28:15] actually, there's a Paradise Lost scene which is perfect for this [00:28:39] I keep gravitating toward matter / antimatter sorts of reactions. [00:29:17] "This is exactly what we need! ...if only matter had all the opposite properties we're used to." [00:29:30] Still, though. [00:29:41] I could hella write evil gateway children. [00:29:51] eeeeeevil. [00:30:03] I'd make totally sure every one had a goatee for easy identification. [00:30:41] http://www.dartmouth.edu/~milton/reading_room/pl/book_1/text.shtml [00:31:06] I feel like you're trying to tell me something. [00:31:29] I guess it's not a single line I can point to, but all the exiled angels basically create an inverted church and hold a city hall of hell, pandemonium [00:31:31] "hideous ruine and combustion" [00:31:35] SO GOOD [00:31:46] The heaven parts are unbearably boring though [00:31:51] Yeah. That. That's exactly what I need to do for Local Dev Mode. [00:31:55] Please don't send me there [00:32:15] 'sokay. I'll take this one. [00:32:18] :p [00:32:20] It's all really amazing blind guy imagery [00:32:32] "obdurate pride" [00:32:35] Points. [00:32:38] So many points. [00:32:56] I can see the beautiful steeple of donationinterface, actually supported by a horrid labyrinth of golden demons beneath the surface [00:33:24] gwahaha [00:34:03] * K4-713 coughs [00:34:47] And with that, I think I'm going home to maybe sleep totally early. [00:34:54] Or... wait. [00:34:56] Pigs. [00:34:58] good luck catching up! [00:34:58] oh [00:35:14] Yeah, that's a thing. [00:35:39] I believe I will go home, and await your instructions. [00:35:43] Heh. [00:35:57] mmm ok, I'll leave now then so I can deliver earlyish [00:36:26] wooooo [00:36:44] ...kbye [00:50:43] awight: anything you need reviewed? [00:51:12] oh, i should bang on your 1.25 merge [00:52:45] sure! [01:00:47] (CR) Awight: "This is a great idea! Mostly minor comments, but I think we should use something other than SpecialPage for the endpoint." (16 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214273 (owner: Katie Horn) [01:03:20] see ya! [01:06:21] (PS3) Ejegg: WIP Astropay Listener [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/207526 (https://phabricator.wikimedia.org/T90506) [01:51:04] (PS1) Ejegg: Fix Mustache l10n array-to-string warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214285 [01:52:05] (PS2) Ejegg: Fix Mustache l10n array-to-string warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214285 [02:06:26] (PS1) Ejegg: WIP validate stuff [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) [04:59:08] Fundraising Sprint Kraftwerk, MediaWiki-extensions-CentralNotice, Documentation: CN documentation: review status quo and write a new overview - https://phabricator.wikimedia.org/T99011#1316676 (AndyRussG) Updated the following pages: https://www.mediawiki.org/wiki/Extension:CentralNotice https://meta.... [04:59:36] Fundraising Sprint Kraftwerk, MediaWiki-extensions-CentralNotice, Documentation: CN documentation: review status quo and write a new overview - https://phabricator.wikimedia.org/T99011#1316677 (AndyRussG) Open>Resolved [05:12:38] AndyRussG: Hi? [05:12:58] Glaisher: hi! [05:13:09] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/WMAR_Encuentro_de_Tandil [05:13:17] Do you know why the text is not appearing there? [05:13:20] when you preview it [05:14:09] Hmm checking [05:14:30] hmm [05:14:31] Glaisher: it appears for me [05:14:31] It works now.. [05:14:33] weird [05:14:35] yeah [05:14:49] It was working about two minutes ago and then disappeared [05:14:58] and it's appearing now! [05:15:19] Glaisher: earlier today I heard rumours of some outages [05:15:43] Maybe there was a problem with one of the background calls to get the CentralNotice Javascript or the banner content? [05:16:50] That's all that comes to mind just now... [05:16:59] I've no idea. [05:18:12] AndyRussG: https://meta.wikimedia.org/wiki/Special:GlobalAllocation is also broken :( [05:18:24] I did file a bug about this one [05:19:02] If you're worried about that banner, every time before you check it, you could open the network tab in the browser developer tools. Then if any background requests return an error, at least you'll see it. [05:19:44] WRT Special:GlobalAllocation, yes, I know, it's quite sad. I worked on that a bit as one of my first CentralNotice tasks. However it's a doozie and is not prioritized right now, I'm afraid [05:20:22] It works intermittently but depending on what campaigns are up, it'll die on an out of memory error [05:21:28] A bigger priority is getting a real CentralNotice roadmap. Then seeing what architectural changes may happen. Then we could see what the best route would be to provide a global overview of what campaigns and banners are up. [05:21:53] Anyway that's my 2 cents WRT priorities with our limited resources... [05:22:42] Glaisher: if it's important to you that S:GA (or something comperable) start working quite soon, please feel free to say so on the bug or anywhere else, of course... [05:23:26] CN priorities tend to be driven quite a lot by fundraising these days, and also by concerns about CN's effects on overall site performance [05:23:47] AndyRussG: It's not that high priority but I would like to see that getting fixed. [05:24:34] Glaisher: maybe you'd have some thoughts on a better replacement for it, too? (Fixing it might be the equivalent amount of work...) [05:24:55] Glaisher: I have to run in a few minutes, it's past my bedtime here ;p [05:25:36] Good night! [05:28:07] Glaisher: 'night! Sorry to run off, please feel free to ping NEtime :) [05:28:28] OK and thanks! :) [10:01:56] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs - https://phabricator.wikimedia.org/T100637#1317097 (hashar) NEW a:awight [10:16:18] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs - https://phabricator.wikimedia.org/T100637#1317117 (hashar) Example console: ``... [10:47:56] (CR) Hashar: "The extensions tests are broken because they use the master branch instead of REL1_25. T100637" [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212731 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [10:48:08] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs - https://phabricator.wikimedia.org/T100637#1317187 (hashar) a:awight>hashar [10:48:38] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs - https://phabricator.wikimedia.org/T100637#1317097 (hashar) p:Triage>Unbre... [10:50:18] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Browser-Support-Google-Chrome, Patch-For-Review: Multiselects in Special:CentralNotice sometimes load incorrectly - https://phabricator.wikimedia.org/T74421#1317206 (jrobell) Thanks @andyrussg and @pcoombe. Actually, I see this happening... [10:57:54] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising-Backlog, Patch-For-Review: Change English language legal text about recurring on all forms (before April 18) - https://phabricator.wikimedia.org/T94246#1317211 (jrobell) @Pcoombe @atg... [11:32:00] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs - https://phabricator.wikimedia.org/T100637#1317247 (hashar) mediawiki/core fund... [11:38:28] (CR) Hashar: "recheck" [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212731 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [11:39:07] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs - https://phabricator.wikimedia.org/T100637#1317281 (hashar) I forgot the fundra... [11:39:45] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1317283 (hashar) The mediawiki-extensions-.* jobs are now ignored :-} [11:40:01] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: fundraising/REL1_25 should fallback to REL1_25 instead of master for mediawiki-extensions-* jobs - https://phabricator.wikimedia.org/T100637#1317285 (hashar) [11:40:03] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, Patch-For-Review: Upgrade payments mw-core to REL1_25 - https://phabricator.wikimedia.org/T94528#1317284 (hashar) [11:41:11] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: mediawiki/core fundraising/REL branches should use git submodule - https://phabricator.wikimedia.org/T100637#1317286 (hashar) [11:41:22] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: mediawiki/core fundraising/REL branches should use git submodule - https://phabricator.wikimedia.org/T100637#1317097 (hashar) p:Unbreak!>Normal [11:41:50] (CR) Hashar: "The PHPUnit tests are no more run for extensions :-/ T100637 tracks that." [core] (fundraising/REL1_25) - https://gerrit.wikimedia.org/r/212731 (https://phabricator.wikimedia.org/T94528) (owner: Awight) [11:44:51] Fundraising-Backlog: Spike: how much space (in gigabytes) do we use in Civi? - https://phabricator.wikimedia.org/T100445#1317293 (Jgreen) the database footprint on the fundraising databases is currently around 85GB [13:50:48] Fundraising Sprint Lou Reed, MediaWiki-extensions-CentralNotice, Mobile-Web, Epic, Performance: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1317578 (phuedx) @atgo: There's no patch yet but @AndyRussG's comment would be appreciated. [13:51:07] Fundraising Sprint Lou Reed, MediaWiki-extensions-CentralNotice, Mobile-Web, Epic, Performance: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1317579 (phuedx) Mibad. Missed the link. [13:51:33] (PS3) Phuedx: Save 5.3k whenever a campaign is not running [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/213990 (https://phabricator.wikimedia.org/T100372) (owner: Jdlrobson) [13:52:03] Fundraising Sprint Lou Reed, MediaWiki-extensions-CentralNotice, Mobile-Web, Epic, and 2 others: CentralNotice mobile modules should not be loaded in the head - https://phabricator.wikimedia.org/T100372#1317583 (phuedx) ^ That's all that I look for when I'm glancing at a task. [13:52:37] (CR) jenkins-bot: [V: -1] Save 5.3k whenever a campaign is not running [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/213990 (https://phabricator.wikimedia.org/T100372) (owner: Jdlrobson) [15:35:42] Wikimedia-Fundraising, MediaWiki-extensions-CentralNotice, Browser-Support-Google-Chrome, Patch-For-Review: Multiselects in Special:CentralNotice sometimes load incorrectly - https://phabricator.wikimedia.org/T74421#1317859 (Pcoombe) Yes, I see it occasionally when my connection is supposedly good... [16:44:53] Fundraising-Backlog: Spike: how much space (in gigabytes) do we use in Civi? - https://phabricator.wikimedia.org/T100445#1318044 (CCogdill_WMF) Open>Resolved a:CCogdill_WMF Perfect, thank you, @Jgreen! [17:09:25] ejegg: trying to review some of your dash branches but they are on old versions of master. is this a good use case for the gerrit rebase button? [17:10:20] Wikimedia-Fundraising, Browser-Tests, Continuous-Integration-Infrastructure: Create unit and integration tests for Fundraising extensions to identify breaking MediaWiki changes - https://phabricator.wikimedia.org/T89404#1318153 (awight) [17:10:23] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: mediawiki/core fundraising/REL branches should use git submodule - https://phabricator.wikimedia.org/T100637#1318154 (awight) [17:11:06] yep! if it claims conflict let me know and I'll do a quick manual rebase [17:12:26] cool, thanks! [17:13:24] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, and 2 others: mediawiki/core fundraising/REL branches should use git submodule - https://phabricator.wikimedia.org/T100637#1318157 (awight) @hashar: Thanks for noticing this, and for the work... [17:13:45] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, Continuous-Integration-Config, Patch-For-Review: mediawiki/core fundraising/REL branches should use git submodule - https://phabricator.wikimedia.org/T100637#1318158 (awight) [17:16:11] ejegg: yeah it complains, but i don't mind doing the rebase if i can...but maybe i can't since i don't have access to the actual branch? [17:16:45] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, Continuous-Integration-Config, Patch-For-Review: mediawiki/core fundraising/REL branches should use git submodule - https://phabricator.wikimedia.org/T100637#1318166 (awight) Ah, another annoying issue is that we curr... [17:17:29] i could cherry pick the changes but not sure how i'd rebase the branch from there [17:17:48] no worries - I'll just get 'em straight. Bet it's mostly whitespace [17:17:51] one sec [17:18:23] ok, thanks! [17:19:09] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface, Patch-For-Review: Bad gateway error should be more helpful - https://phabricator.wikimedia.org/T100584#1318168 (awight) a:awight [17:19:53] (PS11) Awight: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [17:24:42] (PS2) Ejegg: Add text filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200097 [17:24:44] (PS10) Ejegg: Create shared filtering component, use in x-by-y [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199266 [17:24:46] (PS5) Ejegg: Add a binding for select2 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/199968 [17:27:56] cwdent: sorry, rebase seems to have broken something... [17:30:06] np! let me know if i can do anything... [17:31:04] (PS3) Ejegg: Add text filters [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/200097 [17:31:10] ah, I added a stray space in file path [17:31:22] ok, i think that's ready for more review! [17:31:53] thanks! [17:32:52] cwdent: oh yeah, i still hadn't figured out the way to make the filter component bindings fully two-way [17:33:23] as built now, the parent component can set initial values [17:33:56] and then read back the desired query string as a computed observable that changes when the user manipulates the filter [17:34:36] but I don't think there's a way for the parent component to reset the filter values without destroying and re-creating the component [17:35:03] and when you say component...like a widget? [17:35:28] yah, the widget is the parent component in ^^^ [17:36:17] ejegg: Hi! Is there one of these for the Mustache form? https://gerrit.wikimedia.org/r/#/c/210764/ [17:36:22] gotcha, and the children are the things you configure when you configure the widget? [17:36:35] awight: ooh, nope! [17:36:42] How do you test stuff locally? [17:36:43] Lemme make that... [17:37:04] sorry if you're wallowing around in a pile of git stash... [17:37:24] awight: so... mustache isn't actually looking at form settings to see what's valid [17:38:00] (CR) Awight: [C: -2] "Blocking this for now, we might still decide to revert to RapidHtml however." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210763 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [17:38:05] ejegg: ooh! [17:38:19] We probably want that [17:38:43] Unless you have other plans? [17:38:56] yeah, we probably do [17:39:09] along with paying attention to ffname on the querystring [17:39:16] right [17:41:28] as configured now, it will only load the $wgDonationInterfaceTemplate, so I /think/ it's not a security hole [17:42:21] Yeah I'm sure it's safe, considering it's disabled on production :) [17:42:28] heh, that too [17:42:39] But we need a mechanism for enabling and disabling individual payment methods and countries [17:42:49] definitely [17:43:12] No rush, I was just doing a little CR to procrastinate my other stuff [17:43:30] awight: does this listener look like it's in the right vein? https://gerrit.wikimedia.org/r/207526 [17:43:36] I should really just hustle through the limbo queue work so I can help with this [17:46:27] ejegg: Looks great! Feel free to TODO all over the place with any ideas about fixing the impedance mismatch between the framework and what we actually have to do. [17:47:09] I'm pretty annoyed every time I see "expatriated message", and things seem optimized for the multi-message SOAP thing where control is passed to an external routine. [17:47:29] Also it could use some test data. [17:48:14] word, will do. in the meantime, i think the mustache patches are testable locally with a link directly to the AstropayGateway [17:49:27] I did get some response, but it's none too healthy yet. Probably local configuration issues, and I guess I need to create the appeal. [17:50:36] hrm. The first one doesn't have the css to make it pretty... [17:50:43] that comes in with the resources refactor [17:56:14] (CR) Awight: [C: 2] "TODO: We should be able to pass params [1:] to the message." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214285 (owner: Ejegg) [17:56:41] (Merged) jenkins-bot: Fix Mustache l10n array-to-string warning [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214285 (owner: Ejegg) [18:15:12] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1318336 (atgo) [18:16:10] ejegg: if i get booted a bunch from the tubes, will you apologize on my behalf? :) [18:16:24] sure! [18:29:26] Fundraising Sprint Lou Reed, MediaWiki-extensions-CentralNotice: Refactor bannerController API as required for banner history - https://phabricator.wikimedia.org/T100686#1318408 (AndyRussG) [18:30:24] Fundraising Sprint Lou Reed, MediaWiki-extensions-CentralNotice: Refactor bannerController API as required for banner history - https://phabricator.wikimedia.org/T100686#1318384 (AndyRussG) [18:30:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Epic: Banner History - https://phabricator.wikimedia.org/T78089#1318416 (AndyRussG) [18:40:30] ejegg: Did you test the appeal patch with the live templates, or just a "foo"? I'm seeing wikitext expansion issues. [18:40:40] I'll see if I can figure it out while you're meeting... [18:41:43] I was trying with a template [18:42:09] funky. ok [18:44:50] ejegg: Hah, I was missing ParserFunctions [18:45:01] (PS12) Awight: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [18:45:06] (CR) Awight: [C: 2] Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [18:45:13] (PS12) Awight: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [18:45:49] (Merged) jenkins-bot: Add appeal to mustache data [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212457 (owner: Ejegg) [18:55:09] (CR) Awight: [C: -1] "The output is perfect! Just one small security thing to fix." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [18:55:33] (CR) Awight: "Rebase conflict..." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (owner: Ejegg) [19:01:59] (CR) Awight: [C: -1] "I like where you're going, but it doesn't seem necessary to refactor any validation at this point. Did you run into a blocker? If this i" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (owner: Ejegg) [19:08:49] (CR) Awight: WIP validate stuff (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) (owner: Ejegg) [19:13:18] thanks for all the CR - I'll get that path sanitized and the other thing rebased right quick [19:15:32] heading to the shop, back shortly [19:30:15] (PS13) Ejegg: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) [19:44:25] (CR) AndyRussG: "Neat!! And interesting :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/213990 (https://phabricator.wikimedia.org/T100372) (owner: Jdlrobson) [20:00:36] here's a thing that happens: when i import Engage data into civi, i get rows in civicrm.civicrm_contribution_tracking but not drupal.contribution_tracking, which some of the dash queries target [20:03:48] cwdent: there shouldn't be such a thing as civicrm_contribution_tracking [20:04:01] Is this under vagrant? [20:04:20] (PS8) Ejegg: More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 [20:04:32] err sorry, civicrm_contribution [20:05:14] aah [20:05:20] lessee... [20:06:08] awight: want to come stand up? [20:06:28] try it! it's fun! [20:18:12] wheeee! [20:18:38] cool shirt awight [20:18:52] hehe, it was free [20:20:42] cwdent: fyi, if contribution_tracking is not updating for file imports, that's a pretty big deal, cos that would mean it's probably not working for the queue consumer either. [20:21:10] cwdent: Can you paste me a line of your sample data? [20:21:16] It's not marked as recurring, is it? [20:21:34] i don't believe so [20:21:37] one sec [20:22:06] there would be a subscription ID or something, and the imported civicrm_contribution rows would have a value in contribution_recur_id [20:23:08] pm'd you [20:23:10] yeah that fk is null [20:23:37] good. [20:24:03] If you have logging... turned up to debug, you should see a line "Contribution missing contribution_tracking_id" for each imported row [20:24:15] However, I'm not sure if that's the default in vagrant [20:26:08] where do i set that? [20:26:21] cwdent: Simpler would be to edit modules/wmf_civicrm/tracking.inc and add an error_log statement in wmf_civicrm_insert_contribution_tracking [20:26:31] That should be tripped for every row. [20:26:36] I'll try locally... [20:26:41] cool, i'll try too [20:28:18] cwdent: oh, careful about deleting records from the civi db, btw, there is some cascade fail. [20:28:50] foreign keys are hard [20:30:11] Especially when your schema is generated from a homebrew XML parser that outputs SQL using string concatenation. [20:30:49] heh [20:32:12] where do the logs go? [20:34:31] from inside the vm, they're at /vagrant/logs/hhvm/error.log and /var/log/syslog [20:35:12] cool [20:43:08] cwdent: OOoookay. Sorry about the rabbithole. [20:43:19] It turns out, we explicitly don't do contribution_tracking stuff for checks. [20:43:34] If this breaks dash, please make a card. [20:43:59] i see! [20:44:01] In the meantime... I can't believe I suggested this as a way to create dummy data... [20:44:09] i'm crawling around civi [20:44:14] wmf_civicrm.module line 1232, btw [20:44:18] there are some confusing symlinks in here [20:44:26] that was my doing [20:44:47] yeah modules/ and modules/civicrm/ are trixy [20:45:34] i go down the rabbit hole and suddenly come back out the top [20:45:45] I think I have a cheat for you, set the "Payment Instrument" column to "Cash". [20:45:51] Lemme try that... [20:46:26] yep, I think that does the trick. [20:46:39] ahh i see [20:46:41] awesome [20:46:44] * awight sighs about all the things I should document [20:46:52] that's one of them. [20:47:15] this module, this is things to extend civicrm? [20:47:34] Officially, these are Drupal modules. [20:47:41] But we can provide CiviCRM hooks in them. [20:48:04] There is another type of extension for CiviCRM, see https://civicrm.org/extensions [20:48:25] and I'm writing one called "donor_review", maybe it's on a branch... they are very different. [20:49:04] But ahh right, to answer your question, wmf_civicrm is meant to hold everything we do that is tightly coupled to Civi. [20:49:27] gotcha [20:49:39] Although we obviously break that encapsulation all over the place... We assume it's okay for now, as long as the cheater modules include wmf_civicrm as a dependency. [20:52:49] ok that makes sense [21:05:25] (CR) Awight: [C: 2] Refactor form resource loading (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [21:05:52] (Merged) jenkins-bot: Refactor form resource loading [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212458 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [21:06:04] (CR) Awight: "Is PS 8 just a rebase?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (owner: Ejegg) [21:12:28] (CR) Ejegg: "PS8: rebase." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (owner: Ejegg) [21:12:35] ejegg: :p [21:13:32] This is not gonna turn out well, is it... https://github.com/adamwight/php-queue/compare/master...adamwight:redis-zset [21:14:56] ejegg: lmk if you want to chat about your new approach to validation, I hope my comments didn't sound prohibitorily mundane ;) [21:14:59] heh. that comment also had a note about how i wanna go fwd. but after a \n, so bot didn't include it [21:15:11] lol k [21:15:32] good points, we should do that [21:16:14] I think the country change is the sort of thing we would want to do to all gateways at once, rather than in parallel, you agree? [21:16:26] Just so there's always one place to make the config changes. [21:16:29] hmm, yeah [21:16:53] It also seems pretty safe, like a cutover can be done tactfully, and is reversible. [21:17:02] i hope so! [21:17:19] <_< /me checks whether K4's irc scripts actually ping her when I say "cutover" [21:17:30] ha! [21:17:53] confirmed. [21:23:48] Jason Geffner discovered a buffer overflow in the emulated floppy [21:23:50] disk drive, resulting in the potential privilege escalation. [21:24:01] Package : virtualbox [21:24:03] CVE ID : CVE-2015-3456 [21:24:10] best cve i've seen in awhile [21:26:58] hehe [21:27:43] another notch in the suspenders [22:06:22] http://csvkit.readthedocs.org/en/0.9.1/index.html [22:27:36] Fundraising Sprint Kraftwerk, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Astropay Integration, Patch-For-Review: Add gateway name to queue consumer switch, and custom reports - https://phabricator.wikimedia.org/T90508#1319063 (atgo) Hey @awight is this confirmed fixed? Can we close? [22:33:55] switching locations... back in an hour! [22:52:26] Did something happen with vagrant? I just resinstalled fresh, and now I'm getting a 'Bad Title' error when trying to go to the GlobalCollect forms. [22:55:07] XenoRyet: I think that's awight's changes from last weekend [22:56:51] XenoRyet: you need some new stuff in LocalSettings.php [22:57:31] Ah, ok. Is that the settings we were talking about yesterday when I couldn't get worldpay to work? [22:57:37] Or something new? [22:57:39] mmm, probably! [22:57:44] stuff like $wgGlobalCollectGatewayEnabled = true; [22:58:10] sounds like we should update the fundraising vagrant localsettings too [22:58:48] Yea I suppose so. [22:59:16] i've been meaning to learn how to contribute to that project for a while - maybe this is a good way to dip my toe in [23:02:41] Ok yea, that's all it was. Thanks for the tip. [23:39:16] (PS9) Ejegg: More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) [23:45:53] (PS10) Ejegg: More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) [23:46:15] (CR) Ejegg: More logic for mustache forms (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg)