[01:52:41] (CR) Awight: More logic for mustache forms (10 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [01:52:51] (CR) Awight: More logic for mustache forms (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [01:54:21] (CR) Awight: "That was fast! Mostly small comments. The places where it's looking a bit messy could benefit from PaymentMethod encapsulation." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [13:46:05] hey ejegg|away! [13:59:04] good morning cwdent! [13:59:41] morning! [13:59:45] how's paris? [13:59:53] i'm actually in london now! [13:59:56] it's rainy [14:00:00] i guess that's not surprising [14:00:05] hehe yeah i've heard that [14:00:19] going to hang out with pcoombe? [14:01:47] you mean the-wub? :) [14:01:57] yes! we're going to meet up next week, details TBD [14:02:32] oh nice, didn't know that was him [14:02:46] hehe [14:02:47] * the-wub waves [14:02:50] :) [14:03:06] have you guys "met"? [14:03:44] yeah sorta i came to the last fr standup [14:04:25] oh nice [14:05:07] yeah. I hope to meet you in real life soon cwdent! [14:05:29] me too! [14:08:01] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1320683 (atgo) [14:08:37] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1021387 (atgo) I just added that other one as a blocked... [14:09:33] Fundraising-Backlog: Logging if a donation amount was chosen from one of the fixed amounts - https://phabricator.wikimedia.org/T92462#1320689 (atgo) @andyrussg will this be covered in banner history? @pcoombe is there a different way we could get this? [14:14:25] Fundraising-Backlog: Logging if a donation amount was chosen from one of the fixed amounts - https://phabricator.wikimedia.org/T92462#1320697 (AndyRussG) @atgo Hi! It's not part of the banner history stuff. It sounds doable but would work differently... [14:14:42] * AndyRussG waves [14:14:48] hi AndyRussG! [14:14:59] :) [14:15:16] Fundraising-Backlog: Logging if a donation amount was chosen from one of the fixed amounts - https://phabricator.wikimedia.org/T92462#1320698 (atgo) Ok. Let's leave it out for now and we'll decide/triage later. We should stay focused on getting the MVP of the banner history stuff out for now. [15:03:15] hey AndyRussG! [15:03:21] thanks for sending over that summary of things with the banner history [15:04:21] so.. it looks like we have a ways to go before the feature is usable by megan, etc.... right? [15:04:30] i just want to make sure i'm current on the status there [15:04:42] is there anything that i can do to help define anything at this point? or are you pretty set? [15:05:55] also, in your summary you say "Tasks 1, 2 and other tasks on that roadmap won't be deployed one by one, but rather all together at the end." [15:06:39] if possible, could we push out at the end of step 6 first? [15:06:52] i'd like to get the minimum in our user's hands and build from there, if possible [15:14:34] atgo: hi! one sec, lemme see... [15:20:52] atgo: well yes, that's also doable :) [15:21:21] Sorry I kept just looking at the tech roadmap and turning a blind eye to the features roadmap [15:21:50] I mean, yes now that you mention it that's indeed how we planned it... [15:25:31] The main thing is that tech steps 1 and 2 don't have any value at all until we get to 6. Right now in fact there are bits of code in 1 that are "placeholders", dummy code that is in the place of stuff that's coming along later, and is just there to show that the real code that was added works in principle [15:25:36] That's why it's on a feature branch [15:27:07] atgo: (for example the comment on lines 248-249 here: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FCentralNotice/0b7925e799de58b5e0b4dacf4fdf8aa6e679c740/CentralNotice.php#L248 ) [15:27:25] yeah [15:27:36] that all makes sense, i just want to make sure we get something out as soon as we can [15:27:43] and the banner history part is what they've actually asked for [15:29:30] but AndyRussG - it sounds like we can probably do Steps 1-6 at the same time still, yeah? [15:31:04] atgo: yep! [15:31:39] alright! cool [15:31:53] so... another question [15:31:59] since we're now on step 4/6 [15:32:39] and it's been >3 months of the project [15:32:47] are we still 3 months out from step 6...? [15:32:47] :/ [15:33:16] AndyRussG: i realize i keep forgetting to tag you :P [15:33:47] atgo: no, we're not 3 months from step 6 [15:34:00] rad [15:34:01] that is nice :) [15:34:29] AndyRussG: anyway megan was asking me for an update, so i'd love to give her a rough window [15:34:44] she wants to burn in using the banner history stuff well in advance of december [15:34:50] i know these things are hard to estimate though [15:34:54] atgo: right! that makes sense [15:35:39] AndyRussG: could you estimate this? https://phabricator.wikimedia.org/T100686 [15:35:43] i know we missed it in the last prawning because time [15:36:05] I think we can probably get an initial version of step 6 in 2-3 weeks :) [15:36:18] awesome! [15:36:24] i will tell her that we're aiming for the end of the quarter [15:36:51] and i'm just digging around.... it looks like this one is pretty undefined: https://phabricator.wikimedia.org/T90918 [15:37:01] AndyRussG: should we... work on that? do you have what you need? [15:37:23] K just estimated T100686 (4 pts) [15:37:42] wooo [15:38:21] yeah sorry I didn't make the card before the prawns took off [15:38:22] my bad [15:39:16] no worries! it's all good [15:39:27] atgo: regarding T90918... that one is about the actual coding, or about defining exactly what we store? [15:39:41] i'm hopeful when we have the scrum master/agile person i can focus a lot more on requirements and helping make sure the tasks are outlined in the way that makes the most sense [15:39:43] I think we do need still those exact details, no? [15:39:53] i think what we store [15:40:00] usually when we ask we get "everything. we need everythign" [15:40:12] hmmm [15:40:25] Well we could also look at the priorities that they already laid out, and make a specific proposal [15:40:41] And then they could see whether which needs it meets and which ones it doesn't [15:40:58] yeah [15:41:00] i'll dig at that a bit [15:41:23] hi K4-713! [15:41:27] eep [15:41:32] What did I do? [15:43:17] just saying hi [15:43:21] i've been awake for a long time [15:43:29] Heh. That's cool. Hi! [15:43:51] How's the Europes? [15:43:55] good! i got to london [15:44:01] Nice. [15:44:03] it's kind of overwhelming that everyone speaks my language all the time [15:44:08] haha [15:44:10] harder to be lost in my own thoughts [15:44:19] I really like not having to understand teenagers. [15:45:15] atgo: will you return to the US speaking British then? [15:45:58] I'm so going up to the meeting room early. [15:46:00] biab [15:49:40] franglish [15:49:54] thanks tons for the chat, AndyRussG [15:50:37] atgo: likewise thanks tons for keeping tabs on this and helping to keep stuff focused :D [15:50:43] :) [15:50:57] i'm going to send an update to megan right now... please feel free to jump in and correct anything i got wrong [15:53:40] atgo: Hm. I wonder if anybody but me is going to be in the office tday. [15:53:44] Today. [15:53:47] Letters. [15:54:00] hm indeed [15:54:02] CV is out for sure [15:54:06] Pats? [15:54:13] i think usually WFH on fridays [15:54:18] * K4-713 nods [15:55:42] * K4-713 continues to eat really loud potato chips [15:56:23] Clearly there is still some jetlag going on. [15:56:34] * K4-713 waves at XenoRyet [15:57:20] Mornin' [15:57:54] Got a bit more sleep last night, but a kid with a fever is still roughhouse. [15:58:23] Hey, so, I was looking at my calendar for today, and through something that closely resembles a miracle, I seem to have no meetings after 10:30. Aside from standup. [15:58:39] wow, nice [15:59:10] Are you still in the stage of unwinding RapidHTML that you could use a trail guide? :) [15:59:31] the-wub: Oh wow. I didn't know you aged. [15:59:43] Weird. [15:59:48] Yea, there are definitly still some bits I could use explained. [16:01:04] K4-713: yeah, it keeps happening about this time every year :) [16:05:32] Get that checked right away... must be something wrong with the circuitry. [16:35:16] Hey! do you guys know when the astropay forms should go out? ejegg|away said this week. awight XenoRyet cwdent AndyRussG K4-713 [16:35:23] thanks :) [16:35:47] hi atgo [16:37:00] howdy! [16:37:08] i just need to fix a couple more commits before they can be merged [16:37:13] awesoooome [16:37:20] are you feeling OK about this as a friday deploy? [16:37:25] i believe that's something we try to avoid typically [16:38:01] that's crazee [16:39:30] i think maybe it could be ok here [16:39:53] since this last batch hardly touched any other gateways [16:39:55] atgo-meetingz, ejegg: I'd rather not do friday deploys unless you can prove that something/someone is actually on fire. [16:40:10] yeah.. i mean, i'm OK to push it to Monday [16:40:22] but would rather not delay past that if we can avoid it [16:40:29] i mean, if we deploy and then lots of things need fixing, sure [16:41:48] yeah, guess waiting till Monday would be the smart thing to do [16:42:38] sorry atgo [16:42:59] that's all good. just looking for an update [16:45:29] thanks [17:02:56] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Provide access to limbo messages without knowing keys - https://phabricator.wikimedia.org/T99152#1321247 (awight) [17:03:26] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Provide access to limbo messages without knowing keys - https://phabricator.wikimedia.org/T99152#1286377 (awight) [17:12:11] hey [17:12:19] on payments1001 there is usually an nginx running [17:12:25] but it fails to start now: [17:12:31] Starting nginx: nginx: [emerg] invalid number of arguments in "client_max_body_size" directive [17:12:36] Jeff_Green: ^^ [17:12:42] how critical is it if that is not running [17:13:03] looks at the error closer [17:13:05] Er. Not? [17:13:16] while we try to decide whether we should call Jeff already [17:13:37] K4-713: it's not critical? what does it break [17:14:37] what's in the "payments wiki" [17:14:42] docs for FR i assume [17:14:51] (CR) Ejegg: "Some responses in line. Will take a look at pushing stuff into PaymentMethod, but I'm was thinking we might need a lot of gateway-specifi" (6 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [17:14:52] Ah... no, it's the thing that DonationInterface lives in. [17:15:05] We don't use the wiki part of the wiki much / at all. [17:16:05] cmjohnson1: yt? [17:16:18] eh, i think i fixed it [17:16:29] What did you do? :) [17:16:29] "1M" should have been "1m" [17:16:29] wait, is nginx not doing the ssl termination for payments? [17:16:39] also, that is the default setting [17:16:48] but i suppose i have to find it in puppet too [17:16:48] mutante: ok thx! I'm confused that the nginx fail did not take out paymentswiki. [17:17:12] I thought we had nginx set up to reverse proxy to apache... [17:17:17] Sorry... I'm horribly task-switching right now. [17:17:57] 10:16 < icinga-wm> RECOVERY - check_nginx on payments1001 is OK: PROCS OK: 49 processes with command name nginx [17:17:58] ah hehe, I see the icinga warnings now. Perhaps it did take down the wiki. [17:18:00] 10:16 < icinga-wm> RECOVERY - check_payments_wiki on payments1001 is OK: HTTP OK: HTTP/1.1 200 OK - 249 bytes in 0.029 second response time [17:18:03] 10:16 < icinga-wm> RECOVERY - check_puppetrun on payments1001 is OK Puppet is currently enabled, last run 177 seconds ago with 0 failures [17:18:06] ^ after i made a change [17:18:36] There weren't a ton of errors, but I guess if people weren't getting to 1001 at all, there wouldn't be. [17:18:40] Doy. [17:20:26] ehm/. didn't tellurium have this banner [17:20:32] with all the info where to make puppet changes etc [17:20:36] i dont see it now [17:21:04] mutante: boron I think? [17:21:24] yep [17:22:12] ah..ok.. ehm.. really: [17:22:13] work: clone to your homedir and see puppet/README.frack_puppet [17:22:17] tries all that [17:25:54] awight: it's really weird.. so puppet changes it back to how it was when i found it broken [17:26:05] but then i can restart it and the error is gone nevertheless [17:26:14] ok, that's weird. [17:26:23] mutante: you found the private puppet repo, right? [17:26:46] maybe the config had been livehacked wrongly before you went in there? [17:26:54] they are both private [17:26:58] and it was a different bug than what you saw? [17:27:02] it's just called "puppet" [17:27:05] the one i was looking at [17:27:16] that template isn't there apparently [17:27:45] there's a puppet repo I can get to on boron, then a second one with pw hashes and other things, which I can't read. [17:28:02] the livehack theory doesn't really explain it [17:28:05] becuase puppet was not disabled [17:28:09] right... [17:28:24] so i found it broken [17:28:29] with that very specific error message [17:28:33] about this config line: [17:28:55] [emerg] invalid number of arguments in "client_max_body_size" [17:29:15] i made the change from "1M" to "1m" [17:29:26] because that was the only difference i saw to the example used in docs, such as: [17:29:36] http://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size [17:29:49] where it's a default anwaysy [17:29:51] Default: [17:29:52] client_max_body_size 1m; [17:29:54] mutante: I just tested 1M and 1m locally, neither causes an error. [17:30:01] nginx 1.6.2 [17:30:07] then all i did was start it [17:30:17] but it did complain about that line before [17:30:24] then when i ran puppet after my change: [17:30:33] /File[/etc/nginx/sites-available/payments.wikimedia.org:443]/content: [17:30:37] DIFFS DISABLED /etc/nginx/sites-available/payments.wikimedia.org:443 /tmp/puppet-f [17:30:54] ^ you can see it changing it .. but DIFFS are disabled [17:31:00] and all is fine.. start/restart.. works [17:33:10] I donno what DIFFS is about [17:33:19] hey [17:33:23] My only guess is that there are several client_max_body_size directives in different files [17:33:29] and perhaps one was missing a config value [17:33:39] yes, I just added that to the template, and there was a typo initially [17:33:50] i thought it was fixed though, it ran clean on the host I tested (lutetium) [17:33:51] looking [17:33:55] hehe 15209a167fe7902a2618dc8273f115dc2c3585bf [17:33:56] thx [17:34:34] Invalid resource type nginx::http_site at /etc/puppet/modules/role/manifests/civicrm.pp wtf. that's not even a file I touched... [17:34:49] (PS3) Awight: Orphan slayer reads from Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211062 (https://phabricator.wikimedia.org/T99017) [17:35:20] oh I lied. i did touch it, and I left a semicolon where a comma should be. [17:37:41] that is how i did my first site outage =] [17:44:36] hi awight :) [17:44:51] ccogdill: morning! [17:44:54] do you have a second to look at a query? I feel like I’m doing everything right but not returning the results I want [17:44:56] good morning! [17:44:57] :D [17:45:07] sure, I enjoy your puzzles :) [17:45:50] so I just want a count of the different gateways our enUS donors used in the past few years [17:45:59] we want to try emailing specifically based on recent payment method [17:46:29] cool [17:46:38] so I did this: SELECT COUNT(*), e.gateway FROM wmf_contribution_extra e JOIN civicrm_contribution co ON co.id = e.entity_id JOIN civicrm_contact c ON c.id = co.contact_id JOIN civicrm_email em ON em.contact_id = c.id JOIN civicrm_address a ON a.contact_id = c.id JOIN civicrm_country u ON u.id = a.country_id JOIN drupal.contribution_tracking t ON t.contribution_id = co.id WHERE (u.iso_code = 'US') OR (t.country = 'US') AND [17:46:38] c.preferred_language = 'English' AND co.receive_date < '2015-01-01' AND co.receive_date > ‘2011-12-31’ AND em.email IS NOT NULL; [17:46:51] and all I’m getting is one row of data with GC as the gateway [17:46:54] no pp, no amazon [17:47:27] you need a "group by" clause, otherwise the count(*) will cause the entire result set to collapse [17:47:32] ohhh [17:47:36] try "group by a.contact_id" [17:47:41] thank you! [17:47:45] np! [18:05:20] (PS4) Awight: Orphan slayer reads from Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211062 (https://phabricator.wikimedia.org/T99017) [18:07:36] Friends, anyone feel like reading some queueing code? I'm eggbeating like hell to keep my head out of the lava here... https://phabricator.wikimedia.org/T99152 [18:08:06] heading to the shop, brb [18:08:16] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Provide access to limbo messages without knowing keys - https://phabricator.wikimedia.org/T99152#1321390 (awight) [18:11:01] awight: eggbeating? [18:11:28] awight: patch? [18:11:47] AndyRussG: thanks! https://github.com/adamwight/php-queue/pull/3 [18:15:45] awight: you're adding a hardcoded string ('fifo')? How about using a constant? [18:15:55] AndyRussG: good idea [18:16:58] * AndyRussG hides pirated copy of _Code review cookbook vol. 34 Github edition_ [18:17:14] hehe [18:17:25] enjoy their superior commenting system! [18:18:03] No way, Gerrit is tops [18:18:42] awight: This is the same external lib that you'd asked for review for before and I never got to, right? [18:18:58] Yes :) [18:19:04] Mmmm sorry for the delay! [18:19:11] No worries, the upstream author and ejegg are peeking at it occasionally. [18:19:27] I'm trying to get into into Gerrit in the next few days, to make CR more consistently bad. [18:19:32] Would you like to do a short video call sometime this afternoon to walk me through the codebase and ur goals really briefly? [18:19:43] that would be helpful for me! [18:19:48] fantastic! [18:20:00] What time would work best 4 u? [18:20:20] Any time at all. Now, 2:00... [18:22:12] cool... 2pm SF time then? [18:22:19] u got it [18:22:24] K [18:22:40] (really any time is also OK w/ me... especially anytime after standup) [18:23:21] ok sure, we can improvise [18:23:39] ejegg: Do you feel like doing a call also, to talk me through the validation stuff, or you ok w/o that? [18:24:43] a call would be great! when is good for you? [18:25:48] any time! [18:25:49] XenoRyet: Hey... I have escaped the meeting vortex. [18:25:56] now through end of day [18:26:27] XenoRyet: Should I set up another meeting with you after lunch? :) [18:26:40] Yea, that sounds good to me [18:26:45] okay, cool. [18:26:55] Any time should be fine. [18:27:14] I'll grab an hour at some point after standup. [18:27:27] Cool [18:27:29] ...the great Room Hunt. [18:28:31] awight in 15 min then? [18:29:04] ejegg: works for me [18:29:59] cool. want to goog-call me when you're set up? [18:30:11] yup [18:43:26] awight: is it the redis queue you're talking about? [18:43:44] cwdent: yep [18:44:31] would you mind if i sat in on that call? [18:44:37] i might learn something [18:47:54] cwdent: re limbo queueing? sure! [18:49:15] cool. i am in JS debug hell right now but tyler (from releng) is at the shop and he's a js wizard [19:42:00] awight: ejegg: version of celery used by DjangoBannerStats? [19:42:04] on barium? [19:45:49] hmm [19:46:15] I'm getting an error, "'module' object has no attribute 'commit_manually'" [19:47:10] I was looking at http://stackoverflow.com/questions/7350212/django-celery-transaction-and-task-dont-stack , tho now looking more carefully, it may not be that.. [20:19:31] AndyRussG: aargh. Unversioned dependencies [20:19:33] lemme see [20:19:52] awight: thx! [20:22:29] Jeff_Green: how are python libraries installed on barium? [20:23:11] I think entirely by puppet-installed debs [20:23:45] ok, cool. I'll look on boron [20:23:53] Jeff_Green: where do you see a dependency on elery? [20:23:56] celery [20:24:19] I don't see any reference in DjangoBannerStats [20:24:39] barium is a 'civicrm' role box, so you'd look in /etc/puppet/modules/role/manifests/civicrm.pp to start [20:24:52] thx! [20:25:14] class { 'fundraising::django_banner_stats': [20:25:35] package { 'python-django': [20:25:47] that's the only package specific to that class anyway [20:29:09] awight: Jeff_Green: I might be mixed up then [20:29:22] Jeff_Green: sorry, I sent that question to the wrong person [20:29:26] ha [20:29:30] AndyRussG: yeah I don't see any reference to celery [20:29:40] in the code or on the box that runs it [20:29:53] oh you're literally looking for a py module named celery? that doesn't ring a bell anywhere in frack [20:30:39] Jeff_Green: no [20:30:44] Here's my error: https://tools.wmflabs.org/paste/view/fd170d6e [20:30:45] AndyRussG: I can tell u we're using the deb package python-django 1.3.1-4ubuntu1 [20:31:08] Maybe you installed a newer django via pip? [20:32:04] awight: Hmm interesting. I tried installing with deb but my python didn't find it, so I did install via pip (system-wide) [20:32:22] maybe your python isn't installed from the package either? [20:32:29] dpkg -S `which python` [20:32:45] Hmmm [20:33:30] BTW my question about celery was from haphazardly grabbing bits of irrelevant info fom this stack overflown: http://stackoverflow.com/questions/7350212/django-celery-transaction-and-task-dont-stack [20:33:46] Sorry 'bout that silliness [20:34:48] Hmmm: dpkg -S `which python` [20:34:48] python-minimal: /usr/bin/python [20:34:57] Nice trick BTW! [20:35:54] That looks like the right package. [20:36:03] # python -V [20:36:03] Python 2.7.10rc1 [20:36:12] can u try installing django by package again, and we can debug that? [20:37:01] (pip uninstall first, of curse) [20:38:05] K [20:39:10] My pip django version is 1.8.2, so yeah that's a bit later [20:40:30] Hmm my deb package would give me 1.7.7, tho [20:40:39] what ubuntu are we on? [20:40:41] argh [20:41:12] 12.04.5 LTS [20:42:01] That would be tragic if u ended up porting this piece of cruft to a newer Django [20:43:06] Internets tell me you could try, pip install -I django==1.3.1 [20:43:16] that would make it a cruft -> update = crupftdate [20:43:31] Yeah I think that's the route [20:43:31] I think that's a network protocol [20:43:42] "cruft me up"! [20:43:47] lol [20:44:07] Engage the cruft drives, Scooty! [20:46:00] awight: Jeff_Green: weeeee...! oui! that did it [20:46:05] thanks much [20:52:55] great news! [21:00:43] yurp [21:01:03] awight: anytime you want to talk about the queue stuff, I'm all set [21:01:18] ok one second [21:02:17] I wonder if anyone else might like to join too (ejegg XenoRyet cwdent K4-713 ? ) [21:02:44] Still talking to K4 about rapidHTML [21:04:42] yeah i'm here [21:04:47] AndyRussG: did yu get the invite? [21:05:09] https://www.mediawiki.org/wiki/Fundraising_tech/Message_queues [21:23:13] https://github.com/adamwight/php-queue/pull/3/commits [21:23:55] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FDonationInterface.git/8a9959cf409a5e95c84cfe625d0c792ec1e79318/gateway_common%2FDonationQueue.php [21:26:46] https://github.com/adamwight/php-queue/blob/master/src/PHPQueue/Backend/Base.php [21:27:10] https://github.com/adamwight/php-queue/blob/master/src/PHPQueue/Backend/Base.php [21:27:25] https://github.com/adamwight/php-queue/blob/master/src/PHPQueue/Base.php [21:28:05] https://github.com/adamwight/php-queue/tree/master/src/PHPQueue/Interfaces [21:28:40] https://github.com/adamwight/php-queue/blob/master/src/PHPQueue/Backend/Predis.php [21:28:50] https://github.com/adamwight/php-queue/blob/master/src/PHPQueue/Backend/Stomp.php [21:46:00] awight: cwdent: ejegg: Sorry I had to drop out, still there? [21:49:31] nah, that was it! [21:51:46] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 3 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1322195 (XenoRyet) Upon investigation it appears the alert box... [21:57:28] awight: ah OK... thanks! [22:06:31] (Really unexpected BTW, supposedly the parent wasn't coming to pick up my kid's friend until later.) [22:08:18] awight: which repo do I clone? awight/php-queue? [22:08:35] I mean, adamwight/php-queue? [22:10:13] yeah, https://github.com/adamwight/php-queue [22:10:31] you can also clone DonationInterface and run "composer update" to get the repo [22:16:19] awight: ah OK! that sounds like something to do with the shiny new vagrant role [22:18:34] it works with a normal checkout, not overly vagabonded [22:21:33] Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash and not Enage - https://phabricator.wikimedia.org/T100853#1322277 (RLewis) NEW a:atgo [22:44:35] (PS11) Ejegg: More logic for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/212728 (https://phabricator.wikimedia.org/T97056) [22:52:41] Fundraising Sprint House of Pain, Fundraising Sprint Indigo Girls, Fundraising Sprint James Brown, Fundraising Sprint Kraftwerk, and 3 others: Change errors on GC forms from popup to red text - https://phabricator.wikimedia.org/T86214#1322378 (atgo) Yes, I think that's a great idea. We think that... [23:15:03] (PS1) Ejegg: Use generic payment_submethod in mustache inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214780 [23:15:47] awight: I added tons of TODOs to https://gerrit.wikimedia.org/r/212728 , and ^^ gets rid of cc- prefix and bank_code input name in forms [23:17:27] (PS1) Ejegg: PaymentMethod spec combines metadata from all levels [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214781 [23:19:16] (PS2) Ejegg: PaymentMethod spec combines metadata from all levels [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214781 [23:30:24] ejegg: awesome, I'll take a look [23:32:02] well i'm totally fried [23:32:04] thanks! [23:32:23] i swear this is going to end up being a bug in knockout [23:32:35] it's been known to happen [23:33:47] i need a beer [23:33:51] i'm sure i'll be back on later [23:33:58] but if y'all aren't, have a good weekend! [23:46:46]