[00:01:50] (PS5) Awight: Orphan slayer reads from Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211062 (https://phabricator.wikimedia.org/T99017) [00:09:36] (PS6) Awight: Orphan slayer reads from Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211062 (https://phabricator.wikimedia.org/T99017) [00:16:21] awight: does this jibe with what you were imagining for hierarchical payment methods? https://phabricator.wikimedia.org/P706 [00:17:08] looking... [00:17:13] also: awesome [00:19:09] That looks great for now, but there's still some stuff bothering me [00:19:53] Submethods are not still... subordinate, and there's no way to have a polyhierarchy [00:20:02] I'm not sure we need any of that though [00:20:04] ok, planning to let it percolate a while before coding anything [00:20:16] polyhierarchy, like multiple inheritance? [00:20:20] I've been percolating like 3 years and still feeling tepid [00:20:21] yeah [00:21:09] I mean... there are two really important requirements, * the donor can hint which payment method they want to use, and * we can communicate with the gateway about exactly what is happening [00:21:21] I think the rest is just how we want to do bookkeeping [00:23:30] heh. and how complicated we want the settings to look. that 'ALL' / '+' / '-' stuff lets you be nice & brief, but the logic to filter with multiple levels of overrides will need a ton of tests [00:24:26] yeah... probably the config GUI should look something like Special:CentralNotice [00:24:52] where each concrete method (aka submethod) capabilities is listed in full [00:25:16] was there a particular use case you had in mind for a poly-parented submethod? [00:27:32] only a freaky one that we wilfully ignore: someone gets redirected to paypal... but they pay using a credit card. [00:28:16] oh yeah. So it's like cc is top-level and not. [00:28:32] yaah [00:28:40] but for our purposes, do we even care how a paypal donor settles? [00:28:53] that can be like half-pp-balance, half-credit [00:29:08] but if the donor wants to use a credit card and we can't support with any other processor... we should know that they can be sent through the paypal gateway. [00:29:15] oho [00:29:20] truf [00:29:29] We can totally ignore that edge case until we can't ignore it [00:29:39] I was just using that as a way to think about what's really happening here [00:29:52] ok, definitely needs more percolation [00:30:09] That would probably be useless for reconciliation, cos PP will charge their normal fees I assume [00:30:27] AFAIK, we only care about the cc type because there are different margins [00:30:45] maybe for donor services calls, too [00:31:31] nice to have 'em listed in the same spot for the gateways which offer different ones in different places. [00:34:14] I guess the internal code hygiene thing that has really been up my bonnet is that I can't stand duplicating code for method and submethod. I don't even like that either appears in switch statements. [00:35:34] For lack of a better phrase, it seems like the dependencies are backwards. The payment *method should include quirks flags, like if 'dd' requires extra fields, we just spell those out in the spec rather than having a conditional later on. [00:40:02] yeah, that should be possible with tge validation element, right? [00:40:45] anyway, gonna rest my brain for a bit [00:40:56] see you later folks [00:41:52] chow! [11:45:16] Wikimedia-Fundraising, operations: Add /fundraising to dumps.wikimedia.org - https://phabricator.wikimedia.org/T42847#1322818 (Krenair) So what we want to do here is move /fundraising under /other/fundraising (with a 301 redirect in place), and provide a link on the /other index.html? Is that correct? [11:52:27] Wikimedia-Fundraising, operations: Add /fundraising to dumps.wikimedia.org - https://phabricator.wikimedia.org/T42847#1322826 (jayvdb) >>! In T42847#1322818, @Krenair wrote: > So what we want to do here is move /fundraising to /other/fundraising (with a 301 redirect in place), and provide a link on the /o... [11:54:30] https://meta.wikimedia.org/wiki/Help_talk:CentralNotice#EventLogging [19:32:25] Fundraising-Backlog, Security, operations: Delete gadolinium:/a/log/fundraising/ - https://phabricator.wikimedia.org/T92336#1323396 (Krenair) [23:14:39] Wikimedia-Fundraising, operations: Add /fundraising to dumps.wikimedia.org - https://phabricator.wikimedia.org/T42847#1323517 (Krenair) It looks like all old data, and I can't find references in puppet to it. Nor can I find references to frdata, which appears to be hosted in frack?