[00:57:59] (PS7) Awight: Orphan slayer reads from Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211062 (https://phabricator.wikimedia.org/T99017) [00:59:09] (PS8) Awight: Orphan slayer reads from Memcache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/211062 (https://phabricator.wikimedia.org/T99017) [01:03:20] (PS1) Awight: add a WMF .gitreview [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215835 [01:45:49] (PS1) Awight: Fix typo in Stomp backend [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215852 [01:45:51] (PS1) Awight: Explicitly serialize using JSON for memcached messages [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215853 [01:45:54] (PS1) Awight: Correct Redis incr/decr when count > 1 [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215854 [01:45:55] (PS1) Awight: Don't double-encode [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215855 [01:45:57] (PS1) Awight: Implement IndexedFifoQueue for Predis [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215856 (https://phabricator.wikimedia.org/T99152) [02:16:44] (CR) AndyRussG: [C: -1] "Thanks!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/213990 (https://phabricator.wikimedia.org/T100372) (owner: Jdlrobson) [14:36:05] !log Disable PayPal audit parsing job [14:36:11] Logged the message, Master [16:13:16] what maintenance is going on this morning? [16:23:23] cwdent: no idea, is something off? [16:25:11] no i just saw that email that campaigns have been taken down [16:30:33] hmmm [16:38:39] cwdent: it's manual cleanup on the civicrm database [16:42:09] cool [17:19:47] HEADS UP: maintenance window starting, payments and civi will go down in a few minutes [17:25:19] AndyRussG: ejegg|away: fyi, the php-queue stuff is in Gerrit now, whenever you have time to re-review... [17:33:50] Jeff_Green: Is it me, or are the failmails changing? [17:33:59] * K4-713 is also changing [17:34:18] the external monitoring? [17:34:22] Yep [17:34:31] yeah, we're trying a new provider [17:34:41] Aaah [17:34:55] crud something is still writing to deb1025 [17:34:57] what can it be? [17:35:11] * K4-713 thinks [17:35:19] Writing? [17:35:31] advancing the master status [17:35:37] hurm [17:35:57] Well, donate wiki used to... but that's been supposedly broken for a long time. [17:36:08] hopefully that's successfully broken [17:36:09] We'd have to deploy a settings change to turn that off. [17:36:27] orphan slayer? [17:36:34] That's on 1004. [17:36:54] So, as long as www-staging got the off setting... [17:36:58] oh man, I think it's my jenkins resurrector script [17:37:04] ! [17:37:14] * K4-713 shudders at the thought of zombie jenkins [17:38:07] Are we, ah, expecting the listener box to be... missing? [17:38:26] not missing, it's returning a down-for-maintenance page [17:38:30] the external test is stupid [17:38:31] oh, ha. [17:38:37] Got it. [17:38:50] I'm going to add that switch everywhere we have an nginx proxy [17:38:55] it's the best thing ever :-) [17:39:11] ok showtime [17:39:19] woot. Let me know if I can do a thing. [17:42:12] (CR) Ejegg: [C: 2 V: 2] "Welcome to gerrit, php-queue!" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215835 (owner: Awight) [17:43:53] (CR) Ejegg: [C: 2 V: 2] "specificity!" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215852 (owner: Awight) [17:49:12] awight: cool, I'll check it out! [17:49:44] thanks! [17:50:00] :) [17:50:28] Here is my submission for Guiness World Record for the longest Gerrit comment: https://gerrit.wikimedia.org/r/#/c/213990/ [17:51:10] whoa, 3 postscripts! [17:51:11] rrrg, it still took me more than an hour to finish after I'd said it was 5 minutes from done... [17:52:04] They're supposed to be like the cherry on the ice cream sunday :) though in this case they may be olives in disguise [17:52:37] wowza! [17:52:54] glad you didn't lose the entire thing by navigating away from the page :-/ [17:53:11] Heh I did save it elsewhere a few times... [17:54:24] can someone log into civi and check that it's behaving normally? [17:54:28] sure [17:54:33] thx [17:54:45] I wish I were more certain about everything I said there... If there's a script in the head that says mw.loader.load and that makes a call to fetch RL modules, which returns asynchronously, that doesn't block main content display, right? I mean, I'm not crazy... bwahahahagbrbrrgggg [17:55:04] looks like it's working [17:55:09] Civi, that is [17:55:18] great [17:55:25] then we're done! [17:57:13] Jeff_Green: hey, I cannot find my client_cert password... Do you have those somewhere? [17:57:30] should be in your homedir on lute [17:57:47] ah k I was on boron [17:58:45] ah yeah [17:59:01] i stopped putting them on boron so the documentation can be consistent [17:59:48] (CR) Ejegg: [C: 2 V: 2] "Makes sense for interoperability with non-PHP queue consumers" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215853 (owner: Awight) [18:01:28] !log Enabling PayPal audit parser job [18:01:34] Logged the message, Master [18:06:12] (CR) Ejegg: [C: 2 V: 2] "This change looks good. Not sure why these functions are in the api though - they seem very backend-specific" [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215854 (owner: Awight) [18:06:44] (CR) Ejegg: [C: 2 V: 2] Don't double-encode [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215855 (owner: Awight) [18:08:13] Fundraising Sprint Lou Reed, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1338293 (AndyRussG) [18:15:43] (CR) Aaron Schulz: [C: 2] Remove redundant ResourceLoaderModule::getModifiedTime implementation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/215382 (https://phabricator.wikimedia.org/T94074) (owner: Krinkle) [18:23:08] (Merged) jenkins-bot: Remove redundant ResourceLoaderModule::getModifiedTime implementation [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/215382 (https://phabricator.wikimedia.org/T94074) (owner: Krinkle) [18:34:46] (CR) AndyRussG: "Thanks!! :)" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/215382 (https://phabricator.wikimedia.org/T94074) (owner: Krinkle) [18:35:12] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1338399 (RLewis) @awight Yes short names are fine as lo... [18:36:39] Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1338403 (RLewis) @awight was this fixed? Can Engage staff now save Community Gifts? Thanks, [18:37:54] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1338406 (awight) The last file was corrupted, here's an... [18:39:35] More CR requests: https://gerrit.wikimedia.org/r/#/c/215535/ [18:40:51] Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1338407 (awight) Not yet, sorry. I'm waiting for code review, then deployment. I'll post here when it's ready to use! [18:41:11] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1338410 (awight) [18:42:03] heading to the shop [18:42:20] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Amend rule for Engage team members - https://phabricator.wikimedia.org/T101179#1338414 (RLewis) @awight that's cool, just wanted to let Engage staff know. [18:45:16] AndyRussG, awight: are either of you going to be in Mexico City before or after the conference? [18:45:50] ejegg: yeah! I'm flying in quite early, in fact, on June 23 [18:45:57] And I'll be there one day still afterwards [18:46:25] oh wow! [18:46:38] ejegg: Good question, hopefully padding on both ends... you getting tickets now? [18:46:54] trying to nail down my dates by tomorrow [18:47:12] We're probably gonna hide out on the beach for a bit afterwards, and there are some pre-conference events... [18:50:29] awight: cool... You could always try this beach http://www.informador.com.mx/mexico/2009/94373/6/playa-artificial-de-iztacalco-la-mas-concurrida-del-df.htm [18:51:35] That looks like a crazy scene [18:56:25] nice [18:57:40] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1338453 (awight) With workaround for Excel's limited va... [19:01:41] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1338479 (Jgreen) I took a very quick look at this and afaict this requires a... [19:05:33] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, MediaWiki-extensions-DonationInterface: Revoke ActiveMQ read permissions for payments cluster - https://phabricator.wikimedia.org/T92923#1338491 (awight) OK great news, well great that it's possible at all. How sh... [19:16:46] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1338545 (RLewis) Re-uploaded file. {F174624} [19:17:15] ejegg: PPena_: Hi five, awesome work! [19:17:31] awight yay! [19:19:59] thanks awight! [19:20:23] there are some more mustaches tp review if you have spare time [19:20:33] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1338549 (awight) The .xlsx version is still missing som... [19:53:33] (CR) Ejegg: "Looks good! Just one thing to update in the test setup. Not this patch, but existing behavior with hashes is a little funky and backend-" (1 comment) [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215856 (https://phabricator.wikimedia.org/T99152) (owner: Awight) [20:04:10] Fundraising Sprint Lou Reed, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1338679 (AndyRussG) Supposing that there were no known outages in our infrastructure that correspond to that period, maybe let's explore the... [20:07:28] ejegg hello! [20:08:06] hi PPena_ [20:08:32] Just one sec - in fr-tech standup! [20:17:19] http://www.somethingawful.com/author/27/ [20:36:00] (PS1) Ejegg: Add 'ask' rates as currency conversion options. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/215965 [20:37:56] K4-713: quick question before u go: it seems I should be able to do my own queries on Hive and also on the pgehres database? If you agree, whom do I ask? [20:38:35] Er... wait. Do you need to *get* permissions, or do you already have them and need to know how to use them? [20:38:48] K4-713: both, I think... [20:38:56] ha, okay. [20:39:04] Unless I already have maybe the DB ones without knowing... [20:39:15] Jeff_Green would know about that part of it. [20:39:42] If you need some kind of fancy hive permissions, I think what you have to do is file a phabricator task and then I say "I approve" or similar... [20:39:44] I think DjangoBannerStats runs on barium? That would be also good to be able to log into to check setup and stuff someties... [20:40:41] So, yeah. Phabricator ticket to the ops requests project for things outside the frack, I think. [20:41:02] You should be able to get to barium, too. That's ours. [20:41:16] If, for some reason, you don't have those things yet, you should. [20:41:17] (Abandoned) Ejegg: Add 'ask' rates as currency conversion options. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/215965 (owner: Ejegg) [20:41:51] ssh barium.eqiad.wmnet [20:41:54] channel 0: open failed: administratively prohibited: open failed [20:42:01] crap, I'm going to be late. Sorry, have to run... [20:42:08] K4-713: np! have fun :) [20:42:13] AndyRussG: you need a bastion server set up in .ssh/config -- you haz? [20:42:25] ProxyCommand ssh -W %h:%p awight@bast1001.wikimedia.org [20:42:31] oops, wrong one [20:42:48] e.g. [20:42:50] Host barium [20:42:56] ProxyCommand ssh -W %h:%p awight@tellurium.wikimedia.org [20:43:18] AndyRussG: you have an ssh key you only use for FR hosts, right? [20:43:34] your host entry should say something like, IdentityFile ~/.ssh/id_rsa-fr [20:44:34] awight: hmm [20:45:09] yes... [21:04:23] (PS2) Awight: Implement IndexedFifoQueue for Predis [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215856 (https://phabricator.wikimedia.org/T99152) [21:06:12] (PS1) Ejegg: Make it easier to run phpunit [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/215969 [21:09:17] (CR) Awight: [C: 2] Make it easier to run phpunit (2 comments) [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/215969 (owner: Ejegg) [21:09:37] thanks! [21:09:59] (Merged) jenkins-bot: Make it easier to run phpunit [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/215969 (owner: Ejegg) [21:12:49] (PS1) Ejegg: Move phpunit bootstrap file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/215971 [21:13:31] (CR) Awight: [C: 2] Move phpunit bootstrap file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/215971 (owner: Ejegg) [21:13:35] (Merged) jenkins-bot: Move phpunit bootstrap file [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/215971 (owner: Ejegg) [21:18:00] (PS3) Awight: PaymentMethod spec combines metadata from all levels [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214781 (owner: Ejegg) [21:18:08] (CR) Awight: [C: 2] PaymentMethod spec combines metadata from all levels [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214781 (owner: Ejegg) [21:18:31] (CR) Awight: [C: -1] "rebase conflict" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214780 (owner: Ejegg) [21:18:39] (PS2) Awight: Mustache l10n - use additional parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215521 (owner: Ejegg) [21:18:49] (Merged) jenkins-bot: PaymentMethod spec combines metadata from all levels [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214781 (owner: Ejegg) [21:26:05] (PS4) Ejegg: Use generic payment_submethod in mustache inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214780 [21:26:07] (PS3) Awight: Mustache l10n - use additional parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215521 (owner: Ejegg) [21:26:13] (CR) Awight: Mustache l10n - use additional parameters (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215521 (owner: Ejegg) [21:26:19] (CR) Awight: [C: -2] Mustache l10n - use additional parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215521 (owner: Ejegg) [21:27:22] oops [21:27:39] heh, was wonder why so vehement [21:27:43] *wondering [21:27:44] (CR) Awight: [C: 2] "the other "no"" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215521 (owner: Ejegg) [21:28:08] (PS2) Awight: Get rid of special test functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215534 (owner: Ejegg) [21:28:13] (Merged) jenkins-bot: Mustache l10n - use additional parameters [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215521 (owner: Ejegg) [21:29:35] (CR) Ejegg: "PS4: rebase" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214780 (owner: Ejegg) [21:32:44] (PS3) Awight: Get rid of special test functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215534 (owner: Ejegg) [21:33:15] (CR) Awight: [C: 2] "Too kind :) I like that you've created a second variable to make it clear when we're gaming the system." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215534 (owner: Ejegg) [21:33:36] (PS5) Awight: Initial validation for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) (owner: Ejegg) [21:33:38] (Merged) jenkins-bot: Get rid of special test functions [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215534 (owner: Ejegg) [21:34:00] (PS5) Awight: Use generic payment_submethod in mustache inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214780 (owner: Ejegg) [21:36:14] (CR) Awight: [C: 2] Use generic payment_submethod in mustache inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214780 (owner: Ejegg) [21:36:27] (PS6) Awight: Initial validation for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) (owner: Ejegg) [21:36:35] (Merged) jenkins-bot: Use generic payment_submethod in mustache inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214780 (owner: Ejegg) [21:39:05] awight: let me just update the 'card selection' one to account for the 'submethod' merge [21:43:11] sure! [21:43:16] (CR) Awight: Initial validation for mustache forms (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) (owner: Ejegg) [21:43:20] (PS7) Awight: Initial validation for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) (owner: Ejegg) [21:43:28] (CR) Awight: [C: 2] Initial validation for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) (owner: Ejegg) [21:44:58] (PS2) Awight: Annotate some more vars and methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215527 (owner: Ejegg) [21:45:09] (CR) Awight: [C: 2] Annotate some more vars and methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215527 (owner: Ejegg) [21:47:12] (PS2) Ejegg: Make mustache form card selection act like GC [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215813 [21:47:59] (CR) Ejegg: "PS2: rebased on top of generic payment_submethod patch, jquery selector updated to match" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215813 (owner: Ejegg) [21:48:16] (Merged) jenkins-bot: Initial validation for mustache forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/214286 (https://phabricator.wikimedia.org/T100562) (owner: Ejegg) [21:48:19] (Merged) jenkins-bot: Annotate some more vars and methods [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215527 (owner: Ejegg) [21:51:11] (Abandoned) Ejegg: Revert Astropay to using RapidHTML form engine [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/210763 (https://phabricator.wikimedia.org/T97056) (owner: Ejegg) [21:51:23] ejegg: "card selection" is ready to go now? [21:51:30] yep! Thanks [21:51:35] (PS3) Awight: Make mustache form card selection act like GC [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215813 (owner: Ejegg) [21:55:34] Fundraising Sprint Kraftwerk, Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Analytics-Cluster, operations: Verify kafkatee use for fundraising logs on erbium - https://phabricator.wikimedia.org/T97676#1339107 (AndyRussG) > In those cases, there are more requests in kafkatee than in udp2... [21:56:24] ejegg: ooh yeah, you and XenoRyet are on a collision course in that validation code. [21:56:45] yeah, I figured there would be some toe-stepping [21:57:06] tried not to do too much there though [21:57:07] (CR) Awight: [C: 2] Make mustache form card selection act like GC (5 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215813 (owner: Ejegg) [21:57:17] XenoRyet: minor rebase alert ^^ [21:57:27] I know, it's tempting... [21:57:28] (Merged) jenkins-bot: Make mustache form card selection act like GC [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215813 (owner: Ejegg) [21:57:59] Fundraising Sprint Lou Reed, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1339123 (atgo) [21:58:17] Fundraising Sprint Lou Reed, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June? - https://phabricator.wikimedia.org/T101265#1333901 (atgo) Unplanned work doesn't get story points [22:00:50] back in a short little 2 hrs or so! :) [22:01:03] Yea, that's right where I'm working. Part of it anyway. [22:02:27] Though not the exact same lines, so might be ok. [22:02:29] ejegg: you want to knock that php-queue patch through the wicket? [22:02:41] awight: yep, just taking one last look at it! [22:02:42] XenoRyet: hehe, I was imagining you would have slashed and burned that entire savannah [22:02:59] Trying for a lightish touch in that particular file. [22:03:11] ejegg: I want it yesterday,and the demands will all be changed tomorrow!!! [22:03:43] * ejegg tries to picture awight as J Jonah Jameson [22:04:32] Is that where that's from?? [22:05:26] no idea [22:05:53] he was just the prototype of irate boss from my childhood [22:08:11] Aww, the source I was thinking of is not so funny... Billy Connolly, http://homepage.tinet.ie/~shaykelly6780/funnysounds/demands.wav [22:09:46] shoulda stayed a boilermaker, Billy! [22:10:58] grr, microsoft broke my composer update [22:11:15] sadly, you have to "composer update --no-dev" [22:11:16] microsoft/windowsazure dev-master requires pear-pear2.php.net/http_request2 * -> no matching package found. [22:11:21] ah, thanks! [22:11:31] some of those dev packages are fictitious, like ext-memcache [22:17:51] oh wacky, ext- in your composer.json means it needs a php extension [22:18:23] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1339240 (awight) {F174751} Five or more is the magic n... [22:18:52] Is that really a thing? I was imagining it was just some freeform text. [22:19:14] wat. it's a thing [22:19:21] yeah, and lib- means a specific library version [22:19:47] I bet that works about as well as the excel features I just tried to use from libreoffice [22:19:54] :P [22:22:50] (CR) Ejegg: [C: 2 V: 2] Implement IndexedFifoQueue for Predis [wikimedia/fundraising/php-queue] - https://gerrit.wikimedia.org/r/215856 (https://phabricator.wikimedia.org/T99152) (owner: Awight) [22:27:42] (PS1) Awight: Update to the Gerrit php-queue [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/215990 [22:28:56] awight: think I might deploy that mustache stuff [22:29:23] sounds exciting! [22:29:46] yeah, only thing to watch out for should be the email defaults, I think [22:31:07] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/215992 [22:33:41] (CR) Ejegg: [C: 2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/215992 (owner: Ejegg) [22:35:54] (PS1) Ejegg: Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/215995 [22:36:39] (CR) Ejegg: [C: 2 V: 2] Update DonationInterface for deploy [core] (fundraising/REL1_23) - https://gerrit.wikimedia.org/r/215995 (owner: Ejegg) [22:39:03] !log updated payments from d22e44e3fab2b937707c2776384cb93a49b4cfd3 to 43c7952d2a31deaea97e8319f5612d644dce43c8 [22:39:06] Logged the message, Master [22:41:11] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review: Create an Civi import function for hand keyed (including DAF) donations - https://phabricator.wikimedia.org/T88836#1339358 (awight) Okay, -aw5 above is the winning contes... [22:43:31] Fundraising Sprint Lou Reed, Astropay Integration, Patch-For-Review: Validation and error display for mustache form - https://phabricator.wikimedia.org/T100562#1339374 (Ejegg) Open>Resolved [22:43:54] Fundraising Sprint Lou Reed, Astropay Integration, Patch-For-Review: Astropay form is autofilling email to "nobody@wikimedia.org" - https://phabricator.wikimedia.org/T101114#1339375 (Ejegg) Open>Resolved [22:44:30] Fundraising Sprint Lou Reed, Fundraising Tech Backlog, Wikimedia-Fundraising, MediaWiki-extensions-DonationInterface, Patch-For-Review: Bad gateway error should be more helpful - https://phabricator.wikimedia.org/T100584#1339383 (Ejegg) Open>Resolved [23:31:38] ejegg: I wasn't clear on the final verdict, does AP send a discernable "pretty much good" code? [23:32:05] yes, their status 9 means all paid up [23:32:21] posted to result switcher, and also send to listener [23:32:27] *sent [23:32:55] ok. I'm wondering cos the listener task says something about "rescues from limbo queue", which is not necessary if we aren't actually finalizing the transactions there. [23:33:17] right... i need to delve into the queue consumer [23:33:20] Or, it might also become necessary if it turns out 75% of people drop out of the workflow before getting back to us [23:33:32] amazon's smashpig bit seems to create messages with all of the details [23:33:34] which one? The queue2civicrm consumer? [23:33:51] yeah, that consumes the listener messages, right? [23:33:55] yep [23:34:00] donations queue [23:35:16] so if anything outside of the listener is melding incomplete info with limbo / pending queue, it would be that [23:35:41] Sadly, we have no melding capability yet. I'd like to in the future... [23:36:05] ohh, so I /do/ need to do some more work [23:36:10] gotcha! [23:36:10] Whatever comes in first becomes the donation of record [23:36:22] what's the extra work? [23:36:42] the rescuing, to fill in the blanks [23:36:49] I [23:37:05] had modeled my listener after the amazon one [23:37:14] but that one seems to get all the info it needs [23:37:28] which makes sense for a fully hosted payment flow [23:38:48] err, yep, seems obvious now. Dunno where I thought the data fairy was coming in to help out [23:42:12] Sorry, IRL happened [23:42:23] I don't think you want to patch data in from the limbo queue [23:42:46] Hmm, where else would I find it? [23:42:48] It's.. not really something we do, and probably not a direction we want to go in. My fault if I muttered something like that yesterday [23:43:16] Urgh [23:43:30] Ulp [23:44:17] OK never mind me. It totally does make sense. [23:44:30] It's just a bit of tedious work, like you said. [23:44:35] yep! [23:45:14] I was bothered that we would be stuffing all this cruft into the pending queue with no way to know if we used it or not, but I suppose we'll be clearing it all out as the listener messages come in. [23:45:42] right, I'll want to check both [23:46:26] Both? Are we allowing SmashPig to talk to Civi? I thought we decided not to... [23:46:40] I mean both the limbo and the pending queue [23:47:15] That's... right [23:47:44] hrm, pending queue really does seem redundant [23:48:05] While you're mashing data though... the right place to add that is in the CRM consumer, I think. [23:48:07] i guess it's nice to know whether we've heard anything back at all [23:48:51] OK, I agree that the listener should just toss messages in the queue, and that the consumer should meld the data [23:48:56] It would be much simpler if we were just streaming everything we got back to the CRM... But I guess we can't patch together limbo stuff at that point :( [23:49:08] Software is evil [23:49:38] CRM can read from the limbo and pending queues, right? [23:49:50] no... limbo is only available on the cluster [23:50:05] oh phooey [23:50:09] I'm making sure of that right now :) [23:50:21] wait, how about the listener box? [23:50:37] yeeeah, that's an issue [23:51:06] If we need, it's okay to spew a second copy of that stuff back out of the payments cluster. [23:51:22] We just want to avoid persisting it unless it's a real donation. [23:51:54] so use the pending queue instead of the limbo queue when we send the donor to AP [23:52:10] in case they never make it back to the TY page [23:52:39] then the listener drops a sparse message in the donation queue [23:53:01] and when the consumer sees tons of data missing, it checks the pending queue for the rest [23:53:23] Do you want to send a sparse or full message back from the payments completion page? [23:53:41] might as well send a full message back at that point [23:53:55] ...and delete any pending message [23:53:58] sure, then we need to send the data to both pending and limbo [23:54:18] in this situation, isn't limbo redundant? [23:54:47] we aren't allowed to read from the external queue server from frack, nbd [23:55:14] we can blindly issue a delete though, right? [23:58:49] yeah sure, but stomp doesn't support that... [23:59:03] We can just rely on an expiry I suppose [23:59:11] ah, ok