[16:36:28] Fundraising-Backlog: Change domain for fundraising email - https://phabricator.wikimedia.org/T103123#1382884 (CCogdill_WMF) NEW [16:37:18] Fundraising-Backlog: Change domain for fundraising email - https://phabricator.wikimedia.org/T103123#1382894 (CCogdill_WMF) [17:24:13] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219250 (owner: Ejegg) [17:26:42] awight: buildkit works fine for me locally with 7.38, and I still don't see how the upgrade would change module enablement that way. [17:26:59] what a freakshow [17:27:06] drush -v or even -d doesn't provide enough output to help [17:27:25] at a loss - any ideas? [17:27:33] I think I usually specify "-v -v", I forget what that means for debug level though [17:27:47] ohh, lemme try that and see what it spits out [17:27:48] I'm sort of okay accepting this evil [17:28:14] just cos there's absolutely no reason not to renumber our migrations +1000 [17:28:32] This is _with_ the renumbered migrations :( [17:28:51] what is broken? [17:29:06] cwdent: https://gerrit.wikimedia.org/r/219250/ [17:29:19] drupal 7.38 migration breaks civibuild [17:29:21] wat. [17:29:49] awight: you merged that yesterday - wouldn't a recheck get the latest from the crm repo? [17:30:00] dang [17:30:19] I was just about to say... the way zuul chooses which tree-ish to check out is not entirely wholesome. [17:30:42] hmm, lemme double check [17:30:46] (PS1) Glaisher: Initialize empty $filtered array in SpecialGlobalAllocation::filterCampaigns [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/219403 [17:32:49] ejegg: It's a whole rabbit warren, but you could edit the job definition in Jenkins, remove the rm -rf $WORKSPACE cleanup step, manually build, then log into the CI node servicing the job and inspect the crm/ checkout to see if it's got the new 7xxx numbering [17:33:21] oof. I guess I could... [17:33:34] lemme try... [17:33:37] it's fun :p [17:33:37] job def in jenkins is where again? zuul/jjb? [17:33:47] Naw edit it right in the UI [17:33:50] teach me to fish? [17:33:58] https://integration.wikimedia.org/ci/ [17:34:04] sorry man [17:34:45] WMF tab [17:34:46] thanks! In the config... [17:35:05] oh, not project config, because of jjb [17:35:14] login is your LDAP creds [17:35:24] yeah, in the config [17:35:33] u gotta log in to see it [17:36:12] Uh, oh, I don't see it [17:36:21] post-build actions? [17:36:27] k. https://integration.wikimedia.org/ci/view/WMF/job/wikimedia-fundraising-civicrm/configure [17:36:28] yeah, logged in [17:36:29] I think so [17:36:47] hmm, no rm $WORKSPACE there [17:37:01] I think it's a "publisher", which runs even if the build fails [17:37:10] not the 'discard old builds' checkbox? [17:38:14] Asking in -releng... [17:58:14] K4-713: that potty ball is an unbelievable hit... [17:58:19] Couldn't have been better timing. [17:58:23] YAY [17:58:36] I knew that thing had a proper home. [18:02:44] Ugh. The problem with getting up at 5:30 in the morning, is... [18:02:48] Wait. [18:03:22] All the current problems are that. [18:03:49] That was my bedtime. Argh, friend came by with an unusual car, coil wire totally shredded by the headlight cam mechanism. [18:04:42] wut [18:05:08] I'm guessing that was before 5:30 then. [18:07:29] He had limped it over here with a pocketknife and a bunch of tape, crimped some leftover jagged metal around the wire... [18:11:36] ejegg: Rabbitholes r us [18:22:13] where is the db 'donations' supposed to come from? [18:24:01] cwdent: Hrm, it's the db that contains contribution_tracking [18:24:19] Probably, the only well-supported configuration is if you set that to the same as the drupal default db [18:25:34] oh, ok, my local civi complains about $db->push('donations') in tracking.inc [18:25:44] i've been hunting for the config option but can't find it [18:26:16] also learning to use xdebug in vim which makes me dizzy [18:27:56] i have the drupal db and everything [18:28:02] does it map to the name donations somewhere? [18:30:24] cwdent: oof. This is serious undocumented evil fu [18:31:11] Add a line like, $databases['donations'] = $databases['default']; to settings.php [18:31:20] heh well i was hoping it wasn't something simple cause i've been messing with it for awhile [18:31:30] i'm guessing it's a result of setting up civi mostly manually [18:31:38] i must have missed something [18:32:10] Nah, there is so much stuff we need to document about crm/ [18:32:27] You'll also need require_once __DIR__ . '/../../vendor/autoload.php'; [18:32:32] yuuck [18:33:13] in sites/default/settings.php? [18:35:20] cwdent: yep [18:43:52] xdebug sure makes me appreciate the sheer number of calls involved in firing up drupal [18:44:21] grossss [18:50:02] drupal_bootstrap_kitchen_sink [18:50:55] At least global functions don't have access restrictions which would be totally effed if possible [18:54:30] (PS2) Awight: Initialize empty $filtered array in SpecialGlobalAllocation::filterCampaigns [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/219403 (owner: Glaisher) [18:54:38] (CR) Awight: [C: 2] "Thanks!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/219403 (owner: Glaisher) [18:55:31] (Merged) jenkins-bot: Initialize empty $filtered array in SpecialGlobalAllocation::filterCampaigns [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/219403 (owner: Glaisher) [18:56:09] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219250 (owner: Ejegg) [19:22:42] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Fail hard when assigning to a custom field that doesn't exist - https://phabricator.wikimedia.org/T103162#1383642 (awight) NEW [19:31:10] ejegg: Crazy idea? https://issues.civicrm.org/jira/browse/CRM-16726 [19:34:44] awight: that ticket you just made, could it have anything to do with this error i'm getting when trying to post a refund? The custom field Restrictions is corrupt. Please delete and re-build the field [19:35:05] it looks like it's failing to select the parent row, but i'm looking in the db and the row is there [19:38:45] awight: I like that idea - maybe just an import / export custom field config button & api call [19:40:53] (PS8) Awight: WIP Test and fix all fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 [19:40:55] (PS2) Awight: Make WmfImportFile the default offline import format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219224 (https://phabricator.wikimedia.org/T88836) [19:40:57] (PS8) Awight: Write test for contact_groups import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217989 [19:40:59] (PS5) Awight: Use RAII for fixtures [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218438 [19:41:01] (PS11) Awight: Import organization contact name and title [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/217990 [19:41:03] (PS1) Awight: Add and fix migrations for legacy custom fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219436 [19:41:05] (PS1) Awight: Correct custom field mapping for letter_code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219437 (https://phabricator.wikimedia.org/T88836) [19:41:07] (PS1) Awight: Iterate offline keying template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219438 [19:41:37] (CR) jenkins-bot: [V: -1] WIP Test and fix all fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 (owner: Awight) [19:43:52] cwdent: Haven't seen that failure yet! The string is coming from civicrm/CRM/Core/BAO/CustomQuery.php fwiw [19:44:11] oooh [19:44:47] I think I see what happened, it's got a list of options, maybe those were not created [19:44:58] checking to see if it migrates correctly on my local instance [19:47:21] cwdent: confirmed the bug [19:47:56] now those custom fields, is that the option_group thing? [19:48:07] or no, that's civi? [19:48:25] ejegg: Did you drop the wmf_contribution_extra table before you ran the migration locally? [19:48:45] cwdent: It's all in Civi, but we write migrations that use the Civi API to create the stuff. [19:49:03] In this case, my migration didn't correctly wire the "option group" (multiple choice list) to the custom field. [19:49:31] Fixing now... [19:49:49] whew [19:56:57] awight: I was trying with a whole new table [19:57:15] just hacked a line into the custom group creation form to set table_name before calling create [19:57:32] and it used the table_name I gave it just fine [19:57:38] (PS2) AndyRussG: Merge branch 'master' into campaign_mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/219120 [19:58:50] That would be nice to upstream one day... [19:58:56] * AndyRussG waves [19:59:01] Um. I'm slightly out of ideas [19:59:40] ejegg: The job is passing all like hell for the crm/ repo itself..... [19:59:50] "Programmer seeks +2. Cash paid up front. https://gerrit.wikimedia.org/r/#/c/219120/ " [19:59:51] AndyRussG: hey! [20:00:00] ;) [20:00:43] just for kicks, i'm gonna abandon the patch and resubmit [20:00:44] hot. no strings attached [20:01:35] (PS26) AndyRussG: Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) [20:02:12] (CR) AndyRussG: "Rebased" [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [20:02:22] (CR) jenkins-bot: [V: -1] Campaign-associated mixins [extensions/CentralNotice] (campaign_mixins) - https://gerrit.wikimedia.org/r/202310 (https://phabricator.wikimedia.org/T90915) (owner: AndyRussG) [20:02:27] rrrrrrrrg [20:03:51] (Abandoned) Ejegg: Upgrade to Drupal 7.38 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219250 (owner: Ejegg) [20:03:51] (PS1) Ejegg: Upgrade to Drupal 7.38 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) [20:03:51] (CR) jenkins-bot: [V: -1] Upgrade to Drupal 7.38 upstream [wikimedia/fundraising/crm/drupal] (contrib) - https://gerrit.wikimedia.org/r/219443 (https://phabricator.wikimedia.org/T103006) (owner: Ejegg) [20:25:29] awight: oh hey, the checked-out version of crm/civicrm is really old [20:25:50] like, from last october [20:28:26] ejegg: on the CI box? [20:28:31] waoow [20:28:31] yep [20:28:36] That is really really bad [20:28:44] Thanks for tracking this down! [20:28:51] and sudo says i'm forbidden to run rm -rf for some reason... [20:29:40] odder still, the civicrm dir is detached from master, but the version of master there is only one patch behind gerrit [20:30:27] this has certainly been a learning experience. Looking for docs on jjb zuul-cloner task [20:33:17] ooh that permission issue would explain how we got here [20:34:43] it looked more like a sudo command filter than file permissions [20:35:15] Sorry, user ejegg is not allowed to execute '/bin/rm -rf civicrm/' as root on integration-slave-trusty-1014.integration.eqiad.wmflabs. [20:39:02] ejegg: oh hehe. 'sudo su -' [20:43:28] awight: where was that drush command to install all the modules again? civi buildkit? [20:43:51] yeah, civibuildkit/app/config/wmff/install.shj [20:43:56] ^j^ [20:45:27] thanks! was this pre puppet installer? [20:45:48] Sort of simultaneous. I know, it's duplicated effort [20:45:56] We did not architect this tool [20:46:08] It's written by a rad Civi core guy, Tim Otten [20:46:14] You should meet him. [20:46:29] aah cool, just some overlap [20:47:04] cwdent: The more we talk though, you're almost convincing me it'd be worth the small trouble to fix up some little details in civibuildkit to make it appropriate for running under puppet. [20:47:41] hmmm, i like the sound of that [20:48:04] just call the build kit from puppet, instead of reinventing stuff [20:48:09] ehh, i'll sort it out monday. have a great weekend all! [20:48:19] later ejegg! [20:48:58] bye! [20:53:33] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Port crm mw-vagrant to rely more on civicrm-buildkit - https://phabricator.wikimedia.org/T103180#1383927 (awight) NEW [20:53:47] cwdent: ^ if you have more to say [20:54:23] cool yeah, if you want my help with that i'd be happy to [20:57:43] Fundraising Tech Backlog, Documentation: Define code style conventions for fundraising repos - https://phabricator.wikimedia.org/T103181#1383934 (awight) NEW [21:43:46] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Write migration for Campaign options and custom groups - https://phabricator.wikimedia.org/T103187#1384085 (awight) [21:45:06] awight: http://squiggle.city/~casey/ [21:45:32] consistent history across terminals [21:45:40] but doesn't ruin up arrow [21:46:35] (PS1) Awight: WIP Migration for Restrictions options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 [21:46:47] cwdent: Sorry, this doesn't quite work for me ^^ [21:47:03] (CR) jenkins-bot: [V: -1] WIP Migration for Restrictions options [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219480 (owner: Awight) [21:47:12] I need to switch to the Rosie thing for another few hours, then I can get back to it, if not already solved [21:47:54] Either way, if you run that migration and then link the civicrm_custom_field.option_group_id to the created group by hand, I can help, you'll be unblocked on the other stuff I hope [21:48:08] np! i'll see if i can figure out what's going on there [21:48:19] sure, that would be great! [22:05:58] (PS9) Awight: WIP Test and fix all fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 [22:06:00] (PS2) Awight: Iterate offline keying template [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219438 [22:06:02] (PS2) Awight: Remove fictitious letter_code field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219437 [22:06:41] (CR) jenkins-bot: [V: -1] WIP Test and fix all fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 (owner: Awight) [22:16:59] (PS10) Awight: Test and fix more fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 [22:17:43] (PS11) Awight: Test more fields used by WmfImportFile format [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/218567 [22:24:13] Awww nuts, we don't have any more opsen for the day? [22:25:49] ejegg|away: If you happen to go by a computer, can you chmod g+w(s) stuff in lutetium:/srv/org.wikimedia.civicrm ? [22:32:43] awight: would you mind just giving me the 10000ft view of what's going on here? looks like contribution->get() in mark_refund bails, but the contribution id looks right. how does the restrictions group factor in to that? [22:34:13] There's a bunch of stuff that gets set on contributions, probably even if it's null, and something in there is asserting that your contribution custom fields are valid. Which they are not. [22:37:08] awight: and those custom fields map to things in option_group/value? and they are modeled by the api? [22:37:37] awight: just chmodded as many files as I could over on lutetium [22:37:56] (in that dir) [22:39:09] cwdent: yes! [22:39:48] cwdent: If you run that migration, it should get to the very last step, which is "update civicrm_custom_field set option_group_id=NN" [22:40:07] which you then have to run by hand [22:40:15] aaah, so the getter knows to bail if the constraint isn't met [22:40:22] I guess so [22:40:31] cool! that helps a ton [22:40:38] Hopefully that's the issue. [22:41:02] ejegg|away: Thanks! Ignore me now, it's just a staging deployment [22:41:59] ejegg|away: woot, that worked! [23:04:27] awight: is there a drush command to run the migration? [23:05:20] (PS1) Awight: Passthrough more payment types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219492 (https://phabricator.wikimedia.org/T88836) [23:05:22] (PS1) Awight: Drop "Amount (USD)" column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219493 (https://phabricator.wikimedia.org/T88836) [23:05:23] cwdent: "drush -v -v updatedb -y" [23:05:57] thanks! [23:06:02] (PS2) Awight: Passthrough more payment types [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219492 (https://phabricator.wikimedia.org/T88836) [23:06:07] (PS2) Awight: Drop "Amount (USD)" column [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219493 (https://phabricator.wikimedia.org/T88836) [23:08:42] cwdent: I have some time to finish that migration now, but it's idempotent so don't wait for me... [23:08:56] Should be able to fix up an already existing custom field. [23:09:16] cool, if you want to, or i'm happy to try [23:09:23] yah here i go [23:09:24] but it's getting dangerously close to dinner time [23:09:31] better idea! [23:09:45] Don't accidentally bite the hand that taunts you :p [23:10:11] i think i skipped lunch so that will be good to remember [23:10:38] plus, it's a friday night in the high desert [23:11:16] camping in the mountains this weekend [23:11:18] get out of the heat [23:11:46] Sounds great! Say hi to the stars for me [23:11:48] been a long time [23:14:08] i cherry picked that migration onto my detached head [23:14:10] nasty [23:14:52] but i'll say the gerrit workflow is less outrageous than i thought at first [23:19:15] (PS1) Awight: Only delete option groups that exist [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/219495 [23:24:18] (PS1) Awight: Update Civi to pick up fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219498 [23:25:00] cwdent: With that patch, the migration can finish the job ^ [23:25:37] does it need the other one too? [23:30:18] (PS2) Awight: Update Civi to pick up fix [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/219498 [23:30:19] ohwait i get it [23:32:46] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Fix unclear Civi import error message - https://phabricator.wikimedia.org/T103199#1384368 (awight) NEW [23:33:53] Fundraising Tech Backlog, Wikimedia-Fundraising-CiviCRM: Fix unclear Civi import error message - https://phabricator.wikimedia.org/T103199#1384380 (awight) [23:35:57] Fundraising Sprint Lou Reed, Fundraising Sprint Miles Davis, Wikimedia-Fundraising-CiviCRM: Recent Engage Import - Contribution Type = Cash when it should be Engage - https://phabricator.wikimedia.org/T100853#1384384 (awight) [23:46:14] awight: i still get the message about The custom field Restrictions is corrupt...was there anything to do besides run that migration? [23:46:46] do i need to insert some other data for that custom field? Restrictions [23:49:39] i'll dig into it monday. have a good weekend! [23:53:07] Was civicrm_custom_group.option_group_id updated for that group? [23:53:21] Did u happen to run the migration again after the civicrm submodule bump? [23:55:33] cwdent|afk: for the backlog, [23:57:23] http://civi.deb/civicrm/admin/custom/group/field should have a "Restrictions" field and an action link "Edit Multiple Choice Options", that links to a page like http://civi.dev/civicrm/admin/custom/group/field/option?reset=1&action=browse&gid=&fid=26 [23:57:53] If that works, then you are good to go.